Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
* bump version to 4.1.1-rc
* fix code to run kbn bootstrap
* fix errors
* DO NOT MERGE. mute errors and ping teams to fix them
* Address EuiSelectableProps configuration in discover sidebar
* use explicit type for EuiSelectable
* update to ts v4.1.2
* fix ts error in EuiSelectable
* update docs
* update prettier with ts version support
* Revert "update prettier with ts version support"
This reverts commit 3de48db3ec.
* address another new problem
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
* fix flaky test and re-enable it
* wait for table to load before to perform operations
* move everything out of ciGroup2 for flaky test runner
* add debug block for flaky runner
* use correct vis name
* remove test sync
* Revert "move everything out of ciGroup2 for flaky test runner"
This reverts commit db86c3b5
* add tag selector to save modal
* save tag references onSave
* populate tags when unwrapping attributes
* tslint
* update listing page to show tags
* fix data-test-subj id in functional tests
* i18n cleanup
* tslint
* remove unused import
* use listingTable service for functional tests
* tslint and fix mvt grid layer functional test
* review feedback
* add tags to all privileges and add test user to find, delete, get, get_all, and update tests
* move functions to module scope
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Visualizations] New vis wizard
* Update functional tests
* Create oss plugins for maps and lens and unregister alias function
* Add new plugins to .i18nrc.json
* Add readme and codeowners to the new plugins
* update docs
* fix tests
* fix types
* fixes
* Update development docs
* fix oss functional tests
* Fix jest and x-pack functional tests
* Fix functional test
* changes on the layout
* Cleanup and responsiveness
* cleanup unecessary code
* add common folder to the new OSS plugins
* remove unecessary translations
* Update limits.yml file
* Fix basic label
* Add experimental badge on controls vis
* Nice improvements
* fixes
* Improving styles
* Making modal go full height on smaller screens
* Fixing sass lint warning
* fix lint error
* fix internationalization error
* PR fixes
* PR changes
* Use useCallback where possible
* Remove translations that need to be translated again
* Lazy Load wizard modal
* Remove legacyMapVisualizationWarning
* Import the OSS plugins constants from the plugins
* Export constant from lensOss
* Change the new oss plugins from OSS to Oss
* Add a new line to the kibana.json files of the new plugins
* New nit fix
* Fix spaces
* Change the texts for the first step of the modal
* Fix test
* Fixes some of the PR comments
* Add onClick funtionality to the entire aggregation based card
* Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss
* Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled
* fix eslint error
* Change groupTitles and descriptions
* Change input vis description
* Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint
* Make the disabled cards badge clickable
* Changes from code review
* Fix functional tests failures
* Rename groupTitle to titleInWizard to be more specific
* Change vega vis note
* minor design changes
* fix problem with plugins list docs
* Retrieve maps and lens landing page from docs service and add tracking url param
* Fix funtional test for the new dashboard flow
* Fix logic in alias registry for removing the discardOnRegister alias
* no need to remove the alias entry from the discardOnRegister array
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
This PR adds screenshot comparison tests for the nodes in the graph on the test plugin.
Run the tests using this command:
`yarn test:ftr --config x-pack/test/plugin_functional/config.ts --grep Resolver`
* create xpack plugin skeleton, start to implement management section
* add tag creation modal
* first implementation of the tags table
* use InMemoryTable
* add edit modal and delete action
* update plugin list
* add tag list, fix types
* add capabilities check on client-side
* add tag combo box component
* add missing i18n keys
* fix privilege FTR tests
* add base structure for FTR tests
* fix feature ftr test
* use string literals for i18n
* create savedObjectsTaggingOss plugin, move API types to oss plugin, start to wire to SO management page.
* update plugin list
* fix types
* allow to use `_find` with multiple references
* add FTR test for _find API on references fields
* add _find integration tests
* update generated doc
* start to implement tag filtering on SO management section
* update generated docs
* wire tagging API to dashboard listing page
* fix i18n namespace
* fix type & tests
* update dashboard listing snapshots
* adapt FTR listingTable service to search for parsable queries
* wite tagging API to visualize listing
* update tagging plugin limits
* add server-side and client-side validation for tag create/edit
* rename title field to name
* fix types
* fix types bis
* add removeReferencesTo API to SOR/SOC
* update generated doc
* add server-side unit test for `savedObjectsTagging` plugin
* move tagging API types to its own file
* add savedObjectsTaggingOss mock
* add tags_cache tests
* add tests for client-side tag client
* extract uiApi to distinct files
* various API improvements
* add more tests
* add link between tag and so management sections + add connection counts
* add base functional test suite for tagging
* add more FTR tests
* improve feature control func test
* update codeowners
* update generated doc
* fix access to proxy modal
* adapt SO save modal to allow to add tag field
* add SO decorator registry and tag implementation
* add unit tests for SO tag decorator
* add functional tests for visualize integration
* add tag SO read permission for vis/dash feature
* add RBAC api integ tests
* add API integration tests
* add test for getTagConnectionsUrl
* add SOM test suite
* add dashboard integration suite
* remove test line
* add missing unit tests
* improve API types doc
* fix create modal save button label
* remove console.log
* improve doc
* self review
* add refresh interval for tag cache
* improve page object doc
* minor cleanup
* address review comments
* small layout fixes
* add initial focus
* use lazy accessor for tag request handler context
* adapt SOM export and export route to handle references
* remove icon from feature config due to master changes
* fix SO table tests
* update generated docs
* sort tags by name in filter dropdown and listing component
* wire SO tagging to dashboard save modal
* fix types
* - add 'create tag' action in tag selector
- add notifications on update/create/delete from management
- delete modal wording
* add description max length validation
* remove real-time validation
* fix i18n bundle id
* update expected size of savedObjectsTagging plugin
* use own useIfMounted
* update limit again, contract components cannot be lazy loaded atm.
* math is hard
* remove single usage of lodash for bundle size
* add async imports for create/edit modal
* add FTR test for 'create tag' action from tag selector
* allow 'create new' option to prepopulate name field
* extract savedObjectToTag
* add advancedSettings read user for security api_integ suite
* add audit login for security client wrapper
* use import type when possible
* wire SO tagging to lens visualization
* fix lens jest test
* Fix `create tag` option being selected when closing the selector dropdown
* add sorting to tag column from getTableColumnDef
* address some of restrry comments
* rename tag selector's setSelected option to onTagsSelected
* fix audit logging even type for saved_object_remove_references
* update plugin size limit to current size
* adapt maxlength validation wording
* remove selection column until we have batch action menu
* remove connections link when user lack read privilege to savedObjectManagement
* forbid registering multiple SO decorators with the same priority
* add so decorator test
* extract getTagFindReferences and create API mock
* update audit-logging ascidoc
* doc nit
* throw conflict error if update returns any failure
* use refresh=true as default
* wording nits
* export: rename `references` to `hasReference`
* update generated doc
* set description max length to 100
* do not initialize tag cache on anonymous pages
* split fetchObjectsToExport into two distinct functions
* change tag client `delete` call order
* tsdoc nits
* more nits
* add README for oss plugin
* add oss plugin start tests
* SavedObject.find: rename `references` to `hasReference`
* change section description label
* remove url prefix constants
* last nits and comments
* update generated doc
* Add a session service and use it in discover and dashboard
* check unefined
* Start session in visualize
* Fix tests
* docs
* OSS error alignemnt
* Adjust error messages in xpack
* Add getErrorMessage
* Use showError in vizualize
Add original error to expression exception
* Cleanup
* ts, doc and i18n fixes
* Fix jest tests
* Fix functional test
* functional test
* ts
* Update functional tests
* Add unit tests to interceptor and timeout error
* expose toasts test function
* doc
* typos
* lint
* Cleanup
* review 1
* Code review
* doc
* doc fix
* visualization type fix
* fix jest
* Fix xpack functional test
* fix xpack test
* code review
* Add tracking methods to session service
* remove chromium
* Fix ts and jest tests
* jest + docs
* ts fix
* siem test
* Use session service to show a timeout notification per session + more unit tests
* ts and docs
* Remove session service from search source (not needed)
* Code review
* ts
* Single active session in FE session service
* Cleanup
* Don't integrate with dashboard \ visualize
Add functional tests for session toast plugin
* Typescript
* ts
* Improve functional tests
* es
* simplify filter test
* wait until loadedw
* filter test
* delete crypto for now
* Select the correct index 🤦
* timerange
* Adjust functional test logic
* improved test format @dosant
* Handle exceptions
* Don't close sessions automatically, warn instead
* jest
* Adjust functional test
* Remove unused code
* delete export
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* feat: 🎸 add grouping to presentable interface
* feat: 🎸 add group to "Explore underlying" data action
* refactor: 💡 return panel list and simplify context creation
* refactor: 💡 simplify context menu builder code
* refactor: 💡 further simplify context menu builder code
* feat: 🎸 add grouping to context menu builder
* feat: 🎸 add icon to drilldowns group
* fix: 🐛 sort in the other order
* feat: 🎸 group drilldown actions in edit mode
* fix: 🐛 fix TypeScript error
* feat: 🎸 wrap long context menu list into a submenu
* feat: 🎸 improve context menu long list wrapping
* feat: 🎸 display drilldowns panel at the bottom of main panel
* feat: 🎸 add separator line for context menu
* test: 💍 add basic context menu builder unit tests
* feat: 🎸 remove meta decoratiosn from generated menu
* test: 💍 add test subject attribute to "More" menu item
* chore: 🤖 remove separator line and add comment about EUI
* test: 💍 update Jest snapshots
* chore: 🤖 revert back change of showing both drilldown options
* test: 💍 add context menu samples to example plugin
* feat: 🎸 collapse long groups into a sub-panel
* test: 💍 add context menu panel edit mode examples
* test: 💍 fix OSS functional test
* test: 💍 fix X-Pack functional tests
* fix: 🐛 re-introduce item sorting by title
* test: 💍 allow explicitly opening more menu
* test: 💍 try opening more panel in functional tests
* test: 💍 disable some tests
* chore: 🤖 remove unused code
* test: 💍 use action test helper in unit tests
* refactor: 💡 add helper utility to generate actions in examples
* test: 💍 disable one more functional test
* test: 💍 improve how inspector is opened in functional tests
* test: 💍 enable functional test
* refactor: 💡 convert test suite to typescript
* test: 💍 move panel replace tests into a separate test suite
* test: 💍 move panel cloning tests to a separate test suite
* test: 💍 set up dashboard context menu test suite
* test: 💍 enable few panel context menu tests
* test: 💍 enable saved search panel tests
* test: 💍 enable expanded panel context menu tests
* test: 💍 remove render complete awaits
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Moves common utility functions to obtain the repository root,
paths (config/data), and Kibana package.json to a @kbn/utils package.
Moving these existing functions allows them to be used in production, in
other packages because of Kibana.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* pass originatingApp into App
* save and return top nav option
* clean up
* navigate to originating app
* functional test
* tslint
* cutOriginatingAppConnection
* add functional test for cutting originating app flow
* one more fix for cutting originator app and another functional test to verify
* typo
* review feedback
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Rename kibana_breadcrumbs to kibana_chrome
- in anticipation of upcoming refactor where SetPageChrome now handles document title as well as Kibana breadcrumbs
+ cleanup exports
* Add generate_title helpers
- will be used by new set_chrome helper
* Add setDocTitle context + behavior to set_chrome
+ refactor set_chrome.test.tsx:
- add title tests
- add SetWorkplaceSearchChrome test to increase coverage
- clean up inner/outer call in favor of simpler mocks/imports
- simplify isRoot tests
* Update plugins to set product titles
- on mount but before render
* Copy feedback - change pipe separator to hyphen
- to match ' - Elastic'
* Add functional tests confirming that document titles updated
Fixes#71461 regression since 7.7
New state syncing utils didn't properly handle errors,
Errors happening during URL parsing or writing wasn't handled, so state syncing could stop or in worth case blow out. (see #71461)
There are not much scenarios where missing proper error handling could really impact users, except the one described in #71461:
Kibana users state:storeInSessionStorage
Users often intuitively share hashed dashboard urls directly
When someone opens those urls - there is a blank screen with warning
In 7.6 - dashboard would still load with default state.
Since 7.7 these still could be achieved by removing query params for URL, but it is not obvious for regular users.
This PR makes sure that behaviour is similar to one we had before 7.7.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [ftr/webdriver] retry on all errors, use Rx so that timers are canceled
* throw if attemptToCreateCommand() aborts by resolving to undefined
Co-authored-by: spalger <spalger@users.noreply.github.com>