Commit graph

47093 commits

Author SHA1 Message Date
Marco Liberati aad477185d
[Lens] Keep the custom label when transitioning to/from Formula (#114270)
* 🐛 Keep the custom label when transitioning to/from Formula

* 🐛 Fix transition bug with padding

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-13 10:08:08 +02:00
Ashokaditya 1d71d42a7b
[Security Solution][Endpoint] Host Isolation API changes (#113621)
* Use the new data stream (if exists) to write action request to
and then the fleet index. Else do as usual.

fixes elastic/security-team/issues/1704

* fix legacy tests

* add relevant additional tests

* remove duplicate test

* update tests

* cleanup

review changes
refs elastic/security-team/issues/1704

* fix lint

* Use correct mapping keys when writing to index

* write record on new index when action request fails to write to `.fleet-actions`

review comments

* better error message

review comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-13 09:25:20 +02:00
Oliver Gupte 3d75154368
[APM] Removes the apm_oss plugin and deprecates related configs (#113364)
* [APM] Removes the apm_oss plugin and deprecates related configs (#108160)

* removes commented lines

* fixes typescript errors

* performs start up migration on the saved objects mapping for apm-indices

* removes all references to the deprecated apm_oss.* config paths in APM

* fixes missing bundle error

* fixes type error

* fixes eslint error with disabled rules

* fixes saved object mappings for es_archvices for tests

* fixes eslint error

* Updates default index values to include the more general apm-*. Fixes broken tests.

* removing unused configs from the config path migration: apm_oss.indexPattern and apm_oss.fleetMode

* - replaces full index configuration paths with references in the `xpack.apm.indices` namespace
- removes mergeConfig function and test

* fixes proxy mock object in unit test

* fixes linting issues

* PR feedback and failed test

* changes the configs at `xpack.apm.indices.*` from plural to singular to match `processor.event` values
2021-10-13 03:16:21 -04:00
Jen Huang 935ba166f9
[Fleet] Show security requirements page when ES security is not enabled (#114583)
* Show security requirements page when ES security is not enabled

* Add comments
2021-10-13 02:48:00 -04:00
Tyler Smalley e7ce0616b6 skip flaky suite (#113697) 2021-10-12 21:45:58 -07:00
Thomas Watson 06be96cfb3
Bump refractor from v3.4.0 to v3.5.0 (#114654) 2021-10-12 22:08:04 -04:00
Tiago Costa ad9c1588e6
chore(NA): improve kbn-ui-shared-deps-npm split (#114557)
* chore(NA): remove elastic-datemath from kbn-ui-shared-deps-npm

* chore(NA): remove @kbn deps on kbn ui shared deps npm

* chore(NA): missing peer dep to build kbn ui shared deps npm

* chore(NA): general improvements for kbn ui shared deps npm

* chore(NA): remove min size chunks plugin

* chore(NA): remove split chunks

* chore(NA): improve dep declaring on kbn-ui-shared-deps-src

* chore(NA): remove typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-13 02:50:49 +01:00
Scotty Bollinger 3025942e1c
[Workplace Search] Wire up write view for Blocked windows (#114696)
* Fix unsaved changes prompt showing up between tabs

We already added a reducer for this but forgot to implement this. Because we have shared state between the tabs, we need to overrule the unsaved changes prompt when simply navigating between tabs.

* Fix some timezone issues

After wiring up the backend and converting to UTC, some changes to mocks and time formats had to be made.

* Refactor to remove blockedWindows reducer

This commit refactors to make use of the already-in-state schedule object. Previously, while wiring up the static views, I used a blockedWindows array directly on the state tree. This simplifies things so that equality checks can be done with one object.

* Wire up ability to remove blocked window

* Fix key and remove fallback

It was hard to test removing an item from an array that doesn’t exist so I changed the code to expect the array to be present (! operator), since the other path is not possible.

Also updated the server value from deletion to delete to match the API

* Wire up blocked windows form to change values and update state

* Pass formatted blocked_windows to server

(test was covered in previous commit)

* Update link text, hrefs, and replace temp copy

One of the links was removed intentionally

* Fix typo

* Fix edge case where unsaved changes shown when removing last item

The API omits the key when there are no items so we need to have the item removed as well in the UI state. Otherwise, removing the last item will cause the UI to say there are unsaved changes when there are not.

I tried setting  it as:

schedule.blockedWindows = undefined

but the selector did not see those as equal but deleting the key does.

* More typo fixes

Syncronization -> Synchronization (+h)

* Fix link address

* Refactor for simplicity

Was unable to figure out the TypeScript  but did some more digging
2021-10-12 21:32:08 -04:00
Tyler Smalley 690c25112c
[ci-metrics] Use git rev-parse for branch (#114736)
--show-current was added in 2.22, which is still relatively new.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-12 21:17:01 -04:00
Sandra G c3b9e813c9
add loading state to nodes table (#114709)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 21:07:06 -04:00
Søren Louv-Jansen 169df02635
[APM] Improve readability of APM readme (#114633) 2021-10-12 20:34:13 -04:00
Thiago Souza fb4414786f
[Security Solution][Telemetry] Refactoring security telemetry task code (#114095)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 19:54:18 -04:00
Lukas Olson a070aafe93
Deprecate search:includeFrozen parameter (#114578) 2021-10-12 15:35:49 -07:00
renovate[bot] 3a8eb8a6e4
Update dependency core-js to ^3.18.3 (master) (#114720)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
2021-10-12 18:25:56 -04:00
Bree Hall a51545ecc3
Bumping EUI to 39.0.0 (#113633)
* Upgraded the version of EUI to 38.2.0 from 38.0.1

* Updated the i18n mappings required for EUI v.38.2.0

* Update i18n snapshots and resolve linting error

* Removed html_id_generator mocks.

Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts

* Resolve linting error in i18n mapping file

* Removed html_id_generator mocks.

Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts

* Update plugin snapshots

* Resolve merge conflict in license_checker config.ts file

* Upgrade EUI to version 39.0.0 from the original target (38.2.0) to handle an issue found with a functional test during the original upgrade

* Updated the i18n mapping for EUI v.39.0.0

* Update various snapshots to account for the an i18n translation token addition in EUI v. 39.0.0

* Updated test cases marked as obsolete by CI

* Update src/dev/license_checker/config.ts

Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed.

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
2021-10-12 17:11:04 -04:00
Tim Sullivan 636581ac26
[Reporting/Docs] remove note about host name set to "0" (#114710) 2021-10-12 14:04:41 -07:00
Tyler Smalley 7290b6936a
[ci] Updates APM server (#114588)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-12 13:58:12 -07:00
Kyle Pollich d014729ae2
Add APM and Synthetics to auto update package list (#114641) 2021-10-12 16:25:23 -04:00
Thomas Neirynck 1afac0ffbb
[Fleet] Have EPR register new categories / Show category counts (#114429) 2021-10-12 16:13:58 -04:00
Tim Sullivan 3c8662f9fa
[Reporting] deprecate capture.viewport setting from reporting config as unused (#114019)
* [Reporting] remove capture.viewport setting from reporting config

* update snapshots

* update snapshot

* add helpful version comment

* self-review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 15:42:38 -04:00
renovate[bot] 0de7012bf2
Update polyfills (master) (#114564)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-10-12 14:39:43 -05:00
Nathan Reese 26e1d1dc18
[Maps] fix flaky getTile test (#114689) 2021-10-12 13:23:00 -06:00
Caroline Horn 852634590d
[Design] Tutorial views cleanup (#114186)
* Move copy function to `isCopyable` on EuiCodeBlock
* Using EuiMarkdownFormat for Content
* Using KibanaPageTemplate for not found page
* Using KibanaPageTemplate for tutorial page and splitting into more panels
* Better spacing inside instruction_set
* Rendering Introduction as a EuiPageHeader
* Changed module notice “NOTE” to icon
* Moving tabs to the first set of content in an instructions set; Using EuiSplitPanel
* Changed fields button to a simple link
* Changed button group to wide, text colored, left-aligned set
2021-10-12 15:20:20 -04:00
Catherine Liu 16c049a2d9
[Canvas] Toolbar UI Updates (#113329) 2021-10-12 11:53:40 -07:00
Candace Park d50ec56ed1
[Security Solution][Endpoint][TA] Trusted Apps license downgrade experience (#113048) 2021-10-12 14:47:00 -04:00
Marshall Main 9e908f6caa
[RAC][Security Solution] Refactor persistence and security rule generic types (#114022)
* Refactor persistence and security rule generic types

* Remove unused import, fix unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 14:43:50 -04:00
Vadim Kibana 6a55f87da0
Connect locator persistable state to Short URLs (#114397) 2021-10-12 20:25:08 +02:00
Christos Nasikas 7ffebf1fa3
[Connectors] ServiceNow ITSM & SIR Application (#105440)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 20:58:45 +03:00
Zacqary Adam Xeper 396ed09259
[Monitoring] Fix Set Up Monitoring redirect to setup mode (#114354)
* [Monitoring] Fix Set Up Monitoring redirect to setup mode

* Fix initt setup mode from route init
2021-10-12 13:54:39 -04:00
Kate Farrar b4010c86ad
Move interval help text to be a tooltip on the datepicker (#108761)
* moving interval help text as a tooltip on the datepicker

* [Metrics UI] Refactor Snapshot data for use in FilterBar

Co-authored-by: Chris Cowan <chris@chriscowan.us>
2021-10-12 13:49:25 -04:00
Vadim Kibana e9f0d7b9b4
Short url docs (#113084) 2021-10-12 19:46:58 +02:00
Nicolas Chaulet 0fa95fdfcb
[Fleet] Handle existing default output in preconfiguration output service (#114631) 2021-10-12 13:30:48 -04:00
Scotty Bollinger ec0fdee814
[Workplace Search] Wire up write view for Sync Frequency (#114522)
* Refactor to use correct kea way of doing reset

The listener is not needed as the actions can set the state themselves

* Wire up reset button for Frequency section

* Extract shareble updateServerSettings method

We use a PATCH call to the server to update the state. We can extract this to a shared actions.updateServerSettings method that can be used in the main toggle on the Synchronization landing page, the Frequency section and the Object and assets section.

As a part of this commit, I refactored `updateSyncEnabled` to use this method as well. In doing so, to simplify things, I removed the granular enabled/disabled message in favor of the generic “"Source synchronization settings updated.” message that the other sections use. The state of the toggle is a good enough indication of the state the server is in.

I also renamed the updateSyncSettings method to updateObjectsAndAssetsSettings, as it was incorrectly named.

* Add schema for schedules

* Use mutable schedule in component

Originally used the immutable version directly on the content source for initial read view. We now use a mutable one found in SynchronizationLogic

* Set local copies of schedule after persisting to server

* Wire up form change handlers

We pass the ‘type’ to the component to inform the logic file which section is being changed. We then update the mutable `schedule` reducer with the correct value

* Wire up save button and persist changes

* Add type and make server prop optional

If there are no blciked windows, we send undefined, so the type has been updated.

* Add unsaved changes propmpt

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 12:28:14 -05:00
Dominique Clarke ef8cd680bf
[Uptime] [Synthetics Integration] add new advanced options (#112454)
* refactor common fields

* add ignore_https_errors and journey filters options

* adjust formatters and normalizers

* adjust content and hide fields when zip url is not defined

* adjust content again

* update tests

* adjust tests

* adjust tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 12:39:43 -04:00
Dominique Clarke 80c152c0eb
[Observability] [Exploratory View] add percentile ranks, show legend always, and fix field labels (#113765)
* add percentile ranks, show legend always, and fix field labels

* add 50th percentile

* replace hard coded values with constant

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 12:37:21 -04:00
Devin W. Hurley 103869509c
[Security Solution] [Platform] Utilize SO resolve api for reading rules by id (#112478)
* added outcome to backend routes

* adds so resolved property alias_target_id to response

* adds UI portion

* working URL redirect on aliasMatch - todo -> update rule details page refresh button to use SO resolve.

* cleanup

* fix integration tests

* fix jest tests

* cleanup types

* fix eslint.. I think vs code formatted this

* WIP - undo me, working index.test.ts function

* WIP - also undo me, probably

* working test for aliasMatch, need to add test for outcome = conflict

* add conflict callout when SO resolve yields conflict outcome

* code cleanup

* fix type issues

* small cleanup, fix jest test after undoing changes for getFailingRuleStatus

* cleanup tests

* add alias_target_id to response validation too

* unit test changes

* update tests again

* add all dependencies to useEffect and prefer useMemo

* add type cast

* adds integration tests for different outcomes after mocking a migrated rule leading to an aliasMatch and a migrated rule + accidental inserted rule to lead to a conflict. Also removes the outcome property if it is an exactMatch

* remove unused import

* fix test

* functional WIP

* cleanup

* cleanup

* finishing touches to address PR review comments

* remove console.error

* fix bug where spaces was not typed correctly in the plugin start method here https://github.com/elastic/kibana/pull/113983
2021-10-12 12:12:34 -04:00
Kaarina Tungseth 9594574d65
[DOCS] Reformats the Spaces settings tables into definition lists (#114146) 2021-10-12 11:08:47 -05:00
Kaarina Tungseth 511c085944
[DOCS] Reformats the Search sessions settings tables into definition lists (#114145) 2021-10-12 11:08:02 -05:00
Kaarina Tungseth be0a1e6c00
[DOCS] Reformats the Machine learning settings tables into definition lists (#114143) 2021-10-12 11:07:38 -05:00
Kaarina Tungseth 86af44854c
[DOCS] Reformats the Logs settings tables into definition lists (#114140) 2021-10-12 11:02:41 -05:00
Yara Tercero 2c2b8e388a
[Security Solution][Platform] - Bug fix when loading a saved query in detections (#114347)
Bug in checking === for null when possibility of undefined, added tests.
2021-10-12 11:49:11 -04:00
Pete Hampton 917807e7a3
Telemetry: update security filterlist. (#114495) 2021-10-12 16:32:44 +01:00
Marco Liberati fa69602b34
[Lens] Fix Metric visualization scale (#113956)
* 🐛 Fix metric rescale

* 📸 Restored old snapshots

* 🐛 Extend the fix to all scenarios

* 📸 Refresh snapshots for new fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 17:32:32 +02:00
Zacqary Adam Xeper 435404e961
[Stack Monitoring] Fix blank page between loading page and overview (#114550)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-12 10:23:01 -05:00
Brian Seeders f4ef2b116b
[buildkite] buildkite dependencies need to install before print_agent_links (#114573) 2021-10-12 11:18:13 -04:00
Marco Liberati ba8abc4151
[Vega] Improve error message in case of invalid $schema URL (#114459)
* 🐛 Catch the schema parser and provide a better error message

* 🌐 Add i18n
2021-10-12 16:58:37 +02:00
Shahzad df971b7dc9
[Exploratory view] Render content only on expand (#114237) 2021-10-12 16:46:23 +02:00
Davis Plumlee 0b46bb1b93
[Security Solution][Detection Alerts] Fixes follow-up alert refresh bugs (#112169) 2021-10-12 10:40:54 -04:00
Cristina Amico f50e3f5cce
[Fleet] Fix agent count in update modal (#114622) 2021-10-12 16:36:38 +02:00
Marco Vettorello ff1b014c7b
Update dependency @elastic/charts to v37 (master) (#113968) 2021-10-12 16:36:18 +02:00