Commit graph

46243 commits

Author SHA1 Message Date
Cauê Marcondes 958adc57af
[APM] Bug with Transaction Latency Threshold rule (#111541) 2021-09-08 15:23:52 -04:00
Brian Seeders 3e1e90fd47
[CI] Disable running ES Snapshots pipelines in Jenkins for everything above 6.8 (#111554) 2021-09-08 14:47:08 -04:00
Brian Seeders 7971283bbe
[CI] Buildkite ES Snapshots Pipelines / attempt 2 (#111565) 2021-09-08 14:31:04 -04:00
Candace Park 05495a336b
[Security Solution][Endpoint][TrustedApps][EventFilters] Change add button color (#111218) 2021-09-08 12:22:07 -06:00
Byron Hulcher d03efa227b
Fix logic issues resulting from CrawlerLogic/CrawlerOverviewLogic split (#111564) 2021-09-08 14:13:09 -04:00
Matthias Wilhelm 284bc6663c
[Discover] Cleanup legacy code fragments (#110646) 2021-09-08 19:55:40 +02:00
Andrew Goldstein 99ee803459
[Security Solution] Enable schema-driven sorting descriptions in column headers (#111232)
## Summary

This PR resolves issue <https://github.com/elastic/kibana/issues/110041> reported by @snide to enable schema-driven sorting descriptions in column headers.

@chandlerprall recommends obtaining a **+1** from the Machine Learning and Observability solutions, because the fix updates an `i18n` constant in Kibana common to all consumers of `EuiDataGrid`.

## Details

Thanks @chandlerprall for paring on this!

The Alerts table, `Host > Events`, and other `EuiDataGrid`-based views in the Security Solution make use of the default [`EuiDataGrid` schemas](https://elastic.github.io/eui/#/tabular-content/data-grid-schemas-and-popovers).

The default schemas enable `EuiDataGrid` to automatically display, for example, `Old-New` and `New-Old` sorting descriptions for datetime fields, as opposed to generic `A-Z` and `Z-A` descriptions.

The following (shared) Kibana `i18n` constant in `src/core/public/i18n/i18n_eui_mapping.tsx` is expected to be rendered a `string` at runtime:

```ts
    'euiColumnActions.sort': ({ schemaLabel }: EuiValues) =>
      i18n.translate('core.euiColumnActions.sort', {
        defaultMessage: 'Sort {schemaLabel}',
        values: { schemaLabel },
      }),
```

But the constant was rendered in `EuiDataGrid` column headers as `[object Object]` when schemas were enabled, as shown in the screenshot below:

![column-header-object-object](https://user-images.githubusercontent.com/4459398/132079843-a8b0f5e5-9d47-4816-8baa-e29577511bf1.png)

_Above: The `sortTextAsc/Desc` text was rendered as `[object Object]`_

The temporary workaround described by [#110041](https://github.com/elastic/kibana/issues/110041) ensured that `Sort A-Z` and `Sort Z-A` labels were always displayed (in lieu of `[object Object]`), as shown in the screenshot below:

![image](https://user-images.githubusercontent.com/324519/130789326-bfe67cae-e4f7-469a-9b57-320cbf733cc8.png)

_Above: `Sort A-Z` and `Sort Z-A` labels were always displayed as a workaround_

The fix in this PR updates the following (shared) Kibana `i18n` constant in `src/core/public/i18n/i18n_eui_mapping.tsx` to use a `FormattedMessage`:

```ts
    'euiColumnActions.sort': ({ schemaLabel }: EuiValues) => (
      <FormattedMessage
        id="core.euiColumnActions.sort"
        defaultMessage="Sort {schemaLabel}"
        values={{ schemaLabel }}
      />
    ),
```

, which ensures a schema-specific sorting label is displayed as-expected.

It also removes the workaround, as shown in the animated gif below:

![after](https://user-images.githubusercontent.com/4459398/132080352-1ee41a7e-8884-45ad-ae3c-daa9a0127aac.gif)

_Above: Schema-specific sorting descriptions are displayed for `datetime`, `text`, and `numeric` column headers_
2021-09-08 11:54:39 -06:00
spalger 65bdbe71d0 Revert "[Canvas] SidebarContent refactor. (#110051)"
This reverts commit 6a958a5e83.
2021-09-08 10:34:17 -07:00
Shahzad 032810e46a
[Uptime] Added loading for certificates page on initial load (#111526) 2021-09-08 13:33:54 -04:00
Marco Liberati b36ffc98fc
[Lens] Fix Heatmap in dashboard with numeric color stops (#111117)
* 🐛 Fix heatmap numeric stops problem + tests

* 🏷️ Fix type issue

*  Add dashboard functional tests for this issue

*  Simplify functional test

*  fix functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 19:02:10 +02:00
Yaroslav Kuznietsov 6a958a5e83
[Canvas] SidebarContent refactor. (#110051)
* Refactored sidebar.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 12:50:05 -04:00
Tim Roes 8956cad79d
Share history package via shared deps (#111537) 2021-09-08 18:49:17 +02:00
Nathan L Smith 0204762667
Ensure name columns are not cut off on APM tables (#111046)
* Switch the overview to single column when we're at < 1200px
* Hide sparkplots on transactions, dependencies, and instances tables at widths where they could be easily cut off
* Right-align sparkplot columns
* Make chart heights match latency chart height when showing a single column
* Make all impact bars fixed 96px width
* Make values be shown before sparklines
* Make SparkPlots `overflow: 'hidden'`
* Remove fixed widths from columns
* Return breakpoint and width from `useBreakpoints`
* Rename "breakPoint" to "breakpoint" everywhere to match what EUI does
* Replace `ServiceListMetric` (on used on service list) with `ListMetric` (used when sparkplots are conditionally shown)

Fixes #110165.
2021-09-08 11:44:39 -05:00
Lisa Cawley dc2180a8dd
[APM] Updates failed transaction correlations help (#111222) 2021-09-08 09:31:19 -07:00
Lisa Cawley e16736416a
Replace hard-coded doc links in uptime (#111075) 2021-09-08 09:27:08 -07:00
Yaroslav Kuznietsov 6f7d07c6e7
[Canvas] SidebarHeader refactor. (#110176)
* Removed recompose.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 11:59:32 -04:00
Angela Chuang 22acf4f216
fix topN popover for case view (#111514)
* fix topN popover for case view

* unit tests
2021-09-08 16:55:22 +01:00
Brian Seeders a5acde42c7
Revert "[CI] Buildkite ES Snapshots Pipelines (#100843)" (#111560)
This reverts commit 84a3a9b86e.
2021-09-08 11:43:47 -04:00
Stratoula Kalafateli 6f4d8a52dc
[Vislib] Removes old implementation of xy chart (#110786)
* [Vislib] Remove xy chart

* Update i18n

* Remove uncecessary file

* Fix types

* More fixes

* Fix functional tests part 1

* Fix functional tests part 2

* Fix bug with shard-delay

* Fix functional tests part 3

* fix functional tests part4

* Fix async_serch FT

* Fix functional dashboard async test

* REplace screenshot area chart image

* Cleanup vislib from xy charts

* Remove unused fixtures

* Address PR comments

* Remove miaou :D

* Address PR comments

* Fix i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 18:35:51 +03:00
Robert Oskamp dc8f557d3b
[ML] Functional tests - omit node_name in job message assertions (#111529)
This PR removes the node_name from job audit message assertions as it can vary depending on test environments, particularly in cloud.
2021-09-08 11:21:14 -04:00
Brian Seeders 84a3a9b86e
[CI] Buildkite ES Snapshots Pipelines (#100843) 2021-09-08 11:18:42 -04:00
David Sánchez 641a4b58a9
Allow kuery in get summary request in order to be able to filter summaries by policyId (or something else in the future) (#111507)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 17:17:58 +02:00
Dima Arnautov d1f2e37902
[ML] Fix "Exclude jobs or groups" control (#111525) 2021-09-08 11:15:17 -04:00
David Sánchez eb9a0fcc17
[Security Solution] [Endpoint] Add new policy tabs layout (#110966)
* Add new policy tabs layout with policy settings and trusted apps tab. Only visible with feature flag enabled

* Add URL state of which tab is selected. Also refactored policy_details component. Hide sticky bar at bottom when trustedApps tab is selected

* Fix wrong constant path in routing

* Don't refresh policyItem if is not necessary

* Remove old code and use new form layout component even if FF is disabled

* Split test file

* Clean test file with unused mocks

* Fixes failing test

* Address pr comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 17:04:34 +02:00
Dmitry Tomashevich c94c4e653a
[Discover] Fix opening the same saved search (#111127)
* [Discover] fix opening the same saved search

* [Discover] fix functional test

* [Discover] apply suggestion

* [Discover] apply suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 17:33:29 +03:00
Jonathan Budzenski 55b0d535ff skip flaky test. #111496 2021-09-08 09:30:53 -05:00
Alexey Antonov d717521ad0
[TSVB] Fix pinned filters not showing in TSVB (#109223)
Closes: #17025

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 17:29:02 +03:00
Jonathan Budzenski 178b56980f
[ftr] Check client status using v8format=true (#111480)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 08:24:26 -05:00
Ashokaditya 01218e4745
[Security Solution][Endpoint] Do not validate TA creation form with soft errors when required name field is empty (#111508)
* validate to true only if name is not empty as well

fixes elastic/kibana/issues/108509

* update test

* review changes
2021-09-08 15:23:04 +02:00
Orhan Toy 721cf1023d
[App Search] Crawler overview empty state needs an EuiSpacer (#111498) 2021-09-08 15:00:17 +02:00
Scotty Bollinger ac95ec4d6e
[Enterprise Search] Update internal routes to use /internal prefix over /api (#111035)
* Convert App Search server routes to new prefix

* Update frontend route prefixes for App Search

* Convert Workplace Search server routes to new prefix

* Update frontend route prefixes for Workplace Search

* Convert Enterprise Search server routes to new prefix

* Update frontend route prefixes for Enterprise Search
2021-09-08 08:48:08 -04:00
Ahmad Bamieh 436bb0fea5
[i18n] Integrate 7.15.0 Translations (#111488) 2021-09-08 14:59:39 +03:00
Alejandro Fernández Gómez 77e25bedfb
[Logs UI] Fix alert previews for thresholds of 0 (#111150)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 11:33:00 +02:00
Tre 094f2c9b81
[Archive Migration][Partial] discover apps-discover (#110437)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 10:32:42 +01:00
Dario Gieselaar c7d6f6df1c
[APM] Set start date of APM ML job to -4 weeks (#111375)
Closes #111045.
2021-09-08 11:20:32 +02:00
Walter Rafelsberger f1fbe8e06d
[ML] APM Latency Correlations: Code consolidation. (#110790)
Code deduplication:
- combine 3 existing client side hooks into useSearchStrategy
- combine server side multiple search strategy files into shared search_strategy_provider.ts
- Clarified naming (client/server params, strategy naming etc.), improved types.
- None of the actual deeper internal logic changed, larger chunks of code that show up as new lines is mostly just moved code + additional types (e.g. function overloads) to support the different search strategies with the same server side code and client side hook.
2021-09-08 09:47:07 +02:00
Matthias Wilhelm 1b1e936320
[Discover] Fix indices permission for multiline test (#111284) 2021-09-08 07:41:01 +02:00
Justin Ibarra b8acf0fbab
[Detection Rules] Add 7.15 rules (#111464) 2021-09-08 00:11:18 -04:00
Candace Park a4828baf3d
[Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (#111064) 2021-09-07 20:43:42 -04:00
Mat Schaffer 7fc4c2935d
React version of angular license view (#111317)
* React version of angular license view

* Fix time handling and linking to license upload

* Use getPageData pattern instead of useClusters

* Add note about locked time picker

* Add disable support to monitoring toolbar

* Disable toolbar on license page only

* Remove old todo

* Clean up render setup method ordering

* Fix CI checks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 09:18:58 +09:00
Søren Louv-Jansen e79a23a122
[APM] Fix link in readme (#111362) 2021-09-07 18:42:35 -05:00
Joey F. Poon 14660994d2
[Security Solution] add agent field to generator (#111428) 2021-09-07 15:15:18 -05:00
Devon Thomson 70632e2a9e
[Dashboard] Retain Tags on Quicksave (#111015)
* fixed missing tags api when loading saved dashboard. Added tests
2021-09-07 14:20:15 -04:00
Orhan Toy aaf0870197
Reorder App Search ingestion methods (#111361) 2021-09-07 20:12:13 +02:00
Luke Elmers 98a67c07cc
Port performance docs to new docs system. (#111063) 2021-09-07 14:04:08 -04:00
Davis Plumlee 733b17f80c
[Security Solution][RAC] Fixes updatedAt loading bug (#111010) 2021-09-07 13:59:33 -04:00
Nathan Reese daf860c701
[sample data] update web log geo.src field to match country code of geo.coordinates (#110885)
* [sample data] update web log geo.src field to match country code of geo.coordinates

* fix functional tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-07 10:40:46 -06:00
David Sánchez 855a338b9f
[Security solution] [Endpoint] Fix bad artifact migration (#111294)
* Working test that validate migrated artifact has same properties as SO artifact
* Checks if artifact is compressed and uncompress it if necessary before creating the new one from fleet

Co-authored-by: Paul Tavares <paul.tavares@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-07 12:36:06 -04:00
Justin Kambic 973645f928
Fix copy typo. (#111203)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-07 12:22:32 -04:00
Jonathan Budzenski 173bb47563
[build] Remove empty optimize directory (#111393)
This folder is no longer used.
2021-09-07 12:19:35 -04:00