Commit graph

20374 commits

Author SHA1 Message Date
Silvia Mitter
baf77580b3 [APM] Update Index Pattern (#33023) 2019-03-12 15:15:38 -04:00
Felix Stürmer
b2af9dfcb2
[6.7] [Infra UI] Strictly pick fields sent upon source config creation (#32897) (#32990)
Backports the following commits to 6.7:
 - [Infra UI] Strictly pick fields sent upon source config creation  (#32897)
2019-03-12 18:57:52 +01:00
Andrew Cholakian
476d02cc4b
[Uptime] Add i18n to plugin name in sidebar (#32586) (#32817)
Fixes https://github.com/elastic/kibana/issues/32052
2019-03-12 05:46:54 -05:00
Hamid
728e5172d6
[APM] Use correct agent name in instructions (#32896) (#32903) 2019-03-12 08:46:32 +01:00
Nathan Reese
cd9e77717c
Add link to Maps docs in Kibana getting started with sample data (#32848) (#32949)
* Add link to Maps docs in Kibana getting started with sample data

* Update docs/getting-started/add-sample-data.asciidoc

Co-Authored-By: nreese <reese.nathan@gmail.com>
2019-03-11 18:13:16 -06:00
gchaps
cad3a21194 [Maps][Docs] Updates for Maps Getting Started (#32809)
* [Maps] getting started documentation

* [DOCS] Edits for Maps Getting Started

* [DOCS] Incorporates review comments

* [DOCS] Rewrite section on sample data

* [DOCS] Adds link to add sample data page
2019-03-11 16:48:38 -07:00
Felix Stürmer
6c82b88508
[Infra UI] Adapt settings ui to saved object version type change (#30082) (#32938)
Backports the following commits to 6.7:
 - [Infra UI] Adapt settings ui to saved object version type change (#30082) (#29622)

Caused by backport of #29906 to `6.x`.
2019-03-12 00:44:00 +01:00
Tiago Costa
6f976229b9
Add a docker run example to Kibana Install doc2 (#32702) (#32924)
* Add a docker run example to Kibana Install doc2 

See PR #29911

* Update docs/setup/docker.asciidoc

Co-Authored-By: pgoldtho <peter@goldthorp.com>
2019-03-11 21:18:07 +00:00
Alexey Antonov
a073fcb10c
[6.7] Deprecated field [template] used, replaced by [index_patterns] (#32879) 2019-03-11 21:38:15 +03:00
Alexey Antonov
db9b734fe2
[types removal] The parameter include_type_name should be explicitly specified in get indices requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means responses will omit the type name in mapping definitions." (#32891) 2019-03-11 18:21:41 +03:00
Tim Roes
71d981762d
fix missing axis labels when changing vertical bar chart to horizontal bar chart (#32628) (#32876) 2019-03-11 10:45:05 +01:00
Alexey Antonov
c625fa086d
[6.7] Deprecated field [all_fields] used (#32669) 2019-03-11 11:01:51 +03:00
Clint Andrew Hall
fd31256071
[6.7] [canvas] Fix resolved_args sync issue when deleting a page (#32835) (#32856)
Backports the following commits to 6.7:
 - [canvas] Fix resolved_args sync issue when deleting a page  (#32835)
2019-03-09 23:31:01 -08:00
Catherine Liu
b41c59a9a6
[Canvas] Fixes workpad update error for read only users (#32831) (#32838)
* waits for write permission test before loading workpad

* Adds setRefreshInterval to list of skipped actions in es_persist
2019-03-09 22:18:25 -07:00
Spencer
41b8931569
[6.7] [ts] add script to verify that all ts is in a project (#32727) (#32828)
* [dev/run] typescriptify the dev/run helper (#32705)

Simple typescript conversion of the `src/dev/run` helpers.

* [ts] add script to verify that all ts is in a project (#32727)

Based on #32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.

* select all ts files from tsconfig.json file
2019-03-08 19:50:50 -08:00
Clint Andrew Hall
9ef9ad3cb4
[6.7] [intepreter][Canvas] Dedupe server functions in batched requests (#32712) (#32833)
* [intepreter][Canvas] Dedupe server functions in batched requests (#32712)

* [intepreter][Canvas] Dedupe server functions in batched requests

* Add and correct tests

* Update interpreter.test.js

Fix merge error

* Delete batched_fetch.test.js

This file was not present in the branch and is failing.
2019-03-08 19:26:18 -08:00
Catherine Liu
b0b18bfca6
Added del as shortcut for deleting elements on osx (#32704) (#32711) 2019-03-08 15:39:18 -07:00
Brandon Kobel
5618e1a5e3
Upgrading handlebars (#32699) (#32717) 2019-03-08 13:52:53 -08:00
Spencer
37974c982f
[reporting/autoDownload] default to true when not in distributable (#32803) (#32807)
# Conflicts:
#	x-pack/plugins/reporting/index.js
2019-03-08 12:38:06 -08:00
Joe Fleming
c63da63c64
Fix: show actual errors on failed elements, handle null values from functions (#32600) (#32797)
Closes https://github.com/elastic/kibana/issues/32356

This PR fixes two issues.

The first there was an issue filed, #32356:

- Show non-Boom errors instead of asking users to look at server logs
  - Also write the error to the server when asking them to look there

![](https://user-images.githubusercontent.com/404731/53673728-9368b180-3c46-11e9-912e-7aaff25d3ddf.png)
*If the function failed for some reason, this is all you'd ever see*

![screenshot 2019-03-06 16 24 09](https://user-images.githubusercontent.com/404731/53921029-4d3b9580-402c-11e9-85bf-21ab31e952bc.png)
*Errors are shown to the user*

![screenshot 2019-03-06 16 26 16](https://user-images.githubusercontent.com/404731/53921130-a0154d00-402c-11e9-9cb5-102d360a69f8.png)
*Code errors bubble up correctly as well*

---

The other I didn't bother opening an issue for:

- Fixes issue where functions that return `null` produce an error message
  - `null` is a valid thing to return, it's only `undefined` that causes a problem
  - This was only a problem for server functions that return `null` (currently, none of them do)
  - Introduced in #31298
  - Discovered when I ran into casting problems (see https://github.com/elastic/kibana/issues/32597)

![screenshot 2019-03-06 16 18 17](https://user-images.githubusercontent.com/404731/53921039-562c6700-402c-11e9-9650-fc51d1f91643.png)

![screenshot 2019-03-06 16 19 01](https://user-images.githubusercontent.com/404731/53921044-5cbade80-402c-11e9-9cde-fdb49334dcd0.png)
2019-03-08 13:23:58 -07:00
Spencer
5254c40e69
[6.7] remove bootstrap cache, which is only for master (#32784)
(cherry picked from commit 985a988563)

6.7 backport of https://github.com/elastic/kibana/pull/32782
2019-03-08 09:18:19 -08:00
Joe Fleming
106423d1dc
feat: import and use clear function (#32589) (#32696) 2019-03-08 09:34:20 -07:00
Robert Monfera
f64bcd75d7
[Canvas] Fix: lose element selection on page flip (#32111) (#32741)
* Fix: lose element selection on page flip

* Fix: remove selection in Redux too (PR feedback from Joe)
2019-03-08 16:32:00 +01:00
Jonathan Budzenski
10a2ef3618
[es] scripts.inline -> scripts.source (#30457) (#32701) 2019-03-08 07:24:53 -06:00
Justin Kambic
32a9f427ef Fix broken test snapshot. (#32715) 2019-03-07 17:07:58 -06:00
Lukas Olson
70dd28713c Merge remote-tracking branch 'upstream/6.7' into 6.7 2019-03-07 14:06:16 -07:00
Jason Rhodes
8e398bda98
[6.7 backport] Updates EUI to include date picker types (#31937) (#32581)
* [7.0] Updates EUI to include date picker types (#31937)

* Fixed a simple argument bug and removed infra date picker EUI types

* Fixes for EUI date picker types

* Updates EUI to 6.10.4 to bring in date picker types, adds react-datepicker types as a necessary peer dep

* Updates moment imports to import from moment-timezone to avoid type collisions

* Syncs version for react-datepicker types between x-pack and kibana root

* Fixes query bar type issue with eui super date picker
2019-03-07 13:18:04 -05:00
Felix Stürmer
9434669200
[6.7] [Logs UI] Use log message field configured in the yaml file (#32502) (#32653)
Backports the following commits to 6.7:
 - [Logs UI] Use log message field configured in the yaml file  (#32502)
2019-03-07 19:06:48 +01:00
Justin Kambic
4c1264dd51
[Uptime] ICMP not displayed in Overview page or as a filter option (#32083)
* Add definition for type filter in addition to scheme.

* Remove scheme from filter bar.

* Update ES queries to return ICMP counts.

* Update API tests for new histogram size. Add tests for ICMP data.

* Improve code quality for server function.

* Remove unneeded ICMP-specific code.

* Remove unneeded ICMP code from error list query.

* Add correct curve to monitor chart.

* Update ICMP docs and fix broken API tests.

* Add filter bar icmp functional test.

* Update filter bar UI test to ensure that ICMP monitors are supported.
2019-03-07 12:09:59 -05:00
Andrew Cholakian
0a5b524ffd
Added dummy fucntion to avoid warning. (#32070) (#32606)
Co-Authored-By: ganeshpatro321 <30416891+ganeshpatro321@users.noreply.github.com>
2019-03-06 21:35:47 -06:00
Sébastien Loix
02b4e6b359
[CCR] Fix form bug + add missing i18n (#32544) (#32557)
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
2019-03-06 15:59:30 +00:00
Clint Andrew Hall
53d41bfcbd
[Canvas] Fix context elements issue with Element Stats (#32510) (#32540)
## Summary

(closes #32512, closes #32508)

This fixes a bug where element stats was causing a failure due to not every element being an `expressionRenderable` all the time... when first added, `TimeFilter` is `expressionContext` and should be considered `pending`.

This PR also fixes an issue where `resolvedArgs` was not being reset between workpad loads, causing element stats to be compounded.

Co-authored-by: Spencer <email@spalger.com>
2019-03-05 21:50:41 -06:00
gchaps
da4d4643eb
[DOCS] Fixes pagination in Upgrade Assistant docs (#32520) 2019-03-05 15:07:05 -08:00
Andrew Cholakian
db6a4e6cbf
[Uptime] Fix misnamed 'Host' filter to 'ID' (#32421) 2019-03-05 14:17:37 -06:00
Sarah Hersh
b4199aa571 [DOCS]Add sample data (#32244)
* add screenshot to add sample sets

* add sample data overview

* new screenshot

* add next steps

* feedback from Gail
2019-03-05 14:01:29 -05:00
Walter Rafelsberger
0c5c1bbddd
[ML] Adds missing error handling to annotations request. (#32384) (#32490)
- This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases.
- Disables annotations feature in Single Metric Viewer if annotations fail to load.
- Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.
2019-03-05 19:58:59 +01:00
Chris Cowan
2ff4418b94
[Infra UI] Revert ECS changes for 6.7 (#31961)
* Revert "[Infra UI] Clean up Docker and Kubernetes fields for ECS (#31175)"

This reverts commit cb3dad1317.

* Revert "[Infra UI] Fixing group by labels by fixing the field names (post ECS migration) (#30416) (#31012)"

This reverts commit 6bd74e0abd.

* Revert "[Infra UI] ECS Migration (#28205) (#29965)"

This reverts commit fe9748583e.

* Fixing tests

* Fixing tests

* Adding test data for docker and some basic sanity checks to ensure ids and names work correctly with real data
2019-03-05 11:21:32 -07:00
Joe Fleming
72c7595742
Fix: Prevent some needless re-rendering in high-level components (#31958) (#32359)
In an effort to remove the workpad renaming lag in https://github.com/elastic/kibana/issues/25070, I started hunting down and fixing re-renders that happened with the name change. 

I was hoping this PR would fix the lag, but I've shifted to some other performance issues that have a much larger impact, so this is just a bunch of re-rendering fixes, which come with some performance gains. Here's the breakdown:

- `Workpad`, `WorkpadHeader`, and `FullscreenControl` would always re-render because the hotkey handler function was always re-created
- `Workpad` would re-render when the workpad's name changed
  - We were passing the whole workpad object into the component, so it re-rendered on all sorts of changes
  - Page title updating moved to middleware so the component doesn't need that value
- `AssetManager` would always re-render if the parent re-rendered because it always created a new state value in `mapStateToProps`
- make `Workpad` and `Toolbar` pure, they take no props and this helps stop some re-rendering
2019-03-05 10:10:30 -07:00
Joe Fleming
62d2123048
fix: supply a valid axisconfig position default (#32335) (#32362)
The previous default was an empty string, but empty strings are not valid in the expression. The code ends up using "left" or "top" (depending on the axis), so defaulting to either isn't really a change.

This fixes the following valid expression:

```
demodata | pointseries x=@timestamp y="mean(price)" | plot yaxis={axisConfig max=120}
```

Previously this would fail because the `position` default is invalid unless you specified a value.

<img width="617" alt="screenshot 2019-03-01 12 11 47" src="https://user-images.githubusercontent.com/404731/53660475-33104a80-3c1b-11e9-9a4c-a93116598e28.png">

Now it works as expected:

<img width="536" alt="screenshot 2019-03-01 12 11 03" src="https://user-images.githubusercontent.com/404731/53660440-212ea780-3c1b-11e9-8f4f-7d83a1009fd0.png">
2019-03-05 10:09:58 -07:00
Clint Andrew Hall
bb3e14348b
[Canvas] Loading Indicator + Elements Panel (#32369) (#32448)
* [Canvas] Loading Indicator + Elements Panel
2019-03-04 22:13:51 -06:00
gchaps
2633ed6ef4
[DOCS] Adds information about reindexing to Upgrade Assistant doc (#32413) 2019-03-04 15:58:12 -08:00
Nathan Reese
f6b4f402e2
[Maps] docs (#32130) (#32416)
* [Maps] docs

* unique ids

* use hyphen instead of underscore in file names

* get everything working

* add screen shots of layer types

* add sources to layer documentation

* terms join example

* vector styling

* clean up

* link to geo_point for grid agg source

* minor clean up

* review feedback

* Update docs/maps/index.asciidoc

Co-Authored-By: nreese <reese.nathan@gmail.com>

* Update docs/maps/heatmap-layer.asciidoc

Co-Authored-By: nreese <reese.nathan@gmail.com>

* Update docs/maps/heatmap-layer.asciidoc

Co-Authored-By: nreese <reese.nathan@gmail.com>

* Update docs/maps/heatmap-layer.asciidoc

Co-Authored-By: nreese <reese.nathan@gmail.com>

* rest of changes suggested by gchaps

* update terms join intro
2019-03-04 13:45:51 -07:00
Tiago Costa
cc8a0f3af7
chore(NA): merge and solve conflicts with 6.7 (#32390) 2019-03-04 14:51:48 +00:00
Alexey Antonov
e768a2eed9
TSVB is retaining results even after indexpattern is removed from opt… (#32003) (#32320)
# Conflicts:
#	src/legacy/core_plugins/metrics/server/lib/get_fields.js
2019-03-04 11:02:29 +03:00
Spencer
85521ae500
[6.7] [junit] use default rootDirectory for project (#32256) (#32347)
Backports the following commits to 6.7:
 - [junit] use default rootDirectory for project  (#32256)
2019-03-01 16:06:38 -08:00
Mikhail Shustov
1d93e8db8d
update @types/node to latest v10 (#32306) (#32324) 2019-03-01 19:11:39 +01:00
Chris Davies
aa73d53e96
Remove unused server functionality from the interpreter (#32133) (#32312) 2019-03-01 11:38:14 -05:00
Pete Harverson
5035d13a52
[ML] Adds missing applyAsync to advanced job wizard page (#32186) (#32296) 2019-03-01 12:07:32 +00:00
Pete Harverson
1687a660bf
[ML] Fix formatting of values for time of day or week anomalies (#32134) (#32287) 2019-03-01 10:42:41 +00:00
Joe Reuter
06e4388b95
Fix pushed down chart on multi line horizontal legends (#31466) (#32128) 2019-03-01 11:40:28 +01:00