Commit graph

45750 commits

Author SHA1 Message Date
Tiago Costa
c736d99c87
skip failing es promotion suite (#109660) 2021-08-23 15:18:00 +01:00
Andrew Goldstein
6a61c43f06
[RAC] [Security Solution] Hides the Show top <field> action in chart legends (#109566)
## Summary

Fixes <https://github.com/elastic/kibana/issues/108910> , which allowed users to launch a new `Top <field>` popover from an existing popover, to infinity (and beyond)

The `Show top <field>` action is now hidden in the `Top <field>` popover's chart legend, and also:

- In the legend items of charts throughout the Security Solution (e.g. on the `Overview` page, and in the `Trend` chart on the `Alerts` page)
- For items in the `Count` aggregation table on the `Alerts` page

## Screenshots

### Before (Top `signal.rule.name` popover)

![before-top-signal-rule-name](https://user-images.githubusercontent.com/4459398/130302784-00a6c24d-17c8-4361-979e-01b8467f100e.png)

_Above: It was possible to launch another `Top <field>` popover from the legend of an existing popover_

### After (Top `signal.rule.name` popover)

![after-top-signal-rule-name](https://user-images.githubusercontent.com/4459398/130302925-d5aaa1ff-9565-4374-aa87-bde5880cb64f.png)

_Above: It is no longer possible to launch another `Top <field>` popover from the legend of an existing popover_

### Before (Chart legends)

![before-overview](https://user-images.githubusercontent.com/4459398/130303169-dc6c6de3-a2ba-40fe-a1f0-fe0d78b9638c.png)

_Above: It was possible to launch a `Top <field>` popover from chart legends_

### After (Chart legends)

![after-overview](https://user-images.githubusercontent.com/4459398/130303519-2eb0a60e-c6cd-4659-b6b2-d5ba234f668f.png)

_Above: It is no longer possible to launch a `Top <field>` popover from chart legends_

### Before (`Count` items)

![before-count](https://user-images.githubusercontent.com/4459398/130304111-b37373cf-1afb-41b8-9f38-b5d9b37cdb2d.png)

_Above: It was possible to launch a `Top <field>` popover from `Count` items_

### After (`Count` items)

![after-count](https://user-images.githubusercontent.com/4459398/130304166-fb641fa2-b52e-44ff-8210-0e228a43330c.png)

_Above: It is no longer possible to launch a `Top <field>` popover from `Count` items_

cc @mdefazio
2021-08-23 08:09:00 -06:00
Dario Gieselaar
6e3af2b524
[APM] Support multiple route paths in useApmParams (#109370)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 15:38:06 +02:00
Esteban Beltran
60a74e8eaf
Fix detection rules link for memory and behaviour protections cards (#109591) 2021-08-23 15:15:21 +02:00
Joe Portner
65e04b1380
Remove spacesOss plugin (#109258) 2021-08-23 15:10:09 +02:00
Aleh Zasypkin
3a0f209bde
Cumulative set of the preboot stage adjustments (#108514) 2021-08-23 15:01:46 +02:00
Søren Louv-Jansen
8deaa573de
[APM] Change username in readme (#109604) 2021-08-23 09:00:47 -04:00
Matthias Wilhelm
8489e91f2a
[Discover] Fix keeping error state after invalid KQL query (#109514) 2021-08-23 14:55:26 +02:00
Sergi Massaneda
64dff78dce
[RAC] Actions popovers UI unification (#109221)
* popover padding size unified

* remove panels from all context menus

* action items order changed

* cases menu items test fixed

* translations and small changes

* remove components not used anywhere

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
2021-08-23 08:42:24 -04:00
Ester Martí Vilaseca
ec7889a938
[Stack Monitoring] Add initial react app (#109218)
* Add feature toggle

* Add basic react app with router and simple loading page

* Add title hook

* Add loading page with page template and clusters hook

* fix types

* fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 14:29:10 +02:00
Mark Hopkin
69f2a0e94a
[Fleet] Fix Fleet settings and HostInput error handling (#109418)
* fix: HostInput error placement onChange

* fix: check for duplicates in hosts

* fix: validate all sections

* fix: error swapping

* fix: yaml placeholder position and styling

* test: add unit tests for delete behaviour

* tidy: use generic for reduce typing
2021-08-23 13:26:29 +01:00
Kerry Gallagher
597593d056
[RAC] Fix hover on alert status column (#109273)
* Fix alert status column hover
2021-08-23 13:10:27 +01:00
Pablo Machado
f2df9cc959
Small improvements around Reason field and AlertCountTable draggable fields (#109239)
* Make count table field and alert table event renderer undraggable

* Remove tooltip from alert count table

* Remove DefaultDraggable wrapper from reason field

* Fix unit test and remove unused props

I am not 100% sure, but apparently, the test was broken due to a long import chain loop.
I cut the import chain by extracting some constants to a file.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 13:45:53 +02:00
Quynh Nguyen
63ef9d10b0
[ML] Fix UI inconsistencies in APM Failed transaction correlations (#109187)
- Show the same empty state in the correlations table
- Add "Correlations" title above the table
- Add EuiSpacer between the sections before and after progress
- Update the copy within the beta badge title=Failed transaction correlations description=Failed transaction correlations is not GA...
- Remove s size from the beta badge
- Move the help popover to the top of the panel (similar to the Latency correlations tab)
- Move the Cancel/Refresh option to the right of the progress bar (similar to the Latency correlations tab)
- When the correlation job is running the correlations tab should show a loading state similar to the latency correlations table
- Indicate in the table headers Score is sorted by default
- Add sortability to both Latency and failed transactions correlations table
- Refactor to prevent duplicate code/components like Log, progress bar
- Fix alignments of the tab content header (previously navigating from one Trace samples tab to Latency correlation tabs will cause a minor jump in the header, or the titles within the same tab were not the same size )
- Remove the event.outcome as a field candidate (because event.outcome: failure would always be significant in this case)
- Shrink the column width for impact (previously it was at 116px)
- Added badge for High, medium, low [APM] Correlations: Show impact levels (high, medium, low) as colored badges indicating their severity
- Fix license prompt text
- Functional tests for the new tab
- Make the p value & error rate columns visible only when esInspect mode is enabled
2021-08-23 07:28:18 -04:00
Georgii Gorbachev
f9aa9deef9
[Security Solution][Detections] Skip failing Cypress test detection_alerts/acknowledged.spec.ts (#109532)
## Summary

I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time:

https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658

The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected".

I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well.

Skipping for now as it's blocking a critical fix for 7.15: https://github.com/elastic/kibana/pull/109276
2021-08-23 13:18:51 +02:00
Dmitry Tomashevich
68afb8d0e1
[Discover] Fix discover footer width (#109403)
* [Discover] fix discover footer width

* [Discover] fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 14:16:51 +03:00
Yulia Čech
ca5b2cb996
[ILM] Fixed _meta field failing server validation (#109295)
* [ILM] Fixed the bug with built-in policies not saving because of the _meta field

* [ILM] Added PR review suggestions

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 12:58:46 +02:00
Yaroslav Kuznietsov
237fcac254
[Canvas] Expression tagcloud (#108036)
* Added `expression_tagcloud` plugin.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 06:52:19 -04:00
Maja Grubic
6711005db2
[Saved Search Embeddable] Do not set source field when reading fields from source (#109069)
* [Saved Search Embeddable] Do not set source if reading fields from source enabled

* Extract functionality to a helper function and added unit tests

* Fix unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 12:34:35 +02:00
Pierre Gayvallet
5c5e191364
Add multiple namespaces support to PIT search and finder (#109062)
* initial modifications

* change approach for openPointInTime and add tests for spaces wrapper changes

* fix and add security wrapper tests

* fix export security FTR tests

* update generated doc

* add tests for PIT finder

* NIT

* improve doc

* nits
2021-08-23 12:02:41 +02:00
Alejandro Fernández Haro
75cdeae490
[Flaky test] Application Usage: Wait for chrome to visible (#109405) 2021-08-23 05:58:34 -04:00
Manuel de la Peña
92c6787af1
chore(ci): remove apm ui e2e old pipelinegit ci (#109441)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 04:19:55 -04:00
Mat Schaffer
0ec5148c73
Fix grammar on stack monitoring alerts modal (#109360)
Pretty sure the rules only get created in the current kibana space, but the message is plural. Switching to singular.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 13:06:24 +09:00
Tiago Costa
eb08603a00
skip failing es promotion suites (#109583) 2021-08-23 00:21:24 +01:00
Tiago Costa
8f3a069a85
skip flaky suite (#106650) 2021-08-23 00:08:19 +01:00
Tiago Costa
dc6d50a7e8
skip flaky suite (#89072) 2021-08-22 23:58:43 +01:00
Tiago Costa
c2ec613ffc
skip flaky suite (#106492) 2021-08-22 23:56:13 +01:00
Robert Oskamp
08e47c8dd3
[ML] Functional tests - re-enable modules API test suite (#109471)
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1839/
2021-08-21 10:48:20 +02:00
Tiago Costa
e340ce61cc
chore(NA): moving @kbn/securitysolution-autocomplete to babel transpiler (#109423)
* chore(NA): moving @kbn/securitysolution-autocomplete to babel transpiler

* chore(NA): finetune package

* chore(NA): update deps

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-21 00:08:22 -04:00
Tiago Costa
c4d1e7da4a
chore(NA): moving @kbn/alerts to babel transpiler (#109320)
* chore(NA): moving @kbn/alerts to babel transpiler

* chore(NA): finetune package

* chore(NA): miss dep

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 18:55:18 -04:00
Sergi Massaneda
5a00ff3075
[RAC] Alerts table widths updated (#109267)
* action and ts column widths changed

* snapshot updated

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 17:35:25 -04:00
Davis Plumlee
acc8465c19
[Security Solution][RAC] Adds OR bool for acknowledged status filter (#109348) 2021-08-20 17:30:10 -04:00
Davis Plumlee
0ebe3c6b09
[Security Solution][Detections] Fixes broken cypress test (#109533)
## Summary

Fixes `acknowledged.spec.ts` test that is currently failing on some ci builds

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-08-20 23:05:48 +02:00
Tiago Costa
f4e18d47c0
chore(NA): moving @kbn/securitysolution-utils to babel transpiler (#109439)
* chore(NA): moving @kbn/securitysolution-utils to babel transpiler

* chore(NA): update packages/kbn-securitysolution-utils/.babelrc

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
2021-08-20 22:04:39 +01:00
Devon Thomson
95463f47f3
[Dashboard] Remove Legacy Dashboard Only Mode (#108103)
Remove all dashboard only mode code and tests. Align dashboard permissions to use showWriteControls only
2021-08-20 15:39:10 -04:00
renovate[bot]
92ec225cfd
Update dependency @elastic/elasticsearch to ^8.0.0-canary.18 (master) (#109414)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-08-20 18:39:25 +01:00
Chris Cowan
d4b4b0e7b0
[Metrics UI] Re-enabled saved view tests (#108725)
* [Metrics UI] Re-enabled saved view tests

* Adding ensureViewIsLoadable back in

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 11:33:04 -06:00
Xavier Mouligneau
e8e53e36e5
[RAC] Get o11y alerts in alerts table (#109346)
* get back index names  in o11y

* testing and integration

* fix types

* Avoid using the rule data client for field list

* Remove left-over index argument

* no needs of alert consumer anymore

Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
2021-08-20 12:52:34 -04:00
Tiago Costa
ec2d041638
chore(NA): moving @kbn/ui-shared-deps to babel transpiler (#109323)
* chore(NA): moving @kbn/ui-shared-deps to babel transpiler

* fix(NA): missing correct paths on package.json files

* chore(NA): update jest integration snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 17:12:08 +01:00
Justin Kambic
cb3d353a36
Remove references to deprecated IIndexPattern. (#109347) 2021-08-20 12:08:54 -04:00
Tim Roes
4d115dcaa2
Fix bug with highlighting in field formatters (#109401)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 18:08:12 +02:00
Anton Dosov
cd7f26dd81
[IndexPatterns] No data experience to handle default Fleet assets (#108887)
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
2021-08-20 17:58:34 +02:00
Kaarina Tungseth
a8c2a43834
[DOCS] Reformats the Alerting and action settings tables into definition lists (#107964)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 11:29:37 -04:00
Marco Vettorello
958a3ba28a
fix(heatmap): remove duplicate legend items (#109338) 2021-08-20 17:09:22 +02:00
Kaarina Tungseth
7323cdbbb9
[DOCS] Reformats the AleBanner settings tables into definition lists (#107966)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 10:03:51 -05:00
Jean-Louis Leysens
132f55d362
fix check for security and added jest test (#109429) 2021-08-20 11:03:38 -04:00
Kaarina Tungseth
385d24b48a
[DOCS] Reformats the Development tools settings tables into definition lists (#107967)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 10:03:31 -05:00
Kaarina Tungseth
970cf589c5
[DOCS] Reformats the Graph settings tables into definition lists (#108065) 2021-08-20 10:03:21 -05:00
Casper Hübertz
8ab068ae1e
[APM] Change panel style for license prompt (#109386) 2021-08-20 16:55:25 +02:00
Matthias Wilhelm
aa2897ce51
[Discover] Fix runtime fields editor test in cloud environment (#109367) 2021-08-20 16:50:05 +02:00