## Summary
Hopefully reduces flake within cypress timeline notes.
* Removed additional notes about issues with the timelineid. I don't think that's a problem anymore now that I removed the assertion issue.
* Removed the pipe since the timeline click can cause multiple async URL actions to occur which will cause indeterminism.
* I added a visibility check to Cypress for the timeline link to be visible on the screen before we try to click on it which should hopefully give us enough breathing room for the click handler to be added.
* Added a query that returns no results as that can cause "UI blocking" since the UI loading for timeline takes a while. The "UI blocking" could be causing issues with clicks, but at the very least this speeds up the test and removes one more thing to worry about if this fails again.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
## Summary
Pulls constants from lists plugin into its own kbn package.
Phase 1: Lift and shift small shared constants into kbn package called `kbn-securitysolution-constants`
Phase 2: Deprecate existing code now in packages
Phase 3+: Strangle/remove existing code and use the code from the kbn package
Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
* Add isTrial selector to LicensingLogic
* Add LicenseCallout component
In order to match the existing design, I opted to use an extra EuiFlexItem for the gap between the button, instead of adding a stylesheet with padding, like the legacy version had. Verified it looks good on mobile as well.
* Add TrialCallout component
* Wire up new callouts
- Only render when the host is set, otherwise, fall back to the Setup Guide callout
- Add some extra padding with a larger spacer to beter match legacy UI
* Refactor for a better test
* Use isEmptyRender API instead of checking for length
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* DRY out callout heading
* Remove grow prop to align button to right
* Update button copy
* Replace EuiButton with EuiButtonTo
* Remove EuiText wrapper on link text
* Better test organization
* Remove unnecessarydivs
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Refactor i18n for link
Also changes link style to underline
* Center-align trial callout
* Rename i18n ID
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Add back and rename translations
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
## Summary
Good place for one off utils to use and reduce/remove the circular deps we have between security_solutions, lists, and anywhere else we have them for different utils.
Phase 1: Adds kbn package of `kbn-securitysolution-utils` through lift and shift
Phase 2: Deprecated the functions
Phase 3: Removes the functions in favor of using the `kbn-securitysolution-utils`
Phase 4+: Adds more and removes dependencies/copies across plugins within the security solution. Maybe we break things out by domain later as this grows in size.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
## Summary
We are removing duplicated code in sections of plugins into the kibana/packages folder. This is phase 1 of 4+ where:
Phase 1: Lift and shift the io-ts code into `kibana/packages/kbn-securitysolution-io-ts-utils`
Phase 2: Deprecate the utils across plugins any copied code
Phase 3: Replace the deprecated types with the ones in here where we can. [Strangle pattern](https://martinfowler.com/bliki/StranglerFigApplication.html)
Phase 4+: (potentially) consolidating any duplication or everything altogether with the `kbn-io-ts-utils` project
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
* [Metrics UI] Use the noramlized field for CPU usage for Observability Overview
* fixing overview page as well
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Connectors][API] Updated connectors with enabledAfterImport flag
* fixed functional tests
* added new field to connectors API docs
* added update unit test
* fixed test
* renamed enableAfterImport to isMissingSecrets
* removed onExport
* revert the logic of true/false for isMissingSecrets
* fixed test
* fixed tests
* added unit test
* fixed docs
* fixed import text and button labels
* fixed import text
* fixed text
* Showing placeholder message when connector is missing secrets
* Throwing error on isMissingSecrets = true before executing actions
* Hiding connectors with missing secrets from dropdown
* Checking for connectors with missing secrets during action validation on rule creation/update
* Updating error wording
Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>
Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>
* migrate add cluster route and jest tests
* migrated delete remote clusters route
* migrated the get route
* migrated the update route
* added shared types file
* reduce some test boilerplate
* fix type issues introduced by new types from ES client
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
- For groupby/agg configs, removes the .keyword postfix for the agg name and field name being displayed. The config itself will still use the field name including .keyword.
- For histogram charts, if available, query data using the .keyword field. This enables support for charts for terms when there's both a text and keyword variant.
- Fixes isKeywordDuplicate check for field names with multiple dots in them.
Co-authored-by: Walter Rafelsberger <walter@elastic.co>
* PaginatedContent: Show pagination only if we have items
* Updated trusted apps and event filters about info displayed in page title
* Include Add button on page header if entries exist
* EventFilters: Show items using the ExceptionItem component
* Enhance ExceptionItem Card so that optionally we can show Name as well as Modified information on the card
* new set of builders for async resources
* Fix circular dependency causing tests to fail - moved function from inside of `pages/index.tsx`
(used by outside component that is `import`ed by this same pageto a common pace. Error was:
```
Cannot create styled-component for component: undefined.
```
* Fixes assignment v comparison and null type check in metrics detail page
* Updated docs to specify new optional TS generic
* Switches new generic to extending the interface
* Removes previously added core generic type and defaults to unknown
* Reverts unknown change, saves for later
* Reverts unknown/any change for now
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Use PiT for outdated document search (#98797)
* use PiT for OUTDATED_DOCUEMENT_SEARCH step
* update tests
* fix typo
* fix so migrations unit tests
* TEMP: use wait_for when transformin docs
* add a step to refresh target index if transformed outdated docs
* add unit tests
* refresh before searching outdated docs
* add integration test for outdated docs migration
* add a step to refresh target index if transformed outdated docs
* make query required
* address comments
* skip test
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
* Make the flyout `s` instead of `m` size
* Remove flyout tabs
* Make flyout description list `compressed`
* Make spacer before description list `s` size
* Use `EuiPageTemplate` on alerts and cases pages.
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
* Move SchemaErrorsAccordion to its own folder
+ give it its own export
* Move errors-specific copy to its own file
+ Capitalize ID heading
* [UI polish] Accordion header tweaks
- Fix responsive behavior
- Make Review button more accessible (a within a button is not semantically correct)
- Add <code> markup for field type
* [UI polish] CSS tweaks
- use OOTB EUI CSS classes for borders (see https://elastic.github.io/eui/#/layout/accordion#styled-for-forms)
- tweak spacing
- misc fixes
* [Code polish] Misc cleanup
- Simplify / DRY out props types
- Prefer unique IDs/names over map indexes for React keys
- Improve var names
* Simplify conditional "view" column + misc fixes
- Rename prop to match AS's generateSomePath helpers
- Remove need for itemId - AS should be able to generate its own URL route without it
- Fix accessibility for view column - should be totally hidden to screen readers if not present
- Fix semantics of view link - should be an <a> link not a button
* Update WS's use of SchemaErrorsAccordion
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* chore(NA): moving @kbn/analytics into bazel
* chore(NA): fix type check for package migration
* chore(NA): fix type check for package migration
* chore(NA): fix type check for package migration
* chore(NA): separate type generating from server code
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# packages/kbn-analytics/scripts/build.js
* Adding query to identify long running rules to docs
* Wording suggestsion from PR review
* Adding event.provider to query. Allowing copy to console
* Adding note for system privileges
* Adding runtime field to query
* Removing extra dollar sign
* PR fixes
Co-authored-by: ymao1 <ying.mao@elastic.co>
* Move SchemaAddFieldModal to its own folder
+ misc test cleanup - remove unnecessary jest.spyOn in individual tests, it's already in the beforeEach
* i18n fixes
- Move constants to subfolder
- Fix various i18n IDs/var names - modal titles is not a fieldNote title
- Fix an i18n string that should be a FormattedMessage (could have grammar issues otherwise)
- Add missing i18n strings - labels (shared, AS will also use these as column headers) & placeholder
- Import order
* Move formatFieldName util to its own file
- simplify leading/trailing trimming regex
- add unit tests - primarily for documenting regexes & providing examples
* Refactor modal form submission
- See https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal for documentation - form should be submitted via ID & EuiModalFooter form={id}
* Misc props cleanup
- Move optional props to bottom of type list
- Remove unnecessary props (default EUI behavior)
- Data test subj cleanup
- Add missing `disabled` passed prop, add unit test for disableForm prop
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
###Summary
Removes some anti-patterns I introduced in my last PR and makes use of Cypress' chainable pattern that will hopefully help with the flakiness.
