Tyler Smalley
b593781009
Jest multi-project configuration ( #77894 )
...
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-02 11:42:23 -08:00
Anton Dosov
eaa65535ed
Use saved object references for dashboard drilldowns ( #82602 )
2020-11-12 15:54:55 +01:00
Vadim Dalecky
aaadbe88c5
Context menu trigger for URL Drilldown ( #81158 )
...
* feat: 🎸 add context menu trigger to URL drilldown
* fix: 🐛 translate "Drilldowns" grouping title
* feat: 🎸 add dynamic action grouping to dynamic actions
* fix: 🐛 add translations to trigger texts
* feat: 🎸 enambe ctx menu trigger in both flyouts, move to end
* fix: 🐛 show context menu event scope variable sfor ctx menu
* test: 💍 add tests
* fix: 🐛 use correct namespace for translation keys
* docs: ✏️ update autogenerated docs
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-30 13:04:48 +01:00
Vadim Dalecky
59e4e06316
Drilldowns in examples ( #75640 )
...
* feat: 🎸 add telemetry for in-chart "Explore underlying data"
* feat: 🎸 add telemetry for in-chart "Explore underlying data"
* refactor: 💡 move all drilldowns into a sub-folder
* feat: 🎸 setup example app section for ui_actions_enhanced
* feat: 🎸 set up Drilldown Manager section
* feat: 🎸 open drilldown manager from example plugin
* refactor: 💡 rename supportedTriggers -> triggers prop
* feat: 🎸 show dev warning if triggers prop is empty
* refactor: 💡 rename "supportedTriggers" -> "triggers" props
* feat: 🎸 open and close drilldown manager from example plugin
* feat: 🎸 add sample ML job trigger
* feat: 🎸 add sample ML URL drilldown
* refactor: 💡 move KibanaURL to share plugin
* refactor: 💡 add index file to ml drilldown
* feat: 🎸 add AbstractDashboardDrilldown
* refactor: 💡 make dashboard drilldown use abstract drilldown
* refactor: 💡 rename dashboard drilldown to embeddable drilldown
* feat: 🎸 add Dashboard drilldown to sample plugin
* feat: 🎸 open dashboard drilldown in list view
* feat: 🎸 add drilldown execute button
* refactor: 💡 move drilldown React hooks into /hooks folder
* test: 💍 fix tests after renaming triggers
* chore: 🤖 populate "requireBundles"
* fix: 🐛 fix TypeScript errors
* fix: 🐛 fix Kibana plugin dependency
* chore: 🤖 remoe unused import
* feat: 🎸 persist drilldown manager state across app navigations
* refactor: 💡 move no-embeddable example into a seprate file
* feat: 🎸 set up example with embeddable
* feat: 🎸 improve embeddable example
* refactor: 💡 rename without embeddable example
* feat: 🎸 set up no-embeddable single click example
* feat: 🎸 add dashboard drilldown to single button example
* fix: 🐛 remove unused margin
* fix: 🐛 make "Get more actions" translation static
* chore: 🤖 remove old dashboard drilldown definition
* refactor: 💡 rename samples to generic names
* refactor: 💡 make app 1 example drilldown "hello world"
* chore: 🤖 remove unused required bundle
* chore: 🤖 add dashboardEnhanced back
* [kbn/optimizer] only build xpack examples when building xpack plugins
* move alerting_example into x-pack/examples
* remove filter for alertingExample plugin in oss plugins CI step
* revert unrelated change
* fix: 🐛 use correct prop name
* test: 💍 fix embeddable-to-dashboard drilldown mock
* test: 💍 fix a test after refactor
* chore: 🤖 remove unused import
* chore: 🤖 add dashboard_enahcned to example plugin
* chore: 🤖 address review comments
* feat: 🎸 add description to UI Actions Enhanced examples
* docs: ✏️ improve docs of example plugin
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 16:31:30 +02:00
Anton Dosov
4d5a9df76c
@testing-library remove "pure" hack ( #78742 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 13:49:05 +02:00
Nathan L Smith
564a7b1a17
Storybook 6 and config changes ( #75357 )
...
Upgrade to Storybook 6 and attempt to use the declarative configuration.
The goals of this PR (as part of Kibana's Storybook roadmap, are:
Upgrade to Storybook 6
Still allow running Storybooks with yarn storybook plugin_name
Use the declarative configuration to (hopefully) make the configuration simpler to use an easier to understand, as well as avoiding deprecation warnings and loss of future compatibility
The ways in which what I have so far differs from how we do things today are:
In the alias configuration it takes a path to a storybook configuration directory instead of the storybook.js file from before
Each plugin (it doesn't have to be a plugin; can be any directory) has a .storybook/main.js (the aliases file in @kbn/storybook specifies these locations) where they can define their Storybook configuration. You can require('@kbn/storybook').defaultConfig to get defaults and override them
@kbn/storybook has a preset that can provide Webpack and Babel configuration and Storybook parameters and decorators
Instead of dynamically creating the list of stories to import, we define them in the globs of the stories property in .storybook/main.js.
Do not build a DLL. We are using @kbn/ui-shared-deps as externals. Startup time is not quite as fast but still acceptable.
Other things done in this PR:
Allow default exports in .stories. to allow for Common Story Format CSF stories
Add guard in Webpack configuration needed for overriding CSS rules
Update filename casing check to allow for files with required names in Storybook
Clean up observability stories
Rename *.examples.tsx and *.story.tsx to *.stories.tsx
2020-09-29 19:34:05 -05:00
Vadim Dalecky
4b49e5a1c8
Context menu ( #76497 )
...
* feat: 🎸 add grouping to presentable interface
* feat: 🎸 add group to "Explore underlying" data action
* refactor: 💡 return panel list and simplify context creation
* refactor: 💡 simplify context menu builder code
* refactor: 💡 further simplify context menu builder code
* feat: 🎸 add grouping to context menu builder
* feat: 🎸 add icon to drilldowns group
* fix: 🐛 sort in the other order
* feat: 🎸 group drilldown actions in edit mode
* fix: 🐛 fix TypeScript error
* feat: 🎸 wrap long context menu list into a submenu
* feat: 🎸 improve context menu long list wrapping
* feat: 🎸 display drilldowns panel at the bottom of main panel
* feat: 🎸 add separator line for context menu
* test: 💍 add basic context menu builder unit tests
* feat: 🎸 remove meta decoratiosn from generated menu
* test: 💍 add test subject attribute to "More" menu item
* chore: 🤖 remove separator line and add comment about EUI
* test: 💍 update Jest snapshots
* chore: 🤖 revert back change of showing both drilldown options
* test: 💍 add context menu samples to example plugin
* feat: 🎸 collapse long groups into a sub-panel
* test: 💍 add context menu panel edit mode examples
* test: 💍 fix OSS functional test
* test: 💍 fix X-Pack functional tests
* fix: 🐛 re-introduce item sorting by title
* test: 💍 allow explicitly opening more menu
* test: 💍 try opening more panel in functional tests
* test: 💍 disable some tests
* chore: 🤖 remove unused code
* test: 💍 use action test helper in unit tests
* refactor: 💡 add helper utility to generate actions in examples
* test: 💍 disable one more functional test
* test: 💍 improve how inspector is opened in functional tests
* test: 💍 enable functional test
* refactor: 💡 convert test suite to typescript
* test: 💍 move panel replace tests into a separate test suite
* test: 💍 move panel cloning tests to a separate test suite
* test: 💍 set up dashboard context menu test suite
* test: 💍 enable few panel context menu tests
* test: 💍 enable saved search panel tests
* test: 💍 enable expanded panel context menu tests
* test: 💍 remove render complete awaits
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-21 15:42:46 +02:00
Peter Pisljar
e361035650
Embeddable telemetry and reference extraction/injection ( #74352 )
2020-09-18 17:43:00 +02:00
Anton Dosov
e7d80e7e70
[Drilldowns] URL drilldown MVP ( #75450 )
2020-09-04 13:52:41 +02:00
Peter Pisljar
40d8edc2a0
cleaning up embeddable types ( #75560 )
2020-08-25 09:31:03 +02:00
Stacey Gammon
4ffef0a481
Add asciidoc support for generated plugin list ( #72292 )
...
* add asciidoc support for generated plugin list
Try level offset "=+2" instead of "=+1" to stop the inlining of the includes.
remove +2 back to +1
* Remove asciidoc, switch to regex. Rearrange dev guide to avoid nesting limit.
* Add tests for regex
* add a description to not throw off the table. Remove the heading from the paragraph snippet.
* Fix more READMEs so table renders correctly
* Update plugin list
* Remove code-exploration file, moved to plugin-list
* fix typo
* Add link to developer examples
* Update plugin list
* fix typo
2020-08-24 11:31:27 -04:00
Anton Dosov
3c5f2e7e7b
[Drilldowns] Trigger picker ( #74751 )
...
Drilldowns now support trigger picker. It allows to create a drilldown and specify which trigger it should be attached to.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 14:47:25 +02:00
Tim Roes
f9fc83fb1d
Add README files for Kibana app plugins ( #74277 )
...
* Add README files for Kibana app plugins
* Update src/plugins/timelion/README.md
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
* Update src/plugins/vis_type_vislib/README.md
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
2020-08-05 14:28:56 +02:00
Anton Dosov
abfda1f792
Use "Apply_filter_trigger" in dashboard drilldown ( #71468 )
...
* attach dashboard drilldown to apply filter trigger
* fix types
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 09:57:04 +02:00
Spencer
fa93a81ba6
[kbn/optimizer] implement "requiredBundles" property of KP plugins ( #70911 )
...
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 18:43:17 -07:00
Vadim Dalecky
8a6a55097d
Enable "Explore underlying data" actions for Lens visualizations ( #70047 )
...
* refactor: 💡 rename folder to "explore_data"
* style: 💄 check for "share" plugin in more semantic way
"explore data" actions use Discover URL generator, which is registered
in "share" plugin, which is optional plugin, so we check for its
existance, because otherwise URL generator is not available.
* refactor: 💡 move KibanaURL to a separate file
* feat: 🎸 add "Explore underlying data" in-chart action
* fix: 🐛 fix imports after refactor
* feat: 🎸 add start.filtersFromContext to embeddable plugin
* feat: 🎸 add type checkers to data plugin
* feat: 🎸 better handle empty filters in Discover URL generator
* feat: 🎸 implement .getUrl() method of explore data in-chart act
* feat: 🎸 add embeddable.filtersAndTimeRangeFromContext()
* feat: 🎸 improve getUrl() method of explore data action
* test: 💍 update test mock
* fix possible stale hashHistory.location in discover
* style: 💄 ensureHashHistoryLocation -> syncHistoryLocations
* docs: ✏️ update autogenerated docs
* test: 💍 add in-chart "Explore underlying data" unit tests
* test: 💍 add in-chart "Explore underlying data" functional tests
* test: 💍 clean-up custom time range after panel action tests
* chore: 🤖 fix embeddable plugin mocks
* chore: 🤖 fix another mock
* test: 💍 add support for new action to pie chart service
* feat: 🎸 enable "Explore underlying data" action for Lens vis
* test: 💍 make tests green again
* refactor: 💡 rename trigger contexts
* chore: 🤖 fix TypeScript errors
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-01 12:16:23 +02:00
patrykkopycinski
cc4c1729d1
Bump jest related packages ( #58095 )
2020-06-20 21:05:09 +02:00
Anton Dosov
f33192d35f
[refactor] remove drilldown plugin, move components to uiActionsEnhanced ( #69403 )
...
* refactor: remove drilldown plugin by moving components to uiActionsEnhanced
* fix
* fix mistake in test
* fix i18n
2020-06-18 15:35:22 +02:00
Vadim Dalecky
99a6435daf
advanced_ui_actions 👉 ui_actions_enhanced ( #68258 )
...
* chore: 🤖 rename advanced_ui_actions to ui_actions_enhanced
* chore: 🤖 rename exported interface to "enhanced"
2020-06-05 13:14:01 +02:00
restrry
bf04235dae
apply prettier styles
2020-05-22 09:08:58 +02:00
Joe Reuter
52070091f4
Lens drilldowns ( #65675 )
2020-05-15 12:01:27 +02:00
Joe Reuter
b7e87c2c8b
Switch to core application service ( #63443 )
2020-05-13 09:19:24 +02:00
Anton Dosov
0f5c1ed95a
[Drilldowns][chore] Remove some any's from components. Remove PlaceContext
from components ( #65854 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-12 10:57:49 +02:00
Anton Dosov
387e28a6a4
[Drilldowns][chore] import dashboard url generator from plugin contract ( #64628 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-11 10:12:59 +02:00
Vadim Dalecky
360b9c1200
Drilldowns ( #61219 )
...
* Add drilldown wizard components
* Dynamic actions (#58216 )
* feat: 🎸 add DynamicAction and FactoryAction types
* feat: 🎸 add Mutable<T> type to @kbn/utility-types
* feat: 🎸 add ActionInternal and ActionContract
* chore: 🤖 remove unused file
* feat: 🎸 improve action interfaces
* docs: ✏️ add JSDocs
* feat: 🎸 simplify ui_actions interfaces
* fix: 🐛 fix TypeScript types
* feat: 🎸 add AbstractPresentable interface
* feat: 🎸 add AbstractConfigurable interface
* feat: 🎸 use AbstractPresentable in ActionInternal
* test: 💍 fix ui_actions Jest tests
* feat: 🎸 add state container to action
* perf: ⚡ ️ convert MenuItem to React component on Action instance
* refactor: 💡 rename AbsractPresentable -> Presentable
* refactor: 💡 rename AbstractConfigurable -> Configurable
* feat: 🎸 add Storybook to ui_actions
* feat: 🎸 add <ErrorConfigureAction> component
* feat: 🎸 improve <ConfigureAction> component
* chore: 🤖 use .story file extension prefix for Storybook
* feat: 🎸 improve <ErrorConfigureAction> component
* feat: 🎸 show error if dynamic action has CollectConfig missing
* feat: 🎸 render sample action configuration component
* feat: 🎸 connect action config to <ConfigureAction>
* feat: 🎸 improve <ConfigureAction> stories
* test: 💍 add ActionInternal serialize/deserialize tests
* feat: 🎸 add ActionContract
* feat: 🎸 split action Context into Execution and Presentation
* fix: 🐛 fix TypeScript error
* refactor: 💡 extract state container hooks to module scope
* docs: ✏️ fix typos
* chore: 🤖 remove Mutable<t> type
* test: 💍 don't cast to any getActions() function
* style: 💄 avoid using unnecessary types
* chore: 🤖 address PR review comments
* chore: 🤖 rename ActionContext generic
* chore: 🤖 remove order from state container
* chore: 🤖 remove deprecation notice on getHref
* test: 💍 fix tests after order field change
* remove comments
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Drilldown context menu (#59638 )
* fix: 🐛 fix TypeScript error
* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
* fix: 🐛 correctly order context menu items
* fix: 🐛 set correct order on drilldown flyout actions
* fix: 🐛 clean up context menu building functions
* feat: 🎸 add context menu separator action
* Add basic ActionFactoryService. Pass data from it into components instead of mocks
* Dashboard x pack (#59653 )
* feat: 🎸 add dashboard_enhanced plugin to x-pack
* feat: 🎸 improve context menu separator
* feat: 🎸 move drilldown flyout actions to dashboard_enhanced
* fix: 🐛 fix exports from ui_actions plugin
* feat: 🎸 "implement" registerDrilldown() method
* fix ConfigurableBaseConfig type
* Implement connected flyout_manage_drilldowns component
* Simplify connected flyout manage drilldowns component. Remove intermediate component
* clean up data-testid workaround in new components
* Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
* require `context` in Presentable. drill context down through wizard components
* Drilldown factory (#59823 )
* refactor: 💡 import storage interface from ui_actions plugin
* refactor: 💡 make actions not-dynamic
* feat: 🎸 fix TypeScript errors, reshuffle types and code
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript import error
* Drilldown registration (#59834 )
* feat: 🎸 improve drilldown registration method
* fix: 🐛 set up translations for dashboard_enhanced plugin
* Drilldown events 3 (#59854 )
* feat: 🎸 add serialize/unserialize to action
* feat: 🎸 pass in uiActions service into Embeddable
* feat: 🎸 merge ui_actions oss and basic plugins
* refactor: 💡 move action factory registry to OSS
* fix: 🐛 fix TypeScript errors
* Drilldown events 4 (#59876 )
* feat: 🎸 mock sample drilldown execute methods
* feat: 🎸 add .dynamicActions manager to Embeddable
* feat: 🎸 add first version of dynamic action manager
* Drilldown events 5 (#59885 )
* feat: 🎸 display drilldowns in context menu only on one embed
* feat: 🎸 clear dynamic actions from registry when embed unloads
* fix: 🐛 fix OSS TypeScript errors
* basic integration of components with dynamicActionManager
* fix: 🐛 don't overwrite explicitInput with combined input (#59938 )
* display drilldown count in embeddable edit mode
* display drilldown count in embeddable edit mode
* improve wizard components. more tests.
* partial progress, dashboard drilldowns (#59977 )
* partial progress, dashboard drilldowns
* partial progress, dashboard drilldowns
* feat: 🎸 improve dashboard drilldown setup
* feat: 🎸 wire in services into dashboard drilldown
* chore: 🤖 add Storybook to dashboard_enhanced
* feat: 🎸 create presentational <DashboardDrilldownConfig>
* test: 💍 add <DashboardDrilldownConfig> stories
* test: 💍 use presentation dashboar config component
* feat: 🎸 wire in services into React component
* docs: ✏️ add README to /components folder
* feat: 🎸 increase importance of Dashboard drilldown
* feat: 🎸 improve icon definition in drilldowns
* chore: 🤖 remove unnecessary comment
* chore: 🤖 add todos
Co-authored-by: streamich <streamich@gmail.com>
* Manage drilldowns toasts. Add basic error handling.
* support order in action factory selector
* fix column order in manage drilldowns list
* remove accidental debug info
* bunch of nit ui fixes
* Drilldowns reactive action manager (#60099 )
* feat: 🎸 improve isConfigValid return type
* feat: 🎸 make DynamicActionManager reactive
* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
* feat: 🎸 make panel top-right corner number badge reactive
* fix: 🐛 correctly await for .deleteEvents()
* Drilldowns various 2 (#60103 )
* chore: 🤖 address review comments
* test: 💍 fix embeddable_panel.test.tsx tests
* chore: 🤖 clean up ActionInternal
* chore: 🤖 make isConfigValid a simple predicate
* chore: 🤖 fix TypeScript type errors
* test: 💍 stub DynamicActionManager tests (#60104 )
* Drilldowns review 1 (#60139 )
* refactor: 💡 improve generic types
* fix: 🐛 don't overwrite icon
* fix: 🐛 fix x-pack TypeScript errors
* fix: 🐛 fix TypeScript error
* fix: 🐛 correct merge
* Drilldowns various 4 (#60264 )
* feat: 🎸 hide "Create drilldown" from context menu when needed
* style: 💄 remove AnyDrilldown type
* feat: 🎸 add drilldown factory context
* chore: 🤖 remove sample drilldown
* fix: 🐛 increase spacing between action factory picker
* workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
* fix react key issue in action_wizard
* don’t open 2 flyouts
* fix action order
https://github.com/elastic/kibana/issues/60138
* Drilldowns reload stored (#60336 )
* style: 💄 don't use double equals __
* feat: 🎸 add reload$ to ActionStorage interface
* feat: 🎸 add reload$ to embeddable event storage
* feat: 🎸 add storage syncing to DynamicActionManager
* refactor: 💡 use state from DynamicActionManager in React
* fix: 🐛 add check for manager being stopped
* Drilldowns triggers (#60339 )
* feat: 🎸 make use of supportedTriggers()
* feat: 🎸 pass in context to configuration component
* feat: 🎸 augment factory context
* fix: 🐛 stop infinite re-rendering
* Drilldowns multitrigger (#60357 )
* feat: 🎸 add support for multiple triggers
* feat: 🎸 enable Drilldowns for TSVB
Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7
* "Create drilldown" flyout - design cleanup (#60309 )
* create drilldown flyout cleanup
* remove border from selectedActionFactoryContainer
* adjust callout in DrilldownHello
* update form labels
* remove unused file
* fix type error
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* basic unit tests for flyout_create_drildown action
* Drilldowns finalize (#60371 )
* fix: 🐛 align flyout content to left side
* fix: 🐛 move context menu item number 1px lower
* fix: 🐛 move flyout back nav chevron up
* fix: 🐛 fix type check after refactor
* basic unit tests for drilldown actions
* Drilldowns finalize 2 (#60510 )
* test: 💍 fix test mock
* chore: 🤖 remove unused UiActionsService methods
* refactor: 💡 cleanup UiActionsService action registration
* fix: 🐛 add missing functionality after refactor
* test: 💍 add action factory tests
* test: 💍 add DynamicActionManager tests
* feat: 🎸 capture error if it happens during initial load
* fix: 🐛 register correctly CSV action
* feat: 🎸 don't show "OPTIONS" title on drilldown context menus
* feat: 🎸 add server-side for x-pack dashboard plugin
* feat: 🎸 disable Drilldowns for TSVB
* feat: 🎸 enable drilldowns on kibana.yml feature flag
* feat: 🎸 add feature flag comment to kibana.yml
* feat: 🎸 remove places from drilldown interface
* refactor: 💡 remove place in factory context
* chore: 🤖 remove doExecute
* remove not needed now error_configure_action component
* remove workaround for storybook
* feat: 🎸 improve DrilldownDefinition interface
* style: 💄 replace any by unknown
* chore: 🤖 remove any
* chore: 🤖 make isConfigValid return type a boolean
* refactor: 💡 move getDisplayName to factory, remove deprecated
* style: 💄 remove any
* feat: 🎸 improve ActionFactoryDefinition
* refactor: 💡 change visualize_embeddable params
* feat: 🎸 add dashboard dependency to dashboard_enhanced
* style: 💄 rename drilldown plugin life-cycle contracts
* refactor: 💡 do naming adjustments for dashboard drilldown
* fix: 🐛 fix Type error
* fix: 🐛 fix TypeScript type errors
* test: 💍 fix test after refactor
* refactor: 💡 rename context -> placeContext in React component
* chore: 🤖 remove setting from kibana.yml
* refactor: 💡 change return type of getAction as per review
* remove custom css per review
* refactor: 💡 rename drilldownCount to eventCount
* style: 💄 remove any
* refactor: 💡 change how uiActions are passed to vis embeddable
* style: 💄 remove unused import
* fix: 🐛 pass in uiActions to visualize_embeddable
* fix: 🐛 correctly register action
* fix: 🐛 fix type error
* chore: 🤖 remove unused translations
* Dynamic actions to xpack (#62647 )
* feat: 🎸 set up sample action factory provider
* feat: 🎸 create dashboard_enhanced plugin
* feat: 🎸 add EnhancedEmbeddable interface
* refactor: 💡 move DynamicActionManager to x-pack
* feat: 🎸 connect dynamic action manager to embeddable life-cycle
* test: 💍 fix Jest tests after refactor
* fix: 🐛 fix type error
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* refactor: 💡 move action factories to x-pack (#63190 )
* refactor: 💡 move action factories to x-pack
* fix: 🐛 use correct plugin embeddable deps
* test: 💍 fix Jest test after refactor
* chore: 🤖 remove kibana.yml flag (#62441 )
* Panel top right (#63466 )
* feat: 🎸 add PANEL_NOTIFICATION_TRIGGER
* feat: 🎸 add PanelNotificationsAction action
* test: 💍 add PanelNotificationsAction unit tests
* refactor: 💡 revert addTriggerAction() change
* style: 💄 remove unused import
* fix: 🐛 fix typecheck errors after merge
* support getHref in drilldowns (#63727 )
* chore: 🤖 remove ui_actions storybook config
* update docs
* fix ts
* fix: 🐛 fix broken merge
* [Drilldowns] Dashboard to dashboard drilldown (#63108 )
* partial progress on async loading / searching of dashboard titles
* feat: 🎸 make combobox full width
* filtering combobox polish
* storybook fix
* implement navigating to dashboard, seems like a type problem
* try navToApp
* filter out current dashboard
* rough draft linking to a dashboard
* remove note
* typefix
* fix navigation from dashboard to dashboard
except for back button - that would be addressed separatly
* partial progress getting filters from action data
* fix issue with getIndexPatterns undefined
we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull
* fix filter / time passing into url
* typefix
* dashboard to dashboard drilldown functional test and back button fix
* documentation update
* chore clean-ups
fix type
* basic unit test for dashboard drilldown
* remove test todos
decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env
* remove config
* improve back button with filter comparison tweak
* dashboard filters/date option off by default
* revert change to config/kibana.yml
* remove unneeded comments
* use default time range as appropriate
* fix type, add filter icon, add text
* fix test
* change how time range is restored and improve back button for drilldowns
* resolve conflicts
* fix async compile issue
* remove redundant test
* wip
* wip
* fix
* temp skip tests
* fix
* handle missing dashboard edge case
* fix api
* refactor action filter creation utils
* updating
* updating docs
* improve
* fix storybook
* post merge fixes
* fix payload emitted in brush event
* properly export createRange action
* improve tests
* add test
* post merge fixes
* improve
* fix
* improve
* fix build
* wip getHref support
* implement getHref()
* give proper name to a story
* use sync start services
* update text
* fix types
* fix ts
* fix docs
* move clone below drilldowns (near replace)
* remove redundant comments
* refactor action filter creation utils
* updating
* updating docs
* fix payload emitted in brush event
* properly export createRange action
* some more updates
* fixing types
* ...
* inline EventData
* fix typescript in lens and update docs
* improve filters types
* docs
* merge
* @mdefazio review
* adjust actions order
* docs
* @stacey-gammon review
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: streamich <streamich@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
* fix docs
* nit fixes
* chore: 🤖 remove uiActions from Embeddable dependencies
* chore: 🤖 don't export ActionInternal from ui_actions
* test: 💍 remove uiActions deps in x-pack test mocks
* chore: 🤖 cleanup ui_actions types
* docs: ✏️ add JSDoc comment to addTriggerAction()
* docs: ✏️ regenerate docs
* Drilldown demo 2 (#64300 )
* chore: 🤖 add example of Discover drilldown to sample plugin
* fix: 🐛 show drilldowns with higher "order" first
* feat: 🎸 add createStartServicesGetter() to /public kibana_util
* feat: 🎸 load index patterns in Discover drilldown
* feat: 🎸 add toggle for index pattern selection
* feat: 🎸 add spacer to separate unrelated config fields
* fix: 🐛 correctly configre setup core
* feat: 🎸 navigate to correct index pattern
* chore: 🤖 fix type check errors
* fix: 🐛 make index pattern select full width
* fix: 🐛 add getHref support
* feat: 🎸 add example plugin ability to X-Pack
* refactor: 💡 move Discover drilldown example to X-Pack
* feat: 🎸 add dashboard-to-url drilldown example
* feat: 🎸 add new tab support for URL drilldown
* feat: 🎸 add "hello world" drilldown example
* docs: ✏️ add README
* feat: 🎸 add getHref support
* chore: 🤖 cleanup after moving examples to X-Pack
* docs: ✏️ add to README.md info on how to find drilldowns
* feat: 🎸 store events in .enhancements field
* docs: ✏️ add comment to range trigger title
* refactor: 💡 move Configurable interface into kibana_utils
* chore: 🤖 simplify internal component types
* refactor: 💡 move registerDrilldwon() to advanced_ui_actions
* test: 💍 update functional test data
* merge
* docs: ✏️ make drilldown enhancement comment more general
* fix: 🐛 return public type from registerAction() call
* docs: ✏️ add comment to value click trigger title field
* docs: ✏️ improve comment
* fix: 🐛 use second argument of CollectConfigProps interface
* fix: 🐛 add workaround for Firefox rendering issue
See:
https://github.com/elastic/kibana/pull/61219/#pullrequestreview-402903330
* chore: 🤖 delete unused file
* fix: 🐛 import type from new location
* style: 💄 make generic type variable name sconsistent
* fix: 🐛 show "Create drilldown" only on dashboard
* test: 💍 add extra unit test for root embeddable type
* docs: ✏️ update generated docs
* chore: 🤖 add example warnings to sample drilldowns
* docs: ✏️ add links to example warnings
* feat: 🎸 add URL drilldown validation and https:// prefixing
* fix: 🐛 disable drilldowns for lens
* refactor: 💡 remove PlaceContext from DrilldownDefinition
* fix: 🐛 fix type check error
* feat: 🎸 show warning message if embeddable not provided
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
2020-05-04 16:11:20 +02:00
Matthew Kime
498abb4152
Revert "Drilldowns ( #59632 )" ( #61136 )
...
This reverts commit 5abb2c8c7d
.
2020-03-24 16:22:11 -05:00
Vadim Dalecky
5abb2c8c7d
Drilldowns ( #59632 )
...
* Add drilldown wizard components
* Dynamic actions (#58216 )
* feat: 🎸 add DynamicAction and FactoryAction types
* feat: 🎸 add Mutable<T> type to @kbn/utility-types
* feat: 🎸 add ActionInternal and ActionContract
* chore: 🤖 remove unused file
* feat: 🎸 improve action interfaces
* docs: ✏️ add JSDocs
* feat: 🎸 simplify ui_actions interfaces
* fix: 🐛 fix TypeScript types
* feat: 🎸 add AbstractPresentable interface
* feat: 🎸 add AbstractConfigurable interface
* feat: 🎸 use AbstractPresentable in ActionInternal
* test: 💍 fix ui_actions Jest tests
* feat: 🎸 add state container to action
* perf: ⚡ ️ convert MenuItem to React component on Action instance
* refactor: 💡 rename AbsractPresentable -> Presentable
* refactor: 💡 rename AbstractConfigurable -> Configurable
* feat: 🎸 add Storybook to ui_actions
* feat: 🎸 add <ErrorConfigureAction> component
* feat: 🎸 improve <ConfigureAction> component
* chore: 🤖 use .story file extension prefix for Storybook
* feat: 🎸 improve <ErrorConfigureAction> component
* feat: 🎸 show error if dynamic action has CollectConfig missing
* feat: 🎸 render sample action configuration component
* feat: 🎸 connect action config to <ConfigureAction>
* feat: 🎸 improve <ConfigureAction> stories
* test: 💍 add ActionInternal serialize/deserialize tests
* feat: 🎸 add ActionContract
* feat: 🎸 split action Context into Execution and Presentation
* fix: 🐛 fix TypeScript error
* refactor: 💡 extract state container hooks to module scope
* docs: ✏️ fix typos
* chore: 🤖 remove Mutable<t> type
* test: 💍 don't cast to any getActions() function
* style: 💄 avoid using unnecessary types
* chore: 🤖 address PR review comments
* chore: 🤖 rename ActionContext generic
* chore: 🤖 remove order from state container
* chore: 🤖 remove deprecation notice on getHref
* test: 💍 fix tests after order field change
* remove comments
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Drilldown context menu (#59638 )
* fix: 🐛 fix TypeScript error
* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
* fix: 🐛 correctly order context menu items
* fix: 🐛 set correct order on drilldown flyout actions
* fix: 🐛 clean up context menu building functions
* feat: 🎸 add context menu separator action
* Add basic ActionFactoryService. Pass data from it into components instead of mocks
* Dashboard x pack (#59653 )
* feat: 🎸 add dashboard_enhanced plugin to x-pack
* feat: 🎸 improve context menu separator
* feat: 🎸 move drilldown flyout actions to dashboard_enhanced
* fix: 🐛 fix exports from ui_actions plugin
* feat: 🎸 "implement" registerDrilldown() method
* fix ConfigurableBaseConfig type
* Implement connected flyout_manage_drilldowns component
* Simplify connected flyout manage drilldowns component. Remove intermediate component
* clean up data-testid workaround in new components
* Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
* require `context` in Presentable. drill context down through wizard components
* Drilldown factory (#59823 )
* refactor: 💡 import storage interface from ui_actions plugin
* refactor: 💡 make actions not-dynamic
* feat: 🎸 fix TypeScript errors, reshuffle types and code
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript import error
* Drilldown registration (#59834 )
* feat: 🎸 improve drilldown registration method
* fix: 🐛 set up translations for dashboard_enhanced plugin
* Drilldown events 3 (#59854 )
* feat: 🎸 add serialize/unserialize to action
* feat: 🎸 pass in uiActions service into Embeddable
* feat: 🎸 merge ui_actions oss and basic plugins
* refactor: 💡 move action factory registry to OSS
* fix: 🐛 fix TypeScript errors
* Drilldown events 4 (#59876 )
* feat: 🎸 mock sample drilldown execute methods
* feat: 🎸 add .dynamicActions manager to Embeddable
* feat: 🎸 add first version of dynamic action manager
* Drilldown events 5 (#59885 )
* feat: 🎸 display drilldowns in context menu only on one embed
* feat: 🎸 clear dynamic actions from registry when embed unloads
* fix: 🐛 fix OSS TypeScript errors
* basic integration of components with dynamicActionManager
* fix: 🐛 don't overwrite explicitInput with combined input (#59938 )
* display drilldown count in embeddable edit mode
* display drilldown count in embeddable edit mode
* improve wizard components. more tests.
* partial progress, dashboard drilldowns (#59977 )
* partial progress, dashboard drilldowns
* partial progress, dashboard drilldowns
* feat: 🎸 improve dashboard drilldown setup
* feat: 🎸 wire in services into dashboard drilldown
* chore: 🤖 add Storybook to dashboard_enhanced
* feat: 🎸 create presentational <DashboardDrilldownConfig>
* test: 💍 add <DashboardDrilldownConfig> stories
* test: 💍 use presentation dashboar config component
* feat: 🎸 wire in services into React component
* docs: ✏️ add README to /components folder
* feat: 🎸 increase importance of Dashboard drilldown
* feat: 🎸 improve icon definition in drilldowns
* chore: 🤖 remove unnecessary comment
* chore: 🤖 add todos
Co-authored-by: streamich <streamich@gmail.com>
* Manage drilldowns toasts. Add basic error handling.
* support order in action factory selector
* fix column order in manage drilldowns list
* remove accidental debug info
* bunch of nit ui fixes
* Drilldowns reactive action manager (#60099 )
* feat: 🎸 improve isConfigValid return type
* feat: 🎸 make DynamicActionManager reactive
* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
* feat: 🎸 make panel top-right corner number badge reactive
* fix: 🐛 correctly await for .deleteEvents()
* Drilldowns various 2 (#60103 )
* chore: 🤖 address review comments
* test: 💍 fix embeddable_panel.test.tsx tests
* chore: 🤖 clean up ActionInternal
* chore: 🤖 make isConfigValid a simple predicate
* chore: 🤖 fix TypeScript type errors
* test: 💍 stub DynamicActionManager tests (#60104 )
* Drilldowns review 1 (#60139 )
* refactor: 💡 improve generic types
* fix: 🐛 don't overwrite icon
* fix: 🐛 fix x-pack TypeScript errors
* fix: 🐛 fix TypeScript error
* fix: 🐛 correct merge
* Drilldowns various 4 (#60264 )
* feat: 🎸 hide "Create drilldown" from context menu when needed
* style: 💄 remove AnyDrilldown type
* feat: 🎸 add drilldown factory context
* chore: 🤖 remove sample drilldown
* fix: 🐛 increase spacing between action factory picker
* workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
* fix react key issue in action_wizard
* don’t open 2 flyouts
* fix action order
https://github.com/elastic/kibana/issues/60138
* Drilldowns reload stored (#60336 )
* style: 💄 don't use double equals __
* feat: 🎸 add reload$ to ActionStorage interface
* feat: 🎸 add reload$ to embeddable event storage
* feat: 🎸 add storage syncing to DynamicActionManager
* refactor: 💡 use state from DynamicActionManager in React
* fix: 🐛 add check for manager being stopped
* Drilldowns triggers (#60339 )
* feat: 🎸 make use of supportedTriggers()
* feat: 🎸 pass in context to configuration component
* feat: 🎸 augment factory context
* fix: 🐛 stop infinite re-rendering
* Drilldowns multitrigger (#60357 )
* feat: 🎸 add support for multiple triggers
* feat: 🎸 enable Drilldowns for TSVB
Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7
* "Create drilldown" flyout - design cleanup (#60309 )
* create drilldown flyout cleanup
* remove border from selectedActionFactoryContainer
* adjust callout in DrilldownHello
* update form labels
* remove unused file
* fix type error
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* basic unit tests for flyout_create_drildown action
* Drilldowns finalize (#60371 )
* fix: 🐛 align flyout content to left side
* fix: 🐛 move context menu item number 1px lower
* fix: 🐛 move flyout back nav chevron up
* fix: 🐛 fix type check after refactor
* basic unit tests for drilldown actions
* Drilldowns finalize 2 (#60510 )
* test: 💍 fix test mock
* chore: 🤖 remove unused UiActionsService methods
* refactor: 💡 cleanup UiActionsService action registration
* fix: 🐛 add missing functionality after refactor
* test: 💍 add action factory tests
* test: 💍 add DynamicActionManager tests
* feat: 🎸 capture error if it happens during initial load
* fix: 🐛 register correctly CSV action
* feat: 🎸 don't show "OPTIONS" title on drilldown context menus
* feat: 🎸 add server-side for x-pack dashboard plugin
* feat: 🎸 disable Drilldowns for TSVB
* feat: 🎸 enable drilldowns on kibana.yml feature flag
* feat: 🎸 add feature flag comment to kibana.yml
* feat: 🎸 remove places from drilldown interface
* refactor: 💡 remove place in factory context
* chore: 🤖 remove doExecute
* remove not needed now error_configure_action component
* remove workaround for storybook
* feat: 🎸 improve DrilldownDefinition interface
* style: 💄 replace any by unknown
* chore: 🤖 remove any
* chore: 🤖 make isConfigValid return type a boolean
* refactor: 💡 move getDisplayName to factory, remove deprecated
* style: 💄 remove any
* feat: 🎸 improve ActionFactoryDefinition
* refactor: 💡 change visualize_embeddable params
* feat: 🎸 add dashboard dependency to dashboard_enhanced
* style: 💄 rename drilldown plugin life-cycle contracts
* refactor: 💡 do naming adjustments for dashboard drilldown
* fix: 🐛 fix Type error
* fix: 🐛 fix TypeScript type errors
* test: 💍 fix test after refactor
* refactor: 💡 rename context -> placeContext in React component
* chore: 🤖 remove setting from kibana.yml
* refactor: 💡 change return type of getAction as per review
* remove custom css per review
* refactor: 💡 rename drilldownCount to eventCount
* style: 💄 remove any
* refactor: 💡 change how uiActions are passed to vis embeddable
* style: 💄 remove unused import
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
2020-03-24 08:31:29 +01:00