Commit graph

16012 commits

Author SHA1 Message Date
CJ Cenizal e724571426 Use aria-label in TSVB React components, instead of ariaLabel. (#13714) 2017-08-25 15:27:08 -07:00
Spencer 2eae80cd0c Upgrade Angular to 1.6.5 (#13543)
* [angular/$http] remove use of .success() and .error() callbacks

* [angular/$route] remove `!` hash prefix

* [angular] upgrade

* [angular/$timeout] prevent unhandled exception "canceled" logging

* [ui/fancy_form] refactor FormController for compatibility

* [ngModelController] ensure method calls keep context

* [ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit"

* [confirmModalPromise] fix test for rejected promise

* [watchMulti] specifically check watchers array for length

* [typeahead] check for property rather than own keys

* [ui/compat] add initAfterBindingsWorkaround

* [ui/fancyForms] fix _getInvalidModels()

* [fancyForm] add tests that check nested form error counting

* [ui/fancyForms] ensure that submit is blocked properly

* [ui/fancyForms] escalate soft errors on failed submit

* [ui/fancyForms] bind handlers to this in constructor

* [uiBootstrap/tooltip] describe the new error handling

* [ui/confirmModalPromise] use more sinon assertions

* [$http] resp => data before old .success() and .error() handlers

* [indices/createWizard] apply callAfterBindings workarounds
2017-08-25 14:50:11 -07:00
Spencer 8ba33e7eed remove old maps stuff (#13657) 2017-08-25 13:28:57 -07:00
Spencer f7721fe420 [visualize] Fix agg param race (#13429)
* [visualize/aggConfig] do not rely on the view to reset params

* [vis/editor/aggParams] check for agg and type before accessing
2017-08-25 12:54:36 -07:00
Nathan Reese 5619dbeaa9 Keep current cursor or top line in view when resizing Console to avoid losing user context (#13695)
* keep current cursor or top line in view when resizing to avoid losing user context

* rename variable to more descriptive name

* move state from editor to smart_resize
2017-08-25 12:32:24 -06:00
Nathan Reese 6115d8594d Map filter not set appropriately when spy panel is open (#13678)
* get dimensions from parent elements when map has not height or width

* clean up test variable names
2017-08-25 09:39:43 -06:00
Nathan Reese 51dd98931a Dashboard dark-theme fixes (#13690)
* fix 13421 - filter overlay obscuring saved search table

* fix 13553 - Dashboard dark theme borders in edit mode don't appear
2017-08-25 08:50:38 -06:00
Jonathan Budzenski 38b13c7a67 [console] Don't infer request method (#13694) 2017-08-25 09:41:27 -05:00
Tyler Smalley 3f84c89f03 Changes verbage for opening an existing pattern (#13697)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-08-25 07:18:38 -07:00
Tim Roes c96481d950 Allow reordering aggregation priority by keyboard (#13635)
* Make aggs sortable by keyboard, fix #11858

* Add keyboard_move tests

* Use $parse instead of creating a child scope

* Use keyCodes from ui_framework
2017-08-25 10:10:59 +02:00
Tim Roes 3b1e1e5a15 Refactor keycode exporting in ui_framework (#13663)
* Refactor keycode exporting in ui_framework

* Replace all uses of ENTER_KEY and SPACE_KEY

* Use ESCAPE instead of ESC universally

* Rename keycodes -> keyCodes

* Replace keyCodes in advanced_row
2017-08-24 21:25:52 +02:00
CJ Cenizal fcd4ddfb2d [Accessibility] Give kuiTables keyboard-accessible column headers (#13586)
* Make KuiTable headers keyboard-accessible in UI Framework.
* Use flexbox to consistently apply spacing between table header cell text and sort icon.
* Add aria-label attributes to KuiTableHeaderCell, KuiTableHeaderCheckBoxCell, and KuiTableRowCheckBoxCell.
* Update Jest snapshots.
* Update Dashboard listing table with new markup.
* Update Saved Objects tables with new markup.
* Update Settings table with new markup.
* Update Visualize listing table with new markup.
* Remove padding-right for cells containing checkboxes.
* Update sortableColumn directive with new markup.
2017-08-24 11:48:04 -07:00
Thomas Neirynck 741b5d4d8a exclude filter agg from visualizations (#13680) 2017-08-24 12:20:26 -04:00
Chris Roberson 9175137c57 "Create index pattern" wizard. (#13454)
* Create Index Pattern Creation wizard.
- Create a directive for each step in the wizard.
- Reorganize files into conventional folder structure.
- Rename files with more conventional and consistent naming patterns.
- Display indices, partial matches, exact matches.
- Add loading, empty, and success states.
- Add option to include system indices.

* Temp: comment out and mock getIndices functionality.

* Hook up data seaching

* Add for/id connections for form inputs and labels

* Automatically append a wildcard

* Highlight the index pattern in the results

* Ensure we only remove the last character if it's a `*`

* Auto hide index pattern id controls

* Ensure this link is tabbable

* Move the advanced fields down

* Use toggle button

* This shouldn't ever be required

* Revert "This shouldn't ever be required"

This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612.

* Update based on comments in PR

* Ffew more changes

* Port changes from Tyler's PR, https://github.com/elastic/kibana/pull/13353

* Remove unnecessary file

* Fix broken functional tests

* Copy changes

* Fix functional tests

* Remove loading from the main select, and move to an additional select

* Show help text when loading

* Fix sorting

* Fixing broken functional tests

* Couple changes from PR review

* Ensure input field does not show a red border until touched

* More descriptive and consistent copy
2017-08-24 09:04:28 -04:00
Tyler Smalley 4bbd127626 Removes webpack-directory-name-as-main dependency (#13584)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-08-23 08:21:32 -07:00
Tim Roes d3a62e85a5 Remove custom keyboard mode in datepicker (#13644) 2017-08-23 16:31:00 +02:00
Court Ewing 7b836f91b2 Shortcut to build asciidocs (#13164)
* Shortcut to build asciidocs

The command to build the Kibana docs using the elastic/docs repo can be
easy to forget, so this script is an easy to way to do it right every
time.

* Configurable docs repo location

For folks that clone the elastic docs repo to a different location than
as a sibling of kibana.
2017-08-23 10:27:34 -04:00
Peter Pisljar 4117520f18 don't hide metric if show labels is false (#13637) 2017-08-23 14:37:46 +02:00
Thomas Neirynck 094587c884 Add interval doc (#13629) 2017-08-22 23:42:36 -04:00
Johnny Lim 8cceb73710 Use "curl -O" for Darwin (#13602) 2017-08-22 17:49:15 -07:00
Nathan Reese 599c8c4220 Upgrade kibana to leaflet 1.x (#12367)
* upgrade leaflet modules to 1.x latest

* fix css for leaflet controls

* update draw options so it is easier to see polygon when drawing

* fix chrome touch issues with closing polygon in leaflet draw

* use canvas renderer

* use leaflet-responsive-popup to avoid tooltip cutoff

* remove radius configuration from leaflet heatmap

* make blur a factor of radius. Set maxZoom to map zoom since new values are calculated per precision

* use _.get to avoid error, cannot read property of undefined

* add cluster size slider

* experiments with image differences

* onload not onLoad

* use canvas dimensions

* compare map canvas to stored PNG of map canvas

* remove pixelmatch from project dependecies

* fix broken test - rounding error

* add expected image tests for geohash layers shaded circles and geohash grids

* bump z-index of vis-spy

* update functional test expected data

* update to leaflet 1.2.0

* revert to leaflet 1.0.3 and update expected data set for map functional tests

* test geohash_layer heatmap in unit test

* update region_map functional test since it can not longer pluck map vectors from DOM

* update documentation
2017-08-22 17:26:30 -06:00
Nathan Reese 0d281a7566 Replace "marked" with "markdown-it" (#13623)
* add markdown functional test

* update markdown vis to use markdown-it

* migrate markdown angular filter to markdown-it

* place other uses of marked and remove dependency

* update breaking changes documenation and set linkify to true
2017-08-22 16:29:40 -06:00
Tim Sullivan 49ba9e8e6e [UI Bundler] Add Aliases for Moment so plugins can use the same instance (#13628) 2017-08-22 09:25:33 -07:00
Matt Bargar 9890d22b13 Disable creation of "exists" filters for scripted fields (#13538)
* Disable exists filter button for scripted fields in doc viewer

* Disabled exists filter button for scripted fields in discover sidebar

* Fix reference to non-existent scope variable
2017-08-22 10:32:35 -04:00
Tim Roes 5514f34354 Show a warning for non accessible charts for screen readers (#13573)
* Show warning for non accessible visualizations, fix 13572

* Mark markdown vis as accessible
2017-08-22 11:24:51 +02:00
Spencer 9a349929d9 [chrome/nav/lastUrl] do not track redirect routes (#13432)
* [chrome/nav/lastUrl] do not track redirect routes

* [chrome/subUrl] always track subUrl when no router
2017-08-21 22:33:44 -07:00
Rashmi Kulkarni bf8fb46830 added a helper method- selectIndexPattern method (#13568)
* added selectIndexPattern method
* removed the additional sleep
2017-08-21 17:18:49 -07:00
Thomas Neirynck f6ba3d99e0 remove geo_bounds agg from visualizations (#13536)
* remove geo_bounds agg from visualizations

* remove from horizontal bar chart
2017-08-21 13:28:43 -04:00
CJ Cenizal 96a9160e91 Fix bug with Dashboard breadcrumb alignment. (#13580) 2017-08-21 09:02:20 -07:00
CJ Cenizal 45b10fb175 [UI Framework] Add KuiOutsideClickDetector (#13521)
* Add KuiOutsideClickDetector.
* Convert KuiColorPicker and KuiPopover to use KuiOutsideClickDetector.
2017-08-21 08:58:56 -07:00
Matt Bargar eeb4862224 Fix discover sidebar Visualize button for geo_point fields (#13539)
Fixes #12227

It seems the order of aggs is important now. I don't know the underlying cause here, I just saved a good and bad version of tilemap visualizations and compared the saved objects to figure out what changed.
2017-08-21 10:53:51 -04:00
Thomas Neirynck 5b43727804 fix available metric aggs (#13518) 2017-08-21 10:40:04 -04:00
Tim Roes 529a9e3ac4 Improve timelion accessibility (#13531)
* Fix broken refresh shortcut for non OS X

On non OS X systems, the e.metaKey is most likely the windows key.
Hotkeys with the windows key are usually used as global (non application
internal) hotkeys. Also the documentation states, that Ctrl + Enter
should also work. With this commit it doesn't matter whether you press
the Meta or the Ctrl key + Enter.

* Make timelion datepicker more accessible

* Add meaningful labels to each interval shortcut, and
* Add a proper label to the custom input text field

* Make save options keyboard accessible, fix #12246, fix #12487

* Make sort button of saved-object-finder accessible, fix #12486

* Label timelion options correctly, fix #12907

* Make timelion legends keyboard accessible, fix #11844

* Make timelion autocompletion properly accessible

Fixes #11533, fixes #11525, fixes #12908

* Make timelion charts and actions accessible, fix #12909

* Add some more inline comments

* Fix HTML styles according to styleguide

* Replace sr-only by kuiScreenReaderOnly

* Make timelion autocompletion work with ARIA 1.1
2017-08-21 11:53:28 +02:00
Spencer 8141e3fe4b [savedObjectClient] decorate non-es errors too (#13596) 2017-08-18 18:07:59 -07:00
CJ Cenizal 64a1e0cf7f [Accessibility] Make table pagination controls keyboard-accessible. (#13541)
* Make table pagination controls keyboard-accessible. Update KuiLink so it can be used on a button element.
* Add additional properties to link mixin to make kuiLink look the same for both buttons and anchor tags.
* Fix tests.
2017-08-18 17:11:36 -07:00
CJ Cenizal cb5f508e6b [UI Framework] [K7] Improve generator snippets (#13598) (#13599)
* Remove extraneous path info from SCSS import snippet.
* Add GuideCode to demo page. Put stateless function params on multiple lines.
* Log an error if you try to create a component with a blank name.
2017-08-18 16:12:53 -07:00
Chris Cowan 8aaa900854 Fixes #12866 - Use devicePixelRatio to scale up and down canvas values in TSVB (#13565) 2017-08-18 14:30:17 -07:00
Matt Bargar 9e48298844 Emphasize important difference between Kuery and Lucene query syntax (#13592)
Fixes #13563

Brings additional attention to the fact that Kuery uses implicit ANDs whereas Lucene query syntax uses implicit ORs, which could confuse users if they're not aware of the difference.
2017-08-18 16:45:28 -04:00
Chris Roberson abb54ac445 Fix breaking scope changes in the field format editor samples (#13549) 2017-08-18 14:47:40 -04:00
Chris Roberson e0708ab7da Add aria describes for warning label, #12864 (#13576) 2017-08-18 13:08:16 -04:00
Matt Bargar e7ca19586d Improves dark theme support in the filter editor (#13522)
Fixes #12955

* Added dark theme support to the ui framework modal component
* Also fixed z-index issue where dashboard panels would appear above the filter editor modal when the user moved or resized the panel (see gif below)
2017-08-18 11:05:40 -04:00
Jonathan Budzenski 61c3f38d32 [console] Replace text/plain fallback with application/json (#12294)
* [console] Always set content-type for requests to es

* [console] always set content type to application/json if there is a body

* remove extra space
2017-08-18 10:01:52 -05:00
Chris Cowan 7fb2d7f623 Duration Formatting for TSVB (#13337)
* Adding duration formatter

* Adding decimal places

* Fixing bug with decimals

* Relaxing the duration format test
2017-08-18 07:41:15 -07:00
Tim Roes ef67957119 Improve accessibility of visualizations (#13507)
* Fix markdown vis settings labels

* Fix contrast ratio of markdown blockquotes, #12491

* Fix fontsize of blockquotes in markdown, #12904

* Add vis type description for screen reader, fix #12887

The way tooltips are currently implemented we unfortunately cannot use
the tooltip for the aria-describedby. This is another issue to solve.

* Make main nav a11y when collapsed

* Camel case the vistype id used in HTML
2017-08-18 09:58:11 +02:00
Tim Roes f66c5dbd39 Improve Dev Tools accessibility (#13496)
* Make console actions accessible

Use a button isntead of a link will solve all accessibility issues, and
we just need to style the button the same way we style the links.

* Create kbnUiAceKeyboardModeService

This will be needed for situations in which the initialization need to
be started manually, and a simple directive won't be enough.

* Make console input box accessible

* Make editor_actions buttons instead of links
2017-08-18 09:54:24 +02:00
Spencer 375ee3b206 [ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit" (#13544) 2017-08-17 11:26:44 -07:00
Matt Bargar e09b91403c Fix fixed-scroll on Discover page (#13516)
Some CSS changes were made in #10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416
2017-08-17 12:50:22 -04:00
spalger 8cd269678a remove spammy console.log() 2017-08-16 19:32:34 -07:00
Tyler Smalley 911467a78e Prevents default index pattern name when ID is provided (#13353)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-08-16 09:51:16 -07:00
Jim Unger 0920a99a15 Adds getAriaName function and applies it to advanced settings (#13448) 2017-08-16 10:38:44 -05:00