Commit graph

21070 commits

Author SHA1 Message Date
Stacey Gammon
fb7dbaeb6a
Check for toast before waiting for page to finish loading to avoid mi… (#24424)
* Check for toast before waiting for page to finish loading to avoid missing the toast by the time the page finishes

* turn test back on
2018-10-30 09:57:55 -04:00
Walter Rafelsberger
a86998a0fc
[ML] Fixes missing y-axis description for rare chart. (#24823)
Fixes the missing y-axis description for rare charts in the form of y-axis event distribution split by {{fieldName}}. The intention is to briefly clarify that the type of chart is different than the other ones which have a count or metric based y-axis. This text is in addition to the text provided (but hidden without hovering) in the info icon tooltip.
2018-10-30 14:19:19 +01:00
Casper Hübertz
863cfb79ce
[APM] Added line-height to table cell (#24768)
Improved reading of the contents, especially in the Transaction Flyout.
2018-10-30 11:25:38 +01:00
James Gowdy
d400a797d3
[ML] Reducing risk of upload timeouts (#24677)
* [ML] Reducing risk of upload timeouts

* function rename

* removing hardcoded number

* fixing typo

* updating comment
2018-10-30 09:16:40 +00:00
James Gowdy
4201555a1d
[ML] Removing new ML job link in basic license (#24676) 2018-10-30 09:16:18 +00:00
Walter Rafelsberger
8b2ce42f3f
[ML] Fix a call stack size exception triggered by a negative tickInterval. (#24742)
In certain cases tickInterval mistakenly could end up being negative which made getTickValues() run into a call stack size exception. This PR fixes it by a) adding a check to getTickValues() that interval must not be 0 or smaller and b) changing the way the tickInterval is determined in the Anomaly Explorer Charts.
2018-10-30 09:31:15 +01:00
Andrew Cholakian
0b74169e24 [beats/heartbeat] Fix heartbeat add data instructions (#24795)
This commit does three things:
0. This fixes the instructions for interacting with the heartbeat service, which is called `heartbeat-elastic` not `heartbeat`
1. This removes some extraneous text that should be reserved for the subsequent section.
2. This makes the instructions for creating a monitor more explicit
2018-10-30 09:04:05 +01:00
Spencer
105f89dc3c
[optimizer] ignore node_modules anywhere in the x-pack directory (#24797)
I noticed the following message while watching the build output:

```
00:33:19.131    │ info [kibana] > /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/bin/kibana --optimize.useBundleCache=true --env.name=development --logging.json=false --server.port=5620 --optimize.watchPort=5630 --optimize.watchPrebuild=true --status.allowAnonymous=true --elasticsearch.url=http://elastic:changeme@localhost:9220 --elasticsearch.username=elastic --elasticsearch.password=changeme --server.uuid=5b2de169-2785-441b-ae8c-186a1936b17d --xpack.xpack_main.telemetry.enabled=false --xpack.security.encryptionKey="wuGNaIhoMpk5sO4UBxgr3NyW1sFcLgIf" --optimize.enabled=true --xpack.reporting.capture.browser.type=chromium --xpack.spaces.enabled=false
00:33:38.533    │ proc [kibana]   log   [23:20:25.923] [info][optimize] Optimizing and caching bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana. This may take a few minutes
00:34:12.650    │ proc [kibana] [BABEL] Note: The code generator has deoptimised the styling of "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/x-pack/plugins/infra/node_modules/lodash/lodash.js" as it exceeds the max of "500KB".
00:36:11.346    │ proc [kibana]   log   [23:22:58.721] [info][optimize] Optimization of bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana complete in 152.79 seconds
```

The "code generator has deoptimised" line specifically raised a red flag as babel shouldn't be running on node_modules. We have admittedly weak regular expressions in two places to enforce this. The first is in 49071132c3/src/setup_node_env/babel_register/register.js (L42), which I verified matched `node_modules` directories within the `node_modules/x-pack` directory, but the other is 49071132c3/src/optimize/base_optimizer.js (L152-L154) which does not. It only excludes files from babel in webpack if they are within a node_modules directory that is a direct child of `node_modules/xpack`, but with InfraOps and Canvas we now have node_module directories at `plugins/*/node_modules`.

This should probably be fixed by preventing plugins from installing their own node_modules, but since that would involve upgrading/moving plugins between major versions of dependencies like lodash that's somewhat impractical from where I stand, so instead I've just updated the webpack module rule to exclude any `node_modules/xpack/**/node_modules` directory.
2018-10-29 20:40:46 -07:00
Catherine Liu
0c0444cd6e
Fixes unauthorized error in es datasources (#24624)
* Fixes check for security plugin

* Cleaned up security check logic. Fixed tests for create_handlers. Added TODOs

* Updated comment

* Added tests

* Updated variable names
2018-10-29 20:21:55 -07:00
Jason Rhodes
b7b853abfe
[APM] Removes action menus (#24748)
* Removes infra links and replaces context menu with single discover links for now

* Changes discover links to use empty button style
2018-10-29 23:07:07 -04:00
Spencer
ce0cae64bd
[yarn] bump elasticsearch-js and makelogs (#24767)
In order to support esjs apiVersion 6.5 we need to upgrade to the newly released version of elasticsearch-js. Bumping makelogs allowed us to keep only one version of the elasticsearch module installed.
2018-10-29 18:16:10 -07:00
Spencer
39be1afe1b
[@kbn/datemath] improve types (#24671)
* [kbn-datemath][parseEsInterval] improve types slightly

* [kbn-datemath][vis/leastCommonInterval] make types more precise

* [ui/leastCommonInterval] fix bug in finding same types

* add back valid test
2018-10-29 17:25:08 -07:00
Jen Huang
fd4e63c5a9
[Rollups] Fix time field not being recognized due to ordering of aggs (#24783)
* Fix time field not being recognized due to ordering of aggs

* Clean up UI whitespace

* Update snapshot
2018-10-29 17:20:37 -07:00
spalger
49071132c3 [master] disable flaky test - #24287 2018-10-29 15:57:13 -07:00
Brandon Kobel
9f1cdac12b
Reporting cookies 2 (#24752)
* Revert "Reporting cookies (#24177)"

This reverts commit 9f4ec18000.

* Take 2

* Adding comment

* Better escaping and encoding for use in eval

* Checking for an empty string also

* Fixing session test
2018-10-29 15:54:45 -07:00
CJ Cenizal
0429a54c28
[Rollups] Copy improvements (#24528) 2018-10-29 15:15:11 -07:00
Josh Dover
69d25d8e50
Return promise in reporting jobs API (#24769) 2018-10-29 17:14:27 -05:00
Aaron Caldwell
ad10c758c0
Default scroll wheel zoom to false on vega maps. Update docs (#21169)
* Default scroll wheel zoom to false on vega maps. Update docs

* Update scroll wheel to false in tests
2018-10-29 15:31:16 -06:00
Spencer
dc89a9dc61
[dev/build] scan node_modules rather than lots of deleteAll() calls (#24692) 2018-10-29 13:02:04 -07:00
Chris Roberson
460a297bc9
[Monitoring] Use the cluster name from metadata if it exists (#24495)
* Use the cluster name from metadata if it exists

* PR comments
2018-10-29 15:41:03 -04:00
Sébastien Loix
1018947c3f
refactor(Watcher): Reword translation id for missing property on objects (#24753) 2018-10-29 20:14:24 +01:00
Bill McConaghy
f7782a9722
[Console] Add ccr apis to console autocomplete (#24739)
* fixing issue with doc link paths

* dding ccr API endpoints to autocomplet

* fixing issue with documentation links

* fixing generated specs {indices} -> {index}
2018-10-29 14:04:21 -04:00
Spencer
3f4169452e
[build] avoid extra bootstrap (#24697) 2018-10-29 10:59:24 -07:00
Sébastien Loix
adf8830549
fix(watch): Add WatchErrors to capture invalid watches (#23887)
Instead of immediately throwing an error if a watch Action is invalid (an email for example), there is now an `option` object that we can pass to the `fromUpstreamJson()` method and receive back any error that might exist in a Watch.
The Watch has a new "watchErrors" property to display configuration error in the UI.

fixes #20305
fixes #20970
2018-10-29 16:13:16 +01:00
Spencer
5d295d0cc0
[ui/timeBuckets/calcAutoInterval] Refactor (#24669)
* [ui/timeBuckets] test calcAutoInterval module

* [ui/timeBuckets] refactor calcAutoInterval* methods

* [calcAutoInterval] return 0ms when duration is invalid

* [calcAutoInterval] incorporate review feedback
2018-10-29 08:04:42 -07:00
Jason Rhodes
32f3d0f0d7
[APM] Fixes rare cases where KibanaLink is loaded outside of React context (#24705)
* Fixes rare cases where KibanaLink will be loaded outside of React context and requires no redux connect dependency

* Fixes tests for updated Kibana link component

* Removes obsolete snapshot
2018-10-29 09:58:20 -04:00
Ryan Keairns
06b0e74341
center content in fullscreen mode, hide K7 top nav (#24589) 2018-10-29 08:21:52 -05:00
Nox911
eb9b05bc6a Feature/translate new nav bar (#24326)
translate new_nav_bar
2018-10-29 16:18:18 +03:00
pavel06081991
b3bc86d7b8
Translations for Table Vis plugin (#23679)
add translations for table vis plugin
2018-10-29 16:14:41 +03:00
Casper Hübertz
9850f1150c
[Docs] Remove beta notes for ML and Query bar (#24718) 2018-10-29 14:04:59 +01:00
tibmt
cff438faf9 Translate security/users component (#23940)
Translate security/users
2018-10-29 15:59:31 +03:00
Walter Rafelsberger
75ce0c4fa2
[ML] Remove obsolete sentence from info tooltip. (#24716) 2018-10-29 13:49:12 +01:00
Leanid Shutau
81b334b286
[Tools] Add TemplateLiteral parsing to i18n_check tool (#24580)
* [Tools] Add TemplateLiteral parsing to i18n_check tool

* Add comments
2018-10-29 13:55:37 +03:00
pavel06081991
cf34c9a6db
Translations for Region Map (#23875)
add translations for region_map plugin
2018-10-29 12:39:54 +03:00
pavel06081991
1abe09e32b
Translations for Coordinate Map (#23952)
translate Coordinate Map
2018-10-29 12:34:32 +03:00
Pete Harverson
4cc49be704 [ML] Change file data visualizer JSON format label to NDJSON (#24643)
* [ML] Change file datavisualizer JSON format label to NDJSON
* [ML] Update edit flyout overrides snapshot
2018-10-29 10:07:46 +01:00
Matt Apperson
9a158c1454
[BeatsCM] Beats without tags should return an empty array via the config API (#24665) 2018-10-28 20:56:11 -04:00
Spencer
59206ec096
[kbn/es] add context to error message (#24664)
This just tweaks the kbn-es error message to provide more context than just `Not Found`
2018-10-26 16:57:08 -07:00
Catherine Liu
5df9747f5a
Fixed label position on progress elements (#24623) 2018-10-26 13:24:50 -07:00
Josh Dover
b093fddee8
Don't throw errors in optimizer (#24660) 2018-10-26 14:02:32 -05:00
Jason Rhodes
3a2db6e38f
Polish 6.5 (#24556)
* Updates waterfall item design for timeline rows

* Adjusts span and tx flyouts and updates tooltips to EUI

* Heading size fixes and clean up

* Updates tooltip snapshots

* Review tweaks and snapshot updates

* Revert experiment :)

Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com>

* Fixes bug with v1 waterfall state

* Fixes bug with timeline bar height

* Updates snapshot tests

* Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run
2018-10-26 14:56:20 -04:00
Joe Fleming
b8b0229fd6
Feat/expression threading (#24598)
Replaces https://github.com/elastic/kibana/pull/23301
Closes https://github.com/elastic/kibana/issues/23080

---

This is a minimal threading implementation for Canvas. There's still a lot to be done to make this concept great, but this is a start. 

What it does:
- Creates a server side abstraction on top of the interpreter
- Determines where to send the expression by checking the first function to be run
- Loads common functions in a separate worker thread on the server. 
- Routes to a single forked worker (thread), the main thread (server), or the browser (browser), in that order
- Defers back to the router when a function isn't found. Fails if the function isn't found in any of the above 3 environments
- Times out the worker if it takes too long, and respawns it as needed.
- Simplifies the error dialog to remove the stack. 

What is does not.:
- Round robin a pool of workers
- Queue. If one expression in the threaded env fails then anything sent to it in the meantime will fail. The upstream environment handles managing timeouts. I think this would only make sense todo with a pool.
- Client side. This doesn't implement web workers, but we could use roughly the same architecture. 
- Implement a specific, pluggable `worker` environment on the server. Right now it's just common functions, so plugin authors will always end up in a thread if they put their function in the common directory.

What I don't like:
- The socketProvider code. This was reused across the server & browser, but now that it's only used in the browser there's no good reason for the abstraction
- The serialize/deserialize stuff feels messy. Do we really need serialization?
2018-10-26 09:49:46 -07:00
Chris Roberson
a0543b1aec
Skip this test until snapshots are updated (#24650) 2018-10-26 11:32:50 -04:00
spalger
214ccfcf5f [dev/build] fix invalid assertion 2018-10-26 08:22:40 -07:00
Court Ewing
6737725c18 [backport] add back earlier 6.x minor versions
We still backport to these branches, primarily for doc changes.
2018-10-26 11:05:30 -04:00
tibmt
039ced34f0 Translate global navigation bar component (#23993)
Translate global navigation bar component
2018-10-26 17:03:30 +03:00
Leanid Shutau
a39238568a
[Tools] Forbid i18n filter usage outside of interpolation expressions (#23982)
* [I18n] Forbid i18n filter usage outside of interpolation expressions

* Add tests

* Add usage examples to JSDoc
2018-10-26 15:54:53 +03:00
Pete Harverson
afbc9d7476
[ML] Hides File Data Vizualizer field name overrides if empty list (#24576) 2018-10-26 12:08:24 +01:00
Leanid Shutau
074556f79e
[I18n] Update locale objects format (#23917)
* Update output file format for i18n_check tool

* Update i18n engine to work with new format

* Update tests

* Fix UI bootstrap test

* Update loader tests and fix getTranslationsByLocale function

* Fix messages passing to IntlProvider

* Update messages interface

* Resolve comments

* Resolve comment
2018-10-26 13:35:48 +03:00
Aleh Zasypkin
c8a09e3c65
TypeScriptify src/utils. (#23962) 2018-10-26 12:29:27 +02:00