Commit graph

138 commits

Author SHA1 Message Date
Corey Robertson 510bc698ff
[Dashboard] Export appropriate references from byValue panels (#91567)
* Adds references from byValue panels when saving dashboard

* Remove extra spaces

* Rework a type check

* Fix type check

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-24 16:23:44 -05:00
Wylie Conlon 78bed9e56d
[Lens] Fix bug in Safari and Firefox form rendering (#92542)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-24 14:04:46 -05:00
Marta Bondyra e1d0cd5270
[Lens] Fix overlowing content on a chart for charts and table (#92006) 2021-02-22 12:16:41 +01:00
Marta Bondyra 65be9e0306
[Lens] Drag and drop performance improvements (#91641) 2021-02-21 10:02:04 +01:00
Marta Bondyra 351990068d
[Lens] Drag and drop accessibility messages (#91494)
* [Lens] copy dnd

* Update x-pack/plugins/lens/public/drag_drop/providers.tsx

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
2021-02-17 16:48:26 +01:00
Marta Bondyra 8127103a71
[Lens] Fix partial move on datatable (#90630)
* [Lens] Fix partial move on datatable

* test

* fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-15 16:16:39 +01:00
Joe Reuter 5a5b8ad9a8
[Lens] Adjust new copy for 7.12 (#90413) 2021-02-15 13:17:31 +01:00
Marco Liberati e9e7453e1d
[Lens] Improves error messages when in Dashboard (#90668)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-15 13:00:31 +01:00
Marta Bondyra 0ee7be1f0d
[Lens] Keyboard-selected items follow user traversal of drop zones (#90546) 2021-02-15 12:48:06 +01:00
Joe Reuter 40570a633f
render only once (#90601) 2021-02-11 17:56:29 +01:00
Marta Bondyra df3e14dbbd
[Lens] (Accessibility) Fix focus on drag and drop actions (#90561) 2021-02-10 13:50:41 +01:00
Marta Bondyra 43e8ff8f8f
[Lens] Add new drag and drop capabilities (#89745) 2021-02-05 18:17:03 +01:00
Joe Reuter 1741cef4ae
[Lens] Hide column in table (#88680) 2021-02-04 16:22:09 +01:00
Brandon Kobel 4584a8b570
Elastic License 2.0 (#90099)
* Updating everything except the license headers themselves

* Applying ESLint rules

* Manually replacing the stragglers
2021-02-03 18:12:39 -08:00
Joe Reuter f4ebdf3a79
[Lens] Export nested types (#89868) 2021-02-03 12:03:55 +01:00
Marta Bondyra 1b8c3c1dcc
[Lens] Refactor reorder drag and drop (#88578) 2021-02-01 11:54:16 +01:00
Marco Liberati ecf512a048
[Lens] Make Lens visualization load faster on Dashboard (#88953)
* 🚀 Load indexPatternRefs only on edit mode

* :white_mark_check: Fix test with new editor init flag

* 🐛 Avoid to save to localStorage undefined indexPattern

* :white_mark_check: Adapted tests to new conditional ref loading

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-26 19:06:40 +01:00
Andrea Del Rio fb536f5428
Make toolbar_button a shared component (#88386) 2021-01-25 14:14:47 -08:00
Joe Reuter ab1d97e441
[Lens] Restart session if fixed now becomes outdated (#88575) 2021-01-21 11:00:57 +01:00
Marta Bondyra 0cd8c90a7c
[Lens] (Accessibility) Added button to execute drag and drop to workspace (#85960) 2021-01-20 17:11:37 +01:00
Marco Liberati 7297cc3b1d
[Lens] Add a11y test suite (#88623)
*  Add a11y test suite for Lens + some fixes

* 🔧 Removed unused ids

* 🐛 Fix component duplication via key prop

* :white_mark_check: Add more a11y tests

* ♻️ Restored back reorder id + fix multi layer duplicate ids

* 🐛 Fix #88806

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-20 16:44:59 +01:00
Marco Liberati 898385c2e2
[Lens] Clean full reference operation error state when switching to other operation (#87064)
* 🐛 Make sure to check incomplete columns before saved ones

* ⚗️ Try a different approach

* 🐛 Isolate the fullRef to field transition and trigger the removal + tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 16:58:23 +01:00
Jonathan Budzenski 51ba94d3e5
[dev] Replace sass-lint with stylelint (#86177)
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dave Snider <dave.snider@gmail.com>
2021-01-15 11:52:29 -06:00
Anton Dosov d3303f28bb
[Search] Search Sessions with relative time range (#84405) 2021-01-12 14:51:04 +01:00
Joe Reuter 94b02d97ed
[Lens] Implement deep linking and embedding (#84416) 2021-01-12 10:45:53 +01:00
Josh Dover 0af81310b6
Remove dynamic mapped types from UiActions (#87075)
* Remove dynamic mapped types from UiActions

* Remove import between data <-> embeddables

* remove outdated comments, export action types from discover_enhanced

* fix notice.txt

Co-authored-by: restrry <restrry@gmail.com>
2021-01-05 10:11:05 +01:00
Marco Liberati bd908c6ba3
[Lens] Integrate searchSessionId into Lens app (#86297)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-29 14:18:30 +01:00
Joe Reuter 57a72a78f7
[Lens] Configurable color syncing (#86180) 2020-12-22 17:35:27 +01:00
Wylie Conlon 23fd044562
[Lens] Introduce 4 new calculation functions: counter rate, cumulative sum, differences, and moving average (#84384)
* [Lens] UI for reference-based functions

* Fix tests

* Add a few unit tests for reference editor

* Respond to review comments

* Update error handling

* Update suggestion logic to work with errors and refs

* Support ParamEditor in references to fix Last Value: refactoring as
needed

* Fix error states

* Update logic for showing references in dimension editor, add tests

* Fix tests

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-22 10:33:27 -05:00
Joe Reuter 388b2508b3
[Lens] Make sure Lens does not reload unnecessarily (#86092) 2020-12-21 14:26:14 +01:00
Luke Elmers 9a3e2910a3
App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (#82791)
* Move applyFilter, selectRange, valueClick triggers to data/embeddables.

* Update imports.

* Remove embeddable references to non-existent data plugin dependency.

* remove data mocks from embeddable

* Remove query, filters, timeRange from EmbeddableInput and move to apps.

* Remove data plugin imports from embeddable test samples.

* Remove circular dependencies caused by expressions renderer handlers.

* Update circular deps allowList.

* Remove data dependency on embeddable.

* Revert accidental data plugin change.

* Fix new circular deps issues.

* Update generated docs.

* Fix type errors in vis_type_xy

* Fix inspector data table.
2020-12-18 18:34:07 -07:00
Peter Pisljar b93034b72c
inspector table adapter cleanup (#84232) 2020-12-17 12:14:07 +01:00
Marta Bondyra 5b9e285582
[Lens] (Accessibility) focus on adding/removing layers (#84900) 2020-12-16 21:58:14 +01:00
Marco Liberati 62623cdab9
[Lens] New sorting feature for the datatable visualization (#84435)
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 12:37:59 +01:00
Vadim Dalecky b01a327076
Row trigger 2 (#83167)
* feat: 🎸 add ROW_CLICK_TRIGGER

* feat: 🎸 wire row click event to UI Actions trigger in Lens

* feat: 🎸 add row click trigger to url drilldown

* feat: 🎸 add datatable to row click context

* feat: 🎸 pass in row index in row click trigger context

* feat: 🎸 add columns to row click trigger context

* feat: 🎸 fill values and keys event scope array

* feat: 🎸 generate correct row scope variables

* fix: 🐛 report triggers from lens embeddable

* feat: 🎸 add sample preview for row click trigger

* feat: 🎸 remove url drilldown preview box

* chore: 🤖 remove mock variable generation functions

* feat: 🎸 generate context and global variable lists

* feat: 🎸 preview event variable list

* feat: 🎸 show empty url error on blur

* feat: 🎸 add ability to always show popup for executed actions

* refactor: 💡 rename multiple action execution method

* fix: 🐛 don't add separator befor group on no main items

* feat: 🎸 wire in uiActions service into datatable renderer

* feat: 🎸 check each row if it has compatible row click actions

* feat: 🎸 allow passing data to expression renderer

* feat: 🎸 add isEmbeddable helper

* feat: 🎸 pass embeddable to lens table renderer

* feat: 🎸 hide lens table row actions which are empty

* feat: 🎸 re-render lens embeddable when dynamic actions chagne

* feat: 🎸 hide actions column if there are no row actions

* feat: 🎸 re-render lens embeddable on view mode chagne

* fix: 🐛 fix TypeScript errors

* chore: 🤖 fix TypeScript errors

* docs: ✏️ update auto-generated docs

* feat: 🎸 add hasCompatibleActions to expression layer

* feat: 🎸 remove "data" from expression renderer handlers

* fix: 🐛 fix TypeScript errors

* test: 💍 fix Jest tests

* docs: ✏️ update autogenerated docs

* fix: 🐛 wrap event payload into data

* test: 💍 add "alwaysShowPopup" test

* chore: 🤖 add comment requested in review

https://github.com/elastic/kibana/pull/83167#discussion_r537340216

* test: 💍 add hasCompatibleActions test

* test: 💍 add datatable renderer test

* test: 💍 add Lens embeddable input change tests

* test: 💍 add embeddable row click test

* fix: 🐛 add url validation

* test: 💍 add url drilldown tests

* docs: ✏️ remove url drilldown preview from docs

* docs: ✏️ remove preview from url templating

* docs: ✏️ add row click description

* chore: 🤖 move 36.5 KB bundle balance to url_drilldown

* test: 💍 simplify test case

* style: 💄 change types places

* refactor: 💡 clean up panel variable generation

* test: 💍 add getPanelVariables() tests

* fix: 🐛 generate runtime variables correctly

* fix: 🐛 improve getVariableList() and add tests for it

* feat: 🎸 add translation, improve types
2020-12-14 13:28:23 +01:00
Anton Dosov cb29438b0d
[Search] Fix dashboard embeddables don't refetch on searchSessionId change (#84261) 2020-12-10 14:21:35 +01:00
Joe Reuter 33c552feee
[Lens] Use eui component instead of custom color stops (#85239) 2020-12-09 16:06:25 +01:00
Wylie Conlon 0fdf76e779
[Lens] Don't assign dimension until it becomes valid (#84972) 2020-12-08 11:29:07 +01:00
Marta Bondyra 2cf4e72394
[Lens] (Accessibility) Added focus state and accessible name to suggestions (#84653)
* [Lens] (Accessibility) Added focus state and accessible name to suggestions

* Apply suggestions from code review

* Update x-pack/plugins/lens/public/editor_frame_service/editor_frame/suggestion_panel.tsx

padding oops

* cr
2020-12-04 19:28:33 +01:00
Wylie Conlon f176e8b7fd
[Lens] Remove extra render when closing flyout with valid column (#84951)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 11:00:10 -05:00
Marta Bondyra 1ff2bb3d8a
[Lens] allow drag and drop reorder on xyChart for y dimension (#84640)
* [Lens] allow drag and drop on xyChart for y dimension

* wip

* tests

* dimension panel fix

* eslint

* fix test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-03 20:30:42 +01:00
Marta Bondyra 145c0a5128
Revert "[Lens] (Accessibility) Focus mistakenly stops on righthand form (#84519)" (#84866)
This reverts commit a9845c6fc2.
2020-12-03 14:12:14 +01:00
Marta Bondyra 487eb2e4e4
[Lens] accessibility screen reader issues (#84395)
* [Lens] accessibility screen reader issues

* fix i18n

* fix: no aria-label on divs

* cr fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-03 13:28:41 +01:00
Marco Liberati 17d986e499
[Embeddable] Export CSV action for Lens embeddables in dashboard (#83654)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-03 10:46:51 +01:00
Marta Bondyra 6900ce2b96
[Lens] Provide single-value functions to show the "First" or "Last" value of some field (#83437) 2020-12-02 19:55:58 +01:00
Wylie Conlon c73de26773
[Lens] Refactor function selection invalid state (#84599)
* [Lens] Refactor function selection invalid state

* Fix types per review comment
2020-12-02 11:16:59 -05:00
Marta Bondyra 9d25669db1
[Lens] (Accessibility) Improve landmarks in Lens (#84511) 2020-12-01 15:03:38 +01:00
Marta Bondyra a9845c6fc2
[Lens] (Accessibility) Focus mistakenly stops on righthand form (#84519) 2020-12-01 15:02:59 +01:00
Marta Bondyra f23d2e6ea1
[Lens] (Accessibility) add aria-label to chart type icon (#84493) 2020-11-30 15:45:26 +01:00
Joe Reuter a763d3302f
[Lens] Calculation operations (#83789) 2020-11-25 09:43:23 +01:00