* adds try catch in getFailingRules method and adds a test for merge statuses
* rename IRuleStatusAttributes to IRuleStatusSOAttributes to better reflect what specifically the interface represents, which are the properties on the rule status saved object, while maintaining a separate interface for the HTTP response representation of those attributes as snake_case
* adds tests for getFailingRules utility function
* minor cleanup
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add fullEngineAccessChecked logic
* Add onEngineSelect logic
* [Refactor] DRY out/simplify http mocks
Note: import reorder is required in for mocks to work correctly
* Add onApiTokenChange logic
* Update flyout footer to use onApiTokenChange
* Add new POST/PUT server routes
+ some opinionated comments
* [PR feedback] tests copy, extra data tests
* [PR feedback] Reuse fullEngineAccessChecked, fix fullEngineAccessChecked being undefined vs a bool
* [Maps] fix refreshing the page causes loss of unsaved change
* fix functional tests
* remove unneeded check for app leave modal
* check for appLeaveConfirmModal for clicking confirmModalConfirmButton
* see failures without closing appLeaveModal
* start clearing unsaved changes warning in maps
* clean up more unsaved state in functional tests
* more cleaning up of unsaved state in functional tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Added an empty Flyout
* Refactor CredentialsFlyout to its own component folder
+ split out child sub components for easier testing/reading
* Add initial FlashMessages setup
- mostly just DELETE_MESSAGE currently, since that's what's already wired up
- CREATE_MESSAGE and UPDATE_MESSAGE will be used in an upcoming commit
+ adds FlashMessages in flyout, which will show returned form errors from the API
* Fix flash messages appearing on flyout open
e.g. deletion success messages
+ incidental linting/cleanup
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
resolves: https://github.com/elastic/kibana/issues/80371
Previously, when claiming tasks, we were always sorting the tasks to claim by
the score and then by the time they should be run. We sort by score to
capture `runNow()` tasks, also referred to internally as "pinned" tasks
in the update by query.
The change in this PR is to only sort by score if there are pinned tasks, and
to not sort by score at all if there aren't any.
* Update id of second sources mock to be unique
Both were originally set to ‘123’
* Remove unused types from interface
These were never used and were only uncovered while testing. These both exist on `group` but not at the top level.
* Add group mock
* Fix typo in reducer name
* Add tests for group_logic
* Remove redundant messages check
This is not needed with global flash messages, as the component will not render with no messages.
* Add tests for group_router
* Add group mock
* Add tests for groups_logic
* Convert groups_router to use children
This allow for testing the component visiblity and aligns with other usage of React Router
* Add tests for groups_router
* Refactor pagination logic
This commit removes the useDidUpdateEffect custom hook and moves the logic to fetch the search results to a listener inside of Kea.
* dd tests for main groups container
* Lint fixes
* Fix broken test and remove comment
The issue was that the delay needed to be in the catch block to properly execute.
* Add comments and make test explicit
In other places in the tests, we explicitly test for an error string in the catch block. Changing this to match.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* convert pdf.js to TS
* more typescript
* simplify caller
* more typescript
* more typescript
* fix the code to match the expected interface
* very cool comment
* interface correction
* remove unused class method
* add unit test for PdfMaker
* file rename for typo correction
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Change an example in embeddable to use controls instead of knobs
* Add controls to SyncBadge APM story
* Convert both to [CSF](https://storybook.js.org/docs/react/api/csf)
* Remove the Knobs addon from the default Storybook configuration
Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.
Fixes the `extract-mitre-attacks` script and generates `v6.3` tactics and techniques. Will move to `7.x` as part of the structural changes to support sub-technique in https://github.com/elastic/kibana/issues/75771.
