Commit graph

11191 commits

Author SHA1 Message Date
Alison Goryachev 5959b606ec
[CCR] Unskip component integration tests (#99385) 2021-05-11 08:55:46 -04:00
Paul Tavares 997e179f7a
[Security Solution][Endpoint] Additional Unit Tests for the Event Filters Page (#99463)
* event filters middleware tests for listpage
* additional tests for reducer of event filters
* use Async Resource builders in middleware
* Refactor listPage selectors to use `getLastLoadedResourceState()`
* New utility for mocking core.http apis that can be reused
* Add ability to set experimental featurers on `AppContextRender` mock utility
2021-05-11 08:21:46 -04:00
Dmitry Shevchenko ea8aa69db3
Fix deleted rule view (#99406) 2021-05-11 12:40:07 +02:00
Mikhail Shustov 5fde16c2b3
Do not mutate config in place during deprecations (#99629)
* refactor config deprecations to avoid config mutations

* remove dynamic access keys in core deprecations.

* refactor custom config deprecations to match the new signature

* improve config deprecations fixtures for nested keys

* add a test for xpack.banner config deprecations

* key --> path, add a test for invalid command
2021-05-11 05:41:48 -04:00
Mikhail Shustov d1d741b479
remove joi usage from x-pack (#99401)
* remove unused helper

* remove joi usage from Security Solutions

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-11 11:04:30 +03:00
Andrew Pease 4831826bae
Update Timeline Template README.md (#95814)
## Summary

`xpack.security_solution.signalsIndex` is listed to be added to `kibana.dev.yml`, however that generates:
```
FATAL  Error: Unknown configuration key(s): "xpack.security_solution.signalsIndex". \
Check for spelling errors and ensure that expected plugins are installed.
```
I think this should be `xpack.securitySolution.signalsIndex`

This is for the steps to create a timeline template.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2021-05-10 22:38:20 -04:00
Justin Ibarra 45c6ca42d0
[Detection Rules] Add 7.13 rules (#99725) 2021-05-10 19:48:57 -04:00
Nathan Reese b248472e82
[Maps] show empty tooltips with actions on click (#99337)
* [Maps] show tooltips with actions on click

* clean up

* call canShowTooltip in _getTooltipFeatures

* move view into action

* cleanup

* i18n

* add comment to clarify if statement

* tslint

* fix security tslint

* fix jest tests

* clean up

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-10 17:46:33 -06:00
Zacqary Adam Xeper b5380697cc
[Fleet] Add keep_enabled flag to preconfiguration to prevent disabling certain inputs (#99656)
* [Fleet] Add keep_enabled flag to prevent disabling inputs

* Remove console.log

* Fix missing key definition
2021-05-10 18:16:03 -05:00
Scotty Bollinger 0b5d323613
[Workplace Search] Fix bug with updating a role mapping (#99688)
`id` is not needed by the server as a body prop, as it’s inferred from the params.
2021-05-10 18:30:57 -04:00
Yuliia Naumenko fcc2ac5799
Fixed alerting health check behavior when alerting cannot find its health task in Task Manager. (#99564)
* Fixed alerting health check behavior when alerting cannot find its health task in Task Manager.

* fixed test

* added unit tests
2021-05-10 15:24:42 -07:00
Brian Seeders 6d269c5062
Revert "[SecuritySolution] Get endpoint metadata (#99452)" (#99719)
This reverts commit 5893d67b4b.
2021-05-10 17:42:39 -04:00
Clint Andrew Hall e0c57e08fd
[labs] Fix reset overreach; add method for testing project (#99672) 2021-05-10 16:27:35 -05:00
Angela Chuang 5893d67b4b
[SecuritySolution] Get endpoint metadata (#99452)
* getHostEndpoint

* add endpointContext

* add deps

* get endpoint info

* clean up

* fix tests error

* fix types

* fix unit tests

* fix unit tests

* fix unit tests

* fix types error

* fix types

* fix api integration test

* fix api integration tests

* add comment

* review

* add getHostInfo

* rename getHostInfo into getHostMetaData

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-10 15:21:36 -04:00
ymao1 8e3604fe11
[Alerting UI] Fixing behavior when trying to render an Index Threshold visualization with invalid data (#99518)
* Showing error message not object. Removing error toaster

* Updating unit tests

* Fixing i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-10 14:46:01 -04:00
Quynh Nguyen e9e7314c3b
[ML] Make swimlane annotation markers look less like a 0 (#99592)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-10 13:18:40 -05:00
Kyle Pollich baf11e8749
[Fleet] Remove timestamp field from component template (#99619)
* Remove timestamp field from component template

Elasticsearch bug fixed upstream allows us to remove this field from the
template: elastic/elasticsearch/#58956

Closes #71095

* Remove timestamp field from functional test
2021-05-10 14:11:23 -04:00
Patryk Kopyciński ec66797c7c
[Osquery] Fix Osquery plugin initialization (#99591) 2021-05-10 19:44:01 +02:00
Dan Panzarella dfe8637c52
[Security Solution] Add Host Isolation API (#98842) 2021-05-10 13:31:11 -04:00
Lisa Cawley c787495f00
Use doc link services in rollups (#99137) 2021-05-10 10:01:19 -07:00
Frank Hassanabad c092fbfe1a
[Security Solutions] (Phase 3, part 1) Removes dependency on security_solution plugin from lists (#99431)
## Summary

Removes the dependency of security_solution from the lists plugin

* Removes some of the deprecated types in favor of the new kbn package
* Adds a workaround in the kbn packages of removing the ?? and `a?.b?.c` typescript since kbn packages cannot transpile it
* Exposes the test_utils from the kbn package 

### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-05-10 10:16:19 -06:00
Sergi Massaneda 518da5bcc1
[SecuritySolution] Histogram IP legends error fixed (#99468)
* make sure stackByField exists

* fix types

* fix unit test

* skip extra request for non-ip queries

* elasticserach query changes to prevent corrupted data response bug

* client changes to split ip stacked histogram queries in two, inspect modal shows all requests and responses

* lint fixes

* test for useMatrixHistogramCombined added

* comment added on new multiple prop

* changed query to always contain value_type:ip for ip queries

Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-10 17:54:55 +02:00
Pablo Machado 0ffe4c7a54
[SecuritySolution] Add success toast to timeline deletion (#99612)
* Add success toast to timeline deletion

* Add unit tests for timeline deletion toast

* Refactor export_timeline to use useAppToasts instead of useStateToaster
2021-05-10 16:58:50 +02:00
Alison Goryachev 5f618da802
[Rollups] remove use of custom cluster client (#99623) 2021-05-10 10:19:38 -04:00
Ashokaditya da890fd24c
[Security Solution][Endpoint] Validate path values for trusted apps (#99035)
* Validate path values for trusted apps

show soft warnings when path values are not valid.

refs elastic/security-team/issues/315

* use case insensitive flag

refs 71ac9bdeaf

* correct check for windows paths

review changes

* rename

review changes

* add validations to include ? for wildcards

also add more tests
refs elastic/security-team/issues/315

* update copy for soft errors

refs elastic/security-team/issues/315

* refactor validation logic

review changes

refs elastic/kibana/pull/99035#discussion_r625106658

* allow wildcards in path names

refs elastic/security-team/issues/315

* stack soft errors

refs elastic/security-team/issues/315

* Update x-pack/plugins/security_solution/public/management/pages/trusted_apps/view/components/create_trusted_app_form.tsx

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

* remove links to private repos

review changes

* improve windows path regex

refactor tests for better debugging
review changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
2021-05-10 16:18:48 +02:00
Dominique Clarke 9715157467
[Uptime] add data mock to rtl helpers (#99483)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-10 10:15:49 -04:00
Dominique Clarke 23bef5193a
[Uptime] remove border from waterfall chart sidebar panel (#99079)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-10 10:14:03 -04:00
Jen Huang 903b8751da
Fix yaml settings editor styling (#99558) 2021-05-10 08:13:59 -04:00
Yara Tercero ebe85665a9
[Security Solution][Exceptions] - Fix operator logic for large value lists (#99490)
### Summary
Logic for operators was off, this fix adds unit tests to ensure this bug is not hit again and updates logic
2021-05-10 01:14:24 -04:00
Tim Sullivan f73da420ff
[Reporting] Update Puppeteer to version 8.0.0 and Chromium to r856583 (#98688)
* Update Puppeteer to 8.0.0

Updates Chromium to r856583
Links to new build of Linux headless_shell in the Kibana team GCS bucket
Links to main download site of Chromium for Mac and Windows
Removes Mac and Windows compatibility from the Chromium build scripts

* add functional tests for large dashboard

* ensure png comparison is working

* add test for large dashboard pdf

* update arm64 binary checksum

* update README

* more readme update

* Update x-pack/build_chromium/README.md

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
2021-05-07 09:54:33 -07:00
James Gowdy 518da4daa1
[ML] Fixing route handler types and schemas (#98636)
* [ML] Fixing route handler types and schemas

* commenting out type error

* updates to fix functional tests

* updating jest test

* updating test expect

* fixing tests

* fixing test expect

* changes based on review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-07 13:08:25 +01:00
Michail Yasonik 921c942bef
Unifying converting listing pages to new layout (#98651)
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 18:31:20 -04:00
Scotty Bollinger 238fc3ac1d
[App Search] Remove reset mappings button from Role mappings (#99499)
* Move toolTip type to shared

This is used by Workplace Search as well

* Remove reset mappings button

Will not be used as a part of the User transition

* Remove server route

* Remove unused import

* Remove unused translations
2021-05-06 17:11:52 -04:00
Larry Gregory 0886b0e9e5
Don't query for the current user on anonymous pages (#99511) 2021-05-06 17:04:56 -04:00
Kyle Pollich 00c133b838
[Fleet] Force text wrapping in README content (#99516)
* Force text wrapping in README content

Long paragraph tags weren't wrapping, which allowed the README section
of the integration details screen to expand past its normal width and
break other parts of the layout.

Closes #99087

* Use EUI class instead of inline style
2021-05-06 16:22:16 -04:00
Melissa Alvarez 7ed6e36156
[ML] Anomaly Detection explorer: ensure map reflects anomalies selected (#99403)
* show choropleth layer for anomalies present

* use type guard
2021-05-06 15:27:14 -04:00
John Dorlus 43aead77cb
Add Component Integration Test For Common Processor Fields (#97194)
* Added test for setting common fields. All except the if field as it uses monaco text editor. Reaching out for help with this issue.

* Added  assertion for the code editor.

* Added await to fix promise rejection.

* Added mockCodeEditor data test subject to correct file.

* Removed unneeded comment.

* Split out common processors test and fixed nits in PR feedback.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 15:24:16 -04:00
Gloria Hornero d993ec7911
[Security Solution] [Detections] Adds investigate in timeline test for indicator match generated alerts (#99214)
* adds investigate in timeline test for indicator match generated alerts

* refactor

* removes duplicated line

* refactor

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 21:02:12 +02:00
Dario Gieselaar 64b9136f46
[APM] fix typo in ML callout (#99412) 2021-05-06 20:42:04 +02:00
Jonathan Budzenski 79be58ee1b Revert "[App Search] Remove reset mappings button from Role mappings (#99414)"
This reverts commit 1d4bdc554c.
2021-05-06 11:14:31 -05:00
David Sánchez 35f4be4387
[Security Solution][Endpoint] User can edit existing event filters from the list (#98898)
* Makes width 100% to allow multilang

* Removes state/index types and move those types into the parent types file

* Allows fill form from existing exception by id. Adds unit tests. Fixes wrong comments display when there is more than one comment.

* Allows user update an existing event filter. Adds unit tests. Fixes some wrong behaviours when opening the flyout after create/update action

* Fixes typo

* Fixes wrong entry type

* Uses selectors when it's possible instead of accessing directly to state object

* Fixes typechecks

* Allows edit from the card edit button. Removes unused imports and fixes some types

* Reverts type name

* Changes reducer to don't add entry to the list manually after creation, list will be reloaded with api call. Also check always if data exists to display the add new entry button at the first time
2021-05-06 18:13:55 +02:00
Lisa Cawley fa13af90be
[ML] Add popover help for swim lanes (#98855)
Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>
Co-authored-by: Michael Marcialis <michael@marcial.is>
2021-05-06 08:41:08 -07:00
Scotty Bollinger 1d4bdc554c
[App Search] Remove reset mappings button from Role mappings (#99414)
* Move toolTip type to shared

This is used by Workplace Search as well

* Remove reset mappings button

Will not be used as a part of the User transition

* Remove server route

* Remove unused import
2021-05-06 10:37:16 -05:00
Kyle Pollich baf149fdc3
[Fleet] Update no results content for integrations (#99415)
* Update no results content for integrations

- Update content when no results returned from search on integrations
screen
- Add links to custom integrations and discuss forums to bottom of
results grid, even when results are returned

Closes #87015

* Don't show missing integration message for installed integrations

* Remove unneeded history.push
2021-05-06 11:27:58 -04:00
Frank Hassanabad 0d56a59582
[Security Solutions] Fixes more Cypress flakes by adding abilities to do refresh on timelines (#99413)
## Summary

This should fix the flakes by adding the ability to do refreshes when timelines aren't being shown.

* Fixes the missing data subjects and tests in our code base
* Fixes the flakes in each of the tests we were seeing
* Cleans up some of the .then() and additional checks we were using
* Returns more chainables from Cypress so we can use more then() logic to keep things cleaner
* Removes 1 dead duplicated function found 

You can replicate the flake by adding this code below in any before code of this pull request. This is how I was able to replicate it and then fix it within the utils.

```ts
export const waitForTimelinesPanelToBeLoaded = (): Cypress.Chainable<JQuery<HTMLElement>> => {
  cy.get(TIMELINES_TABLE).should('exist');
  cy.wait(5000); // <--- Do a wait for 5 seconds to ensure the table is fully loaded with zero hits to replicate the flake this fixees
  return cy.get(TIMELINES_TABLE).should('exist');
};
```

A secondary issue is that when you do fast refreshes the click handlers are not on the timelines in the timeline table. However, we cannot do fast pipe/re-clicking on those because that causes a different type of flake. The flake that can cause is multiple clicks are registered and then we end up with multiple URL/route reloads.

So instead, we have to unfortunately rely on one `cy.wait(1000)` Cypress wait of 1 second.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-05-06 08:42:10 -06:00
Stratoula Kalafateli fe9029cef3
[Rollup] Fixes telemetry (#98639)
* [Rollup] Fix telemetry and also add lens visualizations

* Different lens stats for rollup visualizations

* Add unit test

* Implement pagination

* Fix telemetry schema

* Fix test

* Add unit tests

* Change docs per page size to 1000

* Add meta description for our rollup telemetry

* Fix telemetry schema

* Fix unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 17:41:54 +03:00
Spencer 7740e06b0b
[sec/actions] move constants to a separate file to avoid circular deps (#99439)
* [sec/actions] move constants to a separate file to avoid circular deps

* split out setupSavedObjects import

* remove unused import

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-05-06 06:54:20 -07:00
David Sánchez ddc640731d
Fixes special characters and quotes on trusted apps search (#99377)
* Escapes special chars and backslashes and colons. Updates test.

* Uses regexp to escape all non alphanumeric chars

* Skips whitespaces

* Skips slashes

* Fixes regex and adds more test cases
2021-05-06 15:25:07 +02:00
Kevin Logan f2bb74e996
[Security Solution][Detections] Add linux artifact for exception lists (#99104) 2021-05-06 09:13:37 -04:00
ymao1 86ea803168
[Task Manager] Using track_total_hits in workload agg (#99360)
* Using track_total_hits in workload agg

* Increasing size of terms aggregation
2021-05-06 09:02:24 -04:00