* Convert Search UI view to use new page template
+ update tests TODO
* [UX polish] Add empty state to Search UI view
- On a totally new engine, all pages except this one* had an empty state, so per Davey's recommendations I whipped up a new empty state for this page
* Overview has a custom 'empty' state, analytics does not have an empty state
* Update router
* Fix bad merge conflict resolution
* [Polish] Copy feedback proposed by Davey
- see cbc3706223
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* wip: start migrating views from ccr
* finish up migrating ccr pages to new nav layout
* Fix tests, linter errors and i18n strings
* remove todo
* Render loading and error states centered in screen without page title
* Keep loader going while we still setting the payload
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Convert AnalyticsHeader to AnalyticsFilters
- it's basically the same component as before, but without the title section/log retention tooltip, since the header/title will be handled by the new page template
* Update AnalyticsLayout to use new page template
+ add new test_helper for header children
* Update breadcrumb behavior
- Set analytic breadcrumbs in AnalyticsLayout rather than AnalyticsRouter
- Update individual views to pass breadcrumbs (consistent with new page template API)
* Update router
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* very wip
* added new assets screen
* added routes to new assets view on the package details view
* Finished styling the assets page layout, need to work on adding
links
* rather use EuiHorizontalRule
* only show the assets tab if installed
* Added hacky version of linking to assets.
* added comment about deprecation of current linking functionality
* added an initial version of the success toast with a link to the agent flyout
* First iteration of end-to-end UX working. Need to add a lot of tests!
* fixed navigation bug and added a comment
* added a lot more padding to bottom of form
* restructured code for clarity, updated deprecation comments and moved relevant code closer together
* added a longer form comment about the origin policyId
* added logic for handling load error
* refactor assets accordions out of assets page component
* slightly larger text in badge
* added some basic jest test for view data step in enrollment flyout
* adjusted sizing of numbers in badges again, EuiText does not know about size="l"
* updated size limits for fleet
* updated styling and layout of assets accordion based on original
designs
* remove unused EuiTitle
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
* 🐛 Carry over filter extra fields with in incomplete state
* 👌 Integrated feedback
* 👌 Integrated feedback
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
* [Metrics] Add divider in the actions menu
* [Metrics] Add color and icon to the alert link
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Casper Hübertz <casper@elastic.co>
* Removes 'none' compression as it not used anymore
* Revert type because none type is needed for the first time the artifact is created befor the compression
Co-authored-by: David Sánchez <davidsansol92@gmail.com>
* start working on license management
* migrate permissions check to new layout
* refactor license expiration as a subtitle of the page header
* finish up working on page title
* Fix linter errors and update snapshots
* update method name
* CR changes
* update snapshots
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* WIP add filtering capabilities to XY legend
* Fix filter by legend on xy axis charts
* Filter pie and xy axis by legend
* create a shared component
* Add functional test
* Add functional test for pie
* Make the buttons keyboard accessible
* Fix functional test
* move function to retry
* Give another try
* Enable the rest od the tests
* Address PR comments
* Address PR comments
* Apply PR comments, fix popover label for alreadyformatted layers
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Refactor PersonalDashboardLayout to more closely match new page template
- Remove references to enterpriseSearchLayout CSS (which will be removed in an upcoming PR)
- Prefer to lean more heavily on default EuiPage props/CSS/etc.
- Handle conditional sidebar logic in this layout rather than passing it in as a prop
- Update props & DRY concerns to more closely match WorkplaceSearchPageTemplate
- e.g. isLoading & pageChrome (mostly for document titles)
- make FlashMessage and readOnlyMode work OOTB w/o props)
* Convert Source subnav to EuiSideNav format
+ update PrivateSourcesSidebar to use EuiSIdeNav
* Update routers
- removing wrapping layouts, flash messages, chrome/telemetry
* Refactor SourceRouter into shared layout component
- Remove license callout, page header, and page chrome/telemetry
- NOTE: The early page isLoading behavior (lines 51-) is required to prevent a flash of a completely empty page (instead of preserving the layout/side nav while loading). We cannot let the page fall through to the route because some routes are conditionally rendered based on isCustomSource.
- FWIW: App Search has a similar isLoading early return with its Engine sub nav, and also a similar AnalyticsLayout for DRYing out repeated concerns/UI elements within Analytics subroutes.
* Convert all single source views to new page template
- Mostly removing isLoading tests
- NOTE: Schema page could *possibly* use the new isEmptyState/emptyState page template props, but would need some layout reshuffling
* Convert Add Source pages to conditional page templates
- Opted to give these pages their own conditional layout logic - this could possibly be DRY'd out
- There is possibly extra cleanup here on this file that could have been done (e.g. empty state, titles, etc.) in light of the new templates - but I didn't want to spend extra time here and went with creating as few diffs as possible
* Convert separate Organization Sources & Private Sources views to new page templates
+ fix Link to EuiButtonTo on Organization Sources view
* Update Account Settings with personal layout + write tests
+ add related KibanaLogic branch coverage
* [UX feedback] Do not render page headers while loading on Overview & Sources pages
* [PR feedback] Breadcrumb errors/fallbacks
* [Proposal] Update schema errors routing to better work with nav/breadcrumbs
- `exact` is required to make the parent schemas/ not gobble schema/{errorId}
- added bonus breadcrumb for nicer schema navigation UX
- No tests need to update AFAICT
* Ignore Typescript error on soon-to-come EUI prop
# Conflicts:
# x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/source_settings.tsx
This updates the Fleet final pipeline added in #100973 to match the specification of
`event.agent_id_status` field as defined in ECS. The field was added to ECS in
https://github.com/elastic/ecs/pull/1454. Basically the values of the field were simplified
from what was originally proposed and implemented.
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
* Convert Documents view to new page template
* [UI polish] Move empty state to top-level instead of showing full UI
- per Davey's previous approval
* [UX polish] Show loading indicator on initial documents page load
* Convert single Document detail view to new page template
* Update router
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Split up engines vs. meta engines into separate panels
- per Davey's feedback from earlier UI passes
* DRY out manual header/spacing to reusable DataPanel component
+ update DataPanel icon typing to not error when passed a custom icon/svg
- kudos again to Davey for the component
* Typography tweaks
- Update DataPanel component to accept a custom titleSize (to maintain previous UI/sizing)
- Fix meta engines empty prompt title heading to follow heading levels + tweak sizing to not be larger than panel heading
* Set up new license CTA button for upcoming meta engines CTA
falls back to a documentation link! so fancy
* Update Enterprise Search Overview to use new license button
* Add new Meta Engines license upgrade CTA
- Reuse some copy from Meta Engines creation view
- Reuse DataPanel so visuals stay consistent + it looks similar to CTA on Enterprise Search Overview
- Update DataPanel to allow buttons to be responsive + conditionally load spacer between header & children
* Improve responsiveness of app when platinum license changes
Previously, routes/apps were going off the static data passed from the server which was only initialized once on page load. hasPlatinumLicense however changes dynamically and in real-time, removing the need for a hard page refresh.
I could have replaced all `canManageMetaEngine` flags with `isPlatinum && canManageEngines`, but I thought baking license checks into the main ability would be more scalable and potentially open the way to other license-based flags also being dynamic.
* [PR feedback] Typos in test names
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
* Fix failing test
Missed updating the heading level
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
* Update routers
- To facilitate this being broken up into multiple PRs, non-migrated views still get a wrapping layout
* Set up Engine subnav in EuiSideNav format
+ tweak CSS for new label - heads up that this will break the old nav, but will disappear as the pages get converted
* Convert Engine Overview pages to new page template
* [PR feedback] Code comment explaining side nav icon reorder
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
One of the Workplace Search components was using the 'react-beautiful-dnd' typing for it’s component. This PR relpaces it with the EUI equivalent.
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
* Convert Engine Creation page to new page template
+ simplify EuiForm/form to 1 level of nesting
* Convert Meta Engine Creation page to new page template
* Initial conversion of Engines overview to new page template
* Engines Overview: simplify loading & empty state to use new page template props
* Engines Overview: simplify header
- now that the header/actions, chrome/telemetry, & empty state etc. are all DRY'd out by the template, there's no need for a separate header component
- we can simply dry out the header action, which will shortly be removed with the 7.14 launch
- note: for empty state changes: mostly indenting, the new template automatically creates a subdued panel for us in empty state so no need to include one manually
* Fix broken test mocks
I definitely should not have been importing the index file I'm mocking, but why did this only break now?? :psyduck:
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
This PR stabilizes the `setupModule` API tests by increasing the timeout for the jobs to finish.
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
* Modify threshold rules to receive a single date range tuple
* Modify threat match rules to receive a single date range tuple
* Modify custom query rules to receive a single date range tuple
* Fix up tests (partially)
* Change log message to indicate single tuple instead of array
* Bad test?
* Prevent max_signals from being exceeded on threat match rule executions
* Revert "Prevent max_signals from being exceeded on threat match rule executions"
This reverts commit ba3b2f7a382ef7c369f02c7939e1495f72d92bfe.
* Modify EQL rules to use date range tuple
* Modify ML rules to use date range tuple
* Fix ML/EQL tests
* Use dateMath to parse moments in ML/Threshold tests
* Add mocks for threshold test
* Use dateMath for eql tests
This PR removes the duplicate load of the `event_rate_nanos` archive in the `data_nanos_job` test suite.
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
* add `isExportable` SO export API (#101860)
* add `isExportable` SO export API
* add warning when export contains excluded objects
* add FTR test
* fix API integration assertions
* lint
* fix assertions again
* doc
* update generated doc
* fix esarchiver paths
* use maps instead of objects
* SavedObjectsExportablePredicate is no longer async
* more docs
* generated doc
* use info instead of warning when export contains excluded objects
* try/catch on isExportable call and add exclusion reason
* add FTR test for errored objects
* log error if isExportable throws
* fix dataset for 7.x
* Revert "Revert: [7.x] [FTR][CI] Use default distribution for all tests (#102019)"
This reverts commit c272bdbc25.
* [FTR] Stabilize SSLP functional tests (#102553)
* Removes spaces check, since spaces should always be available
* Disables Monitoring, SecuritySolutions, and Reporting in SSPL tests
until #102552 is completed
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Differentiate the dialog message on the deletion of one item from the deletion of multiple items.
Simplifies CasesTableUtilityBar by handling the selection of multiple and single cases in the same way.
This a companion to elastic/elasticsearch#74188.
This PR is functionally a no-op, as the removed method
was not called anywhere. But it is sensible to remove
it to prevent it being called in the future now that it
references fields that don't exist in Elasticsearch.
Co-authored-by: David Roberts <dave.roberts@elastic.co>
* Used test user and added appropriate kibana privileges for Ingest Node Pipeline functional tests.
* Updated ingest pipelines test config to have read permissions in advanced settings.
* Updated test to account for the fact that advanced settings will be visible due to kibana permissions.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
* Convert Groups page to new page template
* Convert Groups > Group overview to new page template
- Because dataLoading is no longer an early return, certain items need to be converted to conditional checks in order for the app to not crash
* Convert Groups > source prioritization to new page template
* Convert Group subnav to EuiSideNav format
* Update routers
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Mock KibanaServices with services from app context renderer + fix error noise in endpoint host tests
* silence more error noise to the console
* Added options to the ApiHandlerMock function to be able to suppress errors to the console
* Endpoint list - Refactor Fleet mocks for reuse
* Add default http mocks to the app context render test utility
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
* Remove endpoint from the default packages
* Change the default spinner for the initial load
* Export fleet endpoint package as a constant
* Use constants for special packages
* Simplify type signature of `isRequiredPackage`
* Remove unused types
* Simplify required and default package definitions
* Treat REQUIRED_PACKAGES as independent from DEFAULT_PACKAGES
We want to keep the assumption that the lists contain the same packages
only in `epm/constants.ts`
* Install all default packages, not only the required ones
* Document the purpose of each package list
* Handle auto-update for non-default packages
* Make `endpoint` non-removable
* Make endpoint package be installed by default in tests
* Rename requiredPackages to unremovablePackages
* Fix type check
* Add Endpoint to be installed by default on Fleet tests too
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
* Adds boilerplate for new hook-utils package
* Move existing, identified utils into our hook-utils package
Updates references, and fixes a few missing config that were preventing
packages from building.
* Extracts a common type and adds a little more JSdoc for clarity
* Adds new useObservable hook
Similar to useAsync (a nearly identical interface), this is meant to
wrap a thunk returning an observable, allowing conditional invocation
and progressive updates as the observable continues to emit.
* Remove orphaned test
This function (and its tests) were moved to the hook-utils package; this
was simply missed.
* Remove optional chaining from kbn package
The build system does not currently support these typescript features.
While a valid fix would also have been to build separate browser and
node targets a la #99390, the use here was very minimal and so changing
to a supported syntax was the most pragmatic fix.
* Update old reference in test file
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# package.json
* Convert Settings > Customize to new page template
* Convert Settings > oAuth application to new page template
+ DRY form wrappers, update test
* Convert Settings > Connectors to new page template
* Convert source config view to new page template
* Convert Settings subnav to EuiSideNav format
+ update main WS nav
* Update routers
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Convert WS Overview page to new page template
* Misc Overview refactors
- Fix extra spacing caused by hidden onboarding steps
- Default page title to "Organization overview" instead of to onboarding title which flashes during loading
- Prefer shallow over mount (will matter later, when WorkplaceSearchPageTemplate nav includes more kea logic)
* Convert Security page to new page template
+ misc ux enhancement disabling header actions while data is still loading
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* added public-side implementation for package search
* added a test for the new search results provider and updated behaviour
* added comment about open issue regarding hash router in fleet
* fixed jest tests
* refactor to reduce size of if statement
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# rfcs/text/0011_global_search.md
we show an empty state on the actions log tab anyway
refs 2dd22ed92b
fixes elastic/kibana/issues/102335
Co-authored-by: Ashokaditya <am.struktr@gmail.com>
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.
In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.
The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".
Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.
Fixes#102131.
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
* Isolate action should only be available for platinum license
* Moved `useLicense` hook mock into `__mocks__`
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
* Set up shared EnterpriseSearchPageTemplate component
* Set up product-specific page templates + setPageChrome
+ misc tech debt - create AS components/layout/index.ts for imports
* Set up navigation helpers for EuiSideNav usage
- Update react_router_helpers to pass back props as a plain JS obj instead of only working with React components (+ update react components to use new simpler helper)
- Convert SideNavLink active logic to a plain JS helper
* Set up top-level product navigations
NYI: sub navigations (future separate PRs)
* Set up test_helpers for inspecting pageHeaders
- primarily useful for rightSideItems, which often contain conditional logic
* Initial example: Convert RoleMappings views to new page template
Minor refactors:
+ remove unnecessary type union
+ fix un-i18n'ed product names
+ add full stop to documentation sentence
+ add semantic HTML tags around various page landmarks (header, section)
* EUI feedback: add empty root parent section
* Revert Role Mappings union type removal
- but shenanigans it a bit to take our i18n'd shared product names (requires as const assertion)
- done to reduce merge conflicts for Scotty / make his life (hopefully) a bit easier between ent-search and Kibana
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* WIP: Migrate fleet to new page layout system
* Add 'Add Agent' button to agents table
* Fix flyout import in search and filter bar
* Place settings/feedback in header
* Move actions to top nav
* Fix i18n + types + unit test failures
* Remove unused props in DefaultLayout
* Fix background height in Fleet layout
This is fixed through a hack for now, because Kibana's layout doesn't
allow apps to flex the top-level wrapper via `flex: 1`. The same
behavior reported in the original issue (#101781) is present in all
other Kibana apps.
Fixes#101781
* Use euiHeaderHeightCompensation for min-height calc
* Move settings portal to app component
* Fix agent details URL in failing unit test
* Remove unreferenced overview files + update functional tests
* Remove unneeded fragment
* Remove beta badges in Fleet + Integrations
Fixes#100731
* Fix i18n
* Fix page path reference
* Fix failing tests
* Re-fix i18n post merge
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# x-pack/plugins/translations/translations/ja-JP.json
# x-pack/plugins/translations/translations/zh-CN.json
* Log at different levels based on the state
* Fix types and add tests
* Remove unnecessary code
* Add more descriptive message
* Partially fix failing tests
* Move into separate function
* Get rid of customStatus in favor of moving the logging logic to a separate, mockable function
* Remove debug logging
* Do not log as an error if the stats are empty
* PR feedback
* Add docker whitelist
* alpha order
* English is hard
* Removing extra newline
* PR feedback around ignoring capacity estimation
* Move json utils
* Added CITs for Circle processor.
* Fixed issue with form function using int instead of string.
* Added changed per nits.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
* Add endpoint isolation status for when multiple actions of different types are pending
* Refactored List to break out Agent status code to separate component
* Generator improvements for how actions are generated for Endpoints
* Add HTTP mock for fleet EPM packages (to silence console errors)
* new `.updateCommonInfo()` method to generator (to regenerate stateful data)
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
* Adding boilerplate for new CTI search strategy type
This is going to be a subtype of the general SecSol search strategy;
the main functionality is going to be:
* transformation of the incoming parameters into named equivalents
* transformation of responses to include enrichment context fields
(matched.*)
* More boilerplate, including tests
A few type errors because our functions don't actually do anything yet,
nor are our request/response types fleshed out.
* Starting to flesh out the request parsing
* Defines a basic request, along with a mock
* Defines helper function to generate should clauses from field values
* Adds placeholder tests throughout
* Fleshing out unit tests around our enrichment query
* Fleshing out response parsing of eventEnrichment strategy
* Fix types from elasticsearch
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Rename PrivateSourcesLayout to PersonalDashboardLayout
The renaming was required because this layout is also used for Account Settings.
* Rename imports
* Rename files
* More personal_dashboard_layout from sources folder to layout folder
* Extract PrivateSourcesSidebar from PersonalDashboardLayout
This is needed to add the ability to pass AccountSettingsSidebar in the
next commit.
* Add and use AccountSettingsSidebar
* Move related styles to personal_dashboard_layout folder
* Move tests from personal_dashboard_layout to private_sources_sidebar
* Add tests for account_settings_sidebar
* Remove redundant import
* Move source-related sidebar text constants to top-level constants file
Now all personal dashboard sidebar copy is in one place
Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
* Add tooltip back to table row
This was missed when refactoring the table to an EUI component. Built-in mappings have tooltips and don’t have IDs and need to show tooltips instead of actions.
* Fix roleType display
Also missed in the refactor. Made a mistake when copying/pasting
* Refactor logic files to use single endpoint for UI props
As a part of this feature, we are now passing all props needed for the UI in the list endpoint. Previously, whether creating a new mapping, or updating an existing mapping, an endpoint had to be called to fetch the data needed for display. Now all this data comes from the initial fetching of mappings and the other endpoints are no longer needed.
* Refactor WS test to match AS
There was an issue where 100% test coverage was not achieved in Workplace Search. This had already been fixed in App Search by refactoring. This changes the code and test in Workplace Search to match
* Remove server routes
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
* fix flakyness of metricbeat dashboard test
* skip test for now
* Update _metricbeat_dashboard.js
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marius Dragomir <marius-dr@users.noreply.github.com>
* show relative time only upto an hr from now
fixes elastic/security-team/issues/1313
* Update formatted_date_time.tsx
undo changes done in e38e202e81
Co-authored-by: Ashokaditya <am.struktr@gmail.com>
* Initial commit, very WIP
- added link to the integrations UI instead of add integration
in fleet
- added a new piece of route state that gets passed to integration
from fleet when browsing integrations for a policy
- when the integration is being added the page will send the user
back to the policy overview instead of back to integrations UI
* remove unnecessary agent policy clear function
* added # to path so that navigation is correctly handled
* added logic to read the forward agent policy id
* remove inline select integration package from fleet add integration
* updated toast notification
* using query parameter to pass policy id back to create policy package page
* removed policyId from route path
* fix type issue
* updated the select agent field layout per the designs
* simpified item rendering in combobox and fixed combobox z-index issue
* added comment
* fix types and i18n
* updated icon and removed unused i18n
* refactor to using styled components for cusomt z-index styling
* attempt to fix integration test
* added scroll functionality for dealing with fixed footers that might be obstructing content
* fix scroll direction!
* attempting another scroll algorithm
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
* Hide legacy index templates table if the user doesn't have any.
* Render deprecation warning above legacy index templates table and in legacy index template wizard.
* Update index template doc link to point to the new docs.
* Adding Security Authentication jobs in 7.14
* Renamed some jobs
* Changing memory limits and linting change
* Linting fix
* Changed the order
* Adding module to ml_modules.tsx
* Update recognize_module.ts
this test modules uses older Auditbeat data which predates the event.category field so the test has to be skipped per https://elastic.zoom.us/j/93000943632?pwd=TmpvNWhtYUNzMUc0c0N6Tlc2QlVPZz09
* Update recognize_module.ts
needs to be a single line
* Update recognize_module.ts
Some linters want spaces and some linters want no spaces. This linter wants spaces.
* descriptions
added description text
* Update auth_rare_hour_for_a_user.json
removed a wayward newline char
* Minor nitpicking
* memory limits
raised memory limits to 128mb which is larger than the highest observed peak model bytes for the most memory hungry jobs in this event class.
Co-authored-by: Craig <mailredirector36@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Co-authored-by: Craig <mailredirector36@gmail.com>
creates bulkCreate and wrapHits factories for the modularization of the detection engine
Co-authored-by: Marshall Main <marshall.main@elastic.co>
Co-authored-by: Ece Özalp <ozale272@newschool.edu>
Co-authored-by: Marshall Main <marshall.main@elastic.co>
* WIP
add tabs for endpoint details
* fetch activity log for endpoint
this is work in progress with dummy data
* refactor to hold host details and activity log within endpointDetails
* api for fetching actions log
* add a selector for getting selected agent id
* use the new api to show actions log
* review changes
* move util function to common/utils
in order to use it in endpoint_hosts as well as in trusted _apps
review suggestion
* use util function to get API path
review suggestion
* sync url params with details active tab
review suggestion
* fix types due to merge commit
refs 3722552f73
* use AsyncResourseState type
review suggestions
* sort entries chronologically with recent at the top
* adjust icon sizes within entries to match mocks
* remove endpoint list paging stuff (not for now)
* fix import after sync with master
* make the search bar work (sort of)
this needs to be fleshed out in a later PR
* add tests to middleware for now
* use snake case for naming routes
review changes
* rename and use own relative time function
review change
* use euiTheme tokens
review change
* add a comment
review changes
* log errors to kibana log and unwind stack
review changes
* search on two indices
* fix types
* use modified data
* distinguish between responses and actions and respective states in UI
* use indices explicitly and tune the query
* fix types after sync with master
* fix lint
* do better types
review suggestion
* add paging to API call
* add paging info to redux store for activityLog
* decouple paging action from other API requests
* use a button for now to fetch more data
* add index to fleet indices
else we get a type check error about the constant not being exported correctly
from `x-pack/plugins/fleet/common/constants/agent`
* add tests for audit log API
* do semantic paging from first request
* fix ts error
review changes
* add document id and total to API
review suggestions
* update test
* update frontend to consume the modified api correctly
* update mock
* rename action
review changes
* wrap mock into function to create anew on each test
review changes
* wrap with schema.maybe and increase page size
review changes
* ignore 404
review changes
* use i18n
review changes
* abstract logEntry component logic
review changes
* move handler logic to a service
review changes
* update response object
review changes
* fix paging to use 50 as initial fetch size
* fix translations and move custom hook to component file
review changes
* add return type
review changes
* update default value for page_size
review changes
* remove default values
review changes
https://github.com/elastic/kibana/tree/master/packages/kbn-config-schema#schemamaybehttps://github.com/elastic/kibana/tree/master/packages/kbn-config-schema#default-values
* fix mock data
refs 1f9ae70194
* add selectors for data
review changes
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Ashokaditya <am.struktr@gmail.com>
Adds Capacity Estimation to the Task Manager Health Endpoint.
Below is a diagram depicting what information we use to estimate the varying capacity variables.
Please use the user facing docs to understand how it fits together. If the docs aren't clear enough - make a review comment and I'll clarify in the docs.
* Removes zlib compression when creating artifacts. Also fixes related unit tests and removes old code
* Replaces artifact in new manifest using the ones from fleet client with zlip compression
* Fixes create_policy_artifact_manifest pushArtifacts missing new manifest. Also fixes unit tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: David Sánchez <davidsansol92@gmail.com>
* updated add agent flyout buttons
* move close button to left
* added new optional prop for the add agent flyout and factored out a component from the index.tsx file
* quite a big refactor, moved the agent policy authentication to own component and reused in two places
* fixed layout on view where policy was not selected, also fixed a render cycle
* removed unnecessary filter
* move handler to function body instead of in JSX
* remove unused i18n
* added jest test for agent enrollment flyout steps behaviour
* fix issues after master merge
* Fix bad import in type file
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
* Revert "[FTR] Use importExport for saved_object/basic archive (#100244) (#102016)"
This reverts commit 9851b7bcfa.
* Revert "[7.x] [FTR][CI] Use default distribution for all tests (#94968) (#101118)"
This reverts commit 73225daa87.
* [FTR][CI] Use default distribution for all tests (#94968)
* [FTR] Use importExport for saved_object/basic archive (#100244)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [Enterprise Search] Add owner and description properties to kibana.json
Adds owner and description properties to kibana.json
* Reorder to match other plugins
Both others have the props at the end of the file:
https://github.com/elastic/kibana/blob/master/src/plugins/bfetch/kibana.json
Also removes redundant prefix from description
* Copy change
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* [APM] Improvments in the APM fleet integration (#95501)
* added unit test and line comment
* fixes eslint issues
Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
* Copy lazy_wrapper and suspense_error_boundary from Spaces plugin
These components are needed to enable async loading of Security components into Enterprise Search.
The components are copied without any changes except for i18n ids, so it's easier to DRY out in the future if needed.
* Create async versions of personal_info and change_password components
* Create ui_api that allows to load Security components asuncronously
The patterns were mostly copied from Spaces plugin
* Make ui_api available through Security components's lifecycle methods
* Import Security plugin into Enterprise Search
* Add Security plugin and Notifications service to Kibana Logic file
* Export the required components from the Security plugin and
use them in the new AccountSettings component
* Update link to the Account Settings page
* Move getUiApi call to security start and pass core instead of getStartServices
* Simplify import of change_password_async component by providing...
... `notifications` and `userAPIClient` props in the security plugin
* Remove UserAPIClient from ui_api
It's not needed anymore since the components are initiated with this prop already passed
* Export ChangePasswordProps and PersonalInfoProps from account_management/index.ts
This makes it easier to import these props from outside the account_management folder
* Remove notifications service from kibana_logic
It is not needed anymore since we're initializing security components with notifications already provided
* Add UiApi to SecurityPluginStart interface
* Utilize index files for exporting Props types
* Replace Pick<...> with two separate interfaces as it doesn't work well with our docs
* Add a comment explaining why we're not loading async components through index file
Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
* Create AssignmentSelectors
These components will be used in both the Role Mapping and User flyouts to create and edit role mappings and users, respectively
* Implement AssignmentSelectors in components
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
* Add shared actions component
Both tables use the same actions
* Refactor RoleMappingsTable to use EuiInMemoryTable
This is way better than the bespoke one I wrote and it comes with pagination for free
- Also fixes a typo in the i18n id
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
* Fixing app_container
* Use EUI mixin `euiHeaderAffordForFixed()` to maintain parity
* Adding `aria-busy` when `showSpinner`
* i18n for the loading aria-label
* wip: add datafeed modal for chart
* Add arrows to navigate through time in the chart
* ensure runtime_mapping and indices_options in search query
* move chart data fetching behind single server endpoint
* remove success check as it is not returned in result
* load necessary modal data in modal
* remove extra legend and add text to action icons
* remove unused endpoint and types
* handle job not found and fix types
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* 💄 Hack to fix suggestion box
* 🐛 Fix validation messages
* 🐛 Relax operations check for managedReferences
* Change completion params
* 🏷️ Fix missing arg issue
* ✨ Add more tinymath fns
* 🐛 Improved validation around math operations + multiple named arguments
* 🐛 Use new onError feature in math expression
* ♻️ Refactor namedArguments validation
* 🐛 Fix circular dependency issue in tests + minor fixes
* Move formula into a tab
* 🔥 Leftovers from previous merge
* ✨ Move over namedArgs from previous function
* ✅ Add tests for transferable scenarios
* ✅ Fixed broken test
* ✨ Use custom label for axis
* Allow switching back and forth to formula tab
* Add a section for the function reference
* Add modal editor and markdown docs
* Change the way math nodes are validated
* Use custom portal to fix monaco positioning
* Fix model sharing issues
* Provide signature help
* 🐛 Fix small test issue
* 🐛 Mark pow arguments as required
* 🐛 validate on first render only if a formula is present
* 🔥 Remove log10 fn for now
* ✨ Improved math validation + add tests for math functions
* Fix mount/unmount issues with Monaco
* [Lens] Fully unmount React when flyout closes
* Fix bug with editor frame unmounting
* Fix type
* Add tests for monaco providers, add hover provider
* Add test for last_value
* Usability improvements
* Add KQL and Lucene named parameters
* Add kql, lucene completion and validation
* Fix autocomplete on weird characters and properly connect KQL
* Highlight functions that have additional requirements after validating
* Fix type error and move help text to popover
* Fix escape characters inside KQL
* 🐛 Fix dataType issue when moving over to Formula
* Automatically insert single quotes on every named param
* Only insert single quotes when typing kql= or lucene=
* Reorganize help popover
* Fix merge issues
* Update grammar for formulas
* Fix bad merge
* Rough fullscreen mode
* Type updates
* Pass through fullscreen state
* Remove more chrome from full screen mode
* Fix minor bugs in formula typing
* 🐛 Decouple column order of references and output
* 🔧 Fix tests and types
* ✅ Add first functional test
* Fix copying formulas and empty formula
* Trigger suggestion prompt when hitting enter on function or typing kql=
* 🐛 Prevent flyout from closing while interacting with monaco
* refactoring
* move main column generation into parse module
* fix tests
* refactor small formula styles and markup
* documentation
* adjustments in formula footer
* Formula refactoring (#12)
* refactoring
* move main column generation into parse module
* fix tests
* more style and markup tweak for custom formula
* Fix tests
* [Expressions] Use table column ID instead of name when set
* [Lens] Create managedReference type for formulas
* Fix test failures
* Fix i18n types
* fix fullscreen flex issues
* Delete managedReference when replacing
* refactor css and markup; add button placeholders
* [Lens] Formulas
* Tests for formula
Co-authored-by: Marco Liberati <marco.liberati@elastic.co>
* added error count placeholder
* Add tooltips
* Refactoring from code review
* Fix some editor issues
* Update ID matching to match by name sometimes
* Improve performance of Monaco, fix formulas with 0, update labels
* Improve performance of full screen toggle
* Fix formula tests
* fix stuff
* Add an extra case to prevent insertion of duplicate column
* Simplify logic and add test for output ID
* add telemetry for Lens formula (#15)
* Respond to review comments
* ✨ Improve the signatures with better documentation and examples
* adjust border styles to account for docs collapse
* refactor docs markup; restructure docs obj; styles
* Fix formula auto reordering (#18)
* fix formula auto reordering
* add unit test
* Fix and improve suggestion experience in Formula (#19)
* ✨ Revisit documentation and suggestions
* 👌 Integrated feedback
* ✨ Add query validation for quotes
* Usability updates & type fixes
* add search to formula
* fix form styles to match designs
* fix text styles; revert to Markdown for control
* 👌 Integrated more feedback
* improve search
* improve suggestions
* improve suggestions even more
* 🐛 Fix i18n issues (#22)
* Persist formula on leave, fix fullscreen and popovers
* Fix documentation tests
* 🏷️ fix type issue
* 🐛 Remove hidden operations from valid functions list
* 🐛 Fix empty string query edge case
* 🐛 Enable more suggestions + extends validation
* Fix tests that depended on setState being called without function
* Error state and text wrapping updates
* ✨ Add new module to CodeEditor for brackets matching (#25)
* Fix type
* show warning
* keep current quick function
* ✨ Improve suggestions within kql query
* 📷 Fix snapshot editor test
* 🐛 Improved suggestion for single quote and refactored debounce
* Fix lodash usage
* Fix tests
* Revert "keep current quick function"
This reverts commit ed477054c5.
* Improve performance of dispatch by using timeout
* Improve memoization of datapanel
* Fix escape characters
* fix reduced suggestions
* fix responsiveness
* fix unit test
* Fix autocomplete on nested math
* Show errors and warnings on first render
* fix transposing column crash
* Update comment
* 🐛 Fix field error message
* fix test types
* 📝 Fix i18n name
* 💄 Manage wordwrap via react component
* Fix selector for palettes that interferes with quick functions
* Use word wrapping by default
* Errors for managed references are handled at the top level
* 🐛 Move the cursor just next to new inserted text
* ⚗️ First pass for performance
* 🐛 Fix unwanted change
* ⚡ Memoize as many combobox props as possible
* ⚡ More memoization
* Show errors in hover
* Use temporary invalid state when moving away from formula
* Remove setActiveDimension and shouldClose, fixed by async setters
* Fix test dependency
* do not show quick functions tab
* increase documentation popover width
* fix functional test
* Call setActiveDimension when updating visualization
* Simplify handling of flyout with incomplete columns
* Fix test issues
* add description to formula telemetry
* fix schema
* Update from design feedback
* More review comments
* Hide callout border from v7 theme
Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Joe Reuter <email@johannes-reuter.de>
Co-authored-by: Marco Liberati <marco.liberati@elastic.co>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Joe Reuter <email@johannes-reuter.de>
Co-authored-by: Marco Liberati <marco.liberati@elastic.co>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
* Clean up public API of cases plugin
1. Don't use export * on index.ts files that define the public API
2. Add comments to the interface show they show up in the API docs
3. Export types that are part of the public API so they show up in the API docs.
4. Fill in information for the up and coming `description` and `owner` items in kibana.json.
* Update returns comments to be more descriptive
* update api docs
* Remove kibana.json attributes, until PR supporting them is merged.
* Change all exports to export type to avoid increase page bundle size
Co-authored-by: Stacey Gammon <gammon@elastic.co>
* Adjust Action Status API types
* add lib/service to fetch host pending actions
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
Context:
The import button can be used to import both timelines and timeline templates.
In theory, one imported file could have multiple timelines and timeline templates at the same time.
Solution:
Since the import endpoint only returns the total count and not the type of the imported documents.
It seems like that rewording "timeline(s)" to "item(s)" is the most straightforward fix that solves
the user problem.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Adjust packageToPackagePolicy to support multiple policy_templates
* Adjust validatePackagePolicy to support multiple policy templates
* Create input for every policy template input instead of grouping
* Related adjustments for previous commit
* Don't key by policy template when package doesn't have integrations
* Adjust limited package check to support multiple policy templates
* First pass at UI support
* Fix imports, add missing schema
* Fix finding input agent templates, adjust tests
* Only enable specific integrations by default in the UI
* Fix import
* Make breadcrumbs and create package policy page title reflect integration, not package
* Only show specific integration inputs when adding integration to a policy
* Change predicate
* Simplify condition
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
## Summary
* Grabbed the ECS mappings from [v1.10.0 tag]( https://github.com/elastic/ecs/blob/v1.10.0/generated/elasticsearch/7/template.json)
* Updated the fields that had `constant_keyword` to `keyword` since we do many to 1 of source to signals index
* Wrote a unit tests which tests to ensure we don't have any `constant_keyword` fields
* Updated the `SIGNALS_TEMPLATE_VERSION` version by an increment of 10.
This should mostly fix:
https://github.com/elastic/kibana/issues/101572
Since agents add their data into `_source` even though they have a `constant_keyword`. When agents do not include the values in `_source` we will have to merge `fields` into `_source` before copying which are still planning on doing before release.
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
* Link to home file data visualizer
* remove unused import
* i18n cleanup
* remove unused import from EmptyState
* use const
* remove ml functional test cases checking for ml_file_data_visualizer
* more clean-up of ml_file_data_visualizer
* jest snapshot and nav to home page in no_ml_access tests
* revert change to functional test dual_privileges_all at everything_space
* revert another change to security_and_spaces/tests/catalogue.ts
* revert changes to x-pack/test/ui_capabilities/security_only/tests/catalogue.ts
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx
* Add "Add Agent" button to package policy list
- Add button to open enrollment flyout from package policy list screen
- Move necessary components up into `public` in order to open enrollment
flyout from within Integrations application
* Create initial package policy table actions
* Fix context menu link + add a few tests
* Fix import in list_layout
* Unify package policy actions menu in shared component
* Update x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
