Commit graph

44557 commits

Author SHA1 Message Date
Maja Grubic
b4fe6b43dd
[Discover] Fix multi-field display when parent field is not indexed (#102938)
* Show multifields when parent is not indexed

* [Discover] Fix for multi-fields when parent is not indexed

* Readd package.json

* Applying Tims suggestion

* Add a unit test

* Updating unit test so that it tests the right thing
2021-07-14 13:44:07 +02:00
Pierre Gayvallet
750c738174
fix flaky file_hash unit test (#105447)
* fix flaky unit test

* lint

* uncomment the suite
2021-07-14 13:43:25 +02:00
Jean-Louis Leysens
8fb5633d36
[Reporting] Fix flaky download pdf test (#105210)
* added a retry for checking that we are on the dashboard landing page

* added .only and removed .skip

* remove .only

* revert this: added .only for flaky test runner

* Remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-14 13:26:34 +02:00
Matthias Wilhelm
1fe4135ab6
[Discover][Main] Fix missing error message when building search query throws exceptions (#103923)
* Fix missing error message when building search fails

* Fix test

* Update _date_nested.ts

* Lint config.js

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-14 12:18:21 +02:00
Angela Chuang
b2a6a9d308
[SecuritySolution] disable edit and create from rules breadcrumb (#105412)
* disable edit and create from rules breadcrumb

* remove href for create /rule breadcrumb

* fix lint error
2021-07-14 09:36:56 +01:00
Christos Nasikas
604b424212
[Actions] Swimlane: Change API Token field to a password textfield (#105475)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-14 11:21:58 +03:00
Oliver Gupte
1fa33ea751
[APM] Updates the APM static index pattern regardless of fleet migration status (#105471)
* [APM] Updates the APM static index pattern regardless of fleet migration status (#105469)

* Fixed and added more unit tests

* ignores eslint error for property name in mock object
2021-07-14 01:19:29 -04:00
Oliver Gupte
e60f14eb94
[APM] Fixes support for APM index pattern with data streams (#105360)
* [APM] Fixes support for APM index pattern with data streams (#94702)

* fix unit test

* - Revert "fix unit test"
- tests each component of index pattern title for index matches

This reverts commit a3a27df4b6.
2021-07-14 00:33:27 -04:00
Oliver Gupte
194725d351
[APM] Fixes support for APM data streams in Security and Timelines UIs (#105334)
* addes support for apm data streams (traces-apm*) to timelines

* [APM] Adds support for apm data streams (traces-apm*) to security solution (#94702)

* fix unit tests

* reverting prepackaged_rules changes to be bumped later
2021-07-14 00:11:38 -04:00
Frank Hassanabad
bdf1069e56
[Security Solutions][Detection Engine] Removes dead duplicated code and marks other duplicated code (#105374)
## Summary

* Removes dead duplicated code from `security_solution` and  `lists`
* Adds notes and TODO's where we still have duplicated logic
* Adds notes where I saw that the original deviated from the copy from modifications in one file but not the other.
* DOES NOT fix the bugs existing in one copy but not the other. That should be done when the copied chunks are collapsed into a package. Instead see this issue where I marked those areas: https://github.com/elastic/kibana/issues/105378

See these two files where things have deviated from our duplications as an example:
[security_solution/public/common/components/autocomplete/field.tsx](https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/common/components/autocomplete/field.tsx
)
[lists/public/exceptions/components/autocomplete/field.tsx](https://github.com/elastic/kibana/blob/master/x-pack/plugins/lists/public/exceptions/components/autocomplete/field.tsx)

Ref PR where fixes are applied to one of the files but not the other (could be other PR's in addition to this one):
https://github.com/elastic/kibana/pull/87004

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-07-13 16:23:58 -06:00
Patryk Kopyciński
ef06cf7ec0
[Osquery] Revert fix Saved Query mapping (#105503) 2021-07-13 18:10:08 -04:00
Justin Kambic
c633dbef7b
[Uptime] Exclude all documents missing hash from TLS query (#105492)
* Exclude all documents missing `tls.server.hash.sha256` from TLS page query.

* Simplify query.
2021-07-13 18:05:55 -04:00
Kyle Pollich
8f1dde5675
Handle deprecated $yml code block language in integration READMEs (#105498) 2021-07-13 17:48:30 -04:00
Frank Hassanabad
773b5b5d48
[Security Solutions][Detection Engine] Removes EQL timestamp workaround and reduces test boiler plating (#105483)
## Summary

Removes EQL timestamp workaround we introduced earlier when we found the bug https://github.com/elastic/kibana/pull/103771 now that it has been fixed with the fields API https://github.com/elastic/elasticsearch/issues/74582

* Fixes the EQL timestamp issue by removing the workaround
* Introduces EQL timestamps being formatted as ISO8601 like we do with KQL
* Adds e2e tests for the EQL timestamps
* Removes some boiler plating around our e2e tests by adding two utilities of `getEqlRuleForSignalTesting` and `getThresholdRuleForSignalTesting` and reducing those e2e code areas.   

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-07-13 17:42:16 -04:00
Shahzad
139326a06f
[Exploratory view] Fixed bug in series storage hook (#105495) 2021-07-13 17:31:34 -04:00
Walter Rafelsberger
5dc1c8f53a
[ML] API integration tests for APM latency correlation. (#104644)
Adds API integration tests for APM Latency Correlations code.

Writing the tests surfaced some glitches fixed as part of this PR:
- If the applied filters don't return any docs, we won't throw an error anymore. Instead, the async search service finishes early and just returns no results.
- If for whatever reason the async search service throws an error, it will also set its state now to isRunning = false.
- If the client triggers a request with a service ID we now make sure that async search service still exists. We throw an error if that service no longer exists. This avoids re-instantiating async search services when they've already finished or failed and for whatever reason a client triggers another request with the same ID.
- Refactored requests to reuse APM's own getCorrelationsFilters(). We now require start/end to be set and it will be converted from ISO (client side) to epochmillis (server side) to be more in line with APM's existing code.
- The async search service now creates a simple internal log. This gets exposed via the API and we assert it using the API tests. In the future, we might also expose it in the UI to allow for better problem investigation for users and support.
2021-07-13 15:46:14 -05:00
Scotty Bollinger
e5c3065adf
Handle edge case for GitHub oAuth URL mismatch (#105302)
* Hangle edge case for github oauth mismatch

* Fix grammar

* Refactor test
2021-07-13 15:36:57 -04:00
Wylie Conlon
9c2effc93e
[Lens] Fix flaky formula test (#105295)
* [Lens] Fix flaky formula test

* Only run formula tests

* Remove .only

* Increase debounce time
2021-07-13 15:10:25 -04:00
Wylie Conlon
de58b8cc0c
[Lens] Fix field stats when multiple runtime fields are used (#105359) 2021-07-13 14:19:49 -04:00
James Gowdy
e300a75e45
[ML] Fix calendar creation during model snapshot restore (#105421)
* [ML] Fix calendar creation during model snapshot restore

* adding toast for unexpected errors
2021-07-13 19:11:55 +01:00
James Gowdy
1fdcf367a9
[ML] Improve bucket span estimator error toast (#105457) 2021-07-13 19:11:28 +01:00
Patryk Kopyciński
c88213b095
[Osquery] Fix Saved Query mapping (#105398) 2021-07-13 20:07:23 +02:00
Matthew Kime
d65743cc3c
Revert "Rollup index pattern list fixes (#105328)" (#105456)
This reverts commit 6933d63007.
2021-07-13 12:57:14 -05:00
Pablo Machado
18780bcece
Add empty string validation for Tags and Authors (#101756) 2021-07-13 19:27:41 +02:00
Liza Katz
95176b0f54
[Search Sessions] Expire empty sessions after a minute (#105430)
* Expire empty sessions after a minute

* Take value from config
2021-07-13 19:03:31 +02:00
Lisa Cawley
bd2e4e313d
[ML] Fix APM latency order of sticky header properties, add help popover (#103759)
* [ML] APM latency correlations help popover

* Remove spacer

* [ML] Updates correlation tooltip

* Remove scss, use styled popover instead

* Fix order to be Service > Environment > Transaction

* Addresses popover text feedback

* Addresses more popover text feedback

* Adds performance warning to popover; improves tooltip

* Internationalizes aria label in popover

* Internationalizes aria label in ML popover

Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 17:57:38 +01:00
Quynh Nguyen
fd4b9dfd19
Fix not refreshing with relative time and now (#104994)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 11:36:28 -05:00
Quynh Nguyen
524e4d5481
[ML] Fix Index Data Visualizer not gracefully handling error (#104567)
* Fix to show better error message

* Handle batch errors by still showing as much data as possible

* Fix i18n

* Fix errors

* Fix 404 error, add extractErrorProperties

* Fix missing histogram

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 11:35:39 -05:00
Cauê Marcondes
ee8c9be778
[APM] Add telemetry to track usage of the agent config to fleet synchronisation feature (#105297)
* removing telemetry hook from pages

* adding telemetry to schema and agent config
2021-07-13 12:33:32 -04:00
Tiago Costa
4ae6dd3f9e
skip flaky suite (#105174) 2021-07-13 16:11:29 +01:00
Matthew Kime
6933d63007
Rollup index pattern list fixes (#105328)
* fix index pattern field list and improve typescript
2021-07-13 09:34:32 -05:00
Lisa Cawley
d5c5fb732d
[ML] Updates URLs in documentation link service (#105011) 2021-07-13 07:32:45 -07:00
Kyle Pollich
f578548ca1
Fix typo in unenrollment modal (#105420) 2021-07-13 10:19:40 -04:00
Aaron Caldwell
c02cdd85fe
Format numbers in TOC pop-up and add layer menu to locale (#105165)
* Format numbers in TOC pop-up and add layer menu to locale

* Review feedback + format a couple other counts

* Update jest test
2021-07-13 10:17:53 -04:00
Xavier Mouligneau
1c5d548893
bring back KQL autocomplete in timeline + fix last updated (#105380) 2021-07-13 09:34:44 -04:00
Aaron Caldwell
32e6b1edb6
[Maps] Change TOC pop-up wording to reflect filter change, not search bar change (#105163)
* Change pop-up wording

* Review feedback. Update wording
2021-07-13 09:16:34 -04:00
Jonathan Buttner
3f47646606
Updating urls to upstream elastic repo (#105250) 2021-07-13 09:10:30 -04:00
Aaron Caldwell
41fb80b8a7
[Maps] Move new vector layer wizard card down (#104797) 2021-07-13 09:09:44 -04:00
Jonathan Buttner
4f7cae7950
Exclude registering the cases feature if not enabled (#105292) 2021-07-13 09:06:59 -04:00
Dominique Clarke
3743eb8fe7
[Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (#104541)
* check monitor status by monitor.timespan

* Delete mappings.json

* adjust logic

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 08:49:55 -04:00
Jean-Louis Leysens
654300bc42
updated UI copy (#105184) 2021-07-13 13:48:46 +02:00
Josh Dover
6b269491b4
Log a warning when documents of unknown types are detected during migration (#105213) 2021-07-13 06:35:58 -04:00
Felix Stürmer
e9f42d27eb
[Logs UI] Register log threshold rule as lifecycle rule (#104341)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 11:59:11 +02:00
Ignacio Rivas
8c9de0b0cc
[Ingest pipelines] add network direction processor (#103436)
* initial form setup

* custom solution with usemultifields

* wip: sort of working now

* fix bootstraping of initial state

* fix field validation

* add tests

* fix linter errors

* Fix i18 namespace

* Fix linter problems and remove unused whitelisting

* Fix copy for description

* lil prettier fix

* add docs and tweak copy

* small tweaks

* [Form lib] expose handler to access field defaultValue

* Refactor <NetworkDirection />

* fix up import orders

* Fix test mocks

* Move up mocks a bit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sabee77@gmail.com>
2021-07-13 12:43:10 +03:00
Yulia Čech
538dfba513
[Console] Autocomplete definitions (manual backport) (#105086)
* [Console] Removed x-pack console extensions folder and moved json files to src/plugins/console

* [Console] Generated console definitions with ES repo on master branch

* Added some overrides and doc links fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 10:31:50 +02:00
Esteban Beltran
a4a7253d30
[Security Solution] User can make Exceptions for Memory protection alerts (#102196) 2021-07-13 10:21:31 +02:00
Marco Liberati
26bc0015ba
[Lens] Formula: add validation for multiple field/metrics (#104092)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 10:09:46 +02:00
James Gowdy
aa85de3fbf
Removing async from file upload and data visualizer plugins start lifecycle (#105197) 2021-07-13 09:08:40 +01:00
Pablo Machado
516480e78e
Fix error when validating the form with non blocking validations (#103629)
* Fix error when validating the form with non blocking validations

issue: https://github.com/elastic/kibana/issues/102338

* Add a flag to only validate blocking validation when validating the form

* Refactor bypass validation

Co-authored-by: Sébastien Loix <sabee77@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 10:06:53 +02:00
Dima Arnautov
9ccbbef582
[ML] Fix "View by" swim lane with applied filter and sorting by score (#105217)
* [ML] fix top influencers fetch with filter selection

* [ML] add relative position to the chart container

* [ML] fix ts

* [ML] fix updating search input from influencer filter
2021-07-13 10:03:21 +02:00