Commit graph

3138 commits

Author SHA1 Message Date
Marco Vettorello 5cd40b43ff Replace Discover chart with elastic-charts (#43788)
* use elastic-charts for histogram
* add class accessibility
* specify onElementClick type annotation
* set chartElement tooltip type to Follow
* use moment methods for now annotation logic
* move historam inside directive folder
* remove unused timechart directive
* remove dependency from tsvb brush handler
* remove non-required class to fix tooltip overflow
* change the cursor/crosshair
* fix(ie11): add fixed width for header text
* fix: annotation colors on dark theme
* unpdate click and brush ui functional tests
* move functional tests to percy
2019-09-10 12:44:36 -05:00
spalger 078ac2897f Revert "Revert "[ci] compress jobs for CI stability" (#44584)"
This reverts commit 50355d08f2.
2019-09-10 09:03:23 -07:00
Matthias Wilhelm 3798674043
De-angularize and EUI-ficate Discover Context control elements (#44474)
* Create ActionBar component, merges loading button and size picker

* Use react component, remove angular code

* Migrate constants + state to typescript

* Remove unused increaseCount functions + tests

* Add jest test
2019-09-10 16:47:28 +02:00
Christiane (Tina) Heiligers 0656e4fc00
Remove double call to update state from saved query (#45046)
* Changes saved query watchers in Discover to reduce number of calls to updateStateFromSavedQuery

* Changes saved query watchers in Dashboard to reduce number of calls to updateStateFromSavedQuery

* Changes saved query watchers in Visualize to reduce number of calls to updateStateFromSavedQuery

* formatting

* fixes test
2019-09-06 16:12:31 -07:00
Daniil Suleiman ab24359879 Replace TSVB timeseries charts with elastic-charts (#33558)
* Replace TSVB timeseries charts with elastic-charts

* Add sort index for series

* Update src/legacy/core_plugins/metrics/public/visualizations/views/timeseries/index.js

Co-Authored-By: Nick Partridge <nick.ryan.partridge@gmail.com>

* Fix PR comments

* fix issue with scaling

* fix crosshair styles for bar
2019-09-06 12:45:30 +03:00
Dmitry Lemeshko 3a158b9d7d
FTR: fix WebDriver Actions calls (#44605)
* [services/web_element_wrapper] add actions API methods

* fixes

* [services/browser] fix dragAnDrop to work in both w3c/non-w3c modes

* small review changes

* dragAndDrop: add default values for offset
2019-09-06 07:54:26 +02:00
Mikhail Shustov 861a1e26cc
disable router prefixing with pluginId (#44855)
to unblock plugin migration until new api and static
resource services are available
2019-09-05 18:03:09 +02:00
Stacey Gammon 81d06d5378
Decouple actions from embeddables: step 1 (#44503)
* Decouple actions from embeddables: step 1

* prefer as any instead of is-ignore

* Remove unneccessary test, no more triggerContext to be null.

* Fix bug and fix the test that should have caught it.  Be more strict about checking isCompatible.
2019-09-05 10:17:42 -04:00
Matt Bargar e195279918
Attempts to make saving of the current query more robust (#44797) 2019-09-04 18:49:31 -04:00
Dmitry Lemeshko 96cd619380
[visualize/_tsvb_time_series] fix flaky test (#44505) 2019-09-04 08:05:58 +02:00
Josh Dover b352f67bdb
Add ApplicationService Mounting (#41007)
* Add core-only bundle

* Add ApplicationService mounting

* Add LegacyCore{Setup,Start}

* Fix PR comments

* Add functional tests

* Fix PR comments

* Fix PR comments

* Remove other usages of rootRoute

* Use state field notation

* Add support for open in new tab

* Fix PR comments

* Fix pesky await from the dead

* Update docs

* Bump @types/history
2019-09-03 13:03:05 -05:00
Spencer 50355d08f2
Revert "[ci] compress jobs for CI stability" (#44584)
This reverts commit debf8c62b4.
2019-09-03 08:36:47 -07:00
spalger ac23159b1f disable flaky suite (#22322) 2019-08-30 15:30:44 -07:00
Rashmi Kulkarni 382733be29
[WIP] Rollup unskip test - test 30 times on CI (#44304)
fixes https://github.com/elastic/kibana/issues/43559
2019-08-30 10:36:51 -07:00
Stacey Gammon c469b0849d
np-ify embeddable explorer plugin (#44110)
* np-ify embeddable explorer plugin

* use plugins.embeddable, not start
2019-08-30 12:04:32 -04:00
Matthias Wilhelm 213ae02162
Remove :type from discover context url (#44008)
* Add url without type to discover context

* Add redirectTo for the legacy URL

* Adapt link to context in discover table

* Remove code duplication by usage of redirectTo

* Remove anchorType from application and tests

* Cleanup mocha tests
2019-08-30 16:33:06 +02:00
Caroline Horn fbc1be5240
Saved queries design cleanup (#44191) 2019-08-29 09:11:29 -04:00
spalger debf8c62b4 [ci] compress jobs for CI stability 2019-08-28 22:31:40 -07:00
spalger 3ad4eb86da Revert "only build if necessary"
This reverts commit eb9f54d216.
2019-08-28 20:55:39 -07:00
spalger eb9f54d216 only build if necessary 2019-08-28 17:49:08 -07:00
Greg Thompson fbca664cd2
eui to 13.6.1 (#44149) 2019-08-27 17:25:24 -05:00
Dmitry Lemeshko 48c610968e
esArchiver: retry kibana config update (#43987)
* [services/es_archiver] retry uiSettings update

* run x-pack-ciGroup7 30x times

* Revert "run x-pack-ciGroup7 30x times"

This reverts commit 80e199c3aa.

* [saved_object_api_integration/common/services] add retry service to the set

* add retry service for x-pack api tests
2019-08-27 23:15:29 +02:00
spalger 9d8f808063 skip flaky test (#44132) 2019-08-27 13:40:36 -07:00
Greg Thompson 084433fbee
Upgrade EUI to 13.6.0 (#43916)
* eui to 13.6.0

* euirange updates

* euipage snapshot updates

* add classname toggle for nav locking

* new header wrapper component; removed observable

* Add styles for locked nav

And updated BEM naming of `header-global-wrapper`

* move headerwrapper

* isLocked localStorage

* remove useEffect
2019-08-27 14:47:41 -05:00
Christiane (Tina) Heiligers 43df3a78ed
Reset dirty saved query on reload (#43927)
* Clears changes a loaded saved query before loading another one

* Adds general functional test to ensure changes to a saved query are discarded on reloading it

* Moves resetting a dirty saved query to the app controllers in Discover, Visualize and Dashboard
2019-08-27 12:00:47 -07:00
Mikhail Shustov 9a732014cb Response factory parameters as named arguments (#43248)
* pass body as response parameter. use attributes for error responses

* update core

* update tests

* update x-pack code

* update x-pack tests

* regen docs

* update comment

* Review feedback and fixes after master merge

* Eslint fixes
2019-08-23 19:31:17 +02:00
Spencer e1535d5660
[indexPatterns/bytesFormat] switch default decimal places to 1 (#43785)
* [indexPatterns/bytesFormat] switch default decimal places to 1

* set format:bytes:defaultPattern in some functional test suites
2019-08-23 07:03:23 -07:00
Matt Bargar bba04a51e3
Save query form validation on blur (#43726)
This PR changes the save query form to only validate its inputs on blur. Previously we validated on every change. This could lead to the errors flashing in the user's face before they're done typing a valid input. For example, we allow spaces in the name field, but not at the beginning or end of the name. So if a user typed this is a long name with spaces they would see the error pop up every time they type a space, only to have it disappear when they type the next letter.
2019-08-22 17:39:29 -04:00
Daniil Suleiman e568c3dfde
[Vis: Default editor] EUIficate gauge/goal options tab (#43265)
* Euificate gauge options

* Changes params places

* Add ranges validation

* Get rid of legacy translates

* Fix functional tests

* Split gauge to panel components

* Disable alignment option
2019-08-22 16:01:55 +03:00
Matt Bargar e233e419cf
Implement saved queries and filters (#39140)
Introduces "saved queries". Saved queries are a new saved object type similar to saved searches but more limited in scope. They allow users to store the the query string in the query bar and optionally the set of filters and timefilter in order to reload them anywhere a query is expected: Discover, Visualize, Dashboard, anywhere that uses our full SearchBar component.
2019-08-21 16:53:19 -04:00
Josh Dover 5071c74945
Replace CSP 'nonce-<base64>' directive with 'self' directive (#43553) 2019-08-21 14:11:38 -05:00
Dmitry Lemeshko 9b9801f470
functional tests for input control range (#42483)
* [apps/visualize] functional tests for input control range

* update jest test to have 100% combined coverage with functional
2019-08-21 17:22:54 +02:00
dave.snider@gmail.com b0a4181f7d
Upgrade EUI@13.3.0 (#42858)
Upgrades 13.3.0
2019-08-20 13:37:47 -07:00
Matthias Wilhelm dd26316fd2
De-angularize DocViewer (#42116)
* Migrate doc-viewer directive to use React/TypeScript

* Refactor DocViewsRegistryProvider

* Add compatibility for 3rd party plugins still using angular

* Add tests

Angular rendering for usage in React component:

Co-authored-by: spalger <email@spalger.com>
2019-08-20 07:47:21 +02:00
Mikhail Shustov 00a0203584 Extend request handler with request scoped core capabilities (#43103) 2019-08-19 13:34:48 -05:00
Vadim Dalecky d2166596b0
fix: 🐛 pass whole action context to isCompatible() method (#43457)
* fix: 🐛 pass whole action context to isCompatible() method

* test: 💍 add function test for saved search filtering in pie

* test: 💍 move save search functional test in its own test suite
2019-08-19 14:31:32 +02:00
Daniil Suleiman df72f91878
[Vis: Default editor] EUIficate region map options tab (#42944)
* EUIficate region_map_options

* Reuse types

* Remove wms_options directive

* Remove style import

* Fix issue with join field default value
2019-08-15 21:09:28 +03:00
Matthias Wilhelm 6da05e0b8d
Restore discover histogram selection triggering fetch (#43097)
* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error
2019-08-14 18:12:29 +02:00
Maryia Lapata a892d58677
[Vis: Default editor] EUIficate Panel Setting tab (#42828)
* EUIficate pointe-series and grid

* Apply TS

* Show grid on a panel

* Remove extra space

* Add TS

* Use BasicOptions

* Adjust func test

* Add dataTestSubj prop to SelectOption

* Use id instead of data-sest-subj

* Disable show x-axis lines when there is histogram agg

* Add tooltip for disabled 'Show x-axis lines' config

* Remove extra space
2019-08-14 17:52:36 +03:00
Mike Côté f6e137baf7
Re-enable failing test (#43190) 2019-08-13 10:56:55 -04:00
spalger e3b0ff6e93 skip failing test (#43163) 2019-08-12 20:43:15 -07:00
Spencer c29a17ce3c
[ftr] enable visualRegression jobs (#42989)
* enable visualRegression jobs

* skip the console and login visual tests
2019-08-12 10:50:22 -07:00
Vadim Dalecky ece2c35de1
Embeddables 👉 NP-ready (#41272)
* refactor: 💡 create registries file

* docs: ✏️ add testing command to docs

* chore: 🤖 create state folder

* chore: 🤖 WIP

* refactor: 💡 remove static imports of stateful things

Make Embeddables ./triggers tests pass

* test: 💍 add await-of for testing

* refactor: 💡 move stateless code into shim's lib/ folder

* test: 💍 add registry tests

* feat: 🎸 add Embeddable plugin public "setup" API

* feat: 🎸 create Embeddable plugin shim

* refactor: 💡 minor improvements for new plugin structure

* refactor: 💡 move test helpers into shim

* feat: 🎸 add Embeddable setup.getTrigger() method

* feat: 🎸 inject setup API into pure setup functions

* refactor: 💡 generate Embeddable setup API in a loop

* feat: 🎸 add getTriggerActions() Embeddable setup function

* feat: 🎸 add getTriggerCompatibleActions() to Embeddable shim

* chore: 🤖 uninstall await-of package

* chore: 🤖 simplify imports/exports

* test: 💍 improve testing utilities

* feat: 🎸 add executeTriggerActions() Embeddables setup method

* fix: 🐛 remove non-existing import

* chore: 🤖 cleanup actions

* refactor: 💡 move errors into dedicated errors.ts file, add test

* test: 💍 add unit test for ApplyFilterAction class

* test: 💍 import helpers correctly after refactoring

* test: 💍 fix actions tests

* feat: 🎸 clean up /lib/embeddables

* test: 💍 fix /lib/containers tests

* test: 💍 make embeddable_panel.test.tsx tests pass

* refactor: 💡 work on briging EditPanelAction action to /actions

* test: 💍 make /containers tests pass

* test: 💍 make /actions and /embeddables tests pass

* test: 💍 clean up tests from legacy platform static imports

* feat: 🎸 add getEmbeddableFactories API method

* test: 💍 add tests for factory list method

* feat: 🎸 add start life-cycle API

* feat: 🎸 unify Embeddables API

* refactor: 💡 create /css folder, move all CSS there

* feat: 🎸 improve dashboard container shim

* feat: 🎸 progress on dashboard container shim

* feat: 🎸 implement getEmbeddableFactory Embeddable API method

* feat: 🎸 improve embeddable container shim

* test: 💍 fix dashboard container expand panel tests

* test: 💍 fix dashboard grid tests

* test: 💍 fix createPanel tests

* test: 💍 fix dashboard viewport tests

* test: 💍 fix dashboard container tests

* test: 💍 add Embeddable plugin mock

* test: 💍 improve tests after merge

* refactor: 💡 move new platform code into np_ready folders

* chore: 🤖 fix some TS errors after merge

* chore: 🤖 fix more TS errors after merge

* fix: 🐛 fix TypeScript errors in kbn_tp_sample_panel_action

* fix: 🐛 fix more TypeScript errors

* fix: 🐛 fix TypeScript in functional tests

* fix: 🐛 fix more TypeScript errors

* fix: 🐛 fix more TS errors

* refactor: 💡 pass deps through constructors

* refactor: 💡 improve dependency injection and fix tests

* test: 💍 fix container integration tests

* test: 💍 fix customize_panel_modal tests after refactor

* test: 💍 fix all tests in embeddable_api

* chore: 🤖 fix linter error

* test: 💍 fix dashboard_embeddable_container tests after merge

* test: 💍 fix /src TypeScript errors

* fix: 🐛 fix Jest tests and add global typings in demo plugin

* fix: 🐛 fix build errors

* fix: 🐛 make build start without errors

* fix: 🐛 in dashboard container don't import types from ui/*

* chore: 🤖 fix linter errors

* refactor: 💡 remove getUserData, remove another ui/new_platform

* chore: 🤖 fix linter errors

* refactor: 💡 remove ui/new_platform from HelloWorldAction

* refactor: 💡 remove ui/new_platform from SendMessageAction

* refactor: 💡 remove ui/new_platform from ContactCardEmbeddableF*

* chore: 🤖 fix ESLint errors

* feat: 🎸 throw if action or trigger with given ID already exists

* feat: 🎸 throw if embeddable factory already registered

* docs: ✏️ fix tsdoc

* chore: 🤖 remove unused @ts-ignore

* refactor: 💡 remove createEmbeddables() function

* refactor: 💡 use new NP inspector plugin

* fix: 🐛 fix TypeScript errors

* chore: 🤖 improve plugin manifests

* feat: 🎸 cherry pick exported API from Embeddable plugin

* refactor: 💡 do not import constants from Kibana App

* fix: 🐛 remove unnecessary any

* chore: 🤖 uncomment SASS files

* refactor: 💡 remove IndexPattern logic out of dashboard panel

* refactor: 💡 move RefreshInterval and TimeRange to New Platform

* fix: 🐛 revert back notifications usage

* chore: 🤖 export test samples from index.ts files

* test: 💍 re-enable ApplyFilterAction integration tests

* chore: 🤖 remove unused translation

* refactor: 💡 rename variable to something less React specific

* fix: 🐛 improve CSS imports, remove unused hack, remove any type

* fix: 🐛 fix Embeddables demo plugin

* fix: 🐛 fix missing SASS variable

* fix: 🐛 re-enable translation

* fix: 🐛 uncomment saved object flyout panel logic

* refactor: 💡 pass in <SavedObjectFinder> from top level

* test: 💍 re-enable add_panel_flyout tests

* refactor: 💡 pass in <ExitFullScreenButton> through args

* fix: 🐛 import specific constants to fix functional tests

* fix: 🐛 fix CI type_check error

* test: 💍 change import paths to fix functional tests on CI

* test: 💍 fix exit button test after refactoring

* refactor: 💡 make do not change page on grid error

* test: 💍 fix functional test

* refactor: 💡 move CSS next to components

* fix: 🐛 remove missing props

* test: 💍 try fixing functional test on CI

These tests pass locally, but fail on CI. This is a stab to fix it on
CI.

* refactor: 💡 move variables.scss one folder up

* test: 💍 disable Embeddable Explorer functional tests

* chore: 🤖 remove onCoreReady in functional tests

* test: 💍 disable maps functional test for embeddables

* chore: 🤖 remove comment, export types explicitly

* refactor: 💡 remove unused `firstName`, add link to issue

* refactor: 💡 remove double underscore __ in test registry names

* refactor: 💡 remove utils folder, move bootstrap() fn to top lvl

* test: 💍 uncomment edit_panel_action tests

* test: 💍 uncomment inspect_panel_action tests
2019-08-12 12:41:18 +02:00
Brandon Kobel 2ce2bfbca7
Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (#41305)
* Adding "style-src 'unsafe-inline' 'self'" to default CSP rules

* Updating jest snapshot

* Fixing api integration smoke test

* Verifying all CSP responses

* Fixing OIDC implicit flow test
2019-08-09 15:15:40 -07:00
Dmitry Lemeshko 2198222f28
run chained_controls on Firefox to catch regression (#43044) 2019-08-09 21:40:34 +02:00
Dmitry Lemeshko 2ebbf1b091
[apps/dashboard] skip part of filtering tests on FF (#43047) 2019-08-09 20:46:28 +02:00
Peter Pisljar 06706b5748 fixes scaling logic to check agg type instead schema (#42574)
* fixes scaling logic to check agg type instead schema

* adding selenium test

* updating jest snapshot

* fixing test

* Change test order

* Fix test order
2019-08-08 18:09:14 +02:00
Dmitry Lemeshko ce07151bf4
bump chromedriver version to 76 (#42468)
* bump chromedriver version to 76

* [test/interpreter_functional] update snapshots

* [test/interpreter_functional] skip failing tests

* Revert "[test/interpreter_functional] update snapshots"

This reverts commit 6401554882.

* [test/interpreter_functional] skip snapshot tests
2019-08-07 22:52:02 +02:00
Josh Dover 5192dac0b6
Add ContextService to server (#42395) 2019-08-06 12:24:49 -05:00
Nicolas Chaulet 1aa21c123d
[Tests] Setup contract tests in x-pack (#42345) 2019-08-05 11:15:03 -04:00