Maryia Lapata
5e687b12ec
[NP] Clean up shim legacy_imports ( #57192 )
...
* Clean up ui/documentation_links in vis_default_editor
* Replace move from ui/utils/collection
* Remove loading stateManagementConfig since it is unused
* Inline SimpleEmitter
* Inline Binder to get rid of a dep
* Remove unused imports
* Update unit test
* Fix test
* Remove unused legacyChrome
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-12 15:22:02 +03:00
Liza Katz
b8c5b249fc
Explicit namespaces for esFilters ( #57177 )
...
* Explicit namespaces for esQuery and esQuery
* Remove unnecessary file from siem
* remove jsonvalue definition from siem
* esFilters refactor O_O
* Delete IFilterType
* import fixes
* Fix merge
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-12 13:22:06 +02:00
Alexey Antonov
c1a40f33ac
fix Master branch ( #57421 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-12 12:05:36 +02:00
James Gowdy
7e753e9883
[ML] Removing missed timefilter use ( #57373 )
2020-02-12 09:07:16 +00:00
Mikhail Shustov
2abc3f5793
[NP] Add meta-data and timestamp formatting for Log Record ( #56982 )
...
* log meta in pattern layout
* address pgayvallet comment
* add conversion patterns for timestamp
* use comparison instead of inline snapshots
* logs. use elasticsearch and LP compatible timezone format in json layout
* use regexp groups and dot separator for ms. as in default iso format
* use America/New_York timezone as default as it set in guess anyway
* fix APM tests. they need to reset timezone locally and restore it after
* fix logging tests
2020-02-12 09:04:50 +01:00
Pierre Gayvallet
49bec6e73e
preprend basePath in getUrlForApp ( #57316 )
2020-02-12 08:08:14 +01:00
Liza Katz
6eaeca8538
Explicit index pattern namespace ( #57194 )
...
* Explicit index pattern namespace
* typing of index patterns
* fix ts error on master
* export FieldList
* Move isFilterable into indexPatterns namespace
* Server index pattern cleanup
* comment
* isDefault
* karma mock fix + discover fix
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-12 09:04:51 +02:00
Shailesh cheke
3c3d0b539c
Fix paths for kibana packages used by plugins ( #57097 )
...
* Fix paths for kibana packages in prepare_project_dependencies(#40858 ).
* Dist/index.js after yarn build.
* chore(NA): correctly include kbm pm new dist file
* Commit after cherry-pick 985c85c from recreation branch.
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-12 04:04:35 +00:00
Garrett Spong
93138a3570
[SIEM] Fixes Host Details Events Table to only show events for specified Host ( #57388 )
...
## Summary
Fixes an issue where the `Events Table` on the `Host Details` page would show all events instead of those for the specific host. Also adds tests to make sure this doesn't happen again 🙂
Note: This will not interfere with any user-added queries/filters as those are added separately.
##### Before / After (See Event count at bottom of image)
<img width="300" alt="Screen_Shot_2020-02-11_at_15_35_12" src="https://user-images.githubusercontent.com/2946766/74286988-2f6bbb80-4ce6-11ea-9ca2-35d4ae9ff3f2.png "> <img width="300" alt="Screen_Shot_2020-02-11_at_15_46_23" src="https://user-images.githubusercontent.com/2946766/74287150-840f3680-4ce6-11ea-9267-365753a52fc2.png ">
### Checklist
Delete any items that are not applicable to this PR.
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~
- [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server )~
- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~
### For maintainers
- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
2020-02-11 20:11:01 -07:00
Poff Poffenberger
0dd8129b0e
[Canvas] Move sample data and feature registration to canvas np plugin ( #56564 )
...
* Move sample data and feature registration to canvas np plugin
* Prepare to move i18n to new platform and adjust paths
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 17:24:21 -06:00
Patrick Mueller
f304f88605
instrument task manager with apm transactions ( #55356 )
...
Adds some apm transaction boundaries for parts of task manager, so that
they will show up in APM as new types of transactions. Should provide
some visibility into the ES calls made by task manager for alerting and
actions, especially under stress testing scenarios.
2020-02-11 18:20:56 -05:00
Gidi Meir Morris
3effcdb94a
displays Alert Instance state on Alert Details page ( #56842 )
...
Adds a list of Alert Instances to the Alert Details page based off of the current state of the Alert.
2020-02-12 11:53:06 +13:00
Michail Yasonik
6207b74f80
Adding the Accessibility Statement to docs ( #57153 )
...
* adding accessibility statement to docs
2020-02-11 17:31:43 -05:00
Justin Kambic
7f336b497d
[Uptime] Remove redundant adapter function ( #56980 )
...
* Remove get_doc_count function in favor of index status function.
* Rename adapter function.
* Remove obsolete import.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 17:28:23 -05:00
Frank Hassanabad
f890776e6d
[SIEM][Detection Engine] Backend end-to-end tests
...
## Summary
* Adds end to end integration tests
* Fixes a bug with import where on imports it was forcing all rules that were being imported to be set to be "enabled: false" instead of honoring what the original export has set for its enabled.
* Adds a few "to be safe" await block so that the front end does not get a race condition within the bulk deletes and other parts of the code.
* Fixes `statusCode` to be `status_code` and removes most of the Hapi Boomer errors
* Changes PUT to be PATCH for partial updates
* Adds true updates with PUT
* Put some TODO blocks around existing bugs found in the API in the e2e tests that we might have time to get to or might not. This will let others maintaining the tests know that once they fix the bug they should update the end to end test to change the behavior.
Testing this:
Go to the latest CI logs and look for any particular lines from the test executing such as:
```ts
should set the response content types to be expected
```
Also run this manually on your machine through this command:
```ts
node scripts/functional_tests --config x-pack/test/detection_engine_api_integration/security_and_spaces/config.ts
```
Change a test manually and re-run the above command to watch something fail.
Screen shot of what you should see on the CI machine when these are running:
<img width="1825" alt="Screen Shot 2020-02-08 at 10 15 21 AM" src="https://user-images.githubusercontent.com/1151048/74089355-ae9a8e80-4a5d-11ea-9050-86e68d7e3bba.png ">
### Checklist
Delete any items that are not applicable to this PR.
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
~~- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server )~~
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
### For maintainers
- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )
2020-02-11 15:24:30 -07:00
Shahzad
5bfbf5f530
[Uptime] Added tests for pages ( #56736 )
...
* added test for pages
* fixed types
* update types
* update snap
* PR feedback
* PR feedback
2020-02-11 22:48:22 +01:00
Brandon Kobel
f305fe0168
Updating to kind-of@6.0.3 ( #57367 )
...
* Updating to kind-of@6.0.2
* Rebuilding @kbn\pm
2020-02-11 13:35:19 -08:00
Mike Côté
8ec0e01b34
Include actions new platform plugin for codeowners ( #57252 )
2020-02-11 15:41:32 -05:00
Brandon Morelli
3e95a84b37
[APM][docs] 7.6 documentation updates ( #57124 )
2020-02-11 11:43:03 -08:00
Vadim Dalecky
454d0a2646
Expressions refactor ( #54342 )
...
* feat: 🎸 add UiComponent interface
* feat: 🎸 add adapter for react => ui components and back
* refactor: 💡 move registries to shared /common folder
* feat: 🎸 create expressions service state contaienr
* chore: 🤖 export some symbols
* feat: 🎸 add Executor class
* test: 💍 add simple integration test
* feat: 🎸 move registries into executor
* feat: 🎸 add initial implementation of Execution
* feat: 🎸 move Executor's state container into a signle file
* refactor: 💡 move createError() to /common folder
* feat: 🎸 use Executor in plugin definition
* refactor: 💡 rename handlers to FunctionHandlers
* feat: 🎸 improve function typings
* feat: 🎸 move types and func in sep folder, improve Execution
* refactor: 💡 cleanup expression_types folder
* refactor: 💡 improve typing names of expression types
* refactor: 💡 remove lodash from ExpressionType and improve types
* test: 💍 add ExpressionType tests
* refactor: 💡 remove function wrappers around types
* refactor: 💡 move functions to /common
* test: 💍 improve expression function tests
* feat: 🎸 create /parser folder
* refactor: 💡 move function types into /expression_functions dir
* refactor: 💡 improve parser setup
* refactor: 💡 fix export structure and move args into expr_func
* test: 💍 add ExpressionFunctionParameter tests
* fix: 🐛 fix executor types and imports
* refactor: 💡 move getByAlias to plugin, fix Execution types
* feat: 🎸 add function for argument parsing
* test: 💍 add Executor type tests
* test: 💍 add executor function and context tests
* test: 💍 check that Executor returns Execution
* test: 💍 add basic tests for Execution
* test: 💍 add basic test for execution of a chain of functions
* test: 💍 add "mult" function tot tests
* feat: 🎸 create separate expression_renderer folder
* feat: 🎸 use new executor in public plugin
* feat: 🎸 remove renderers from executor, add result to execution
* fix: 🐛 fix Kibana TypeScript errors
* test: 💍 add file to write integration tests for expr plugin
* refactor: 💡 move state_containers to /common
* refactor: 💡 move /parser to /ast and inline format() function
* refactor: 💡 remove remaining @kbn/interpreter imports
* feat: 🎸 better handling and typing for Executor context
* feat: 🎸 use Executor.run function in plugin
* fix: 🐛 fix TypeScript type errors
* test: 💍 move integration tests into one file
* feat: 🎸 create ExpressionsService
* chore: 🤖 clean up legacy code
* feat: 🎸 use ExpressionsService in /public
* refactor: 💡 move inspector adapters to /common
* feat: 🎸 improve execution
* feat: 🎸 add state to execution state and don't clone AST
* test: 💍 add tests for Execution object
* test: 💍 improve expression test helpers
* test: 💍 add Execution tests
* refactor: 💡 improve required argument checking
* fix: 🐛 fix Kibana TypeScript errors
* test: 💍 add ExpressionsService unit tests
* fix: 🐛 fix Expression plugin TypeScript types
* refactor: 💡 prefix React component with React*
* fix: 🐛 fix X-Pack TypeScript errors
* fix: 🐛 fix test TypeScript errors
* fix: 🐛 fix issues preventing loading
* feat: 🎸 remove getInitialContext() handler
* fix: 🐛 fix TypeScript errors
* chore: 🤖 remove uicomponent interface
* chore: 🤖 remove missing import
* fix: 🐛 correctly handle .query in "kibana" expression function
* refactor: 💡 call first arg in expression functions "input"
* fix: 🐛 do not free Execution state container
* test: 💍 fix tests after refactor
* test: 💍 fix more tests after refactor
* fix: 🐛 remove redundant export
* test: 💍 update intepreter_functional test shapshots
* fix: 🐛 relax "kibana" function throwing on missin gsearch ctx
* refactor: 💡 don't use ExpressionAST interface in Canvas
* docs: ✏️ improve ExpressionRenderer JSDocs
* refactor: 💡 rename context.types to inputTypes in internal fn
* refactor: 💡 replace context.types by unknown in ExprFuncDef
* refactor: 💡 improve expression function definitions in OSS
* fix: 🐛 correctly set name on metric_vis_fn
* refactor: 💡 improve Lens definitions of expression functions
* refactor: 💡 improve Canvas expression function definitions
* test: 💍 add createMockExecutionContext() helper
* refactor: 💡 add some type to events$ observable in expr handler
* feat: 🎸 add types to observables in data handler
* refactor: 💡 use inputTypes in canvas
* fix: 🐛 fix interpreter grammer generation script
* feat: 🎸 allow array in getByAlias
* test: 💍 simplify test function specs
* test: 💍 fix autocomplete tests
* fix: 🐛 use correct expression types and NP getFunctions() API
* refactor: 💡 use NP expressions to get renderer
* fix: 🐛 use context.types on server-side Canvas function defs
* refactor: 💡 use NP API to register Canvas renderers
* feat: 🎸 use NP API to get types
* style: 💄 minor formatting changes
* feat: 🎸 use NP API to get expression functions
* fix: 🐛 fix Canvas workpads
* test: 💍 add missing mock functions
* refactor: 💡 improve Lens func definition argument types
* fix: 🐛 fix Lens type error
* feat: 🎸 make lens datatable work again
* feat: 🎸 bootstrap ExpressionsService on server-side
* feat: 🎸 expose more registry related functions in contract
* feat: 🎸 add environment: server to server-side expressions
* docs: ✏️ add documentation
* test: 💍 add missing Jest mocks
* fix: 🐛 correct TypeScript type
* docs: ✏️ improve documentation
* fix: 🐛 make FunctionHelpDict type contain only Canvas functions
* fix: 🐛 fix merge conflict
* test: 💍 fix expression mocks
2020-02-11 19:47:36 +01:00
Melissa Alvarez
9fd75dbb91
[ML] New Platform server shim: update annotation routes to use new platform router ( #57067 )
...
* update annotation routes to use NP router
* create ts file for feature check
* update schema to allow null value for earliest/latestMs
* update annotations model test
* use NP security plugin to access user info
2020-02-11 13:36:13 -05:00
Poff Poffenberger
d0dfacd863
Remove injected ui app vars from Canvas ( #56190 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 12:34:37 -06:00
Melissa Alvarez
c0497ce972
update max_anomaly_score route schema to handle possible undefined values ( #57339 )
2020-02-11 13:26:52 -05:00
Maja Grubic
7b6db2a07b
[Add panel flyout] Moving create new to the top of SavedObjectFinder ( #56428 )
...
* [Add panel flyout] Moving create new to the top of SavedObjectFinder
* [Add panel flyout] Moving create new to the top of SavedObjectFinder
* Fixing failing unit test
* Readd missing test
* [NP] Move saved object modal into new platform (#56383 )
* Move saved object modal into new platform
* Fix TS
* Revert "Fix TS"
This reverts commit f2f9f5e935d0f0ea6e30
2020-02-11 18:10:45 +00:00
Poff Poffenberger
57f5924f9f
Add mock of a legacy ui api to re-enable Canvas storybook ( #56673 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 12:07:01 -06:00
Tyler Smalley
9d7bdd3799
[monitoring] Removes noisy event received log ( #57275 )
...
This log is very noisy when running in verbose and does not appear to
have much value in debugging.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-02-11 09:59:21 -08:00
Jean-Louis Leysens
e7773f27c5
Remove use of copied MANAGEMENT_BREADCRUMBS and use setBreadcrumbs from management section's mount ( #57324 )
2020-02-11 18:33:21 +01:00
Matthew Kime
0d30327e01
Advanced Settings management app to kibana platform plugin ( #56931 )
...
* advanced settings component registry to new platform
2020-02-11 10:41:37 -06:00
Dima Arnautov
b133357311
[ML] New Platform server shim: update recognize modules routes to use new platform router ( #57206 )
...
* [ML] modules with NP router
* [ML] use extendedRouteInitializationDeps
* [ML] add apidoc annotations
* [ML] address PR comments
* [ML] convert data_recognizer test to jest
* [ML] optional indexPatternName
2020-02-11 17:11:29 +01:00
Dima Arnautov
733f6023d9
[ML] Fix overall stats for saved search on the Data Visualizer page ( #57312 )
...
* [ML] fix overall stats fetch with a saved search
* [ML] refactor
2020-02-11 17:04:00 +01:00
James Gowdy
b3e8bdf767
[ML] [NP] Removing ui imports ( #56358 )
...
* [ML] [NP] Removing ui imports
* replacing timefilter and ui context
* replacing ui/i18n and ui/metadata
* removing ui/system_api
* removing ui/notify
* removing most ui/new_platform
* fix explorer date format loading
* removing ui/chrome
* fixing timebuckets test
* fixing jest tests
* adding http
* testing odd CI type failure
* revrting type test changes
* fixing odd test type error
* refactoring dependencies
* removing injectI18n and using withKibana for context
* updating components to use kibana context
* re-enabling some tests
* fixing translation strings
* adding comments
* removing commented out code
* missing i18n
* fixing rebase conflicts
* removing unused ui contexts
* changes based on review
* adding text to errors
* fixing management plugin
* changes based on review
* refeactor after rebase
* fixing test
2020-02-11 16:03:42 +00:00
MadameSheema
7c05928e6f
[SIEM] Fixes failing Cypress tests ( #57202 )
...
* fixes events viewer tests
* fixes 'toggle column' tests
* fixes 'url state' tests
* fixes type check issues
2020-02-11 16:52:16 +01:00
Jason Rhodes
bb06ca8d69
Create observability CODEOWNERS reference ( #57109 )
...
* Create observability CODEOWNERS reference
* Update elastic/epm to elastic/ingest per Jen's request :)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 10:27:35 -05:00
Melissa Alvarez
82d2831c56
fix results service schema ( #57217 )
2020-02-11 10:21:33 -05:00
Peter Pisljar
1ffb171cfb
don't register a wrapper if browser side function exists. ( #57196 )
2020-02-11 09:30:43 -05:00
Stacey Gammon
2ae70d9592
Ui Actions explorer example ( #57006 )
...
* wip
* Move action registration out of AppMountContext fn
* Move all registration to setup
* Fix type error
2020-02-11 09:08:47 -05:00
Mike Côté
62e3189c34
Fix update alert API to still work when AAD is out of sync ( #57039 )
...
* Ensure update API still works when AAD is broken
* Add API integration test
* Fix ESLint errors
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 07:47:10 -05:00
Walter Rafelsberger
c654018122
[ML] Anomaly Detection: Fix jobs list default refresh. ( #57086 )
...
* [ML] Fix anomaly detection jobs list default refresh.
* [ML] Fix initial load of jobs list.
* [ML] Fix blockRefresh check.
* [ML] Fix blockRefresh check.
* [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list.
2020-02-11 12:45:28 +00:00
Nathan Reese
d7c2552944
[Maps] do not disable other styling when symbol size is dynmaic ( #57247 )
2020-02-11 05:38:16 -07:00
Søren Louv-Jansen
13cf3c83e7
Bump backport to 4.9.0 ( #57293 )
2020-02-11 13:28:53 +01:00
Pierre Gayvallet
c13b0751f3
kbn-config-schema: allow parsing of array and object types from string ( #57189 )
...
* allow parsing from string for object-ish and array types
* update snapshots
* fix FTR assertion
* add documentation note about using a json string as input
2020-02-11 11:19:02 +01:00
Liza Katz
eb54678f35
Explicit namespaces for esQuery and esKuery ( #57172 )
...
* Explicit namespaces for esQuery and esQuery
* Remove unnecessary file from siem
* remove jsonvalue definition from siem
* server
FieldFormatsRegistry,
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 12:14:58 +02:00
Justin Kambic
c383f50cdd
Consume core startup services. ( #57259 )
2020-02-11 11:01:15 +01:00
Jean-Louis Leysens
b67b1c3173
[Watcher] Fix flaky functional test ( #56393 )
...
* Give a bit more time for machines on CI
* Remove unnecessary sleep
* Dummy error logs [do not commit to master]
* Revert "Dummy error logs [do not commit to master]"
Also only update data (and call serializer) on a success response, not on an error response.
* Remove common.sleep and rewrite the comment explaining the use of retry.waitFor
* Fix typo
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 09:39:20 +01:00
Sébastien Loix
7e9d79754c
[Index management] Server-side NP ready ( #56829 )
2020-02-11 11:36:17 +05:30
Peter Schretlen
bb7e152211
Webhook action - make user and password secrets optional ( #56823 )
2020-02-10 17:08:56 -05:00
gchaps
682d3672c2
[DOCS] Removes reference to IRC ( #57245 )
2020-02-10 13:35:06 -08:00
igoristic
205c2ab761
[Monitoring] NP migration: Local angular module ( #51823 )
...
* More np stuff
* Fixed tests and added more np stuff
* Added missing variable
* Fixed path and linting
* resolved conflicts
* Fixed liniting issues
* Fixed type tests
* Fixed i18n check
* Added from master
* Added more shims
* Updated master
* Merged master
* Fixed ts config file
* Fixed ui_exports
* Fixed snapshots
* Fixed hard refresh bug and some tests
* Addresed feedback
* Added missing imports
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-10 15:57:20 -05:00
Garrett Spong
a68a18e8c3
[SIEM] Adds ECS link to help menu ( #57104 )
...
## Summary
Adds link to ECS docs in SIEM HelpMenu as requested by @MikePaquette. 🙌 📜
<img src="https://user-images.githubusercontent.com/2946766/74039051-71ab9a80-497e-11ea-92e0-e69988af8fdc.png " width=300>
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~
- [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server )~
- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~
### For maintainers
- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
2020-02-10 13:48:15 -07:00
Josh Dover
af37d5fc12
Ensure http interceptors are shares across lifecycle methods ( #57150 )
2020-02-10 13:32:09 -07:00
