Commit graph

4617 commits

Author SHA1 Message Date
Matthew Kime
3fd7dbe455
[data views] allow fields that start with an underscore in the field list (#111238)
* stop filtering out fields that start with underscore
2021-09-13 10:45:34 -05:00
Maja Grubic
22d253f846
[Discover] Fix a functional test 'index pattern with unmapped fields' (#111323)
* [Discover] Fix a functional test

* Fix failing type

* Select index pattern first

* Select index pattern first

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-13 16:44:03 +02:00
Matthias Wilhelm
f3dc980bb9
[Discover] Fix permissions for runtime fields functional test (#111925) 2021-09-13 16:03:15 +02:00
Diana Derevyankina
33cfc4183a
[TSVB] Support custom field format (#101245)
* [TSVB] Support custom field format

Add format_label response processor for series vis data and bucket key formatting to process_bucket for table vis data

* Add ignore_field_formatting for series to support value formatting for all panel types except markdown

* Fix type issue for visData and rename getCustomFieldFormatter to createCustomFieldFormatter

* Update vis.test to cover custom field formats logic and add a migration script to set ignore_field_formatting to true for the series

* Move createCustomFieldFormatter to a separate file, make formatting respect only active metrics field name, refactor vis files and fix label formatting only for grouped by terms series

* Remove services, add getFieldFormatsService  to use it in format_label and get_table_data, replace getCustomFieldFormatter with createCustomFieldFormatter

* Update plugin.ts

* Update start for plugin.ts

* Add formatting for annotations and markdown values

* Refactor some code

* Update some naming and conditions

* Fix formatting of data type labels

* In process_bucket fix case for no getFieldFormatByName

* Add field formatting functional tests for all panel types

* Update tests to make them run correctly for firefox

* Update _tsvb_markdown test setup

* Move series ignoreFieldFormatting check to a separate file, change convertSeriesToVars signature, update migration script and refactor a bit functional tests

* Fix type check for timeseries_visualization.tsx

* Update migrations.js test expected version to 7.15

* Fix tests in _tsvb_chart.ts

* Fix merge conflict remove process_bucket.js

* Update process_bucket.test.ts

* Fix markdown labels formatting

* Add ignore_field_formatting for annotations, enhanced migration script to set that flag to true, refactor data_format_picker

* Fix migration script and add disabling for ignore component when string index pattern is used

* Add supporting URL and color formatters in tsvb table

* Fix eslint

* Remove ignore formatting component, add field formatting option to TSVB data format picker and make it default, remove migration script, update tests and refactor some files

* Fix failing tests, refactor create_field_formatter and add test to it, update some other files

* Fix series formatting for top hit when it has not numeric result

* Handle no fieldFormatMap case for table/vis.js

* Remove "Default" option form DataFormatPicker when index pattern is string, fix markdown variables issue and refactor some code

* Chore(TSVB): Replace aggregations lookup with map

* Fix types, update test expected data and remove unused translations

* Fix i18 check and useEffect in agg.tsx

* Handle aggregations field formatting case

* Fix agg_utils, vis and check_if_numeric_metric tests

* Correct typo and refactor condition in std_metric

* Fix type check

* Get rid of IFieldType

* Add URL and color formatting for topN and metric tabs, fix setting initial custom formatter and switching formatter in agg.tsx

* Update tsvb.asciidoc

* Remove link icon from Date format field help text, update click logic for top N in case of custom field format and fix CI

* Remove unused import

* Revert top N bar extra logic for click

* Refactor some code in agg.tsx

* Add URL and color formatting to Gauge

* Fix bug with terms formatting, refactor some code, update create_field_formatter

* Add comments to _gauge.scss

* Remove unnecessary await

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>
2021-09-13 11:51:32 +03:00
Stratoula Kalafateli
d60fab1413
[VisEditors] Add code ownership to the functional tests (#111680)
* [VisEditors] Add code owenership to the functional tests

* Remove the unnecessary imports

* Revert

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-13 11:36:14 +03:00
Uladzislau Lasitsa
70090e326c
Timelion App removal (#110255)
* Remove timelion app and stuff which related to it

* Fix CI

* Fix lint

* Fix tests

* Fix tests

* Fis tests

* Fix some comments

* Clean up

* fix CI

* fix some comments

* Fix deprecation examples

* Return `enabled` property in config for timelion vis

* Remove unused angular lib

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
2021-09-10 14:53:07 +03:00
Matthias Wilhelm
53ba2c42df
[Discover] Set ownfocus to false when displaying the document flyout (#108646) 2021-09-10 11:52:36 +02:00
Greg Thompson
6803fb362a
Upgrade EUI to v37.6.0 (#110998)
* eui to 37.6.0

* update snapshots

* grid cell text

* update snapshot

* Revert "grid cell text"

This reverts commit 1721e83939.

* grid cell text

* update tsvb baseline

* update area_chart baseline

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-09 14:54:30 -05:00
Rudolf Meijering
5464af6923
legacy dashboards import/export API: deprecation logs and usage data (#111283)
* Move legacy dashboards API to core and adds usage data

* More legacy_export plugin removal

* Log a warning for deprecated dashboard import/export API

* Review comments
2021-09-08 16:15:52 -04:00
Jonathan Budzenski
f2c00fdd5a
[os/kibana.yml] Use new logger (#111192)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 14:43:34 -05:00
Jonathan Budzenski
97f9497269
[ci] Update list of storybooks to build (#111556) 2021-09-08 14:40:03 -05:00
Matthias Wilhelm
284bc6663c
[Discover] Cleanup legacy code fragments (#110646) 2021-09-08 19:55:40 +02:00
Stratoula Kalafateli
6f4d8a52dc
[Vislib] Removes old implementation of xy chart (#110786)
* [Vislib] Remove xy chart

* Update i18n

* Remove uncecessary file

* Fix types

* More fixes

* Fix functional tests part 1

* Fix functional tests part 2

* Fix bug with shard-delay

* Fix functional tests part 3

* fix functional tests part4

* Fix async_serch FT

* Fix functional dashboard async test

* REplace screenshot area chart image

* Cleanup vislib from xy charts

* Remove unused fixtures

* Address PR comments

* Remove miaou :D

* Address PR comments

* Fix i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 18:35:51 +03:00
Tre
094f2c9b81
[Archive Migration][Partial] discover apps-discover (#110437)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-08 10:32:42 +01:00
Matthias Wilhelm
1b1e936320
[Discover] Fix indices permission for multiline test (#111284) 2021-09-08 07:41:01 +02:00
Devon Thomson
70632e2a9e
[Dashboard] Retain Tags on Quicksave (#111015)
* fixed missing tags api when loading saved dashboard. Added tests
2021-09-07 14:20:15 -04:00
Tre
f0a05e9b3f
[Archive Migration][Partial] discover apps-home (#110440) 2021-09-07 16:09:31 +01:00
Matthew Kime
7e9d2965da
remove skip test - no, _id is not aggregatable (#111241) 2021-09-07 08:52:55 -05:00
Dmitry Tomashevich
0d009438d1
[Discover] Add permissions for context size test (#109391)
* [Discover] add permissions for flaky context test

* [Discover] apply test_logstash_reader role

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-06 15:55:08 +03:00
Yaroslav Kuznietsov
eef094bafb
[Canvas] TagCloud (#106858)
* Added `tagCloud` to canvas.

* Added `icon` to the `tagCloud` element.

* Added column name support at `tag_cloud`.

* Added condition to `vis_dimension` not to pass invalid index.

Added check of accessor index, if such column exists at vis_dimension.
Removed checks of column existance from TagCloudChart.
Added test for accessing data by column name in addition to a column number.
Updated tag_cloud element in Canvas.
Fixed types. Removed almost all `any` and `as` types.

* Added test suites for `vis_dimension` function.

* Added tests for DatatableColumn accessors at tag_cloud_fn and to_ast.

* Refactored metrics, tagcloud and tests.

Added valid functional tests to metrics and tag_cloud.
Fixed types of metrics_vis.
Added handling of empty data at tag_cloud renderer.

* Added storybook ( still doesn't work ).

* Fixed some mistakes.

* Added working storybook with mocks.

* Added clear storybook for tag_cloud_vis_renderer.

* Updated the location of vis_dimension test after movement of the function.

* Fixed unused type.

* Fixed tests and added handling of the column name at `visualizations/**/*/prepare_log_table.ts`

* Reduced the complexity of checking the accessor at `tag_cloud_chart.tsx`

* Added comments at unclear places of code.

* Added the logic for disabling elements for renderers from disabled plugins.

* removed garbage from `kibana.yml`.

* Fixed element_strings.test error.

* Made changes, based on nits.

* Fixed mistake.

* Removed `disabled` flag for `expression_*` plugins.

* recovered lost comments at the unclear places.

* removed dead code.

* fixed test errors.

* Fixed test error, I hope.

* fixed more tests.

* fixed code, based on nits.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-06 04:13:38 -04:00
Tim Roes
b6ab15e9f4
Remove kibana.defaultAppId setting (#109798)
* Remove kibana.defaultAppId setting

* Fix typings

* Remove plugin dependency

* Use proper navigation method to get to home

* Default route for home

* Address discover new routing code

* Make non existing /kibana URLs working

* Fix space awareness

* Remove documentation

* Remove the setting from docker file

* Make defaultRoute forward work properly

* Add forward_url tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-03 17:59:59 +02:00
Christiane (Tina) Heiligers
66cb058fa7
Removes support for legacy exports (#110738)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-03 07:22:14 -07:00
Alejandro Fernández Haro
dfea0fee21
[GET /api/status] Default to v8format and allow v7format=true (#110830) 2021-09-03 07:32:59 -04:00
Mikhail Shustov
641cef7ca6
Functional tests for execution context (#110299)
* remove unnecessary ts-ignore

* add context propagation to x-opaque-id header tests

* run tests on CI

* simplify logging. the action purpose follows from the context name

* extend tests with the assertion against execution_context from the Kibana logs

* split JSON log records only

* apply suggestions proposed by Spencer
2021-09-03 05:48:32 -04:00
Jonathan Budzenski
95423242ac
[package testing] Update logging and pid configuration (#111059)
With the merge of #98213, pid and log file settings were moved from
command line options to kibana.yml.  Package tests use a non-default
kibana.yml and these settings were not applied.  This updates our
configuration to include these settings.
2021-09-02 20:11:45 -04:00
Devon Thomson
e704a52f6e
[Dashboard] Read App State from URL on Soft Refresh (#109354)
Subscribe to app changes from URL to allow dashboard URL to be used as an API. On URL change, update filters, timerange, and query
2021-09-02 17:50:02 -04:00
Poff Poffenberger
c692ad3724
Add correct roles to test user for functional tests in dashboard (#110880)
* Add animals role to test user for functional tests in dashboard

* Fix two more dashboard tests by applying proper roles

* Restore test user defaults

* Fix one last dashboard test

* forgot security service

* Cleanup
2021-09-02 16:35:12 -05:00
Diana Derevyankina
8a357fdabd
Failing test: Chrome UI Functional Tests.test/functional/apps/visualize/_tsvb_table·ts - visualize app visualize ciGroup12 visual builder table should display correct values on changing metrics aggregation (#110784) 2021-09-02 12:22:29 +03:00
Cauê Marcondes
2fe56f9793
[APM] tests restructure (#110703)
* refactoring test

* improving test structure

* improvements

* improving readmes

* readme

* test

* fixing ts issue

* addressing pr comments

* fixing readme files

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-01 16:42:33 -04:00
Tyler Smalley
9850414b92
[ci] Removes all verbose flags (#110842)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-09-01 12:05:28 -07:00
Ahmad Bamieh
249c5fbf9a
[Core deprecations] Add title field to deprecation info (#109840) 2021-09-01 13:10:25 +03:00
Tim Roes
c510288c05
Split KibanaApp into VisEditors and DataDiscovery (#110588)
* Split KibanaApp into VisEditors and DataDiscovery

* Add discover functional tests to codeowners

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-31 15:57:23 +02:00
Tre
234f7f6085
[Archive Migration][Partial] discover partial accessibility (#110073)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-30 15:16:22 +01:00
Alejandro Fernández Haro
7cfdd000ee
[Home app] Fix this references (#110207)
* [Home app] Fix `this` references

* More readable if
2021-08-26 10:18:39 -04:00
Alexey Antonov
3cc7da8435
[Lens] Inspect flyout should be available in editor mode. (#109656)
* [Lens] Inspect flyout should be available in editor mode.

* fix typo

* add test

* add functional tests for inspector

* toMatchInlineSnapshot -> toMatchSnapshot

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 10:18:09 -04:00
Nathan L Smith
406df4d986
Open in dev tools button for request inspector (#109923)
Add a "Open in Dev Tools" link to the request inspector.

Allow the dev tools to open data uris that are lz-string encoded (the same method used by TypeScript Playground, which are a lot shorter than a base64 encoded string.)
2021-08-25 12:49:13 -05:00
Diana Derevyankina
e3a6fc59f3
Chore(TSVB): Replace aggregations lookup with map (#109424)
* Chore(TSVB): Replace aggregations lookup with map

* Fix types, update test expected data and remove unused translations

* Correct typo and refactor condition in std_metric

* Fix metric type

* Fix CI and label for Bucket Script

* Update agg_utils.test expected data

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-25 13:06:24 +03:00
Constance
8dfdeadd40
[Enterprise Search] Set up cypress-axe tests (#108465)
* Set up cypress-axe

@see https://github.com/component-driven/cypress-axe

* DRY out Kibana axe rules into constants that Cypress can use

* Create shared & configured checkA11y command

+ fix string union type error
+ remove unnecessary tsconfig exclude

* Add Overview plugin a11y tests

* Add AS & WS placeholder a11y checks

- Mostly just re-exporting the shared command and checking for failures, I only ran this after the shared axe config settings and found no failures

* Configure our axe settings further to catch best practices

- notably heading level issues (thanks Byron for catching this!)

- however I now also need to set an ignore on a duplicate landmark violation caused by the global header (not sure why it's showing up - shouldn't it be out of context? bah)

- remove option to pass args into checkA11y - I figure it's not super likely we'll need to override axe settings per-page (vs not running it), but we can pass it custom configs or args later if needed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-24 12:05:41 -07:00
Nathan Reese
84be1c500e
[maps] remove xpack.maps.showMapVisualizationTypes (#105979)
* [maps] remove xpack.maps.showMapVisualizationTypes

* remove settings from xpack_plugins

* eslint

* new telemetry_check parser features

* remove xpack.maps.showMapVisualizationTypes from functional test config

* remove unused const destruct

* update expect for functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
2021-08-24 10:46:40 -06:00
liza-mae
c7d742cb8b
Fix field formatters test on cloud (#109707) 2021-08-24 08:11:08 -06:00
Stacey Gammon
52ee65b8d5
Make owner attribute required on kibana.json (#108231)
* make owner attribute required

* Add owner properties in more places

* add test for owner attribute

* add error check too in the test

* Fix tests

* fix tests and update docs

* wip

* More test fixes

* Fix All The Errorz

* Adding more owner attributes

* Update x-pack/test/saved_object_api_integration/common/fixtures/saved_object_test_plugin/kibana.json

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* Update x-pack/test/ui_capabilities/common/fixtures/plugins/foo_plugin/kibana.json

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* commeeeooonnnn

* Update docs

* soooo many kibanajsons

* adjust plugin generator to add an owner

* Add owner to the plugin generator scripts

* update snapshot

* Fix snapshot

* review updates

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-24 10:02:32 -04:00
Matthias Wilhelm
42527e4188
[Discover] Remove Angular from doc viewer (#109368)
* Remove angular from doc viewer

* Remove types

* Remove plugin_functional for angular doc_view, since testing angular is no longer necessary
2021-08-24 10:50:22 +02:00
Lukas Olson
0a8d42c80b
[data.search] Remove deprecated courier:batchSearches advanced setting (#109350)
* [data.search] Handle warnings inside of headers

* Update docs

* Add tests

* Remove isWarningResponse

* Remove deprecated courier:batchSearches advanced setting

* Update docs

* Remove legacy tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 09:31:13 -07:00
Yaroslav Kuznietsov
237fcac254
[Canvas] Expression tagcloud (#108036)
* Added `expression_tagcloud` plugin.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-23 06:52:19 -04:00
Anton Dosov
cd7f26dd81
[IndexPatterns] No data experience to handle default Fleet assets (#108887)
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
2021-08-20 17:58:34 +02:00
Matthias Wilhelm
aa2897ce51
[Discover] Fix runtime fields editor test in cloud environment (#109367) 2021-08-20 16:50:05 +02:00
Spencer
7e2bd4fd54
[ftr] rework ciGroup validation to remove JOBS.yml and avoid duplication (#109149)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-08-19 11:40:23 -05:00
Tiago Costa
eec7bb318b
skip flaky suite (#95376) 2021-08-19 15:31:52 +01:00
Alejandro Fernández Haro
3cb3984d59
[Flaky-tests] Fix SOM edit-saved-objects test (#109215) 2021-08-19 08:40:56 -04:00
Matthias Wilhelm
544c41e214
[Discover] Unskip discover tab field data functional tests (#107305) 2021-08-19 08:18:28 +02:00