Commit graph

28832 commits

Author SHA1 Message Date
Mike Côté
ea9bb0a0a5
Ability to have telemetry always opted in (#49798)
* Initial work

* WIP changes

* Turn off banner when allowChangingOptInStatus is true

* Fix bugs

* Fix broken jest tests

* Add jest tests for TelemetryForm

* Add TelemetryOptIn jest tests

* Make some adjustments to allow always being opted in

* Disallow turning telemetry completely off

* Fix bug in Joi config

* Keep route there
2019-11-11 18:28:38 -05:00
Mike Côté
a746bcec5f
Add "Get Help" and "Kibana Feedback" links to the help popover (#49797)
* Initial work

* Move links to constants

* Update UI based on design and copy

* Apply PR feedback

* Remove unused translations

* Apply requested changes

* Remove some icons
2019-11-11 18:26:12 -05:00
Jonathan Budzenski
1cc2a34745
Removes references to Elasticsearch mapping types (#47610)
* rm types

* fix infra/reindex test

* rm max_adjacency_matrix_filters

* lint

* more fixes

* comment return

* override documentation links

* typo

* return unfedined

* skip highlight test

* lint
2019-11-11 16:41:08 -06:00
Nathan Reese
9fdbf82ab3
[skip-ci] Replace coordinate map in Kibana getting started docs with Maps (#50167)
* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
2019-11-11 15:34:45 -07:00
Dima Arnautov
538d4864b9
[ML] Indicate missing required privileges for import in File Data Viz (#50147)
* [ML] show a tooltip which indicates missing required privileges for data import

* [ML] fix export

* [ML] PR comments
2019-11-11 22:58:20 +01:00
Frank Hassanabad
ab5f411753
[SIEM][Detection Engine] Removes technical debt and minor bug fixes (#50111)
## Summary

* Removes technical debt of name being in the params now that the regular alerting has name as a first class citizen.
* Only creates new signals on an update if it sees that saved objects return 404
* Changes the conversion script of saved searches to rules to be every 5 minutes for tests.
* Changes the logger levels to be mostly quiet by using debug instead of info.
* Small fixes for when we return false for errors on 0 found signals when that is not an error. 
* Added a delete all api keys for more cleanups when developing 

For testing things on the backend this is the `kibana.dev.yml` settings I use for this PR which enables the siem debug but filters out the others and enables additional request information for testing:

```yml
logging.verbose: true
logging.events:
  {
    log: ['siem', 'info', 'warning', 'error', 'fatal'],
    request: ['info', 'warning', 'error', 'fatal'],
    error: '*',
    ops: __no-ops__,
  }
```

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-11-11 13:02:09 -05:00
Joe Reuter
cbad2beea9
[Graph] Remove inferred edges leftover code (#50006) 2019-11-11 16:03:31 +01:00
Jean-Louis Leysens
0491589d50
[SearchProfiler] Fix console error message when umounting (#50105)
* Safer access of input ref

* Remove unnecessary "!" [skip ci]
2019-11-11 09:42:36 -05:00
Robert Oskamp
e2d3c87269
[ML] Skip advanced wizard categorization test (#50141) 2019-11-11 09:33:20 -05:00
Liza Katz
a72cb8589b
Move timefilter and PersistedLog ⇒ NP (#49491)
* Move timefilter to NP

* Fixed editor import

* added karma mocks

* More karma mocks

* Change way timefilter is mocked

* Fix timefilter passing in timelion

* attempted revert of mock types
2019-11-11 15:38:16 +02:00
Dario Gieselaar
15f2ebcdb8
[APM] Script optimization of APM-specific tsconfig (#49868)
* [APM] Script optimization of APM-specific tsconfig

* Don't break bootstrap process

* Document TS optimizations
2019-11-11 14:35:29 +01:00
Maja Grubic
8f6c41f268
[Discover] Close filter popup on click outside (#49934) 2019-11-11 13:11:15 +00:00
István Zoltán Szabó
4860c055e1
[DOCS] Fixes typo in ML related privileges. (#50142) 2019-11-11 07:44:37 -05:00
Søren Louv-Jansen
d86b6c7288
[APM] Add _debug=true to APM docs (#50093)
* [APM] Add `_debug=true` to APM docs

* Fix typo
2019-11-10 21:28:49 +01:00
Liza Katz
29aeec8ce1
Fix disco filters #2 (#50061)
* closes #44349, as well as SDH issue #64

* added tests to cover fix

* eslint

* Fixed test import
2019-11-10 22:25:02 +02:00
spalger
78e9d93268 skip flaky suite (#50079) (#50074) (#48709) (#50078) 2019-11-08 09:59:48 -05:00
Alexey Antonov
c3951e9374 Move @kbn/es-query into data plugin - filters folder (#49843)
Dismissing reviews from ml and canvas as this is only an import change. 


* Move @kbn/es-query into data plugin - filters folder

* fix PR comments
2019-11-07 22:02:49 -05:00
Tim Sullivan
4baf5d9751
[Dev Docs] Improve usage collection readme (#50098) 2019-11-07 21:57:28 -05:00
Andrew Cholakian
cd94184f86
[Uptime] Use EuiSelect instead of ComboBox for ping history (#49700)
Use EuiSelect instead of ComboBox for ping history

Resolves elastic/uptime#98
2019-11-07 18:24:38 -05:00
Tiago Costa
a014241a3c
fix(NA): correctly reference babel plugin into the node babel preset (#50090) 2019-11-07 17:25:00 -05:00
Chris Cowan
bca4e01cf3
[Metrics UI] Fixing Outbound Traffic metric for Inventory View (#49986) 2019-11-07 10:48:59 -08:00
Joe Reuter
349bc12f1e
Shim home app (#48715) 2019-11-07 11:56:19 -05:00
Spencer
0010447f0f
[a11y] add initial accessibility functional tests (#43584)
* [a11y] add initial accessibility functional tests

* add accessibility jobs

* fix config path

* remove percy setup from scripts

* disable color-contrast rule

* apply changes from @myasonik

* define aria-controls/owns props even when suggestions aren't visible

* [ftr/a11y] only throw error when there are errors

* adding tests for management page

* add a11y test for management page

* adding ignore rules' to a11y

* accessibility test for kibana home

* 7 passing tests, 0 failures

* jest snapshot update

* support a11y test in pipeline job

* update a11y test script for pipelines

* use oss compatible ci setup

* fix exclude syntax

* add default exclusion syntax
2019-11-07 10:07:40 -05:00
sainthkh
3f130ba27f Move legacy/server/index_patterns -> src/plugins/data/server (#46537)
Dismissed @elastic/kibana-app review of import changes.

ts-ignored @ts-ignore

* Moved files to plugins/data/server.

* Renamed IndexPatternsService to IndexPatternsFetcher and created new IndexPatternsService

* Set routerPath.

* Fixed type error.

* Changed beats_management _fields_for_wildcard request with data/public/legacy api.

* Fixed changed paths.

* Fixes crashes after merge.

* Updated path for clarity.

* Applied Plugin interface to service.

* Fixed test failure caused by non camel case local variable name.

* Fixed import to IndexPatternsService to IndexPatternsFetcher.
2019-11-06 18:29:11 -05:00
Phillip Burch
7cfcc4dfce
Make sure that filter query bar can be set to null (#50070) 2019-11-06 16:17:26 -06:00
Steph Milovic
12391da1e7
[SIEM] HTTP Requests table (#49955) 2019-11-06 13:55:52 -07:00
Dmitry Lemeshko
4a696b939a
update chromedriver dependency to v78 (#49737) 2019-11-06 15:13:22 -05:00
Liza Katz
3d2b1203e4
Remove unneded ui/documentation_links import (#49886) 2019-11-06 13:49:01 -05:00
Brandon Kobel
c4d1430372
Revert "No response compression when there is a referer (#47751)" (#49987)
This reverts commit 85e5885ccf.
2019-11-06 10:11:42 -08:00
Gidi Meir Morris
c485893ab2
Improves performance of task execution in Task manager
This PR include three key changes:

1. Run tasks as soon as they have been marked as running, rather than wait for the whole batch to me marked
2. Use a custom refresh setting of refresh: false where possible, in place of wait_for, in order to speed up Task Manager's internal workflow
3. Instrumentation of Task Manager exposing Activity / Inactivity metrics in Performance test runs
2019-11-06 08:44:13 -05:00
Maryia Lapata
17383b82f3
[Vis Editor] Fix issue with parent pipeline agg (#48756)
* Add error when there is no histogram agg when using parent pipeline

* Update error message

* Update message

* Get rid of let
2019-11-06 09:54:34 +03:00
dave.snider@gmail.com
f8ef2c6a34
remove pound symbol from saved queries (#50038) 2019-11-05 18:59:08 -08:00
Patrick Mueller
5ba237a885
[Telemetry] Remind users about telemetry on each minor version (#49644)
resolves #49519

If a user has previously opted out of telemetry, this PR will
cause them to be prompted again, when the major or minor version
of Kibana changes. Previously, once opted out, they would never
get prompted again.
2019-11-04 23:28:54 -05:00
Chris Roberson
f48497b6d1
[Monitoring] Ensure cloud cannot see setup mode (#49223)
* Ensure cloud cannot see setup mode

* Remove cloud check from collection status, as it's an injected var now

* Man these tests suck
2019-11-04 11:22:31 -05:00
Joe Reuter
6cd624f25a
[Graph] Switch to core http (#49487) 2019-11-04 12:57:21 +01:00
spalger
601800c9aa disable failing suite (#50005) 2019-11-03 02:16:30 -07:00
dave.snider@gmail.com
807103cce5
Improve dashboard filters display to use color as well as text for negated filters (#49939)
* Better key out negative filters

* fragments not spans

* Alter filter bar colors

- Red border for excluded
- Match pinned color to border color

* Fix title by using `useInnerText`

* Fix alignment of add filter button

* Moving SASS variables to its own file
2019-11-01 23:13:46 -07:00
Caroline Horn
49aa62ecfc
Add specificity to EuiComboBox focus ring hack (#49981) 2019-11-01 18:49:09 -04:00
renovate[bot]
73ebd567ad Update dependency rxjs to ^6.5.3 (#49837)
* Update dependency rxjs to ^6.5.3

* move argument type def up for better coverage

* adapt to possibly undefined helpExtension

* complete definition of deprecation$ type

* define types that bindNodeCallback can no longer infer

* define more types that bindNodeCallback can't infer

* be more explicit and accurate about the types for a subject/observable pair

* fix interface error, TS now identifies it

* ignore a return type flaw because types are not being managed properly

* avoid overspecifying types

* allow types to be inferred where possible

* remove unnecessary withLatestFrom()

* reduce number of rxjs versions installed

* update kbn/pm dist
2019-11-01 14:44:21 -07:00
Aleh Zasypkin
203ef5577c
Migrate Encrypted Saved Objects plugin to the new platform. (#49890) 2019-11-01 22:32:12 +01:00
Chris Davies
d10b7a1efb
Fix Lens auto date bug (#49967) 2019-11-01 15:46:45 -04:00
Larry Gregory
45617f0bbe
Adding NP spaces plugin to CODEOWNERS (#49963) 2019-11-01 15:37:38 -04:00
Mike Côté
2b6bd2f01e
Return referenced by count with each action on the find API (#49104)
* Initial work

* .kibana index configurable, NP ready implementation

* Fix broken jest tests

* Fix broken functional tests

* Add functional test

* Cleanup actions_client.test.ts
2019-11-01 15:15:54 -04:00
Mike Côté
bfdf61714e
Add ability to name alerts (#49035)
* Ability to name alerts

* Fix RawAlert TypeScript interface

* Update docs
2019-11-01 13:35:17 -04:00
Melissa Alvarez
568b8d3992
[ML] DF Analytics Regression results: Ensure error handling and table sort works correctly (#49929)
* add error handling for regression jobConfig fetch

* fix sorting change causing blank table by removing table render timeout

* Add label to table for number of docs obtained

* parameterize searchSize in documents fetched text
2019-11-01 12:12:01 -04:00
Gidi Meir Morris
128948c2a7
[task-manager] Improves messaging on errors due to inline scripts being disabled (#49860)
This PR detects when claiming tasks fails due to inline scripts being disabled in Elasticsearch and improves the message reported in the Kibana log.
2019-11-01 15:30:04 +00:00
Justin Kambic
f479f1e925
Add assertCloseTo calls to prevent off-by-one errors in unit tests for backend adapter. (#49928) 2019-11-01 11:02:54 -04:00
renovate[bot]
491ecf5865 Update dependency @elastic/charts to ^13.5.12 (#49874) 2019-11-01 09:45:23 -05:00
Aaron Caldwell
cf03665b98
[File upload] Switch to index pattern service shim (#49893)
* Switch to index pattern service shim

* Fix test breaking due to unrelated import in same file

* Move mock and require out of before call to top of file since they're not directly test-related

* Some minor cleanup

* One more thing...
2019-11-01 07:47:13 -06:00
Maryia Lapata
dbc9a52fd8
[Visualize] Centralize dependencies in kibana_services.ts (#49293)
* Centralize dependencies for Visualize  plugin

* Centralizing dependencies in editor and embeddable

* Remove unused deps, move imports

* Fix dangerouslyGetActiveInjector

* Move loading directive to kibana_services.ts

* Fix exceptions

* Get rid of injectI18n; fix chrome method invocation

* Update unit tests

* Fix TS

* Move data and Embeddable import

* Import VISUALIZE_EMBEDDABLE_TYPE directly

* Fix deps
2019-11-01 11:24:31 +03:00