* Clear flash messages when saving Settings
Previously when making changes to the UI in Settings, the error messages would persist. This PR removes the flash messages when any API requests are made.
* Also reset when staging/removing images
* [ILM] Fixed policy request flyout requiring policy name to show json
* [ILM] Fixed policy name in the request flyout for a new policy
* [ILM] Renamed saveAsNew to isClonedPolicy
* Fixed i18n errors
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* es-query types
* jest and lint
* cc
* options
* type
* types for kuery FUNCTIONS
* doc
* sec fixes
* typey type
* test typescript
* test
* fixes
* test
* cr
* cleanup a bit more
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Lens] Fixes flakiness in editing pre-existing runtime field
* Field editor changes
* Unskip test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Converted Grok debugger tests to use standard functional test runner practices.
* Fixed last test.
* Removed old test now that the new test is passing.
* Fixed condition for retry.
* Removed .only to restore test run.
* fixed errors
* Fixed nits.
* Adding telemetry usage counter for create rule API when predefined ID is specified
* Checking explicitly for default space id
* Handling undefined space id when spaces is disabled
* Consolidating logic in single function
* Tracking total usage and custom usage
* searchsource should send all index patterns defined on the runtime field
* fix jest test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* balance solutions
* clean up solution changes
* change footer button size
* update management section
* apply max-width to management items
* remove right side items from page header
* add data content update
* illustration poc
* add data content updates per feedback
* img size and alignment
* moved shared images to shared assets folder
* more solutions clean up
* rm unneeded import
* remove references to subtitle and appDescriptions
* update tests and snapshots
* more test and snapshot updates
* restore solution sort order
* ts and jest fixes; thx catherine!
* i18n fixes
* use new `KibanaPageTemplateSolutionNavAvatar` comp
* change solution imgs from png to svg
* update tests and snapshots
* rm spacer and update snapshots
* account for flex margin changes in img offset
* Change "Kibana" overview page text to "Analytics"
* update overview icon to match hp changes
* update snapshots
* center justify solutions and update snapshots
* update snapshots
* title case dev tools and stack management
* update text and snapshots
* fix merge error
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* switch dfa create, runtime, and expanded row json editor to new codeEditor
* add aria label. wrap codeEditor in div to allow data attribute for test
* update functional test service for new code editor
* Remove TODOs
Removes 2 todos:
- in index.tsx, the access is handled somewhere else and visiting any org page as a non-admin results in an error message. No further action needed
- error_state.tsx - this had been completed by Constance in a separate PR but the comment was missed.
* Remove a bunch of unused components
These were left over from the user migration project and mainly have to do with users displayed in the groups section, which is no longer a feature.
* This commit needs no explanition
This was missed in this commit:
19ccd27e04
Refacotred and somehow renaming resulted in this monstrosity 🤦🏼♂️
* Remove source descriptions
Since this commit, these are no longer displayed in the UI
16d089acfd (diff-a4761afc86544a299d0129b749e3001625f5b194b95ebc31303824f8f95f4381L173)
* Set up tsconfigs
- Required if we're going to have several different Cypress suites (one for each plugin/product essentially) in order for global cy.() commands and it()/describe() to register as expected
@see https://docs.cypress.io/guides/tooling/typescript-support#Clashing-types-with-Jest
* Set up shared commands and routes
NOTE: Unlike ent-search, shared/ will *not* have its own set of tests - rather, shared/cypress is a resource/set of helpers for other test suites to extend/import/etc.
* Create basic Enterprise Search Overview E2E tests
- For happy path testing, we _likely_ shouldn't need more than these tests going forward
- If we ever want to add an error connecting test however, this is likely where it should go (or alternatively, use Kibana's FTR with Enterprise Search host set but not spun up)
* Set up App Search Cypress test scaffolding
- placeholder/hello world test only
* Set up Workplace Search Cypress test scaffolding
- placeholder/hello world test only
* Add helper script and update README
* Add config setup & documentation for potentially running Cypress against Kibana functional server
* PR feedback: Fix typescript project names
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Use empty state page template
* Remove unused translations
* Fixed snaps
* Use docLinks service
* Fix test
* Revert "Use docLinks service"
Use exisiting docLinks.ELASTIC_WEBSITE_URL instead
* Update learn more link and test
* fix test
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* provide execution context information for task.run and alert.execute
* log default space
* expose setRequestId to plugins for cases when a runtime scope exists outside of requestHandler
* fix typescript errors in jest test files
Unfortunately, some of the tests are still failing. Not quite sure what's
going on, but it looks like the calls to `withContext()` are not returning
the result of the function passed in, but only in the tests. Because the
code seems to run fine when I run Kibana - but perhaps we're just lucky
and don't need the results the tests are looking for, for my simple
smoke tests. But seems unlikely to me - guessing the mock is not being
set up correctly, or there's some weird interaction with jest mocks
and async hooks.
* fix alerting unit tests
* add tests that withContext is called even when exection_context service is disabled
* update docs
* add fakerequestid registration
* do not attach request id when undefined (FakeRequest, for example)
* Revert "add fakerequestid registration"
This reverts commit ca5a396dcc.
* not to expose setRequestId for time being
* cleanup alerting code
* update docs
* add a unit test for alerting execution context
* add a test for execution context of task runner
* improve description readability
* update type definitons
* fall back to unknownId if no requestId is provided
Co-authored-by: Patrick Mueller <pmuellr@gmail.com>
The socket timeout for testing whether the status page is available or
not is currently 30 seconds. This test was disabled for being flaky.
Reproducing this locally hasn't been straight forward, but I am seeing
an average of ~20 seconds, which is close enough to the timeout that I'd
like to rule out machine differences. This gives the status check 120
seconds before dropping the connection.
Related to #106749 and #107300
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Fixes agnostic type bug where in part 1 (#108225), I incorrectly used the same saved object type for both `single` and `agnostic`.
Before the references for SO's were:
```json
"references" : [
{
"name" : "param:exceptionsList_0",
"id" : "endpoint_list",
"type" : "exception-list" <--- This should have been "exception-list-agnostic" type
},
{
"name" : "param:exceptionsList_1",
"id" : "50e3bd70-ef1b-11eb-ad71-7de7959be71c",
"type" : "exception-list"
}
],
```
After:
```json
"references" : [
{
"name" : "param:exceptionsList_0",
"id" : "endpoint_list",
"type" : "exception-list-agnostic" <--- This should now be the "exception-list-agnostic" type
},
{
"name" : "param:exceptionsList_1",
"id" : "50e3bd70-ef1b-11eb-ad71-7de7959be71c",
"type" : "exception-list"
}
],
```
Manual testing: Add a new `security_solution` alert and exception list as well as an endpoint list to it. Then save it
<img width="1581" alt="Screen Shot 2021-08-13 at 5 00 39 PM" src="https://user-images.githubusercontent.com/1151048/129425847-78025aba-6d7a-4a5a-9d4f-950ec664596c.png">
<img width="1571" alt="Screen Shot 2021-08-13 at 5 00 47 PM" src="https://user-images.githubusercontent.com/1151048/129425848-42018331-cac6-4411-8153-3441a8af6f34.png">
Do this query in dev tools:
```json
GET .kibana-hassanabad19/_search
{
"query": {
"terms": {
"alert.alertTypeId": [
"siem.signals"
]
}
},
"size": 10000
}
```
And check to ensure that the references look like the after picture where type has : `"type" : "exception-list-agnostic"` if we have an agnostic list. Ensure that on a page reload that the exception types are still there on the rule. Ensure that there are no errors in the console about not finding the correct SO type or anything else odd.
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios