This PR adds two components to aid in creating a uniform UI for specifying the conditions for Action Groups:
1. `AlertConditions`: A component that generates a container which renders custom component for each Action Group which has had its _conditions_ specified.
2. `AlertConditionsGroup`: A component that provides a unified container for the Action Group with its name and a button for resetting its condition.
This can be used by any Alert Type to easily create the UI for adding action groups with whichever UI is specific to their component.
* fix ilm policy deserialization
* reorder expected jest object to match actual
* fix removal of wait for snapshot if it is not on the form
* add client integration test for policy serialization of unknown fields
* save on a few chars
* added unit test for deserializer and serializer
* Implement feedback
- move serializer function around a little bit
- move serialize migrate and allocate function out of serializer
file
* Updated serialization unit test coverage
- removed the "forcemergeEnabled" meta field that was not being
used
- added test cases for deleting of values from policies
* fixed minor issue in how serialization tests are being set up
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
resolves https://github.com/elastic/kibana/issues/55634
resolves https://github.com/elastic/kibana/issues/65746
Buffers event docs being written for a fixed interval / buffer size,
and indexes those docs via a bulk ES call.
Also now flushing those buffers at plugin stop() time, which
we couldn't do before with the single index calls, which were
run via `setImmediate()`.
* Initial copy/paste of components
Changes for pre-commit hooks were:
- Linting
- Lodash imports
- remove `any` type in favor of React.ReactNode
- Move setState to top of component
* Add image
* Update component paths
* Remove reference to ConfirmModal
Since all the legacy component does it wrap the EUI component we decided to drop it.
Legacy:
https://github.com/elastic/ent-search/blob/master/app/javascript/shared/components/ConfirmModal/ConfirmModal.tsx
* Remove local flash messages in favor of global flash messages
* Various type fixes
* Fix image location
* shell scripts for creating roles + users for testing
* update readme's and updated privilege requirements based on testing with the users and inferring what the roles are supposed to do
* update role privileges based on feedback meeting yesterday
* updated scripts to accept filepath to role / user, added a test to ensure upload value list button is disabled
* updated role scripts to be parameterized
* adds login with role function and adds a sample test with a role to test that a t1 analyst user cannot upload a value list
* add object with corresponding roles
* fix spacing
* parameterize urls for basic auth with roles + users
* forgot to change the cy.visit string
* add KIBANA_URL env var for cli runner
* add env vars for curl script execution
* second script
* update readme's for each role and remove create_index from lists privilege for the soc manager role
* remove 'manage' cluster privilege for rule author
* remove 'create_index' privilege from soc_manager role since that is not parity with the security workflows spreadsheet
* update the login function logic with glo's feedback
* replace SIEM with Security Solution in markdown files
* make role param optional not just undefined
* remove unused file
* add copyright to scripts files
* update top-level README for roles scripts
* remove reference to internal spreadsheet and reference readme for this pr
* remove unnecessary -XPOST and remove verbose mode from post_detections_user script
* adds utils for running integration tests with other users and adds two sample tests showing example usage
* minor type updates and small refactor
* fix x-pack/test types
* use enum types instead of custom type
* fix path to json
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
* Adding alert.updatedAt field that only updates on user edit
* Updating unit tests
* Functional tests
* Updating alert attributes excluded from AAD
* Fixing test
* PR comments
* Unskipping tests and updating es archiver data
* Initial copy/paste of components
Changes for pre-commit hooks were:
- Linting
- Lodash imports
- changed enum names in add_source because there were collistions with component names. So SaveConfig becomes SaveConfigStep because there is a component by the same name
- replaced apostrophe’s with ‘'’ per lint rule
Finally, the linter didn’t like this expression:
asOauthRedirect ? onOauthFormSubmit() : onCredentialsFormSubmit();
… so I changed it to:
const onSubmit = hasOauthRedirect
? onOauthFormSubmit
: onCredentialsFormSubmit;
onSubmit();
* Add route helper
* Remove AppView, Sidebar navigation and FlashMessages
Sidebar copy and breadcrumbs will be recreated at the top level in a separate PR
* Update component paths
* Use Kibana’s hasPlatinumLicense over minimumPlatinumLicense
* Various TypeScript lint fixes
* Fix index paths
* Remove in-page breadcrumbs and move sidebar copy
In Kibana, breadcrumbs will be at the top-level and not in the view
Also, we have no sidebar with contextual copy. The Figma designs call for this copy to be above the main content. For now I am placing this in the existing ViewContentHeader component.
This will be slightly broken because of the structure of ViewContentHeader but that is expected for now since it cannot be rendered in the browser yet to fix
* Temporarily add parseQueryParams
This is a placeholder until https://github.com/elastic/kibana/pull/83750 lands
* Remove optional from isOrganization
Looks like the value is always passed
* Remove ‘!!’
* [Enterprise Search] Add parseQueryParams helper
This PR migrates part of the ent-search queryParams util, `parseQueryParams` for use in Workplace Search.
`setQueryParams` was no a part of this PR because it is only used one time in App Search and a better alternative might be available for that use-case
* Remove mock
* Actually test functionality of query-string
* Add test for array
* Better test name
* Removing circular dependency between spaces and security
* Apply suggestions from code review
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
* Tests refactor
- Reorganize top level describes into 3 space-based blocks into based on spaces:
- space disabled
- spaces plugin unavailable
- space enabled (most previous tests go under this new block) with new beforeEach
- wrote new tests for uncovered lines 58, 66-69
* Review1: address PR feedback
* changing fake requests for alerts/actions
* Fixing tests
* fixing more tests
* Additional testing and refactoring
* Apply suggestions from code review
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
* Review 2: Address feedback
* Make ESLint happy again
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Constance Chen <constance.chen.3@gmail.com>
resolves: https://github.com/elastic/kibana/issues/67389
Adds new variables to the existing set of variables that can be used in mustache templates to be used in action parameters when creating alerts.
- `alertActionGroup` - the action group associated with the alert scheduling actions
- `date` - the current date, in ISO format
* Set up Overview file
* Finish Overview page logic, stub out empty/metric views
* Stub in basic empty engine overview
- Minus document creation button & API code example
* Stub out EngineOverviewMetrics and unavailable empty prompt
* Stub out EngineOverMetrics components (stats, charts, logs)
* [Refactor] Pull out some document creation i18n strings to constants
- They're repeated/reused by the DocumentCreationPopover component
* PR feedback: Drop the regex
* PR feedback: RecentLogs -> RecentApiLogs
* PR feedback: Copy
* PR feedback: Copy, sentence-casing
* I forgot to rebase against my own PR :dead_inside:
* [ML] Space management UI
* fixing types
* small react refactor
* adding repair toasts
* text and style changes
* handling spaces being disabled
* correcting initalizing endpoint response
* text updates
* text updates
* fixing spaces manager use when spaces is disabled
* more text updates
* switching to delete saved object first rather than overwrite
* filtering non ml spaces
* renaming file
* fixing types
* updating list style
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This addresses a bug in Task Manager in the task timeout behaviour. When a recurring task's `retryAt` field is set (which happens at task run), it is currently scheduled to the task definition's `timeout` value, but the original intention was for these tasks to retry on their next scheduled run (originally identified as part of https://github.com/elastic/kibana/issues/39349).
In this PR we ensure recurring task retries are scheduled according to their recurring schedule, rather than the default `timeout` of the task type.
