This is a first step in attempting to address the over zealous shifting we've identified in TM.
It [turns out](https://github.com/elastic/elasticsearch/issues/63671) `version_conflicts` don't always count against `max_docs`, so in this PR we correct the `version_conflicts` returned by updateByQuery in TaskManager to only count the conflicts that _may_ have counted against `max_docs`.
This correction isn't necessarily accurate, but it will ensure we don't shift if we are in fact managing to claim tasks.
* [TSVB] get rid of vis_type_timeseries_enhanced
* add search strategy should be called from setup hook
* remove vis_type_timeseries_enhanced from CODEOWNERS
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Maps] migrate maps, maps_file_upload, and maps_legacy_licensing to TS projects
* include types to avoid rison import errors
* add mappings to tsconfig include
After observing the conditions when this test fails, it appears that
some (but not all) signals are available. As these signals are generated by a
rule via a bulk create, the odds of us retrieving signals in the middle
of that bulk creation is very slim (but not impossible).
The crux of the error here was: we wait for signals to be generated, but
not the ones that we need. Specifically, we are waiting for a single
signal to be available, but since we are asserting on sequences of
signals, we need several to be available to us.
While not perfect (because the signals we receive are not technically
guaranteed to be sequence signals), increasing the number of signals
that we wait for before proceeding should be sufficient to prevent this
failure state. In debugging, it was observed that every test returning
9-10 signals succeeded, while it was possible for the test to return
only one signal and fail.
* [Alerts][Actions][Telemetry] Fix mappings for Kibana actions and alert types telemetry.
* fixed count_active_by_type for actions
* fixed tests
* Fixed due to comments.
* Fixed due to comments.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Phases redesign
* Title and name field layout
* Active highlight wip
* Copy comments
* Updated data allocation dropdown
* Min age error message
* Fixed tests
* Fixed edit policy integration tests
* Fixed more tests
* Cleaned up test files
* Use hotProperty instead of a string
* Clean up in phase component
* Fixed i18n files
* Updated optional fields
* Updated aria attributes after running axe tests
* Added review suggestions
* Reversed data allocation field changes
* Fixed type error
* Reversed on/off label and prepend input label
* Deleted property consts from phases components
* Removed not needed i18n consts and added i18n where missing
* Fixed merge conflicts with master
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* change from type:gauge to type:top_n in inventory models
* Add test for hostSystemOverview metric
* fix lint errors
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Enable v2 so migrations, disable in FTR tests
* Disable v2 migrations for ui_settings integration tests
* Disable v2 migrations for reporting without serucity api integration test
* Cleanup OSS code from visualizations wizard
* Remove unecessary translations
* Remove unused translation
* Fix functional test
* Disable the functional test for OSS
* Remove from oss correctly :D
* Fix ci
* cleaning up unused types and legacy logic
* added new relative age logic with unit tests
* initial implementation of timeline
* added custom infinity icon to timeline component
* added comment
* move timeline color bar comment
* fix nanoseconds and microsecnds bug
* added policy timeline heading, removed "at least" copy for now
* a few minor changes
- fix up copy
- fix up responsive/mobile first view of timeline
- adjust minimum size of a color bar
* minor refactor to css classnames and make trash can for delete more prominent
* added delete icon tooltip with rough first copy
* added smoke test for timeline and how it interacts with different policy states
* update test and copy
* convert string svg to react svg component and use euiIcon class and refactor scss
* update delete icon tooltip copy and add aria-label to svg
* mock EuiIcon component in jest tests because it causes issues with custom react-svg component
* added comment to mock
* remove setting of classname
* fix typo and update delete icon tooltip content
* refinements to the delete icon at the end of the timline and support dark mode
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* fixes https://github.com/elastic/kibana/issues/74449
* watcher test with specific permissions
* adding the false parameter
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add index route for personal dashboard
* Fix links to personal source flow
In ent-search, the base route was /sources so the getSourcesPath helper was not needed. In Kibana, we use the ‘/p’ route to differentiate personal from org so the helper is needed and we pass false as the isOrganization flag
* Remove legacy sidebar text
When I first migrated this, I left the sidebar copy in so that it was not aboandoned before the design pass. After talking with John we decided to just use the copy to the right of the sidebar so this drops that legacy copy.
* Remove constants
* Remove legacy sidebar link
* Revert "Remove legacy sidebar text"
This reverts commit 8c8a3fb63c.
* Revert "Remove constants"
This reverts commit a88723ec90.
* Revert "Remove legacy sidebar link"
This reverts commit 5d08a12a7d.
* Update TODO
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* 🚀 Load indexPatternRefs only on edit mode
* :white_mark_check: Fix test with new editor init flag
* 🐛 Avoid to save to localStorage undefined indexPattern
* :white_mark_check: Adapted tests to new conditional ref loading
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* bump babel version
* build kbn-pm
* fix integration test
* remove cicular dependency between files which crashes Kibana in rutime
Co-authored-by: spalger <spalger@users.noreply.github.com>
* [ML] fix swim lane selected times with only start boundaries
* [ML] unit test
* [ML] update url variables
* [ML] selectedLanes to an array type
* [ML] handle legacy query params
* Move shared data to mock
* Change name of mock
Everywhere else we don’t use the “mock” prefix for mocked data so I’m changing here to match.
Also added missing “size” prop from mock.
* Remove unused actions
These were missed on the migration to the new add_source_logic file. All of that logic lives there now
* Add tests for source logic
* REmove resetFlashMessages
This is no longer used as Kibana resets its own. This was removed from the component already.
* Export items for use in tests
* Remove unnecessary condition
It’s literally not possible for this function to receive an empty contentSources parameter. Not sure why this was added. Even if the server sends response with no privateContentSources, the reducer falls back to an empty array.
* Add tests for sources logic
* Fix typo
* only check privileges if index param is not empty
* fix jest test i added in previous commit, fixes bug where timestamp field was printed twice in partial failure message
* adds two unit tests to check the error messages written from hasTimestampFields util function
* add refresh button to alerts list
* add refresh button to Alerts Details Page
* fix: add EuiFlexItem tag
* add tests for refresh button in alerts_list and alert_details
* fix: add test for requestRefresh and loadAlerts
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
resolves https://github.com/elastic/kibana/issues/68575
The index threshold alert defines an `index` parameter which is
typed as `string | string[]`. However the UI for this alert has
been typing it as only `string[]`.
This PR changes the UI to work with an incoming string value for
this parameter. If the parameter is edited in the UI, it will always
be set as an array, even if there is only one element.
* Bump EUI to v31.3.0
* jest snapshot updates
* Fixed space issue in kbnQueryBar date picker
* Removed unecessary space in query bar scss
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Create reusable AnalyticsCards component
* Update EngineOverview to use new AnalyticsCards component
* Update Analytics overview with AnalyticsCards + data
* Update QueryDetail with AnalyticsCards + data
* Update Analytics overview with AnalyticsChart + data
- turns out we do need startDate after all for charts, so I added it back to types
* Update QueryDetail with AnalyticsChart + data
* [Polish] Dash click and no result lines to match standalone UI
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add getListeners to Kea test helpers
* Update TelemetryLogic to use new getListeners helper
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Maps] fix users without access to Maps should not have the option to create them
* fix test message
* wrap add geo field trigger in show capabilities check
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Remove history params
We already replace the history.push functionality with KibanaLogic.values.navigateToUrl but the history object was still being passed around.
* Add org sources container tests
* Add tests for source router
* Clean up leftover history imports
* Add tests for SourcesRouter
* Quick refactor for cleaner existence check
Optional chaining FTW
* Refactor to simplify setInterval logic
This commit does a refactor to move the logic for polling for status to the logic file. In doing this I realized that we were intializing sources in the SourcesView, when we are actually already initializing sources in the components that use this, which are OrganizationSources and PrivateSources, the top-level containers.
Because of this, I was able to remove the useEffect entireley, as the flash messages are cleared between page transitions in Kibana and the initialization of the sources ahppens in the containers.
* Add tests for SourcesView
* Fix type issue
* [Feedback] Move generateEnginePath to its own standalone helper
- instead of living inside EngineLogic.values
- I forgot Kea lets us do this now!
* Update all components using generateEngineRouter to import helper directly
* Add a generatePath engineName helper to EngineLogic
* Create mockEngineValues reusable mock
* Update routes + EngineNav & EngineRouter to include ENGINE_PATH in all urls
- routes: remove get*Route fns in here as all routes should prefer to use generatePath from EngineLogic moving forward
- EngineRouter - add missing canViewEngineDocuments checks
- Engine tests - import base mock values + update tests to point directly at files to work around the auto mock
* Update AnalyticsRouter to use new routes+generatePath
* Update DocumentDetailLogic to use new generatePath
+ Misc cleanup:
- organize imports by shared > AS specific > docs specific
- move delete-specific const's to directly before they're used, since they're only used in one place
- deconstruct KibanaLogic.values
* Update all components using getEngineRoute to use new generatePath
+ misc import order cleanup - prefer shared > specific groupings
* [PR feedback] Change components that override the engineName param to just use default generatePath
* [PR feedback] Rename instances of EngineLogic's generatePath to generateEnginePath
* Add full source mocks
The overview page recieves heavily annotated source data for display. This extends the existing mocks
* Refactor for easier readability
Uses optional chaining. Hide whitespace changes for easier reviewing of this commit
* Remove conditionals
The false case will never be true here because the line above only renders when there is a summary. Around line 109:
```
{!!summary &&
```
* Refactor GroupsSummary to variable
It was challenging to test the null in the original implementation so I refactored to cloer match the way we do this in other places by making the conditional rendering inline, rather than `null` in a function.
* Remove unused const
* Add overview test-subj attrs
* Add overview unit tests
* Add tests for SourceAdded
* Move meta to shared mock
* Add tests for SourceContent
* Add tests for SourceInfoCard
* Move redirect logic from component to logic file
We had this weird callback passing to trigger a redirect and we are already redirecting in the logic file for other things so I simplified this to have the logic file do the redirecting and not have to pass the callback around, which is hard to test and unnecessary complexity.
Also using the KibanaLogic navigateToUrl instead of history.push
# Conflicts:
# x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/source_logic.ts
* Add tests for SourceSettings
* Add tests for SourceSubNav
* I am the typo king
🤴🏼Prove me wrong.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
