I'd really like to upgrade to Typescript 3 for its `unknown` type, but we need to upgrade to `jest@23` to support a recent version of `ts-jest@23`.
The [jest changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) breaks down the breaking changes in 23.x, but I found it to be slightly incomplete so I've broken down the changes that actually caused breaks for us here, and addressed each in individual commits to make review a little easier:
- the `testURL` config default was changed from `about:blank` to `http://localhost`
- this cause some XHR requests powered by JSdom to start failing. It seems these requests just do nothing in master but start to fail when JSdom is initialized with an actual URL... I think we would ideally stop sending meaningless XHR requests in the tests, but it was a lot easier to just set the config to `about:blank` for now, and we can worry about cleanup later if necessary
- `expect(...).toThrow()` only passes if an actual error was thrown.
- In two places in the index pattern code we were throwing strings, which broke the assertions. Fortunately/Unfortunately the errors are not being consumed by anything, so I was able to wrap them in `new Error()` without causing any issues.
- snapshots of mock functions now include a `results` array, detailing the return values of the function
- React fragments are now serialized as `<React.Fragment>` instead of `<UNDEFINED>`
- undefined props in React components are now stripped from snapshots
- minor changes to the ordering of mocks, imports resolution, and before hooks caused the uiSettings API tests to start breaking, but I'm replacing them with totally new tests in #22694 so I just deleted them here
- mocks created with `jest.spyOn()` that are restored now have their `mock.calls` reset, so some of the kbn-pm tests stated failing. This was fixed by restoring them with `jest.restoreAllMocks()` rather than trying to do it before the assertions
* lint for innerHTML and family
Browser apis like innerHTML and document.write are dangerous when used
incorrectly, so we should not be using them unless we explicitly opt-out
of the linting rule on a case by case basis.
* add no-unsanitized to eslint peerDependencies
* Build packages before running ESLint on CI
* Add production task to kbn-build
* Ensure packages are bootstrapped before running the build
* Run ESLint on kbn-build
* [eslint] upgrade to 4.10.0
* [eslint-config-kibana] limit jest config to jest test files
* [ui_framework] remove trailing comma from rest-spreads
* [dashboard/tests] tag jest helpers with .test.js suffix
* explicitly import expect.js where used
* [eslint] apply auto-fixes
* [eslint] manually add/wrap some parens for compliance
* [npm] point to local packages for testing/review
* [jest] remove .test extension from jest helpers
* [ui_framework] fix trailing comma removal from 3bc661a1c8
* [packages] upgrade eslint packages
* Initial commit
* added actual config
* version 0.0.1
* version 0.0.2
* [no-const-assign] Disallow assignment to const
http://eslint.org/docs/rules/no-const-assign
* [no-redeclare] Disallow redeclaring variables
http://eslint.org/docs/rules/no-redeclare
* version 0.0.3
* [no-unused-vars]: Disallow declaration of variables that are not used in the code.
* Bump to 0.1.0.
* upgrade deps in preperation for babel6 transition
* 0.2.0-alpha1
* use yaml for readability
* 0.2.0
* update/pin peed dependency versions
* 0.2.1
* [quotes] allow template literals
This allows eslint to validate this rule from the styleguide: https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#use-template-strings-to-avoid-escaping-single-quotes
* 0.2.2
* add object-curly-spacing and no-global-assign rules
* sort .eslintrc.yaml rules
* 0.3.0
* add basic react support
* 0.4.0
* Disallow using 'context' in tests
* 0.5.0
* move from .eslintrc.yaml to .eslintrc.js without .json generation (#6)
* Implement import plugin (#7)
* update deps
* include eslint-plugin-import
* Dereference import config (#8)
* reorganize existing rules into groups
* defreference eslint-plugin-import "recommended" config
Based on ea9c92c732/config/recommended.js
* 0.6.0
* set environment info for import rule
* 0.6.1
* update peerDependencies
* 0.7.0
* Move eslint-config-kibana into packages directory
