Commit graph

18 commits

Author SHA1 Message Date
Spencer
f5ca67dc41
[6.x] [yarn] Upgrade to 1.10.1 (#23971) (#24054)
Backports the following commits to 6.x:
 - [yarn] Upgrade to 1.10.1  (#23971)
2018-10-15 18:20:26 -07:00
Josh Dover
5794396834
Fix plugin generator when using hacks and SCSS [ci skip] (#23579) (#23580) 2018-09-27 12:10:06 -05:00
Aleh Zasypkin
fd70b4faf3
Upgrade eslint/tslint/prettier plugin versions. (#23562) 2018-09-27 14:17:45 +02:00
pavel06081991
4c331b1348
Update versions of @babel/parser and @babel/types (#23268) (#23469)
Update versions of @babel/parser, @babel/types, eslint, babel-eslint
2018-09-25 16:18:05 +03:00
Tyler Smalley
b93b868b0f
Moves styleSheetPath to uiExports (#23007) (#23385)
This was previously defined in uiExports.app, which limited plugins which are not an app of providing a stylesheet. This allows any plugin to define a stylesheet which will be available on page load.
2018-09-20 20:42:04 -07:00
Spencer
9a7fa9a938
Upgrade to Jest 23.5.0 (#22791) (#22846)
I'd really like to upgrade to Typescript 3 for its `unknown` type, but we need to upgrade to `jest@23` to support a recent version of `ts-jest@23`.

The [jest changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) breaks down the breaking changes in 23.x, but I found it to be slightly incomplete so I've broken down the changes that actually caused breaks for us here, and addressed each in individual commits to make review a little easier:

- the `testURL` config default was changed from `about:blank` to `http://localhost`
    - this cause some XHR requests powered by JSdom to start failing. It seems these requests just do nothing in master but start to fail when JSdom is initialized with an actual URL... I think we would ideally stop sending meaningless XHR requests in the tests, but it was a lot easier to just set the config to `about:blank` for now, and we can worry about cleanup later if necessary
- `expect(...).toThrow()` only passes if an actual error was thrown.
     - In two places in the index pattern code we were throwing strings, which broke the assertions. Fortunately/Unfortunately the errors are not being consumed by anything, so I was able to wrap them in `new Error()` without causing any issues.
- snapshots of mock functions now include a `results` array, detailing the return values of the function
- React fragments are now serialized as `<React.Fragment>` instead of `<UNDEFINED>`
- undefined props in React components are now stripped from snapshots
- minor changes to the ordering of mocks, imports resolution, and before hooks caused the uiSettings API tests to start breaking, but I'm replacing them with totally new tests in #22694 so I just deleted them here
- mocks created with `jest.spyOn()` that are restored now have their `mock.calls` reset, so some of the kbn-pm tests stated failing. This was fixed by restoring them with `jest.restoreAllMocks()` rather than trying to do it before the assertions
2018-09-07 20:30:49 -07:00
Stacey Gammon
2355bb10c3
Bump eui (#20774) (#20909)
* bump eui

* Fixed breaking `EuiPage` changes

Mainly adding `EuiPageBody`’s where there were none

* bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots

* bump eui

* bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots

* Update jest snapshots in xpack
2018-07-17 20:45:11 -04:00
Spencer
215c41c4dc
[6.x] [kbn-plugin-generator] Fix plugin naming inconsistency (#20808) (#20898)
Backports the following commits to 6.x:
 - [kbn-plugin-generator] Fix plugin naming inconsistency  (#20808)
2018-07-17 17:36:53 -07:00
Tiago Costa
3fab7f6aa7
chore(NA): bump chalk version dependencies and update lock files. (#20629) 2018-07-13 00:27:23 +01:00
Tim Roes
de3e5b5cb6
Increase prettier line width to 100 (#20535) (#20596)
* Increase prettier line width to 100

* Fix packages JS prettier

* Change style guide to 100 width

* Fix line-width in latest master changes
2018-07-11 00:41:00 +02:00
Marco Vettorello
8e69c0d79d
[kbn-plugin-generator] Fix eslint dependencies and template code linting (#20517) (#20612)
* Add missing peer dependency and upgraded to new import resolver kibana

* Fixed template code to follow eslint rules

* Fix lint script to lint all files in the generated dir

* More precise slurp :p
2018-07-10 15:56:49 +02:00
Tyler Smalley
a1b5a56f94
Adds SCSS support for plugins (#19643) (#20137)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-06-22 08:03:14 -07:00
Spencer
4f29b323bf
Backport/19383/6.x (#19487)
* [eslint][tslint] require Apache 2.0 license headers

(cherry picked from commit 337fea30b9)

* [kbn-eslint-plugin-license-header] don't try to fix files with hashbangs

(cherry picked from commit db79f1501e)

* [eslint][tslint] autofix license headers
2018-05-28 20:24:23 -07:00
Tyler Smalley
ffd2fe83e3
[kbn-es] Package for managing Elasticsearch during dev and testing (#17168) (#17273)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-03-21 17:48:49 -07:00
Bill McConaghy
f5ba3025bd
moving plugin template to React and EUI (#16937) (#17253)
* moving plugin template to React and EUI

* fixing method reference error

* adding whitespace and comments per PR feedback

* adjusting test

* fixing test

* reducing Angular dependency and fixing issue with hack not loading properly

* fixing tests

* reacting to PR feedback
2018-03-20 08:44:05 -04:00
Jonathan Budzenski
37fba36b69
[packages] add licenses (#17072) 2018-03-12 12:40:15 -05:00
Kim Joar Bekkelund
1339331692
Missing argument for generate_plugin script (#16782) (#16809) 2018-02-19 10:15:55 +01:00
Spencer
d141b33e12
[kbn-plugin-generator] add plugin generator to the repo (#16655) (#16686)
* [kbn-plugin-generator] add plugin generator to the repo

* [plugin-generator] use snake_case plugin name for directory name

* [plugin-generator] fix typo

* [plugin-generator] remove translation support until we resume i18n efforts

* [yarn] update lockfile

* [mocha] remove plugin-generator selector from mocha tests

* [plugin-generator] update generated readme to recommend yarn

* [plugin-generator] add readme to generator pacakge

* [plugin-generator] link from plugin-resource docs

* [plugin-generator] mention very important `kbn bootstrap` script

* [plugin-generator] rework some parts of the README

* [plugin-generator] log actual directory name with system separators

* [plugin-generator] include bootstrap/yarn preinstall check script
2018-02-12 17:46:46 -07:00