Commit graph

31673 commits

Author SHA1 Message Date
Jen Huang f168b6abb8
Add additional safeguards for data source wizard step 2 (#60426)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 15:26:29 -07:00
Spencer 32b3861580
[kbn/pm] don't fail when plugins are outside repo (#60164)
* [kbn/pm] don't fail when plugins are outside repo

* remove unused import

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 15:25:44 -07:00
Spencer 2367d749c1
upgrade react-use (#60427)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 15:24:59 -07:00
Karen Metts 631d93da50
Remove link to old settings (#60326) 2020-03-17 16:11:40 -04:00
Luke Elmers a8e33a87b5
Update app arch CODEOWNERS items. (#60396) 2020-03-17 13:27:10 -06:00
James Gowdy 9f31565b88
[ML] Fixing custom urls to dashboards (#60355)
* [ML] Fixing custom urls to dashboards

* missing file

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 19:25:01 +00:00
Nick Peihl 928454afa4
Update the ems-client dependency to 7.7.0 (#59936)
* Update the ems-client dependency

This PR adds the `appName` and `appVersion` parameters used by ems-client. The `appVersion` parameter replaces the now deprecated `kbnVersion` parameter in ems-client.

* Review feedback

* Fix borked merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 11:51:17 -07:00
Melissa Alvarez f875b7165e
do not update cell background if is label cell (#60308) 2020-03-17 13:41:46 -04:00
Rashmi Kulkarni 89f9260da2
FTR configurable test users (#52431)
* initial implementation of configurable test users

* user superuser by default to match master

* referenced the configs in reporting and api integration

* setting the minimum number of default roles

* looking for x-pack tests with users and roles

* add testUserService in dashboard mode tests

* running only ciGroup7

* uncommenting - addign visualization

* re-enabling all CI groups to run on CI

* reinstating Jenkinsfile

* disable Test user for OIDC config

* improved logging and added Roles for OSS tests to get better info on the runs.

* disable test_user for auth tests

* don't fetch enabledPlugins when testuser disabled

* fix es-lint

* running oss tests with x-pack enabled

* [revertme] build default dist for oss tests

* updating NOTICE.txt file as it complained in the kibana intake tests

* changed to pick OSS builds

* trying a license change to trial

* switch back to xpack builds

* created a new sample data role and used it in homepage tests

* revert test/scripts/jenkins_ci_group.sh

* only refresh browser and wait for chrome if we are already on Kibana page

* fix large_string test to use minimum set of roles and privileges

* fix for date nanos custom timestamp with a configured role

* changes to the files with addition of new roles for the test_user

* reverting to OSS changes and few additions to the time_zone test to run as a test_user

* changes to security

* changes to the x-pack test to use elastic superuser

* fix for chart_types test

* fixes to area chart , input control test

* fix for dashboard filtering test and a new config role

* changes to handle the x-pack tests

* additional role for date nanos mixed

* added the logstash role to the accessibility tests

* removed telemetry setting

* docs+few changes to the tests

* removed Page navigation

* removed pageNavigation which was unused

* test/accessibility/apps/management.ts

* update management.ts

* aria label, and other changes

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* reverted

* unloading of logstash data, fixing aria label

* aria-label

* added the required role

* fix for tsvb chart

* fix for sample data test reverted home_page pageobject file

* changes to sample data test and visualize index file to incorporate OSS changes

* changes to describe() and some more changes to incorporate in settings_page

* re-adding the after()

* removed unwanted roles

* replaced kibana_user with kibana_admin

* added the check of deprecated kibana_user

* testing with kibana_admin  role

* fix for discover test

* incorporated the review comments

* incorporated the review comments

* incorporate review comments and added restoreDefaults()

* removed describe.only

* reverted the OSS logic change I had here- pulled into seperate PR

* incorporated the review comments

* incorporated review changes

* adding hidden=true to find hidden kibanaChrome

* change field.test.tsx to be same as that of master branch

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 10:41:23 -07:00
Joel Griffith 6b7731bb74
[Reporting] Wholesale moves client to newest-platform (#58945)
* Move over to new plugin space, working implementation

* Fixing tests for report_listing snapshots

* WIP: Fixing react-component tests

* Fixing report_info_button tests

* Fixing download linksies

* WIP: Final working implementation

* Fixing attachAction API + API URLs

* Let the past die. Kill it if you have to. That’s the only way to become what you were meant to be.

* Fixing stream-client for new platform APIs

* Fixing types and tests

* Fix broken mock

* Adds back in warnings to report info button

* kibana.json line-breaks on required plugins

* Fixing broked snapshots

* Fix license checks in client-side components

* Adding back in warnings to report_listing component

* Fix danglig unused import

* Adds license checks for basic to our csv panel action

* Fixes issues from prior fork

* Move relative pathing to absolute

* Fix POST URL copying as we've moved from static methods

* Fix layoutId props

* Fixes types for layoutId

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 10:41:06 -07:00
Jen Huang 4da0cb3684
[Ingest] Support show_user package registry flag (#60338)
* Support registry `show_user` var definition property (elastic/package-registry#266)

* Add tests
2020-03-17 10:24:58 -07:00
MadameSheema 79b04547db
[SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (#60380)
* Revert "Revert "adds new test (#60064)""

This reverts commit 4a8fd0afee.

* waits for having 25 signals displayed
2020-03-17 18:14:02 +01:00
Yara Tercero cea277e7c2
[SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (#60108)
* add rule note markdown field to rule creation, rule details, and rule edit flows

Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 13:06:12 -04:00
Nicolas Chaulet 156066dc6f
[Fleet] Add config revision to fleet agents (#60292) 2020-03-17 12:34:03 -04:00
Larry Gregory 9318862f19
Allow kbn-config-schema to ignore unknown keys (#59560)
* allow kbn-config-schema to ignore unknown keys

* Consolidate unknown key configuration

* updates following merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 12:30:17 -04:00
Robert Oskamp 6a70d21ef3 [ML] Functional tests - disable df analytics clone tests 2020-03-17 16:29:01 +01:00
spalger b71099d620 skip flaky suite (#58643) (#58991) 2020-03-17 08:13:32 -07:00
Brian Seeders ce64895b2e
[FTR] Add support for --include and --exclude files via tags (#60123) 2020-03-17 10:53:59 -04:00
Xavier Mouligneau 0f9f81c30a
[SIEM] Fix link on overview page (#60348)
* Fix link on overview page

* no needs of useMemo

* clean up

* review I

* review II

* review III
2020-03-17 10:46:54 -04:00
spalger b9cc3e940c skip flaky test (#60369) 2020-03-17 07:39:04 -07:00
Davis Plumlee 53d23fcb3b
[Endpoint] Adds take action dropdown and tests to alert details flyout (#59242)
* adds dropdown

* changes i18n fields

* switches to buttons

* adds tests for alert details flyout

* updates es archiver data

* finishes functional and react tests

* cleanup tests for alerts

* updates alert esarchive data

* replaces es archives and fixes tests

* rebase

* fixes functional tests

* suggested changes to take action button

* addresses comments

Co-authored-by: oatkiller <robert.austin@elastic.co>
2020-03-17 10:34:39 -04:00
Wylie Conlon caed9ba5ac
[Lens] Simplify state management from visualization (#58279)
* [Lens] Declarative right panel

* Fix memoized operations

* Add error checking

* Fix dimension panel tests

* More updates

* Fix all editor frame tests

* Fix jest tests

* Fix bug with removing dimension

* Update tests

* Fix frame tests

* Fix all tests I could find

* Remove debugger

* Style config panels

* Update i18n

* Fix dashboard test

* Fix bug when switching index patterns
2020-03-17 09:57:52 -04:00
Jonathan Buttner 9c3c2a2372
Changing default type to start and allowing it to be configured by the event category (#60323) 2020-03-17 09:39:59 -04:00
Dima Arnautov dd680c790c
[ML] Adds the class_assignment_objective to classification (#60358)
* [ML] add maximize_minimum_recall to classification analysis

* [ML] fix mutation of the original job during the cloning
2020-03-17 13:34:33 +01:00
Marco Vettorello e25430ba36
[TSVB] fix text color when using custom background color (#60261)
When the user apply a background color manually from the UI,
this commit adapt the current colors to have a better contrast with
the chosen background color irrespective of the used dark/light theme
2020-03-17 12:22:45 +01:00
Tim Roes a755e55907
Fix import to timefilter from in TSVB (#60296) 2020-03-17 12:16:11 +01:00
Daniil Suleiman eddbdc896b
[NP] Get rid of usage redirectWhenMissing service (#59777)
* Move redirect_when_missing to kibana utils

* Replace redirectWhenMissing in dashboard

* Replace redirectWhenMissing in discover

* Remove redirect in monitoring

* Remove extra import

* Move invalid vistype check into editor.js

* Mock the history folder

* Fix redirect when missing index or saved object

* Move history to discover services

* Use redirect to listing page

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 14:02:03 +03:00
patrykkopycinski 55003b61dd
[SIEM] Fix Timeline footer styling (#59587) 2020-03-17 11:50:34 +01:00
Pete Harverson 7f901f9e03
[ML] Fixes to error handling for analytics jobs and file data viz (#60249)
* [ML] Fixes to error handling for analytics jobs and file data viz

* [ML] Fix failing tests and address comments from review

* [ML] Add key prop to error messages map

* [ML] Add errors.ts
2020-03-17 09:20:00 +00:00
Thomas Watson 56010b1c65
Give better stack traces for Unhandled Promise Rejection warnings (#60235) 2020-03-17 08:33:08 +01:00
Patrick Mueller d5665921c7
resolves https://github.com/elastic/kibana/issues/58905 (#60120)
The current index threshold alert uses a `size` limit on term aggregation, when used, but does not sort the buckets, so it's just using descending count on the grouped buckets as the sort to determine what to return.

The watcher API for the index threshold notes this as "top N of", implying a sort.

This PR applies sorting when the using `groupBy: top`, and the `aggType != count`.  For count, ES is already sorting the way we want.

The sort is calculated as a separate agg beside the date_range aggregation, which is the same metrics agg specified in the query - `aggType(aggField)`.  This field is then referenced in a new `order` property in the terms agg, using 'asc' sorting for `min`, and `desc` sorting for `avg`, `max`, and `sum`.

This doesn't change the shape of the output at all, just changes which term buckets will be returned, if there are more term buckets than requested with the `termSize` parameter.
2020-03-17 00:29:33 -04:00
Yuliia Naumenko 90f3778bc6
Added variables button for text fields in Pagerduty component. (#60189)
* Added variables button for text fields in Pagerduty component. Fixed bugs mentioned in https://github.com/elastic/kibana/issues/60067

* Fixed due to comments

* fixed language check issue

* Fixed tests

* Fixed due to comments
2020-03-16 19:39:21 -07:00
Patrick Mueller 35d6a0a635
adds test that action vars are rendered for alert action parms (#60310)
resolves https://github.com/elastic/kibana/issues/60083
2020-03-16 22:20:51 -04:00
Oliver Gupte 59551e7e81
Closes 59786 by removing the update toast (#60172)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-16 18:46:38 -07:00
Jen Huang 466da684a9
[EPM] Packages list tabs (#60167)
* Memo'ize some layout and EPM header components

* Split EPM home page into two tabs

* Clean up dead files and import paths

* Add empty state

* Use react routing for rendering tab content

* Fix import paths (again)
2020-03-16 17:05:11 -07:00
Yuliia Naumenko 4ebdc4edad
Added message variables button for Webhook body form field (#60174)
* Added message variables button for Webhook body form field

* Fixed test issue
2020-03-16 17:02:41 -07:00
spalger 4a8fd0afee Revert "adds new test (#60064)"
This reverts commit a946adbf10.
2020-03-16 15:58:53 -07:00
Nathan Reese ef3261132a
[Maps] move MapSavedObject type out of telemetry (#60127)
* [Maps] move MapSavedObject type out of telemetry

* move SavedObject from server to core/types

* review feedback

* results from check_published_api_changes
2020-03-16 15:40:52 -06:00
Tim Sullivan 537fa8c1eb
[Reporting] Fix error handling for job handler in route (#60161)
* fix bogus rison error

* add generate route test

* update test name
2020-03-16 14:26:47 -07:00
Eric Davis 132383c28c
[Endpoint] TEST: verify alerts page header says 'Alerts' (#60206)
* test to verify alerts page header says alerts

* updating test with pr feedback

* updating test with pr feedback and better verbiage

* updating test with pr feedback for better test titling

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-16 17:25:14 -04:00
nnamdifrankie 69ec60d744
EMT-248: implement ack resource to accept event payload to acknowledge agent actions (#60218)
[Ingest]EMT-248: implement ack resource to accept event payload to acknowledge agent actions
2020-03-16 17:18:49 -04:00
Aaron Caldwell c898e799a5
Migrate dual validated range (#59689)
* Move validated range files to new NP location

* Update refs in code

* Clean up old validated range files

* Change relative paths to 'kibana-react'. Some clean up

* Change to relative paths

* Fix i18n errors

* i18n clean up. Export module explicitly

* Change files over to TS to prevent build issue where validated range was missing

* Clean up TS conversion

* More clean up. Extend EuiRangeProps

* Remove unneeded ts-ignore

* Review feedback and test fixes

* Change double to single quotes

* min and max aren't always passed, make optional

* Type updates

* Review feedback. Set state to empty on init and add ignore comment

* Review feedback

* Add back in last 2 ts-ignores. Build fails without focusable attribute on EuiDualRange & No good alternatives for spread syntax in TS components

* Rollback change to state init. Initializing state to null actually triggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-16 14:33:56 -06:00
Vadim Dalecky 92aec698f5
Embeddable triggers (#58440)
* feat: 🎸 add Embeddable.supportedTriggers() method

* feat: 🎸 report supported triggers on visualization embeddable

* feat: 🎸 hard-code supportedTriggers() in visualize_embed

* feat: 🎸 use VIS_EVENT_TO_TRIGGER when executing trigger

* perf: ️ improve type

* fix: 🐛 revert back trigger check to how it is done on master

* chore: 🤖 remove unused import

* feat: 🎸 hard-code triggers for each visualization

* fix: 🐛 fix import

* feat: 🎸 reshuffle vis_types in supportedTriggers() method

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-16 21:28:34 +01:00
marshallmain 93914b6cb5
[Endpoint] Sample data generator CLI script (#59952)
* start on cli

* make it work

* cleanup

* remove failed attempt code

* update package and tsconfig

* remove empty file

* generate resolver events from multiple endpoints

* re-add child randomization

* align index names with real plugin

* remove duplication

* better naming

* add temporary mapping to sample data generator

* error handling, move tsconfig

* add readme

* Update README.md

* move mapping from common to scripts

* make delete index option

* remove unnecessary map call

* fix import style

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-16 15:53:49 -04:00
Alison Goryachev 77a859d43d
[Remote clusters] Add support for proxy mode (#59221) 2020-03-16 15:46:17 -04:00
Stacey Gammon dccfa593dc
Embeddable API cleanup (#60207)
* wip

* Remove test in legacy functional plugin
2020-03-16 15:37:42 -04:00
Nathan Reese 6cbfa274cf
[Maps] add draw control to create distance filter (#58163)
* [Maps] add distance filter to draw controls

* create distance filter

* update jest snapshot

* remove duplicated code

* reset circle draw when user hits escape

* i18n cleanup

* ts MultiIndexGeoFieldSelect

* ts DistanceFilterForm

* remove unused prop

* make interface a type

* move geo_field_with_index to components folder

* convert draw_circle to TS

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-16 13:33:40 -06:00
Felix Stürmer 6cd888f75f
[Logs UI] Fix log rate table row expansion (#60096)
This fixes the log rate table row expansion button, which broke in #54586 during a refactoring.
2020-03-16 19:47:56 +01:00
Frank Hassanabad dfff4fd6fa
[SIEM][Detection Engine] Refactors signal rule alert type into smaller code by creating functions
Refactors signal rule alert type into a smaller executor

## Summary

* Breaks out the schema into its own file and function
* Breaks out the action group into its own file and function
* Moves misc types being added to this into the `./types` file
* Breaks out all the writing of errors and success into their own functions
* Uses destructuring to pull data out of some of the data types
* Tweaks the gap detection to accept a date instead of moment to ease "ergonomics"   
* Updates unit tests for the gap detection

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-03-16 12:18:27 -06:00
James Gowdy 8a578960c0
[ML] Use real datafeed ID for datafeed preview (#60275) 2020-03-16 17:28:07 +00:00