Commit graph

33811 commits

Author SHA1 Message Date
Paul Tavares
afa8d3f7cb
[Endpoint] Refactor policy test service to cache call that retrieves package info (#68827)
* Call to EPM to retrieve Endpoint package information is cached
* Call to EPM to retrieve Endpoint is wrapped in `retry.try` in order to possibly work around network connectivity issues
2020-06-11 08:39:45 -04:00
Larry Gregory
21ceeebb97
Support migrating from reserved feature privileges (#68504) 2020-06-11 07:42:38 -04:00
Pierre Gayvallet
5f00d26ff3
add preference field to SavedObjectsFindOptions (#68620) 2020-06-11 12:57:59 +02:00
Yulia Čech
4b1b4759ef
[ILM] Add "wait for snapshot" policy field to Delete phase (#68505)
* [ILM] Add "wait for snapshot" text field to edit policy form (Delete phase)

* [ILM] Add jest client integration tests for delete phase

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-11 12:52:29 +02:00
Tim Roes
2a4741125d
Cleanup old license overwrites (#68744) 2020-06-11 11:28:13 +02:00
Mikhail Shustov
f593455a62
Bump TypeScript to v3.9 (#67666)
* add babel support for export type

* bump ts version to 3.9.3

* rebuild kbn-pm

* bump typescript-eslint

* fix error in security plugin UI

* check export as works

* fix app migration type

* use correct test subj attribute

* fix errors from the old PR

* embeddable is already passed in props

* explicitly define type of fetch

* add some types for viz

* fix fetch type p.2

* add null to allow spreading without type errors due to override

* add type guard to fix type error

* cast to any, since cannot assign unknown

* add timestamp to known types

* fix type error in fetch

* fix type error. id is always defined in attibutes

* declare a type

* move ts-ignore to the lines with errors

* declare tuple type explicitly

* mute type error. cannot assign unknown

* fix errors. id is always defined

* fix error type

* fix override errors. id is always defined

* fix error. extends any doesn't work anymore

* fix type error. type is always defined

* env doesn't always contain values

* fix type error

* cast to string

* add: logs is already declared in getNodeLogsUrl

* state is already  passed in props

* fix some errors in timelion

* number of fragments is always defined

* 'absolute' is not just string, but value

* TEMP: option is always defined

* always true if cast to promise manually

* both props are always defined

* explicitly define returned SO type

* workaround type

* bump tslib to be compatible with ts v3.9

* test private property

* rebuild kbn-pm

* Fix ts errors for beats management

* Fix type inference broken by the TS 3.9 upgrade

* Fix ingest manager saved object attributes typings

* Fix TS errors in cross_cluster_replication and index_management.

* Fix TS error in Watcher.

* roll back colorRange wrong type

* fix security plugin types

* TypeScript 3.9 fixes for APM

* Fix ColorRange types.

* fix actions & alerts errors. ByGidi

* fix lists error

* More APM fixes

* Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.)
* Add option chain for case in registerTransactionDurationAlertType
* Cast `overallValue` in transform_metrics_chart
* Use more specific type for custom link filters
* Add more option chaining for local UI filters buckets response
* Remove unused parameters from routes
* Fix getProjection type parameter
* Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error
* Revert `UnionToIntersection` change in `AggregationResponseMap`

Fixes #67804.

* fix platform type error

* Fix visualizations types.

* Fix data plugin types.

* bump TS version to 3.9.5

* Fix telemetry TS errors

* Fix dashboard code

* Adding Canvas Fixes for TS 3.9

* Fix case and security_solution types

* roll back to the old export syntax. new one might cause problems in api-extractor

* update docs

* Fix timelion code

* Fix meta

* Fix types

* fix type errors om ingest_manager

* bump babel deps

* enable private props & methods syntax

* update kbn-pm dist

* whitelist 0BSD license

* use @babel/plugin-proposal-private-methods in default set as well

* disable new babel plugins

* Revert "disable new babel plugins"

This reverts commit 04d959431d.

* cleanup security_solution types

* Fixes type error for newer TypeScript

* update docs

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Co-authored-by: Tim Roes <tim.roes@elastic.co>
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-11 10:04:09 +02:00
Oliver Gupte
9c4b4667f9
[APM] Service maps - adds new storybook stories to test out various data sets (#68727)
* - move cytoscape stories-related files to __stories__
- adds story to generate/render service map response data
- adds story that renders any service map response json
- adds story that renders opbeans test data

* added example data for 'Hipster store' and 'Todo app'

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-11 00:53:53 -07:00
Oleg Ivasenko
091cece232
Fix vega specification parsing (#67963)
* add filter clause to es_query_parser.js

* update tests to consider the filter clause

* update docs to show the new filter clause

Co-authored-by: Oleg Ivasenko <oleg.ivasenko@devolo.de>
2020-06-11 09:08:55 +03:00
Brandon Morelli
6ec3c23077
docs: add more api information (#68717) 2020-06-10 22:35:05 -07:00
Nathan L Smith
8aa1b39695
[APM] Don't show annotations on charts with no data (#68829)
Hide the annotations plot and legend when a chart has annotations but doesn't have any values in the series.

Fixes #66981.
2020-06-10 19:45:38 -05:00
Chris Cowan
89a6007881
[Metrics UI] Fix Inventory View sorting by handling null values (#67889)
* [Metrics UI] Fix Inventory View sorting by handling null values

* Fixing situation where the id is not unique

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 17:19:31 -07:00
spalger
0cfe1166ec skip flaky suite (#68836) 2020-06-10 16:07:23 -07:00
Yara Tercero
9216012c52
[SIEM][Detections Engine] - Fix reference rule url overflow (#68640)
### Summary

Rule reference urls, when really long, appear to overflow. The expected behavior is that it would wrap. I thought it was working in the create rule flow and not the details flow, but it was not working on either. The creation flow was simply hiding the overflow. This fixes it by adding word wrap to the urls.
2020-06-10 19:03:21 -04:00
Matthew Kime
40d2cfc4db
Index pattern public api => common (#68289)
Refactor index pattern api so it can be used by public and server services
2020-06-10 17:24:03 -05:00
Nathan L Smith
867a2d4c63
[APM] Lazy-load alert triggers (#68806)
Use `React.lazy` to load the alert triggers so the code doesn't load until the alert flyout is opened.

Fixes #66189.
2020-06-10 17:15:04 -05:00
DeDe Morton
05590d906a
[DOCS] Fix table formatting in ingest manager settings (#68824) 2020-06-10 15:10:23 -07:00
Paul Tavares
577381d821
[Endpoint] Functional Tests cleanup (#68756)
* Removed several unnecessary disabled eslint rules
* moved common pageobject from endpoint_list to page_utils
* Rename functional_endpoint to security_solution_endpoint
* Delete `functional_endpoint_ingest_failure` no longer applicable
2020-06-10 17:10:34 -04:00
Suyog Rao
28d9c1407c
revert previous commit which was unintentional
sorry, i thought i was making this change to a different repo
2020-06-10 13:50:14 -07:00
Suyog Rao
dfa4cdf05a
Use Github token instead for project assignments 2020-06-10 13:48:02 -07:00
Yara Tercero
49a45ecac5
[SIEM][Exceptions] - ExceptionsViewer cleanup (#68739)
### Summary

- Adds missing unit tests for relevant files missing them
- Changes filter search to fire request on 'Enter'
- Breaks out the main ExceptionViewer component into smaller components to make more readable and better tested
- Updates utility bar to have the specific list description text next to it as proposed by @spong in #68294 (comment)
- Adds loading state any time async request occurs
- Now fetches list on list type toggle (if user selects to view either only detections or endpoint items), before was simply filtering already fetched items
2020-06-10 16:45:09 -04:00
Mikhail Shustov
b3445cad8f
move @kbn/storybook to devDeps (#68791)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 22:04:13 +02:00
Sonja Krause-Harder
ff97a034ee
Clean up main Ingest Management doc directory (#68785) 2020-06-10 21:43:57 +02:00
Quynh Nguyen
3197a00e79
Revert "[ML] Transforms: Add ability to delete dest index & index pattern when deleting transform job" (#68793) 2020-06-10 12:02:52 -05:00
Nathan Reese
332a1386d0
[Maps] bump @elastic/ems-client and incorporate types (#68444)
* [Maps] bump @elastic/ems-client and incorporate types

* tslint

* update to ems-client 7.9.2

* bump to 7.9.3

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 10:57:23 -06:00
Brandon Kobel
e616935d0b
Using re2 for Timelion regular expressions (#67416)
* Revert "Revert "Using re2 for Timelion regular expressions (#55208)""

This reverts commit c90293d03f.

* Updating re2 to 1.14.0. Still need to update build patching

* Extract the gzip to the destination, supporting multiple extract methods

* Adding 'node' to jest's moduleFileExtensions

'node' is in the defaults, not sure why we aren't using the defaults...
https://jestjs.io/docs/en/configuration#modulefileextensions-arraystring

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 09:55:42 -07:00
Clint Andrew Hall
713f323447
[Canvas] Fixes for expected prop-types, Shape Arg UI, and i18n strings (#68304)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 11:30:36 -05:00
Joe Reuter
8d1a319472
keep custom labels (#68498) 2020-06-10 18:29:22 +02:00
Joe Reuter
497ecf8164
[Lens] Add description property and check duplicate title on save (#68219) 2020-06-10 18:28:00 +02:00
Tyler Smalley
8a5a7c3032
[eslint] Prevents importing of public code into server (#67149)
We should not be allowing importing of public into server. Any shared code should reside in a common directory. After #66506, this will not even be possible as we will no longer be transpiling public code into commonjs.

Blocks #66506

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-06-10 08:39:52 -07:00
Garrett Spong
3b4fa6ade6
[Security] Updates Cypress README.md to show how to run-as-ci with Cypress UI [skip ci] (#68728)
## Summary

Updates Cypress README.md to show how to `run-as-ci` with the Cypress UI. 

##### Updates: 
> Note: To `run-as-ci` with the Cypress UI, update [x-pack/test/security_solution_cypress/runner.ts](https://github.com/elastic/kibana/blob/master/x-pack/test/security_solution_cypress/runner.ts#L25) from 
> ``` ts
>args: ['cypress:run'],
>```
>to 
>``` ts
>args: ['cypress:open'],
>```
>This is helpful for debugging specific failed tests from CI without having to run the entire suite.
2020-06-10 09:19:32 -06:00
EamonnTP
3c6aabcf35
[DOCS] Move Logs app content to Logs monitoring guide (#68644)
* Move content to Logs guide

* Add redirects to Logs monitoring guide

* Update urls
2020-06-10 16:14:46 +01:00
Quynh Nguyen
9bc0936311
[ML] Transforms: Add ability to delete dest index & index pattern when deleting transform job (#67922) 2020-06-10 10:11:46 -05:00
Frank Hassanabad
8118b13ff7
[SIEM][Detection Engine] Follow up issues from PR 68127 (#68612)
## Summary

* Smaller follow ups and bug fixes from: https://github.com/elastic/kibana/pull/68127
* Added unknown to `findDifferencesRecursive`
* Added linter rule to catch NodeJS code in the common folders for both `lists` and `security_solution`
* Removed the Hapi server type from the common folder of lists

### Checklist

* Added unknown to the correct locations

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-06-10 08:54:27 -06:00
gchaps
4b620616bc
[DOCS] Fixes titles in Discover, Graph, & Install for consistency (#68685)
* [DOCS] Fixes titles in Discover, Graph, & Install for consistency

* [DOCS] More docs tweaks for consistency
2020-06-10 07:20:55 -07:00
Joe Reuter
a462e2c7b0
[Lens] Keep global filters, time range and refresh interval on refresh (#68075) 2020-06-10 15:44:59 +02:00
Vadim Dalecky
324393db36
docs: ✏️ update Drilldown description in docs (#68762) 2020-06-10 15:28:08 +02:00
Alison Goryachev
d7d9544a6f
[IM] Refactor component templates API integration tests (#68282)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 09:25:49 -04:00
Steph Milovic
c21c475694
[Security] [Timeline] Fix filter manager bug (#68708) 2020-06-10 07:09:58 -06:00
MadameSheema
dab193fa46
Renames detections missing parts (#68408)
* renames SIEM for Security

* changes from 'Security advanced settings' to 'Security Solution advanced settings'

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 15:08:16 +02:00
Nicolas Chaulet
08ca314faf
[Ingest Manager] Document fleet configuration flags (#66736) 2020-06-10 08:51:43 -04:00
Chris Cowan
951114d66b
[Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts (#68678)
* [Metrics UI] Fix fatal error when no data is available for Metric
Threshold Alerts

* Adding i18n support for error message

* Adding test
2020-06-10 05:47:04 -07:00
Yara Tercero
83771811e0
[SIEM][Detections Engine] - Exceptions viewer cleanup (#68651)
### Summary

This PR is a follow up to #68027 where some feedback didn't make it in. It cleans up the and_or_badge component, updates some css, and cleans up stories.
2020-06-10 08:08:57 -04:00
MadameSheema
3eced03bb1
[SIEM] Fixes flyout flaky test (#68683)
* fixes flaky test

* Update x-pack/plugins/security_solution/cypress/integration/timeline_flyout_button.spec.ts

Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>

Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>
2020-06-10 12:01:13 +02:00
MadameSheema
028c19e7b4
[SIEM] Cypress renaming (#68659)
* updates naming in integration

* updates naming in objects

* updates naming in screens

* updates naming in support

* updates naming in tasks

* fixes failing test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-10 12:00:40 +02:00
Aleh Zasypkin
204977c6ce
Partial revert of "Sync Kerberos + Anonymous access tests with the latest security/_authenticate API (user roles now include roles of anonymous user)." (#68624) 2020-06-10 09:10:23 +02:00
Pierre Gayvallet
50d47a2ed5
adapt some snapshot test (#68489) 2020-06-10 08:01:01 +02:00
Oliver Gupte
cac9018f81
[APM] Service maps - Fix missing ML status for services with jobs but no anomalies (#68486)
* Closes #68485 by:
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job

* - Use the anomalyDetectorsProvider jobs API rather than the search endpoint directly
- Defines a specific return type for the ml jobs api
- Update the empty anomaly data message

* Code and types cleanup

* Return to using record result type on anomaly queries. These are the
same values used in the anomaly explorer and it includes actual &
typical values which greatly improve performance of the previous query.

* - If anomaly data is missing show a gray border around node

* - moved AnomalyDetection out of service map Contents into own component

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 20:58:46 -07:00
Tyler Smalley
d00e91a2e5 [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user
https://github.com/elastic/kibana/issues/68720

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-06-09 20:06:50 -07:00
Yara Tercero
80958568e7
[SIEM][Exceptions] - ExceptionsViewer UI component part 2 (#68294)
### Summary 

This PR is a follow up to #68027 . It brings it all together to complete the exceptions viewer component. This component is meant to display all exception items and allow a user to create, edit, delete, and search these exception items.

- Moves ExceptionItem (from part 1) into its own folder
- Adds exceptions_viewer_header component that includes the search, list toggle, and add exception buttons
- Adds actual ExceptionViewer component
- Updates the useExceptionList hook refresh function logic. Noticed that the previous version was creating some issues
2020-06-09 21:37:37 -04:00
CJ Cenizal
aec0b97615
Surface data streams in Index Management. (#67806) 2020-06-09 16:05:48 -07:00