Commit graph

44580 commits

Author SHA1 Message Date
Alison Goryachev
d3ccb982c7
Improve painless validation handling in monaco (#105799) 2021-07-16 08:36:59 -04:00
Liza Katz
71385b6944
[Search Sessions] Hide search sessions menu after interaction (#105610)
* Hide search sessions menu after interaction

* simpler code using cores openModal

* fix ts and closing delete dialog

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 14:12:06 +02:00
James Rodewig
2adb59f5d9
[DOCS] Update watcher screenshots for new EUI (#105843) 2021-07-16 08:01:41 -04:00
Marco Liberati
2e5e4ca57f
[Lens][Visualize][Inspector][Reporting] Unified check for CSV cells for known formula characters (and value escaping more in general) (#105221)
*  Unify escaping logic for csv export

* 📝 Update api doc

*  Fix test with new escape logic

* 👌 First batch of feedback

* 💬 Fix typo

* 👌 Memoize function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 10:55:49 +02:00
Marco Liberati
8e5d83d995
[Lens] Add more Lens QA doc (#105057)
* 📝 Add more Lens qa doc

* 🐛 Fix wrong ref

* 🔥 Remove section anchor for now

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* 👌 Integrated feedback

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
2021-07-16 10:55:16 +02:00
Søren Louv-Jansen
2cf1bd540c
[APM] Enable metric-powered ui (#104929)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
2021-07-16 04:30:11 -04:00
John Schulz
f220ee63af
[Fleet] Reordered & more consistent summaries in API docs (#105824)
## Summary

Some changes to the order & summaries in the OpenAPI docs.

 * Removed `Fleet - ` and `EPM - ` text from the summaries. It saves space and I don't think the extra text helped the user
 * Replaced `Enrollment` prefix with `Enrollment API Key`
 * Used plural (`policies`, `agents`) for operations that return a list
 * Rearranged the order of the routes to group the routes vs using an alphabetic sort. 
   * Not sure if it's priority/domain but it feels better to me
   * `/setup` is the first route; not last.  
   * installing integrations and adding agents are "above the fold"

<details><summary>screenshots from one viewer - before (left) vs PR (right)</summary>
<img align="top" width="40%" alt="Screen Shot 2021-07-15 at 1 53 48 PM" src="https://user-images.githubusercontent.com/57655/125836353-1b3c10e2-6c1d-4a7a-99c7-04d49a37cbac.png"><img align="top" width="40%" alt="Screen Shot 2021-07-15 at 1 53 57 PM" src="https://user-images.githubusercontent.com/57655/125836358-6f0647c3-4209-43a3-8fc7-7b33ad97d543.png">
</details>
2021-07-15 20:23:14 -04:00
Quynh Nguyen
dced8bb1aa
[ML] Add functional tests for Anomaly Detection annotations (#105527)
* [ML] Add functional tests for annotations

* [ML] Update jest tests

* [ML] Fix regression caused by #104994

* [ML] Rename for clarity, clean up

* [ML] Fix rename typo, adds more log steps

* [ML] Update getVisibleText

* [ML] Move job & datafeed config to before
2021-07-15 19:33:21 -04:00
Justin Kambic
7c09bb5c5f
Fix broken doc links in Uptime app. (#105482)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 18:28:18 -04:00
Tiago Costa
86225685c6
chore(NA): upgrades bazel rules nodejs into v3.7.0 (#105764)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 22:35:56 +01:00
John Schulz
c9e11e0fb2
/agents returns Agent[] not AgentPolicy[] (#105814)
Fix the typo in https://github.com/elastic/kibana/pull/105679 which indicates `/agents` returns a list of agent policy objects instead of the correct list of agents.

diff from `/paths/agents.yaml`
```diff
-                  $ref: ../components/schemas/agent_policy.yaml
+                  $ref: ../components/schemas/agent.yaml
```

<details><summary>screenshot - before</summary>
<img width="1293" alt="Screen Shot 2021-07-15 at 12 39 14 PM" src="https://user-images.githubusercontent.com/57655/125829619-ddbd74f4-8806-45c4-af94-4b7645e2dc9b.png">
</details>

<details><summary>screenshot - after</summary>
<img width="1302" alt="Screen Shot 2021-07-15 at 12 39 33 PM" src="https://user-images.githubusercontent.com/57655/125829622-2715d071-14ee-4a2d-9ff5-96ece4eea682.png">
</details>
2021-07-15 16:54:44 -04:00
Justin Kambic
cba23c17b4
Define color for XHR timings in waterfall chart. (#105817) 2021-07-15 16:18:39 -04:00
Joe Portner
15b4981b1d
[Docs] Update security and spaces docs/screenshots (#105652) 2021-07-15 16:04:33 -04:00
Quynh Nguyen
78d6fc553d
[ML] Fix Anomaly Explorer annotations misaligned (#105696)
* Move swimlane annotation out of container, add new axis width prop

* [ML] Fix alignment if some annotations overflow

* [ML] Move utils function to inside anomaly_timeline_service

* [ML] Fix y chart overflow

* [ML] Enforce stricter check on isOverallSwimlaneData

* [ML] Update logic to check if only one label
2021-07-15 15:03:05 -05:00
Ece Özalp
5128613213
[CTI] Adds validation to Indicator index pattern (#105649)
* [CTI] Adds validation to Indicator index pattern
2021-07-15 15:31:06 -04:00
Wylie Conlon
1e68fb253c
[Lens] Fix overall_min, overall_max and overall_average functions (#105276)
* [Lens] Fix overall metrics

* Style comments
2021-07-15 15:30:21 -04:00
Ece Özalp
db8c86a2a1
[CTI] Adds integration test coverage to CTI Overview (#104785)
* [CTI] Adds integration test coverage to CTI Overview

* remove unnecessary line

* increases coverage

* updates tests"

* removes comments & unusued files

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 15:01:09 -04:00
Ryland Herrick
6e566b30c1
[Security Solution][CTI] Enrichment Details Final Copy/UI (#105701)
* Convert enrichment icon from the security logo to an (i)

Feedback was that the security logo was confusing.

* Move tooltip icon to the right of our content

Placing it on the left was meant to call out these fields as distinct
from others, but placing it on the right is more in line with EUI
guidelines.

This also updates the relative spacing of these elements to account for
this new position.

* Allows header to span multiple lines if content would wrap

Without this, both the tooltip icon and the inspect button could be
hidden if the indicator matched a field with a particularly long value
(e.g. a file hash).

* Update copy with latest from product

I took a guess at extending the verbiage for some of the more detailed
descriptions, since product has not yet provided those.

* Final copy updates

Each panel now includes the CTI CTA as well.
2021-07-15 14:38:58 -04:00
Kate Farrar
2079d61544
[Metrics UI] Inventory layout issues - interval language to tooltip (#105687)
inventory view - moved interval label language to a tooltip to make more room for waffle map controls responsively
2021-07-15 12:29:00 -06:00
Kate Farrar
eb3f4c0215
[Observability] Obs Overview cleanup & Metrics section layout fix (#104577)
* updating overview page layout to accommodate side bar nav, fixing metrics table responsive issues, style updates
2021-07-15 11:56:53 -06:00
Jonathan Budzenski
9e9dfe22ed skip flaky suite. #105784 2021-07-15 12:17:34 -05:00
Quynh Nguyen
98fc711117
[ML] Fix regression caused by #104994 (#105666)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 12:14:51 -05:00
Devon Thomson
da42524e51
Unskip Dashboard Listing Test (#105668)
* unskipped test due to successful flaky test runner
2021-07-15 11:54:07 -04:00
Wylie Conlon
f90e6669e1
[Lens] Fix pie chart with 0 decimal places for percent (#105672) 2021-07-15 11:23:35 -04:00
Melissa Alvarez
75e6b8721b
check metric function as well as label to determine geo (#105671) 2021-07-15 10:35:33 -04:00
John Schulz
00cee5f775
[Fleet] Improve OpenAPI accuracy and validity (#105679)
* Improve schema from object to $ref

* Add description and response schema for /agent-status endpoint

* Remove code related to removed /install/:os endpoint

* Add response schemas for enrollment-api-key operations

* Add response schemas for /agents/:agentId

* Fix two security scheme names

* Change format for reference selectors

* Replace Ingest Manager with Fleet in OpenAPI spec

* Replace instances of Ingest Manager with Fleet

* Update instructions to create bundled specs
2021-07-15 10:28:24 -04:00
David Sánchez
e77fbced4b
[Endpoint] [Security Solution] Adds security-onboarding-and-lifecycle-mgt as a codeowner (#105219)
* Adds security-onboarding-and-lifecycle-mgt as a codeowner of /public/management and /server/endpoint/routes/trusted_apps

* Add more server folders that we own

* adds more sub paths and split our team from the security one using a comment line

* sort imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 16:27:38 +02:00
Lisa Cawley
4f83eae47f
[ML] Rare anomaly detection job wizard card text (#105635) 2021-07-15 07:23:45 -07:00
Angela Chuang
b6ff81d83e
[Security Solution] Fix landing page on rule deletion (#105572)
* fix landing url on rule delete

* add cypress test

* fix cypress
2021-07-15 15:18:10 +01:00
Tiago Costa
1a47c05f9e
skip flaky suite (#93188) 2021-07-15 14:49:20 +01:00
Shahzad
84d4652b14
[User Experience App] Fixed searching filter values (#105582) 2021-07-15 15:42:00 +02:00
Alison Goryachev
8ccf88e3e1
[Snapshots + Restore] Fix no snapshots prompt 2021-07-15 08:50:17 -04:00
Anton Dosov
5fcdb9d137
[Search Sessions] Don’t try to delete errored searches (#105434) 2021-07-15 12:59:39 +02:00
Anton Dosov
4b4a405043
[Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (#105407) 2021-07-15 12:57:17 +02:00
Yulia Čech
7dcb136c68
[Remote Clusters] Fixed remote clusters details flyout for long strings (#105592) 2021-07-15 12:22:48 +02:00
Robert Oskamp
79c4126cca
[ML] Functional tests - re-activate a11y tests (#105198)
This PR re-activates the ML a11y test suite `with data loaded`.
2021-07-15 12:14:43 +02:00
Dario Gieselaar
821aeb1ff4
[APM] Typed client-side routing (#104274)
* [APM] @kbn/typed-router-config

* [APM] typed route config

* Breadcrumbs, wildcards

* Migrate settings, home

* Migrate part of service detail page

* Migrate remaining routes, tests

* Set maxWorkers for precommit script to 4

* Add jest types to tsconfigs

* Make sure transaction distribution data is fetched

* Fix typescript errors

* Remove usage of react-router's useParams

* Add route() utility function

* Don't use ApmServiceContext for alert flyouts

* Don't add onClick handler for breadcrumb

* Clarify ts-ignore

* Remove unused things

* Update documentation

* Use useServiceName() in ServiceMap component
2021-07-15 11:30:59 +02:00
Yaroslav Kuznietsov
e999b33e54
[Canvas] Expression error (#103048)
* Basic setup of error plugin.

* Removed not used `function` files at `error` expression.

* Moved related components from canvas.

* Changed imports of components.

* Fixed renderer and storybook.

* Fixed types errors.

* Added limits.

* Removed useless translations and fixed .i18nrc.json

* added `done` handler call.

* Added more fixes fo i18nc.

* Added docs.

* More fixes of i18nrc.

* Fixed async functions.

Written current code, based on https://github.com/storybookjs/storybook/issues/7745

* Fixed one test with Expression input.

After changing the way of rendering in stories, all elements are mounting and componentDidMount is involved. The previous snapshot was without
mounted `monaco` editor.

* Fixed storybook error.

* More fixes.

* removed unused translations.

* Removed handlers and changed the way of handling `resize` and calling `done`.

* Fixed i18n error.

* Fixed storybook.

* Replaced Popover with EuiPopover.

* Moved `Popover` back to `canvas`

* Removed `Popover` export from presentation_utils components.

* Moved error_component and debug_component from presentation_util to expression_error.

* Fixed translations and imports.

* Moved `debug renderer` to `expression_error` plugin.

* Fixed error.

* Fixed lazy exports.

* Fixed imports

* Fixed storybook snapshot.

* Removed `.i18nrc.json`.

* Fixed color of `error`.

* Exported concrete elements from popover.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 12:19:55 +03:00
James Gowdy
63ba5cc5f5
[ML] Fixing job wizard with missing description (#105574) 2021-07-15 09:18:33 +01:00
Yara Tercero
d43551ca4b
[Security Solution][Alerts] - Add alerts subfeature UI (#105505)
###Summary
This PR adds the subfeature UI for alerts to security solution. Note that the ability to customize subfeatures is still a gold feature. How will this map with existing users? The feature and subfeature are tied. So if a user was previously assinged All for security solution - they would get all for alerts, etc.

It still remains behind a feature flag, so to see the change you'll need to have the following in your kibana.dev.yml

xpack.securitySolution.enableExperimental: ['ruleRegistryEnabled']
xpack.ruleRegistry.write.enabled: true
2021-07-15 00:34:43 -04:00
Chandler Prall
3731a3048c
Upgrade EUI to v35.0.0 (#105127)
* Bump EUI to v35.0.0, update euiContextMapping to match latest i18n tokens

* Updated i18n_service jest snapshot

* Added license override for EUI

* Attempting to clean up some forced dependency resolutions

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-14 20:15:09 -06:00
Tim Sullivan
84af487292
[Reporting] Clean up types for internal APIs needed for UI (#105508)
* [Reporting] Refactor types for API response data

* fix api test

* Update x-pack/plugins/reporting/common/types.ts

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

* more verbose comments

* set comments in interface type definition

* Update x-pack/plugins/reporting/common/types.ts

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* more strict

* Update x-pack/plugins/reporting/public/management/report_info_button.tsx

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* Update x-pack/plugins/reporting/public/management/report_info_button.tsx

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* fix suggestion

* fix accidental declaration of interface methods as function properties

* fix info panel

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
2021-07-14 17:48:30 -07:00
spalger
961681fc5d skip flaky suite (#105087) 2021-07-14 17:01:39 -07:00
Scotty Bollinger
0f3e4f415f
[Workplace Search] Fix Chrome issues with GitHub sources (#105680)
* Fix route validation

This param is not always required. Was already fixed for org version but the personal dashboard came later and was not fixed.

Original fix for org:
30d8b1dfa8 (diff-07f094b2a4719e8511f003d8e278a77cd6b808d11b14d1c528705f9b259c328fR373)

* Fix route to account for private github route

Previously had the org route hard-coded

* Move the logic for parsing the query params to template

Because the useEffect call comes after the initial render, the chrome flashes. We originally got around this by hiding the chrome always because in non-github scenarios, this worked fine.

However, because the oauth plugin sends the state in the quert params and uses the same URL, we need to parse that to determine whether this is an org or accoutn route. We now do that logic in the template and set the chrome before calling the useEffect.

We still need to pass both the parsed params and the original quert string because the redirect passes that string to the next view.
2021-07-14 19:44:49 -04:00
Kyle Pollich
f0b44d7ef9
[Fleet] Add containerized fleet server instructions to Fleet README (#105669)
* Add containerized fleet server instructions to Fleet README

* Address PR feedback
2021-07-14 18:59:38 -04:00
Melissa Alvarez
6fae8fe80b
[ML] Add api integration test for analytics map endpoint (#105531)
* adds api integration test for analytics map endpoint in spaces

* wrap request code in function

* check error value and add messaging
2021-07-14 17:22:50 -04:00
Frank Hassanabad
b31b1a21d0
Fixes cypress flake across two tests (#105645)
## Summary

* Fixes flake where it looks like pre-built rules can take longer than 1 minute to load, so I increased that to 5 minutes
* There are problems with how the `cy.intercept` is not always working on CI we don't understand yet, so I am removing the failing call but keeping the rest of the test for the failure.

Backporting these two into `7.14` to add stability to `7.14` tests as well.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-07-14 15:03:25 -06:00
mgiota
6e30483cbf
[Logs&Metrics UI] add owner properties to plugin manifest (#105580) 2021-07-14 22:25:17 +02:00
Tiago Costa
977039cb76
chore(NA): introduce preset for jest-integration tests on @kbn/test (#105144)
* chore(NA): introduce preset for jest-integration tests on @kbn/test

* chore(NA): fix lockfile

* chore(NA): fix ci

* fix tests (#14)

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-14 20:53:12 +01:00
Jason Stoltzfus
02cd5086bc
[Enterprise Search] Added Thumbnails to Search UI (#104199) 2021-07-14 15:40:05 -04:00