Commit graph

6 commits

Author SHA1 Message Date
Andrew Cholakian 117bfb5cc7
Improve pull request template proposal (#56756)
Looking through Kibana PRs many currently ignore the check boxes or just delete them. The goal here is to make the process easier, delete some unused options and align the checkboxes with what's most useful. We've had some discussions on the Uptime team about ways the PR template could be potentially improved. These changes are based on an extended discussion we had on the topic. We'd love to hear if other teams would be OK with these recommended changes.

The changes here are:

* Allow authors to just delete unnecessary items rather than strike through. Adding all the `~~` in markdown is painful
* Remove the unnecessary checkbox for release notes, the build bot catches this and blocks merges without that being set.
* Add a checkbox for testing in various browser sizes / mobile responsive devices
* Move IE checkbox to the bottom of the list since it's seldom checked and makes the checklist seem daunting
2020-02-04 22:07:37 -06:00
Marco Vettorello 462229e90d
Fix typos in PR requeste template (#24075) 2018-10-17 09:54:25 +02:00
dave.snider@gmail.com abb3fcf53e
[PROPOSAL] Make Kibana's PR template a checklist (#23511)
Kibana now uses a checklist for its PR template. The contributing docs were updated with more detail about release process.
2018-09-28 09:36:31 -07:00
Spencer 0fde087ca2 Switch to Yarn (#15485)
* switch to yarn

* cleanup misc references to npm

* [yarn] loosen dependency ranges so yarn will merge more deps

* fix linting error now that moment uses ESM

* [licenses] font-awesome changed the format of its license id

* Use local yarn

* Misc fixes

* eslintignore built yarn file

* Remove mkdir which doesn't do what it should do

* Check build without upgrading lots of versions

* Fix license check

* too many moments

* Better description

* Review fixes

* Lock to angular@1.6.5

* More specific version locks

* Revert "More specific version locks"

This reverts commit 11ef81102e.

* Revert "Lock to angular@1.6.5"

This reverts commit 3ade68c14c.

* rm yarn.lock; yarn

* Forcing a specific version of React, Angular, Moment

* Using vendored version of yarn in ci

* Use --frozen-lockfile

* fixes
2018-01-10 13:23:43 +01:00
Court Ewing 2fbfa531c7 github: PR template checklist in a comment
The checklist of items in the PR description should be in a comment so
you don't have to manually remove them on every pull request.
2017-08-12 10:28:21 -04:00
Court Ewing a80287fbbe Correct PR template file name
09eb74a introduced a PR template with an incorrect file name, so github
does not use it for pull requests.
2016-06-11 16:46:35 -04:00
Renamed from .github/PR_TEMPLATE.md (Browse further)