* add skeleton for global_search plugin
* base implementation of the server-side service
* add utils tests
* add server-side mocks
* move take_in_array to common folder
* implements base of client-side plugin
* add tests for server-side service
* fix server plugin tests
* implement `navigateToUrl` core API
* extract processResults for the client-side
* fetch server results from the client side
* factorize process_results
* fix plugin start params
* move things around
* move all server types to single file
* fix types imports
* add basic FTR tests
* add client-side service tests
* add tests for addNavigate
* add getDefaultPreference & tests
* use optional for RequestHandlerContext
* add registerRoutes test
* add base test for context
* resolve TODO
* common nits/doc
* common nits/doc on public
* update CODEOWNERS
* add import for declare statement
* add license check on the server-side
* add license check on the client-side
* eslint
* address some review comments
* use properly typed errors for obs
* add integration tests for the find endpoint
* fix unit tests
* use licensing start contract
* translate the error message
* fix eslint rule for test_utils
* fix test_utils imports
* remove NavigableGlobalSearchResult, use `application.navigateToUrl` instead.
* use coreProvider plugin in FTR tests
* nits
* fix service start params
* fix service start params, bis
* I really need to fix this typecheck oom error
* add README, update missing jsdoc
* nits on doc
* initial file import
* update types
* update RFC PR number
* first draft complete
* draft v1.1.0
* initial self review
* nits and comments
* add 'preference' option
* change meta type to Record<string, Serializable>
* specify cancellation
* remove generic for GlobalSearchResponse, use distinct type on client and server
* use plain string instead of enum for GlobalSearchResult.type
* remove terminology from unresolved questions
* update pros/cons of core vs plugin
* GS is exposed from a plugin instead of core
* remove the server.publicAddress proposal, return mixed abs url / rel paths instead
* distinguish result type between GS api and result providers
* return batched results, no longer sort
* remove request from GlobalSearchProviderContext
* add maxResults to GlobalSearchProviderFindOptions
* nit/typo
* [RFC][skip-ci] Pulse
* Add drawback
* Add Opt-In/Out endpoint
* Add clarification about synched local internal indices
* Update rfcs/text/0008_pulse.md
Co-Authored-By: Josh Dover <me@joshdover.com>
* Add Phased implementation intentions, Security and Integrity challenges and example of use
* Refer to a follow up RFC to talk about security in the future
* Fix wording + add Legacy behaviour
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Josh Dover <me@joshdover.com>
* Draft RFC for unblocking plugin lifecycle methods
* Draft RFC for unblocking kibana startup
* Rename rfc from 0006 to 0007
* Add references to TC39 top-level await
* Update with review suggestion
Co-Authored-By: Court Ewing <court@epixa.com>
* Update RFC#0007
* Apply suggestions from code review
Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>
* Address review comments from @joshdover and @azasypkin
1. Fleshed out motivation, this RFC doesn't prevent errors, but isolates the
impact on the rest of Kibana.
2. Added a footnote explaining that sync lifecycles can still block on sync
for loops, so it's not a perfect guarantee (from @azasypkin).
3. Updated IContextProvider type signature in (2) to match latest master
4. Dynamically reloading configuration changes should be limited to a
whitelist, risky changes like the Elasticsearch host should still require a
complete restart. Added to (3) based on
https://github.com/elastic/kibana/pull/45796#discussion_r331277153
5. Added Section 5, "Core should expose a status signal for Core services &
plugins" (from @joshdover)
6. Added the drawback that incorrect, but valid config would not block Kibana,
and might only be surfaced when the associted API/UI gets used (from
@azasypkin)
* Formatting: number ordered list instead of letter for github rendering
* Apply suggestions from code review
Co-Authored-By: Josh Dover <me@joshdover.com>
* Update rfcs/text/0007_lifecycle_unblocked.md
Co-Authored-By: Josh Dover <me@joshdover.com>
* Example of plugin exposing API dependent on internal async operation
* Clarify that context providers won't block kibana, just their handlers
* Update adoption strategy as per latest discussion
* Fix formatting
* General structure of Public w/ legacy brace + autocomplete 🤔
Refactor Resizer functionality (panel component)
Refactor Play Button
Refactor Auto-completion
Refactor Docs opener
Refactor Storage
* First refactor of kbn ace keyboard mode to TS+React
* clean up unused props
* console_menu.js -> console_menu.tsx
* Remove unused file from quarantine and added fixed ui ace keyboard mode react hook
* - Refactored history and storage to app-wide services
- Pre-emptive changes to tests
- sense-history -> HistoryList
- removed unused kbn top nav v2 component
* A lot of cleanup, re-introduced editor resize checker, re-introduced history viewer as TS+React. `history` still needs refactoring.
* First iteration of tap nav menu, with history toggle working
* Lots of fixes
Also moved over and integrated remaining three react components
* Moved a lot of files around again, tidied up NP set up
* Replace angular directive
* Remove used code
* Re-order imports and move all ace dependencies to same location
* Remove more unused code
* Revise quarantined setup mocks
* Don't suggest 'undefined' or other null-like values in autocomplete
* Clean up api_server folder
* Re-add missing style
* Updated karma spec mock
* Fix editors cutting of at bottom of screen
* Refactor console editors into single components
Refactor a lot of business logic to main.tsx container
Minor renaming of variables for better readability
* Updated use of contexts with better error message
Fixed broken render sync cycles (using useCallback)
Fixed Main container render cycle (added missing deps to useEffect)
Fixed default input and removed auto indent from being called on init for already formatted text
* Updated test mocks
* Update to be more in line with NP conventions https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md
* Update console history when making new requests
Fixed spacing between editor and console history
Moved registration of keyboard commands to TS
Fixed setup_mocks.js after renaming app to application
* Clean up git merge conflict artifact
* Use updated NP interfaces
* More typings fixed after updating local project dependencies
* Removing some dependencies on KUI and font awesome from legacy editor
* Fix clear history not re-rendering
Refactor prop name to be more descriptive
* Simplify split_panel and add tests
* Fix accessibility tabbing behaviour for ace editor
* Refactor ConsoleEditor into two separate components
Remove unused changeCursor code
Remove unused textArea ref
Use default lodash debounce (remove unnecessary arg)
* Major a11y fix when tabbing
Major fix for ace in IE11 and Edge browsers
* Update comment
* Add core-only bundle
* Add ApplicationService mounting
* Add LegacyCore{Setup,Start}
* Fix PR comments
* Add functional tests
* Fix PR comments
* Fix PR comments
* Remove other usages of rootRoute
* Use state field notation
* Add support for open in new tab
* Fix PR comments
* Fix pesky await from the dead
* Update docs
* Bump @types/history
The `setup` lifecycle function for core and plugins will be for
one-time setup and configuration logic that should be completed
in a finite amount of time rather than be available throughout
the runtime of the service.
The existing `start` lifecycle function will continue to serve
only the purpose of longer running code that intentionally only
executes when `setup` is finished.
