Commit graph

26745 commits

Author SHA1 Message Date
WangQianliang f809ea5556
fix(code/frontend): fix wrong symbol range (#46157) (#46306) 2019-09-23 10:01:43 +08:00
Mikhail Shustov 73bb9b332c
remove unused properties and duplicated operations (#45347) (#45435) 2019-09-22 20:40:00 +03:00
Frank Hassanabad 62c56fde89
[SIEM] Filter out "loading" from Panel to make it a more React Performant boolean (#46258) (#46303)
## Summary

* This filters out the loading boolean from the EuiPanel to remove React console warnings
* This makes React memo's more performant by not pushing down new objects potentially causing re-renders.
* This improves the syntax usage from awkward object to a regular boolean value
* This DRY (Do not Repeat Yourself) the Panel to put in one area for usage
* This adds a unit test to ensure loading=true does not end up on the DOM  

References:
https://github.com/styled-components/styled-components/issues/1198#issuecomment-425650423
https://github.com/elastic/kibana/pull/41596#issuecomment-514418978
https://www.styled-components.com/docs/faqs#why-am-i-getting-html-attribute-warnings
https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html
### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-09-22 08:56:15 -06:00
Dmitry Lemeshko 0fa18df2df
Re-enable tsvb math aggs test (#46188) (#46254)
* re-enable tsvb  Math Aggregation test

* run ciGroup6 15x times

* Revert "run ciGroup6 15x times"

This reverts commit 19d94befcb.
2019-09-22 12:16:34 +03:00
Dmitry Lemeshko 5a7421a882
Fix/markdown functional tests (#46216) (#46262)
* [page_objects/visual_builder_page] improve text area input clearing and typing value

* run ciGroup6 15x times

* Revert "run ciGroup6 15x times"

This reverts commit d94491769b.
2019-09-22 12:13:46 +03:00
spalger 336fb97798 skip flaky suite (#46305)
(cherry picked from commit 5b67cd5e4f)
2019-09-21 11:30:06 -07:00
Matthew Kime 35788c958d
removing angular_vis_type (#45888) (#46302)
* removing angular_vis_type
2019-09-20 20:57:14 -05:00
Robert Oskamp 8569adc0dc
[ML] Update navigation tests to handle main and sub tabs (#45793) (#46242)
This PR updates the navigation tests to handle and validate the new main and sub tabs.
2019-09-20 21:37:38 +02:00
Sébastien Loix 8651c64a29
[Form Helpers + Template UI] Refactor Template UI using Form lib + helpers (#45287) (#46231) 2019-09-20 18:48:20 +02:00
Frank Hassanabad 7c5e01fb94
[SIEM] Changed job links have the job configuration in the search when the user clicks on them. (#46084) (#46209)
## Summary

* Adds the link for ML search when you click on it. 
* Adds more unit tests
* https://github.com/elastic/kibana/issues/46052

When you are an ML admin and open the ML Anomaly detection button and then click on the hyper link to a job it will take you to the ML job page of:
```ts
/app/ml
```
Which lists all of the jobs.
<img width="1405" alt="Screen Shot 2019-09-18 at 11 22 08 AM" src="https://user-images.githubusercontent.com/1151048/65170796-a7b7a480-da06-11e9-9cec-1a912129fb83.png">

If you have a lot of jobs to sort through this non-optimal. As an ML admin, you will want to go directly to the job you clicked on by having the search populated. That is possible by changing the link and adding the ml job:

Now when you click on a job id you are going to have the job ID populated like so:
<img width="1357" alt="Screen Shot 2019-09-18 at 11 20 55 AM" src="https://user-images.githubusercontent.com/1151048/65170720-7a6af680-da06-11e9-9482-84e7cd62763f.png">

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-09-20 10:05:38 -06:00
gchaps 0c498e49cf
[DOCS] Adds content for customized filters (#46203) (#46247) 2019-09-20 08:55:47 -07:00
Dmitrii 5c600b44b1
[ML] link to calendar settings from a job config (#46141) (#46225)
* [ML] link to calendar settings from a job config

* [ML] add basePath

* [ML] disable auto-refresh control for calendar page

* [ML] disable auto-refresh control for calendar page

* [ML] disable auto-refresh control for calendar page on mount

* [ML] mock timefilter
2019-09-20 17:41:44 +02:00
CJ Cenizal a280d2d626
Add spacer between form buttons and form body in Create Advanced Watch form. (#46186) (#46229) 2019-09-20 08:36:44 -07:00
Walter Rafelsberger 88ba17a06d
[ML] Data Frame Analytics: Fix permissions check. (#46110) (#46233)
The permissions check to delete an analytics job was wrongly checking for data frame transforms permissions. This fixes it by checking the correct canDeleteDataFrameAnalytics permission.
2019-09-20 08:33:30 -07:00
Mike Côté ee1441df31
Add throttling support for alerts (#41919) (#46228)
* Initial work

* Apply PR feedback pt1

* Apply PR feedback pt2

* Convert lastFired to be stored per group

* Keep track of alert instances until no longer throttled or no longer firing

* Fix broken jest tests

* Fix TypeScript types in AlertInstance

* Add unit tests for alert instance

* Rename confusing variable

* TypeScript Meta

* Fix failing api integration tests

* Add throttle integration test

* Make alert instances obsolete as soon as they don't fire

* Make action groups strict

* Change throttle behaviour as per discuss issue

* Fix jest test failures

* Cleanup

* Add test scenarios for throttle reset & changing groups

* Fix test failures

* Fix failing tests, share utils

* Cleanup

* i18n

* Rename epocTime

* Add new updateLastFired function

* Change lastScheduleActions to lastScheduledActions

* Add es test index tool class

* Make throttle string | null instead of string | undefined

* Remove isResolved

* Log instead of throwing error in createExecutionHandler

* Remove examples from regex validation

* Fix failing jest tests

* Fix throttle?: string to string | null

* Make throttle parameter mandatory on update

* Fix type check failures

* Fix failing integration test

* Fix other failing integration test
2019-09-20 11:18:25 -04:00
Matthias Wilhelm dbda7f4a52
Add numeric_type option for correct sort order on mixed date and date_nanos fields (#44212) (#46212)
* Implement getSortForSearchSource for add-on of 'numeric_type' to the ES request. Then sorting on a field that can be of date or date_nanos type works correctly

* Add functional test
2019-09-20 16:46:01 +02:00
gchaps 69ea45befd
[DOCS] Adds breaking changes for 7.4 (#46195) 2019-09-20 07:41:08 -07:00
Joe Reuter 7b33db0028
[Graph] Kql support for query bar (#45364) (#46221) 2019-09-20 16:23:40 +02:00
Frank Hassanabad d91c254eea
[SIEM] Fix unit tests to not throw unhandled promise rejections (#46152) (#46208)
One test was silently failing with unhandled exceptions:
```
(node:80263) UnhandledPromiseRejectionWarning: Error: Applying a filter requires a filter as context
(node:80263) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 14)
(node:80263) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
```

This fixes that as well does the following:
* Removes `any` types by using `unknown` and `is` type narrowing
* Removes the error handling helper in favor of just using Jest built in reject handling.

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-09-19 22:44:39 -06:00
Frank Hassanabad 53aa643d42
[SIEM] Remove ts-ignore where possible as other packages such as eui have updated now (#46046) (#46082)
## Summary

Packages such as EUI have updated and we can remove more ts-ignore from imports and other areas of code.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-09-19 19:36:33 -06:00
Nathan Reese c0c743d590
[Maps] cancel SearchSource fetches that are no longer needed. (#44436) (#46199)
* [Maps] cancel SearchSource fetch on new request and destroy

* cancel requests on layer delete and map unmount

* use delete function to unregister cancel callback

* review feedback

* move cancelRequest to action

* bubble request abort error up to caller
2019-09-19 18:20:31 -06:00
Wylie Conlon 000ea0ef37
[lens] Show field details on click (#44697) (#46187)
* [lens] Initial Commit (#35627)

* [visualization editor] Initial Commit

* [lens] Add more complete initial state

* [lens] Fix type issues

* [lens] Remove feature control

* [lens] Bring back feature control and add tests

* [lens] Update plugin structure and naming per comments

* replace any usage by safe casting

* [lens] Respond to review comments

* [lens] Remove unused EditorFrameState type

* [lens] Initial state for IndexPatternDatasource (#36052)

* [lens] Add first tests to indexpattern data source

* Respond to review comments

* Fix type definitions

* [lens] Editor frame initializes datasources and visualizations (#36060)

* [lens] Editor frame initializes datasources and visualizations

* Respond to review comments

* Fix build issues

* Fix state management issue

* [lens][draft] Lens/drag drop (#36268)

Add basic drag / drop component to Lens

* remove local package (#36456)

* [lens] Native renderer (#36165)

* Add nativerenderer component

* Use native renderer in app and editor frame

* [Lens] No explicit any (#36515)

* [Lens] Implement basic editor frame state handling (#36443)

* [lens] Load index patterns and render in data panel (#36463)

* [lens] Editor frame initializes datasources and visualizations

* Respond to review comments

* Fix build issues

* remove local package

* [lens] Load index patterns into data source

* Redo types for Index Pattern Datasource

* Fix one more type

* Respond to review comments

* [draft] Lens/line chart renderer (#36827)

Expression logic for the Lens xy chart.

* [lens] Index pattern data panel (initial) (#37015)

* [lens] Index pattern switcher

* Respond to review comments

* [Lens] Editor state 2 (#36513)

* [lens] Dimension panel that generates columns (#37117)

* [lens] Dimension panel that generates columns

* Update from review comments

* [lens] Generate esdocs queries from index pattern (#37361)

* [lens] Generate esdocs queries from index pattern

* Remove unused code

* Update yarn.lock from yarn kbn bootstrap

* [Lens] Add basic Lens xy chart suggestions (#37030)

Basic xy chart suggestions

* [Lens] Expression rendering (#37648)

* [Lens] Expression handling (#37876)

* [Lens] Lens/xy config panel (#37391)

Basic xy chart configuration panel

* [Lens] Xy expression building (#37967)

* [Lens] Initialize visualization with datasource api (#38142)

* [lens] Dimension panel lets users select operations and fields individually (#37573)

* [lens] Dimension panel lets users select operations and fields individually

* Split files and add tests

* Fix dimension labeling and add clear button

* Support more aggregations, aggregation nesting, rollups, and clearing

* Fix esaggs expression

* Increase top-level test coverage of dimension panel

* Update from review comments

* [Lens] Rename columns (#38278)

* [Lens] Lens/index pattern drag drop (#37711)

* Basic xy chart suggestions

* Re-apply XY config panel after force merge

* Initial integration of lens drag and drop

* Tweak naming, remove irellevant comment

* Tweaks per Wylie's feedback

* Add xy chart internationalization
Tweak types per Joe's feedback

* Update xy chart i18n implementation

* Fix i18n id

* Add drop tests to the lens index pattern

* improve tests

* [lens] Only allow aggregated dimensions (#38820)

* [lens] Only allow aggregated dimensions

* [lens] Index pattern suggest on drop

* Fully remove value

* Revert "[lens] Index pattern suggest on drop"

This reverts commit 604c6ed68c.

* Fix type errors

* [lens] Suggest on drop (#38848)

* [lens] Index pattern suggest on drop

* Add test for suggestion without date field

* fix merge

* [Lens] Parameter configurations and new dimension config flow (#38863)

* fix eslint failure

* [lens] Fix build by updating saved objects and i18n (#39391)

* [lens] Update location of saved objects code

* Update internatationalization

* Remove added file

* [lens] Fix arguments to esaggs using booleans (#39462)

* [lens] Datatable visualization plugin (#39390)

* [lens] Datatable visualization plugin

* Fix merge issues and add tests

* Update from review

* Fix file locations

* [lens] Use first suggestion when switching visualizations (#39377)

* [lens] Label each Y axis with its operation label (#39461)

* [lens] Label each Y axis with its operation label

* Remove comment

* Add link to chart issue

* [Lens] Suggestion preview rendering (#39576)

* [Lens] Popover configs (#39565)

* [Lens] Basic layouting (#39587)

* remove datasource public API in suggestions (#39772)

* [Lens] Basic save / load (#39257)

Add basic routing, save, and load to Lens

* [lens] Fix lint error

* [lens] Use node scripts/eslint.js --fix to fix errors

* [lens] Include link to lens from Visualize (#40542)

* [lens] Support stacking in xy visualization (#40546)

* [lens] Support stacking in xy visualization

* Use chart type switcher for stacked and horizontal xy charts

* Clean up remaining isStacked code

* Fix type error

* [Lens] Add xy split series support (#39726)

* Add split series to lens xy chart

* [lens] Lens Filter Ratio (#40196)

* WIP filter ratio

* Fix test issues

* Pass dependencies through plugin like new platform

* Pass props into filter ratio popover editor

* Provide mocks to filter_ratio popover test

* Add another test

* Clean up to prepare for review

* Clean up unnecessary changes

* Respond to review comments

* Fix tests

* [Lens] Terms order direction (#39884)

* fix types

* [Lens] Data panel styling and optimizations (#40787)

Style the data panel (mostly Joe Reuter's doing). Optimize a bunch of the Lens stack.

* [Lens] Optimize dimension panel flow (#41114)

* [Lens] re-introduce no-explicit-any (#41454)

* [Lens] No results marker (#41450)

* [lens] Support layers for visualizing results of multiple queries (#41290)

* [lens] WIP add support for layers

* [lens] WIP switch to nested tables

* Get basic layering to work

* Load multiple tables and render in one chart

* Fix priority ordering

* Reduce quantity of linting errors

* Ensure that new xy layer state has a split column

* Make the "add" y / split the trailing accessor

* Various fixes for datasource public API and implementation

* Unify datasource deletion and accessor removal

* Fix broken scss

* Fix xy visualization TypeScript errors?

* Build basic suggestions

* Restore save/load and fix typescript bugs

* simplify init routine

* fix save tests

* fix persistence tests

* fix state management tests

* Ensure the data table is aligned to the top

* Add layer support to Lens datatable

* Give xy chart a default layer initially

* Allow deletion of layers in xy charts

* xy: Make split accessor singular
Remove commented code blocks

* Change expression type for lens_merge_tables

* Fix XY chart rendering expression

* Fix type errors relating to `layerId` in table suggestions

* Pass around tables for suggestions with associated layerIds

* fix tests in workspace panel

* fix editor_frame tests

* Fix xy tests, skip inapplicable tests
that will be implemented in a separate PR

* add some tests for multiple datasources and layers

* Suggest that split series comes before X axis in XY chart

* Get datatable suggestion working

* Adjust how xy axis labels are computed

* Datasource suggestions should handle layers and have tests

* Fix linting in XY chart and remove commented code

* Update snapshots from earlier change

* Fix linting errors

* More cleanup

* Remove commented code

* Test the multi-column editor

* XY Visualization does not need to track datasourceId

* Fix various comments

* Remove unused xy prop
Add datasource header to datatable config

* Use operation labels for XY chart

* Adding and removing layers is reflected in the datasource

* rewrote datasource state init

* clean up editor_frame frame api implementation

* clean up editor frame

* [Lens] Embeddable (#41361)

* [lens] Move XY chart config into popover and fix layering (#41927)

* [lens] Move XY chart config into popover and fix layering

* Fix tests

* Update style

* Change wrapping of layer settings popover

* [Lens] Fix bugs in date_histogram and filter ratio (#42046)

* [Lens] Performance improvements (#41784)

* fix type error

* switch default size of terms operation to 3 (#42334)

* [lens] Improve suggestions for split series (#42052)

* [lens] Add chart switcher (#42093)

* solve merge conflicts

* fix test case

* [Lens] Allow only current visualization on field drop in workspace (#42344)

* [Lens] Remove indexpattern id on column (#42429)

* [lens] Implement app-level filtering and time picker (#42031)

* [lens] Implement app-level filtering and time picker

* More integration with filter bar

* Clean up test code and type errors

* Add frame level tests for syncing with app

* Add test coverage for app logic

* Simplify state management from app down

* Fix import errors

* Clarify whether properties are ids or titles for index pattern

* pass new saved object by ref

* add dirty state checking

* Fix tests

* [Lens] Add some tests around document handling in dimension panel (#42670)

* [Lens] Terms operation boolean support (#42817)

* [lens] Minor UX/UI improvements in Lens (#42852)

* Make dimension popover toggle when clicking button

* Without suggestions hide suggestion panel

* Add missing translations (#42921)

* [Lens] Config panel design (#42980)

* Fix up design of config panel

Does not include config popover

* Remove a couple of non-null assertions (#43013)

* Remove a couple of non-null assertions

* Remove orphaned import

* [Lens] Switch indexpattern manually (#42599)

* [Lens] Update frame to put suggestions at the bottom (#42997)

* fix type errors

* switch indexpattern on layer if there is only a single empty one (#43079)

* [Lens] Suggest reduced versions of current data table (#42537)

* [Lens] Field formatter support (#38874)

* Fix bugs

* [Lens] Add bucket nesting editor to indexpattern (#42869)

* [Lens] Remove unnecessary fields and indexing from mappings (#43285)

* [Lens] Xy scale type (#42142)

* [lens] Allow updater function to be used for updating state (#43373)

* [Lens] Lens metric visualization (#39364)

* Fix axis rotation (#43792)

* [Lens] Auto date histogram (#43775)

* Add auto date histogram

* Improve documentation and cleanup

* Add tests

* Change test name

* [Lens] Fix query bar integration (#43865)

* [Lens] Clean up operations code (#43784)

* [Lens] Functional tests (#44279)

Foundational layer for lens functional tests. Lens-specific page objects are not in this PR.

* [Lens] Add Lens visualizations to Visualize list (#43398)

* [Lens] Suggestion improvements (#43688)

* [lens] Calculate existence of fields in datasource

* [lens] Show field details on click

* [lens] Calculate existence of fields in datasource (#44422)

* [lens] Calculate existence of fields in datasource

* Fix route registration

* Add page object and use existence in functional test

* Simplify layout of filters for index pattern

* Respond to review feedback

* Update class names

* Use new URL constant

* Fix usage of base path

* Fix lint errors

* Add basic API test and make trigger into draggable

* [Lens ] Preview metric (#43755)

* format filter ratio as percentage (#44625)

* [Lens] Remove datasource suggestion id (#44495)

* [Lens] Make breadcrumbs look and feel like Visualize (#44258)

* Improve click target for popover

* [lens] Fix breakage from app-arch movements (#44720)

* [lens] Fix type error in test from merge

* Merge branch origin/feature/lens

* [lens] Fix registration of embeddable (#45171)

* Upgrade EUI and fix typescript breakages

* Undo EUI changes

* [Lens] Functional tests (#44814)

Basic functional tests for Lens, by no means comprehensive. This is more of a smokescreen test of some normal use cases.

* Fix snapshots

* Fix issues with types and tests

* Add back accidentally committed code

* [lens] Add Lens to CODEOWNERS (#45296)

* Change popover styles and simplify types on server

* [lens] Fix visualization alias registration

* [lens] Fix usage of EUI after typescript upgrade (#45404)

* [lens] Fix usage of EUI after typescript upgrade

* Use local fix instead of workaround

* Process results more

* Fix API errors

* Fix API tests and use sampleCount

* Simplify document count calculation

* [lens] Fix usage of expressions plugin (#45544)

* [lens] Fix usage of expressions plugin

* Use updated exports from #45538

* Fix imports and mocha tests

* Use relative instead of absolute path to fix tests

* Fix API test

* Fix type errors and pass through new platform from top

* [lens] More cleanup from QueryBar changes in master (#45687)

* Fix tests

* Fix i18n issue

* [lens] Fix build and use new platform from entry points (#45834)

* [lens] Fix build and use new platform from entry points

* Fix params for existence route

* Fix tests and add boolean/empty field support

* Updated top values

* Fixed up overall layout including adding a popover header

* Fix up time display

* Improve popover edge cases and respond to feedback

* Fix field formatters for histogram

* Use custom style for empty top values
2019-09-19 18:31:30 -04:00
Larry Gregory e9ea5fb52f
Spaces - updating moving SO between spaces docs (#45843) (#46183)
* updating moving SO between spaces docs

* mark api as beta

* apply review suggestions
2019-09-19 17:45:54 -04:00
Mengwei Ding 412e077297
[7.x] [Code] initial code telemetry integration (#45467) (#46161)
* [Code] initial code telemetry integration (#45467)

* [Code] initial code telemetry backend integration

* frontend metric code

* Add lang server and repositories

* adjustments

* fix test

* update test
2019-09-19 12:33:26 -07:00
liza-mae e6664473d0
Revert hiding Kibana icon, test Percy rendering (#43990) (#46168)
* Revert hiding Kibana icon, test Percy rendering

* Update jobs.yml

* Use percy token for kibana dev

* Update Percy token to read from kibana-issues

* Read correct field

* increase timeout

* Run each visual job 10 times

* Revert last commit

* Increase timeout

* Disable visual tests and revert percy token

* Fix jest tests

* Another jest test fix
2019-09-19 13:11:25 -06:00
Josh Dover 27225fec2e
[7.x] Ensure core context providers are always provided to plu… (#46028) 2019-09-19 14:03:42 -05:00
Chris Cowan a337c3a199
[Infra UI] Visual Regression Test for Inventory View (#44189) (#46165)
* [Infra UI] Visual Regression Test for Inventory View

* removing extra code

* Updating tests
2019-09-19 11:42:56 -07:00
Caroline Horn 159fee4e5b
Upgrade EUI to 14.2.0 (#46075) (#46160)
* Upgraded EUI to 14.2.0

* Remove form row + button shim

* Uncomment compressed prop from EuiComboBoxes

* Fix and/or simplify prepend/append usages

* Update two test files to correctly call EuiRange's onChange prop
2019-09-19 14:36:24 -04:00
Dmitry Lemeshko 2d50a92a9d
Fix visualize point series tests (#46069) (#46159)
* change interaction with 'select' element

* run ciGroup5 15x times

* Revert "run ciGroup5 15x times"

This reverts commit 9c19d9a135.
2019-09-19 20:10:05 +02:00
Poff Poffenberger 267d75195c
[Canvas] i18n work for app, asset picker, and color manager components (#45936) (#46156)
* Asset Picker i18n and typescript conversion

* Color Manager i18n

* App i18n
2019-09-19 12:56:46 -05:00
Spencer 5f6f49a963
[7.x] [docs] jenkins piplines (#46080) (#46147)
* [docs] jenkins piplines

add some docs describing how to find the logs for specific failed steps in pipelines

* fix typo
2019-09-19 10:12:01 -07:00
Alison Goryachev 371452b0e5
[SR] support setting for disabling slm ui (#46050) (#46143) 2019-09-19 12:52:58 -04:00
Caroline Horn 6c1048445d
[Maps] Design updates for compressed form styles (#46088) (#46136) 2019-09-19 12:26:54 -04:00
Wylie Conlon 052f63f281
[Lens] Transient suggestions (#44234) (#46092)
* [lens] Initial Commit (#35627)

* [visualization editor] Initial Commit

* [lens] Add more complete initial state

* [lens] Fix type issues

* [lens] Remove feature control

* [lens] Bring back feature control and add tests

* [lens] Update plugin structure and naming per comments

* replace any usage by safe casting

* [lens] Respond to review comments

* [lens] Remove unused EditorFrameState type

* [lens] Initial state for IndexPatternDatasource (#36052)

* [lens] Add first tests to indexpattern data source

* Respond to review comments

* Fix type definitions

* [lens] Editor frame initializes datasources and visualizations (#36060)

* [lens] Editor frame initializes datasources and visualizations

* Respond to review comments

* Fix build issues

* Fix state management issue

* [lens][draft] Lens/drag drop (#36268)

Add basic drag / drop component to Lens

* remove local package (#36456)

* [lens] Native renderer (#36165)

* Add nativerenderer component

* Use native renderer in app and editor frame

* [Lens] No explicit any (#36515)

* [Lens] Implement basic editor frame state handling (#36443)

* [lens] Load index patterns and render in data panel (#36463)

* [lens] Editor frame initializes datasources and visualizations

* Respond to review comments

* Fix build issues

* remove local package

* [lens] Load index patterns into data source

* Redo types for Index Pattern Datasource

* Fix one more type

* Respond to review comments

* [draft] Lens/line chart renderer (#36827)

Expression logic for the Lens xy chart.

* [lens] Index pattern data panel (initial) (#37015)

* [lens] Index pattern switcher

* Respond to review comments

* [Lens] Editor state 2 (#36513)

* [lens] Dimension panel that generates columns (#37117)

* [lens] Dimension panel that generates columns

* Update from review comments

* [lens] Generate esdocs queries from index pattern (#37361)

* [lens] Generate esdocs queries from index pattern

* Remove unused code

* Update yarn.lock from yarn kbn bootstrap

* [Lens] Add basic Lens xy chart suggestions (#37030)

Basic xy chart suggestions

* [Lens] Expression rendering (#37648)

* [Lens] Expression handling (#37876)

* [Lens] Lens/xy config panel (#37391)

Basic xy chart configuration panel

* [Lens] Xy expression building (#37967)

* [Lens] Initialize visualization with datasource api (#38142)

* [lens] Dimension panel lets users select operations and fields individually (#37573)

* [lens] Dimension panel lets users select operations and fields individually

* Split files and add tests

* Fix dimension labeling and add clear button

* Support more aggregations, aggregation nesting, rollups, and clearing

* Fix esaggs expression

* Increase top-level test coverage of dimension panel

* Update from review comments

* [Lens] Rename columns (#38278)

* [Lens] Lens/index pattern drag drop (#37711)

* Basic xy chart suggestions

* Re-apply XY config panel after force merge

* Initial integration of lens drag and drop

* Tweak naming, remove irellevant comment

* Tweaks per Wylie's feedback

* Add xy chart internationalization
Tweak types per Joe's feedback

* Update xy chart i18n implementation

* Fix i18n id

* Add drop tests to the lens index pattern

* improve tests

* [lens] Only allow aggregated dimensions (#38820)

* [lens] Only allow aggregated dimensions

* [lens] Index pattern suggest on drop

* Fully remove value

* Revert "[lens] Index pattern suggest on drop"

This reverts commit 604c6ed68c.

* Fix type errors

* [lens] Suggest on drop (#38848)

* [lens] Index pattern suggest on drop

* Add test for suggestion without date field

* fix merge

* [Lens] Parameter configurations and new dimension config flow (#38863)

* fix eslint failure

* [lens] Fix build by updating saved objects and i18n (#39391)

* [lens] Update location of saved objects code

* Update internatationalization

* Remove added file

* Lens basic metric visualization

* [lens] Fix arguments to esaggs using booleans (#39462)

* [lens] Datatable visualization plugin (#39390)

* [lens] Datatable visualization plugin

* Fix merge issues and add tests

* Update from review

* Fix file locations

* Fix merge issues, localize expression help text

* Add auto-scaling to the lens metric visualization

* Fix unit tests broken by autoscale

* Move autoscale to the new Lens folder

* [lens] Use first suggestion when switching visualizations (#39377)

* [lens] Label each Y axis with its operation label (#39461)

* [lens] Label each Y axis with its operation label

* Remove comment

* Add link to chart issue

* [Lens] Suggestion preview rendering (#39576)

* [Lens] Popover configs (#39565)

* [Lens] Basic layouting (#39587)

* remove datasource public API in suggestions (#39772)

* [Lens] Basic save / load (#39257)

Add basic routing, save, and load to Lens

* [lens] Fix lint error

* [lens] Use node scripts/eslint.js --fix to fix errors

* [lens] Include link to lens from Visualize (#40542)

* [lens] Support stacking in xy visualization (#40546)

* [lens] Support stacking in xy visualization

* Use chart type switcher for stacked and horizontal xy charts

* Clean up remaining isStacked code

* Fix type error

* [Lens] Add xy split series support (#39726)

* Add split series to lens xy chart

* [lens] Lens Filter Ratio (#40196)

* WIP filter ratio

* Fix test issues

* Pass dependencies through plugin like new platform

* Pass props into filter ratio popover editor

* Provide mocks to filter_ratio popover test

* Add another test

* Clean up to prepare for review

* Clean up unnecessary changes

* Respond to review comments

* Fix tests

* [Lens] Terms order direction (#39884)

* fix types

* [Lens] Data panel styling and optimizations (#40787)

Style the data panel (mostly Joe Reuter's doing). Optimize a bunch of the Lens stack.

* Add metric preview icon

* Fix metric vis tests

* Fix metric plugin imports

* Use the operation label as the metric title

* [Lens] Optimize dimension panel flow (#41114)

* [Lens] re-introduce no-explicit-any (#41454)

* [Lens] No results marker (#41450)

* [lens] Support layers for visualizing results of multiple queries (#41290)

* [lens] WIP add support for layers

* [lens] WIP switch to nested tables

* Get basic layering to work

* Load multiple tables and render in one chart

* Fix priority ordering

* Reduce quantity of linting errors

* Ensure that new xy layer state has a split column

* Make the "add" y / split the trailing accessor

* Various fixes for datasource public API and implementation

* Unify datasource deletion and accessor removal

* Fix broken scss

* Fix xy visualization TypeScript errors?

* Build basic suggestions

* Restore save/load and fix typescript bugs

* simplify init routine

* fix save tests

* fix persistence tests

* fix state management tests

* Ensure the data table is aligned to the top

* Add layer support to Lens datatable

* Give xy chart a default layer initially

* Allow deletion of layers in xy charts

* xy: Make split accessor singular
Remove commented code blocks

* Change expression type for lens_merge_tables

* Fix XY chart rendering expression

* Fix type errors relating to `layerId` in table suggestions

* Pass around tables for suggestions with associated layerIds

* fix tests in workspace panel

* fix editor_frame tests

* Fix xy tests, skip inapplicable tests
that will be implemented in a separate PR

* add some tests for multiple datasources and layers

* Suggest that split series comes before X axis in XY chart

* Get datatable suggestion working

* Adjust how xy axis labels are computed

* Datasource suggestions should handle layers and have tests

* Fix linting in XY chart and remove commented code

* Update snapshots from earlier change

* Fix linting errors

* More cleanup

* Remove commented code

* Test the multi-column editor

* XY Visualization does not need to track datasourceId

* Fix various comments

* Remove unused xy prop
Add datasource header to datatable config

* Use operation labels for XY chart

* Adding and removing layers is reflected in the datasource

* rewrote datasource state init

* clean up editor_frame frame api implementation

* clean up editor frame

* [Lens] Embeddable (#41361)

* [lens] Move XY chart config into popover and fix layering (#41927)

* [lens] Move XY chart config into popover and fix layering

* Fix tests

* Update style

* Change wrapping of layer settings popover

* [Lens] Fix bugs in date_histogram and filter ratio (#42046)

* [Lens] Performance improvements (#41784)

* fix type error

* switch default size of terms operation to 3 (#42334)

* [lens] Improve suggestions for split series (#42052)

* [lens] Add chart switcher (#42093)

* solve merge conflicts

* fix test case

* [Lens] Allow only current visualization on field drop in workspace (#42344)

* [Lens] Remove indexpattern id on column (#42429)

* [lens] Implement app-level filtering and time picker (#42031)

* [lens] Implement app-level filtering and time picker

* More integration with filter bar

* Clean up test code and type errors

* Add frame level tests for syncing with app

* Add test coverage for app logic

* Simplify state management from app down

* Fix import errors

* Clarify whether properties are ids or titles for index pattern

* pass new saved object by ref

* add dirty state checking

* Fix tests

* [Lens] Add some tests around document handling in dimension panel (#42670)

* [Lens] Terms operation boolean support (#42817)

* [lens] Minor UX/UI improvements in Lens (#42852)

* Make dimension popover toggle when clicking button

* Without suggestions hide suggestion panel

* Add missing translations (#42921)

* [Lens] Config panel design (#42980)

* Fix up design of config panel

Does not include config popover

* Add metric suggestions, fix tests

* Remove a couple of non-null assertions (#43013)

* Remove a couple of non-null assertions

* Remove orphaned import

* [Lens] Switch indexpattern manually (#42599)

* [Lens] Update frame to put suggestions at the bottom (#42997)

* Back out suggestion changes, in lieu
of Joe's work

* fix type errors

* switch indexpattern on layer if there is only a single empty one (#43079)

* [Lens] Suggest reduced versions of current data table (#42537)

* [Lens] Field formatter support (#38874)

* Fix bugs

* Fix metric autoscale logic

* Register metric as an embeddable

* Fix metric autoscale flicker

* Render mini metric in suggestions panel

* Cache the metric filterOperations function

* fix auto scaling edge cases

* [Lens] Add bucket nesting editor to indexpattern (#42869)

* Modify auto-scale to handle resize events

* use format hints in metric vis

* start cleaning up suggestions

* [Lens] Remove unnecessary fields and indexing from mappings (#43285)

* Tweak metric to only scale down so far, and
scale both the number and the label.

* Fix lens metric tests

* [Lens] Xy scale type (#42142)

* start adding more suggestions

* remove unused imports

* work on suggestions

* work more on suggestions

* work more on suggestions

* work more on suggestions

* [lens] Allow updater function to be used for updating state (#43373)

* [Lens] Lens metric visualization (#39364)

* clean up tests and add new ones

* remove isMetric

* area as default on time dimension

* fix bug in area chart for time

* Fix axis rotation (#43792)

* remove title form layer

* [Lens] Auto date histogram (#43775)

* Add auto date histogram

* Improve documentation and cleanup

* Add tests

* Change test name

* handle state in app

* fix isMetric usages

* fix integration tests

* fix type errors

* fix date handling on submit

* add new suggestion types

* fix test

* do not suggest single tables

* remove unused import

* [Lens] Fix query bar integration (#43865)

* switch order of appending new string column

* resolve merge conflicts

* [Lens] Clean up operations code (#43784)

* fix merge conflicts

* poc implementation

* highlight currently active suggestion and provide button to submit current choice

* [Lens] Functional tests (#44279)

Foundational layer for lens functional tests. Lens-specific page objects are not in this PR.

* [Lens] Add Lens visualizations to Visualize list (#43398)

* [Lens] Suggestion improvements (#43688)

* fix bugs

* [lens] Calculate existence of fields in datasource (#44422)

* [lens] Calculate existence of fields in datasource

* Fix route registration

* Add page object and use existence in functional test

* Simplify layout of filters for index pattern

* Respond to review feedback

* Update class names

* Use new URL constant

* Fix usage of base path

* Fix lint errors

* [Lens ] Preview metric (#43755)

* format filter ratio as percentage (#44625)

* [Lens] Remove datasource suggestion id (#44495)

* [Lens] Make breadcrumbs look and feel like Visualize (#44258)

* [lens] Fix breakage from app-arch movements (#44720)

* Design cleanup

* PR review comments

* fix tests

* small cleanup

* remove unused import

* [lens] Fix type error in test from merge

* [lens] Fix registration of embeddable (#45171)

* keep references stable if table is just extended and add tests

* changed label for stack/unstack

* fix test

* [Lens] Functional tests (#44814)

Basic functional tests for Lens, by no means comprehensive. This is more of a smokescreen test of some normal use cases.

* [lens] Add Lens to CODEOWNERS (#45296)

* [lens] Fix visualization alias registration

* [lens] Fix usage of EUI after typescript upgrade (#45404)

* [lens] Fix usage of EUI after typescript upgrade

* Use local fix instead of workaround

* fix bug and address reviews

* Fix frame tests
2019-09-19 12:07:39 -04:00
Devin W. Hurley 97fd0e9269
[SIEM] removes awaits from return statements (#46006) (#46134) 2019-09-19 11:11:11 -04:00
Pete Harverson 661f0f725c
[ML] Only enable wizard start real time button when job closed (#46127) (#46132) 2019-09-19 16:07:30 +01:00
Peter Pisljar 944c04c6a2
cleaning up Vis object (#44885) (#46102) 2019-09-19 17:03:25 +02:00
Spencer 683935cb88
[7.x] upgrade to elasticsearch 16.4.0 for 7.4 api (#46099) (#46104) 2019-09-19 07:58:32 -07:00
Mike Côté 68243484d6
Pass alertId and alertInstanceId to templates converting action params (#45803) (#46130) 2019-09-19 10:27:09 -04:00
Mike Côté f90ea7699c
Add cross space tests for alerting and actions (#45892) (#46129)
* Add cross space tests for actions

* Add cross space tests for alerting

* Apply PR feedback
2019-09-19 10:26:56 -04:00
Nathan Reese 7fbc5ad033
[Maps] use EuiPopover instead of mapbox tooltip (#45938) (#46095)
* [Maps] use EuiPopover instead of mapbox tooltip

* update draw tooltip to use EuiPopover, remove mapbox popup css hacks

* use anchor size of 26px to fix positioning calculations

* close tooltip when position is no longer visible

* remove reevaluateTooltipPosition, its no longer needed

* fix problem with map move and hover tooltip location not also moving
2019-09-19 08:15:16 -06:00
Shaunak Kashyap c12e529465
Sort using unix timestamp value (#43162) (#45933)
* Sort using unix timestamp value

* Extract internationalization from react components to function calls.

* Updating Jest snapshots for pipelines table component
2019-09-19 06:16:09 -07:00
patrykkopycinski 51351645e7
Fix Firefox focus state in SIEM tab_navigation (#45996) (#46128) 2019-09-19 15:12:42 +02:00
Marco Vettorello 6283651dc4
Replace Discover chart with elastic-charts (#43788) (#46115)
* use elastic-charts for histogram
* add class accessibility
* specify onElementClick type annotation
* set chartElement tooltip type to Follow
* use moment methods for now annotation logic
* move historam inside directive folder
* remove unused timechart directive
* remove dependency from tsvb brush handler
* remove non-required class to fix tooltip overflow
* change the cursor/crosshair
* fix(ie11): add fixed width for header text
* fix: annotation colors on dark theme
* unpdate click and brush ui functional tests
* move functional tests to percy
2019-09-19 14:46:24 +02:00
Pengcheng Xu 4c2eee1ecf
[Code] Move ctags langserver to language servers in development (#45982) (#46122) 2019-09-19 20:07:51 +08:00
Joe Reuter 07e8b6a9b9
[Graph] EUI-ification of search bar (#45351) (#46119) 2019-09-19 14:06:10 +02:00
Daniil Suleiman 0bd788ce95
Remove extra code from point series functional tests (#45895) (#46010)
* Remove extra code

* Remove unused ids
2019-09-19 14:35:13 +03:00
Shahzad a3f3ef9ef6
[Uptime] Fix/issue 70 display tls certificate expiration (#45613) (#46116)
* update certificate information

* added type

* update unit tests snaps

* Update type for certificate string

Co-Authored-By: Justin Kambic <justin.kambic@elastic.co>

* update ssl certificate component

* updat test snaps

* fix type

* incorporated PR feedback

* more fomatting issues
2019-09-19 15:36:07 +05:00
Dmitrii 429fae95fb
[ML] severity cell with multi-bucket impact support (#46002) (#46111)
* [ML] severity cell with multi-bucket impact support

* [ML] fix type check

* [ML] fix PR remarks

* [ML] replace css classes with Eui components

* [ML] severity cell with multi-bucket impact support

* [ML] fix type check

* [ML] fix PR remarks

* [ML] replace css classes with Eui components

* [ML] set props for eui flex
2019-09-19 12:01:27 +02:00
Kerry Gallagher 1c9d5ea36d
[LogsUI] Ensure 'unknown' setupStatus is handled (#45887) (#46109)
* Ensure 'unknown' setupStatus is handled
2019-09-19 10:44:42 +01:00