Commit graph

1755 commits

Author SHA1 Message Date
Daniil Suleiman
748c18b8f4 [types removal] Remove type from bulk_uploader in monitoring (#32315)
* [types removal] Remove type from bulk_uploader in monitoring

* Remove type from get_settings_collector

* Revert changes
2019-03-05 12:52:32 +03:00
Casper Hübertz
1ef6ebf2c7 [APM] Update contextual data objects and sorting for ECS (#32199)
* Reordering existing data and adding new ECS fields.

* Removed agent

The agent is moved its own object.

* Support 3rd level properties

* Add support for nested properties like `error.custom` and `transaction.custom`

* Bumped fontsize

* Decreased first column min-width

* Updated snapshot

* Update tests

* Fixed translation label

* Reordering existing data and adding new ECS fields.

* Removed agent

The agent is moved its own object.

* Support 3rd level properties

* Add support for nested properties like `error.custom` and `transaction.custom`

* Bumped fontsize

* Decreased first column min-width

* Updated snapshot

* Update tests

* Fixed translation label

* Decreased fontsize

On second thought, the fontsize was too large. Now matches Discover.
2019-03-05 09:31:05 +01:00
Clint Andrew Hall
fff5b70553
[Canvas] Loading Indicator + Elements Panel (#32369)
* [Canvas] Loading Indicator + Elements Panel
2019-03-04 16:50:23 -06:00
Dmitry Lemeshko
325df74261
Improving way to check if pipelines list is loaded (#32370)
* [services/pipeline_list] wait for loadingPipelines is not displayed

* run x-pack-ciGroup2 x20 times

* Revert "run x-pack-ciGroup2 x20 times"

This reverts commit 1fb4077c2c.
2019-03-04 22:09:28 +01:00
Mike Place
4e9b7ef112
Minor change to stack monitoring tooltips (#31855)
* Minor change to stack monitoring tooltips

In the Linux documentation and source code, cgroups are always referred to without
capitalization and should be here as well.

* Update Jest snapshots

* Update more test fixtures
2019-03-04 20:45:23 +00:00
Oliver Gupte
c7f5584358
[APM] Context Tabs jumping height fix (#32351)
* [APM] fixes #18144 by setting the container min-height to the tab with the largest rendered height

* [APM] moved HeightRetainer into its own shared component module
2019-03-04 10:42:37 -08:00
Kerry Gallagher
ce79bb1a7f
Add Infrastructure and Logs Help content (#32118)
Remove old Feedback link component (removed with K7)

Add a HelpCenterContent component

Add HelpCenterContent to Infrastructure

Add HelpCenterContent to Logs
2019-03-04 15:23:59 +00:00
Robert Monfera
765fb5d3ef
Chore: remove exception that impairs user experience on the off chance the condition is met (#32114) 2019-03-03 17:27:13 +01:00
Joe Fleming
8440606b3b
fix: supply a valid axisconfig position default (#32335)
The previous default was an empty string, but empty strings are not valid in the expression. The code ends up using "left" or "top" (depending on the axis), so defaulting to either isn't really a change.

This fixes the following valid expression:

```
demodata | pointseries x=@timestamp y="mean(price)" | plot yaxis={axisConfig max=120}
```

Previously this would fail because the `position` default is invalid unless you specified a value.

<img width="617" alt="screenshot 2019-03-01 12 11 47" src="https://user-images.githubusercontent.com/404731/53660475-33104a80-3c1b-11e9-9a4c-a93116598e28.png">

Now it works as expected:

<img width="536" alt="screenshot 2019-03-01 12 11 03" src="https://user-images.githubusercontent.com/404731/53660440-212ea780-3c1b-11e9-8f4f-7d83a1009fd0.png">
2019-03-01 17:42:30 -07:00
Joe Fleming
7d8dbc669e
Fix: Prevent some needless re-rendering in high-level components (#31958)
In an effort to remove the workpad renaming lag in https://github.com/elastic/kibana/issues/25070, I started hunting down and fixing re-renders that happened with the name change. 

I was hoping this PR would fix the lag, but I've shifted to some other performance issues that have a much larger impact, so this is just a bunch of re-rendering fixes, which come with some performance gains. Here's the breakdown:

- `Workpad`, `WorkpadHeader`, and `FullscreenControl` would always re-render because the hotkey handler function was always re-created
- `Workpad` would re-render when the workpad's name changed
  - We were passing the whole workpad object into the component, so it re-rendered on all sorts of changes
  - Page title updating moved to middleware so the component doesn't need that value
- `AssetManager` would always re-render if the parent re-rendered because it always created a new state value in `mapStateToProps`
- make `Workpad` and `Toolbar` pure, they take no props and this helps stop some re-rendering
2019-03-01 17:18:56 -07:00
Casper Hübertz
55aacd7363 [APM] Adjust responsive flyout sizing (WIP) (#32021)
* [APM] Adjust responsive flyout sizing

The responsive values for the Transaction details need an update in order to contain more content, especially on larger screens, where the flyout just feels a little too slim.

* [APM] exterinalize ResponsiveFlyout styled component, then used it in Transaction and Span flyouts
2019-03-01 16:11:58 -08:00
Justin Kambic
729fdfd654
[Uptime] Improve monitor charts query (#30561)
* Refactor chart querying.

* Fix monitor chart query.

* Refactor several inline computations to helper functions. Improve schema naming.

* Move unit conversion to client, remove bare conversion values.

* Add API tests for monitor charts.

* Add test for conversion function.

* Add type annotations to latest schema additions.

* Fix typo.

* Refactor based on PR feedback, add comments asked for in PR feedback.

* Rename fields in schema, update tests. Extract monitor charts to functional component and add unit test.
2019-03-01 16:05:16 -05:00
Nathan Reese
54bbdbaedb
[Maps] Map embeddable (#31473)
* [Maps] embeddable

* fix embeddable registration

* get embeddable to render

* render map embeddable

* support filter pills on dashboard

* fix layerName error

* update getBoundsForFilters to not record bounds request in inspector

* set isReadOnly

* fix bug where different states are sharing same inspectorAdapters instance

* populate indexPatterns so container has index patterns for type ahead and filter bar

* pass refreshConfig from container to map store

* add functional test verifying index patterns passed to container

* remove data.json files commited by mistake

* add functional test ensuring inspector adaptors are not shared between embeddables

* add functional tests for filters getting passed to embeddable

* remove embeddable dashboard from web logs sample data saved objects

* add slash to edit path

* fix typo

* pass previous query state on reload, add functional tests to verify reload and refresh timer

* remove unnecessary check in getFilters

* review feedback from thomasneirynck

* fix resize bug

* remove animationFrame from resize callback
2019-03-01 12:06:46 -07:00
Chris Davies
079834af25
Remove unused server functionality from the interpreter (#32133) 2019-03-01 10:31:04 -05:00
Pete Harverson
46cc8469fd
[ML] Adds missing applyAsync to advanced job wizard page (#32186) 2019-03-01 10:03:38 +00:00
Jake Landis
c2f89f4ca8 Logstash central management typeless API (#30546)
This commit adopts Elasticsearch's typeless API for Logstash
central management.

Relates: https://github.com/elastic/elasticsearch/issues/3863
2019-03-01 11:46:26 +03:00
Spencer
369bef316a
[eslint] require final newline (#32265)
We have had `insert_final_newline = true` in our `.editorconfig` file since April 2015, but never validated it with eslint. I'm a little tired of extra changes showing up in PRs because some people use editors which respect the `.editorconfig` file and some don't, so I figured we might want to enable the rule in eslint so that the can be autofixed.

Votes requested please :)
2019-02-28 18:01:29 -08:00
Bill McConaghy
2efe09afb5 Fix Index Management bug in which the "Show system indices" toggle turned off other toggles (#32258) 2019-02-28 15:47:12 -08:00
Oliver Gupte
aefa169a68
[APM] fix inconsistencies in ESC type migrations (#32097)
* [APM] fix inconsistencies in ESC type migrations

* [APM] audit ESC schema types and removed unused fields

* [APM] removed unused line property type from IStackFrameBase
2019-02-28 13:45:11 -08:00
Bill McConaghy
55ecd79b41
disabling ccr and remote clusters when index mgmt is disabled (#32203)
* disabling ccr and remote clusters when index mgmt is disabled

* addressing PR feedback
2019-02-28 13:56:01 -05:00
Josh Dover
021acaa2e6
Remove types from Esqueue (#32146) 2019-02-28 12:29:30 -06:00
Søren Louv-Jansen
aa71146252
[APM] Convert most of remaining js to ts (#32115)
* [APM] Convert most of remaining js to ts

* Fixes for distribution component

* Make `page` and `sort` optional

* Add Server definition from hapi
2019-02-28 17:54:57 +01:00
Mikhail Shustov
8c6b1e5908
Update Typescript to the latest version (#32063)
* bump typescript version to 3.3.3333

* fix tests after updating TS version

* suppress type errors until they fixed appropriately

* address comments

* add type def for UnconnectedKibanaLink

* remove fix @ts-ignore

* fix snapshot test. provide displayName
2019-02-28 17:21:47 +01:00
Aleh Zasypkin
0835cd30ca
Introduce Elasticsearch service. (#28344) 2019-02-28 17:22:07 +02:00
Aleh Zasypkin
b8c9d0afa0
Get rid of Handlebars support in i18n tools. (#32190) 2019-02-28 17:16:59 +02:00
Mikhail Shustov
5fc7addac5
Update jest to v24 (#31825)
* udpate jest, jest-cli, @types/jest to v24

* fix type error in kibana-i18n package

* return serivce explicitly to fix typings

* add explicit never

* suppress typings errors

* update jest versions in x-pack

* make tests in x-pack more robust and fix incompatibility

* suppress CallCluster mock typings

Mock interface doesn't match CallCluster. Requires
additional work

* x-pack. resolve other typing conflicts

* remove unused types/jest

* fix snapshots

* restore mocks after jest.spyOn

* remove outdated definitions for jest

* cleanup x-pack package.json and update @types/jest

* fix tests merged from master

* updated yarn.lock and log errors for scripts/type_check

* This commit fixes error in TS, which failed on parsing the file.

* suppress type errors from master

* jest-cli is devDep
2019-02-28 13:26:16 +01:00
Pete Harverson
f2acacb237
[ML] Fix formatting of values for time of day or week anomalies (#32134) 2019-02-28 09:32:32 +00:00
Joe Fleming
acd762d8ae Fix: don't initialize workpad from WorkpadApp (#32163)
Closes https://github.com/elastic/kibana/issues/32161

All the elements are loaded in the router, so loading the from the component just duplicates the work.

This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now.

### Stats

Workpad | Previous load time | PR load time
-- | -- | -- 
Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds
Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds

*Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
2019-02-27 22:00:11 -06:00
Robert Monfera
0530dfb880
Usability: larger minimum element size (#32106) 2019-02-27 20:03:08 +01:00
Alison Goryachev
6e77a7cb03
fix client validation for rollup index name (#32067)
* fix client validation for rollup index name

* remove wrapper object in constants file

* move support for "*" illegal character to common constants file
2019-02-27 13:08:37 -05:00
Chris Cowan
aeb5f7ba7a
Fixes #32022 - Fix table to display name instead of ID (#32051) 2019-02-27 07:38:35 -07:00
Walter Rafelsberger
db700ffcef
[ML] Fixes restoring table interval selection from appState. (#32056)
Fixes a regression introduced in #31692. The table interval selection wasn't properly restored from `AppState` because of a mismatch in the expected object structure.
2019-02-27 12:26:51 +01:00
Tim Roes
9d77205191
Cleanup unused code (#32018) 2019-02-27 10:18:35 +01:00
Oliver Gupte
5949b004b0
[APM] Trunctating DB statements in span flyout (#31674)
* [APM] closes #18114 by trunctating db statements in span flyout by default but allowing toggle between preview and full content.

* Made component more tolerant of changes in props/children by checking for clipping on each update

* [APM] simplify component by enforcing the prop previewHeight is a number and use it for calculation
2019-02-26 16:34:32 -08:00
Tim Sullivan
87bd8913bd
[Reporting] Fix error handling in process request failed (#31861)
* [Reporting] Fix error handling in process request failed

- Callback param is a Puppeteer `Request` object, not Error

* unrelated prettier
2019-02-26 16:48:35 -07:00
Joel Griffith
db2e92012b
Fixes data points on maps not showing up in reports (#31949)
* Fixes data points on maps not showing up in reports
2019-02-26 10:30:25 -08:00
Justin Kambic
c067a779b0
Switch uptime internationalization from i18n provider to context. (#31601) 2019-02-26 12:40:26 -05:00
Chris Cowan
32dbb82bf8
[Infra UI] Change waffle map node to button for accessibility (#31764)
* Fixes #28158 - Change waffle map node to button for accessibility

* intl-izing the aria-labels; changing size to eui
2019-02-26 10:09:44 -07:00
James Gowdy
f89faec278
[ML] Changing job wizard query to use match_all (#32008)
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
2019-02-26 16:51:17 +00:00
Jen Huang
50c7da3360
Fix common license checker issues (#31339)
* Fix hardcoded plugin name and license modes in common license checker

* Fix licensePreRoutingFactory scope issues

* PR feedback adjustments

* Use minimum license string instead of array of valid license
* Pass plugin name instead of ID for UX
* Return license status instead of `showLinks` and other flags
* Adjust factory closure for readability

* Fix test

* Additional PR feedback:

* Move license status constants to `/common`
* Internationalize plugin names that are passed to check license, and its error messages
* Remove `isAvailable` flag, change pre-routing logic to use `LICENSE_STATUS.VALID` instead
* Change constant `INACTIVE` to `EXPIRED`
* Convert check license test from mocha to jest

* Fix test
2019-02-26 08:29:47 -08:00
Søren Louv-Jansen
c68cc7890a
[APM] Improve license check (#31923)
* [APM] Improve license check

* Remove unneeded strings

* Add translations

* Use React.FunctionComponent

* Update copy
2019-02-26 17:09:34 +01:00
Jonathan Budzenski
25e7b077c3
remove aws-sdk (#31002)
* rm aws-sdk

* remove references

* readd gitignore

* rm dlls/

* gitignore
2019-02-26 10:01:11 -06:00
Bill McConaghy
a382b49744
fixing issues with maximum documents and maximum size being set (#31998)
* fixing issues with maximum documents and maximum size being set

* removing defaults from ES policy load and removing unneeded propTypes

* fixing react warnings about controlled -> uncontrolled

* fixing tests

* more fixes for react controlled -> uncontrolled errors

* better fix for react warnings through empty default phases

* removing unused translation

* removing unnecessary async/awaits in onChange handlers
2019-02-26 10:23:11 -05:00
Alexey Antonov
9907f48e3b
Rollup support for TSVB (#28762)
* Added a feature of rollup search on the UI side

Signed-off-by: Alexey Antonov <alexwizp@gmail.com>

* Rollup Feature - initial commit

* Revert "Added a feature of rollup search on the UI side"

This reverts commit 9568b0970b16f5102f50b748bb4d691a8612c2c2.

# Conflicts:
#	src/legacy/core_plugins/metrics/public/components/index_pattern.js

* Remove the 'label' property from the search strategies

* Changed search by strategy from the last

* add single search request

* rollup_search_strategy add base implementation of isViable method

* rollup_search_strategy add base implementation of isViable method -fix

* Changed requests due to search request type

* refactoring of import Base classes / remove '../../../../../../

* remove extra await

* rollup_search_strategy. Refactoring of isRollupJobExists method

* remove question

* Add support of annotations and table data

* skeleton for adding Search Strategy restrictions

* Add rollup search capabilities

* apply search strategy for annotations request

* set fields capabilities for rollup strategy

* add timezone, interval into SearchCapabilities

* Add fields from capabilities

* add timezone, interval into SearchCapabilities

* fix default timezone

* Merging of two Rollup Jobs was removed

* move getFieldsForWildcard to searchStrategy

* Fix TSVB search requests should have a timeout

# Conflicts:
#	src/legacy/core_plugins/metrics/server/lib/vis_data/get_annotations.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/series/get_request_params.js

* Add unit test

* apply getEsShardTimeout for annorations/get_request_params,  series/get_request_params

* rename metrics -> tsvb

* search_strategies_register refactoring: move 'add' method from class

* Add merge rollup capabilities with fields

* Add merge rollup capabilities with fields - small fixes

* Add support of 'Everything' aggregation for Rollup Search

* Return back metrics plugin

* remove 'metrics' from the X-pack\rollup require

* Fix test cases

* fix broken test: fail: "apis InfraOps GraphQL Endpoints metrics should basically work"

* rollup search - split by terms is not working

* Add count metric

* /get_bucket_size.js. Add support of 'auto' interval, Add support of gte intervals  e.g.:  >=1m

* fix build_request_body test

* [Rollup] [Phase 1] Error handling - rollup search errors should be more user friendly

* [Rollup] [Phase 1] Table View - research the query to ES - sorting is not wokring

* Merge #26006 into rollup

# Conflicts:
#	src/legacy/core_plugins/metrics/server/lib/vis_data/annorations/build_request_body.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/get_annotations.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/get_series_data.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/get_table_data.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/request_processors/annotations/query.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/series/__tests__/build_request_body.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/series/build_request_body.js
#	src/legacy/core_plugins/metrics/server/lib/vis_data/series/get_request_params.js

* Add table view support

* fix broken build

* fix broken build

* [Rollup] [Phase 1] - write new tests  (rollup_search_request, rollup_search_strategy)

* [Rollup] [Phase 1] - write tests for rollup_search_capabilities

* Add test on default_search_capabilities, abstract_search_strategy, search_strategies_register

* Add test cases for search_requests folder

* [Rollup] [Phase 1] - write tests for rollup_search_strategy

* FIx broken build

* remove todo

* fix calculation of interval value for rollup search

* add unit tests

* Remove default exports

* fix PR comments

* fix calendar intervals
2019-02-26 18:08:57 +03:00
Alison Goryachev
8fc9d90744
fix Platinum features link in license management (#31945)
* fix Platinum features link in license management

* move external license links to constants file
2019-02-26 08:01:22 -05:00
Thomas Neirynck
698e46dabc
[Maps] Show joined term metrics in tooltip (#31826) 2019-02-26 03:31:14 -05:00
Sébastien Loix
baf46c9079
[Rollup] Unit test for detail panel (#31690) 2019-02-26 06:35:10 +01:00
Thomas Neirynck
79a26aef36
Ensure any existing layers get cleared when previewing a new one (#31973) 2019-02-25 23:05:15 -05:00
Catherine Liu
a037874e4a
[Canvas] Fixes filter clearing on undo/redo (#31859)
* Added check to reset filters in 'setExpression'

* Removed filter reset from filter renderers' onDestroy handler

* Cleaned up setExpression

* Added TODO
2019-02-25 16:26:31 -07:00
Jonathan Budzenski
01c8627622
[es] scripts.inline -> scripts.source (#30457) 2019-02-25 16:34:47 -06:00