Commit graph

282 commits

Author SHA1 Message Date
Tim Sullivan 80833cde95
Remove /api/_xpack/usage and /api/_kibana/v1/stats (#20800)
/api/_xpack/usage was added as a target for 6.4.0 but it will not be
used. Instead, the /api/stats response will include usage info on
everything that gets registered with the usage service in
/src/server/usage

/api/_kibana/v1/stats is a GET API that was added in 6.2, during a point
where we thought providing usage stats through a public API would be OK
for capturing internally, with the benefit of having it be visible.

However, we've pivoted away from that idea because it doesn't line up
too well with the existing flow of data, where usage stats are combined
with the "Kibana stats" such as process uptime and number of requests.
We want to shift how we collect stats from Kibana, but it will be
gradual. It might be a while before we have an architecture that makes
sense for a standalone public API for the usage stats

This endpoint was never documented, and isn't used anywhere in the code.
It does incur a maintenance cost though.

Therefore, instead of waiting for a next major version to remove this
API, I'm removing it for 6.4. It will be marked in the release notes as
a breaking change. Since it was never documented, it should not provide
a problem.
2018-07-19 13:46:52 -07:00
Tim Sullivan f8bdc7d22a
[Test/Cleanup] Remove console.log (#21002) 2018-07-19 13:42:47 -07:00
Bill McConaghy 35dade2d3c
Reactify users roles (#20739)
* partial progress on reactifying users

* progress on EUIfication of users screen

* removing Angular stuff

* adding data-test-subj="passwordConfirmationInput"

* removing data-test-subj="userFormEmailInput" refs from tests

* fixing selector for role assignment

* some functional test fixes

* fixing some functional tests

* fixing last functional test

* removing stray console log

* fixing warnings

* attempting to fix flaky test

* trying again to fix flaky test

* PR feedback

* PR feedback

* fixing issue where form tried to submit

* adding sleep to allow user to load

* Design edits

Mainly adding wrapper EUI page elements, but also shifted around form elements.

* Fixed console error and added responsive prop to table

* addressing PR feedback

* A few more PR feedback

- Fixed alignment of table
- Removed the tooltip from the lock icon and placed the description inline.
- Changed delete button to an empty button

* addressing more PR feedback

* adding email field back in

* adding back username validation

* restoring original error message

* fixing dumb null error
2018-07-19 16:40:12 -04:00
James Gowdy d1b667512c
[ML] Better handling of job request timeouts (#20985) 2018-07-19 16:39:54 +01:00
James Gowdy 3d06046295
[ML] Removing _feature and _ignored from detector modal (#20984) 2018-07-19 16:39:42 +01:00
James Gowdy 7a84e7871e
[ML] Changing edit job icon (#20935) 2018-07-19 08:21:10 +01:00
Tim Sullivan 274617de59
Stats API: implement the "kibana status" spec from the Monitoring data model for stats (#20577)
* [Stats API] Set API field names per spec

* fix jest tests

* fix api integration test

* trash the original metrics collector

- constantly accumulating stats over time does not align with the existing behavior, which is to reset the stats to 0 whenever they are pulled

* move some logic out of the collector types combiner into inline

- change the signature of sourceKibana

* Make a new stats collector for the API

- to not clear the data when pulling via the api
- fetching is a read-only thing

* isolate data transforms for api data and upload data

* no static methods

* remove external in bytes

* remove the _stats prefix for kibana and reporting

* update jest test snapshot

* fix collector_types_combiner test

* fix usage api

* add test suite todo comment

* reduce some loc change

* roll back mysterious change

* reduce some more loc change

* comment correction

* reduce more loc change

* whitespace

* comment question

* fix cluster_uuid

* fix stats integration test

* fix bulk uploader test, combineTypes is no longer external

* very important comments about the current nature of stats represented and long-term goals

* add stats api tests with/without authentication

* fix more fields to match data model

* fix more tests

* fix jest test

* remove TODO

* remove sockets

* use snake_case for api field names

* restore accidental removal + copy/paste error

* sourceKibana -> getKibanaInfoForStats

* skip usage test on legacy endpoint

* fix api tests

* more comment

* stop putting a field in that used to be omitted

* fix the internal type to ID the usage data for bulk uploader

* correct the kibana usage type value, which is shown as-is in the API

* more fixes for the constants identifying collector types + test against duplicates

* add a comment on a hack, and a whitespace fix
2018-07-18 16:37:04 -07:00
James Gowdy 3c74d30bee
[ML] Adding close jobs menu item (#20927)
* [ML] Adding close jobs menu item

* changing icon

* updates based on review

* adding extra check for close failure

* adding extra guard against missing response
2018-07-18 17:47:44 +01:00
Walter Rafelsberger 651013b89c
[ML] Moves tooltip of info icon to top to avoid overlapping with corresponding form fields. (#20874) 2018-07-18 14:20:05 +02:00
CJ Cenizal a36b87ad3e
Add SearchStrategyRegistry and defaultSearchStrategy to support existing search behavior, and integrate it with CallClient. (#20497)
* Add SearchStrategyRegistry and defaultSearchStrategy to support existing search behavior, and integrate it with CallClient.
* Move fetch param logic from CallClient into defaultSearchStrategy.
* Move defaultSearchStrategy configuration into kibana plugin via search uiExport to avoid race conditions with other plugins.
* Add call-out react directive.
* Show error in Discover if user tries to access a rollup index pattern without the right search strategy. Sentence-case copy in field chooser.
* Add tests with multiple searchStrategies and fix errors in logic.
2018-07-17 18:49:46 -07:00
Stacey Gammon e90f652875
Bump eui (#20774)
* bump eui

* Fixed breaking `EuiPage` changes

Mainly adding `EuiPageBody`’s where there were none

* bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots

* bump eui

* bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots

* Update jest snapshots in xpack
2018-07-17 19:28:07 -04:00
Hendrik Muhs a0a22cfc12
[Monitoring/ML] add number of forecasts to monitoring overview (#20758)
Add forecasts (Number of forecasts for an ml jobs) as column to the ML Jobs monitoring page. Related to: elastic/elasticsearch#31647
2018-07-17 16:41:19 +02:00
James Gowdy 492fb01f8c
[ML] Better error notifications in jobs list (#20880)
* [ML] Better error notifications in jobs list

* removing test data
2018-07-17 14:27:28 +01:00
Pete Harverson 6939f5073c
[ML] Adds page to ML Settings for viewing and editing filter lists (#20769)
* [ML] Add page to ML Settings for viewing and editing filter lists

* [ML] Edits to Filter Lists Settings page following review
2018-07-17 09:47:26 +01:00
Felix Stürmer 4b255e9fe9
Upgrade typescript to 2.9.2 (#20757)
This upgrades TypeScript to version 2.9.2. My main motivation is the support for generic type arguments in JSX elements and tagged templates (e.g. for `styled-components`).

Problems arising from breaking changes in the new TypeScript version have been mitigated by:

* setting the `keyofStringsOnly` option until impacted code has been
  future-proofed
* Restricting some joi-related generics

See the [release notes](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html) for details.

Some follow-up tasks should be:

* Update EUI to support the new `keyof` behaviour
* Update new platform TypeScript code to support new `keyof` behaviour
* Remove `keyofStringsOnly` setting
2018-07-17 00:31:05 +02:00
Tim Sullivan 8ba773a498
Add Beats module and input info to Telemetry (#20648)
* fix metrics field name (stats)

* add state info

* add module name count

* use a set for the unique hosts instead of a map

* fix getting beats_state info

* fix unit test

* processBeatsStatsResults and processBeatsStateResults
2018-07-16 12:57:26 -07:00
James Gowdy 54cf83d360
[ML] Jobs list bug fixes (#20823) 2018-07-16 16:33:59 +01:00
Tyler Smalley 46bacc6c64
Workaround for yarn interdependency conflicts (#20805)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-07-16 07:42:49 -07:00
James Gowdy 6ddc9db376
[ML] Removing hardcoded datafeed ID in jobs list (#20815) 2018-07-16 12:44:59 +01:00
Chris Roberson 276f08ccbb
[Monitoring] Capitalize the license type (#20683)
* Capitalize the license type in monitoring

* Revert "Capitalize the license type in monitoring"

This reverts commit 38ad3a516d.

* Pass in the type capitalized

* Revert "Pass in the type capitalized"

This reverts commit 6a05bb12f3.

* Capitalize type in license status directly so consumers do not need to worry about it
2018-07-13 16:24:57 -04:00
Tyler Smalley cca09311c0
Skip flaky Monitoring Shard Allocation Per Node tests (#20138)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-07-13 08:34:41 -07:00
Aleh Zasypkin 34a44289aa
[Reporting] Blacklist Transfer-Encoding HTTP header for PDF report generation. (#20755) 2018-07-13 15:51:13 +03:00
Casper Hübertz ecefab55e6
[APM] Add section titles to span detail modal (#20717)
* Adding fontSize from variables

* SectionHeader style added

* Adding section headers

Needed titling for DB statement and Stacktrace on the page

* Pluralization

* Adding fontSize variable

* Creating new header title style

* Moving title into Stacktrace container

* Updated snapshots
2018-07-13 09:15:28 +02:00
Tiago Costa b142f80d7d
Match chalk dependency version on kibana with the one used on x-pack (#20621)
* chore(NA): match chalk dependency version on kibana with x-pack to ^2.3.2.

* chore(NA): bump chalk version dependencies and update lock files.
2018-07-13 00:26:57 +01:00
Stacey Gammon 826758c78c
Turn reporting tests back on (#20634)
* unskip reporting tests

* Focus only on flaky test suite and run 10x

* Revert "Focus only on flaky test suite and run 10x"

This reverts commit a6616b1140c29d8d3f13666d20ae94db9a97267f.
2018-07-12 11:27:18 -04:00
Søren Louv-Jansen 423a961a1f
Redux should update after timefilter has changed (not before) (#20719) 2018-07-12 17:17:14 +02:00
James Gowdy da1acd0367
[ML] removing unnecessary privileges provider (#20671) 2018-07-12 09:31:23 +01:00
Walter Rafelsberger 65081ccdce
[ML] Ignore mouse events on pseudo element. (#20668)
The pseudo-element agg-type-select-wrapper::after which represents the dropdown's arrow didn't react to the click element of the dropdown itself. pointer-events: none is now added to the pseudo-elements to let the click pass through to the element intented to react on the click.
2018-07-12 09:58:32 +02:00
Søren Louv-Jansen 32505afd3d
Ensure timefilter updates correctly (#20677) 2018-07-11 21:35:45 +02:00
Walter Rafelsberger 0dbb819563
[ML] Fixes a regression bug which made the progress bar invisible. (#20618)
Fixes a regression introduced by #19794. This PR added a 5px top margin to the affected charts. The hard coded bottom margin of the progress bars wasn't adjusted accordingly so the progress bars ended up being hidden behind the actual chart. This PR fixes the problem by taking the chart's top margin into account for progressBarMarginBottom.
2018-07-11 15:21:39 +02:00
Walter Rafelsberger 8baf89006c
[ML] Migrate ml-info-icon to React/EUI. Fixes related IE11 error. (#20610)
- Migrates the ml-info-icon directive to use React/EUI. This fixes a related error in IE11.
- For now a hard-coded override is used to size the icon because EuiIconTip doesn't pass on the size attribute to the wrapped EuiIcon directive.
- The (simple) React component is kept within the directive's, because previously the directive template also wasn't in a separate file.
- Removes the unused mlJsonTooltipService angular service.
2018-07-11 14:27:30 +02:00
gchaps 739139ec45
[COPYEDIT] Management: Fixes capitalization in Extend your trial (#20627)
* [COPYEDIT] Management:  Fixes capitalization in Extend your trial

* [DOCS] Updated snapshot file
2018-07-10 13:30:50 -07:00
Søren Louv-Jansen bf3aa086c9
[APM] Add kuery to apm ui (#19469)
* Add Kuery to APM UI

* Format bool queries

* Fix test

* Add min-height

* Updated css to vars

* Added loading indicators

* Update breadcrumbs

* Update Discover links

* Add search button

* Fix readcrumb test

* Remove debounce

* Fix “undefined” kuery

* Handle missing index pattern

* Fix race condition in data fetching

* Fix legacy url encoding

* Filter out field-suggestions starting with "span*"

* Convert KuiTable to EuiTable for service overview

* Convert KuiTable to EuiTable for transaction overview

* Convert KuiTable to EuiTable for error overview

* Updated empty state messages

* Bump CI jo

* updated snapshots

* Add beta tooltip and update to EuiSearch

* Fixed issue with focus

* Submit when clicking search button

* Submit when clearing input

* Handle missing index pattern

* Remove query from spans
2018-07-10 21:00:54 +02:00
Tyler Smalley 201afb709e Bump yarn.lock
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-07-10 09:15:43 -07:00
Nathan Reese 2084842e36
Add _bulk_create endpoint to /api/saved_objects (#20498)
* add _bulk_create rest endpoint

* document bulk_create api

* provide 409 status code when conflicts exist

* add overwrite and version to documenation

* clean up assert statements and 2 places where bulkCreate is getting used with new output

* properly stub bulkCreate return

* remove version of documenation example
2018-07-10 07:38:39 -06:00
archana c5432f27ba
[Tests] Run es from snapshot locally in xpack (#20585) 2018-07-10 05:25:55 -05:00
Tim Roes cb5ee01c6a
Increase prettier line width to 100 (#20535)
* Increase prettier line width to 100

* Fix packages JS prettier

* Change style guide to 100 width

* Fix line-width in latest master changes
2018-07-09 22:50:37 +02:00
CJ Cenizal 49139d2218
Replace uses of Notifier with toastNotifications in Watcher. (#20538) 2018-07-09 13:29:48 -07:00
James Gowdy 646f1d7f2c
[ML] disabling time range selector on jobs list (#20563) 2018-07-09 18:05:18 +01:00
Tim Sullivan c043788c97
[Telemetry] move x-pack/monitoring collector classes to src/server/usage (#20248)
* [Monitoring/Telemetry] Move Usage service from Monitoring to Kibana core

* fix tests

* fix reporting integration

* roll back more diffs

* roll logger into bulk uploader to remove file duplication

* fix xpack usage api

* subclass constructor is not needed

* collectorSet has factory methods for collector object creation

* fix reporting usage jest test
2018-07-09 09:32:02 -07:00
Justin Kambic d4d5fe1368
[PipelineViewer] Test PipelineViewer sub-components (#20329)
* Rename config view to PipelineViewer.

* Decouple CollapsibleStatement from if/else using props.children.

* Add tests for PipelineViewer component.

* Test Metric component.

* Test CollapsibleStatement component.

* Test PluginStatement component.

* Test Queue component.

* Test StatementListHeading component.

* Test StatementSection component. Move StatementList component to dedicated file.

* Test StatementList component.

* Test Statement component.

* Run prettier on edited files.
2018-07-09 11:51:52 -04:00
James Gowdy d44840cd19
[ML] Adding jobs stats bar to top of jobs list (#20527)
* [ML] Adding jobs stats bar to top of jobs list

* unsetting update function

* changing node variable name

* small refactor

* using props copy of `updateJobStats`

* adding proptypes

* adding fixed height
2018-07-09 14:59:10 +01:00
Chris Davies e34dbd0817
Fix issue w/ running chromium headless over http (#20528)
Remove the referrer header from report requests.
2018-07-06 15:30:10 -04:00
Nathan Reese 61d7b918c3
Upgrade to EUI 1.1.0 (#20411)
* Upgrade to EUI 1.0.1

* upgraded to eui 1.1.0

* fix setInspectorTablePageSize function in functional tests

* better comment about basic table pagination buttons
2018-07-06 12:15:55 -06:00
CJ Cenizal 8b8e5a0a8d
Convert various uses of notifier to toastNotifications. (#20420)
* Add MarkdownSimple component.
* Replace Context use of notifier with toastNotifications.
* Replace field.js use of notifier with toastNotifications.
* Replace State use of notifier with toastNotifications.
* Replace reporting use of notifier with toastNotifications.
* Convert Logstash to use toastNotifications.
* Convert Security to use toastNotifications.
2018-07-06 08:33:04 -07:00
James Gowdy d9fe439671
[ML] Using kibana's auto-refresh for jobs list (#20496)
* [ML] Using kibana's auto-refresh for jobs list

* better auto refresh management

* fixing typo

* increasing default interval

* variable rename

* kill interval on page change

* updating comment

* adding minimum refresh interval

* correctly clearing the interval
2018-07-06 11:32:49 +01:00
James Gowdy c6ba696127
[ML] Adding permission checks to jobs list (#20487)
* [ML] Adding permission checks to jobs list

* adding comment

* removing horizontal line

* changes based on review
2018-07-06 08:57:54 +01:00
James Gowdy 9d57acc867
[ML] Allow job cloning via wizards (#20227)
* [ML] [WIP] Allow job cloning via wizards

* updating clone link

* removing-created-by-data-when-editing-job

* removing commented out code

* changes based on review
2018-07-04 16:51:23 +01:00
James Gowdy c4756b183f
[ML] Adding filter bar to jobs list (#20415)
* [ML] Adding filter bar to jobs list

* fixing page index when filtering

* refreshing job selection after actions have happened

* adding job counts to groups

* catching multi-select start datafeed errors

* style tweaks

* more style tweaks

* changes based on review

* refactoring search logic
2018-07-04 13:57:25 +01:00
Søren Louv-Jansen 90528194da
[APM] ML integration (#19791) 2018-07-04 14:18:19 +02:00