Shahzad
81bcaed7ae
update local ( #55177 )
2020-01-18 00:24:34 +01:00
Ryland Herrick
27103bd4a5
[SIEM] Fix mocks for kibana context ( #54996 )
...
* Use our internal uiSettings mock in all context mocks
We were previously only using our internal uiSettings mock (which
returns real values) in our TestProviders component, as
all tests either needed:
* specific mocks, in which case we'd call jest.mock() ourselves
* broad mocks, for which platform's kibana_react mocks were usually
sufficient
However, a recent addition in the Timeline component added a usage of
uiSettings that could not use the default mock.
With this change, one can either jest.mock('lib/kibana') or use the
TestProviders wrapper to get real values for UI settings in test.
* Remove production code guarding against tests
This coalescence was due to the service not being properly mocked in
test, which is now fixed.
2020-01-17 16:28:38 -06:00
Joel Griffith
e8b859bf2f
[Reporting] Fix map tiles not loading by using Chrome's Remote Protocol ( #55137 )
...
* WIP Fixing map tiles and such
* Small comment and importing map from dolash
* Better destructuring and comments
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-17 12:18:24 -08:00
Alexey Antonov
801302e3ce
[Data Plugin] combine autocomplete provider and suggestions provider ( #54451 )
...
* [Data Plugin] combine autocomplete provider and suggestions provider
Closes : #52843
* [Data Plugin] combine autocomplete provider and suggestions provider - add skeleton for SuggestionsProvider
* autocomplete_provider -> autocomplete
* value_suggestions.ts - change getSuggestions method
* remove suggestions_provider folder
* fix PR comments
* fix PR comments
* fix CI
* fix CI
* getFieldSuggestions -> getValueSuggestions
* update Jest snaphots
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-17 22:42:51 +03:00
Mike Côté
9c2d778d1c
Fix enable API to schedule task after alert is updated ( #55095 )
2020-01-17 10:48:48 -05:00
Pete Harverson
d740ec34b3
[ML] Accessibility fix for structural markup on table rows ( #55075 )
...
* [ML] Accessibility fix for structural markup on table rows
* [ML] Fix type error on Transforms table cell for scope property
2020-01-17 13:48:31 +00:00
Alison Goryachev
102bd2bcda
[Mappings editor] include/exclude fields only support custom options ( #54949 )
2020-01-17 08:22:17 -05:00
Walter Rafelsberger
f13adfab5b
[ML] Single Metric Viewer: Fix time bounds with custom strings. ( #55045 )
...
Makes sure to set bounds via timefilter.getBounds() again and not infer directly from globalState to correctly consider custom strings like now-15m.
2020-01-17 13:16:02 +01:00
Daniil Suleiman
3e46060854
[Vis: Default editor] EUIficate and Reactify the sidebar ( #49864 )
...
* EUIficate the sidebar
* Create a state reducer and a state context
* Create an editor context and actions
* Improve types
* Apply aggs reordering
* Fix functionality
* Improve types
* Fix sub_agg changes
* Remove legacy dependencies
* Watch dirty state
* Fix dirty state changes
* Update actions and reducers
* Handle keyboard submit
* Apply editor form validation
* Remove fancy forms
* Update validation
* Use embeddable instead of visualize loader
* Add auto apply behavior
* Remove legacy styles
* Remove the sidebar
* Restrict responsive to the bottom_bar
* Upgrade @elastic/eui to v14.10.0
* Replace EuiBottomBar with EuiControlBar
* Get rid of mutations in control vis
* Revert "Upgrade @elastic/eui to v14.10.0"
This reverts commit 2cd86c51d2
.
* Replace bottom bar with a control panel for sidebar
* Replace selectors
* Use editor resizer
* Apply selectors
* Change selectors
* Fix sub agg change values
* Add collapse button
* Fix tests
* Get rid of editor editor_state_context, simplify the code
* Fix jest tests, update snapshots
* Fix types
* Moving collapse button to right of index pattern
* Tweaks bottom buttons
* Moved Vega buttons so they don’t scroll away
* Fix responsiveness
* Resolve UI comments
* Fix console resizer
* Update dev docs
* Bail out of additional render in metrics and axes
* Apply performance optimizations for metrics and axis panel
* Remove unused translations
* Use debounce when autoapply enabled
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-17 14:01:44 +03:00
Sébastien Loix
92b5f78f4f
[Mappings editor] Fix cannot set boolean value for "null_value" param ( #55015 )
2020-01-17 12:33:31 +05:30
Garrett Spong
24df3a92e1
[SIEM] Adds support for apm-* to the network map ( #54876 )
...
## Summary
Resolves https://github.com/elastic/kibana/issues/52297 , https://github.com/elastic/kibana/issues/52565
To improve the display of APM data within SIEM (specifically the `HTTP Table` and `Network Map`), this PR adds `apm-*-transcation*` to `siem:defaultIndex`, and additional support for showing `client`/`server` layers on the `Network Map` when a matching `apm-*` index pattern is present.
The map now supports pattern matching when checking for available Kibana Index Patterns, and so matches `apm-*-transcation*` -> `apm-*` (if exists). Additionally, the map config was updated to generate layers for client/server geo fields (instead of the usual source/dest) since these are the fields Transactions use.
![image](https://user-images.githubusercontent.com/2946766/72573225-2a038880-3882-11ea-9590-a545d726dbf9.png )
<img width="1214" alt="Screen Shot 2020-01-14 at 18 22 11" src="https://user-images.githubusercontent.com/2946766/72407120-bcd5e300-371b-11ea-90cc-a0714320a59c.png ">
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~
- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )
- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials
- Will work with @benskelker on updating the maps docs
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~
### For maintainers
- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
2020-01-16 17:13:39 -07:00
Tim Sullivan
cfbd095841
[Reporting] Define shims of legacy dependencies ( #54082 )
...
* simplify serverfacade definition
* simplify requestfacade definition
* use the shim
* makeRequestFacade
* requestFacade
* import sorting
* originalServer
* reduce loc change
* remove consolelog
* hacks to fix tests
* ServerFacade in index
* Cosmetic
* remove field from serverfacade
* add raw to the request
* fix types
* add fieldFormatServiceFactory to legacy
* Pass the complete request object to sec plugin
* Fix test
* fix test 2
* getUser takes a legacy request
* add unit test for new lib
* add getRawRequest to pass to saved objects method
* update test snapshot
* leave a TODO comment for type import
* variable rename for legacy id
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 15:15:25 -07:00
Thomas Neirynck
2b873a740f
[Maps] Support styles on agg fields with _of_ in name ( #54965 )
2020-01-16 16:59:13 -05:00
Aaron Caldwell
83b0062836
Remove xpack_main requirement, it's no longer in use ( #55060 )
2020-01-16 14:44:18 -07:00
John Dorlus
dde9e9b7b0
Fix Snapshots Policies Alignment Issue in IE11 ( #54866 )
...
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers.
* Restored <EuiFlexItem> but added grow=false to properly align icons.
2020-01-16 16:33:12 -05:00
The SpaceCake Project
bc69d6e604
first rule cuts ( #54990 )
...
* rule cuts
first pass at rule cuts, 21 deelted rule files, no adds, no changes.
* Update index.ts
* index regen
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 15:49:26 -05:00
Corey Robertson
78ec55e6fa
[Canvas] Fixes the Copy Post Url link ( #54831 )
...
* Fixes the Copy Post Url link
* Adds tests
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 14:31:20 -05:00
Corey Robertson
ece414e423
Fixes bugs with full screen filters ( #54792 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 14:14:02 -05:00
Dima Arnautov
a922e1f5ae
[ML] Fix decoding in the URL state ( #54915 )
...
* [ML] condition for rison decode in getUrlState
* [ML] fix icon alignment
* [ML] use Set
* [ML] add export, fix typo
* [ML] setUrlState test
* [ML] fields stats width
2020-01-16 19:33:08 +01:00
Frank Hassanabad
178c7a48fc
[SIEM][Detection Engine] Adds critical missing status route to prepackaged rules
...
## Summary
* Fixes a critical bug where the missing status for the REST route was missing
* Fixes a bug with the 400 not being used for the missing index in some cases
* Changes create and update to NO LONGER allow immutable to be passed
* Fixes a bug with the add prepackaged schema to where you could use `immutable: false`. Now it is required to be missing or set to `immutable: true` within it.
* Cleans up unit tests
To use the critical bug missing status for the REST route:
```ts
GET /api/detection_engine/rules/prepackaged/_status
```
And you will get back:
```ts
{
"rules_installed": 252,
"rules_not_installed": 87,
"rules_not_updated": 0
}
```
See the script:
```ts
get_prepackaged_rules_status.sh
```
for more details
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )
2020-01-16 10:37:22 -07:00
Melissa Alvarez
8ce07c23bd
[ML] DataFrame Analytics: filter out docs with no prediction data from results table ( #54826 )
...
* filter out docs with no prediction data from results table
* ensure bool.must exists in the cloned searchQuery
* create must in bool query if not present
2020-01-16 12:34:33 -05:00
Alison Goryachev
46568c2213
[Mappings editor] Clean up dynamic_templates code ( #54950 )
2020-01-16 11:53:43 -05:00
Thomas Neirynck
ca91ec55b4
[Maps] Rename geo_tile display points option to clusters ( #54973 )
2020-01-16 11:47:20 -05:00
Alison Goryachev
6658412bad
[Mappings editor] Add missing period to load JSON copy ( #54959 )
2020-01-16 10:38:54 -05:00
Melissa Alvarez
b9814bfb76
[ML] DF Analytics Outlier detection results: improve handling of text fields ( #55002 )
...
* add keyword suffix to fieldName when both text and keyword
* update exploration jest test
2020-01-16 10:32:27 -05:00
Nathan L Smith
e60289f611
[APM] Storybook support ( #54970 )
...
Add Storybook with help from changes in #43529 .
We still need to do some work around having mocks for hooks and HTTP requests but the basics are there.
2020-01-16 09:27:07 -06:00
Pete Harverson
3419b06ee3
[ML] Fixes empty table header cell and duplicate ID accessibility issues ( #54917 )
...
* [ML] Fixes empty table header cell and duplicate ID accessibility issues
* [ML] Fix anomalies table columns test
2020-01-16 14:19:34 +00:00
Jean-Louis Leysens
2acb42662c
Upgrade io-ts after fix was merged and update use of some types ( #55013 )
...
* Upgrade io-ts after fix was merged and update use of some types
* Stricter checking against object keys
2020-01-16 13:57:37 +01:00
MadameSheema
8a07023343
[SIEM] Improves toggle column Cypress tests execution time ( #54475 )
...
* refactor
* replaces 'clearTimeline' for 'createNewTimeline'
* fixes typecheck issue
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 12:31:46 +01:00
Shahzad
6d3c284d11
[Uptime] Fix/embedded map console warning ( #54926 )
...
* update it
* type
* refresh app when it is out of focus
* updated
* unused code
2020-01-16 12:14:38 +01:00
Angela Chuang
c2f3c977eb
[SIEM] Dns histogram enhancement ( #54902 )
...
* update DNS histogram
* fix indent
* hide dropdown if only one option provided
* update DNS histogram
* fix types
2020-01-16 18:46:22 +08:00
MadameSheema
ea9351aaaa
[SIEM] Improves data providers Cypress tests execution ( #54462 )
...
* refactor
* replaces 'clearTimeline' for 'createNewTimeline'
* removes unused data-test-subj
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 11:10:49 +01:00
Gidi Meir Morris
8458e47614
removes usage of the _id field in Task manager ( #54765 )
...
As of Elasticsearch 8.0.0 it will no longer be possible to use the _id field on documents.
This PR removes the usage that Task Manager makes of this field and switches to pinned queries to achieve a similar effect.
2020-01-16 09:55:51 +00:00
MadameSheema
81a7f89448
[SIEM] Improves flyout button Cypress tests time execution ( #54463 )
...
* refactor
* replaces 'clearTimeline' for 'createNewTimeline'
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 10:11:44 +01:00
MadameSheema
043573e264
[SIEM] Improves inspect Cypress tests time execution ( #54443 )
...
* groups test by context
* renames 'openHostsAndStatsTables' to 'openStatsAndTables'
* replaces map method for forEach
* adds timeout for modal-inspect-close
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 09:57:36 +01:00
Sébastien Loix
41f72032e2
[Mappings editor] Fix clear searchbox ( #54880 )
2020-01-16 12:46:54 +05:30
Thomas Neirynck
0f924f5475
[Maps] Remove the tile_map plugin dependency ( #54947 )
2020-01-15 21:42:57 -05:00
Nick Partridge
bd7d5eb9f6
Shim vis_type_vislib ( #53536 )
...
* shim of kbn_vislib_vis_types (now vis_type_vislib)
* Move vislib into vis_type_vislib plugin
* Convert remaining plugin files to typescript
* Rename vis to vis_type_vislib
2020-01-15 15:48:19 -06:00
Thomas Neirynck
8ee7ed9a06
[Maps] Coerce property value to string to match mapbox-gl spec ( #54928 )
2020-01-15 16:43:16 -05:00
Melissa Alvarez
6b35b97e96
do not render the tablist element if there are no sub menus ( #54838 )
2020-01-15 16:04:27 -05:00
Steph Milovic
5ba24b8f54
[SIEM] [Case] Service Now Kibana Action ( #53890 )
2020-01-15 13:50:38 -07:00
Vadim Dalecky
22369c9992
📕 Storybook for everyone (take 2) ( #43529 )
...
* chore: 🤖 add Infra sample Storybook story
* chore: 🤖 add @kbn/storybook package
* chore: 🤖 add sample SIEM stories
* chore: 🤖 add Canvas new Storybook config
* fix: 🐛 fix TypeScript errors
* chore: 🤖 add @kbn/babel-preset to package.json
* chore: 🤖 move dependencies to devDependencies
* chore: 🤖 make Storybook dependencies non-dev
* chore: 🤖 upgrade Storybook dependencies
* chore: 🤖 add packages to webpack
* fix: 🐛 fix TypeScript type check
* chore: 🤖 disable ESLint warnings
* chore: 🤖 remove Storybook info plugin
* chore: 🤖 upate yarn.lock
* chore: 🤖 add Storbook to Embeddables
* feat: 🎸 add --clean flag to Storybook CLI
* coalesce yarn.lock versions
* update kbn/pm dist
* This reverts commit 97d8ff9f53
and 49b07cd007
.
* chore: 🤖 use fs instead of mkdirp
* chore: 🤖 use debug for message logging
* chore: 🤖 update yarn.lock
* feat: 🎸 add link to kbn-storybook package
* docs: ✏️ add Storybook readme
* chore: 🤖 remove packages that failed DLL build
* style: 💄 add ESLint comma
* chore: 🤖 apply changes from #52209
* fix: 🐛 make Canvas Storybook build again
* chore: 🤖 move Canvas stories to global Storybook
* chore: 🤖 move more Canvas components to global Storybook
* chore: 🤖 move more Canvas stories to global Storybook
* chore: 🤖 move <ItemGrid> and <KeyboardShortcutsDoc> to NP SB
* chore: 🤖 move shape picker Canvas stories to global Storybook
* chore: 🤖 move Canvas sidebar stories to global Storybook
* fix: 🐛 split imports to not import path.resolve in Storybook
* chore: 🤖 move tag and PDF panel Canvas stories to global SB
* chore: 🤖 move Canvas share website flyout stories to global SB
* fix: 🐛 clean up <ShareWebsiteFlyout> imports
* chore: 🤖 add back Canvas withInfo decorator
* chore: 🤖 look for Canvas stories everywhere in /canvas folder
* test: 💍 mock correct files in Storyshots
* test: 💍 update Canvas Storyshot snapshots
* chore: 🤖 move more Canvas components to global Storybook
* chore: 🤖 move more Canvas components to global Storybook
* test: 💍 update Canvas Storyshots
* chore: 🤖 rebuild @kbn/pm
* chore: 🤖 refresh @kbn/pm dist/index.js artifact
* chore: 🤖 update yarn.lock
* chore: 🤖 update @kbn/pm artifact
* feat: 🎸 address review comments
* fix: 🐛 remove circular import
* chore: 🤖 update yarn.lock
* test: 💍 disable a test suite
* test: 💍 update Canvas storyshots
* chore: 🤖 remvoe build step from @kbn/storybook
* chore: 🤖 enable disabled functional test suite
Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 12:30:59 -08:00
Joel Griffith
5b2e315e5a
Getting flaky tests back in shape for reporting ( #46076 )
...
* Rebasing from master, updating test utils and getting report pdf/png generation
* Removing legacy functions, packages and updating README/Licenses
* Dropping duplicitive test
* Better URL check for lens reporting
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 11:28:39 -08:00
Elizabet Oliveira
ed3c8991db
Color blind palette ( #54918 )
2020-01-15 18:55:33 +00:00
Peter Pisljar
297aa7bd23
visualize embeddable to visualizations plugin ( #54840 )
2020-01-15 13:53:56 -05:00
Jean-Louis Leysens
781ef7a2c0
[Mappings Editor] Remove Joi ( #54913 )
2020-01-15 12:42:02 -05:00
patrykkopycinski
b758b78e1e
[SIEM] Add support for IP details flow target in url ( #54546 )
2020-01-15 18:31:54 +01:00
igoristic
884fe91c1e
Added new index pattern ( #54681 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 11:44:22 -05:00
Shahzad
f2695c4d25
[Uptime] Ping list, margin before expand arrow ( #54905 )
...
* added margin
* Update x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx
Co-Authored-By: Katrin Freihofner <katrin.freihofner@elastic.co>
Co-authored-by: Katrin Freihofner <katrin.freihofner@elastic.co>
2020-01-15 17:14:54 +01:00
Melissa Alvarez
5fc691f775
Ensure result field columns can be deselected and re-selected ( #54766 )
2020-01-15 09:19:37 -05:00