Commit graph

6660 commits

Author SHA1 Message Date
Greg Thompson 82e30f6eff
Upgrade EUI to v27.4.1 (#75240)
* eui to 27.4.1

* src snapshot updates

* x-pack snapshot updates

* remove increased default timeout

* revert date change

* delete default_timeout file

* reinstate storyshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-21 10:48:04 -06:00
Jen Huang 3031e66806
Update datasets UI copy to data streams (#75618) 2020-08-21 09:16:17 -07:00
Joe Reuter 86f73cb0c2
[Lens] Register saved object references (#74523) 2020-08-21 18:08:25 +02:00
DeDe Morton 471b114089
[DOCS] Update links to Beats documentation (#70380)
* Update links to Beats documentation

* Update snapshot files

* Fix lint errors
2020-08-21 09:08:07 -07:00
Constance 172c464b14
[Enterprise Search] Convert our public_url route to config_data and collect initialAppData (#75616)
* [Setup] DRY out stripTrailingSlash helper

- DRYs out repeated code
- This will be used by an upcoming server/ endpoint change, hence why it's in common

* [Setup] DRY out initial app data types to common/types

- In preparation for upcoming server logic that will need to reuse these types
+ DRY out and clean up workplace_search types
  - remove unused supportEligible
  - remove currentUser - unneeded in Kibana

* Update callEnterpriseSearchConfigAPI to parse and fetch new expected data

* Remove /public_url API for /config_data

* Remove getPublicUrl in favor of directly calling the new /config_data API from public/plugin

+ set returned initialData in this.data

* Set up product apps to be passed initial data as props

* Fix for Kea/redux state not resetting between AS<->WS nav

- resetContext at the top level only gets called once total on first plugin load and never after, causing navigating between WS and AS to crash when both have Kea - this fixes the issue

- moves redux Provider to top level app as well

* Add very basic Kea logic file to App Search

* Finish AppSearchConfigured tests & set up kea+useEffect mocks

* [Cleanup] DRY out repeated mock initialAppData to a reusable defaults constant
2020-08-21 09:02:15 -07:00
Devon Thomson 6b3ce3f91e
[Dashboard First] Lens Originating App Breadcrumb (#75470)
Changed lens breadcrumbs to reflect the Originating App
2020-08-21 10:18:14 -04:00
Aleh Zasypkin c68363995b
Improve login UI error message. (#75642) 2020-08-21 16:15:12 +02:00
Robert Austin da0da4ca75
[Security Solution] modify circular deps checker to output images of circular deps graphs (#75579) 2020-08-21 09:43:42 -04:00
Marta Bondyra 23f46c9d85
[Lens] Use index pattern service instead saved object client (#74654) 2020-08-21 11:33:42 +02:00
Vadim Dalecky 74ab9897b5
Embeddable input (#73033)
* refactor: 💡 move timeRange, filters and query to base embeddabl

* refactor: 💡 use new base embeddable input in explore data

* feat: 🎸 import types as types
2020-08-21 11:28:37 +02:00
Pete Harverson 659890cc91
[ML] Transforms: Unset doc title when app unmounts (#75539)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-21 09:25:17 +01:00
Quynh Nguyen 958296c5c2
[ML] Update broken job config callout error (#75481)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 18:14:58 -05:00
Jen Huang 3201efe797
[Ingest Manager] Add namespace validation (#75381)
* Add namespace validation on APIs and UI

* Add test coverage

* Fix imports

* Fix schema

* Rename to policy

* Fix typo
2020-08-20 15:29:56 -07:00
Gidi Meir Morris 5308cc7100
[Task Manager] Monitors the Task Manager Poller and automatically recovers from failure (#75420)
Introduces a monitor around the Task Manager poller which pips through all values emitted by the poller and recovers from poller failures or stalls.
This monitor does the following:
1. Catches the poller thrown errors and recovers by proxying the error to a handler and continues listening to the poller.
2. Reacts to the poller `error` (caused by uncaught errors) and `completion` events, by starting a new poller and piping its event through to any previous subscribers (in our case, Task Manager itself).
3. Tracks the rate at which the poller emits events (this can be both work events, and `No Task` events, so polling and finding no work, still counts as an emitted event) and times out when this rate gets too long (suggesting the poller  has hung) and replaces the Poller with a new one.

We're not aware of any clear cases where Task Manager should actually get restarted by the monitor - this is definitely an error case and we have addressed all known cases.
The goal of introducing this monitor is as an insurance policy in case an unexpected error case breaks the poller in a long running production environment.
2020-08-20 21:26:56 +01:00
Zacqary Adam Xeper bcca9331b5
[Metrics UI] Get custom metrics working in inventory alerts with limited UI (#75073) 2020-08-20 13:28:10 -05:00
Zacqary Adam Xeper 0d8a4613e4
[Metrics UI] Support percentage format in threshold alerts (#72701)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 13:22:04 -05:00
Jean-Louis Leysens 644e9c25d7
[Ingest Pipelines] Processor forms for processors E-J (#75054)
* Added the enrich processor form (big one)

* added fail processor form

* Added foreach processor form

* Added geoip processor form and refactored some deserialization

* added grok processor form and updated comments and some i18n ids

* updated existing gsub processor form to be in line with other forms

* added html_strip processor form

* refactored some serialize and deserialize functions and added inference processor form

* fix copy-pasta mistake in inference form and add join processor form

* Added JSON processor field

- Also factored out target_field field to common field (still have
  to update the all instances)
- Built out special logic for handling add_to_root and
  target_field combo on JSON processor form
- Created another serializer, for default boolean -> undefined.

* remove unused variable

* Refactor to use new shared target_field component, and fix JSON serializer bug

* fix i18n

* address pr feedback

* Fix enrich max fields help text copy

* add link to enrich policy docs in help text

* fix error validation message in enrich policy form and replace space with horizontal rule

* address copy feedback

* fix i18n id typo

* fix i18n

* address additional round of feedback and fix json form help text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 19:04:42 +02:00
Devon Thomson eba482743a
[Dashboard First] Use App Title for Display Instead of App Id (#75457)
Created app title fetch method in embeddable_state_transfer. Used it instead of the raw app id in a number of places.
2020-08-20 13:01:25 -04:00
Constance 7699f1c29a
[Enterprise Search][bug/tech debt] Fix route navigation (#75369)
* Set up navigateToUrl context

* Update RR link helpers to use navigateToUrl

* Update breadcrumbs to use navigateToUrl + refactor

generate_breadcrumbs:
- Change base breadcrumb generator to a custom React useHook instead of passing history/context around
- Change use{Product}Breadcrumbs helpers to mainly involve merging arrays
- Update + simplify tests accordingly (test link behavior in main useBreadcrumb suite, not in subsequent helpers)

set_chrome:
- Update to use new breadcrumb hooks (requires pulling out of useEffect, hooks can't be used inside another hook)
- Clean up/refactor tests

* Update route redirects now that navigation works correctly
2020-08-20 09:41:43 -07:00
Luke Elmers 94beed1b79
[expressions] Remove legacy APIs. (#75517) 2020-08-20 10:08:31 -06:00
Davis Plumlee afd90b04df
Fixes viewer overflow bug (#75489) 2020-08-20 12:00:41 -04:00
Alison Goryachev 3a66bb5851
[Ingest pipelines] Test pipeline enhancements (#74964) 2020-08-20 11:52:58 -04:00
John Schulz caf3bac6d6
[Ingest Manager] Don't retain POST /setup results. fixes #74587 (#75372)
* add retries for registry requests.

works, afaict. no tests. one TS issue.

* Fix TS issue. Add link to node-fetch error docs

* Restore some accidentally deleted code.

* Add more comments. Remove logging.

* Add tests for plugin setup service & handlers

* Add tests for Registry retry logic

* Extract setup retry logic to separate function/file

* Add tests for setup retry logic

```
  firstSuccessOrTryAgain
    ✓ reject/throws is called again & its value returned (18ms)
    ✓ the first success value is cached (2ms)
```

* More straightforward(?) tests for setup caching

* Revert cached setup. Still limit 1 call at a time

Terrible tests. Committing & pushing to see if it fixes failures like https://github.com/elastic/kibana/pull/74507/checks?check_run_id=980178887

https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/67892/execution/node/663/log/

```
07:36:56               └-> "before all" hook
07:36:56               └-> should not allow to enroll an agent with a invalid enrollment
07:36:56                 └-> "before each" hook: global before each
07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
07:36:56                 │ proc [kibana]  error  [11:36:56.369]  Error: Internal Server Error
07:36:56                 │ proc [kibana]     at HapiResponseAdapter.toError (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/response_adapter.js:132:19)
07:36:56                 │ proc [kibana]     at HapiResponseAdapter.toHapiResponse (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/response_adapter.js:86:19)
07:36:56                 │ proc [kibana]     at HapiResponseAdapter.handle (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/response_adapter.js:81:17)
07:36:56                 │ proc [kibana]     at Router.handle (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/router.js:164:34)
07:36:56                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
07:36:56                 │ proc [kibana]   log   [11:36:56.581] [info][authentication][plugins][security] Authentication attempt failed: [security_exception] missing authentication credentials for REST request [/_security/_authenticate], with { header={ WWW-Authenticate={ 0="ApiKey" & 1="Basic realm=\"security\" charset=\"UTF-8\"" } } }
07:36:56                 └- ✓ pass  (60ms) "Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should not allow to enroll an agent with a invalid enrollment"
07:36:56               └-> should not allow to enroll an agent with a shared id if it already exists
07:36:56                 └-> "before each" hook: global before each
07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
07:36:56                 └- ✓ pass  (111ms) "Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should not allow to enroll an agent with a shared id if it already exists "
07:36:56               └-> should not allow to enroll an agent with a version > kibana
07:36:56                 └-> "before each" hook: global before each
07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
07:36:56                 └- ✓ pass  (58ms) "Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should not allow to enroll an agent with a version > kibana"
07:36:56               └-> should allow to enroll an agent with a valid enrollment token
07:36:56                 └-> "before each" hook: global before each
07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
07:36:56                 └- ✖ fail: Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should allow to enroll an agent with a valid enrollment token
07:36:56                 │      Error: expected 200 "OK", got 500 "Internal Server Error"
07:36:56                 │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
07:36:56                 │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
07:36:56                 │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
07:36:56                 │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
07:36:56                 │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
07:36:56                 │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:718:3)
07:36:56                 │       at parser (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:906:18)
07:36:56                 │       at IncomingMessage.res.on (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/parsers/json.js:19:7)
07:36:56                 │       at endReadableNT (_stream_readable.js:1145:12)
07:36:56                 │       at process._tickCallback (internal/process/next_tick.js:63:19)
07:36:56                 │
07:36:56                 │
```

* New name & tests for one-at-a-time /setup behavior

`firstPromiseBlocksAndFufills` for "the first promise created blocks others from being created, then fufills all with that first result"

* More (better?) renaming

* Fix name in test description

* Fix spelling typo.

* Remove registry retry code & tests

* Use async fn's .catch to avoid unhandled rejection

Add explicit `isPending` value instead of overloading role of `status`. Could probably do without it, but it makes the intent more clear.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 11:09:09 -04:00
John Schulz 0f494f420f
Retry network errors on registry requests (#74507) 2020-08-20 11:07:54 -04:00
Thomas Neirynck 954b5b5224
[Maps] Move elasticsearch_geo_utils to common (#75508) 2020-08-20 09:28:19 -04:00
Chris Roberson 3fb639f986
[Monitoring] Fix bug where kibana crashes with collection disabled (#75335)
* Fix bug where kibana crashes with collection disabled

* Do not set this to an empty object by default

* Always create the bulk uploader, and fix this misplaced license check

* Fix type issue

* Add a couple basic tests

* Fix type issue
2020-08-20 09:23:20 -04:00
Joe Portner 4dd5d63484
Change response for Saved Objects share/unshare operations (#74995) 2020-08-20 08:35:33 -04:00
MadameSheema eba85ef50a
fixes 're-orders columns via drag and drop' test (#75126)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 09:39:38 +02:00
MadameSheema 4a0a79f9c3
fixes timeline local storage test (#75123)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 09:39:09 +02:00
DeDe Morton 4b46316395
Edit text strings for Ingest Manager Overview and Add data pages (#74818)
* Edit Ingest Manager text strings in Overview and Add Data pages

* Add fixes from review

* remove blank line

* Change configurations to policies

* Remove "configuration" from text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-19 18:02:34 -07:00
Kevin Logan f286f8f6e1
[SECURITY_SOLUTION] Task/add auto refresh to endpoint list (#74856) 2020-08-19 19:52:56 -04:00
Josh Dover 51a80c61a0
Add support for reading request ID from X-Opaque-Id header (#71019)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-19 15:41:12 -06:00
Tim Sullivan e48a5672c0
[Reporting/JobListing] fix user ID for non-security in queries (#75365)
* [Reporting/JobListing] fix user ID for non-security in queries

* fix tests

* add fn api test

* fix ci

* revert TS exploration
2020-08-19 13:52:43 -07:00
Jen Huang ad5c0f58fe
[Ingest Manager] Rename agent/package config(s) to agent/package policy(ies) (#74914)
* Initial pass at updating client routes, variables names, code comments, and UI copy

* Adjust server routes and param names, more var names and i18n fixes

* Fix test

* More var renaming

* Rest of server-side var renaming

* Rest of client side var renaming

* Rename agent SO attributes and add migrations

* Remove agent prefix from policy fields

* Rename agent policy SO attributes and add migrations

* Rename enrollment api key SO attributes and add migrations

* Rename package policy SO attributes and add migrations

* Rename agent event SO attributes and add migrations

* Rename subtype CONFIG to POLICY (I don't think this string is ever sent by agent, though)

* Update snapshot

* Remove unnecessary cloning in migrations

* Fix migration typos

* Update naming in tests and es archiver data

* Rename file names in /common

* Rename /server files

* Rename /public files

* Rename test file names

* Rename missed files

* Revert "Rename subtype CONFIG to POLICY (I don't think this string is ever sent by agent, though)"

This reverts commit 3c91e01ed9.

* Add migration version to updated es archiver data to fix tests
2020-08-19 13:52:06 -07:00
Chris Roberson eb3cb8258f
Add loading page (#75362) 2020-08-19 14:57:53 -04:00
Paul Tavares d46227421e
[SECURITY_SOLUTION][ENDPOINT] Add creation of Trusted Apps Agnostic List (#74868)
* Add method to ExceptionsListClient for creating trusted apps list
2020-08-19 14:32:43 -04:00
Frank Hassanabad 02fcbaa794
Fixed bug where list index privileges was returned twice instead of list item index (#75256)
## Summary

Fixes a bug where the list privileges was returning the `.list` privileges twice instead of returning it once and returning the `.items` privileges second with the call. No UI has to change as the way it was written was dynamic to grab the first key found.

This also adds the functional tests to `x-pack/scripts/functional_tests.js` which was not there originally so the end to tend tests should actually run on the CI machine where it was not running on CI before.

Adds the functional tests to the code owners file as well.

Ensure that you go to the test results page from the Jenkins build:
<img width="901" alt="Screen Shot 2020-08-18 at 1 13 18 AM" src="https://user-images.githubusercontent.com/1151048/90482180-13f7c800-e0f0-11ea-92f2-b30a8fffe84e.png">

And ensure you see the tests under:

```
X-Pack Lists Integration Tests
```

Then click through it and ensure they are shown as running and passing

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2020-08-19 12:30:11 -06:00
Brent Kimmel 7ac929b4cb
[Security Solution][Resolver] enzyme semantics (#75311)
* remove old edgeline method on simulator

* [Security Solution][Resolver] Enzyme test treeitem/tree roles
2020-08-19 14:27:48 -04:00
James Gowdy fb2cac9a8a
[ML] Fixing file import button on basic license (#75458) 2020-08-19 19:13:12 +01:00
Quynh Nguyen 3469e164f4
[ML] Add option for per-partition categorization to categorization job wizard (#75061) 2020-08-19 13:03:00 -05:00
Liza Katz b944dd3c96
[Search] Use new es client (#74529)
* improve test stability

* Use new client

* docs

* Use asyncSearch endpoints

* Clean up types

* Use transport request for now

* fixes

* Fix functional test

* encode

* remove eslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-19 20:29:35 +03:00
Shahzad 2c865f5649
[RUM Dashboard] Create new path for client side monitoring (#74740) 2020-08-19 19:05:53 +02:00
Ben Skelker 32bd45bfbb
updates link to security docs (#75421) 2020-08-19 19:28:48 +03:00
Ryland Herrick 32c23eacc9
[Security Solution][Detections] Loosen lists permissions (#75378)
* Allow read-only lists users to use Detections if lists indexes exist

We were previously showing them a configuration page, which was
incorrect. The only place we require the write permission is the value
lists modal, which is now hidden if that permission is absent.

* Disable the Value Lists modal when the user cannot write lists

If the user does not have permission to write to the lists index, they
should not be able to CRUD value lists.

* style: Remove unnecessary useCallbacks

* Replaces useCallback functions with inline anonymous functions
* Renames the modal state to be more similar to existing analogous
  modal state
2020-08-19 11:25:26 -05:00
Sébastien Loix 0c6f682890
[Form lib] Allow new "defaultValue" to be provided when resetting the… (#75302) 2020-08-19 18:08:15 +02:00
Alejandro Fernández Gómez 96118624de
[Logs UI] Add "View in machine learning" links in the anomaly explorer (#74555)
Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-19 18:07:33 +02:00
Gidi Meir Morris 9698a0720d
[Saved objects] Add support for version on create & bulkCreate when overwriting a document (#75172)
Adds support for `version` one the SavedObjectsClient's create api.
This sallows us to retain Optimistic concurrency control when using create to overwrite an existing document.
2020-08-19 16:10:33 +01:00
Walter Rafelsberger e61a4b63a6
[ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (#74499)
Refactors the action buttons for transforms and analytics job list to no longer produce nested button elements and throw a React error.
2020-08-19 16:25:00 +02:00
Dima Arnautov 8f7d213944
[ML] Inference models management (#74978)
* [ML] init tabs

* [ML] init inference API service in UI

* [ML] server-side routes

* [ML] basic table

* [ML] support deletion

* [ML] delete multiple models

* [ML] WIP expanded row

* [ML] fix types

* [ML] expanded row

* [ML] fix types

* [ML] fix i18n id

* [ML] change server-side permission check

* [ML] refactor types

* [ML] show success toast on model deletion, fix models counter

* [ML] update expanded row

* [ML] pipelines stats

* [ML] use refresh observable

* [ML] endpoint to fetch associated pipelines

* [ML] update the endpoint to fetch associated pipelines

* [ML] show pipelines definition in expanded row

* [ML] change stats layout

* [ML] fix headers

* [ML] change breadcrumb title

* [ML] fetch models config with pipelines

* [ML] change default size to 1000

* [ML] fix collections keys, fix double fetch on initial page load

* [ML] adjust models deletion text

* [ML] fix DFA jobs on the management page

* [ML] small tabs in expanded row

* [ML] fix headers text

* [ML] fix models fetching without pipelines get permissions

* [ML] stats rendering as a description list

* [ML] fix i18n id

* [ML] remove an extra copyright comment, add selectable messages

* [ML] update stats on refresh
2020-08-19 16:22:26 +02:00
Chris Roberson 774c04a2d5
[Monitoring] Migrate karma tests (#75301)
* Move to jest

* More tests
2020-08-19 10:13:27 -04:00