Commit graph

10615 commits

Author SHA1 Message Date
Robert Oskamp 834a287379
[ML] Functional tests - re-activate DFA test suites (#75257)
This PR re-enables the DFA test suites for cloning, regression creation and classification creation.
2020-08-18 12:32:13 +02:00
Pierre Gayvallet c844187ee9
GS providers improvements (#75174)
* exclude apps with non visible navlinks from results

* change SO provider to prefix search

* fix service tests
2020-08-18 12:24:48 +02:00
Pierre Gayvallet 890fc31dff
Beats Management plugin: migrate server-side code (#70930)
* move all the legacy codebase to KP plugin

* fix imports

* add empty handler context & rename routes folder

* start migrating routes

* migrate rest of the routes

* migrate adapters

* remove beats from legacy xpack plugin

* use nullable + replace response.custom

* fix wrapRouteWithSecurity, remove incorrect header validation

* remove comment

* updating generated plugin list

* fix typos in doc

* adapt readme too.

* remove old commented routes from route files

* remove eslint disabling

* use camel case for plugin id

* update generated doc

Co-authored-by: Josh Dover <me@joshdover.com>
2020-08-18 12:00:39 +02:00
Patryk Kopyciński 7b785c62e4
[Security Solution] Fix unit tests (#75165) 2020-08-18 09:00:50 +02:00
Aleh Zasypkin e46e66210f
Implement Server-Side sessions (#68117) 2020-08-18 08:38:23 +02:00
CJ Cenizal ec6cc14a9f
Allow Watcher index actions to be configured without specifying an index name. (#74684) 2020-08-17 19:29:38 -07:00
Brent Kimmel b8dc0a02a0
[Security Solution][Resolver] Enzyme tests for graph layout (#75010)
* [Security Solution][Resolver] Enzyme tests for graph layout

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Robert Austin <robert.austin@elastic.co>
2020-08-17 18:07:19 -04:00
Joe Portner 8a110a3c15
lodash 4.17.19 -> 4.17.20 (#75205) 2020-08-17 16:56:32 -04:00
Marshall Main 24773f3a00
[Security solution][Exceptions] Add separate io-ts types for endpoint exceptions (#74468)
* Add separate io-ts types for endpoint exception entries

* Fix text typos

* Fix test

* address review comments

* Add extra entry validation when adding items to endpoint_list

* fix test

* fix tests again

* really actually fix the tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 16:42:04 -04:00
Nathan L Smith 4b4050c8db
APM and Observability storybook fixes (#75168)
In APM:

* Fix stories crashing with errors
* Hide some additional prop tables
* Fix node severites story to show correct node severites
* Fix Service Map Popover story
* Use knobs on sync badge story

In Observability:

* Remove an extra stray paren in decorators

There's additional refactoring and fixes that can be done but this just gets everything in working order.
2020-08-17 14:33:00 -05:00
Tiago Costa df9b28a4ce
skip flaky suite (#75124) 2020-08-17 20:25:22 +01:00
Pierre Gayvallet 57a802c43f
expose es config on es setup contract (#73055)
* expose es config on es setup contract

* move config$ back to legacy
2020-08-17 21:08:27 +02:00
Alison Goryachev 156692cbfb
[Ingest pipelines] Add KibanaContextProvider as dependency of processor editor (#75018) 2020-08-17 14:25:26 -04:00
Constance 0b28dc2f48
[Enterprise Search][tech debt] Refactor external URL generation to a single DRY helper (#75093)
* Set up App Search routes constants file

* Create new helper/generator for external URLs

* Update plugin to pass externalUrl helper in KibanaContext

* Update AS & WS navs to use new external url generator

* Update App Search views to use new externalUrl.getAppSearchUrl helper

* Update Workplace Search to use externalUrl.getWorkplaceSearchUrl helper

+ remove old useRoutes.getWSRoute helper, which was the inspiration for this

* Rename top-level enterpriseSearchUrl to config.host

- This allows us to more clearly separate concerns between the URL set in config.host and externalUrl.enterpriseSearchUrl (used for front-end links, may be a vanity/public URL)
- This change also enables us to not mutate Kibana's config obj, which is much cleaner

Misc tech debt:
- Reorder renderApp args (from least to most likely to change)
- Rename our public url methods/vars to more generic "init data" names - this is in preparation for upcoming changes where we pull more than just external_url from our client endpoint

* Fix broken Workplace Search nav links

- that require a hash for routing to work

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 09:37:21 -07:00
Nathan Reese 4ac0e81554
[Maps] fix double fetch when filters are modified (#74893)
* [Maps] fix double fetch when filters are modified

* add unit tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 09:44:08 -06:00
Nathan Reese b07db9dec8
[Maps] convert kibana_services to TS (#74901)
* [Maps] convert kibana_services to TS

* tslint

* fix jest test

* tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 09:41:08 -06:00
Chris Roberson 4c2f0760dc
Use actual link for cluster listing page (#75016)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 11:27:41 -04:00
Alejandro Fernández Gómez cf65b6ba8c
Track "view in context" usage (#74752)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 17:06:13 +02:00
Peter Pisljar a987cef583
preparing datatable for unifying with kibana_datatable (#73654) 2020-08-17 15:47:37 +02:00
Nathan Reese ea545312e9
[Maps] allow for extensible sourceDescriptor typings (#74758)
* [Maps] allow for extensible sourceDescriptor typings

* revert changes to blended_vector_layer.test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 07:23:57 -06:00
Anton Dosov 3c5f2e7e7b
[Drilldowns] Trigger picker (#74751)
Drilldowns now support trigger picker. It allows to create a drilldown and specify which trigger it should be attached to.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-17 14:47:25 +02:00
Gidi Meir Morris fcb1a2848a
[Task Manager] Handles case where buffer receives multiple entities with the same ID (#74943)
Handles the case where two operations for the same entity make it into a single batched bulk operation and avoid the clashing ID issue that could cause the poller to hang and stop poling for work).
2020-08-17 13:19:04 +01:00
Robert Oskamp a9860f3675 [ML] Functional tests - skip regression and classification tests 2020-08-17 09:51:17 +02:00
Sandra Gonzales 46a268fb99
[Ingest Manager] fix removing ingest pipelines from elasticsearch (#75092)
* fix removing ingest pipelines bug

* undo unneeded changes to default.yml entry pipeline
2020-08-15 16:18:24 -05:00
Sandra Gonzales 48deb7b0a1
move tests for placeholder indices to setup (#75096)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-15 16:16:08 -05:00
Spencer cf93604e43
[jest] temporarily extend default test timeout (#75118)
* [jest] temporarily extend default test timeout

* fix, 30 seconds

Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-08-15 13:31:37 -07:00
spalger d4f52471bf skip flaky suite (#75044) 2020-08-14 17:29:07 -07:00
Tim Sullivan ef5c95ea37 [Reporting/Flaky Test] Skip test for paging list of reports (#75075) 2020-08-14 15:49:14 -07:00
Brian Seeders df7221245d skip flaky suite (#74814) 2020-08-14 17:37:23 -04:00
Yuliia Naumenko 52bd6d98ea
Actions add proxy support (#74289)
* Added proxy support for action types

* Fixed tests

* added rejectUnauthorizedCertificates config setting

* removed slack not used code

* Fixed Slack proxy

* fixed typecheck errors

* Cleanup code

* Fixed slack

* Added unit tests

* added proxy server for test

* Fixed build

* Added functional tests

* fixed due to comments

* Fixed tests and some changes due to comments

* Fixed functional tests

* fixed circular deps

* Added proxy unit test to action type
2020-08-14 14:20:12 -07:00
Yulia Čech 64b8b88c64
[ILM] TS conversion of Edit policy components (#74747)
* [ILM] Convert node allocation component to TS and use hooks

* [ILM] Fix jest tests

* [ILM] Fix i18n check

* [ILM] Implement code review suggestions

* [ILM] Fix type check, docs link and button maxWidth in NodeAllocation component

* Fix internaliation error

* [ILM] Convert node details flyout to TS

* [ILM] Fix useState declaration

* [ILM] Fix useState declaration

* [ILM] Fix jest test

* [ILM] Change error message when unable to load node attributes

* [ILM] Change error message when unable to load node details

* [ILM] Delete a period in error callout

* [ILM] Delete a period in error callout

* [ILM] Convert node details flyout to TS

* [ILM] Fix i18n check

* [ILM] Fix useState declaration

* [ILM] Fix useState declaration

* [ILM] Fix jest test

* [ILM] Change error message when unable to load node details

* [ILM] Delete a period in error callout

* [ILM] edit components

* [ILM] Fix review suggestions

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 23:12:01 +02:00
Robert Austin 459e9d603d
[Resolver] simulator tests select elements directly instead of using descendant selectors. (#75058)
Our tests shouldn't rely on the DOM structure of Resolver (when its arbitrary) because that will make them brittle. If the user doesn't care about the DOM structure, then neither should our tests.

Note: sometimes the user does care about the DOM structure, and in those cases the tests should as well.
2020-08-14 16:31:28 -04:00
Scotty Bollinger ac04e0546a
[Enterprise Search] Add Workplace Search side navigation (#74894)
* Add routes

* Add version for use in doc link

* Set up basic router layout + WorkplaceSearchNav

* Update views to account for Layout

* Move version to common folder

* Fix version path

* Remove product button

No longer needed since we have all top-level app links in Kibana as a part of this PR

* You know, for search

* Remove comment

* Remove unused i18n properties from JSON

Tests were failing after removing component:
https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/67797/execution/node/382/log/

* Revert button and i18n copy  removal

This reverts commit ba0535187e.

* Move Overview out of layout to hide nav

For now, the route for groups was added to avoid having comment out the code. Will add the groups component in a future PR

* Revert layout changes to Overview

Since there is no nav, the padding was missing and the view looked off. Reverting to the 7.9, centered column view

* Remove extra Overview component

Was causing tests to fail

* Revert error state to use EuiPage

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 15:28:34 -05:00
Steph Milovic 1626490c36
[Security solution] Sourcerer: Kibana index pattern selector for security views (#74706) 2020-08-14 13:09:47 -05:00
Felix Stürmer 0f1128281e
[Logs UI] Remove apollo deps from log link-to routes (#74502)
This replaces the use of the old graphql-based `useSource` hook with the new plain JSON `useLogSource` hook.

It also fixes two more problems:

- A rendering problem with the source configuration loading screen and a `setState` race condition in the `useLogSource` hook.
- A non-backwards-compatible change of the `/link-to/:sourceId/logs` route in #61162.
2020-08-14 19:50:20 +02:00
Lee Drengenberg 5627ab3193
[functional test][saved objects] update tests for additional copy saved objects to space (#74907)
Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 12:20:38 -05:00
Mike Côté d56b792e9c
Make the alerts plugin support generics (#72716)
* Initial work

* Expand generic support to alert instances

* Convert index threshold to use generics

* Make fixture alert types use generics

* Make alert instance related types use unknown

* Fix typecheck failures

* Cleanup + add instance generic support to registry.get API

* Shallow clone

* Rename some TS variables

* Fix failing api integration tests

* Change code for easier review and keep more history

* Fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 12:52:42 -04:00
Melissa Alvarez 8559ed87d1
[ML] DF Analytics creation: display explain error message (#75006)
* display explain error message to the user

* fix translation

* update error message
2020-08-14 12:44:42 -04:00
Greg Thompson bbee1f92b0
Upgrade EUI to v27.4.0 (#74004)
* eui to 27.1.0

* eui to 27.2.0

* buttoniconside type

* euiselectable type

* update onScroll callback and polyfill size references

* findTestSubject ts

* buttoncontent and collapsiblenav src snapshot updates

* update prop retrieval

* xpack snapshots

* jest updates

* type fixes

* more snapshots

* virtual list changes

* more virtualization changes

* merge

* fix functional tests

* data-test-subj for indexPatter-switcher

* storyshots

* eui to 27.3.1

* Fix unit tests

* Fix broken unit test

* Updated snapshots

* Fixed types

* search for value in euiselectable before selection

* select the correct element

* mock virtualized dep

* ts fix

* reinstate storyshot

* ts fix

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 10:31:15 -06:00
Jean-Louis Leysens 344e1de7e1
[Upgrade Assistant] Fix potentially long URI (#74485)
* _cluster/state/metadata/* and added a comment to function

* add another comment regarding why we are asking for *

* update jest test

* refactor and clean up use of cluster status to get index state

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 17:14:03 +02:00
Wylie Conlon ec5112b9cc
[Lens] Fix table sorting bug (#74902)
* [Lens] Fix table sorting bug

* Fix types
2020-08-14 10:54:43 -04:00
Kevin Logan 8aa8b04cee
[SECURITY_SOLUTION] Retry on ingest setup (#75000) 2020-08-14 10:06:51 -04:00
Nathan Reese 187a13075b
[file upload] lazy load to reduce page load size (#74967)
* [file upload] lazy load to reduce page load size

* tslint
2020-08-14 07:15:16 -06:00
Patrick Mueller 67e28ac8b4
[EventLog] Populate alert instances view with event log data (#68437)
resolves https://github.com/elastic/kibana/issues/57446

Adds a new API (AlertClient and HTTP endpoint) `getAlertStatus()` which returns
alert data calculated from the event log.
2020-08-14 08:34:26 -04:00
Anton Dosov 7bd014abb3
[UiActions] pass trigger into action execution context (#74363)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 12:07:04 +02:00
Cauê Marcondes bcf8719824
Adding API test for custom link transaction example (#74238)
* Adding api test for custom link transaction example

* expecting specific fields

* expecting specific fields

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 09:55:39 +02:00
Shahzad 7cf0e49c89
[Uptime] Singular alert (#74659)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 09:45:02 +02:00
Chris Cowan 1632391f35
[Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (#74804)
* [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs

* Update x-pack/plugins/infra/public/pages/metrics/metrics_explorer/components/chart_title.tsx

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/calculate_bucket_size/calculate_auto.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/calculate_bucket_size/calculate_auto.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/convert_histogram_buckets_to_timeseries.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/convert_histogram_buckets_to_timeseries.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/routes/metrics_explorer/lib/find_interval_for_metrics.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Fixing some names, changing some units

* Reverting TSVB calculate_auto; fixing names in infra

* Fixing translation names

* Fixing typo

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
2020-08-13 18:45:47 -07:00
Tim Sullivan 447854d992
[Reporting/Functional] unskip pagination test (#74973)
* [Reporting/Functional] unskip pagination test

* change to js file for flaky test runner

* fix ts
2020-08-13 15:06:59 -07:00
Robert Austin 1729091ddf
[Resolver] Stale query string values are removed when resolver's component instance ID changes. (#74979)
The app can show more than 1 Resolver at a time. Each instance has a unique ID called the `resolverComponentInstanceID`. 
When the user interacts with Resolver it will add values to the query string. The query string values will contain the `resolverComponentInstanceID`. This allows each Resolver to keep its state separate. When resolver unmounts it will remove any query string values related to it.

If Resolver's `resolverComponentInstanceID` changes it should remove query string values related to the old instance ID. It does not. This PR fixes that. 

Note: I don't know if it was possible for this bug to actually happen. I can't make it happen, but depending on how Resolver is mounted by its consumers it *could*
2020-08-13 17:50:10 -04:00