Commit graph

8609 commits

Author SHA1 Message Date
Poff Poffenberger
8467b89202
[Time to Visualize] Add visualizations to dashboard from save modal (#83140)
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-12-08 15:39:24 -06:00
John Barrier Wilson
30611f431a
[Workplace Search] Polish Workplace Search Sources & Groups UI (#85071)
* Add spacer to sources page title

* Add space to source list description

* Remove sidebar content from headers

* Polish inner source overview content

* Polish source content loading state and view

* Hide sources header / remove spacers

* Formatting fix

* Fix lint issues

* Add align right to schema table

* Remove rendom EmptyPrompt

WTF

* Make SourceIcon take a variable size

* Add back SourceInfoCard with update design

Co-authored-by: scottybollinger <scotty.bollinger@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 15:30:41 -06:00
Paul Tavares
e74cb409c8
[Fleet] Return to Integration (package) details after create integration policy (#85177)
* useIntraAppState() now also supports state set via Fleet's HashRouter
* Remove use of `<Router>` from inside EPM pages
* Enable round-trip navigation for Integrations add package
2020-12-08 15:08:54 -05:00
Jane Miller
3826283c74
[SECURITY_SOLUTION] 524: Advanced Policy callout and documentation tooltips (#84926)
* 524 added EuiIconTip

* 524 conditional tooltip, caution callout

* 524 help->alert

* 524 paul's PR feedback
2020-12-08 15:07:20 -05:00
Adam Locke
72ed936aa5
Add help text for runtime fields source. (#85204)
* Add help text for runtime fields source.

* fix help text

* Text changes and defining EuiCode element for _source.

Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
2020-12-08 14:51:47 -05:00
MadameSheema
3f32b56192
[SIEM] unblocks master failures (#85319) 2020-12-08 11:46:56 -08:00
Nathan Reese
0eee8a2a86
[maps] style by percentiles (#84291)
* [maps] define style bands by percentiles

* add step function select

* percentiles form

* percentiles agg request

* create mapbox expression for stops

* legend

* small legend tweek

* clean up legend rendering

* fix dynamic color property tests

* add unit test case for percentiles legend

* re-fetch style meta when percentiles change

* name space field meta request types

* rename field_meta to data_mapping

* add tooltip to category field meta switch

* i18n fixes

* tslint

* remove duplicate file license

* fix jest tests

* only show supported step functions in fitting select

* copy updates

* add getPalette function for heatmap palette

* update jest snapshot

* another jest snapshot update

* rename EASING_BETWEEN_MIN_AND_MAX -> INTERPOLATE

* rename STEP_FUNCTION -> DATA_MAPPING_FUNCTION and text updates

* review feedback

* remove 'Apply changes' button on percentiles form

* update legend to use 'up to' and 'greater than' instead of symbols

* tslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 09:59:15 -07:00
AndyHunt66
b3bccc2816
Typos in Readme example (#84391)
The last example on the page is not valid json.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 11:44:30 -05:00
Shahzad
3216fce716
[Uptime] Remove unused code in monitor list API (#84312)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 17:18:37 +01:00
Tyler Smalley
6858562902 skip failing cypress test
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-08 07:36:11 -08:00
Jean-Louis Leysens
8eae30c82f
[ILM] Fix set replicas serialization and validation (#85233)
* added fix for serializing replicas and updated validation to correctly check for non negative nr

* added tests and fixed incorrect use of warm phase setting in cold phase

* remove unused import

* clean up use of Boolean and rename nrOfReplicas -> numberOfReplicas

* fix comment
2020-12-08 16:33:07 +01:00
Jean-Louis Leysens
6ff71992a3
[ILM] Fix hiding/disabling searchable snapshot field when rollover is disabled (#85169)
* fix hiding/disabling searchable snapshot field when rollover is disabled

* added test

* fix i18n

* for now, we hide the forcemerge field in hot

* implement copy updates

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 16:21:10 +01:00
igoristic
a41881d463
[Monitoring] Optimizing alerting code (#83681)
* Optimize alerting code

* Merged all the branches

* resolved conflict

* optimizing all branches merged

* Fixed tests and resolved conflicts

* Fixed jest tests

* Resolved merge conflicts with the alerting team's PR
2020-12-08 10:16:06 -05:00
Mike Côté
5cc9bf82d2
Add capability of defining message variables that don't escape (#84357)
* Add capability of defining message variables that don't escape

* Fix ESLint

* Rename noEscape to useWithTripleBracesInTemplates

* Add unit tests pt 1

* Add unit tests pt 2

* Fix tests

* Fix test failures

* Docs

* PR feedback
2020-12-08 09:46:04 -05:00
MadameSheema
bdd0e25359
fixes and unskips failing tests (#85243) 2020-12-08 14:50:31 +01:00
MadameSheema
e291b84f4d
unskips indicator match rule (#85240) 2020-12-08 14:49:34 +01:00
MadameSheema
273363a85b
fixes and unskips failing test (#85235) 2020-12-08 14:48:51 +01:00
MadameSheema
f46eaf889d
fixes and unskips failing tests (#85232)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 14:47:48 +01:00
DeFazio
0a0ead802c
Update widths on columns in Alert Detail view (#83823)
* Update widths on columns

* Add custom class for truncation fix

* Use euiTruncate mixin and shrink column width of status column

* Update imports to fix checks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 08:02:07 -05:00
Patryk Kopyciński
e4b89d42d8
[Security Solution] Unskip persistent timeline cypress tests (#82972) 2020-12-08 11:48:25 +01:00
Dima Arnautov
b6fe6d0fea
[ML] Fix watcher URL to the Anomaly Explorer page (#85123)
* [ML] fix watcher url to the anomaly explorer page

* [ML] remove refreshInterval from the watcher url to the anomaly explorer page
2020-12-08 11:30:54 +01:00
Wylie Conlon
0fdf76e779
[Lens] Don't assign dimension until it becomes valid (#84972) 2020-12-08 11:29:07 +01:00
Jean-Louis Leysens
fac1f1204d
[ILM] Reposition form toggles (#85143)
* merged toggleable field and described form component and moved toggle to left

* moved all toggles to left, renamed DescribedFormField -> DescribedFormRow and added new ToggleFieldWithDescribedFormRow component

* added new prop fieldNotices to render callouts in correct position on the left
2020-12-08 08:47:26 +01:00
Dario Gieselaar
213b934386
[APM] Make sure jest script can be run from anywhere (#85111) 2020-12-08 07:55:24 +01:00
Scotty Bollinger
62e79eec70
Add EuiButtonEmptyTo components (#85213)
This PR adds another wrapper component for internal routing, the EuiButtonEmptyTo component.
2020-12-07 21:03:10 -06:00
Tiago Costa
568ce65039
skip flaky suite (#85216) 2020-12-08 02:29:41 +00:00
Tiago Costa
eb1c29e656
skip flaky suite (#83775) 2020-12-08 02:27:07 +00:00
Tiago Costa
cd1be91343
skip flaky suite (#83774) 2020-12-08 02:24:26 +00:00
Tiago Costa
eeb68132b3
skip flaky suite (#83773) 2020-12-08 02:22:15 +00:00
Tiago Costa
f667b12cec
skip flaky suite (#83793) 2020-12-08 02:16:52 +00:00
Tiago Costa
8dcbac5518
skip flaky suite (#85215) 2020-12-08 02:12:55 +00:00
Tiago Costa
1a6b88c02c
skip flaky suite (#85217) 2020-12-08 02:10:59 +00:00
Yuliia Naumenko
6757b95b1e
[Alerting UI] Replaced AlertsContextProvider with KibanaContextProvider and exposed components in API (#84604)
* [Alerting UI] Replaced AlertsContextProvider with KibanaContextProvider and exposed components in API

* removed AlertContextProvider

* exposed AlertAdd and EditAlert flyouts with triggers_actions_ui plugin start

* fixed type check

* fixed tests

* fixed typechecks

* fixed wrong consumer

* fixed monitoring flyout flickering

* fixed due to comments

* fixed typechecks

* fixed typechecks

* fixed typechecks

* fixed typechecks

* fixed due to comments
2020-12-07 16:44:40 -08:00
Dave Snider
1f75d0b79f
Small fixes to Kibana search bar (#85079)
* Small fixes to Kibana search bar

* Animate width

* tweak for ipad breakpoint

Co-authored-by: Ryan Keairns <contactryank@gmail.com>
2020-12-07 12:59:45 -08:00
Zacqary Adam Xeper
de289de6c1
[Metrics UI] Refactor Process List API to fetch only top processes (#84716)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 14:46:26 -06:00
John Schulz
81a340e681
[Fleet][EPM] Save installed package assets in ES (#83391)
## Summary
Store package assets (from Registry or local upload) in Elasticsearch. Related to proposal [issue](https://github.com/elastic/kibana/issues/83426) & [document](https://docs.google.com/document/d/18XoS6CSl9UxxPPBt9LXuJngf1Jv-4tl3jY6l19U1yH8)

 * New `epm-packages-assets` saved objects are stored on `.kibana` index, like our existing saved object `epm-packages`
 * Asset id is uuid v5 based on the package name, package version & file path. See 1974324
 * Add a list of IDs of all the installed assets, to `epm-packages` saved object. Like the existing `installed_` properties.  [Example](https://github.com/elastic/kibana/pull/83391/files#diff-fa07cac51b6a49bf1e4824bc2250c9a77dac6c7d6b0a56020f559ef1ff9be25fR491-R512) from a test

<details><summary>Mapping for new Saved Object</summary>

37f7b6ded7/x-pack%2Fplugins%2Ffleet%2Fserver%2Fsaved_objects%2Findex.ts (L329-L339)
</details>

<details><summary>Additional property on existing <code>epm-packages</code> Saved Object</summary>

c4f27ab257/x-pack/plugins/fleet/server/saved_objects/index.ts (L306-L312)

 I don't think the saved object changes are strictly required. It can be removed without changing much about how things work

- Pros: 
      - Preserves accurate record of the assets added at installation time. Separates what assets are currently available for package-version from what was installed. They _should_ be the same, but things happen.
      - Avoids a query to get the installed assets before operating on them
- Cons:
      - size/noise? Could be tens or hundreds of ids
      - migration?
</details>

### More details

**When are saved objects added?**
During installation, after all other actions have succeeded, just before marking the save object as installed, we commit all the files from the package to ES

37f7b6ded7/x-pack%2Fplugins%2Ffleet%2Fserver%2Fservices%2Fepm%2Fpackages%2F_install_package.ts (L193-L198)

**When are documents removed from the index?**

In the `removeInstallation` function which is called in response to a `DELETE /api/fleet/epm/packages/pkgkey`

37f7b6ded7/x-pack%2Fplugins%2Ffleet%2Fserver%2Fservices%2Fepm%2Fpackages%2Fremove.ts (L72)

or a failed package (re-)installation

bf068739ac/x-pack%2Fplugins%2Ffleet%2Fserver%2Fservices%2Fepm%2Fpackages%2Finstall.ts (L145)




**How are we using these assets?**
We're not, currently. Here's an example showing how we could update [`getFileHandler`](514b50e4c2/x-pack%2Fplugins%2Ffleet%2Fserver%2Froutes%2Fepm%2Fhandlers.ts (L101)) to check for local assets before reaching out to the Registry if we wished. It's not DRY, but it does work

```typescript
const esDocRoot = `http://elastic:changeme@localhost:9200/${PACKAGE_ASSETS_INDEX_NAME}/_doc`;
const escapedDocId = encodeURIComponent(`${pkgName}-${pkgVersion}/${filePath}`);
const esRes = await fetch(`${esDocRoot}/${escapedDocId}`);
const esJson = await esRes.json();
if (esJson.found) {
  const asset: PackageAsset = esJson._source;
  const body = asset.data_utf8 || Buffer.from(asset.data_base64, 'base64');
  return response.ok({
    body,
    headers: {
      'content-type': asset.media_type,
      // should add our own `cache-control` header here
      // kibana default is prevents caching: `private, no-cache, no-store, must-revalidate`
      // https://github.com/elastic/kibana/issues/83631
    },
  });
}
```

### Checklist
_updated tests to include new saved object output, no tests added yet_
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2020-12-07 15:11:09 -05:00
Tiago Costa
f961e90ea7
chore(NA): remove scripts on plugins to find circular deps (#84852)
* chore(NA): remove extra scripts on plugins to find circular deps

* chore(NA): remove madge as dependency

* Move cyclic dep jobs

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 19:41:38 +00:00
Davis Plumlee
3d3eb40964
[Security Solution][Detection Rules] Mitre subtechniques (#83511) 2020-12-07 13:34:15 -05:00
Alison Goryachev
079a7e82ba
Integrate painless autocomplete in runtime fields editor (#84943) 2020-12-07 12:55:53 -05:00
igoristic
d19b558c88
[Monitoring][Alerting] Added core features to Kibana services UPDATED (#85074)
* added core features to kibana services

* Added test for alert form

* Added mocking of legacy shims and actions

* Fixed typing

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 12:25:28 -05:00
igoristic
008c6a0e19
Safegaurding alerts in case they come back undefined (#85108) 2020-12-07 11:24:44 -05:00
Lukas Olson
e48e7446c0
[data.search] Move background session service to data enhanced plugin (#84837)
* [data.search] Move search method inside session service and add tests

* Move background session service to data_enhanced plugin

* Fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 08:51:19 -07:00
Søren Louv-Jansen
cee681afb3
[APM] Improve pointer event hook (#85117) 2020-12-07 15:43:58 +01:00
Søren Louv-Jansen
e0d07c227f
[APM] Add ignore_unavailable to avoid querying closed indices (#84813) 2020-12-07 15:43:33 +01:00
John Schulz
ef7367ddb3
[Fleet][EPM] Add TS type for package-spec. Clarify EPR relationship with spec (#84946)
## Summary

 * Create a [TS type for `package-spec`](09cce235de/x-pack/plugins/fleet/common/types/models/package_spec.ts) to differentiate Registry shape from spec shape
 * Clarify EPR types relationship with package spec. i.e. what required properties it makes optional, what properties it adds, which property types it changes, etc.
5f2c4a5547/x-pack/plugins/fleet/common/types/models/epm.ts (L71-L80)
  * Updated `manifest.yml` in `apache_invalid_manifest_missing_field_0.1.4.zip`. Previously it was missing the `type` property, but that's optional [according to package-spec](3b4d820755/versions/1/manifest.spec.yml (L241-L248)). Removed the required `format_version` and re-zipped.

<details><summary>screenshots show errors if catches in a mock PackageInfo object</summary>
using `requirement`; not `conditions`
<img width="1084" alt="Screen Shot 2020-12-02 at 12 07 15 PM" src="https://user-images.githubusercontent.com/57655/101083986-4b915f80-357b-11eb-84c6-14605e1ea3d8.png">
using `versions`; not `version`
<img width="1395" alt="Screen Shot 2020-12-02 at 12 08 13 PM" src="https://user-images.githubusercontent.com/57655/101083988-4c29f600-357b-11eb-9ff2-2b73e313c130.png">
including `elasticsearch` when spec says it' not valid yet
<img width="1589" alt="Screen Shot 2020-12-02 at 12 08 36 PM" src="https://user-images.githubusercontent.com/57655/101083990-4c29f600-357b-11eb-8250-8926f7189af8.png">
</details>

<details><summary>screenshots showing editor autocomplete for registry response values like <code>categories</code></summary>

<img width="422" alt="Screen Shot 2020-12-02 at 12 25 11 PM" src="https://user-images.githubusercontent.com/57655/101083994-4cc28c80-357b-11eb-9013-ae208f7c311a.png">

<img width="345" alt="Screen Shot 2020-12-02 at 12 25 01 PM" src="https://user-images.githubusercontent.com/57655/101083991-4c29f600-357b-11eb-9468-bbb9d27513b1.png">
</details>

<details><summary>screenshot showing type check preventing adding properties which aren't explicitly listed as "additions"</summary>

<img width="1295" alt="Screen Shot 2020-12-03 at 11 38 43 AM" src="https://user-images.githubusercontent.com/57655/101083997-4cc28c80-357b-11eb-83b9-206b85521f11.png">
</details>


### Checklist


- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2020-12-07 09:30:27 -05:00
Shahzad
e476baf276
[Uptime] Details page refactor for browser monitor (#84425)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 14:35:19 +01:00
Pierre Gayvallet
446390d86a
Add bulk assign action to tag management (#84177)
* initial draft

* move components to their own files

* create services folder and move tags package

* add assignment service

* fix some types

* prepare assign tag route

* move server-side tag client under the `services` folder

* add security check, move a lot of stuff.

* design improvements

* display tags in flyout

* improve button and add notification on save

* add action on tag rows

* fix types

* fix mock import paths

* add lens to the list of assignable types

* update generated doc

* add base functional tests

* move api to internal

* add api/security test suites

* add / use get_assignable_types API

* fix feature control tests

* fix assignable types propagation

* rename actions folder to bulk_actions

* extract actions to their own module

* add common / server unit tests

* add client-side assign tests

* add some tests and tsdoc

* typo

* add getActions test

* revert width change

* fix typo in API

* various minor improvements

* typo

* tsdoc on flyout page object

* close flyout when leaving the page

* fix bug when redirecting to SO management with a tag having whitespaces in its name

* check for dupes in toAdd and toRemove

* add lazy load to assign modal opener

* add lazy load to edit/create modals

* check if at least one assign or unassign tag id is specified

* grammar

* add explicit type existence check
2020-12-07 11:18:43 +01:00
Jean-Louis Leysens
34be1e724d
[ILM] Add searchable snapshot field (#83783)
* Added server-side endpoint for getting list of repos

* part one of client side changes: added searchable snapshot field

- added to both hot and cold
- serializing into JSON payload

* make searchable snapshot field toggleable and require value when it is being used

* fix typo in file name and remove whitespace

* added searchable snapshot state context, wip

* finished updating fields to show and hide based on searchable snapshot in the hot phase

* hiding fields when searchable snapshots is enabled in hot

- removed nested EuiFieldRow components in data allocation field
- added SCSS files for data allocation field and searchable
  snapshot field

* added translations and a first hot phase serialization test

* appease type check and i18n

* added cloud-specific behaviour for searchable snapshot default inlc. test

* refactor snapshot state -> configuration issues as this a can be re-used for other issues

* added configuration context file

* hide replicas in cold if snapshotting

* updated new field copy

* update test coverage, test for hiding certain fields too

* added license check to client side!

* moved warning to below field again and moved hot phase searchable snapshot notice to right

* make described form field lazy if needed

* render field even when license requirement is not met

* update serializer for removing searchable_snapshot field

* handle 404 from ES when looking up * snapshot repos - we return an empty array

* address license TODO

* added tests for license check and removed license check HoC

* fix legacy jest tests

* added readme about legacy tests

* updated jest tests and fix type issues

* remove unused import

* refactor component names to have "Field" at the end

* refactor searchable snapshot to single interface def and add comment about force_merge_index option

* address stakeholder feebdack and pr comments

* update tests after latest changes

* link to force merge

* Revert "link to force merge"

This reverts commit 6c714fbbac.

* introduce advanced section to hot, warm and cold

* added test for correctly deserializing delete phase, and added fix

* remove unused variable

* moved fields into advanced settings

* move learn more copy below enable toggle

* fix warm phase on rollover default

* remove label space above rollover toggle

* remove unused import

* update test after fixing warm on rollover default

* removed icons in callouts in searchable snapshot field, added ability to control field toggles

* move callouts to description text

* readd warning callouts to the searchable snapshot field

* slight i18n adjustment

* made callout for actions disabled a bit smaller

* fix i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 10:52:44 +01:00
Tiago Costa
058f28ab23
skip flaky suite (#62060) 2020-12-05 22:21:12 +00:00
Patryk Kopyciński
2f386e8961
[Security Solution] 7.11 Timeline EVOLUTION (#83378) 2020-12-05 16:04:52 +01:00