Previously, when using the slack action with a url which was not whitelisted, the entire URL was reported in the error. With this change, only the hostname is reported in the error.
* Disable actions client when ESO using generated key
* Add test for getActionsClientWithRequest
* Add other part to plugin.test.ts
* Cleanup tests a bit
* Cleanup tests
* plugin.test.ts cleanup
* Add warning logs on setup
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* allow parsing from string for object-ish and array types
* update snapshots
* fix FTR assertion
* add documentation note about using a json string as input
* License expiration
* Flip off
* Only require alerting and actions if enabled
* Support date formating and timezones in the alert UI messages, support ccs better
* Fix status tests
* Fix up front end tests
* Fix linting, and switch this back
* Add this back in so legacy alerts continue to work
* Fix type issues
* Handle CCS better
* Code cleanup
* Fix type issues
* Flip this off, and fix test
* Moved the email address config to advanced settings, but need help with test failures and typescript
* Fix issue with task manager
* Deprecate email_address
* Use any until we can figure out this TS issue
* Fix type issue
* More tests
* Fix mocha tests
* Use mock instead of any
* I'm not sure why these changed...
* Provide timezone in moment usage in tests for consistency
* Fix type issue
* Change how we get dateFormat and timezone
* Change where we calculate the dates to show in the alerts UI
* Show deprecation warning based on the feature toggle
* Ensure we are using UTC
* PR feedback
* Only add this if the feature flag is enabled
* Fix tests
* Ensure we only attempt to look this up if the feature flag is enabled
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Cleanup action task params saved objects after use
* Fix jest tests
* Add integration test to ensure object gets cleaned up
* Add unit tests
* Fix comment
* Re-use updated_at instead of creating createdAt
* Consider null/undefined returned from executor as success as well
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This addresses two issues that have come up:
Alerting and Actions have TypeScript types that are needed across server and public plugins, and need to be extracted to a common path (thanks @chrisronline for bringing this to our attention)
Due to the above, types have been duplicated between the alerting and actions when needed in the Alerting UI, which has led to them diverging. This forces the UI to type check against the API, which will help reduce these errors in the future.
