* Only allow one panel to be open at a time
* Move EuiOutsideClickDetector inside the portal
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ML] Fix synching jobs from other spaces
* updating text in delete modal
* updating translations
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* creating service name header
* fixing icons
* removing unused api import
* fixing some stuff
* adding API tests
* refactoring some stuff
* fixing tests
* refactoring some stuff
* fixing i18n
* reverting
* renaming
* applying min width
* addressing PR comments and adding test
* sorting service version
* changing sort type to desc
* addressing pr comments
* changing to show total and not avg
* addressing pr comments
* addressing pr comments
* addressing pr comments
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Make `getAgentIcon` return a default icon instead of `undefined` when no icon is matched.
* Have the service map icon method check for the agent name to determine whether to use an agent or span icon. Both functions return the default icon when no match is found
* Remove the IE11 conditionals for service map icons
* Set a width on the icons used in the lists to prevent them from being stretched out
* Use EUI theme for icon sizing
Fixes#85150.
* Add mocks
* Make mergeServerAndStaticData available to tests
This method is needed to combine the 3 types of data to use in the logic files. Exporting this so that the mock data can be combined for testing in components.
It was discovered that the serverData had the wrong typings. This was only discovered when actully mocking the real server data, so it was changed here.
* Add tests for AddSourceHeader
* Add tests for AddSourceList
* Add tests for AvailableSourcesList
* Add tests for ConfigCompleted
* Add tests for ConfigDocsLinks
* Add tests for ConfigurationIntro
* Add tests for ConfigureCustom
* Add tests for ConfigureOauth
* Fix typo
* Add coverage for missing functions
The converage tool was complaining and this change assures formSubmitSuccess and handleFormSubmitError are covered
* Fix mocks
Needed an accountOnly source in this test so changed and update other tests where used
* Add tests for ConfiguredSourcesList
* Add tests for ReAuthenticate
Also changes the syntax of the redirect to use the replace method for easier testing
* Add sourceConfigData mock
* Add tests for SaveConfig
* Add tests for SaveCustom
* Add tests for SourceFeatures
* Add tests for ConnectInstance
As with the ReAuthenticate component, changes the syntax of the redirect to use the replace method for easier testing.
* [coverage] re-enable jest
* fix coverage script for x-pack
* use presets in entry configs
* set max workers
* run tests from x-pack folde
* remove duplicate 'reporters' prop
* remove reporters for x-pack config
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Unskipping test
* Using simpler alert type during test
* Fixing test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [KQL] Fix handling of backslashes when autocompleting values
* Revert change to test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Maps] convert MBMap component to TS
* clean up imports messed up by eslint fix
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ML] Adding runtime_mappings to job wizards
* fixing test
* adding runtime fields to fields list in datafeed preview
* fixing cardinality count for runtime field
* fixing cardinality check in data visualizer
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Pass filters from SIEM to resolver
* Fix test type errors
* Revert loading state change, update snapshots
* Make correct check in nodeData selector
* Fix inverted logic in nodeData selector
* Adding request id to node data
* Working time range filters and node data stale selector
* Fixing random name from generator and panel icons
* Fixing unused import
* Remove hardcoded node id
* Ensure that the actions array is reset before each test
Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# [Security Solution][Timeline] Timeline and Draggable Accessibility (a11y) Improvements
This PR improves the accessibility of Timeline and the draggables used throughout the Security Solution.
- ⌨️ Keyboard support for all draggables
- 🖱 Click on any draggable with the mouse to give it keyboard focus
- 🕵️♀️ Press `Enter` to display the draggable's action / options menu (e.g. Filter value, Investigate in Timeline, Show Top N). The menu also displays hyperlinks to allow for keyboard navigation from draggables containing links.
- 🚀 Press `Space` to start dragging via keyboard, and press `Space` again to drop
- 🏓 Timeline, + all Timeline-based tables (i.e. Detections, Host / Network Events, External alerts) support keyboard navigation
- ⬆️⬇️⬅️➡️ arrow key navigation per the `Keyboard Support` section of [w3.org grid examples](https://www.w3.org/TR/wai-aria-practices-1.1/examples/grid/dataGrids.html)
- 📉📈 `page down` and `page up` support per the `Keyboard interactions` section of the [MDN ARIA grid role documentation](<https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Grid_Role>) (and also the [w3](https://www.w3.org/TR/wai-aria-practices-1.1/examples/grid/dataGrids.html))
- 🏠🔚 `home` and `end` moves focus to the first and last cell in the row, per [w3.org](https://www.w3.org/TR/wai-aria-practices-1.1/examples/grid/dataGrids.html) & [MDN](<https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Grid_Role>)
- 🕹🏠 🕹🔚 `ctrl + home` and `ctrl + end` moves focus to the first and last cell in the row, per [w3.org](https://www.w3.org/TR/wai-aria-practices-1.1/examples/grid/dataGrids.html) & [MDN](<https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Grid_Role>)
- 🎉 Screenreader improvements for Timeline, + all Timeline-based tables, and draggables (tested with Voiceover for `macOS` version `10.15`)
- 👂 Draggables implement custom screenreader announcements. For example, when a draggable field is selected, the screenreader reads a custom message that reads the _field name_ in addition to the value, to provide additional context. For example, selecting a field named `network_flow` may be read phonetically by the screen reader as:
> event.action network underscore flow Press enter for actions, or press space to begin dragging
- 📅 Timeline, + all Timeline-based tables provide an enhanced screenreader experience via the use of `EuiScreenReaderOnly` and [w3 grid roles](https://www.w3.org/TR/wai-aria-practices-1.1/examples/grid/dataGrids.html) to provide context. For example, after clicking an arrow key to select a cell, the screenreader reads:
> You are in a table cell. row: 2, column: 5, event.module system Press enter for options, or press space to begin dragging.
- 📰 Timeline's table supports Voiceover screenreader shortcuts that read all cells across a row, or all rows down a column. See <https://github.com/elastic/kibana/issues/83364> for details
- 🍿 popovers and tooltips were enhanced via `EuiScreenReaderOnly` to provide additional context to screen readers
- 🪓 The [axe - Web Accessibility Testing Chrome extension](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd) was run interactively throughout the Security Solution to find and fix the highest-severity issues found by `axe`
- 🧹 Other keyboard-related improvements include
- The `Customize Columns` popover traps keyboard focus, and allows navigation of content via arrow keys & home / end
- The `Event details` view allows navigation of content via arrow keys & home / end
- Improvements to keyboard-focus trapping in popovers throughout the Security Solution
This PR addresses the following issues:
- [X] [[Security Solution] Add support for Voiceover announcements In Timeline's table #83364](https://github.com/elastic/kibana/issues/83364)
- [X] [[Security app] Detections events list 'overflow' ... button and expand > button do not have hover over names #74140](https://github.com/elastic/kibana/issues/74140)
- [X] [SIEM app accessibility issues #64596](https://github.com/elastic/kibana/issues/64596)
- After merging with the _Timeline Evolution_ PR, the drop zone at the bottom of the screen stopped accepting draggables after the first draggable is dropped. The current workaround is to press `Enter` to open the draggables action menu, and select the `Investigate in timeline` action. When Timeline is open, the drag area at the top of the screen accepts additional draggables via keyboard. EDIT: I paired with @XavierM on this, and he has a fix for this issue (duplicate draggable IDs) in his PR.
## Summary
Resolves https://github.com/elastic/kibana/issues/77324, https://github.com/elastic/kibana/issues/77325, resolves https://github.com/elastic/kibana/issues/77325, and resolves https://github.com/elastic/kibana/issues/81302
This PR addresses referential integrity issues when deleting value lists. Previously when deleting value lists, any references in Exception Lists/Items would be left behind. This PR introduces a new confirmation modal when deleting value lists that are referenced in either space aware (`simple`) or space `agnostic` exception lists.
Also includes:
* Fixed Lists plugin `quick_start.sh` as it was using endpoint exception list + value lists (unsupported)
* Adds `quick_start_value_list_references.sh` to create exception lists/items, value lists, and references to easily test
* Add support to `findExceptionList` for searching for both `simple` and `agnostic` list types
* Two new query params have been added to the `deleteListRoute`
* `ignoreReferences` (default:false) when true, maintains pre-7.11 behavior of deleting value list without performing any additional checks.
* NOTE: As written, this becomes an API breaking change as existing existing calls to the same API will `409` conflict if references exist. cc @jmikell821 @DonNateR
* `deleteReferences` (default:false) to perform dry run and identify referenced exception lists/items
## Testing
To test, run `quick_start_value_list_references.sh` and it will create all the necessary resources/references to easily exercise the above functionality. The below diagram details the resources created and how the references are wired up.
> Creates three different exception lists and value lists, and associates as
> below to test referential integrity functionality.
>
> NOTE: Endpoint lists don't support value lists, and are not tested here
>
> EL: Exception list
> ELI Exception list Item
> VL: Value list
>
> EL1 EL2 (Agnostic) EL3
> | | |
> ELI1 ELI2 ELI3
> |\ /| |
> | \ / | |
> | \ / | |
> | \ / | |
> | \/ | |
> | /\ | |
> | / \ | |
> | / \ | |
> | / \ | |
> |/ \| |
> VL1 VL2 VL3 VL4
> ips.txt ip_range.txt text.txt hosts.txt
>
Corner cases to be aware of:
* An exception item may have multiple value list entries -- only referenced value list entries should be removed
* There is no API for removing individual entries. If all entries are references the entire item is deleted. If only some entries are references, the item is updated via a `PUT` (no `PATCH` support for exception items)
* It's not possible via the UI to create a space agnostic list that has value list exception items (only agnostic endpoint exception lists can be created and they do not support value lists). Please use above script to exercise this behavior.
Additional notes:
* Once the Exception List table is introduced (https://github.com/elastic/kibana/pull/85465), we can add an enhancement for deeplinking to exception lists from the reference error modal.
* The `deleteListRoute` response has been updated to include the responses from the reference checks to provide maximum flexibility
* There is no bulk API for deleting exception list items, and so they are iterated over via the `deleteExceptionListItem` API.
##### Reference error modal
<p align="center">
<img width="500" src="https://user-images.githubusercontent.com/2946766/102199153-813e1e80-3e80-11eb-8a9b-af116ca13df9.gif" />
</p>
##### Overflow example
<p align="center">
<img width="500" src="https://user-images.githubusercontent.com/2946766/102199032-5784f780-3e80-11eb-81c7-17283d002ce4.gif" />
</p>
### Checklist
Delete any items that are not applicable to this PR.
- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
### For maintainers
- [X] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
