* Here's the logic
* Added GenericEndpointInlineEditableTable
* small component test suggestions
- clarify relationship between onX props and logic actions
- assert on a few props (isLoading override and title ...rest)
* [opinionated] remove EndpointRoute generic
I'm not sure I see the benefit of DRYing this type - it makes it less clear that the prop is a function, and when all the other onX props are standard typescript function defs and repeated a bunch next to them, it seems a bit futile
In this scenario I'd rather us be explicit if repetitive (and be able to skim all props/actions at once) than obtuse but super DRY
* Fix reorderItems ts-ignores
- remove unnecessary hasReorderProps fn in favor of an early return
- destructure props
- remove confusing itemsFromResponse destructure in favor of a 2nd line
* Fix TODO where we don't actually set table loading state to true for the async call
* Fix ts-ignored
+ prefer 2nd const over confusing destructure
* [opinionated] clean up unnecessary separate types
since reorder props are optional anyway, I don't see a reason to separate them out into a completely different type
* Refactor stripIdAndCreatedAtFromItem to a util file, write tests, and attempt to address type TODO
- not really sure the type change is accurate, but ? should minimize the impact
* [opinionated] Remove saveAndCallback fn in favor of straightforward try/catch http calls
- easier to read and requires less jumping back and forth through the file to see what's happening in what order
- matches the flow/pattern of all our other logic files http calls
- it's actually 16 less total lines in any case heh
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Constance Chen <constance.chen.3@gmail.com>
* migrate integration tests to the new es client
* error field does not exist on result
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [dev-utils/run] support --info flag when default log level changed
* update kbn/pm dist and remove excess --debug flag
Co-authored-by: spalger <spalger@users.noreply.github.com>
* [Reporting CSV] Fix scroll ID bug for deprecated csv export
* fix unit test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* check analyzed_fields exists
* update DataFrameAnalyticsConfig type to make analyzed_fields optional
* updating accessing analyzed_fields for type update
* add isClearable function for checking notifications index
* clear messages from multiple indices when messages stored in multiple indices
* only return clearable indices. update disable clear button check
* add unit test
* [Lens] Formats correctly the falsy values on the x axis
* Address PR comments
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ILM] Server to use new in_use_by property returned by ES API
* [ILM] Cleaning up the PR changes
* [ILM] Fixed functional test
* [ILM] Fixed 'modifiedDate' display in the table
* [ILM] Fixed sorting test
* [ILM] Removed a not needed function declaration
* [ILM] Added index templates flyout to the policies list
* [ILM] Added test for the index templates flyout
* [ILM] Added an a11y test for the index templates flyout
* Update x-pack/plugins/index_lifecycle_management/public/application/components/index_templates_flyout.tsx
Co-authored-by: debadair <debadair@elastic.co>
* [ILM] Fixed jest test and made 0 index templates to not open the flyout
* [ILM] Fixed a11y test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: debadair <debadair@elastic.co>
* set correct focus ring for each theme
* fix field and dimension button span faux focus
* fix dimension button focus
* add mixin to remove euiFocusRing
* clean up the mess
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* adjust alignment of field errors + timeline icon
* Use options popover instead of two continuous inputs
* Set max row size
* Reduce error callout size to s
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Reporting Management] Add warning for deprecated types
* record -> job rename
* restore previous report from archive
* more fn testing
* better testing
* use consts
* add table text test
* nicer archived reports archive
* fix test
* add comment about completed
* remove warning button
* consistent status detail message and callout buttons
* rename the deprecated report
* fix status messages
* update copy
* fix duplicated created_at reports
* fix 18n
* back out text add
* fix fn test snapshot
* [Reporting] fix binding of methods that are called via event handlers
* self review
* spot-fix more untranslated content
* Update x-pack/plugins/reporting/public/lib/job.tsx
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add icon to service link in transaction flyout
* Add icon to service link on transaction spans
* Add backend section with icon and link to span flyout for backend spans
Also:
* Create ServiceLink and BackendLink components and use them wherever the icons with the links are used.
* Rename subType prop to subtype on SpanIcon component
Fixes#103264.
* [ML] Transforms: Adds a type column to the transforms management table
* [ML] Stabilize checks for transform table expanded row content
* [ML] Remove unnecessary expected row data type field
* [ML] Add timeouts to assertTransformExpandedRow existOrFail calls
* [ML] Use separate retry for each expanded row tab click
* [ML] Remove skip from permissions tests
* [ML] Correct suite title for read permissions tests
* wip to remove drag & drop
* fix timeline action visibility and filter present on scroll
* remove unused class
* clean up hover actions
* add isDraggable on row render to allow the control of drag and drop
* fix add to timeline to work the old way
* fix types + unit test
* fix cypress test, I went to fast with the renaming
* review I
* fix pagination
* fix type introduce by another PR
Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
* Add possibility to sync query and filter from state
* Fix unit-tests
* Fix name
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>