Commit graph

38 commits

Author SHA1 Message Date
Caroline Horn 03c2c6e8f4
Point to EUI for SASS/CSS guidelines (#27415) 2018-12-18 14:39:38 -05:00
Clint Andrew Hall 795ee7e5d8
Update js_style_guide.md
We need to explicitly rule out using double-quotes to escape single quotes.  Consider looking into our lint/prettier ruleset for enforcement.
2018-10-25 16:27:36 -05:00
CJ Cenizal 1a65b3577a
Update JS style guide with rule for prefixing private class methods with an underscore. (#20851) 2018-07-17 08:44:51 -07:00
Tim Roes cb5ee01c6a
Increase prettier line width to 100 (#20535)
* Increase prettier line width to 100

* Fix packages JS prettier

* Change style guide to 100 width

* Fix line-width in latest master changes
2018-07-09 22:50:37 +02:00
Josh Soref 2b27fb1c5f Fix misspellings (#19981) 2018-06-26 20:17:41 -07:00
Spencer ef3339bd7a
[@kbn/ui-framework] move ui-framework to a package (#17085)
* [@kbn/ui-framework] move ui-framework to a package

* [@kbn/ui-framework] restore doc_site index.html and fix build task names

* [jest] always ignore modules in target dirs
2018-03-13 10:43:39 -07:00
Kim Joar Bekkelund e58b43f744
Prettier + ESLint setup (#16514)
* Move .eslintrc (yaml) to .eslintrc.js (js)

* Add Prettier setup to ESLint

* Run Prettier on @kbn/build

* Update style guide with Prettier
2018-02-05 18:18:43 +01:00
CJ Cenizal c55beed24f
Remove testing style guide. (#15699) 2017-12-19 11:28:30 -08:00
CJ Cenizal 3bd256c1c4
Reinstate and skip Dashboard and Visualize tests (#15687)
* Reinstate and skip flaky Dashboard view edit tests.
* Reinstate and skip flaky Visualize gauge chart tests.
2017-12-19 10:23:32 -08:00
CJ Cenizal 8fde003a21 Update accessibility guide with note that it's valid to use aria-label directly on form elements. (#14361) 2017-10-11 09:50:32 -07:00
Stacey Gammon 9587611ca8 Update react style guide (#13958) 2017-09-12 15:57:35 -04:00
Jonathan Budzenski 221465f5e2 [style guide/accessibility] button or href for clicking (#13938) 2017-09-11 11:34:44 -05:00
Tim Roes 7cc823c863 Move htmlIdGenerator to ui_framework (#13906)
* Move htmlIdGenerator to ui_framework

* Use jest expect instead of chai

* Add htmlIdGenerator to accessibility styleguide

* Improve the writing of the accessibility styleguide
2017-09-11 13:22:32 +02:00
archana 039d6d8cca Update react style guide for jsx/object-curly-spacing never (#13889) 2017-09-08 09:53:23 -05:00
Tim Roes 99f1c65c4b Initial version of accessibility guide (#13390)
* Initial version of a11y guide

* Move a11y content from HTML guide to a11y guide

* Add PR feedback

* Add PRs feedback

* Add more roles

* Refactor labeling elements section

* Rename "labeling elements" -> "naming elements"

* Use span instead of i for icon examples

* Correct typo
2017-08-14 07:42:06 +02:00
CJ Cenizal 720297d8da [UI Framework] Reorganize UI Framework and add Yeoman generator (#13172)
* Reorganize documentation styles so they all live in doc_site/components directory. (#12809)
  - Remove global styles, e.g. body and html element selectors.
* Create global_styles dir with sub-directories. (#12833)
* Add SCSS style guide. (#12850)
* Refactor UI Framework directory structure to house everything in a src directory. (#12880)
  - Add components/index.js and services/index.js files to continue to export JS modules from the root.
* Add KUI Yeoman generator.
* Support creation of components.
* Add documentation generator for main page, demo, and sandbox.
  - Add additional documentation snippets to KUI generator. (#13076)
  - Fix incorrect use of double quotes in KUI generator snippet. (#13086)
  - Remove infrequently used imports from the KUI generator test template. (#13110)
* Mock assets files for Jest. (#13060)
* Fix broken coverage report paths in Jest config. (#13082)
* Update eslint config to lint the new UI Framework directory structure. (#13102)
* Fix positioning of doc site pagination buttons. (#13203)
* Support hasReact prop for sandboxes. (#13270)
* Remove deprecated used of component mixin from KUI generator's SCSS template. (#13377)
* Fix rebasing errors.
  - Add dashboard back to Jest config.
  - Add missing form and tool_bar variables.
* Rename tasks to createComponent and documentComponent.
* Reference correct src paths in README.
* Add children and className to templates' propTypes.
* Add default folder name for page demo.
* Add suffix to sandbox routes.
* Specify testPathIgnorePatterns more clearly.
* Rename component.test.js to test.js so that Jenkins won't try to run it.
* Update npm scripts to depend on local yo dependency, not global.
* Add ui_framework/src to copy task.
* Simplify npm scripts and remove requirement for installing Yeoman from README.
* Add services to moduleNameMapper in jest config.
* Clean up Button and Gallery examples.
2017-08-11 08:48:48 -07:00
Felix Stürmer 47db80d6f8 [docs] Add css style guide section on open/closed principle (#12276) 2017-08-07 18:04:25 +02:00
Tim Roes 2043cf0e0a Add rule about tabindex > 0 to the styleguide (#12981) 2017-07-22 07:48:02 +02:00
CJ Cenizal e3af175b77 Update HTML style guide with rule about putting nested elements on multiple lines. (#12812) 2017-07-17 13:34:36 -07:00
Shaunak Kashyap 083b11eccc Moving React styleguide next to other style guides (#12361)
* Moving React styleguide next to other style guides

* Adding React style guide to style guides index file
2017-06-15 07:42:35 -07:00
CJ Cenizal 41b8ac0e6e Add title and tooltip accessibility information to HTML style guide. (#11655)
* Add title and tooltip accessibility information to HTML style guide.
* Add sections on native interactive elements and tab order.
2017-06-08 14:55:51 -07:00
CJ Cenizal ed8951a816 Update HTML style guide with rule for camel casing attribute values. (#11653)
* Update HTML style guide with rule for camel casing attribute values.
* Add notes about using the same capitalization in HTML and CSS.
2017-06-08 13:01:31 -07:00
Jim Unger 3ff7d5b6fa Adds subdirectories section to architecture style guide (#11187)
Adds subdirectories section to architecture style guide
2017-04-12 13:53:08 -05:00
Joe Fleming c8c03e5fec add architecture styleguide (#10094)
* add architecture styleguide

* be clearer about application architecture

* define as plugin architecture

and downplay the webpack alias and shims that are available

* fix typo, simplify server description
2017-02-06 15:34:39 -07:00
Stacey Gammon fc25df18f6 Fix link syntax 2017-01-12 13:30:04 -05:00
Stacey Gammon 7ead88eb09 Update style guide for named exports
Add new 'named exports' only rule: https://github.com/elastic/kibana/issues/8641
2017-01-12 13:29:04 -05:00
CJ Cenizal 045e654c15 Explain rationale of HTML bracket formatting in HTML style guide. (#9629) 2016-12-23 12:16:51 -08:00
CJ Cenizal cebf834321 Fix markdown typo in CSS style guide. (#9408) 2016-12-07 13:20:02 -08:00
CJ Cenizal 7cdd29822f Use data attribute to select loading message, instead of CSS class… (#9248)
* Use uniquely and semantically named data attribute to select loading message, instead of CSS class since that creates a brittle coupling between JS and CSS.
* Formalize this rule in the CSS style guide.
2016-11-29 14:21:57 -07:00
CJ Cenizal 80aaaf2872 Add preprocessor-related rules to CSS style guide. (#8921) 2016-11-02 10:44:18 -07:00
Court Ewing 7dae7bde27 Current styleguide conventions with modern JS (#7435)
The existing styleguide was in great need of a rewrite as it did not
reflect the conventions we're using in the codebase or even the best
practices that we follow. In some cases, the guidance it provided was
outright contrary to our current practices.
2016-11-01 21:22:59 -04:00
CJ Cenizal 35fc5f40a3 Merge pull request #8859 from cjcenizal/improvement/css-style-guide-references
Add BEM references to CSS style guide.
2016-10-27 12:12:31 -07:00
CJ Cenizal bbf948ed1a Add BEM references to CSS style guide. 2016-10-27 12:09:03 -07:00
CJ Cenizal bc1b49b88e Fix CSS style guide state class naming convention to be camel case. 2016-10-27 11:54:40 -07:00
CJ Cenizal 2c5e2bff3c Update CSS style guide with new state class format. Change examples to use component name instead of namespace. 2016-07-26 16:12:37 -07:00
CJ Cenizal 4cc4252230 Change HTML style guide. Specify that the opening tag's closing bracket goes on its own line. 2016-06-27 09:32:00 -07:00
CJ Cenizal 81fb346a8c Update API and HTML style guides.
- 80-character line limit in HTML.
2016-06-09 15:32:03 -07:00
CJ Cenizal 9d8776b199 Add style_guides dir, extracted sections from STYLEGUIDE.md.
- css_style_guidee.md
- js_style_guide.md
- html_style_guide.md
- api_style_guide.md
2016-06-09 08:13:35 -07:00