Commit graph

43867 commits

Author SHA1 Message Date
Kibana Machine 2f9b026a80
fix unit prop and default it only in the tGrid body (#109252) (#109389)
Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
2021-08-24 22:47:53 +00:00
Kibana Machine 10a7f73753
Prevent long errors from breaking UI (#109899) (#109936)
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
2021-08-24 18:05:10 -04:00
Kibana Machine 9af96a8009
[Enterprise Search] Set up cypress-axe tests (#108465) (#109920)
* Set up cypress-axe

@see https://github.com/component-driven/cypress-axe

* DRY out Kibana axe rules into constants that Cypress can use

* Create shared & configured checkA11y command

+ fix string union type error
+ remove unnecessary tsconfig exclude

* Add Overview plugin a11y tests

* Add AS & WS placeholder a11y checks

- Mostly just re-exporting the shared command and checking for failures, I only ran this after the shared axe config settings and found no failures

* Configure our axe settings further to catch best practices

- notably heading level issues (thanks Byron for catching this!)

- however I now also need to set an ignore on a duplicate landmark violation caused by the global header (not sure why it's showing up - shouldn't it be out of context? bah)

- remove option to pass args into checkA11y - I figure it's not super likely we'll need to override axe settings per-page (vs not running it), but we can pass it custom configs or args later if needed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
2021-08-24 21:28:49 +00:00
gchaps 3006381216
[7.x] [DOCS] Updates create index pattern (#106935) (#109748)
* [DOCS] Updates create index pattern (#106935)

* [DOCS] Updates create index pattern

* [DOCS] Adds info on refresh

* Update docs/concepts/index-patterns.asciidoc

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update docs/concepts/index-patterns.asciidoc

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update docs/concepts/index-patterns.asciidoc

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update docs/concepts/index-patterns.asciidoc

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update docs/concepts/index-patterns.asciidoc

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* [DOCS] Addresses more review comments

* [DOCS] Updates images

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update docs/concepts/index-patterns.asciidoc

* Update docs/concepts/index-patterns.asciidoc

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
2021-08-24 17:28:36 -04:00
Kibana Machine 7b0adb268c
[Maps] fix choropleth map with applyGlobalQuery set to false still creates filter for source. (#108999) (#109915)
* [Maps] fix choropleth map with applyGlobalQuery set to false still creates filter for source.

* cleanup functional test

* eslint

* fix functional test

* add inidication in tooltip when field is join key

* copy updates

* update jest test

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
2021-08-24 17:10:40 -04:00
Kibana Machine 5e3572ef51
[Security Solution] Add reason field (#108449) (#108645)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
2021-08-24 16:56:44 -04:00
Kibana Machine d30ae561bc
[Fleet] Fix Add Integration page title + Add Integration button icon (#109728) (#109913)
* Fix page title for add integration page

* Revert Add Integration icon to plusInCircle

Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
2021-08-24 16:46:01 -04:00
CJ Cenizal 7947341c82
Add "Back up data" step to UA (#109543)
* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.
2021-08-24 12:51:41 -07:00
Kibana Machine a79cc45384
[RAC] Fix scrolling on Obs alerts table (#109139) (#109895)
* Fix scrolling on obs alerts table and default to 50 items per page

Co-authored-by: Kerry Gallagher <471693+Kerry350@users.noreply.github.com>
2021-08-24 15:42:40 -04:00
Kibana Machine 04103e9ac6
[APM] Suggestion to remove "Kuery" bar from Logs view in APM service overview experience (#109733) (#109884)
* removing kuery bar from logs tab

* fixing ts issue

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2021-08-24 15:01:22 -04:00
Kibana Machine 90c181e722
[Workplace search] Fix several router issues (#109839) (#109881)
* Make "Add more sources" button take users to Add Sources instead of Sources

* Remove several redundant variables in codebase

`canCreateInvitations` and `canCreateContentSources` are always true for admin.
If someone can access admin dashboard, we can safely assume that they are admin.

`isCurated` is outdated variable and backend always returns it as false.

* Add redirect from workplace_search/p/ to workplace_search/p/sources/

Before workplace_search/p/ was returning 404

* Fix redirect always being fired on `workplace_search/p/sources/add` page load

When opening `workplace_search/p/sources/add` as a bookmark or reloading this page,
Sources router first get rendered *before* it receives the canCreatePersonalSources value.
This results in canCreatePersonalSources always being undefined on the first render,
and user always getting redirected to `workplace_search/p/sources`.
Here we check for this value being present before we render any routes.

Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
2021-08-24 14:47:16 -04:00
Michael Dokolin c74f4e9a2d
[Reporting] Increase unit tests coverage (#109547) (#109878) 2021-08-24 14:33:42 -04:00
Kibana Machine 80adb999b1
Cleanup after ExecLog integration (#107695) (#109871)
Co-authored-by: Dmitry Shevchenko <dmshevch@gmail.com>
2021-08-24 14:07:49 -04:00
Kibana Machine ea9803b444
[Uptime] [Synthetics Integration] Synthetics fix tests (#109706) (#109865)
* focus tests

* adjust id

* unfocus test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-08-24 17:35:05 +00:00
Kibana Machine 7ab80e5497
[Security Solution] - hide alerts from deepLinks if no read privilege (#109510) (#109863)
* hide alerts from deepLinks if no read privilege

* explanatory comment added

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
2021-08-24 13:34:19 -04:00
Kibana Machine 26509e91c4
[Maps] fix auto fit to bounds not working when map is embedded in dashboard (#109479) (#109858)
* [Maps] fix auto fit to bounds not working when map is embedded in dashboard

* tslint and eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
2021-08-24 17:12:38 +00:00
Kibana Machine 792760bce4
[Security Solution] [Bugfix] Fixes broken alert actions (add to case, investigate in timeline) (#109339) (#109855)
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
2021-08-24 13:11:38 -04:00
Kibana Machine b1c0879b11
Fix field formatters test on cloud (#109707) (#109851)
Co-authored-by: liza-mae <liza-mae@users.noreply.github.com>
2021-08-24 12:37:23 -04:00
Kibana Machine ee3b2f5030
Update Missing Privileges callout (#109420) (#109810)
Co-authored-by: Dmitry Shevchenko <dmshevch@gmail.com>
2021-08-24 16:33:46 +00:00
Kibana Machine ef248aefdf
[canvas] Prevent scroll 'jumping' with always-there scrollbars (#109765) (#109848)
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
2021-08-24 12:33:30 -04:00
Kibana Machine 7467f58ead
[DataViews] Fix redundant fields requests that cause errors (#109702) (#109845)
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
2021-08-24 12:30:32 -04:00
Kibana Machine ee46f33668
[Security Solutions] Adds missing exceptionable field for behavior protections (#109782) (#109838)
Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>
2021-08-24 12:02:54 -04:00
Kibana Machine 44f7b620cc
[Metrics UI] Unskip Inventory View Saved View Tests (#109697) (#109841)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Chris Cowan <chris@chriscowan.us>
2021-08-24 11:58:51 -04:00
Cauê Marcondes d0195d7897
adding e2e test (#109723) (#109835) 2021-08-24 11:47:22 -04:00
Alejandro Fernández Gómez e638552b6f
[7.x] [RAC] Enable workflow status filtering (#108215) (#109817)
* [RAC] Enable workflow status filtering (#108215)

Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
#	x-pack/plugins/observability/public/pages/alerts/index.tsx

* Backport changes in the tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-24 11:43:28 -04:00
Kibana Machine 89d8ad0a0b
[App Search] Fix typo in content verification fallback message (#109743) (#109833)
Co-authored-by: Orhan Toy <toyorhan@gmail.com>
2021-08-24 15:29:11 +00:00
Kibana Machine 2eece0e659
[Maps][Docs]Reverse geocoding tutorial (#108712) (#109869)
* [Maps] reverse geocoding tutorial

* reverse geocoding step

* add final step

* use dash delemiter instead of underscore in file name

* add float to step 3 so its on the same page

* add into to step 3

* update csa URL to point to elastic/examples repo

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* review feedback

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/reverse-geocoding-tutorial.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* add sentence about not needing geoip

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-08-24 11:27:15 -04:00
Kibana Machine b0f8ffdc1a
[Security Solution][RAC] - Hide hover actions overflow (#109693) (#109819)
* add overflow

* fix types error

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2021-08-24 10:04:00 -04:00
Kibana Machine c3a387d2f8
[APM] Use useTimeRange where possible (#109572) (#109803)
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
2021-08-24 13:33:49 +00:00
Michael Olorunnisola c4f35a26d1
[Security Solution][RAC] Remove toggle column when not usable (#109534) (#109729) 2021-08-24 09:33:19 -04:00
Kibana Machine 9bf9b6c073
[ML] Removes hardcoded datafeed indices for security auth and network modules (#109692) (#109784)
Co-authored-by: Pete Harverson <peteharverson@users.noreply.github.com>
2021-08-24 13:08:18 +00:00
Kibana Machine 4bdee23be3
[Alerting][Docs] Updating alerting setup docs (#109285) (#109827)
* Updating alerting authorization docs

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-08-24 08:37:57 -04:00
Kibana Machine 94b12f1af4
[Data][Es Query] Use ES types in Filters (#108378) (#109793)
* es-query types

* jest and lint

* cc

* options

* type

* types for kuery FUNCTIONS

* doc

* types for filters

* sec fixes

* filtersss

* typey type

* typey type

* comparator options

* test typescript

* test

* fixes

* test types

* test

* cr

* cleanup a bit more

* Jest fix + types

* Remove geo bounding box and geo polygon filters

* delete geo filters

* geo

* geo

* Fix tests \_0_/

* doc

* types and fixes

* jests

* ts

* Remove geo bounding box and geo polygon filters

* delete geo filters

* delete geo filters

* geo

* remove geo docs

* ts

* plg ts

* types

* cast

* Update types.ts

* Update create_threat_signal.ts

* Update packages/kbn-es-query/src/es_query/migrate_filter.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* Code review

* revert change

* docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

Co-authored-by: Liza Katz <lizka.k@gmail.com>
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
2021-08-24 07:56:17 -04:00
Georgii Gorbachev 64a79a1a41
[Security Solution] Fixes the Alerts timeline failing test on master (#109644) (#109716)
* fixes 'Alerts timeline' tests

* adds data test subj for the loading spinner

Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-24 07:01:01 -04:00
Ashokaditya ecd0e434e2
remove min and max date restrictions (#109452) (#109597) 2021-08-24 06:50:59 -04:00
Kibana Machine 2e33b422cd
fix disabled dropdown in alerts table (#109724) (#109780)
Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
2021-08-24 06:27:50 -04:00
Kibana Machine f57fa6da17
[ML] Update API docs generation script to comply with new docs format (#109343) (#109781)
* [ML] update deps

* [ML] fix script

* [ML] add header

* [ML] generate header

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
2021-08-24 06:21:39 -04:00
Uladzislau Lasitsa e4fa7e4936
[Saved Search] Interrupted Loading Throws Console Error (#108926) (#109775)
* Add check if embeddable was destroyed.

* Move isDestroyed inside SavedSearchEmbeddable

* Use destroyed variable from parent

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-24 06:05:04 -04:00
Kibana Machine 799bffbe04
Fix detection rules link for memory and behaviour protections cards (#109591) (#109648)
Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>
2021-08-24 09:56:54 +00:00
Kibana Machine e9929082ed
Improve APM issue template (#109561) (#109778)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
2021-08-24 04:03:21 -04:00
Kibana Machine 10ccb2ff6c
[canvas] Fix numeric variable casting (#109744) (#109762)
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
2021-08-24 02:05:06 -04:00
Kibana Machine a30bd65e60
Remove CrawlerLanding page (#109712) (#109758)
* Remove CrawlerLanding page

The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.

* Remove translations from ja-JP and zh-CN

Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
2021-08-24 00:44:26 -04:00
Kibana Machine 6584864f77
[Security Solution][Detections] Fixes broken cypress test (#109533) (#109552)
## Summary

Fixes `acknowledged.spec.ts` test that is currently failing on some ci builds

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
2021-08-24 04:25:35 +00:00
Kibana Machine 46008337fc
[Security Solution][RAC] - Remove timestamp from reason field (#109492) (#109683)
* remove timestamp from reason

* fix test type errors

* update tests

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2021-08-24 03:26:51 +00:00
Kibana Machine 534d6c45ca
[RAC] [Security Solution] Hides the Show top <field> action in chart legends (#109566) (#109658)
## Summary

Fixes <https://github.com/elastic/kibana/issues/108910> , which allowed users to launch a new `Top <field>` popover from an existing popover, to infinity (and beyond)

The `Show top <field>` action is now hidden in the `Top <field>` popover's chart legend, and also:

- In the legend items of charts throughout the Security Solution (e.g. on the `Overview` page, and in the `Trend` chart on the `Alerts` page)
- For items in the `Count` aggregation table on the `Alerts` page

## Screenshots

### Before (Top `signal.rule.name` popover)

![before-top-signal-rule-name](https://user-images.githubusercontent.com/4459398/130302784-00a6c24d-17c8-4361-979e-01b8467f100e.png)

_Above: It was possible to launch another `Top <field>` popover from the legend of an existing popover_

### After (Top `signal.rule.name` popover)

![after-top-signal-rule-name](https://user-images.githubusercontent.com/4459398/130302925-d5aaa1ff-9565-4374-aa87-bde5880cb64f.png)

_Above: It is no longer possible to launch another `Top <field>` popover from the legend of an existing popover_

### Before (Chart legends)

![before-overview](https://user-images.githubusercontent.com/4459398/130303169-dc6c6de3-a2ba-40fe-a1f0-fe0d78b9638c.png)

_Above: It was possible to launch a `Top <field>` popover from chart legends_

### After (Chart legends)

![after-overview](https://user-images.githubusercontent.com/4459398/130303519-2eb0a60e-c6cd-4659-b6b2-d5ba234f668f.png)

_Above: It is no longer possible to launch a `Top <field>` popover from chart legends_

### Before (`Count` items)

![before-count](https://user-images.githubusercontent.com/4459398/130304111-b37373cf-1afb-41b8-9f38-b5d9b37cdb2d.png)

_Above: It was possible to launch a `Top <field>` popover from `Count` items_

### After (`Count` items)

![after-count](https://user-images.githubusercontent.com/4459398/130304166-fb641fa2-b52e-44ff-8210-0e228a43330c.png)

_Above: It is no longer possible to launch a `Top <field>` popover from `Count` items_

cc @mdefazio

Co-authored-by: Andrew Goldstein <andrew-goldstein@users.noreply.github.com>
2021-08-24 03:25:25 +00:00
Kibana Machine 6bd512c452
[Security Solution][RAC] Adds OR bool for acknowledged status filter (#109348) (#109556)
Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
2021-08-24 03:25:03 +00:00
Kibana Machine b63dd13f46
[RAC] Alerts table widths updated (#109267) (#109559)
* action and ts column widths changed

* snapshot updated

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
2021-08-24 03:24:53 +00:00
Kibana Machine 58948b00cc
[RAC] Actions popovers UI unification (#109221) (#109638)
* popover padding size unified

* remove panels from all context menus

* action items order changed

* cases menu items test fixed

* translations and small changes

* remove components not used anywhere

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
2021-08-24 03:15:59 +00:00
Kibana Machine 7dae9e68b9
[RAC] [Observability] Temporarily enable RAC feature flags (#109113) (#109753)
* Temporarily enable Observability RAC feature flags

This enables the feature flags for two weeks until a decision is made
about keeping it on or reverting to the disabled-by-default state.

* Adapt uptime functional test

* Adapt additional functional tests

* Adapt cases functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
2021-08-23 21:31:07 -04:00
Alison Goryachev 77fe9ecf30
[Upgrade Assistant] Update readme (#109502) 2021-08-23 20:17:59 -04:00