Commit graph

30888 commits

Author SHA1 Message Date
Victor Martinez
446fda62f2
[jenkins] Notify GH Checks for the apm-ui e2e pipeline (#52900) 2020-02-18 08:25:14 +00:00
James Gowdy
3c51fb0314
[ML] File data viz fix index pattern warning after index change (#57807) 2020-02-18 07:16:40 +00:00
James Gowdy
c31c7ee4c7
[ML] Adding get buckets endpoint wrapper (#57752)
* [ML] Adding results buckets endpoint wrapper

* removing unnecessary spread operator

* correcting timstamp format in api doc

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-17 15:06:42 +00:00
Vadim Dalecky
d21d33d0b6
fix: 🐛 don't cast to any (#57799)
EUI 19.0 was merged into Kibana which supports React elements as context
menu items, so we don't need to cast to any here anymore.
2020-02-17 15:25:17 +01:00
Vadim Dalecky
85d737c401
ExecutionContract (#57559)
* feat: 🎸 add ExecutionContract class

* test: 💍 add Execution and Executor tests

* feat: 🎸 add .execute() method to ExpressionsService

* refactor: 💡 replace ExpressionDataHandler by ExecutionContract

* fix: 🐛 fix TypeScript typecheck errors

* docs: ✏️ add JSDocs to ExecutionContract

* refactor: 💡 make .ast and .expresions both optional

* test: 💍 fix test

* test: 💍 fix a test

* test: 💍 fix interpreter functional tests
2020-02-17 15:02:21 +01:00
Vadim Dalecky
ca5e25c139
Local actions (#57451)
* feat: 🎸 create UiActionsService

* feat: 🎸 add UiActionsServvice.fork() method

* feat: 🎸 instantiate UiActionsService in plugin

* feat: 🎸 add UiActionsService.registerTrigger(), remove old

* feat: 🎸 move attach/detachAction() methods to UiActionsService

* refactor: 💡 move remaining actions API to UiActionsService

* chore: 🤖 clean up /trigger folder

* test: 💍 move registry tests into UiActiosnService tests

* fix: 🐛 fix TypeScript typecheck errors

* test: 💍 add .fork() trigger tests

* feat: 🎸 remove actionIds from ui_actions Trigger interface

* fix: 🐛 remove usage of actionIds

* fix: 🐛 attach hello world action to trigger in plugin lifecycle

* feat: 🎸 fork also trigger to action attachments

* fix: 🐛 clear mapping registry in .clear(), improve type
2020-02-17 14:59:47 +01:00
Joe Reuter
9388ff7b43
Fix auto refresh in visualizations and lens (#57667) 2020-02-17 13:52:53 +01:00
Cauê Marcondes
f49581ce34
[APM] Divide "Actions menu" into sections to improve readability (#56623)
* transaction actions menu

* transaction actions menu

* fixing pr comments

* fixing pr comments

* fixing pr comments

* fixing pr comments

* fixing unit test

* fixing unit test

* using moment to calculate the timestamp

* renaming labels

* Changing section subtitle

* fixing unit tests

* replacing div for react fragment

* refactoring

* removing marginbottom property

* div is needed to remove the margin from the correct element
2020-02-17 12:05:46 +00:00
Alejandro Fernández Haro
5c7af8656f
[Telemetry] Fix bug introduced in #55859 (#57441)
* [Telemetry] Refactor to TS Monitoring telemetry_collection files

* [Telemetry] Fetch side documents generated by monitoring to build up the Kibana plugins stats

* Update x-pack/legacy/plugins/monitoring/server/telemetry_collection/get_beats_stats.ts

Co-Authored-By: Ahmad Bamieh <ahmadbamieh@gmail.com>

* Fix import in test file

* Move mocha tests to Jest + TS

* Fix extended telemetry in functional tests

* Fix types

* [Telemetry] Fix bug in usage_collector wrong function override

* Revert integration tests (change not needed)

Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-17 11:21:01 +00:00
Walter Rafelsberger
54f5cc1ce3
[ML] Anomaly Detection: Fixes hiding date picker for settings pages. (#57544)
- Fixes hiding the global date picker on anomaly detection settings pages.
- Consolidates various timefilter usages for enabling/disabling the date picker into a useTimefilter() hook.
2020-02-17 11:53:42 +01:00
James Gowdy
545240065a
[ML] Categorization examples privilege check (#57375)
* [ML] Categorization examples privilege check

* adding privileges check to endpoint

* fixing typo

* moving privilege check to router

* removing unused variable

* rebasing master

* removing comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-17 10:47:50 +00:00
Jean-Louis Leysens
3d7bae4ed2
Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (#57563)
* Move mode and lexer rules to shared space

* Update searchprofiler mode rules

* Moved x-json worker out of searchprofiler and into es_ui_shared (for use in Watcher)
Renamed ace/mode -> ace/modes

* Moved collapse and expand literal string functions to es_ui_shared

* Fix some imports
Enable Watcher editor to parse XJson using XJsonMode

* Fix imports

Import JSON highlight rules in XJSONHighlight rules

* Move console_lang, fix Jest tests

Exporting console_lang through the es_ui_shared/public barrel caused the XJsonMode to imported to a index_management too and any other plugin that may
import something from that directory. console_lang was moved to it's own top level directory es_ui_shared/console_lang.

We also included a mock for tests using XJsonMode to import from console_lang.

* Fixed OSS Jest tests

Console Jest tests were still failing because they did not mock out the raw-loader imported worker file

* Expand triple quotes in editor

Upon entering the advanced watcher creation view, the JSON should be scanned for triple quote expansion

* Bring all editors themes in line

Editors had github theme, which diverged from the textmate theme used in Console and SearchProfiler

* Added XJSON mode to simulate alternative input editor

Slight refactor to the logic for using XJSON mode. Created an adhoc hook for wrapping the
logic of useState and moved lanugage util imports there too to reduce the number of imports
in both the watcher form and simulate tabs in advanced creation.

* Moved x-json worker to x-pack

x-json worker is currently only used inside of x-pack. Also testing
for if this will fix the CI/prod build

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-17 11:06:20 +01:00
Jean-Louis Leysens
26fdc4a6b3
[Upgrade Assistant] Fix filter deprecations search filter (#57541)
* Made eui search field not a controlled component
Added validateRegExpString util

* Update error message display. Use EuiCallOut and i18n to replicate other search filter behaviour, e.g. index management.

* Remove unused variable

* Update Jest snapshot

* Updated layout for callout

The previous callout layout looked off-center next to the controls in the table.

* Update copy and remove intl

Update "Filter Invalid:" to sentence case
Remove inject intl wrapper from CheckupControls component
Remove unnecessary grow={true}

* Updated Jest component snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-17 11:03:57 +01:00
Dima Arnautov
84be262075
[ML] New Platform server shim: update indices routes (#57685)
* [ML] NP indices routes

* [ML] fix error function

* [ML] fix createAndOpenUrl function
2020-02-17 10:59:07 +01:00
patrykkopycinski
f4d29abf1c
Bump redux dependencies (#53348) 2020-02-17 09:58:54 +01:00
Sébastien Loix
8e17fdabd4
[Index management] Client-side NP ready (#57295) 2020-02-17 14:22:07 +05:30
Patrick Mueller
5d3797ee0b
change id of x-pack event_log plugin to eventLog (#57612)
change id of x-pack event_log plugin to eventLog
2020-02-16 20:10:35 -05:00
Patrick Mueller
f998174898
[eventLog] get kibana.index name from config instead of hard-coding it (#57607)
fixes https://github.com/elastic/kibana/issues/55629
2020-02-16 17:55:52 -05:00
Liza K
36599fdfac revert 2020-02-16 18:19:37 +02:00
Liza K
335c712992 allow using any path to generate 2020-02-16 18:13:22 +02:00
Ben Skelker
67087e34d1
fixes ui titles (#57535)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-16 10:39:58 +02:00
Joe Portner
3b232ae735
Fix login redirect for expired sessions (#57157) 2020-02-15 19:32:16 -05:00
Anton Dosov
e370df2e5f
Expose Vis on the contract as it requires visTypes (#56968)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-15 12:46:04 +01:00
Frank Hassanabad
94c856dd42
[SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present
## Summary

Fixes a bug where if you try to query the signals index and it is not present you would get an error that would bubble up to the UI.

Before:
<img width="824" alt="Screen Shot 2020-02-13 at 12 57 55 PM" src="https://user-images.githubusercontent.com/1151048/74499587-74881d00-4ea1-11ea-93b0-8d7258f79404.png">

After:
<img width="790" alt="Screen Shot 2020-02-13 at 8 43 28 PM" src="https://user-images.githubusercontent.com/1151048/74499619-9386af00-4ea1-11ea-889b-cb1853e399e3.png">

<img width="804" alt="Screen Shot 2020-02-13 at 8 43 34 PM" src="https://user-images.githubusercontent.com/1151048/74499624-971a3600-4ea1-11ea-862b-9695ecbadcbe.png">


Also fixes a regression bug with error toasters showing up when they shouldn't because of a signals index not existing. This only effects 7.6.x and master and is _not_ part of 7.6.0 at the moment.

* https://github.com/elastic/kibana/issues/57641

### Checklist

Delete any items that are not applicable to this PR.

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

~~- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)~~

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2020-02-14 20:14:59 -07:00
Alison Goryachev
6e3790537d
[Remote clusters] Migrate client-side code out of legacy (#57365) 2020-02-14 21:10:33 -05:00
Spencer
15e4e6c632
Fix failed test reporter for SIEM Cypress use (#57240)
* [@kbn/test] build with source-maps

* [@kbn/test] the jUnit Reporter being used for SIEM Cypress tests sometimes doesn't include testcases in XML

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 18:47:32 -07:00
spalger
0cee1a4adb skip flaky suite (#45244) 2020-02-14 18:46:01 -07:00
Dmitry Lemeshko
95b713e69d
update chromedriver to 80.0.1 (#57602)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-15 00:43:32 +01:00
Patrick Mueller
96c39a5a14
change slack action to only report on whitelisted host name (#57582)
Previously, when using the slack action with a url which was not whitelisted, the entire URL was reported in the error.  With this change, only the hostname is reported in the error.
2020-02-14 18:29:50 -05:00
Spencer
5d99576ab1
[kbn/optimizer] throw errors into stream on invalid completion (#57735) 2020-02-14 16:17:07 -07:00
Peter Pisljar
78bff535e0
moving visualize/utils to new platform (#56650) 2020-02-14 18:16:49 -05:00
Chris Roberson
e319269e18
[Monitoring] Support shipping directly to the monitoring cluster (#57022)
* Support shipping directly to the monitoring cluster

* Add timestamp

* PR feedback

* Use utc
2020-02-14 16:07:44 -05:00
Mike Côté
918c0dec9f
Increase stability when initializing the Elasticsearch index for the event log (#57465)
* Fix ILM policy creation

* Handle errors thrown in scenario multiple Kibana instances are started at the same time

* Fix tests and cleanup

* Start adding tests

* Refactor tests, add index template failure test

* Create cluster client adapter to facilitate testing and isolation

* Fix places calling callEs still

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 15:38:45 -05:00
Tim Sullivan
34ae99b516
[Reporting/New Platform] Provide async access to server-side dependencies (#56824)
* [Reporting/New Platform] Provide async access to server-side

* consistent name for reportingPlugin

* Prettier changes

* simplify reporting usage collector setup

* add more tests

* extract internals access to separate core class

* fix tests

* fix imports for jest and build

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 12:36:08 -07:00
gchaps
52a566d095
[DOCS] Adds link to migration guide (#57702) 2020-02-14 11:33:25 -08:00
Paul Tavares
fe21356020
[Endpoint] Policy List UI route and initial view (#56918)
* Initial Policy List view

* Add `endpoint/policy` route and displays Policy List
* test cases (both unit and functional)

Does not yet interact with API (Ingest).
2020-02-14 14:14:39 -05:00
Pete Harverson
73cb0aa840
[ML] New Platform server shim: update filters routes to use new platform router (#57597)
* [ML] Update filters routes to use new platform router

* [ML] Edits to filters route following review

* [ML] Edits following review and fix job service api docs

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 19:08:02 +00:00
Josh Dover
6bd09d616f
Fix maybe behavior with object type (#55932) 2020-02-14 12:06:59 -07:00
Greg Thompson
0abfd3c72f
Upgrade EUI to v19.0.0 (#57284)
* eui to v19.0.0

* typescript updates; idAria removal

* src snapshot updates

* mock euicode and euicodeblock for jest

* x-pack snapshot updates

* mock euicode for jest

* more euicode snapshots

* mock euicode in storyshots

* types/enzyme yarn.lock

* sidenav type update
2020-02-14 13:06:31 -06:00
gchaps
356e3a4776
[DOCS] Adds Save to Advanced Settings doc (#57696)
* [DOCS] Adds Save to Advanced Settings doc

* [DOCS] Incorporates review comments
2020-02-14 08:24:27 -08:00
Corey Robertson
98564f857d
Update Canvas usage of Storage from kibana-utils (#55595)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 10:57:06 -05:00
James Gowdy
52b4fe7404
[ML] Categorization wizard functional tests (#57600)
* [ML] Categorization wizard functional tests

* changes based on review

* some idiot left his own name in the code
2020-02-14 15:54:49 +00:00
Nathan Reese
d27fc476dd
[Maps] refactor Join component to remove componentDidUpdate (#57518)
* [Maps] refactor Join component to remove componentDidUpdate

* [Maps] refactor LayerPanel to remove getDerivedStateFromProps

* consolidate async layer state loading into LayerPanel component

* fix jest snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 08:36:49 -07:00
Candace Park
1492d5a372
[Endpoint] Task/basic endpoint list (#55623)
* Adds host management list to endpoint security plugin

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 10:12:34 -05:00
Robert Oskamp
f0cb03e599 Transform functional tests - disable saved search test 2020-02-14 16:08:10 +01:00
Robert Austin
a790f61460
Resolver: Animate camera, add sidebar (#55590)
This PR adds a sidebar navigation. clicking the icons in the nav will focus the camera on the different nodes. There is an animation effect when the camera moves.
2020-02-14 09:41:22 -05:00
Mike Côté
c965a9efa8
Skip flaky test (#57675) 2020-02-14 08:55:13 -05:00
Spencer
343bc9c303
[kbn/optimizer] Fix windows support (#57592)
* [kbn/optimizer] simplify run_workers.ts a smidge

* use Path.resolve() to create windows paths from normalized ones

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 06:54:24 -07:00
Walter Rafelsberger
cefe28c1f4
[ML] Fix single metric viewer chart resize. (#57578)
Fix to trigger a chart update with the correct width when resizing the browser window. Previously after a browser refresh, or opening the view from a bookmarked URL, the chart would not resize until a state change was made to the view (such as moving the zoom slider or altering the time range).
2020-02-14 14:52:04 +01:00
Angela Chuang
0adda9d270
[SIEM] Remove additional props for matrix histogram (#54979)
* update DNS histogram

* fix indent

* hide dropdown if only one option provided

* update DNS histogram

* fix types

* wip

* isolate matrix histogram on server side

* fix type for graphql

* fix types

* fix tests

* fix types

* fix types

* add unit test

* add unit test

* fix types

* split histogram configs to an object

* an idea to simplify more

* add unit test

* remove updateDateRange passing down to matrixHistogram

* change histogramType to enum

* handle the case which config not available

* fix review

* fix review II

* fix parser for dns histogram

* revert change

* isolate parsers

* fix unit

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
2020-02-14 13:44:18 +00:00