Commit graph

42162 commits

Author SHA1 Message Date
Lee Drengenberg 3270c64271
add images and content for functional UI test debugging tutorial (#96790) 2021-04-14 18:05:13 -05:00
Constance 2a281c99c6
[App Search] Refactor out a shared MultiInputRows component (#96881)
* Add new reusable MultiInputRows component

- basically the CurationQuery component, but with a generic values var & allows passing in custom text for every string

* Update CurationQueries with MultiInputRows

* Update MultiInputRows to support on change behavior

- for upcoming Relevance Tuning usage

* Update Relevance Tuning value boost form to use new component

- relevance_tuning_form.test.tsx fix: was getting test errors with mount(), so I switched to shallow()

* Change submitOnChange to onChange fn

- more flexible - allows for either an onSubmit or onChange, or even potentially both

* Convert MultiInputRowsLogic to keyed Kea logic

- so that we can have multiple instances on the same page - primarily the value boosts use case

* Update LogicMounter helper & tests to handle keyed logic w/ props

* [Misc] LogicMounter helper - fix typing, perf

- Use Kea's types instead of trying to rewrite my own LogicFile
- Add an early return for tests that pass `{}` to values as well for performance

* PR feedback: Change values prop to initialValues

+ bonus - add a fallback for initially empty components
+ add a test to check that the logic was mounted correctly

* PR feedback: Remove useRef/on mount onChange catch for now

- We don't currently need the extra catch for any live components, and it's confusing
2021-04-14 18:11:25 -04:00
Rashmi Kulkarni 3ba640403f
unskip accessibility - dashboard_edit_panel tests (#96710)
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 15:05:12 -07:00
Zacqary Adam Xeper deaa7794d5
[Fleet] Add ability to specify which integration variables should be configurable (#97163) 2021-04-14 17:00:18 -05:00
Tim Sullivan d72a7afbf4
[rfc][skip-ci] Screenshot Mode Service (#93496)
* [Reporting] Screenshot Service RFC

* rewrite summary

* simplify design

* Update 0009_screenshot_mode_service.md

* mention the 3 screenshot report apps

* try not to say this is a high-level service

* clarify that print media css is just ok

* clarify the intent

* drop the `app`

* add the possibility to test screenshot mode through a URL parameter

* keep it more low-level

* keep the discussion high level

* move a sectioin of text
2021-04-14 14:21:28 -07:00
Jason Stoltzfus e9eff7181a
Fixed relevance tuning (#97172) 2021-04-14 16:50:42 -04:00
Scotty Bollinger af9129b584
[Workplace Search] Source row and Group Manager Modal bugfixes (#97166)
* Add spacing to group manager modal

* Add error state to source row

This mimics the design pattern from the overview page
2021-04-14 16:25:59 -04:00
Joe Reuter 9602896f9e
Discover: Limit document table rendering (#96765) 2021-04-14 21:06:28 +02:00
Tiago Costa 0bfa5aaf01
chore(NA): moving @kbn/tinymath into bazel (#97022)
* chore(NA): moving @kbn/tinymath into bazel

* chore(NA): fixed jest tests

* chore(NA): simplified tsconfig file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 14:49:19 -04:00
Scotty Bollinger 3bc2952216
[Workplace Search] Bypass UnsavedChangesPrompt for tab changes in Display Settings (#97062)
* Move redirect logic into logic file

* Add logic to prevent prompt from triggering when changing tabs

The idea here is to set a boolean flag that sends false for unsavedChanges when switching between tabs and then sets it back after a successful tab change

* Keep sidebar nav item active for both tabs

* Add tests
2021-04-14 13:28:00 -04:00
Dima Arnautov 096536647f
[ML] fix vertical overflow (#97127) 2021-04-14 13:11:44 -04:00
Ross Wolf e35ecaa378
[Security] Adds pre-packaged rule updates through the "Prebuilt Security Detection Rules" Fleet integration (#96698)
* Make the prepackaged rules functions async
* Fix type for getPrepackagedRules mock
* Install updates from saved objects & FS
* Mock getLatestPrepackagedRules instead of getPrepackagedRules
* Cleanup ruleAssetSavedObjectsClientFactory.all
* Fix comment for "most recent version"
* Switch to ruleMap.get() for less typescript errors
* Remove unneeded constants
* Fix SO.attributes sig and use custom validation
2021-04-14 12:57:50 -04:00
Marshall Main ff7c5330ad
[Security Solution] Converge detection engine on single schema representation (#96186)
* Replace validation function in signal executor

* Remove more RuleTypeParams usage

* Add security solution rules migration to alerting plugin

* Handle and test null value in threshold.field

* Remove runtime normalization of threshold field

* Remove signalParamsSchema

Co-authored-by: Davis Plumlee <davis.plumlee@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 12:53:46 -04:00
Alexey Antonov 4c33bfd979
Update VisualizationNoResults component (#97092)
* Update VisualizationNoResults component

* update JEST

* fix font size
2021-04-14 12:35:23 -04:00
Greg Thompson d679035664
Upgrade EUI to v32.0.4 (#96459)
* eui to 31.12.0

* type updates

* snapshot updates

* snapshot updates

* euiavatarprops

* eui to 32.0.3

* euicard updates

* update test
2021-04-14 11:27:36 -05:00
Alison Goryachev 813681eb08
[Upgrade Assistant] Redesign overview page (#95346) 2021-04-14 12:21:46 -04:00
Tim Sullivan 1615d5f62b
Reporting: Refactor functional tests with security roles checks (#96856)
* Reporting: Refactor functional tests with security roles checks

* consolidate initEcommerce calls

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 09:20:59 -07:00
Jason Stoltzfus ec6f652cc5
[App Search] Remaining Result Settings work (#96974) 2021-04-14 12:14:57 -04:00
Phillip Burch 4c00710be8
[Metrics UI] Add Log Rate to the metrics tab (#96596)
* Add Log Rate to the metrics tab

* Add custom metrics to Metrics tab

* Remove unused variables

* Review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 10:46:26 -05:00
Zacqary Adam Xeper 7a070e893d
[Fleet] Add preconfiguration to kibana config (#96588) 2021-04-14 10:43:08 -05:00
Scotty Bollinger fe00b68aa2
[Workplace Search] Update ID label to Source Identifier (#96970) 2021-04-14 11:39:56 -04:00
Marta Bondyra 7c2cbd39c4
[Lens] respect custom labels for fields in time series visualizations (#96937) 2021-04-14 17:18:45 +02:00
Robert Oskamp ad628878b1
[ML] security_network module - fix type of defaultIndexPattern (#97096)
This PR fixes the defaultIndexPattern type in the security_network module definition.
2021-04-14 16:43:37 +02:00
Thomas Watson e2eeb44613
Bump hosted-git-info from 2.5.0/3.0.7 to 2.8.9/3.0.8 (#96987) 2021-04-14 10:36:36 -04:00
Alison Goryachev b401cbb3eb
export DomainDeprecationDetails type from public + fix typo (#96885) 2021-04-14 09:51:47 -04:00
Tiago Costa e36650de70
chore(NA): moving @kbn/config-schema into bazel (#96273)
* chore(NA): moving @kbn/config-schema into bazel

* chore(NA): correctly format packages for the new bazel standards

* chore(NA): correctly maps srcs into source_files

* chore(NA): remove config-schema dep from legacy built packages package.jsons

* chore(NA): include kbn/config-schema in the list of bazel packages to be built

* chore(NA): change import to fix typechecking

* chore(NA): remove dependency on new package built by bazel

* chore(NA): be more explicit about incremental setting

* chore(NA): include pretty in the args for ts_project rule

* docs(NA): include package migration completion in the developer getting started

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 14:38:10 +01:00
Scotty Bollinger 366a537d37
[Workplace Search] Add breadcrumbs to Role mappings (#97051)
* Update Workplace Search nav to align with App Search

* Add constants to shared

* [App Search] Use shared constants

* [Workplace Search] Add breadcrumbs to Role mappings

* Enable shouldShowActiveForSubroutes
2021-04-14 08:25:18 -05:00
Scotty Bollinger 1630c14a15
[Workplace Search] Remove shadows from Source overview panels (#97055) 2021-04-14 10:14:12 -03:00
Alexey Antonov bcc1acb1dd
[TSVB][performance] remove visPayloadSchema.validate (#97091)
* [TSVB][performance] remove visPayloadSchema.validate

Part of: #97061

* Update vis.ts
2021-04-14 15:33:41 +03:00
Alexey Antonov 3b7ef07eca
[TSVB] Field validation should not be performed on string indexes. (#97052)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 15:32:44 +03:00
Ahmad Bamieh 69f570f06a
[Usage collection] Usage counters (#96696)
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
2021-04-14 08:21:11 -04:00
Vadim Dalecky e361e21622
UI actions readme (#96925)
* docs: ✏️ improve UI actions plugin readme

* docs: improve trigger description

* docs: remove unnecessary comma

* chore: 🤖 update autogenerated docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 14:12:27 +02:00
Stratoula Kalafateli 23e18b93eb
[TSVB] Enable brush for visualizations created with no index patterns (#96727)
* [TSVB] Enable brush for visualizations created with no index patterns

* Fix comments typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 13:48:00 +03:00
Alejandro Fernández Haro f4f49bc32e
[Data telemetry] Add Async Search to the tests (#96693)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 06:32:40 -04:00
Jean-Louis Leysens 8c8fcf16c4
added missing optional chain for bracket notation (#96939) 2021-04-14 11:46:12 +02:00
Matthias Wilhelm 3a7f23efac
[Discover][DocViewer] Fix toggle columns from doc viewer table tab (#95748) 2021-04-14 11:00:06 +02:00
Wylie Conlon b0772471ce
[TSVB] Fix per-request caching of index patterns (#97043) 2021-04-14 10:52:12 +03:00
Stratoula Kalafateli f0b1b903d5
[Datatable] Fix filter cell flakiness (#96934) 2021-04-14 08:34:50 +03:00
Stratoula Kalafateli 8db70bca19
Unskip heatmap suite and fixes flakiness (#96941) 2021-04-14 08:33:27 +03:00
Jen Huang 39e4ea8f44
[Fleet] Improve performance of data stream API (#97058)
* Improve performance of data stream API

* Remove extra logger, replace filter with reduce

* Remove unused import
2021-04-13 20:52:17 -07:00
Melissa Alvarez 2c73115b74
[ML] Data Frame Analytics: remove beta badge (#96977)
* remove beta badge from DFA jobs list

* remove unused translations
2021-04-13 21:46:05 -04:00
Byron Hulcher 71672c4c38
[App Search] Migrate expanded rows for meta engines table in Engines Overview (#96251)
* Pull out columns to be re-used for MetaEnginesTable

* Add route to get source engines for meta engines

* New MetaEnginesTableLogic

* New MetaEnginesTable component

* Remove isMeta prop from EnginesTable

* Swap EnginesTable with MetaEnginesTable in EnginesOverview for meta engines

* Missing test for MetaEnginesTableNameColumnContent

* Created new /app_search/components/engines/components/tables directory

* Moving columns to shared_columns.tsx file

* Updates to MetaEnginesTableExpandedRow and MetaEnginesTableNameColumnContent

* Fixes to EnginesTable, MetaEnginesTable, MetaEnginesTableLogic

* Remove flatten import

* Fix i18n

* PR Feedback

* DRY out shared engine link helpers

* DRY out shared ACTIONS_COLUMN

* Tests: DRY out shared columns/props tests

+ update to account for 2 previous DRY commits (e.g. deleteEngine mock)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen.3@gmail.com>
2021-04-13 21:15:37 -04:00
Nathan L Smith dfca5d440c
Instances latency distribution chart tooltips and axis fixes (#95577)
Fixes #88852
2021-04-13 16:02:55 -05:00
igoristic 355c949463
[Monitoring] Using primary average shard size (#96177)
* Using shard size avg instead of primary total

* Added ui text

* Changed to primary average instead of total

* Addressed cr feedback

* Added zero check

* Fixed threshold checking

* Changed description

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-13 17:01:39 -04:00
Scotty Bollinger 448562f758
[Workplace Search] Hide Kibana chrome on 3rd party connector redirects (#97028) 2021-04-13 16:57:38 -04:00
Andrew Goldstein a66bb5394d
## [Security Solution] Fixes Exit full screen and Copy to cliboard styling issues (#96676)
## [Security Solution] Fixes `Exit full screen` and `Copy to clipboard` styling issues

Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release.

- Fixes issue https://github.com/elastic/kibana/issues/96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table:

### Before: Exit Full Screen (`Pinned` tab)

![exit-full-screen-before](https://user-images.githubusercontent.com/4459398/114104665-89372980-9888-11eb-9158-ffa9c5a5ce17.png)

_Before: The `Exit full screen` button on Timeline's `Pinned` tab_

### After: Exit Full Screen (`Pinned` tab)

![exit-full-screen-after](https://user-images.githubusercontent.com/4459398/114106055-3743d300-988b-11eb-9c4d-c08679702d05.png)

_After: The `Exit full screen` button on Timeline's `Pinned` tab_

- Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions:

### Before: Copy to clipboard hover action

![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/114106138-5c384600-988b-11eb-942e-ae4e09848b09.png)

_Before: The `Copy to clipboard` hover action was not aligned_

### After: Copy to clipboard hover action

![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/114106236-8db11180-988b-11eb-85ae-476ac6d1df4e.png)

_After: The `Copy to clipboard` hover action is aligned_

### Desk Testing

Desk tested in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
2021-04-13 14:55:04 -06:00
Matthew Kime 1cd90d744f
Index pattern field editor - Add warning on name or type change (#95528)
* add warning on name or type change
2021-04-13 15:52:37 -05:00
Constance d774a41aef
[App Search] Add small engine breadcrumb utility helper (#96917)
* Add new getEngineBreadcrumbs utility helper

* Update all routes passing engineBreadcrumb as a prop to use new helper
2021-04-13 12:56:22 -07:00
John Schulz 58b1d10f0b
Copy esArchiver commands from ./reassign.ts to fix tests (#97012)
## Summary

Seeing failures like this locally for `x-pack/test/fleet_api_integration/apis/agents/unenroll.ts` tests
<details><summary>screenshot of error</summary>
<img width="1121" alt="Screen Shot 2021-04-13 at 10 06 51 AM" src="https://user-images.githubusercontent.com/57655/114592495-fec04280-9c58-11eb-939c-b84aa7469c2a.png">
</details>
Copied the `esArchiver` patterns from `x-pack/test/fleet_api_integration/apis/agents/reassign.ts` in https://github.com/elastic/kibana/pull/96837 and the error is gone

### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-04-13 15:42:36 -04:00
Garrett Spong 7e20bf85e0
[Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (#97011)
## Summary

This PR updates the MITRE Tactics, Techniques, and Subtechniques used within Security Solution Detection Rules. See https://github.com/elastic/kibana/issues/89876 for details on automating this task. 🙂
2021-04-13 13:40:13 -06:00