Commit graph

28817 commits

Author SHA1 Message Date
Spencer
5fa99d47ee
use a custom wrapper around chance with longer defaults to avoid conflicts (#49653)
* use a custom wrapper around chance with longer defaults to avoid conflicts

* fix a reference to chance

* fix another reference to chance service
2019-10-31 07:09:32 -07:00
Nathan Reese
616911cb51
[Maps] fix removal of multi fields for tooltip field selection (#49816) 2019-10-31 07:46:12 -06:00
sainthkh
faa48d591d eslint no-restricted-path false positive: bug caused by dir names that start with "index". (#46544)
* index* to index.{ts,tsx}

* Added test.

* Added invalid test.

* Added js.
2019-10-31 12:40:53 +02:00
Daniil Suleiman
9e00c78f4c
[Vis: Default editor] Create number_input with numeric value required (#48117)
* Created number_input with numeric value required

* Remove extra license

* Make value be possibly null
2019-10-31 11:27:57 +03:00
Dima Arnautov
c885f3c9ff
[ML] Improve processing of groups in data recognizer wizard (#49310)
* [ML] add support for job overrides

* [ML] disable Save button for invalid form, add translation

* [ML] add a tooltip for edit button

* [ML] fix IE flex layout issue

* [ML] conditionally set jobOverrides to the request payload

* [ML] remove hideCloseButton

* [ML] fix applyJobConfigOverrides

* [ML] processArrayValues

* [ML] check deeper arrays

* [ML] PR remarks

* [ML] check for an empty value
2019-10-31 08:54:20 +01:00
Dmitry Lemeshko
d5831e832b FTR: fix "DevToolsActivePort file doesn't exist" error on star… (#48874) 2019-10-30 22:18:46 -07:00
Justin Kambic
616ec1ece4
[Uptime] Add zero monitors down heading (#48257)
* Add zero down heading.

* Create new heading component for snapshot.

* Add tests and cases for no monitors.
2019-10-30 21:22:08 -04:00
Spencer
c78973b3ae
[canvas] avoid progress reporting in other webpack execution (#49802) 2019-10-30 15:45:31 -07:00
Thomas Neirynck
f7d2c1520c
[Maps] Introduce Agg Source (#49782)
This removes duplication from geogrid, pewpew and term-sources by introducing a top-level agg-source class.
2019-10-30 17:41:49 -04:00
Brian Seeders
6468e794fc
Flaky test runner improvements/fixes (#49367)
* Allocate multiple flaky test runner agents as executions grow

* WIP support for deleting kibana install dir during CI

* Add setup script for testing scripts

* Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner

* Change flaky test runner worker processes from 8 to 12
2019-10-30 17:24:28 -04:00
Kerry Gallagher
7cbe1df1a4
[Logs UI] Improve data structures / access / formatting for the log rate results page (#49158)
* Refactor data structures and data formatting

* Handle the "unknown" partition scenario in a more robust way

* Remove temporary fix for the ML link URLs

* Change Results to LogRateResults
2019-10-30 20:33:08 +00:00
Justin Kambic
7964221cd6
[Uptime] Add pagination functional test (#47633)
* Remove depdency on legacy interface.

* Remove custom interface, use common breadcrumb type.

* Add HTML template for app react entry point.

* Update app props.

* Add constant for react app entry point.

* Remove dependency on legacy capabilities provider.

* Delete legacy kibana framework adapter.

* Add New Platform adapter, reference in startup code.

* Remove dependency on legacy capabilities function.

* Delete reference to obsolete interface.

* Fix busted types in new adapter.

* Add new plugin class, delete old bootstrap code.

* Update routing/functional tests.

* Provide default for potentially-undefined value.

* run x-pack-ciGroup6 40 times

* Reinsert firefox skip tag.

* Update functional tests to work with newly-merged fixtures.

* Add functional test for pagination.

* Update obsolete test snapshots.

* Return CI to normal.

* Return CI to normal.

* Fix broken test expect.

* Fix type-related issue in test and update snapshot.
2019-10-30 16:19:52 -04:00
liza-mae
56c32a24fd
Enable visual tests (#47861)
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
2019-10-30 14:19:40 -06:00
Justin Kambic
3fee427fa4
Add HOC for wrapping snapshot histogram component. (#49268) 2019-10-30 16:05:34 -04:00
Steph Milovic
c72faebccd
[SIEM] fix bug that fails to match index patterns with leading wildcard (#49735) 2019-10-30 13:59:03 -06:00
Garrett Spong
5fc42f5b21
[SIEM] Fixes maps filter on array property to use single property value instead of array value (#49706)
## Summary

Resolves https://github.com/elastic/kibana/issues/49534

Filtering on an array property within the map tooltip now uses the single property value instead of the array value. Ended up not showing more than 1 item as part of the `DefaultFieldRenderer` because of this open issue (https://github.com/elastic/ingest-dev/issues/474) which causes layout of subsequent items to be off.

<img width="715" alt="Screen Shot 2019-10-29 at 21 28 32" src="https://user-images.githubusercontent.com/2946766/67826918-c6906880-fa93-11e9-9c88-cbf85672ad99.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-10-30 13:38:13 -06:00
Felix Stürmer
019ee9220d
[Logs UI] Fix log rate analysis tab title and route (#49646)
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from `analysis` to `log-rate` and performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from `/logs/analysis` to `/logs/log-rate` to reduce confusion in the build candidates.

fixes #49198
2019-10-30 20:01:33 +01:00
Aleh Zasypkin
27c464e35d
Fix link to OpenID Connect Elasticsearch guide from the Kibana OpenID Connect docs. (#49731)
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
2019-10-30 19:40:29 +01:00
Lisa Cawley
2589441527
[DOCS] Fixes link to Kibana monitoring documentation (#49528) 2019-10-30 10:49:46 -07:00
Nathan L Smith
3d9665d21c
[APM] Error stack trace improvements (#49254)
* some error stuff

* add new modules

* more stuff

* revert change to database

* Fix type check and test

* Replace stacktrace with stack trace

* update i18n and snapshots

* Updates based on feedback

* Updates based on @formgeist's feedback

* Remove unused import
2019-10-30 12:41:50 -05:00
Devin W. Hurley
1631900aa6
Replace Scroll query with Search After query (#48844)
* replaces scroll with search_after query. This fixes one issue where too many scroll contexts were being created and blocking queries from running on elasticsearch. Search_after fixes that.. I think there are still issues around task manager dropping new tasks because it runs out of available workers. Bulk Index is still a very slow process. Using search_after doesn't seem to be any faster than scroll, but it does keep this from blowing up ES.

* updates sortId type to match SearchResult type of string[]

* utilizes track_total_hits to know when to end the search_after query.. with scroll the query just would return 0 hits but with search_after we are constantly getting new data with no specified point to end it. Also this updates the search query to include the filter as my original search was not including that. big bug.

* type guard for acquiring total value from search response

* removes property leftover from rebasing with master

* removes defunct getFilter function. the filter is now being passed in from the params in signals_alert_type

* removes unused imports

* parameterizes default index for bulk index request

* adds typeof to do type guarding in lieu of extra function

* removes unused TotalValue import, removes optional requirement from size type property and unions undefined, adds size as parameter to rest signal routes

* no idea what happened here

* adds franks test from review - will update with more tests

* adds BulkResponse type, updates logic for when first search result for reindexing is empty

* fixes type error after introducing new logic for when first search result is empty
2019-10-30 13:35:04 -04:00
Matt Bargar
1dcec9d210
Add nested field support to KQL (#47070)
This PR adds a new syntax to KQL for querying nested fields.

Nested fields can be queried in two different ways:

Parts of the query may only match a single nested doc (bool inside nested). This is what most people want when querying on a nested field.
Parts of the query may match different nested docs (nested inside bool). This is how a regular object field works but nested fields can be queried in the same way. Although generally less useful, there are occasions where one might want to query a nested field in this way.
The new KQL syntax supports both.
2019-10-30 13:07:43 -04:00
James Gowdy
636fa27107
[ML] Fixing some of the eslint rule breakages in ML (#49716) 2019-10-30 16:38:08 +00:00
Angela Chuang
3c1e649e67
[SIEM] fix incorrect inspected query for kpi network (#49695)
* fix incorrect inspected query for kpi network

* update mock data
2019-10-30 12:24:10 -04:00
Liza Katz
0118bdec29
Pass overlays service to createFilterAction (#49736)
* Pass overlays service to createFilterAction

* Changed import path
2019-10-30 18:21:11 +02:00
Walter Rafelsberger
0e341b2088
Fix CODEOWNERS. (#49740)
Fixes the format of the CODEOWNERS file to ping both ML-UI and ES-UI team for the transform plugin. Having the same path twice for each team ignored the second rule. This update has the path only once with both teams on the same line.
2019-10-30 09:12:17 -07:00
Justin Kambic
03e3ee67ad
Right-align IP address column in pings list. (#49449) 2019-10-30 11:38:39 -04:00
Walter Rafelsberger
b368c6acba
[ML] Transforms: Removes temporary x-pack/legacy/plugins/transform eslint overrides.
Re-enables linting rules related to React hooks and adapts inline code.
2019-10-30 08:07:09 -07:00
patrykkopycinski
0efe6a2f16
[SIEM] Hide popover after choosing option from Timeline Settings popover (#49578) 2019-10-30 15:40:53 +01:00
Vadim Dalecky
a38223d890
Expressions np (#47810)
* refactor: 💡 generalize service getters and setters in expressio

* feat: 🎸 create NP-ready plugin for expressions

* refactor: 💡 flatten expressions plugin and remove service

* chore: 🤖 re-export legacy expressions service dir for Lens

* refactor: 💡 don't import renderer registry statically

* test: 💍 mock expressions service renderers registry in Mocha

* refactor: 💡 clean-up NP expressions pugin

* refactor: 💡 move Expression fonts to NP

* refactor: 💡 register Interpreter entities explicitly

* refactor: 💡 move clog Expression function to NP

* refactor: 💡 move font function and style types to NP

* refactor: 💡 remove ui/chrome from kibana_context function

* feat: 🎸 add ability to consume start core from setup life-cycle

* refactor: 💡 move kibana_context function to NP

* feat: 🎸 improve naming and delete import of missing function

* refactor: 💡 register expression clog and font fn in NP

* chore: 🤖 set AppArch as GitHub folder owners

* refactor: 💡 move Expression "kibana" function to NP

* refactor: 💡 move range function to visualizations plugin

* feat: 🎸 move visDimensions to visualizations plugin

* chore: 🤖 delete unused files

* refactor: 💡 move expression type registration to NP

* refactor: 💡 move createHandlers() function to NP

* feat: 🎸 move Expression executor to NP

* refactor: 💡 re-implement function registry

* refactor: 💡 convert expression type to class

* fix: 🐛 correct TypeScript errors

* feat: 🎸 convert Expressions type registry to class

* feat: 🎸 convert render function registry to class

* fix: 🐛 fix TypeScript errors

* fix: 🐛 fix translations after refactor

* refactor: 💡 move Expression types to NP

* test: 💍 remove unused test

* fix: 🐛 fix Lens import after merge with master

* fix: 🐛 fix TypeScript errors

* refactor: 💡 update expression types

* test: 💍 fix renderer test
2019-10-30 14:57:53 +01:00
Mikhail Shustov
e665574c30
add platform team as a licensing owner (#49617) 2019-10-30 09:45:20 -04:00
Dario Gieselaar
46304f0ce9
[APM] Use indexPatternsService for kuery bar suggestions (#49169)
* [APM] Use indexPatternsService for kuery bar suggestions

Closes #44487.

* Use simpler message format

* Remove missing labels

* Get index names from setup.indices
2019-10-30 12:52:52 +01:00
Vadim Dalecky
a10cf388c1
Fix eslint (#49595)
* fix: 🐛 fix unused persistedLog object

* chore: 🤖 ignore ESLint rule

* fix: 🐛 correct dependencies in useUnmount() hook

* fix: 🐛 fix ESLint errors

* chore: 🤖 disable ESLint rule

* fix: 🐛 add savedQueryService to dependency list

* fix: 🐛 fix ESLint errors in data plugin

* chore: 🤖 fix self-closing ESLint rule

* test: 💍 update Jest snapshot

* refactor: 💡 memoize persistedLog in more idiomatic way

* chore: 🤖 remomve unused import

* chore: 🤖 revert possible test breaker

* fix: 🐛 fix query bar merge errors
2019-10-30 12:44:38 +01:00
Joe Reuter
1fab577f8a
Kibana app migration: Local application service (#48898) 2019-10-30 12:15:34 +01:00
Larry Gregory
29c5b44403
[DOCS] - fixing references to kibana_user role (#49309)
* fixing references to kibana_user role

* Update docs/uptime-guide/security.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2019-10-30 07:08:01 -04:00
Jaime Soriano Pastor
ed9cdd7afe
Add CockroachDB Metricbeat module to Kibana Home (#49672) 2019-10-30 11:43:27 +01:00
Søren Louv-Jansen
e3b0fc0626
Allow server to start despite incompatible ES nodes in the cluster (#49490) 2019-10-30 10:55:26 +01:00
Alejandro Fernández
d955797f1f
[Metrics UI] Tweak the z-index inventory toolbars (#49642)
Having a z-index adds problems with the stacking of the dropdowns when
there are two toolbars together.
2019-10-30 09:26:53 +01:00
igoristic
e61ee759f5
Added resize listener after handler was created (#49452) 2019-10-30 00:18:36 -04:00
Nathan Reese
904eb32ae2
[Maps] do not re-fetch data on empty filter setting changes (#49382)
* [Maps] do not re-fetch data on empty filter setting changes

* handle case where prev query does not exist

* add parentheses around turnary statement
2019-10-29 20:55:38 -06:00
Aaron Caldwell
e02b092114
[Maps] Add back removed logic copying feature properties for injected data (#49400)
* Add back removed logic copying feature properties for injected data prior to modification

* Back out injected data and assign featureCollection to sourceDescriptor with __ prefix

* Review feedback. Ensure __featureCollection is always initialized minimally to a geojson object with an empty features array

* Check for null/undefined
2019-10-29 19:28:57 -06:00
Wylie Conlon
dad9d6b1b9
[Lens] Improve layer suggestions and fix layer crash in metric (#49389)
* Add loading indicator to Lens workspace panel

* [Expressions] [Lens] Handle loading and errors in ExpressionRenderer

* Using loading$ observable and improve tests

* [Lens] Fix layer crash and improve layer suggestions

* Using CSS and to handle layout of expression renderer

Added TODO for using chart loader when area is completely empty

* Improve error handling and simplify code

* Fix cleanup behavior

* Fix double render and prevent error cases in xy chart

* Fix context for use in dashboards

* Remove className from expression rendere component

* Improve handling of additional interpreter args

* More layout fixes

- Hide chart if Empty not Loading
- Fix relative positioning for progress bar since className is no longer passed (super hacky)

* Build suggestions that remove layers

* Update tests and add keptLayerIds everywhere

* Fix bug where datatable would accept multi-layer suggestions

* Build more suggestions that work with metric/datatable

* Fix issue with chart switching from empty

* Fix datatable multiple layer issue
2019-10-29 19:05:03 -04:00
Wylie Conlon
c35365109e
[Lens] Link to potential docs page (#49670) 2019-10-29 17:43:39 -04:00
Chris Cowan
871212e1de
[Metrics UI] Remove points from charts on Metrics Explorer and Detail Page (#49500)
* Removing points from Metrics Explorer and Metric Detail Page; Fixing bug with metric detail page labels;

* Remove points configuration
2019-10-29 14:12:55 -07:00
Chris Davies
92d2e4e68a
[Lens] Create special 'Records' field for count operation (#49376) 2019-10-29 16:36:45 -04:00
Chris Davies
5f1c621698
[Lens] Format the split series in XY charts (#49494) 2019-10-29 16:36:11 -04:00
Cauê Marcondes
7fd6499138
[APM] Add filter option to Metadata table (#48520)
* Flatten metadata section objects and adding filter input text

* Adding logic to filter keys and values

* Extrating Section component, adding not found message and creating HeightRetainer component to fix height and avoid the page to jump when filtering

* Adding filtered value to the url

* Refactoring dotted component extrating pathify to an external file

* Removing statefull filtered items

* Refactoring names

* Refactoring variable names

* fixing ui

* Removing space on transaction flyout and changint it to m on span flyout
2019-10-29 21:14:41 +01:00
Garrett Spong
895c0d865b
[SIEM] Update ML incompatible jobs callout text (#49668)
## Summary

Updates the placeholder text within the ML Anomaly Detection UI for when certain jobs are incompatible. To test, remove all `siem:defaultIndex` patterns -- this will not send any indices to the recognize API, and all jobs will be _incompatible_.

Resolves https://github.com/elastic/kibana/issues/49200

![image](https://user-images.githubusercontent.com/2946766/67798171-a4252d80-fa48-11e9-83a6-643302935ae5.png)


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-10-29 13:57:18 -06:00
Xavier Mouligneau
9cc09a09b8
put back the code that make everything works (#49643) 2019-10-29 15:21:40 -04:00
Wylie Conlon
e3ec773004
[Lens] Remove default title, tweak text for consistency (#49394)
* [Lens] Remove default title, tweak text for consistency

* Remove unused

* Text update
2019-10-29 13:51:53 -04:00