Commit graph

1676 commits

Author SHA1 Message Date
Tyler Smalley 9acf8d2656
Adds @kbn/utils package (#76518)
Moves common utility functions to obtain the repository root,
paths (config/data), and Kibana package.json to a @kbn/utils package.
Moving these existing functions allows them to be used in production, in
other packages because of Kibana.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-09-15 10:34:39 -07:00
Stratoula Kalafateli 98113eeb1b
[Functional] Fixes cloud failures on TSVB markdown (#77158)
* [TSVB] Remove the char by char typing on markodown

* revert

* Add the markdown to be computed immediately and give some time to compute it

* Add retry to locate TSVB tabs
2020-09-15 17:02:03 +03:00
Dmitry Lemeshko 1ab229aea8
[x-pack/test] convert PO to typescript, improve find/testSubject usage (#77389) 2020-09-15 15:43:56 +02:00
Pierre Gayvallet 043ef5e1d7
Create the @kbn/std package (#77329)
* move `src/core/utils` to the @kbn/std package

* update README

* update codeowners and add yarn lock file

* remove export from src/core/public and src/core/server and use package import instead

* update generated doc

* adapt forgotten import

* update `data` plugin doc
2020-09-15 15:21:05 +02:00
Michail Yasonik 61c4e6fd8d
Stacked headers and navigational search (#72331)
Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-09-14 14:32:30 -05:00
Larry Gregory 2e34eb239f
Hide management sections based on cluster/index privileges (#67791)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-14 09:30:47 -04:00
Joe Reuter 1dd4b65321
clean up test (#76887) 2020-09-10 10:15:45 +02:00
Stratoula Kalafateli 11be458be3
[Functional] Unskip vega tests and fix flakiness (#76600)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-07 13:40:13 +03:00
Spencer c778646318
[eslint] convert to @typescript-eslint/no-unused-expressions (#76471)
* [eslint] convert to @typescript-eslint/no-unused-expressions

* fix lint errors

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-04 10:07:13 -07:00
Stratoula Kalafateli 6e339d319d
[Functional] Unskip chained controls tests (#76610) 2020-09-04 14:43:27 +03:00
Stratoula Kalafateli 9ea61fc4b4
[Functional] Unskip TSVB metric tests (#76596) 2020-09-04 14:43:13 +03:00
Matthias Wilhelm 1eec83d7b9
[Discover] Fix time zone switch functional test in cloud env (#76396) 2020-09-04 13:22:35 +02:00
Luke Elmers 64b772613b
[data.indexPatterns] Fix broken rollup index pattern creation (#76593) 2020-09-03 08:13:33 -06:00
Pierre Gayvallet 210d6f2df1
Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (#76482)
* Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal

* eslint

* fix for loops
2020-09-03 08:50:03 +02:00
Tyler Smalley 298a7899bc skip flaky suite (#76245) 2020-09-01 15:40:51 -07:00
Alexey Antonov 7d82e273a6
Add auto interval to histogram AggConfig (#76001)
* Add `auto` interval to histogram AggConfig

Closes: #75438

* fix JEST

* update UI

* add tests

* some changes

* small changes

* cleanup code

* fix PR comment

* fix PR comments

* fix PR comment

* Update src/plugins/data/common/search/aggs/buckets/lib/histogram_calculate_interval.test.ts

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Change algorithm for auto interval

* Update src/plugins/data/common/search/aggs/buckets/histogram.ts

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* added some comments

* Update src/plugins/data/common/search/aggs/buckets/lib/histogram_calculate_interval.ts

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
2020-09-02 01:12:17 +03:00
Daniil Suleiman b8c7945b12
[TSVB] Fix panel config updates on history changes (#75896)
* Apply history changes to panel config

* Add functional tests

* Update jest snapshot

* Add waiters for stabilizing vis chart

* Fix comments

* Remove unused method isValidKueryQuery

* Add a waiter for component render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-01 13:29:35 +03:00
Stratoula Kalafateli 9ddd49a9f0
Hides advanced json for count metric (#74636)
* remove advanced json for count agg

* Remove only advanced json from count agg

* use Constant from data plugin

* add the logic to data plugin

* remove json arg from function definition

* remove unecessary translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-31 12:40:44 +03:00
Joe Portner 6627d7d9af
Sharing saved-objects phase 1.5 (#75444)
Added UI for sharing saved objects, and updated UI for importing and copying too
2020-08-26 16:52:29 -04:00
Catherine Liu 532f2d70e8
[Home] Elastic home page redesign (#70571)
Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
2020-08-26 13:00:00 -07:00
Rashmi Kulkarni eddd39a1c1
Adding sorting test to scripted fields in discover (#75520)
...sorting functional UI tests added.
2020-08-24 15:28:36 -07:00
spalger 6dbc2f7fd1 skip flaky suite (#75699) 2020-08-24 13:43:09 -07:00
Marius Dragomir 7eb02d11aa
Handle change in saml VM name (#73808)
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-24 15:28:25 +02:00
Pierre Gayvallet fd459dea5d
Migrate CSP usage collector to kibana_usage_collection plugin (#75536)
* move csp usage collector from legacy kibana plugin to kibana_usage_collection

* make scripts/telemetry_check happy.

* remove assertion on legacy kibana plugin

* remove test on legacy kibana plugin

* update README
2020-08-21 14:35:31 +02:00
Bhavya RM 6376bab559
adding additional tests for the awesome new nav by core ui team and checking off a flaky test' (#75494) 2020-08-20 12:40:18 -04:00
Joe Reuter 8e8f8d6e57
Fixing functional test user roles (#75547) 2020-08-20 17:16:41 +02:00
Alexey Antonov d158692bf5
Vega is now GA (#75157)
* Bringing Vega out of experimental

Closes: #21721

* fix CI group 12

* remove experimental flag from doc

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 12:19:21 +03:00
Stratoula Kalafateli 9a22ef29d4
[Functional]Table Vis increase sleep time in order filter to be applied (#75138)
* Increase sleep time in order filter to be applied

* revert

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-19 18:04:03 +03:00
Matthias Wilhelm 0efe286fad
[Discover] Fix histogram cloud tests (#75268) 2020-08-19 10:48:10 +02:00
Stratoula Kalafateli b6c475707c
Uiactions to navigate to visualize or maps (#74121)
* Navigate from discover to visualize with registering into a trigger

* Implement the VISUALIZE_FIELD action

* Implementation of the maps app trigger actions with the isCompatible functionality

* clean up discover code and tile map action implementation

* Add typeIsHidden on mocks

* Retrieve filters and query from url state

* functional test for oss and tile map

* include geoshape

* fix functional tests

* fix types

* remove unecessary dependencies

* minor fixes

* Remove tilemaps actios as it is going tobe deprecated

* Add useEffect on discover details and move the map action to a separate folder

* Retrieve map tooltips info from context

* Retrieve query and filters from QueryService

* Building urls with urlGenerators

* replace with constants, fetch initialLayers as array

* remove irrelevant comments

* nice improvements

* Return contextualFields for both triggers

* Add getHref on actions, move capabilities to isCompatible method per action and other fixes

* fix type

* Fix type incompatibility after merging with master

* fixes on maps plugin file after merge

* remove unecessary declarations

* nice improvements

* Refactor maps services code to be inline with master

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-19 11:37:45 +03:00
Andrea Del Rio 245c0a3708
[Discover] Create field_button and add popovers to sidebar (#73226)
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-08-18 13:51:47 -07:00
Stratoula Kalafateli 28e6dd3521
[Functional] Increases the time to locate the Create Visualization button (#75133) 2020-08-18 09:12:06 +03:00
Tiago Costa 46e313daef
skip flaky suite (#68472) 2020-08-17 13:07:55 +01:00
Tiago Costa 9cd55614a8
skip flaky suite (#75127) 2020-08-17 12:58:02 +01:00
Lee Drengenberg 5627ab3193
[functional test][saved objects] update tests for additional copy saved objects to space (#74907)
Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 12:20:38 -05:00
Greg Thompson bbee1f92b0
Upgrade EUI to v27.4.0 (#74004)
* eui to 27.1.0

* eui to 27.2.0

* buttoniconside type

* euiselectable type

* update onScroll callback and polyfill size references

* findTestSubject ts

* buttoncontent and collapsiblenav src snapshot updates

* update prop retrieval

* xpack snapshots

* jest updates

* type fixes

* more snapshots

* virtual list changes

* more virtualization changes

* merge

* fix functional tests

* data-test-subj for indexPatter-switcher

* storyshots

* eui to 27.3.1

* Fix unit tests

* Fix broken unit test

* Updated snapshots

* Fixed types

* search for value in euiselectable before selection

* select the correct element

* mock virtualized dep

* ts fix

* reinstate storyshot

* ts fix

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 10:31:15 -06:00
Spencer 4c810be335
Remove legacy optimizer (#73154)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 09:08:44 -07:00
Caroline Horn 5b64a4cdfe
Empty index patterns page re-design (#68819)
Empty index patterns page re-design
2020-08-12 15:58:16 -05:00
Nathan Reese ed69f9b85a
[maps] implement save and return from dashboard (#74303)
* pass originatingApp into App

* save and return top nav option

* clean up

* navigate to originating app

* functional test

* tslint

* cutOriginatingAppConnection

* add functional test for cutting originating app flow

* one more fix for cutting originator app and another functional test to verify

* typo

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-12 07:09:49 -06:00
Alexey Antonov 21b9b36c94
[Vega] add functional tests for Vega visualization (#74097)
* [Vega] [Inspector] add functional tests for Request tab

* add some tests for Vega Debug tab

* add clipboard permissions for webdriver

* add smoke tests for data grid

* fix CI

* add some tests for vega expression funcitons

* change order

* Update _vega_chart.ts

* Rename dagta_grid.ts to data_grid.ts

* Update index.ts

* Update data_grid.ts

* stabilize tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-12 14:05:23 +03:00
Stratoula Kalafateli 78689b7ecd
[Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (#74736)
* Adds a wait time between setting the index pattern and the time field on tsvb

* Char by char to set indexpattern to give more time to load the time field

* Add more time

* uncomment commented lines
2020-08-11 20:17:08 +03:00
Constance 697cd6412e
[Enterprise Search] Update the browser/document title on plugin navigation (#74392)
* Rename kibana_breadcrumbs to kibana_chrome

- in anticipation of upcoming refactor where SetPageChrome now handles document title as well as Kibana breadcrumbs
+ cleanup exports

* Add generate_title helpers

- will be used by new set_chrome helper

* Add setDocTitle context + behavior to set_chrome

+ refactor set_chrome.test.tsx:
  - add title tests
  - add SetWorkplaceSearchChrome test to increase coverage
  - clean up inner/outer call in favor of simpler mocks/imports
  - simplify isRoot tests

* Update plugins to set product titles
- on mount but before render

* Copy feedback - change pipe separator to hyphen

- to match ' - Elastic'

* Add functional tests confirming that document titles updated
2020-08-10 10:37:12 -07:00
Matthew Kime cccf15a3f4
Index pattern field class refactor (#73180)
- Better distinction and relationship between IndexPatternField and its spec
- IndexPatternField class is no longer defined via object mutation
- Reduction of dependencies
- UI code moved into Index Pattern class (will be removed in next ticket)
- IndexPattern field list was previously composed of IndexPatternFields or specs, now only IndexPatternFields
- IndexPattern field list was previously redefined when loading fields, now only its contents are replaced.
2020-08-10 07:35:12 -05:00
Devon Thomson dad5c72a0c
[Fix] Lose OriginatingApp Connection on Save After Create new (#74420)
Fixed typo created in #72725 which caused the originatingApp connection not to be lost properly after Create new
2020-08-06 13:24:54 -04:00
Anton Dosov 3064c6eceb
Improve state sync error handling (#74264)
Fixes #71461 regression since 7.7

New state syncing utils didn't properly handle errors,
Errors happening during URL parsing or writing wasn't handled, so state syncing could stop or in worth case blow out. (see #71461)

There are not much scenarios where missing proper error handling could really impact users, except the one described in #71461:

Kibana users state:storeInSessionStorage
Users often intuitively share hashed dashboard urls directly
When someone opens those urls - there is a blank screen with warning
In 7.6 - dashboard would still load with default state.
Since 7.7 these still could be achieved by removing query params for URL, but it is not obvious for regular users.

This PR makes sure that behaviour is similar to one we had before 7.7.


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-06 15:34:32 +02:00
Mikhail Shustov 88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
2020-08-05 17:32:19 +02:00
Marco Liberati c78da24708
[ Functional Tests ] TVSB charts flaky tests on index pattern switch fix (#74110)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 14:44:16 +02:00
Matthias Wilhelm 10f8beae8e
[Discover] Context unskip date nanos functional tests (#73781)
* Use _source value of timestamp for search_after since ES allows this now

* Unskip functional tests

* Remove unused convertIsoToNanosAsStr
2020-07-31 11:52:00 +02:00
Matthias Wilhelm 39cca0e55d
[Discover] Improve saveSearch functional test handling (#73626)
* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness
2020-07-31 06:52:36 +02:00
Daniil Suleiman 6fc193ceb9
Fix visualize a field through discover app (#73652)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-30 16:36:13 +03:00
spalger c102c4fe18 skip failing suite (#58815) 2020-07-29 14:41:22 -07:00
Matthias Wilhelm 4f8e7baa3e
Set timeRange to default to trigger the error message (#73629) 2020-07-29 16:57:34 +02:00
Liza Katz 14144156f6
[Data] Query Input String manager (#72093)
* improve test stability

* query string input manager (needed for search demo)

* docs

* dashboard

* Fix jest

* mock fix

* Allow restoring a saved query

* sync url

* Luke's fix to test

* cleanup

* lens jest tests

* docs

* use queryStringManager.getDefaultQuery
Don't sync query to global state

* Update app.test.tsx

lens mock

* jest fix

* jest

* use new api in the example

* Rename state param to query to match url state

* Apply changes to discover

* Update src/plugins/data/public/query/query_string/index.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Improve query string state manager

* Cleanup dashboard code

* Handle refresh button

* Set initial dashboard state

* visualize state

* remove unused

* docs

* fix example

* fix jest

* fix filter app state in discover

* fix maps test

* jest

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-29 10:48:23 +03:00
Stratoula Kalafateli 0dbfde4f4d
[Functional Tests] Increase the timeout on getting the legend value on timeseries (#73279) 2020-07-28 17:34:40 +03:00
Marco Liberati 8c710aae3a
[ Functional test ] Increase the waiting time for the filter bar request (#73424) 2020-07-28 14:21:24 +02:00
Stratoula Kalafateli 5ea28702f6
[Functional Tests] Increase the timeout when locating the tableview] (#73243) 2020-07-28 11:15:58 +03:00
Stratoula Kalafateli a696f6c79b
[Functional Tests] Increase waitTime for timelion to fetch the results (#73255)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 10:29:47 +03:00
Stratoula Kalafateli 7b29ecf0b5
[Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (#73238) 2020-07-28 10:29:33 +03:00
Tim Roes 9c2056d2ea
Remove flaky note from gauge tests (#73240) 2020-07-27 11:58:11 +02:00
Joe Reuter 6a53b0021e
Convert functional vega tests to ts and unskip tests (#72238)
* convert to ts and unskip tests

* relax tests and remove unused imports

* remove test exclusion

* remove inspector test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 10:45:23 +02:00
Matthew Kime 5a1972b834
Index patterns on alias - reenable functional tests (#71802)
* reenable test
* nav to management
2020-07-23 17:46:26 -05:00
Marta Bondyra f4bc846a03
unskip test to make sure if it passes (#73014)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 20:38:45 +02:00
Devon Thomson 0103cd3424
[Fix] Lose OriginatingApp Connection on Save As (#72725)
Reset originatingApp in lens and visualize when return to dashboard on saving is false
2020-07-23 12:21:31 -04:00
Daniil Suleiman 2d9eaf013b
Fix view saved search through a visualization (#73040) 2020-07-23 18:00:52 +03:00
Matthew Kime 2cf37a5326
Don't skip index pattern creation test (#73032) 2020-07-23 09:34:56 -05:00
Stratoula Kalafateli 1ee3cdb03d
[Functional Tests] Unskip tsvb timeseries test (#73011)
* [Functional Tests] Unskip tsvb timeseries test

* Add retry to dropdown selection when element is not found to headless mode
2020-07-23 17:00:16 +03:00
Pierre Gayvallet 2178a14519
Migrate status page app to core (#72017)
* move http.anonymousPaths.register('/status'); logic into core, remove status_page plugin

* move status_page to core & migrate lib

* migrate the status_app components to TS/KP APIs

* update rendering snapshots

* use import type syntax

* moves `/status` server-side route to core

* fix route registration

* update generated file

* change statusPage i18n prefix

* (temporary) try to restore legacy plugin to check behavior

* add some FTR tests

* do not import whole lodash

* update snapshots

* review comments

* improve / clean component unit tests

* change url for legacy status app

* set status app as chromeless

* fix FTR test due to chromeless app

* fix typings

* add unit test for CoreApp /status registration
2020-07-23 12:15:03 +02:00
Marco Liberati 6befacfc19
Fix Firefox TSVB flaky test with switch index patterns (#72882) 2020-07-23 10:40:21 +02:00
Lee Drengenberg e9ec039e8e
un-revert login_page change for SAML (#72892) 2020-07-22 14:00:57 -05:00
Matthias Wilhelm 0a3170ffa0
Unskip dashboard filter bar code coverage test (#72799) 2020-07-22 17:09:38 +02:00
Joe Reuter 78ea171a80
Stabilize closing toast (#72097)
* stabilize closing toast

* unskip test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 11:28:23 +02:00
Joe Reuter b9aede40d6
stabilize failing test (#72086) 2020-07-22 11:26:37 +02:00
Joe Reuter edaea1e341
Stabilize filter bar test (#72032) 2020-07-22 11:26:04 +02:00
Joe Reuter 1810dd1fe7
Unskip vislib tests (#71452) 2020-07-22 11:25:41 +02:00
Alexey Antonov e1ffcccb96
Add inspector for VEGA (#70941)
* [WIP] Add inspector for VEGA

Closes: #31189

* view -> dataset

* cleanup

* add spec viewer

* cleanup code

* use rx to retrieve data from adapters

* Make custom inspector adapters registerable from the visType

* fix flex-box size

* cleanup

* remove visTypesWithoutInspector from visualize_embeddable

* fix PR comments

* add vega folder to sass-lint

* fix jest

* Update src/plugins/vis_type_vega/public/vega_inspector/components/data_viewer.tsx

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* use addSignalListener

* cleanup

* add onColumnResize handler

* EuiCodeEditor -> CodeEditor

* fix type_check

* fix issue with pagination

* fix extra vertical scroll

* add area-label for EuiButtonIcon

* add area-label for EuiComboBox

* Design Commit

- Fixing up layout trying to remove any `.eui` classes and uses flex instead of percentage
- Fixing text to use `Sentence case` not `Title Case`

* Wrapper around signal viewer table

* fix Jest snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-07-21 14:45:51 +03:00
Matthias Wilhelm 7f6cd5148a
[Discover] Improve histogram tests (#72235) 2020-07-21 07:09:25 +02:00
Spencer a1753ffffd
[ftr/webdriver] retry on all errors, use Rx so that timers are canceled (#72540)
* [ftr/webdriver] retry on all errors, use Rx so that timers are canceled

* throw if attemptToCreateCommand() aborts by resolving to undefined

Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-20 20:35:15 -07:00
spalger 5741a868bc Revert "skip flaky suite (#72146)"
This reverts commit 45a4393459.
2020-07-20 09:32:41 -07:00
Joe Reuter 96d965d4e3
Unskip dashboard embeddable rendering tests (#71824) 2020-07-20 17:55:27 +02:00
Tiago Costa 45a4393459
skip flaky suite (#72146) 2020-07-17 13:55:51 +01:00
Matthew Kime 9ba750e852
Move data stream index pattern creation test to xpack (#71511)
* Move data stream index pattern creation test to xpack
2020-07-15 20:18:34 -05:00
spalger 68d7f58b1b skip flaky suite (#71987) 2020-07-15 16:59:04 -07:00
spalger 7787d1e48c skip flaky suite (#71979) 2020-07-15 16:53:20 -07:00
Lee Drengenberg 0173ef3528
add short sleep before clicking Remove on sample data (#71104)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-15 09:35:37 -05:00
Tyler Smalley ced455e077 [test] Skips flaky Saved Objects Management test
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-07-14 23:49:27 -07:00
Tyler Smalley 3c8a66e2b3 Revert "re-fix navigate path for master add SAML login to login_page (#71337)"
This reverts commit 1f340969ee.
2020-07-14 21:01:19 -07:00
Wylie Conlon 58b4127b68
Unskip functional tests for feature controls (#71173)
* Unskip functional tests for feature controls

* Update Maps test

* Update test title

* Fix hidden case-sensitive issue in saved queries

* Fix test separation issues

* Improve saved query retry logic

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-14 20:13:44 -04:00
Lee Drengenberg 1f340969ee
re-fix navigate path for master add SAML login to login_page (#71337) 2020-07-14 17:28:03 -05:00
Luke Elmers 7b026bb984
[data.search.aggs] Remove use_field_mapping from top hits agg (#71168) 2020-07-14 08:19:14 -06:00
Tiago Costa fd510ca303
skip flaky suite (#71501) 2020-07-13 19:13:38 +01:00
Tiago Costa e082719870
skip flaky suite (#68400) 2020-07-13 17:12:25 +01:00
Stratoula Kalafateli 06847519f1
[Functional test] Increase the timeout to click new vis function (#71226)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-13 16:26:33 +03:00
Liza Katz 3fc8c7af25
Validate incoming url timerange (#70948)
* validate incoming url timerange

* adjust discover test

* fix tests

* stabilize tests

* oops

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-13 13:47:12 +03:00
Liza Katz 79df8e01ad
improve bugfix 7198 test stability (#71250)
* improve test stability

* reenabled test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-13 09:26:34 +03:00
Dmitry Lemeshko d570ab1eb2
[services/remote/webdriver] fix eslint error (#71346) 2020-07-09 15:50:27 -07:00
Dmitry Lemeshko 4de59f0759
[ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (#71279)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 23:09:48 +02:00
Dmitry Lemeshko 633968e053
Remove IE support in functional tests (#71285)
* [ftr] remove ie support

* remove ie integration tests config
2020-07-09 22:12:52 +02:00
Rudolf Meijering 59d3096e55
Test that savedObjectsTable exists AND isn't loading (#71207)
* Wait until savedObjectsTable exists AND isn't loading

* Use :not css selector

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 15:56:20 +02:00
Tim Roes cfbdf1f55e
Unskip data table non timebased test (#71049)
* Unskip data table non timebased test

* Fix test to use new label

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 15:08:51 +02:00
Tiago Costa 237b2f66ed
skip flaky suite (#71216) 2020-07-09 13:59:00 +01:00
Matthias Wilhelm 216ef477ce
[Discover] Improve Discover histogram time range tests (#71056)
* Improve Discover histogram tests

* Use includes function to find a string

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 14:42:06 +02:00
Matthias Wilhelm d499b91a9b
[Discover] Improve saved queries reload functional test (#70957) 2020-07-09 14:41:29 +02:00
Liza Katz 52b42a81fa
Allow creating filters from fields with null values in discover (#70936)
* Fix bug #7189

* typo

* Test adjustments

* wait for load complete

* Fine tune test

* Update src/plugins/data/public/query/filter_manager/lib/generate_filters.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* Fix filtering by an array of nulls
Allow filtering by a non existing field in the doc
simplify flatten hit logic

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 11:58:22 +03:00
Tre 43302bd0b6
[QA] stack integration tests (not run in ci) (#70904)
## Summary

Migrate tests from integration-test repo.

The integration-test repo's purpose is to smoke test the build artifacts of all the main products in the stack (the .deb, .rpm, .tar.gz, .zip files).  
Currently Vagrant and VirtualBox are used to create VMs of the OSs appropriate for installing those build artifacts.  These scripts are in the integration-test repo.
After the VMs are installed and running the stack, a small number of UI tests are run against Kibana to verify we have beats data, logstash data, etc.
Kibana-QA team also uses the various VMs for manual testing since manually setting up security across the full stack can be time consuming.

The new tests in this PR under x-pack/test/stack_functional_integration/ are NOT executed as part of Kibana CI process.  They run from other periodic Jenkins jobs.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: LeeDr <lee.drengenberg@elastic.co>
2020-07-08 11:54:03 -06:00
Dave Snider c815c96937
Multi-line kql bar (#70140)
* Multiline kql bar

* fix id

* use visibility rather than display to hide stuff, cross fingers for tests

* another vis trick for tests

* quasi fix tests, still some failures

* caroline feedback

* fun!

* fix for mouse

* fix test

* check api

* fix unit test on query_string_input

* Fix cypress test

* handle the resize of the height of the textarea when the window have been resize

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Liza K <liza.katz@elastic.co>
2020-07-08 13:01:00 -04:00
Matthew Kime ea7012ebb1
Index Patterns Management - use /_resolve endpoint for data streams support (#70271)
* Index Patterns Management - use `/_resolve` endpoint for data streams support
2020-07-08 09:58:32 -05:00
Stratoula Kalafateli 0ea7f9ff6e
[Functional test] Increase the timeout on opening a saved visualization (#70952)
* fixes the flakiness on hybrid visualization test

* increase timeout to 20 sec to find and click the hybrid visualization
2020-07-08 11:48:06 +03:00
Maja Grubic acd5da8b9d
[Functional test] Add retry for dashboard save (#70950) 2020-07-08 08:45:20 +01:00
Marco Liberati 0bae5d62c9
[Discover] Doc Table functional tests (#70776)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-07 16:01:06 +02:00
Stratoula Kalafateli f30417624b
fix flaky test on tsvb switch index patterns (#70811)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-07 16:14:13 +03:00
Tim Roes aa99a702fb
Forbid timezones not working in Elasticsearch (#70780)
* Permit timezones not working in Elasticsearch

* Fix functional tests

* Use timezone without summer time for test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-07 12:33:37 +02:00
Dmitry Lemeshko fd152689f8
[functional tests] test url field formatter on dashboard and discover (#70736)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-03 23:09:02 +02:00
Tiago Costa 6c62c686cf
chore(NA): upgrade to lodash@4 (#69868)
* chore(NA): upgrade oss to lodash4

chore(NA): migrate cli, cli_plugin, cli_keystore,  dev, test_utils and apm src script to lodash4

chore(NA): missing file for cli plugin

chore(NA): add src core

chore(NA): es archiver and fixtures

chore(NA): try to fix functional test failure

chore(NA): migrate src/legacy entirely to lodash4 except src/legacy/core_plugins

chore(NA): move legacy core plugins to lodash4

chore(NA): upgrade optimize to lodash4

chore(NA): upgrade to lodash4 on advanced_settings, charts, console and dashboard

chore(NA): migrate to lodash4 on dev_tools, discover, embeddable, es_ui)shared, expressions, home plugins

chore(NA): upgrade data plugin to lodash4

chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4

chore(NA): missing data upgrades to lodash4

Revert "chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4"

This reverts commit 137055c5fed2fc52bb26547e0bc1ad2e3d4fe309.

Revert "Revert "chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4""

This reverts commit f7e73688782998513d9fb6d7e8f0765e9beb28d1.

Revert "chore(NA): missing data upgrades to lodash4"

This reverts commit 92b85bf947a89bfc70cc4052738a6b2128ffb076.

Revert "chore(NA): upgrade data plugin to lodash4"

This reverts commit 88fdb075ee1e26c4ac979b6681d8a2b002df74c6.

chore(NA): upgrade idx_pattern_mgt, input_control_vis, inspector, kbn_legacy, kbn_react, kbn_usage_collections, kbn_utils, management and maps_legacy to lodash4

chore(NA): map src plugin data to lodash3

chore(NA): missing lodash.clonedeep dep

chore(NA): change packages kbn-config-schema deps

chore(NA): update renovate config

chore(NA): upgrade vis_type plugins to lodash4

chore(NA): move vis_type_vislib to lodash3

chore(NA): update visualizations and visualize to lodash4

chore(NA): remove lodash 3 types from src and move test to lodash4

chore(NA): move home, usage_collection and management to lodash 3

Revert "chore(NA): move home, usage_collection and management to lodash 3"

This reverts commit f86e8585f02d21550746569af54215b076a79a3d.

chore(NA): move kibana_legacy, saved_objects saved_objects_management into lodash3

chore(NA): update x-pack test to mock lodash4

Revert "chore(NA): move kibana_legacy, saved_objects saved_objects_management into lodash3"

This reverts commit 2d10fe450533e1b36db21d99cfae3ce996a244e0.

* chore(NA): move x-pack and packages to lodash 4

* chore(NA): remove mention to lodash from main package.json

* chore(NA): remove helper alias for lodash4 and make it the default lodash

* chore(NA): fix last failing types in the repo

* chore(NA): fix public api

* chore(NA): fix types for agg_row.tsx

* chore(NA): fix increment of optimizer modules in the rollup plugin

* chore(NA): migrate `src/core/public/http/fetch.ts` (#5)

* omit undefined query props

* just remove merge usage

* fix types

* chore(NA): fixes for feedback from apm team

* chore(NA): recover old behaviour on apm LoadingIndeicatorContext.tsx

* chore(NA): fixes for feedback from watson

* Platform lodash4 tweaks (#6)

* chore(NA): fix types and behaviour on src/core/server/elasticsearch/errors.ts

* Canvas fixes for lodash upgrade

* [APM] Adds unit test for APM service maps transform (#7)

* Adds a snapshot unit test for getConnections and rearranges some code to make testing easier

* reverts `ArrayList` back to `String[]` in the painless script within `fetch_service_paths_from_trace_ids.ts`

* chore(NA): update yarn.lock

* chore(NA): remove any and use a real type for alerts task runner

Co-authored-by: Gidi Meir Morris <github@gidi.io>

* chore(NA): used named import for triggers_actions_ui file

* chore(NA): fix eslint

* chore(NA): fix types

* Delete most uptime lodash references.

* Simplify. Clean up types.

* [Uptime] Delete most uptime lodash references (#8)

* Delete most uptime lodash references.

* Simplify. Clean up types.

* chore(NA): add eslint rule to avoid using lodash3

* chore(NA): apply changes on feedback from es-ui team

* fix some types (#9)

* Clean up some expressions types.

* chore(NA): missing ts-expect-error statements

* Upgrade lodash 4 vislib (#11)

* replace lodash 3 with lodash 4 on vislib plugin

* Further changes

* further replacement of lodash3 to 4

* further work on upgrading to lodash 4

* final changes to update lodash

* chore(NA): upgrade data plugin to lodash4

chore(NA): upgrade data plugin public to lodash4

chore(NA): fix typecheck task

chore(NA): fix agg_config with hasIn

chore(NA): assign to assignIn and has to hasIn

chore(NA): upgrade data plugin server to lodash4

chore(NA): new signature for core api

fix(NA): match behaviour between lodash3 and lodash4 for set in search_source

* chore(NA): remove lodash3 completely from the repo

* chore(NA): fix x-pack/test/api_integration/apis/metrics_ui/snapshot.ts missing content

* chore(NA): fix lodash usage on apm

* chore(NA): fix typecheck for maps

* Patch lodash template (#12)

* Applying changes from https://github.com/elastic/kibana/pull/64985

* Using isIterateeCall, because it seems less brittle

* Also patching `lodash/template` and `lodash/fp/template`

* Reorganizing some files...

* Revising comment

* Ends up `_` is a function also... I hate JavaScript

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com>
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: kobelb <brandon.kobel@elastic.co>
2020-07-03 01:30:13 +01:00
Daniil Suleiman a8347fad1c
[Visualize] Add missing advanced settings and custom label for pipeline aggs (#69688)
* Show advanced settings in pipeline aggs

* Add functional tests

* Make sub metric in sibling pipeline to have custom label

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-02 13:24:00 +03:00
John Dorlus b21e43d848
Fixed assertion in hybrid index pattern test to iterate through indices (#70130)
* Fixed assertion to check through all indices before making assertion.

* Restored yarn.lock file.

* Removed only from describe.

* Fixed linting issue.

* Fixed nits that were in the PR conversation.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-01 21:04:03 -04:00
Joe Reuter de79985f92
[Lens] Add "no data" popover (#69147) 2020-07-01 10:08:37 +02:00
Matthias Wilhelm ad5ccfd7df
[Discover] Remove column from sorting array when removed from table (#65990) 2020-06-30 21:28:21 +02:00
Maja Grubic 7c352c0702
[Dashboard] Add visualization by value to dashboard (#69898)
* Plugging in DashboardStart dependency

* Create embeddable by reference and navigate back to dashboard

* Trying to feature flag the new flow

* Feature flagging new visualize flow

* Removing unnecessary console statement

* Fixing typescript errors

* Adding a functional test for new functionality

* Adding a functional test for new functionality

* Fixing test name

* Changing test name

* Moving functional test to a separate folder

* Trying to fix the config file

* Adding an index file

* Remove falsly included file

* Adding aggs and params to vis input

* Serializing vis before passing it as an input

* Incorporating new state transfer logic

* Remove dashboardStart as a dependency

* Trying to get the test to run

* Remove unused import

* Readding spaces

* Fixing type errors

* Incorporating new changes
2020-06-30 12:38:12 +01:00
Lee Drengenberg 752fa6e01e
Async Discover search test (#64388)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-29 15:40:02 -05:00
Luke Elmers 851e7ff9b8
[data.search.aggs] Remove fieldFormats from AggConfig & AggConfigs (#69762) 2020-06-29 10:10:34 -06:00
Daniil Suleiman 19bda1fcee
Reactify visualize app (#67848)
* Reactify visualize app

* Fix typescript failures after merging master

* Make sure refresh button works

* Subscribe filter manager fetches

* Use redirect to landing page

* Update savedSearch type

* Add check for TSVB is loaded

* Fix comments

* Fix uiState persistence on vis load

* Remove extra div around TableListView

* Update DTS selectors

* Add error handling for embeddable

* Remove extra argument from useEditorUpdates effect

* Update comments, fix typos

* Remove extra div wrapper

* Apply design suggestions

* Revert accidental config changes

* Apply navigating to dashboard

* Apply redirect legacy urls

* Apply incoming changes

* Apply incoming changes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-29 17:21:49 +03:00
Dmitry Lemeshko 6ebf56ba66
Adding saved_objects_page in OSS (#69900)
* add savedObjects own PO

* fix usage

* simplify functions

* fix test

* fix title parsing

* add missing await

* improve parsing

* wait for table is loaded

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-26 19:02:30 +02:00
Vadim Dalecky 684aa68f17
"Explore underlying data" in-chart action (#69494)
* refactor: 💡 rename folder to "explore_data"

* style: 💄 check for "share" plugin in more semantic way

"explore data" actions use Discover URL generator, which is registered
in "share" plugin, which is optional plugin, so we check for its
existance, because otherwise URL generator is not available.

* refactor: 💡 move KibanaURL to a separate file

* feat: 🎸 add "Explore underlying data" in-chart action

* fix: 🐛 fix imports after refactor

* feat: 🎸 add start.filtersFromContext to embeddable plugin

* feat: 🎸 add type checkers to data plugin

* feat: 🎸 better handle empty filters in Discover URL generator

* feat: 🎸 implement .getUrl() method of explore data in-chart act

* feat: 🎸 add embeddable.filtersAndTimeRangeFromContext()

* feat: 🎸 improve getUrl() method of explore data action

* test: 💍 update test mock

* fix possible stale hashHistory.location in discover

* style: 💄 ensureHashHistoryLocation -> syncHistoryLocations

* docs: ✏️ update autogenerated docs

* test: 💍 add in-chart "Explore underlying data" unit tests

* test: 💍 add in-chart "Explore underlying data" functional tests

* test: 💍 clean-up custom time range after panel action tests

* chore: 🤖 fix embeddable plugin mocks

* chore: 🤖 fix another mock

* test: 💍 add support for new action to pie chart service

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
2020-06-26 14:26:35 +02:00
Matthias Wilhelm c4b2e6f111
[Discover] Validate timerange before submitting query to ES (#69363) 2020-06-26 06:51:13 +02:00
Dmitry Lemeshko ec405931d2
[QA] Unskip functional tests (#69760)
* [functional tests] unskip dashboard state

* [functional tests] unskip empty dashboard, reference ES issue

* [functional tests] unskip data_table_nontime_index

* [functional tests] unskip viz builder tests

* link existing issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-25 16:03:18 +02:00
Mikhail Shustov 78ebb6250a
remove top-nav. it is not rendered in KP (#69488)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-24 13:24:53 +02:00
Joe Reuter d1a6fa26b8
Properly redirect legacy URLs (#68284) 2020-06-24 11:26:19 +02:00
Matthias Wilhelm cc893f3da4
[Discover] Unskip context navigation functional test (#68771) 2020-06-23 16:02:22 +02:00
Spencer 051c93a6be
[ftr] add support for docker servers (#68173)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-18 15:24:16 -07:00
Aaron Caldwell 55a73616ab
[Maps] Migrate maps client router to react (#65079)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-18 12:56:51 -06:00
Mikhail Shustov c8c20e4ca8
Add functional test for Kibana embedded in iframe (#68544)
* convert kbn test config into TS

* add test  for Kibana embedded in iframe

* run embedded tests in functional suite

* ignore tls errors in functional tests by default

* switch test to https

* remove env vars mutation

* allow to pass ssl config to Kibana

* pass ssl config to axios

* adopt KbnClient interfaces

* adopt KibanaServer

* use KbnRequester in security service

* set sameSiteCookies:None in test

* acceptInsecureCerts in chrome

* remove leftovers

* fix type error

* remove unnecessary field

* address comments

* refactor plugin

* refactor test

* make acceptInsecureCerts configurable

* run firefox tests on ci

* up TS version

* fix firefox.sh script

* fix path

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-18 12:02:56 +02:00
spalger 789851eb1a skip flaky suite (#52854) 2020-06-17 16:46:16 -07:00
Stratoula Kalafateli ab1270e566
Replaces the Custom Color Picker on TSVB with the EuiColorPicker (#68888)
* Replace the Custom Color Picker on TSVB with the EuiColorPicker

* Remove the custom picker sass

* Remove private modules of eui and the custom color swatches

* Clear the color

* changes in test implementation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-17 14:27:05 +03:00
Vadim Dalecky 3ee0bf2132
Explore underlying data (#68496)
* feat: 🎸 stub discover_enhanced plugin

* feat: 🎸 improve view in discover action

* feat: 🎸 add URL generator to "View in Discover" action

* feat: 🎸 implement navigation and getHref in view raw logs actio

* fix: 🐛 disable action in "edit" mode

* refactor: 💡 renamce context menu view in discover action

* feat: 🎸 rename action to "explore data"

* fix: 🐛 correctly generate action path

* feat: 🎸 add internationalization to "explore action"

* fix: 🐛 correctly parse generated Discover URL path

* test: 💍 setup basic functional tests

* refactor: 💡 modularize url generation logic

* feat: 🎸 export CommonlyUsed type

* test: 💍 add test subjects to panel custom time range modal

* test: 💍 add index patterna and time range functional tests

* refactor: 💡 rename action file

* refactor: 💡 use URL generator from Discover plugin's contract

* test: 💍 add "Explore raw data" action unit tests

* fix: 🐛 import share plugin to check if it is enabled

* Update x-pack/plugins/discover_enhanced/public/actions/view_in_discover/explore_data_context_menu_action.ts

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* chore: 🤖 add discover_enhanced to KibanaApp codeowners

* test: 💍 improve "Explore underlying data" functional tests

* test: 💍 improve <a> link assertion

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
2020-06-17 10:31:16 +02:00
Dmitry Lemeshko 9f7620b84d
[QA] Code coverage: fix flaky tests (#69272)
* skip test

* [page_objects/common_page] update closing toast
2020-06-16 20:15:01 +02:00
Mikhail Shustov 2a9fc23673
Type safe browser.executeAsync (#69018)
* make browserAsync type safe

* adopt tests

* prefer unknown over any

* simplify signature
2020-06-15 15:32:08 +02:00
Matthias Wilhelm 679118bcbc
[Discover] Unskip context navigation test (#68490) 2020-06-12 06:54:34 +02:00
Greg Thompson 0306c7a8cf
Upgrade EUI to v24.1.0 (#68141)
* eui to 24.1.0

* src snapshot updates

* x-pack snapshot updates

* euiPaletteColorBlind param updates

* euiPaletteColorBlind ts-ignore

* fix collapsibleNav close button click for functional testing

* await focus

* increase legacy sass build timeout value

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 15:07:40 -06:00
Peter Pisljar de4eaf9ae7
fix #66185 (#66186) 2020-06-08 15:31:14 +02:00
Alex Wild 38b9a8db8a
Add embed mode options in the Share UI (#58435) 2020-06-08 14:12:03 +02:00
Robert Oskamp fd1ad4c293
Make welcome screen disabling first action in loginIfPrompted (#68238)
This PR moves the welcome screen disabling in loginIfPrompted to the first position.
2020-06-05 17:39:03 +02:00
Dmitry Lemeshko 5064ae4a4c
[QA] Code coverage: unskip tests, collect tests results, exclude bundles from report (#64477)
* custom nyc configs, run all tests

* copy tests results back to original folder
2020-06-05 09:34:25 -06:00
Matthias Wilhelm a6e9caefe4
[Discover] Unskip context size tests (#68213) 2020-06-05 14:45:59 +02:00
Uladzislau Lasitsa b87eefc753
[uiSettings]: Migrate items owned by app arch to new platform (#66040)
* Migrated uiSettings items to new platform

* API changes

* Fixed translations

* Fixed comment and i18n

* Fixed tests

* Fixed internalization

* Fix karma tests

* made code more explicit

* Fixed plugin

* Added consts for ui settings ids.

* Added id for another settings

* Fixed tests.

* Improved imports

* Fix imports to public which were happening from the server.

* Fixed paths

* Moved styles to plugin.ts

* Moved styles

* Fixed docs

* Fix ci

* Fix ci

* fix documentation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
2020-06-05 10:55:42 +03:00
Liza Katz 537d2f2de1
[FIX] Allow filters without index (#68225)
* Allow filters without index

* Explicitly return true from isFilterApplicable id no index patterns were provided

* Adjust test result
2020-06-04 20:42:52 +03:00
Matthias Wilhelm fa8187ba2a
[Discover] Fix renaming of saved search not displayed in breadcrumb (#67577) 2020-06-04 11:45:08 +02:00
Alexey Antonov d661d66faa
[New Platform Migration]: Management - Implement NP API (#66781)
* [New Platform Migration]: Management - Implement NP API

Part of #47432

* partial progress on a number of management sections

* fix passing history

* Fixed types

* Fixed routing for Ingest Node Pipelines

* introduce and use react router wrapped eui components

* react router utils

* work in progress => hashRouter to router

* more partial progress

* remove console.log

* use reactRouterNavigate for management_sidebar

* Breadcrumbs will need to make use of the reactRouterNavigate function

* [triggersActions] app. Hash Router -> Router

* Replace /app/kibana#/management urls to /app/management

* remove ui/public/management

* fix some links to management apps

* fix management url for functional tests

* add data-test-subj for EuiSideNavItem

* partial progress

* fix some of ts issues

* Fixed breadcrumbs for data index management

* [kibana/spaces] section

* fix functional test

* [role_management] fix Breadcrumbs

* [api_keys] fix Breadcrumbs and Navigation

* Fixed routing for remote cluster

* [role_mapping] Partial progress

* [users] partial progress

* [watcher] partial progress

* fix eslint issues

* [snapshot_restore] partial progress

* [rollup_jobs] partial progress

* Fixed routing for cross cluster replications (partial progress). Enhanced reactRouterNavigate

* Perf optimization: fix extra re-rendering

* fix TS errors

* x-pack fix config for functional tests

* Fixed routing for index lifecycle management

* fix some broken CI tests

* fix PR comment

* [snapshot_restore] move onClick into reactRouterNavigate

* fix some jest

* fix some functional tests

* fix functiona test: management  scripted fields testing regression for issue

* fix some functional tests

* [licence_management] partial progress

* Fixed x-pack jest tests

* [saved_object_management] partial progress

* Fixed some tests

* fix functional test: should add new role myroleEast

* Reverted part of changes for ml

* [transforms] partial progress

* fix TS errors

* fix functional:  redirects to Kibana home

* add support of Backward compatibility

* fix functional: Saved objects management feature controls saved objects management global visualize all privileges listing redirects to Kibana home

* fix PR comment

* fix TS issues

* Fixed x-pack jest tests

* fix oss JEST

* Fixed functional test

* fix functional test

* fix PR comment

* Fixed i18n

* fix typo

* fix Styles

* Fixed paths for cross_cluster_replication

* fix wrong link

* Fixed jest

* Fixed some comments

* fix sorting

* fix type check

* fixed x-pack jest

* fixed x-pack jest

* reverted using of parentHistory

* Add debugging toasts to CCR.

* Comment out non-CCR functional tests.

* Fix typo.

* Uncomment non-CCR functional tests.

* Enable CCR.

* fix CI

* Add comment to explain why CCR is enabled by default and move config variable back to original location in CCR plugin.

* revert some changes in APM

* add space between index pattern name and tags

* fix function test

* Update x-pack/plugins/security/public/management/management_urls.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/api_keys/api_keys_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/roles/roles_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/users/users_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/management_urls.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/management_urls.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* [security] getUrlForApp -> navigateToApp

* [mp] fix Uncaught (in promise) undefined

Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
2020-06-03 18:55:06 +03:00
Liza Katz fbcb74ce28
Add error if filter index pattern is missing (#66979)
* add error if filter index pattern is gone

* docs change - why?

* Fix i18n

* Added a functional test for broken filters (field + index pattern)

* Clarify readme

* Moved readme

* New warning status

* Remove getAll

* git pull upstream master

* Fix translation files

* Fix merge

* added filterbar texts

* disabled correction

* Disable check in maps test until #64861 is resolved

* Fix tests, warning state is not disabled.

* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable

* Add an additional unrelaeted filter test

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Fixed test data

* Revert mapping

* Update data with missing test

* Update test to match data

* Code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-03 09:35:44 +03:00
Matthias Wilhelm 36c6cd9415
[Discover] Fix missing histogram time range update when query is refreshed (#67582) 2020-06-03 06:41:18 +02:00
Dmitry Lemeshko 5e2a78bb52
[test/functional/services] convert dashboard and pie-chart to ts (#66703)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-02 23:24:06 +02:00
Anton Dosov 13138c05c4
Fix "Could not locate that index-pattern" recreate link is not working (#67280)
added a functional test, because we've recently fixed this link and it regressed again
2020-05-27 14:56:45 +02:00
Robert Oskamp dbbd09058c
Add welcome screen disabling to common page (#66713)
This PR adds logic to disable the welcome screen to the common_page which is already used in the x-pack security_page.
2020-05-27 13:11:17 +02:00
Matthias Wilhelm 0aac0a3a28
Improve indexpattern without timefield functional test (#67031) 2020-05-25 14:15:26 +02:00
restrry bf04235dae apply prettier styles 2020-05-22 09:08:58 +02:00
Stratoula Kalafateli 42d21bcdcb
[Discover] Deangularize timechart header (#66532)
* Deangularize timechart header

* Add label attr to options

* Watch the interval prop change

* Tweaking the UI

Mainly moved interval notice to an `append` and copy updates

* Remove outdated i18n tokens

* fix functional test

* Change functional test due to dom changes

* fix functional test

* remove unecessary translation

* remove watcher as it is not necessary anymore

* change interval options copies

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-05-20 10:28:53 +03:00
Tim Roes 3350bffe49
Allow histogram fields in average and sum aggregations (#66891)
* Allow histogram fields in average and sum aggs

* Fix PR review
2020-05-19 18:47:22 +02:00
Joe Reuter 1b89dddde5
move role reset into the top level after clause (#66971) 2020-05-19 17:51:33 +02:00
Daniil Suleiman b70955b436
[Visualize] Bar chart: Show missing values on chart setting (#66375)
* Show missing switch button

* Add functional tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-19 17:47:29 +03:00
Matthias Wilhelm eda439a112
[Discover] Reload route when Reset Search is clicked (#66288)
* Reload route when resetQuery function is triggered

* Add functional test
2020-05-19 15:45:28 +02:00
Matthias Wilhelm 0d71ed2ba2
[Discover] Unskip doc link functional test (#66884)
Co-authored-by: Spencer Alger <email@spalger.com>
2020-05-19 06:45:58 +02:00
Matthew Kime f7181a95dc
Index pattern management to Kibana platform (#65026)
* index pattern management to kibana platform
2020-05-18 22:25:20 -05:00
Dmitry Lemeshko 45cad35222
[services/testSubjects] reduce retry usage, add waitForEnabled (#66538)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-19 00:41:27 +02:00
Joe Reuter 404743a9ae
stabilize listing page object (#66564) 2020-05-18 13:29:26 +02:00
Daniil Suleiman 828108729a
Prevent further failures if timezone was not set (#66529)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-18 12:53:00 +03:00
Pierre Gayvallet 61936a1870
[SOM] Preserve saved object references when saving the object (#66584)
* create field for references and add comments

* add FTR test

* remove comments

* address comments

* use real reference in dataset and assert against it.
2020-05-16 09:08:45 +02:00
Dmitry Lemeshko f575913850
FTR: move basic services under common folder (#66563)
* [CODEOWNERS] set kibana-qa to own test/functional/services

* [functional/services] move low-level services to common folder

* update codeowners

* update imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-15 18:28:28 +02:00
Joe Reuter cdb59c7662
unskip newsfeed tests (#66562) 2020-05-15 16:05:29 +02:00
Aleh Zasypkin aff7f909a9
Add Login Selector functional tests. (#65705) 2020-05-15 12:33:45 +02:00
spalger bf796b295b skip flaky suite (#43150) 2020-05-14 11:22:53 -07:00
Spencer f318c5bfa0
[ftr/service/appsMenu] add missing await (#66498) 2020-05-13 17:52:37 -07:00
Lee Drengenberg 28196558c3
make sure remove sample data button is displayed and enabled before clicking (#66322) 2020-05-13 18:12:47 -05:00
Matthias Wilhelm e6254f1f7c
[Discover] Encode context link filter part (#63831)
* Encode filter part of the URI for context

* Add functional test agent filter with whitespace
2020-05-13 11:48:56 +02:00
Joe Reuter b7e87c2c8b
Switch to core application service (#63443) 2020-05-13 09:19:24 +02:00
spalger 78aa89b818 skip flaky suite (#62866) 2020-05-12 12:22:14 -07:00
Dmitry Lemeshko 69a61d4ee7
[functional/services] import By/until from module (#66015)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-12 11:53:20 +03:00
Tim Sullivan f4d27b2838
[Reporting/Test] Add Functional test for download CSV (#65401)
* [Reporting/Test] Add Functional test for download CSV

* add todo

* add fs.existsSync check to find download

* debug

* handle timeout

* validate toast

* different way of getting repo_root
2020-05-11 12:49:19 -07:00
Matthew Kime 97561d6751
restore index pattern management data-test-subj's (#64697)
* restore index pattern management data-test-subj's
2020-05-08 11:53:42 -05:00
Anton Dosov 7cf7c261b9
fix fetchSoon delay in case of 0ms. Add async_dashboard test (#65083)
* forwardport #64999

* Add additional verifications on dashboard

I hope you don't mind me updating the test directly.
I *thought* the other dashboard tests required a consistent set of exact documents so that the count would always be the same.  Since the test uses sample data, I added a new timepicker:quickRanges so that the test can just select it.  Test FTR isn't set up to do relative time ranges right now.
But it looks like the dashboard checks aren't that specific to the data.  The dashboard seems to have `Last 24 hours` saved in it.  And when I don't change it to the whole sample data time range the test still passes.

* fix eslint error

* [page_objects/time_picker] allow any string in setCommonlyUsedTime

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
2020-05-08 12:03:42 +02:00
Lee Drengenberg e029e35a5b
remove navigate from createIndexPattern and pass insertTimstamp to browser.get() (#65507) 2020-05-07 12:14:26 -05:00
Spencer 4a440427a6
[functional tests] add some missing awaits (#65566) 2020-05-06 16:45:15 -07:00
Dmitry Lemeshko 38c26ff337
[services/remote] set download folder with auto-saving (#65476)
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
2020-05-06 22:41:47 +03:00
Dmitry Lemeshko ced64f43f7
add tsvb tests to Firefox suite (#65425) 2020-05-06 14:13:52 +03:00
Ryan Keairns a108b23c27
Additional branding updates (#64712)
* branding updates

* update snapshots

* update loginPage snapshot

* removed unused EuiText imports

* update button label for exiting full screen

* remove unused translations

* update loading_news snapshot

* update functional baseline screenshots
2020-05-06 01:39:29 -05:00
Matthias Wilhelm 9dc5c7debe
Remove redundant formatting of percentage column (#64948)
* Remove redundant formatting of percentage column

* Fix functional test

* Fix browser test
2020-05-06 08:31:03 +02:00
Michail Yasonik 35e10273d3
New nav (#64018)
Notably, also removes aria-hidden from many visualizations
2020-05-05 23:14:14 -05:00
Devon Thomson 5bad855e4b
Return to dashboard after editing embeddable (#62865)
Changed the process for saving visualizations and lens visualizations when the user has been redirected there from another application.
2020-05-05 16:58:36 -04:00
Dmitry Lemeshko ce06d37ce0
[test/functional] page objects cleanup (#64891)
* move point series functions to POs

* remove unused monitoring_page

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-05 19:08:25 +03:00
Dmitry Lemeshko 7cca2dacf0
[test/functional] Tsfy page objects (#64887)
* [test/functional/page_objects] tsfy console, context, header, timepicker & timelion

* [test/functional/page_objects] tsfy shield & error

* fix ts-check issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-05 16:24:04 +03:00
Tiago Costa 122450a4c8
chore(NA): skip functional test for visualize axis scalling preventing es snapshot promotion (#65100) 2020-05-04 18:04:42 +01:00
Josh Dover 306a5fe55e
Use brotli compression for some KP assets (#64367) 2020-05-04 10:53:06 -06:00
Vadim Dalecky 360b9c1200
Drilldowns (#61219)
* Add drilldown wizard components

* Dynamic actions (#58216)

* feat: 🎸 add DynamicAction and FactoryAction types

* feat: 🎸 add Mutable<T> type to @kbn/utility-types

* feat: 🎸 add ActionInternal and ActionContract

* chore: 🤖 remove unused file

* feat: 🎸 improve action interfaces

* docs: ✏️ add JSDocs

* feat: 🎸 simplify ui_actions interfaces

* fix: 🐛 fix TypeScript types

* feat: 🎸 add AbstractPresentable interface

* feat: 🎸 add AbstractConfigurable interface

* feat: 🎸 use AbstractPresentable in ActionInternal

* test: 💍 fix ui_actions Jest tests

* feat: 🎸 add state container to action

* perf: ️ convert MenuItem to React component on Action instance

* refactor: 💡 rename AbsractPresentable -> Presentable

* refactor: 💡 rename AbstractConfigurable -> Configurable

* feat: 🎸 add Storybook to ui_actions

* feat: 🎸 add <ErrorConfigureAction> component

* feat: 🎸 improve <ConfigureAction> component

* chore: 🤖 use .story file extension prefix for Storybook

* feat: 🎸 improve <ErrorConfigureAction> component

* feat: 🎸 show error if dynamic action has CollectConfig missing

* feat: 🎸 render sample action configuration component

* feat: 🎸 connect action config to <ConfigureAction>

* feat: 🎸 improve <ConfigureAction> stories

* test: 💍 add ActionInternal serialize/deserialize tests

* feat: 🎸 add ActionContract

* feat: 🎸 split action Context into Execution and Presentation

* fix: 🐛 fix TypeScript error

* refactor: 💡 extract state container hooks to module scope

* docs: ✏️ fix typos

* chore: 🤖 remove Mutable<t> type

* test: 💍 don't cast to any getActions() function

* style: 💄 avoid using unnecessary types

* chore: 🤖 address PR review comments

* chore: 🤖 rename ActionContext generic

* chore: 🤖 remove order from state container

* chore: 🤖 remove deprecation notice on getHref

* test: 💍 fix tests after order field change

* remove comments

Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Drilldown context menu (#59638)

* fix: 🐛 fix TypeScript error

* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger

* fix: 🐛 correctly order context menu items

* fix: 🐛 set correct order on drilldown flyout actions

* fix: 🐛 clean up context menu building functions

* feat: 🎸 add context menu separator action

* Add basic ActionFactoryService. Pass data from it into components instead of mocks

* Dashboard x pack (#59653)

* feat: 🎸 add dashboard_enhanced plugin to x-pack

* feat: 🎸 improve context menu separator

* feat: 🎸 move drilldown flyout actions to dashboard_enhanced

* fix: 🐛 fix exports from ui_actions plugin

* feat: 🎸 "implement" registerDrilldown() method

* fix ConfigurableBaseConfig type

* Implement connected flyout_manage_drilldowns component

* Simplify connected flyout manage drilldowns component. Remove intermediate component

* clean up data-testid workaround in new components

* Connect welcome message to storage

Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.

* require `context` in Presentable. drill context down through wizard components

* Drilldown factory (#59823)

* refactor: 💡 import storage interface from ui_actions plugin

* refactor: 💡 make actions not-dynamic

* feat: 🎸 fix TypeScript errors, reshuffle types and code

* fix: 🐛 fix more TypeScript errors

* fix: 🐛 fix TypeScript import error

* Drilldown registration (#59834)

* feat: 🎸 improve drilldown registration method

* fix: 🐛 set up translations for dashboard_enhanced plugin

* Drilldown events 3 (#59854)

* feat: 🎸 add serialize/unserialize to action

* feat: 🎸 pass in uiActions service into Embeddable

* feat: 🎸 merge ui_actions oss and basic plugins

* refactor: 💡 move action factory registry to OSS

* fix: 🐛 fix TypeScript errors

* Drilldown events 4 (#59876)

* feat: 🎸 mock sample drilldown execute methods

* feat: 🎸 add .dynamicActions manager to Embeddable

* feat: 🎸 add first version of dynamic action manager

* Drilldown events 5 (#59885)

* feat: 🎸 display drilldowns in context menu only on one embed

* feat: 🎸 clear dynamic actions from registry when embed unloads

* fix: 🐛 fix OSS TypeScript errors

* basic integration of components with dynamicActionManager

* fix: 🐛 don't overwrite explicitInput with combined input (#59938)

* display drilldown count in embeddable edit mode

* display drilldown count in embeddable edit mode

* improve wizard components. more tests.

* partial progress, dashboard drilldowns (#59977)

* partial progress, dashboard drilldowns

* partial progress, dashboard drilldowns

* feat: 🎸 improve dashboard drilldown setup

* feat: 🎸 wire in services into dashboard drilldown

* chore: 🤖 add Storybook to dashboard_enhanced

* feat: 🎸 create presentational <DashboardDrilldownConfig>

* test: 💍 add <DashboardDrilldownConfig> stories

* test: 💍 use presentation dashboar config component

* feat: 🎸 wire in services into React component

* docs: ✏️ add README to /components folder

* feat: 🎸 increase importance of Dashboard drilldown

* feat: 🎸 improve icon definition in drilldowns

* chore: 🤖 remove unnecessary comment

* chore: 🤖 add todos

Co-authored-by: streamich <streamich@gmail.com>

* Manage drilldowns toasts. Add basic error handling.

* support order in action factory selector

* fix column order in manage drilldowns list

* remove accidental debug info

* bunch of nit ui fixes

* Drilldowns reactive action manager (#60099)

* feat: 🎸 improve isConfigValid return type

* feat: 🎸 make DynamicActionManager reactive

* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager

* feat: 🎸 make panel top-right corner number badge reactive

* fix: 🐛 correctly await for .deleteEvents()

* Drilldowns various 2 (#60103)

* chore: 🤖 address review comments

* test: 💍 fix embeddable_panel.test.tsx tests

* chore: 🤖 clean up ActionInternal

* chore: 🤖 make isConfigValid a simple predicate

* chore: 🤖 fix TypeScript type errors

* test: 💍 stub DynamicActionManager tests (#60104)

* Drilldowns review 1 (#60139)

* refactor: 💡 improve generic types

* fix: 🐛 don't overwrite icon

* fix: 🐛 fix x-pack TypeScript errors

* fix: 🐛 fix TypeScript error

* fix: 🐛 correct merge

* Drilldowns various 4 (#60264)

* feat: 🎸 hide "Create drilldown" from context menu when needed

* style: 💄 remove AnyDrilldown type

* feat: 🎸 add drilldown factory context

* chore: 🤖 remove sample drilldown

* fix: 🐛 increase spacing between action factory picker

* workaround issue with closing flyout when navigating away

Adds overlay just like other flyouts which makes this defect harder to bump in

* fix react key issue in action_wizard

* don’t open 2 flyouts

* fix action order

https://github.com/elastic/kibana/issues/60138

* Drilldowns reload stored (#60336)

* style: 💄 don't use double equals __

* feat: 🎸 add reload$ to ActionStorage interface

* feat: 🎸 add reload$ to embeddable event storage

* feat: 🎸 add storage syncing to DynamicActionManager

* refactor: 💡 use state from DynamicActionManager in React

* fix: 🐛 add check for manager being stopped

* Drilldowns triggers (#60339)

* feat: 🎸 make use of supportedTriggers()

* feat: 🎸 pass in context to configuration component

* feat: 🎸 augment factory context

* fix: 🐛 stop infinite re-rendering

* Drilldowns multitrigger (#60357)

* feat: 🎸 add support for multiple triggers

* feat: 🎸 enable Drilldowns for TSVB

Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7

* "Create drilldown" flyout - design cleanup (#60309)

* create drilldown flyout cleanup

* remove border from selectedActionFactoryContainer

* adjust callout in DrilldownHello

* update form labels

* remove unused file

* fix type error

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>

* basic unit tests for flyout_create_drildown action

* Drilldowns finalize (#60371)

* fix: 🐛 align flyout content to left side

* fix: 🐛 move context menu item number 1px lower

* fix: 🐛 move flyout back nav chevron up

* fix: 🐛 fix type check after refactor

* basic unit tests for drilldown actions

* Drilldowns finalize 2 (#60510)

* test: 💍 fix test mock

* chore: 🤖 remove unused UiActionsService methods

* refactor: 💡 cleanup UiActionsService action registration

* fix: 🐛 add missing functionality after refactor

* test: 💍 add action factory tests

* test: 💍 add DynamicActionManager tests

* feat: 🎸 capture error if it happens during initial load

* fix: 🐛 register correctly CSV action

* feat: 🎸 don't show "OPTIONS" title on drilldown context menus

* feat: 🎸 add server-side for x-pack dashboard plugin

* feat: 🎸 disable Drilldowns for TSVB

* feat: 🎸 enable drilldowns on kibana.yml feature flag

* feat: 🎸 add feature flag comment to kibana.yml

* feat: 🎸 remove places from drilldown interface

* refactor: 💡 remove place in factory context

* chore: 🤖 remove doExecute

* remove not needed now error_configure_action component

* remove workaround for storybook

* feat: 🎸 improve DrilldownDefinition interface

* style: 💄 replace any by unknown

* chore: 🤖 remove any

* chore: 🤖 make isConfigValid return type a boolean

* refactor: 💡 move getDisplayName to factory, remove deprecated

* style: 💄 remove any

* feat: 🎸 improve ActionFactoryDefinition

* refactor: 💡 change visualize_embeddable params

* feat: 🎸 add dashboard dependency to dashboard_enhanced

* style: 💄 rename drilldown plugin life-cycle contracts

* refactor: 💡 do naming adjustments for dashboard drilldown

* fix: 🐛 fix Type error

* fix: 🐛 fix TypeScript type errors

* test: 💍 fix test after refactor

* refactor: 💡 rename context -> placeContext in React component

* chore: 🤖 remove setting from kibana.yml

* refactor: 💡 change return type of getAction as per review

* remove custom css per review

* refactor: 💡 rename drilldownCount to eventCount

* style: 💄 remove any

* refactor: 💡 change how uiActions are passed to vis embeddable

* style: 💄 remove unused import

* fix: 🐛 pass in uiActions to visualize_embeddable

* fix: 🐛 correctly register action

* fix: 🐛 fix type error

* chore: 🤖 remove unused translations

* Dynamic actions to xpack (#62647)

* feat: 🎸 set up sample action factory provider

* feat: 🎸 create dashboard_enhanced plugin

* feat: 🎸 add EnhancedEmbeddable interface

* refactor: 💡 move DynamicActionManager to x-pack

* feat: 🎸 connect dynamic action manager to embeddable life-cycle

* test: 💍 fix Jest tests after refactor

* fix: 🐛 fix type error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* refactor: 💡 move action factories to x-pack (#63190)

* refactor: 💡 move action factories to x-pack

* fix: 🐛 use correct plugin embeddable deps

* test: 💍 fix Jest test after refactor

* chore: 🤖 remove kibana.yml flag (#62441)

* Panel top right (#63466)

* feat: 🎸 add PANEL_NOTIFICATION_TRIGGER

* feat: 🎸 add PanelNotificationsAction action

* test: 💍 add PanelNotificationsAction unit tests

* refactor: 💡 revert addTriggerAction() change

* style: 💄 remove unused import

* fix: 🐛 fix typecheck errors after merge

* support getHref in drilldowns (#63727)

* chore: 🤖 remove ui_actions storybook config

* update docs

* fix ts

* fix: 🐛 fix broken merge

* [Drilldowns] Dashboard to dashboard drilldown (#63108)

* partial progress on async loading / searching of dashboard titles

* feat: 🎸 make combobox full width

* filtering combobox polish

* storybook fix

* implement navigating to dashboard, seems like a type problem

* try navToApp

* filter out current dashboard

* rough draft linking to a dashboard

* remove note

* typefix

* fix navigation from dashboard to dashboard

except for back button - that would be addressed separatly

* partial progress getting filters from action data

* fix issue with getIndexPatterns undefined

we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull

* fix filter / time passing into url

* typefix

* dashboard to dashboard drilldown functional test and back button fix

* documentation update

* chore clean-ups

fix type

* basic unit test for dashboard drilldown

* remove test todos

decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env

* remove config

* improve back button with filter comparison tweak

* dashboard filters/date option off by default

* revert change to config/kibana.yml

* remove unneeded comments

* use default time range as appropriate

* fix type, add filter icon, add text

* fix test

* change how time range is restored and improve back button for drilldowns

* resolve conflicts

* fix async compile issue

* remove redundant test

* wip

* wip

* fix

* temp skip tests

* fix

* handle missing dashboard edge case

* fix api

* refactor action filter creation utils

* updating

* updating docs

* improve

* fix storybook

* post merge fixes

* fix payload emitted in brush event

* properly export createRange action

* improve tests

* add test

* post merge fixes

* improve

* fix

* improve

* fix build

* wip getHref support

* implement getHref()

* give proper name to a story

* use sync start services

* update text

* fix types

* fix ts

* fix docs

* move clone below drilldowns (near replace)

* remove redundant comments

* refactor action filter creation utils

* updating

* updating docs

* fix payload emitted in brush event

* properly export createRange action

* some more updates

* fixing types

* ...

* inline EventData

* fix typescript in lens and update docs

* improve filters types

* docs

* merge

* @mdefazio review

* adjust actions order

* docs

* @stacey-gammon review

Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: streamich <streamich@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>

* fix docs

* nit fixes

* chore: 🤖 remove uiActions from Embeddable dependencies

* chore: 🤖 don't export ActionInternal from ui_actions

* test: 💍 remove uiActions deps in x-pack test mocks

* chore: 🤖 cleanup ui_actions types

* docs: ✏️ add JSDoc comment to addTriggerAction()

* docs: ✏️ regenerate docs

* Drilldown demo 2 (#64300)

* chore: 🤖 add example of Discover drilldown to sample plugin

* fix: 🐛 show drilldowns with higher "order" first

* feat: 🎸 add createStartServicesGetter() to /public  kibana_util

* feat: 🎸 load index patterns in Discover drilldown

* feat: 🎸 add toggle for index pattern selection

* feat: 🎸 add spacer to separate unrelated config fields

* fix: 🐛 correctly configre setup core

* feat: 🎸 navigate to correct index pattern

* chore: 🤖 fix type check errors

* fix: 🐛 make index pattern select full width

* fix: 🐛 add getHref support

* feat: 🎸 add example plugin ability to X-Pack

* refactor: 💡 move Discover drilldown example to X-Pack

* feat: 🎸 add dashboard-to-url drilldown example

* feat: 🎸 add new tab support for URL drilldown

* feat: 🎸 add "hello world" drilldown example

* docs: ✏️ add README

* feat: 🎸 add getHref support

* chore: 🤖 cleanup after moving examples to X-Pack

* docs: ✏️ add to README.md info on how to find drilldowns

* feat: 🎸 store events in .enhancements field

* docs: ✏️ add comment to range trigger title

* refactor: 💡 move Configurable interface into kibana_utils

* chore: 🤖 simplify internal component types

* refactor: 💡 move registerDrilldwon() to advanced_ui_actions

* test: 💍 update functional test data

* merge

* docs: ✏️ make drilldown enhancement comment more general

* fix: 🐛 return public type from registerAction() call

* docs: ✏️ add comment to value click trigger title field

* docs: ✏️ improve comment

* fix: 🐛 use second argument of CollectConfigProps interface

* fix: 🐛 add workaround for Firefox rendering issue

See:
https://github.com/elastic/kibana/pull/61219/#pullrequestreview-402903330

* chore: 🤖 delete unused file

* fix: 🐛 import type from new location

* style: 💄 make generic type variable name sconsistent

* fix: 🐛 show "Create drilldown" only on dashboard

* test: 💍 add extra unit test for root embeddable type

* docs: ✏️ update generated docs

* chore: 🤖 add example warnings to sample drilldowns

* docs: ✏️ add links to example warnings

* feat: 🎸 add URL drilldown validation and https:// prefixing

* fix: 🐛 disable drilldowns for lens

* refactor: 💡 remove PlaceContext from DrilldownDefinition

* fix: 🐛 fix type check error

* feat: 🎸 show warning message if embeddable not provided

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
2020-05-04 16:11:20 +02:00
Lee Drengenberg 0efd02b49d
change createIndexPattern to do what it takes to make the indexPatternName* (#64646) 2020-04-30 12:30:06 -05:00
Lee Drengenberg f5a8d8e6c2
make inserting timestamp with navigate methods optional with default true (#64655) 2020-04-29 14:05:45 -05:00
Dmitry Lemeshko c0bf910a70
Re-enable Firefox functional testing on CI (#64159)
* bring testing on Firefox back

* disable some tests

* skip more tests

* cut more suites for Firefox

* skip more tests for Firefox

* replace smoke tag with includeFirefox

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-24 23:59:14 +03:00
Uladzislau Lasitsa 66074f9042
Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (#64184)
* draft

* Converted edit_index_pattern to React. Created 'tab' component.

* Some fixes

* returned state_container

* Fixed tests and translation

* Some refactoring

* Fixed tests

* rermove unused translations

* update snapshots

* Some refactoring

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Matt Kime <matt@mattki.me>
2020-04-24 14:56:59 +03:00
Maja Grubic ffc8741da2
[Dashboard] Deangularize navbar, attempt nr. 2 (#61611)
* Attempt at deangularization, nr.2

* Remove padding in fullscreen

* Fixing failing functional test

* Fixing remaining functional test

* Fixing typescript errors

* Fixing filter bar not being visible in fullscreen

* Fixing filter bar not being visible in fullscreen

* Rebasing against master

* Fixing a small leftover

* Fix order of functions

* Fixing linting error

* Changing noPadding to a custom class

* Use filterManagers to handle filters

* Rename class

* Attempt at deangularization, nr.2

* Remove padding in fullscreen

* Fixing failing functional test

* Fixing remaining functional test

* Fixing typescript errors

* Fixing filter bar not being visible in fullscreen

* Fixing filter bar not being visible in fullscreen

* Rebasing against master

* Fixing a small leftover

* Fix order of functions

* Fixing linting error

* [APM] Agent config select box doesn't work on IE (#63236)

* adding value property to select options

* fixing test

* Use globe icon for "ext" span type on service map (#63205)

Both "external" and "ext" can be returned and should have the same icon.

* Move shared vislib components into Charts plugin (#62957)

* Closes #56310

Move shared vislib components into Charts plugin

* Fixed imports in tests

* Changed i18n IDs to match charts namespace

* Renamed ColorSchemaVislibParams to ColorSchemaParams, added enums and got rid of useValidation function

* Renamed ColorSchemaVislibParams to ColorSchemaParams and got rid of useValidation function

* Fixed merge conflict

* Replaced enums with objects again

* Make uptime alert flyout test a little more resilient (#62702)

* [SIEM] [Cases] Unit tests for case UI components (#63005)

* Endpoint: Remove unused `lib` module (#63248)

* [Lens] Fix error in query from generated suggestion (#63018)

* [Lens] Fix error in query from generated suggestion

* Update from review comments

* Fix test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Resolver/node svg 2 html (#62958)

* Remove some SVG in Resolver nodes and replace with HTML

* [Reporting] convert all server unit tests to TypeScript (#62873)

* [Reporting] convert all server unit tests to TypeScript

* fix ts

* revert unrelated change

* [SIEM] Link ML Rule card CTA to license_management (#63210)

* Link ML Rule card CTA to license_management

Taking the user directly to the license management page within kibana
(where they could immediately start a trial subscription) is much more
actionable than taking them to the subscriptions marketing page.

* Revert translation key change

Neither of these is totally accurate, and there've already been
translations written for the old one.

* Correctly type ILM's optional dependencies as optional (#63255)

And guard against their absence.

* [Telemetry] use prod keys (#63263)

* update chromedriver dependency to 81.0.0 (#63266)

* task/mac-eventing-form (#62999)

adds mac events form for endpoint policy details
Co-authored-by: oatkiller <robert.austin@elastic.co>

* bc6 rule import april 9 (#63152)

* bc6 rule import april 9

Increased the lookback of the ML rules

* re-import

with LF chars

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Added UI for pre-configured connectors. (#63074)

* Added UI for pre-configured connectors.

* fixed due to comments

* Fixed jest tests

* Fixed due to comments and added some functional tests

* test fix

* Fixed failed checks

* Fixed functional tests failing

* TaskManager tasks scheduled without attempting to run (#62078)

* TaskManager tasks scheduled without attempting to run

* Removing unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Changed alerting wrong param name for help xpack.encrypted_saved_objects.encryptionKey to xpack.encryptedSavedObjects.encryptionKey (#63307)

* fix ScopedHistory.createHref to prepend location with scoped history basePath (#62407)

* fix createHref to prepend with scoped history basePath + add option to exclude it.

* fix prependBasePath behavior

* fix test plugins urls

* add pathname to endpoint url builder methods

* Revert "add pathname to endpoint url builder methods"

This reverts commit 7604932b

* adapt createHref instead of prependBasePath

* use object options for createHref

* update generated doc

* fixing custom link popover size and hiding scroll (#63240)

* Changing noPadding to a custom class

* Use filterManagers to handle filters

* Rename class

* Applying some changes

* Reverting search_bar code changes

* Removing some stuff that was causing functional tests to fail

* Removing refresh dashboard container which was causing errors during navigation

* Do not destroy dashboardContainer

* Adding updateSavedQueryId method

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Co-authored-by: DianaDerevyankina <54894989+DianaDerevyankina@users.noreply.github.com>
Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Robert Austin <robert.austin@elastic.co>
Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com>
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
Co-authored-by: Dmitry Lemeshko <dzmitry.lemechko@elastic.co>
Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
Co-authored-by: The SpaceCake Project <randomuserid@users.noreply.github.com>
Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@elastic.co>
Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
2020-04-22 09:59:43 +01:00
Joe Reuter 2f794e6c42
Refresh index pattern list before redirecting (#63329) 2020-04-22 09:29:51 +02:00
Wylie Conlon 7e3de56303
[TSVB] Use default Kibana palette for split series (#62241)
* [TSVB] Rainbow palette shares colors with dashboard

* Add migration

* Add charts as NP dependency

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 12:43:21 -04:00
Anton Dosov 73548bd473
[Drilldowns] Fix back button by removing panels from url in dashboard in view mode (#62415)
* remove panels from url

* review nits

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-18 10:34:17 +02:00
Devon Thomson 3f98f0f849
Duplicate panel feature (#61367)
Added a new cloning feature for panels on a dashboard.
2020-04-17 11:35:27 -04:00
Dmitry Lemeshko 464a3c23ba
[FTR]: add chromium-based Edge browser support (#63566) 2020-04-16 19:06:33 +03:00
Daniil Suleiman 6bbcabcf1f
[NP] Visualize (#62294)
* Move visualize plugin to np

* Refactor plugin services

* Clean up

* Remove legacy style usage

* Fix style imports

* Fix timelion_options context provider

* Fix translations

* Change codeowners for visualize

* Import styles in legacy for BWC in Browser tests

* Get rid of embeddable dependency

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 18:32:46 +03:00
Anton Dosov c57297c95b
Bugfix clear saved query crashes kibana on Discover in some cases (#63554)
* actual hotfix

* clean up redundant code

* add functional test
2020-04-15 19:55:43 +02:00
Matthias Wilhelm 8264352bbe
[Discover] Fix broken setting of bucketInterval (#62939)
* Fix broken setting of bucketInterval, remove $watch

* Fix and adapt functional tests
2020-04-15 08:33:10 +02:00
Chris Cowan c2f2a79acb
[Metrics UI] Refactor With* containers to hooks (#59503)
* [Metrics UI] Refactor containers to hooks

* clean up depends; move useInterval out of useWaffleTime;

* converting WithWaffleFilters to useWaffleFilters

* Removing WithWaffleOptions

* Refactor WithWaffleViewState to useWaffleViewState

* Removing obsolete files

* Fixing race condition with complext state

* Adding undefined to RisonValue; unwinding changes trying to work around bad type

* Switching to context

* Change assertion to ignore the length of the current URL

* Fixing test frameork to accept urls longer then 230 characters

* Fixes #59395; Refactor WithMetricsTime to hook; Fixes brushing on metric detail page; fixes refresh button on metric detail page

* Fixing tests with adding timeRange

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-14 09:01:41 -07:00
Dmitry Lemeshko 637a9e11a2
Revert FTR: add chromium-based Edge browser support (#61684) (#63448) 2020-04-14 13:25:26 +02:00
Anton Dosov 1199c8c8b0
Bugfix dashboard unpins filters (#62301)
Fixes following cases:

Saving dashboard with pinned filter unpins it. Do not save pinned filters with dashboard see #62301 (comment)
When navigating with global filter to dashboard with same saved filter, filter becomes unpinned
When navigating from listing to dashboard with saved filter, back button didn't work

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-12 17:06:03 +02:00
Brian Seeders b8738b0eeb
Ensure that discover data exists for home/_navigation test so that the test suite can run in isolation (#62516) 2020-04-09 15:05:09 -04:00
Matthias Wilhelm 2a1c8d8de4
[Discover] Hide time picker when an indexpattern without timefield is selected (#62134)
* Assign valid value whether the timepicker should be displayed

* Add functional tests
2020-04-09 14:30:21 +02:00
Dmitry Lemeshko 578e443bdd
FTR: add chromium-based Edge browser support (#61684)
* bump dependency, add edge support in ftr services

* add config files

* fix browser version for msedge

* use npm ms-chromium-edge-driver

* download edge driver aside from session creation

* move dependency to dev

* update dist/index file

* bump edge-driver version

* change type to msedge to match w3c spec

* fix discover tests for Edge

* Revert "fix discover tests for Edge"

This reverts commit 87e7fdd256.

* bump driver version up

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-09 00:08:21 +03:00
Lee Drengenberg fdb4a37a60
restore empty_kibana after saved objects test (#62951) 2020-04-08 15:33:21 -05:00
Dmitry Lemeshko 898504dc8f
FTR: Enable w3c for chromedriver (#62542)
* enable w3c for chrome

* update maps tests

* update maps tests

* update common_page

* Revert "update maps tests"

This reverts commit 31f43fd678.

* revert changes to maps tests

* undo after removal

* update expect range to pass on Windows, unskip tests for Firefox

* print out value for discover brushing test

* log first timestamp

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 17:40:27 +03:00
Lee Drengenberg 0abd7aa43f
simplify new index pattern button click method (#62451)
* simplify new index pattern button click method

* replace method name to match previous commit

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:18:38 -05:00
Joe Reuter 2b32160a65
Vislib: Fix position calculation of ticks in non-horizontal axes (#62309) 2020-04-06 15:03:19 +02:00
Daniil Suleiman 104b49015e
[NP] Dashboard (#61895)
* Remove absoluteToParsedUrl reference in dashboard

* Remove KibanaParsedUrl from visualize

* Fix tests

* Add tests

* Fix saved dashboard

* Fix empty line after resolving conflicts

* Move dashboard to np

* Move migrations back to legacy

* Make it works

* Other fixes

* Move into application folder

* FIx translations

* Make share & home plugins otional

* FIx kbn url tracking, jest tests

* Import from dashboard_constants in FT

* Fix translations order

* Use getStartServices for start plugin deps

* Path fixes

* i18n fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:11:48 +03:00
Liza Katz ddc90247c2
[BUG] Back navigation from surrounding documents doesn't work properly (#62350)
* replace state for load more documents

* simpler solution

* simpler solution + functional test

* fix test

* disable flaky test
2020-04-06 10:41:05 +03:00
Daniil Suleiman 5696f6285c
[Discover] Fix flaky FT in field visualize (#62418)
* Unskip

* Set only suite

* Add field search

* Use alternative flaky fix

* Remove extra actions

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-04 17:05:00 +03:00
spalger b0523d5eb0 skip flaky suite (#62281) 2020-04-03 13:01:09 -07:00
Bhavya RM 29dd518859
a11y for xpack home (#62342)
a11y test xpack home
2020-04-03 14:29:32 -04:00
Anton Dosov ea7a81dfc2
[Drilldowns] Dashboard state fixes for drilldowns (#61457)
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g

2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter.

3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in #57795, but this on covers case when we stay within dashboard app, but change dashboard

4. Fix initial panel state migration causing redundant browser history records

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 12:22:43 +02:00
Joe Reuter 61f2626d0a
Make d3 place nicely with object values (#62004) 2020-04-02 18:12:22 +02:00
spalger aab5a0ce6d skip flaky suite (#53308) 2020-03-31 19:49:32 -07:00
spalger 5d8c65a10b skip flaky suite (#61714) 2020-03-31 16:30:15 -07:00
Matthias Wilhelm 0082ca7ad8
[Discover] Deangularize and euificate sidebar (#47559)
* Split angular templates into React components

* Add tooltip for field label

* Adapt SCSS

* Cleanup angular directives

* Extract helper functions

* Improve tests + docs

* Move css to _sidebar.scss

* Exclude _id field from displaying the Visualize button to prevent an ES error

* A11y improvements
2020-03-31 17:01:44 +02:00
DziyanaDzeraviankina f29a5dd05b
Auto interval on date histogram is getting displayed as timestamp per… (#59171)
* Auto interval on date histogram is getting displayed as timestamp per 0 milliseconds when x-axis bucket is collapsed

Closes #57822

* Fixed incorrect interval label displaying while scaling the chart.

* Updated agg.test.tsx snapshot

* Got rid of context and refactored agg hooks

* Fixed agg.type.name check

* Added functional tests to cover the date histogram interval editing

* Fixed some expected values in tests

* Updated some test cases

* Added a new visualization to visualize archive

* Added testSubjects service to replace find where possible

* Updated tests to match updated behavior

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-31 17:17:09 +03:00
Daniil Suleiman eedf64b091
[Discover] Fix filters passing down to visualize (#61392)
* Fix visualize a discover search

* Move deep clone into vis.ts

* Add functional tests

* Fix passing filters to visualize

* Add functional tests
2020-03-27 11:02:29 +03:00
Matthias Wilhelm 041dcc06af
[Discover] Fix ignoring uiSetting discover:searchOnPageLoad (#61393)
* Add checks for changed query and update in $scope.updateQuery

* Add functional test by counting fetches
2020-03-27 06:42:51 +01:00
Maryia Lapata 45a5ad55bc
[Default editor] Catch invalid calendar exception (#60494)
* Catch invalid calendar exception

* Use isValidEsInterval directly

* Show field error message right away

* Fix for the case 2w

* Update time_interval.tsx

* Restructure validation

* Rename fn to isValidCalendarInterval

* Refactoring

* Update time_interval.tsx

* Add functional tests

* Add functional tests for interval

* Update _area_chart.js

* Don't show error when value is empty

* Use error message from InvalidEsCalendarIntervalError

* Update _area_chart.js

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-26 18:24:03 +03:00
Dmitry Lemeshko 3fe48fe8b3
Fix empty coverage folder, collect coverage when some tests fail (#61349)
* create coverage folder only if json file being saved

* skip some tests

* unskip test

* do not fail coverage run if some tests fail

* unskip fixed test
2020-03-26 13:50:58 +03:00
Daniil Suleiman 1d278d4494
[Discover][Visualize] Fix visualizing a selected field in discover search (#61226)
* Fix visualize a discover search

* Move deep clone into vis.ts

* Add functional tests

* Fix passing filters to visualize

* Revert fixing filters
2020-03-26 10:52:57 +03:00
Tyler Smalley 30a512d831 Temporarily disable tests caused by possible ES regression
https://github.com/elastic/kibana/issues/61366

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-03-25 15:35:33 -07:00
Lee Drengenberg e19ab1ef4b
streamline indexPatternTitle usage (#60999)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-24 20:24:37 +00:00
Devon Thomson ec2972c224
Dashboard/add panel flow (#59918)
Added an emphasize prop to the top nav menu item and used it for a new 'Create new' button which redirects to the 'new visualization' modal.

Co-authored-by: Ryan Keairns <rkeairns@chef.io>
2020-03-23 17:03:01 -04:00
Lee Drengenberg afca33b520
add relationship test on Saved Objects (#59968)
* just a demo of function to return saved object table elements

* fix esArchive data, extend import objects test case for relationships

* improved data-test-subjs

* update snapshot for jest test

* unskip other half of the tests

* removed commented-out code

* use new findByTestSubject methods

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 14:18:35 -05:00
Wylie Conlon 85615bdb3f
Fix formatter on range aggregation (#58651)
* Fix formatter on range aggregation

* Fix test that was using unformatted byte ranges

* Fix test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 11:32:07 -04:00
Chandler Prall 0bf62cbf3e
Upgrade EUI to 21.0.1 (#60282)
* update to eui 21.0.1

* most changes needed for search bar ts changes

* Passing types

* snapshots

* jest tests

* Removed IQuery placeholder types

* Updated functional test to only look at table headers with content

* Moved 'filters' definition around in api docs

* Update types

* update snapshot

* typo

* Move DATA_FRAME_TASK_STATE enum to its own file to fix x-pack functional test config imports

* merge public api 'changes'

Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
2020-03-20 14:07:04 -06:00
Marco Vettorello 88612743a9
Update dependency @elastic/charts to v18.1.0 (#60578) 2020-03-20 17:37:11 +01:00
Dmitry Lemeshko 992c502cf5
WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (#60568)
* [web_element_wrapper] add find/findAll to search with data-test-subj

* fixes

* fix wrong function call

* review fixes

* simplify test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-20 17:18:35 +03:00
Pierre Gayvallet c638cc2a11
fix test description (#60638) 2020-03-20 07:17:00 +01:00
Pierre Gayvallet 395d621249
migrate saved objects management edition view to react/typescript/eui (#59490)
* migrate so management edition view to react

* fix bundle name + add forgotten data-test-subj

* add FTR tests for edition page

* EUIfy react components

* wrap form with EuiPanel + caps btns labels

* Wrapping whole view in page content panel and removing legacy classes

* improve delete confirmation modal

* update translations

* improve delete popin

* add unit test on view components

* remove kui classes & address comments

* extract createFieldList and add tests

* disable form submit during submition

Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-03-19 14:09:44 +01:00
Robert Oskamp 836b3d00ef
[ML] Add functional tests for file data visualizer (#60413)
This PR adds basic functional tests for the file data visualizer, covering a file import and error messages for non-log files. It also moves the file input path handling to a common location in order to avoid code duplication.
2020-03-19 09:08:43 +01:00
Dave Snider 52dd5e0f7a
Branding fixes for dashboard, loader and space selector (#60073) 2020-03-18 10:15:47 -07:00
Rashmi Kulkarni 89f9260da2
FTR configurable test users (#52431)
* initial implementation of configurable test users

* user superuser by default to match master

* referenced the configs in reporting and api integration

* setting the minimum number of default roles

* looking for x-pack tests with users and roles

* add testUserService in dashboard mode tests

* running only ciGroup7

* uncommenting - addign visualization

* re-enabling all CI groups to run on CI

* reinstating Jenkinsfile

* disable Test user for OIDC config

* improved logging and added Roles for OSS tests to get better info on the runs.

* disable test_user for auth tests

* don't fetch enabledPlugins when testuser disabled

* fix es-lint

* running oss tests with x-pack enabled

* [revertme] build default dist for oss tests

* updating NOTICE.txt file as it complained in the kibana intake tests

* changed to pick OSS builds

* trying a license change to trial

* switch back to xpack builds

* created a new sample data role and used it in homepage tests

* revert test/scripts/jenkins_ci_group.sh

* only refresh browser and wait for chrome if we are already on Kibana page

* fix large_string test to use minimum set of roles and privileges

* fix for date nanos custom timestamp with a configured role

* changes to the files with addition of new roles for the test_user

* reverting to OSS changes and few additions to the time_zone test to run as a test_user

* changes to security

* changes to the x-pack test to use elastic superuser

* fix for chart_types test

* fixes to area chart , input control test

* fix for dashboard filtering test and a new config role

* changes to handle the x-pack tests

* additional role for date nanos mixed

* added the logstash role to the accessibility tests

* removed telemetry setting

* docs+few changes to the tests

* removed Page navigation

* removed pageNavigation which was unused

* test/accessibility/apps/management.ts

* update management.ts

* aria label, and other changes

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* reverted

* unloading of logstash data, fixing aria label

* aria-label

* added the required role

* fix for tsvb chart

* fix for sample data test reverted home_page pageobject file

* changes to sample data test and visualize index file to incorporate OSS changes

* changes to describe() and some more changes to incorporate in settings_page

* re-adding the after()

* removed unwanted roles

* replaced kibana_user with kibana_admin

* added the check of deprecated kibana_user

* testing with kibana_admin  role

* fix for discover test

* incorporated the review comments

* incorporated the review comments

* incorporate review comments and added restoreDefaults()

* removed describe.only

* reverted the OSS logic change I had here- pulled into seperate PR

* incorporated the review comments

* incorporated review changes

* adding hidden=true to find hidden kibanaChrome

* change field.test.tsx to be same as that of master branch

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 10:41:23 -07:00
Rashmi Kulkarni 4b2231dc62
OSS logic added to test environment (#60134)
* OSS logic added

* reverting the logic of isOSS()

TileMap and RegionMap are on OSS but not on x-pack because it has Maps.
2020-03-13 14:39:14 -07:00
Stacey Gammon b9e9311d1f
rename dashboard_embeddable_container to dashboard (#59898)
* rename dashboard_embeddable_container to dashboard

* codeowners & typo

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-13 12:55:21 -04:00
Bhavya RM 526972e631
More a11y tests on index pattern page (#59575)
more a11y tests on index pattern page!
2020-03-13 12:21:05 -04:00
Dmitry Lemeshko dcabe3a256
unskip tests for code coverage (#59725)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-12 19:01:51 -05:00
spalger 25c33fcb15 skip flaky suite (#59717) 2020-03-12 09:50:20 -07:00
Brian Seeders 1b0d1f1c51
Add a retry to dashboard test for a sometimes slow async operation (#59600) 2020-03-10 12:45:49 -04:00
Matthias Wilhelm e630950a3d
[Discover] Migrate AppState/GlobalState to new app state helpers (#57175)
* Replace AppState

* Replace GlobalState

* Adapt functional test

* Sync initial app state to URL

* Add jest tests

* Refactoring to use use-default-behaviors="true" in kbn-top-nav

* Cleanup code remove unnecessary imports and variables

* Refactor to use syncQueryStateWithUrl & stopSyncingQueryAppStateWithStateContainer

* Remove discoverPersistedState

* Allow indexPattern switch without $route.reload()

* Remove timeRangeObj because it's not needed

* Create new getDefaultQuery in data plugin

* Simplify check for null in sync_state_with_url.ts

* Remove unused stateMonitorFactory

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
2020-03-09 18:45:14 +01:00