Commit graph

4598 commits

Author SHA1 Message Date
Jean-Louis Leysens a1004169c3
[Reporting] Baseline capture tests (#113910) (#115934)
* added page to reporting example app that contains the capture tests

* first version of PNG capture for test A

* added types file to common

* added data-shared-item attr to image, also added capture menu items

* fix image CSS by providing a fixed width and height

* explicitly add layout for print, does not seem to do anything though?

* added magic numbers of image sizes

* added reporting examples test folder

* first version of capture test for generating and comparing PNGs

* added PNG service and PNG baseline fixture

* added pdf-to-img dev dependency

* refactor compare_pngs to accept a buffer

* added comment to interface

* png service -> compare images service

* export image compare service

* added test for pdf export

* clean up log

* minor fixes and added pdf print optimized test

* added pdf and pdf print fixtures

* refactor lib function name

* Update difference thresholds

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-21 16:20:16 +01:00
Dzmitry Lemechko 408168ad7b
[ftr] update webdriver dependency to 4.0 (#115649) (#115767)
* [ftr] update webdriver dependency to 4.0

* [ftr] cast options on assign

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-20 12:01:13 -04:00
Kibana Machine f1ff1dda11
[QA][refactor] Use ui settings - saved queries (#114820) (#115723)
Co-authored-by: Tre <wayne.seymour@elastic.co>
2021-10-20 12:25:11 +00:00
Kibana Machine e2c8f7d39b
[ML] Functional tests - re-enable transform runtime mappings suite (#115547) (#115721)
This PR stabilizes and re-enables the transform runtime mappings tests.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2021-10-20 11:54:35 +00:00
Maja Grubic 5935f0313d
[Discover] Fix field filters test (#115062) (#115617)
* [Discover] Fix field filters test

* Change the fixture for the test

* Fix discover fixture

* Remove empty line

* Restore after

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-19 16:24:09 -04:00
Kibana Machine 359d28d3c6
[Unified Integrations] Remove and cleanup add data views (#115424) (#115581)
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Thomas Neirynck <thomas@elastic.co>

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
2021-10-19 17:25:11 +00:00
Tre 00c6f114fc
[QA][refactor] Use ui settings - sample data (#114530) (#115549)
# Conflicts:
#	test/functional/page_objects/common_page.ts
2021-10-19 10:42:52 -04:00
Kibana Machine c272b2d95f
Replace Inspector's EuiPopover with EuiComboBox (#113566) (#115412)
* Replacing EuiPopover with EuiComboBox

* The combobox will help alleviate issues when the list of options is very long

* Refactoring the Combobox to listen for change events

* Added an onChange handler
* Renamed the method to render the combobox
* Commented out additional blocks of code before final refactor

* Finished refactoring the Request Selector to use EUI Combobox

* Removed three helper methods for the EUIPopover.
  * `togglePopover()`
  * `closePopover()`
  * `renderRequestDropdownItem()`
* Removed the local state object and interface (no longer needed)
* Renamed the const `options` to `selectedOptions` in `handleSelectd()`
  method to better reflect where the options array was coming from.

* Updating tests and translations

* Fixed the inspector functional test to use comboBox service
* Removed two unused translations

* Updating Combobox options to pass data-test-sub string

* Updated two tests for Combobox single option
* Updated the test expectations to the default string
* Both tests were looking for a named string instead of a default
  message

* Adding error handling to Inspector combobox
* Checking for the item status code
* Adding a " (failed)" message if the status code returns `2`
* Updating test to look for "Chart_data" instead of "Chartdata"

* Updating two tests to validate single combobox options
* Added helper method to check default text against combobox options
* Added helper method to get the selected combobox option
* Checking two inspector instances using helpers

* Adding a defensive check to helper method.

* Correct a type error in test return

* Adding back translated failLabel

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>

Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2021-10-18 19:13:45 +00:00
Kibana Machine e7b60a53dd
[Fleet] Sample data and copy tweaks (#115078) (#115382)
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
2021-10-18 17:03:45 +00:00
Jonathan Budzenski 658dbf083c skip flaky suite. #107057 2021-10-17 09:48:17 -05:00
Sébastien Loix 66ebd9cacf
[Runtime field editor] Fix preview error when not enough privileges (#115070) (#115211) 2021-10-15 13:37:43 -04:00
Pierre Gayvallet 26b5ef8e35
[7.x] Add deprecation.skip_deprecated_settings config setting (#114751) (#115164)
* Add `deprecation.skip_deprecated_settings` config setting (#114751)

* Add `deprecation.skip_deprecated_settings` config setting

* fix deprecation from service

* fix existing config deprecations

* fix kbn-config unit tests

* adapt deprecation types

* fix more deprecations

* add filtering and adapt unit tests

* add service unit tests

* update generated doc

* fix telemetry unit tests

* address review comments

* add missing deprecation titles
# Conflicts:
#	src/core/server/elasticsearch/elasticsearch_config.ts
#	x-pack/plugins/maps/server/index.ts
#	x-pack/plugins/spaces/server/config.ts

* add configPath for core deprecations

* add configPath for csp deprecation

* add configPath for kibana.defaultAppId deprecation

* add configPath for plugins deprecations

* fix test deprecation
2021-10-15 09:54:52 -04:00
Maja Grubic 874325df3c
[Discover] Persist hide chart option to local storage (#114534) (#115064)
* Persist hide chart to local storage

* [Discover] Persist hide chart option to local storage

* Fix state

* Fix dependency check

* Set chart state to undefined

* Update unit test

* Do not override saved search preferences

* Fix missing import

* Add a functional test

* Add a functional test

* Fix functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-14 15:47:49 -04:00
Kibana Machine 317b019677
[Fleet] Add File upload (#114934) (#115061)
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
2021-10-14 15:46:40 -04:00
Maja Grubic 632a2a3cd2
[Discover] Rename default column in the advanced settings (#114100) (#115006)
* [Discover] Rename default column in the advanced settings

* Fix eslint

* Rename default column to an empty string

* Fix typo

* Fix default column filtering

* Update comment

* Make an empty array a default columns

* Improve functional test

* Wording change

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-14 12:17:49 -04:00
Spencer 587f66a604
[ci] filter out proc-runner logs from stdout on CI (#114568) (#114844)
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	test/functional/services/remote/remote.ts
2021-10-13 14:29:21 -04:00
Kibana Machine 4f68785b68
Replace EuiCodeEditor with CodeEditor in app-services code (#114316) (#114793)
* code editor scripted fields

* filter_editor

* embeddable example

* clean

* update tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
2021-10-13 11:25:07 -04:00
spalger 0bcc1087d5 skip flaky suite (#68400) 2021-10-13 14:05:33 +00:00
Kibana Machine 1eb212e7e4
Update dependency @elastic/charts to v37 (master) (#113968) (#114645)
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
2021-10-12 18:22:11 +00:00
Kibana Machine 03cef841d0
[bfetch] Pass compress flag in query instead of headers (#113929) (#114514)
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
2021-10-11 13:51:43 -04:00
Kibana Machine 7a2d0487d7
Functional tests - fix retry.waitFor not timing out correctly (#113905) (#114239)
This PR fixes bugs in test services, where retry.waitForWithTimeout and find.descendantExistsByCssSelector do not time out correctly.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2021-10-09 15:57:00 +00:00
Yaroslav Kuznietsov 0058764851
[MetricVis] Move the expression function and renderer to a separate plugin. (#113427) (#114384)
* Added expressionMetricVis plugin.

* splitted metric vis_type and expression.

* Fixed check errors.

* Fixed plugin docs.

* updated snapshots.

* Added code owner to expressionMetricVis.

* updated chart docs.

* Changed the `Metric` type export.

* Added storybook.

* Added bucket story.

* Added without label story.

* Added "with custom font size" story.

* Added other stories.

* Added DatatableColumn accessors.

* Replaced Metric with MetricOptions.

* Fixed MetricOptions.any

* updated the check of min/max existence.

* Updated function/renderer names.

metricRenderer -> metricVisRenderer
metricFunction -> metricVisFunction

* updated snapshot.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-optimizer/limits.yml
#	src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js
#	src/dev/code_coverage/ingest_coverage/__tests__/transforms.test.js
2021-10-08 04:28:29 -04:00
Kibana Machine b6c75ee752
[7.x] [Fleet] Add language clients (#113666) (#113977)
* [Fleet] Add language clients (#113666)

* Apply suggestions from code review

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update src/plugins/custom_integrations/server/plugin.test.ts

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update src/plugins/custom_integrations/server/plugin.test.ts

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: Thomas Neirynck <thomas@elastic.co>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-10-07 21:44:07 +00:00
Joe Portner b63428a70a
[7.x] Remove securityOss plugin (#113946) (#114322)
* Remove securityOss plugin (#113946)

# Conflicts:
#	.eslintrc.js
#	.github/CODEOWNERS
#	api_docs/security_oss.mdx
#	packages/kbn-optimizer/limits.yml
#	scripts/functional_tests.js
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json

* Add unintentionally removed translations

* Fix jest test
2021-10-07 16:45:09 -04:00
Tyler Smalley 26064a2c7a
[7.x] Update babel (master) (#113352) (#113680)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-06 17:39:48 -07:00
Kibana Machine c9246ef8e9
refactor a11y tests to group by data sets (#113876) (#114134)
* test if 2s sleep fixes flakey test

* switch from sleep to retry.waitFor

* remove .only, add comments to config file about sample data add/remove

* refactor a11y tests for sample data load

* refactor a11y tests for sample data load

* cleanup comments

* cleanup comments

* fix eslint errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
2021-10-06 14:39:17 -04:00
spalger 132b51d811 skip flaky suite (#105171)
(cherry picked from commit 3a9aa78458)
2021-10-06 18:17:16 +00:00
spalger 1ab6f9d6cf skip flaky suite (#113130)
(cherry picked from commit ce489a1131)
2021-10-06 18:06:19 +00:00
Dominique Clarke 2832030065
[Observability] [Exploratory View] Add exploratory view multi series (#113464) (#114120)
* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661ffd.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661ffd.

* [Observability] [Exploratory View] Create multi series feature branch (#108079)

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661ffd.

* Revert "[Observability][Exploratory View] revert exploratory view multi-series (#107647)"

This reverts commit 1649661ffd.

* update types

* update tests

* [Observability] exploratory view design issues (#111028)

* remove custom y axis labels for better clarity

* move add series button to the bottom

* disable auto apply

* fix missing test

* When series count changes, collapse other series. (#110894)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Feature/observability exploratory view multi series panels (#111555)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Exploratory View] Fix date range picker on secondary series (#111700)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Exploratory View] Collapse series only on add, not delete (#111790)

* [Exploratory view] Remove preview panel (#111884)

* [Exploratory view] implement popovers for data type and metric type (#112370)

* implement popovers for data type and metric type

* adjust types

* add IncompleteBadge

* make report metric dismissable

* show date-picker even if metric is undefined

* adjust styles of expanded series row

* add truncation to series name

* move incomplete badge and add edit pencil

* add tooltip to data type badge

* adjust content

* lint

* delete extra file

* move filters row

* adjust name editing behavior

* adjust filter styles

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* move cases button to top

* fix types

* more types :(

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
# Conflicts:
#	test/functional/page_objects/common_page.ts
2021-10-06 13:31:26 -04:00
Kibana Machine d9171bedaf
[7.x] add `coreOverall[7.x] to internal status contract (#113729) (#114089)
* add `coreOverall$` to internal status contract (#113729)

* add coreOverall$ to internal status contract

* add unit tests

* re-patch flaky tests

* add and improve tests

* fix tests for 7.x

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com>
2021-10-06 15:47:46 +00:00
Kibana Machine 2cfe7864e9
[Discover] Redirect to main page when route not found (#113678) (#114059)
* [Discover] redirect to main page on route not found discover error

* [Discover] remove services from dependencies

* [Discover] apply suggestions

* [Discover] return invalid link, but make it not clickable

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
2021-10-06 06:30:43 -04:00
Kibana Machine 2a97c5695d
[Unified Integrations] Create Services, Storybook, Replacements Card; add to Fleet (#113816) (#113997)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
2021-10-05 18:00:20 -04:00
Kibana Machine 0761e6576c
[Dashboard] Adding timelion panel without asking for the index pattern (#113896) (#113933)
* [Dashboard] Adding timelion panel without asking for the index pattern

* Adds a functional test

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2021-10-05 12:11:41 -04:00
Kibana Machine 6a841c5eb1
[Discover] Fix navigation to a new from saved search and saved query, fix discover:searchOnPageLoad (#112262) (#113916)
* [Discover] fix saved search become active

* [Discover] add another fix to be consistent with data fetching code

* [Discover] simplify solution

* [Discover] add functionals

* [Discover] fix saved query bug, add functionals

* [Discover] fix functionals

* [Discover] fix functional test

* [Discover] split saved query tests

* [Discover] preselect logstash index pattern

* [Discover] remove saved query after test complete

* [Discover] change query fill order

* [Discover] try to fix unrelated functional test

* [Discover] one more fix

* [Discover] try to fix one more problem

* [Discover] fix commonly used time range test

* [Discover] revert uisettings init in before statement, do small adjustments

* [Discover] fix unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
2021-10-05 09:36:09 -04:00
Kibana Machine 76c31dafe4
don't wait for nav:not(.ng-hide) on status page (#113674) (#113845)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
2021-10-04 18:37:07 -04:00
Matthew Kime 0d2fcbc1de
[7.x] [data views] Move data views api from data plugin and into its own (#113497) (#113833)
* [data views] Move data views api from data plugin and into its own (#113497)

* initial pass at moving data views into own plugin

* require expressions plugin, fix META_FIELDS reference

* bundle limits and localization

* fix integration test

* update plugin list and jest config

* type fixes

* search fixes

* fix localization

* fix mocks

* fix mocks

* fix stub

* type fixes

* fix import on test file

* path fixes

* remove shorted dotted from data plugin

* more todo removal

* eslint fixes

* eslint fix

* simplify data views server plugin

* simplify data views server plugin

* simplify data views server plugin

* fix imports on api routes

* fix imports on api routes

* update plugin list

* ts fixes

* ts fixes

* add deprecation notice

* fix circular dependency and api integration test

* fix circular dependency and api integration test

* rename types for better clarity

* path fixes

* jest.config and tsconfig cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* localization fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-04 17:55:53 -04:00
Dzmitry Lemechko 4d80db3ad9
[test/page_objects] validate selected dates for timepicker (#113597) (#113837)
* [test/page_objects] validate selected dates for timepicker

* unskip flaky test

* fix types check failure

* update tests

* update message

* unskip more tests
2021-10-04 17:27:48 -04:00
Kibana Machine 98d7a37c73
[7.x] [Uptime] Run Sample uptime tests using @elastic/synthetics (#112128) (#113531)
* [Uptime] Run Sample uptime tests using @elastic/synthetics (#112128)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* update test according to 7.x

* revert

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
2021-10-04 16:28:53 +00:00
Kibana Machine 4814df2e11
[Fleet] Show beats replacements in integration browser (#113291) (#113615)
Display both beats and epr-packages in the integration browser. When there is overlap, the EPR-package equivalent is displayed. When the EPR-package is not yet ga, the beat-equivalent is displayed.

Co-authored-by: Thomas Neirynck <thomas@elastic.co>
2021-10-01 10:35:57 -04:00
Kibana Machine d62cb560ed
test/functional/apps/management/_test_huge_fields.js (#112878) (#112909)
Co-authored-by: Rashmi Kulkarni <rashmi.kulkarni@elastic.co>
2021-09-30 19:52:26 -04:00
Kibana Machine 2f4662bcf1
[Fleet] Register Sample Data (#113200) (#113488)
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
2021-09-29 20:46:17 -04:00
Kibana Machine f2fa26ca4e
[Discover] Unksip and improve index pattern without time field functional test (#112698) (#113391)
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
2021-09-29 10:18:16 -04:00
Kibana Machine 49cabe5d85
Fixes error with percentiles on index with many docs (#113216) (#113384)
* Fixes error with metric viz and percentiles on index with many docs

* Unskip the metric viz suite

* Adds a unit test

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2021-09-29 09:11:48 -04:00
Kibana Machine 3e05cbf9be
Failing test: Chrome UI Functional Tests.test/functional/apps/visualize/_tsvb_table·ts - visualize app visualize ciGroup12 visual builder table should display correct values on changing metrics aggregation (#112216) (#113355)
* Add wait for finish header loading

* Add header waitUntilLoadingHasFinished to visChart waitForVisualizationRenderingStabilized

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>
2021-09-29 05:25:02 -04:00
Kibana Machine 22b1b7f745
fix skipped test test/accessibility/apps/dashboard·ts - Dashboard create dashboard button #111233 (#112872) (#113317)
* test if 2s sleep fixes flakey test

* switch from sleep to retry.waitFor

* remove .only, add comments to config file about sample data add/remove

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
2021-09-28 17:13:41 -04:00
Pierre Gayvallet 102822f4fd
[7.x] add SavedObjectType.management.displayName (#113091) (#113249)
* add `SavedObjectType.management.displayName` (#113091)

* add `SavedObjectType.management.displayName`

* fix unit tests

* add FTR test

* update generated doc

* also update labels

* fix unit tests
# Conflicts:
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx

* fix types

* fix allowedTypes usage

* fix unit tests
2021-09-28 16:03:09 -04:00
Matthias Wilhelm 5c0a46fa50
[Discover] Add "Chart options" menu (#112453) (#113233)
Co-authored-by: Tim Roes <mail@timroes.de>

Co-authored-by: Tim Roes <mail@timroes.de>
2021-09-28 07:17:52 -04:00
Kibana Machine 8e6b834540
Short URLs (#107859) (#113228)
Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
2021-09-28 07:04:15 -04:00
Tiago Costa bd669de514
skip flaky suite (#112920) 2021-09-28 11:58:19 +01:00
Maja Grubic 2299190672
[Saved Search Embeddable] Add view action (#112396) (#113225)
* [Saved Search Embeddable] Add view action

* Fix typescript and lint errors; add tests

* Add a functional test

* Fix a unit test

* Renaming action

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-28 06:02:16 -04:00