Commit graph

1188 commits

Author SHA1 Message Date
liza-mae 0003a32f56
[WIP] FTR Percy changes (#36897)
* [ftr/percy] integrate percy with functional test runner

* execute ftr within `percy exec`

* share PERCY_BIN and GRUNT_BIN vars in setup

* [license] whitelist `(Unlicense OR Apache-2.0)`

* [percy] include pr/parallel info in env

* echo the actual variable value

* destructure required modules

* [ci] calculate percy env in a script

* remove outdated eslint overrides

* oops, nonce should be the same for each build

* take snapshots in context tests

* add percy snapshots to some dashboard tests

* account for extra execution of PERCY_BIN

* remove usage of percy service

* rename service to `visualTesting`

* write a simple test

* switch left-over percy test to visualTesting

* set log level for percy agent

* trigger ci

* try using the system chrome install instead of downloading one

* fix export definition

* Don't skip chromium download

* Add Spencer's fix to point to chrome installation

* Attempting to split tests into own ci job and test files

* Renumber job

* Add tag to decorations file

* Try new files with existing CI job

* Try again to create a new CI job

* Fix eslint problem with space

* eslint updates

* fix console test

* make test names unique

* Update ci group names

* Try old name again

* save

* add separate visual_regression ci job

* add visual regression ci job

* add new job to jobs.yml

* update path to take_percy_snapshot script

* use fixed percy job total

* fix common services import

* move visual_create_and_add_embeddables to visual_regression project

* finish moving create_and_add_embeddables

* add x-pack visual regression job

* migrate dashboard_snapshots tests to visual_regression

* remove references to removed test files

* restore some unnecessary changes

* reimplement the login page tests

* yarn.lock update

* fix test

* remove old CI_GROUP 100 block

* update failed_tests trap

* reduce yarn.lock changes

* disable debug logging

* disable visual-regression tests for now, we can enable them in specific prs
2019-06-14 10:35:23 -06:00
Zacqary Adam Xeper 74a90b25c0
[Infra UI] Format arrays as ul elements in LogEntryFieldColumn (#38692)
* [Infra UI] Format arrays as ul elements in LogEntryFieldColumn

* Add enzyme test for LogEntryFieldColumn

* Fix tests

* Swap ul's for comma separation

* Use semantic markup for inline list

* Fix tests

* Use ::after element for comma separation

* Move ::after element to :not(:last-child)

* Hoist CommaSeparatedLi

* Use EuiThemeProvider in tests instead of isEnzyme prop

* Suppress type error with issue link
2019-06-14 10:07:35 -04:00
renovate[bot] b7dee440c5 Update webpack related packages (#38729)
* Update webpack related packages

* force updates to transient dep versions
2019-06-12 08:11:51 -07:00
spalger f5ab2a1701 [master] revert vega related upgrades
(cherry picked from commit 4b153a54c8)
2019-06-12 06:50:47 -07:00
renovate[bot] dfe30a9bdf Update dependency xmlbuilder to v9.0.7 (#38702) 2019-06-11 22:37:57 -07:00
Matthew Kime 6c3f15c56d
upgrade transitive dependencies (#38746) 2019-06-12 00:00:48 -05:00
renovate[bot] 2ef6c51149 Update dependency yauzl to v2.10.0 (#38704) 2019-06-11 16:17:50 -07:00
renovate[bot] a8d49ac8f1 Update dependency vega-tooltip to ^0.17.0 (#38700) 2019-06-11 16:16:21 -07:00
renovate[bot] f58ec118a8 Update dependency uuid to v3.3.2 (#38672) 2019-06-11 13:25:59 -07:00
renovate[bot] f9881d2c0c Update dependency vega-schema-url-parser to v1.1.0 (#38674) 2019-06-11 10:57:38 -07:00
renovate[bot] ff252022eb Update dependency vega-lib to v4.4.0 (#38673) 2019-06-11 10:55:57 -07:00
renovate[bot] 2a129e3823 Update dependency ui-select to v0.19.8 (#38671) 2019-06-11 10:51:38 -07:00
renovate[bot] e19b20dca4 Update dependency trunc-html to v1.1.2 (#38670) 2019-06-11 10:51:25 -07:00
renovate[bot] 6650b26ef7 Update dependency tinygradient to v0.4.3 (#38588) 2019-06-11 09:32:22 -07:00
Frank Hassanabad 131e3bf1a2
[SIEM] Change deprecated Buffer method for non-deprecated Buffer method (#38634)
## Summary
  * Added linter rule to prevent us from accidentally adding deprecated node methods
  * Added the new package linter plugin for NodeJS
  * Added unit test for the base 64 encoding for sanity check

Note:
Only the one line of code will be back-ported for the NodeJS fix for 7.2.0. The linter rule will not be back-ported. 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-10 22:15:11 -06:00
renovate[bot] 228ca2bee9 Update dependency tinymath to v1.2.1 (#38589) 2019-06-10 15:59:44 -07:00
renovate[bot] c6ebda3702 Update dependency rison-node to v1.0.2 (#38453) 2019-06-10 12:28:50 -07:00
renovate[bot] 78af9c8890 Update dependency tar to v4.4.10 (#38502) 2019-06-10 08:37:02 -07:00
renovate[bot] 46b40d0926 Update dependency simple-git to v1.113.0 (#38456) 2019-06-07 14:07:40 -07:00
renovate[bot] dced039b68 Update dependency rimraf to v2.6.3 (#38438) 2019-06-07 12:18:44 -07:00
renovate[bot] 2b05837aac Update dependency regression to v2.0.1 (#38437) 2019-06-07 12:18:28 -07:00
Stacey Gammon bd484391fc
Embeddable API V2 (#37510)
* Embeddable API plugin

* Expose new embeddableActions uiExport endpoint

* Add missing getInjectedUIAppVars to Server type

* Add jest tests

* Most basic skeleton of the sample plugin to see if it still kills ci

* strip even more out to see if it passes ci

* It passed, put back init fn

* add back in a uiExport to see if that is what is killing ci

* Passed again, add back embeddableActions uiExports and require kibana line

* Add everything back but the sass import

* Found two bugs with customize panel title action, added jest test coverage and fixes

* Functionally test embeddable explorer plugin

* Addressing review feedback part 1

* Simplify action context menu - remove support for nested actions/child panels, which was never exposed anyway.

* More review feedback

* Spread out orders to let developers inject their own actions in the middle.

* Remove check for overwriting ApplyFilterAction

* use createRegistry for EmbeddableFactoryRegistry

* Add comment for getInheritedInput

* Use kbn-es-query Filter types

* Fix missed file after createRegistry switch over for EmbeddableFactoryRegistry

* Use delete instead of setting to undefined

* upgrade EUI to match kibana version

* Add getIsContainer on base embeddable class

* Run functional tests of sample plugin

* move all tests classes outside __test__ and inside test_samples folder so not to potentially create issues with mocha

* fix: 🐛 remove unused imports

* fix: 🐛 set to undefined explicitly

* chore: refactored getRoot functionality

* fix: refactor miss from folder rename __test__ -> test_samples

* fix: add eui switch to let the user indicate “hide this title” to improve ux.

* fix: customize panel flout test

* Try to fix issue with multiple rxjs bundles I hit before.

See https://github.com/ReactiveX/rxjs/issues/3828

* Use an rxjs polyfill to work around the issue of multiple rxjs bundles

* chore: change customize panel flyout to modal post design feedback

* capitalize Reset

* fix: type errors in customize panel modal

* fix: remove extra line added to prevent EUICallout overflow from spilling over panel edges

The bug this was intended to fix doesn’t appear yet because dashboard isn’t using this, and it causes other issues, so for now, just remove.

* Clean up some classes and SASS

* Inline styles needed to get the containers to take up the full height of the app.

* Use the same old style of error messaging in panels

* chore: add untilEmbeddableLoaded tests, expose on interface, and use in embeddable_child_panel

* Remove unused styles, add padding

* Verify trigger Context containers an array of Filters for apply filter action

* Remove panel.embeddableId param, use panel.explicitInput.id instead

* Check `isCompatible` as well as the type guard needed for typescript.

* executeTriggerActions should account for getHref

* Remove unnecessary check for context being defined

* use npStart instead of getNewPlatform

* Conform to latest NP changes

* Use new np_mocks in all the tests

* Address review feedback on rxjs polyfill
2019-06-07 13:30:55 -04:00
renovate[bot] c08f3f179b Update dependency nock to v10.0.6 (#37886) 2019-06-07 06:30:26 -07:00
renovate[bot] ed61d9da8b Update dependency proxyquire to v1.8.0 (#37913) 2019-06-07 06:01:18 -07:00
renovate[bot] a6198fc5f5 Update webpack related packages (major) (#38372) 2019-06-07 06:00:29 -07:00
renovate[bot] b4b25e1fc4 Update dependency geckodriver to v1.16.2 (#37798) 2019-06-07 05:59:50 -07:00
Tim Roes cc372800ab
Convert Markdown components to TS (#38081)
* Convert Markdown components to TS

* Fix jest snapshots
2019-06-07 11:46:03 +02:00
renovate[bot] 21ebc9f973 Update dependency @microsoft/api-extractor to v7.1.8 (#38364) 2019-06-06 23:30:59 -07:00
renovate[bot] 85225036f6 Update dependency pegjs to v0.10.0 (#37889)
* Update dependency pegjs to v0.10.0

* PEG.buildParser() => PEG.generate()
2019-06-06 23:29:56 -07:00
renovate[bot] c536a62bc7 Update dependency leaflet to v1.5.1 (#37811)
* Update dependency leaflet to v1.5.1

* update baseline image

* Fix map draw controls

* Update CSS overrides to match updated package
2019-06-06 23:28:36 -07:00
renovate[bot] ea9d245259 Update webpack related packages (major) (#37552)
* Update webpack related packages

* raw-loader@2 uses esm, so we must import
2019-06-06 22:50:06 -07:00
renovate[bot] 297a895460 Update dependency @microsoft/api-extractor to v7.1.6 (#37760)
* Update dependency @microsoft/api-extractor to v7.1.6

* regenerate docs

* OverlayService: Import react instead of relying on global
2019-06-06 19:18:51 -07:00
Spencer 5973c2a08c
[dev/license_checker][dev/npm] reactor, ts-ify, de-grunt (#37807) 2019-06-06 10:16:19 -07:00
Rudolf Meijering ea9721ad13
[Core] Rewrite saved objects in typescript (#36829)
* Convert simple files to TS

* Fix jest tests

* Rename saved_objects_client{.js => .ts}

* WIP saved_objects_client

* saved_objects repository{.js => .ts}

* includedFields support string[] for type paramater

* Repository/saved_objects_client -> TS

* Fix tests and dependencies

* Fix saved objects type errors and simplify

* saved_objects/index saved_objects/service/index -> ts

* Fix saved objects export test after switching to typed mock

* Workaround type error

* Revert "Workaround type error"

This reverts commit de3252267eb2e6bf56a5584d271b55a7afdc1c53.

* Correctly type Server.savedObjects.SaveObjectsClient constructor

* saved_objects/service/lib/index.{js -> ts}

* saved_objects/service/lib/scoped_client_provider{js -> ts}

* Typescriptify scoped_client_provider

* Fix x-pack jest imports

* Add lodash/internal/toPath typings to xpath

* Introduce SavedObjectsClientContract

We need a way to specify that injected dependencies should adhere to the
SavedObjectsClient "contract". We can't use the SavedObjectsClient class
itself since it contains the private _repository property which in TS is
included in the type signature of a class.

* Cleanup and simplify types

* Fix repository#delete should return {}

* Add SavedObjects repository test for uncovered bug

Test for a bug in our previous js implementation that can lead to data
corruption and data loss.

If a bulkGet request is made where one of the objects to fetch is of a type
that isn't allowed, the returned result will include documents which have the
incorrect id and type assigned. E.g. the data of an object with id '1' is
returned with id '2'. Saving '2' will incorrectly override it's data with that
of the data of object '1'.

* SavedObject.updated_at: string and unify saved_object / serializer types

* Cleanup

* Address code review feedback

* Don't mock errors helpers in SavedObjectsClient Mock

* Address CR feedback

* CR Feedback #2

* Add kibana-platform as code owners of Saved Objects

* Better typings for SavedObjectsClient.errors

* Use unknown as default for generic type request paramater

* Bump @types/elasticsearch

* Fix types for isForbiddenError

* Bump x-pack @types/elasticsearch
2019-06-06 10:49:13 +02:00
Tiago Costa 162e13dbdf
Relative cache loader (#36131)
* chore(NA): first efforts to enable cache-loader relative paths and disable babel-register cache. chore(NA): allow to use cache-loader results everywhere as a persistent cache.

* chore(NA): last change to support cache loader across envs.

* fix(NA): cache-loader config generator function scope.

* refact(NA): static cache config for dll compiler.

* chore(NA): support for force writable cache flag. use built assets for cache on distributable.

* chore(NA): update cache-loader to last version. fix(NA): logic bug with force writable cache flag.

* chore(NA): move optimize cache to built_assets.

* chore(NA): relative paths for sourcemap configurations.

* chore(NA): remove redudant check for process.env var.

* refact(NA): simplify double negated expression.

* chore(NA): remove webpack prefix from devtoolModuleFilenameTemplate.

* chore(NA): rename cache write force flag to KBN_CACHE_LOADER_WRITABLE.

* chore(NA): readd babel register cache.

* chore(NA): change .cache to .ui_bundles_cache

* chore(NA): change .ui_bundles_cache to cache/ui_bundles

* chore(NA): update gitignore with .babel_register_cache.json

* chore(NA): rollback devtool module filename template to asbolute resource path.

* chore(NA): apply cache-loader patch.
2019-06-05 15:17:56 +01:00
Vadim Dalecky a53e480881
feat: kibana-react initial setup (#37206)
* feat: 🎸 add NP TypeScript typings

* feat: 🎸 add kibana-react context provider

* feat: 🎸 add initial in-memory core implementation

* test: 💍 simplify useKibana() tests

* feat: 🎸 add useObservable() hook

* test: 💍 implement initial mock for uiSettings for testing

* feat: 🎸 add useUiSetting() hook

* docs: ✏️ update function name

* test: 💍 use core mock for testing useUiSetting() hook

* chore: 🤖 remove unused types

* chore: 🤖 fix linter error

* test: 💍 move core mock inline

Currently it fails on CI because of the relative import, so moving the
mock inline util it is resolved.
2019-06-03 16:27:13 -07:00
Chandler Prall 86fea48875
Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui (#36316)
* Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui

* update snaps

* Clicking on the svg itself once loaded

* updated snaps

* update icon in snapshots

* Fix snapshot
2019-06-03 12:01:01 -04:00
renovate[bot] 09b1af0bd3 Update d3 related packages (#37786)
* Update d3 related packages

* [ml/explorer_chart/single_metric] update assertion
2019-06-03 07:01:48 -07:00
renovate[bot] 2e14e60128 Update dependency js-yaml to v3.13.1 (#37809) 2019-06-02 09:59:55 -07:00
renovate[bot] 43f546fa8d Update dependency leaflet-draw to v0.4.14 (#37812) 2019-06-02 09:59:36 -07:00
renovate[bot] 0426d301a9 Update dependency node-fetch to v1.7.3 (#37821) 2019-06-02 09:58:15 -07:00
renovate[bot] c80a33f8a8 Update dependency mustache to v2.3.2 (#37816) 2019-06-02 02:47:32 -07:00
renovate[bot] a851018e90 Update dependency lru-cache to v4.1.5 (#37814) 2019-06-02 02:47:19 -07:00
renovate[bot] 65bf608232 Update dependency leaflet-responsive-popup to v0.6.4 (#37813) 2019-06-02 02:47:02 -07:00
renovate[bot] c8bee5ce4f Update dependency json-stringify-pretty-compact to v1.2.0 (#37810) 2019-06-02 02:46:19 -07:00
renovate[bot] 84b074248c Update dependency hjson to v3.1.2 (#37800) 2019-06-01 21:35:08 -07:00
renovate[bot] 05727d750c Update dependency font-awesome to v4.7.0 (#37787)
* Update dependency font-awesome to v4.7.0

* rename license for new font-awesome version
2019-06-01 21:12:03 -07:00
renovate[bot] a293b2d38c Update dependency image-diff to v1.6.3 (#37801) 2019-06-01 19:06:52 -07:00
renovate[bot] 47896b3ec0 Update dependency jimp to v0.6.4 (#37802) 2019-06-01 19:06:10 -07:00
spalger 8f83299cd1 Revert "Update dependency geckodriver to v1.16.2 (#37788)"
This reverts commit 2e1b275338.
2019-06-01 11:45:47 -07:00