* [Maps] custom labels for metrics
* fix onRemove
* set metric propertyLabel to custom label when provided
* add metrics label around MetricsEditor for geo grid source
* do not use label in terms join metric expression
* fix requerying of the data when custom label changes
* remove extra space
* add comment to LeftInnerJoin.getSourceId
* use FormRow.labelAppend instead of absolute positioning for delete aggregation button
* fix i18n translations
* [Maps] set data-render-complete when layers are loaded
* ignore layers that are not visible
* use timeout to give time for render to complete
* move check for layer visibility out of isDataLoaded and into areLayersLoaded selector
* prepend private functions with _ in name
* rename isRenderTimeoutComplete to isInitialLoadRenderTimeoutComplete
* update AbstractLayer.isDataLoaded default implemenation to check source data request to TileLayer source requests are checked
* TileLayer cleanup
* rename for clarity
This implements the overview page changes described in elastic/uptime#41 and https://docs.google.com/document/d/1jlyOam08gC3oq0W8dim0BF-5QYEOXFqSg48nMwbirmg/edit
One change that was necessary was omitting the swimlane visualization. After speaking to the ML team it was discovered that incorporating this component isn't possible yet, as it requires cross-plugin code sharing. In its stead we have re-used the monitor checks over time graph. We may want to keep this, as the graph used here is superior for multiple IP use cases.
* Changes x-pack action executor to return result.
Previously, the result was never captured. It's now captured, and
returned if it's JSONable. If not JSONable a `{succcess: true}`
object is returned with a 200 response (used to be 204).
Also added logging for action execution calls, in lieu of having an
action history available.
Drive-by:
- `services.log` was set to the unbound Hapi server.log method, so
places where it was set were changed to bind it to the server.
* Embeddable and Visualize to use type definitions from kbn-es-query package
* moved state watching to new filter manager and removed query filter dependency on rootScope
* Deleted unused pinFilter
* Extracted merge fitlers function
* Changed mappedFilters name
* Move state management to new filter management as well. query filter is now just a wrapper.
* Code works correctly with new setup of query filter
* improved typing
* Moved mapping into new filter manager
* removed promise dependency from query filter
* Extracted filter state manager from query filter
* Moved addFiltersAndChangeTimeFilter logic into new filter manager
* Fixed addFiltersAndChangeTimeFilter implementation
* Moved all logic to new filter manager - query filter is just a wrapper now!
* Connected query_filter observable management to new filter manager as well
* Usage example in discover
* filter state management tests + fire less events from filter state manager
* Tests for filter manager and filter state manager
* Moved new filter manager to data plugin
* Got rid of FilterManagerProvider and turned it into a getFilterGenerator function that works with the new FilterManager.
Need to merge this code with FilterManager.
* Added tests that make sure that filter manager listens to filter state manager
* fix typo
* Fixed action add filter test
* Fixed increasePredecessorCount test
* Fixed increaseSuccessorCount test
* Fixed setPredecessorCount test
* Fixed setQueryParameters test
* Fixed setSuccessorCount test
* Fixed doc table filter actions test
* Fixed filter generator tests
* rename argument
* Moved push filters into vis filters (only place where its used)
* Filter type fix, test fix
* Removed irrelevant filter tests (for deleted methods)
Added state to filters
* Fixed most of get filters errors by sleeping (TODO!)
* Added destroy methods
Improved merge logic
Improved remove filter tests to use add filter (to avoid having for filter state manager to catch up)
* Fixed discover functional tests
Added default empty filter state in filter generator
Some more browser test adjustments
* Allow filter $state to be empty
* Fixed types
* Code review with @splager
- subscribeWithScope
- query filter to return angular promises
- remove unneeded Promise.resolve
* Separate class\type defenitions from plugin instance setup in shim plugin definition
This helps avoiding circular dependency issues that were obsereved in filter-manager branch (due to code starting to use the data plugin).
* typescript fun
* Fixed merge
* updated some get filter tests to work with add filter, and therefore moved them to add_filters.js
* Remove shouldFetch and add comment explaning the observable.
* Minor code style fixes
* Code review fixes and changes
* Moved Karma tests to jest
* Fixed merge
* Fixed some type errors
* Improved watchFilterState logic
* Removed addFiltersAndChangeTimeFilter test for now, as I'm having TS difficulties
* filters can also be null
* Further watch state fine tuning
* Get data instance inside provider to avoid circular deps
* mock chrome
* Removed change to range filter
* Deleted unnecessary injects
* dedup setFilters as well
* deleted unused subscription
* Added tests for setFilters de-dupe
* Update src/legacy/core_plugins/data/public/filter/filter_manager/filter_state_manager.ts
Co-Authored-By: Stacey Gammon <gammon@elastic.co>
* Update src/legacy/core_plugins/data/public/filter/filter_manager/filter_manager.ts
Co-Authored-By: Stacey Gammon <gammon@elastic.co>
* Code review minor fixes
- Adds a column mode to the data frame transforms list to indicate if the transform is batch or continuous.
- For continuous data frames an animated horizontal loading indicator is shown in the Progress column instead of a progress bar with percentage.
- In expanded rows, for Job details the section checkpointing was added.
- In the transform wizard's creation step, for continuous transforms the progress bar is not shown. In a follow up we could add more useful stats there, like what's shown in the transform list's job details.
The data frame wizard's source index preview table would crash with some field values more complex than strings. This PR fixes it by adding the following "special treatment" for these values:
Arrays of strings will be concatenated to a comma separated string in table rows.
Arrays of objects will be rendered as a badge with the label array and a tooltip that says that the full value is available in the expanded row.
In the expanded row, every value that's not a string will be rendered using JSON.stringify().
* Execute locally configured pre-commit hooks
This change enables users to add and execute locally configured pre-commit hookly configured pre-commit hooks. Previously this was not possible because kibana bootstrap installs its own pre-commit in the `.hooks` folder.
To add a locally configured pre-commit hook, simply create a `.pre-commit` file in the root folder. Kibana's pre-commit hook will check if this file exists and if it does, execute it.
* Address review feedback
* remove GIT_PARAMS, because https://git-scm.com/docs/githooks#_pre_commit
* Added fit to window zoom option
Added reset zoom option
Added divider between zoom and reset options
* Fixed zoom in/out from fit to window scale
* PR feedback
* Fixed fit to window with elements way off the workpad
* Ensure zoom level array is always in ascending order
* Updated storyshot
* Convert function tests to jest
* Fix some bad merge conflict resolutions
* Exclude Server tests from being included in mocha run
* Remove code leftover from testing
* Fix rebase
* Fix paths for running Jest tests
* do not run function server tests as part of test:server
* Move Jest tests to be alongside files
* Box select: highlight box
* Lint
* Create interaction boundary
* PR feedback: selection box should not include group members (therefore undoing the box won't dissolve said groups)
* Change actionType unencryptedAttributes to be non-optional
Will help ensure that action type creators actually spell out which
properties should NOT be encrypted. As an example, when implementing
the email action type, I didn't have a value set, so all properties
were encrypted, which is not ideal.
* add now-required unencryptedAttributes to tests
* fix snapshot in test
