Commit graph

15927 commits

Author SHA1 Message Date
CJ Cenizal
cb5f508e6b [UI Framework] [K7] Improve generator snippets (#13598) (#13599)
* Remove extraneous path info from SCSS import snippet.
* Add GuideCode to demo page. Put stateless function params on multiple lines.
* Log an error if you try to create a component with a blank name.
2017-08-18 16:12:53 -07:00
Chris Cowan
8aaa900854 Fixes #12866 - Use devicePixelRatio to scale up and down canvas values in TSVB (#13565) 2017-08-18 14:30:17 -07:00
Matt Bargar
9e48298844 Emphasize important difference between Kuery and Lucene query syntax (#13592)
Fixes #13563

Brings additional attention to the fact that Kuery uses implicit ANDs whereas Lucene query syntax uses implicit ORs, which could confuse users if they're not aware of the difference.
2017-08-18 16:45:28 -04:00
Chris Roberson
abb54ac445 Fix breaking scope changes in the field format editor samples (#13549) 2017-08-18 14:47:40 -04:00
Chris Roberson
e0708ab7da Add aria describes for warning label, #12864 (#13576) 2017-08-18 13:08:16 -04:00
Matt Bargar
e7ca19586d Improves dark theme support in the filter editor (#13522)
Fixes #12955

* Added dark theme support to the ui framework modal component
* Also fixed z-index issue where dashboard panels would appear above the filter editor modal when the user moved or resized the panel (see gif below)
2017-08-18 11:05:40 -04:00
Jonathan Budzenski
61c3f38d32 [console] Replace text/plain fallback with application/json (#12294)
* [console] Always set content-type for requests to es

* [console] always set content type to application/json if there is a body

* remove extra space
2017-08-18 10:01:52 -05:00
Chris Cowan
7fb2d7f623 Duration Formatting for TSVB (#13337)
* Adding duration formatter

* Adding decimal places

* Fixing bug with decimals

* Relaxing the duration format test
2017-08-18 07:41:15 -07:00
Tim Roes
ef67957119 Improve accessibility of visualizations (#13507)
* Fix markdown vis settings labels

* Fix contrast ratio of markdown blockquotes, #12491

* Fix fontsize of blockquotes in markdown, #12904

* Add vis type description for screen reader, fix #12887

The way tooltips are currently implemented we unfortunately cannot use
the tooltip for the aria-describedby. This is another issue to solve.

* Make main nav a11y when collapsed

* Camel case the vistype id used in HTML
2017-08-18 09:58:11 +02:00
Tim Roes
f66c5dbd39 Improve Dev Tools accessibility (#13496)
* Make console actions accessible

Use a button isntead of a link will solve all accessibility issues, and
we just need to style the button the same way we style the links.

* Create kbnUiAceKeyboardModeService

This will be needed for situations in which the initialization need to
be started manually, and a simple directive won't be enough.

* Make console input box accessible

* Make editor_actions buttons instead of links
2017-08-18 09:54:24 +02:00
Spencer
375ee3b206 [ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit" (#13544) 2017-08-17 11:26:44 -07:00
Matt Bargar
e09b91403c Fix fixed-scroll on Discover page (#13516)
Some CSS changes were made in #10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416
2017-08-17 12:50:22 -04:00
spalger
8cd269678a remove spammy console.log() 2017-08-16 19:32:34 -07:00
Tyler Smalley
911467a78e Prevents default index pattern name when ID is provided (#13353)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-08-16 09:51:16 -07:00
Jim Unger
0920a99a15 Adds getAriaName function and applies it to advanced settings (#13448) 2017-08-16 10:38:44 -05:00
Lukas Olson
c4c6ea1565 Handle booleans in filter editor (#13406)
* Handle booleans in filter editor

* Use select instead of checkbox
2017-08-16 06:02:42 -07:00
Varun Sharma
f2782d66ea #10569 Fixes the position of spy tab buttons at the top of the widget (#13366)
* #10569 Fixes the position of spy tab buttons at the top of the widget

* #10569 Fixes the position of spy tab buttons at the top of the widget.

* Fixes CSS for Spypanel Selector Menu.
2017-08-15 12:32:07 -04:00
Tim Roes
92e795a9c8 Improve accessibility of the discover app (#13498)
* Add sectioning to discover app, fix #12633

* Set unique page title for discover app, fix #12641

* Remove sort button if column isn't sortable

Until now the button was just empty, but could still be focused via
keyboard. This is bad accessibility, so the sort button is now removed
completelyw hen the column isn't sortable.
2017-08-15 16:45:52 +02:00
Tyler Smalley
071e983444 Prevents canceling index pattern modal from throwing error (#13488)
* Prevents canceling modal from throwing error

Fixes #12818

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Prevents refresh and removes returned promise

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-08-15 07:37:32 -07:00
Chris Cowan
c12ef6fcf9 Fixes #12113 - Add timezone to date histogram aggregations for TSVB (#13378)
* Fixes #12113 - Add timezone to date histogram aggregations

* Fixing tests

* Fixing tests

* Moving to universal timezone function
2017-08-14 17:06:26 +02:00
Tim Roes
99f1c65c4b Initial version of accessibility guide (#13390)
* Initial version of a11y guide

* Move a11y content from HTML guide to a11y guide

* Add PR feedback

* Add PRs feedback

* Add more roles

* Refactor labeling elements section

* Rename "labeling elements" -> "naming elements"

* Use span instead of i for icon examples

* Correct typo
2017-08-14 07:42:06 +02:00
Court Ewing
2fbfa531c7 github: PR template checklist in a comment
The checklist of items in the PR description should be in a comment so
you don't have to manually remove them on every pull request.
2017-08-12 10:28:21 -04:00
Lisa Cawley
dfc6408c25 [DOCS] Use shared versions file for doc builds (#13277)
* [DOCS] Use shared versions file for doc builds

* [DOCS] Address feedback in index-shared1.asciidoc
2017-08-11 14:06:04 -07:00
CJ Cenizal
fbaf4e638b [eslint-config-kibana] Upgrade eslint-config to 0.10.0. (#13323)
* Upgrade eslint-config to 0.10.0.
* Fix linting violations with popover and typography stuff in UI Framework.
2017-08-11 11:48:54 -07:00
CJ Cenizal
9671486d98 [UI Framework] Add functionality for hiding and showing the chrome when viewing Sandboxes (#13475)
* Update UI Framework doc site with functionality for hiding and showing the chrome when viewing Sandboxes. (#13437)
* Fix formatting in generator-kui templates. (#13443)
2017-08-11 09:44:23 -07:00
CJ Cenizal
720297d8da [UI Framework] Reorganize UI Framework and add Yeoman generator (#13172)
* Reorganize documentation styles so they all live in doc_site/components directory. (#12809)
  - Remove global styles, e.g. body and html element selectors.
* Create global_styles dir with sub-directories. (#12833)
* Add SCSS style guide. (#12850)
* Refactor UI Framework directory structure to house everything in a src directory. (#12880)
  - Add components/index.js and services/index.js files to continue to export JS modules from the root.
* Add KUI Yeoman generator.
* Support creation of components.
* Add documentation generator for main page, demo, and sandbox.
  - Add additional documentation snippets to KUI generator. (#13076)
  - Fix incorrect use of double quotes in KUI generator snippet. (#13086)
  - Remove infrequently used imports from the KUI generator test template. (#13110)
* Mock assets files for Jest. (#13060)
* Fix broken coverage report paths in Jest config. (#13082)
* Update eslint config to lint the new UI Framework directory structure. (#13102)
* Fix positioning of doc site pagination buttons. (#13203)
* Support hasReact prop for sandboxes. (#13270)
* Remove deprecated used of component mixin from KUI generator's SCSS template. (#13377)
* Fix rebasing errors.
  - Add dashboard back to Jest config.
  - Add missing form and tool_bar variables.
* Rename tasks to createComponent and documentComponent.
* Reference correct src paths in README.
* Add children and className to templates' propTypes.
* Add default folder name for page demo.
* Add suffix to sandbox routes.
* Specify testPathIgnorePatterns more clearly.
* Rename component.test.js to test.js so that Jenkins won't try to run it.
* Update npm scripts to depend on local yo dependency, not global.
* Add ui_framework/src to copy task.
* Simplify npm scripts and remove requirement for installing Yeoman from README.
* Add services to moduleNameMapper in jest config.
* Clean up Button and Gallery examples.
2017-08-11 08:48:48 -07:00
Stacey Gammon
bbabe48b36 Avoid a wrapped retry and use exists instead of find, which will take up all the time allotted for the retry if it fails once (#13467) 2017-08-11 11:34:30 -04:00
CJ Cenizal
0a732a66ee Fix KuiPopover examples. (#13461) 2017-08-11 08:11:11 -07:00
Court Ewing
5d304b2571 remove @bigfunger/jsondiffpatch (#13442)
This dependency is no longer used.
2017-08-11 10:05:30 -04:00
Chris Cowan
17fcaf129c Fixes #13246 - Add checks for empty annotations (#13422)
* Fixes #13246 - Add checkes for empty annotations

* Refactoring get_annotations to use async/await
2017-08-11 01:49:54 +02:00
Chris Cowan
4a06de89e8 Moving timezone functions from Timelion to Vis (#13457)
* Moving timezone functions from Timeline to global

* Fixing a missing require
2017-08-11 01:41:17 +02:00
Thomas Neirynck
2df0c27d3d ensure editor mode propagates correctly (#13355) 2017-08-10 18:12:42 -04:00
Chris Cowan
805c15cc78 Fixes #12685 - Improve error handling, add error for missing aggregations key. (#12688) 2017-08-10 23:42:10 +02:00
Lisa Cawley
3a07e5c8c0 [DOCS] Update links to Kibana security (#13456) 2017-08-10 14:14:34 -07:00
Chris Cowan
6900e9ec08 Fix a bug with the interval label for TSVB (#13440)
* Fix a bug with the interval label for TSVB

* Ensure reduce returns something
2017-08-10 19:23:00 +02:00
Chris Roberson
d12aa4b12b [Management] Improve accessibility within management (#13364)
* Use header/h tag for tab header, #12861

* Add tabindexes for tables, #12862

* Add for/id pairings, #12863

* Search role, #12868

* Use better descriptions for aria labels, #12865

* Add aria label, #12870

* Button and a tags are already in tab order, removing unnecessary change

* The input field cannot contain the role="search"

* The tabindex needs to be on the element which the click handler

* Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles)

* Revert "Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles)"

This reverts commit c54ea227889898baef85ee71b3350bbf69ef5d7c.

* Remove the extra code my cat added

* Addressing hidden inputs from #12863

* Remove unnecessary header tag

* Add clarifying comment

* Prevent multiple ids
2017-08-10 13:19:03 -04:00
Matt Bargar
6193a7f318 Remove esAdmin mention from docs since it no longer exists (#13449)
The angular service was removed in #13000
2017-08-10 12:30:44 -04:00
Thomas Neirynck
f1e5be86fe Visualize Accessibility Issues (#13428) 2017-08-10 11:11:18 -04:00
Spencer
7e16d19249 [npm] move personal forks into elastic org (#13410) 2017-08-09 12:31:30 -07:00
Tim Roes
e66c1d2ac4 Create keyboard mode for ui-ace editor (#13339)
* Add kbn-ui-ace-keyboard-mode directive

* Implemented PR feedback

* Fix broken tests
2017-08-09 21:24:04 +02:00
Spencer
12142da71b [server/stats] add server.getKibanaStats() for programatic access (#13411) 2017-08-09 09:27:54 -07:00
Stacey Gammon
db4eb64aef Be case insensitive when sorting on the visualize and dashboard landing pages (#13397) 2017-08-09 12:20:59 -04:00
Lukas Olson
e545b12018 Truncate long field names in filter editor (#13379)
* Truncate long field names in filter editor

* Update filter editor styles
2017-08-09 08:43:55 -07:00
Matt Bargar
3b0c820f12 Make 'all filters' actions keyboard accessible (#13391)
* Make 'all filters' actions keyboard accessible
* Add extra aria props to actions toggle
2017-08-09 11:21:40 -04:00
Stacey Gammon
7199476c1f port k7 popover component over (#13322)
* port k7 popover component over

* Fix line height

* Clean up css
2017-08-09 10:37:40 -04:00
Stacey Gammon
fb203eaf2e Intentionally show spy pane in full screen mode, but not embed mode (#13395) 2017-08-09 09:41:09 -04:00
Spencer
8a64872ecb [fix/UiSettings] ignore certain errors (#13079)
* [SavedObjectClient] emit detectable errors

* [uiSettingsService] consume new SavedObjectsClient errors

* [SavedObjectsClient] expose errorTypeHelpers as such

* [elasticsearch/tests] recreate error for each test

* [http] wait for elasticsearch plugin to be ready

* [shortUrl/tests] ensure that create request responds with 200

* [shortUrl] use errorTypeHelpers to filter errors

* [uiSettings/savedObjectsClientStub] stub errorTypeHelpers

* [SavedObjectsClient/errors] expose error module so tests can make errors

* [shortUrl/tests] use actual SavedObjectsClient errors

* [uiSettings/savedObjectsClientStub] use actual errors lib

* [SavedObjectsClient] use decorate instead of "wrap"

* [server/routes/uiSettings] refactor routes to forward Boom errors from uiSettings

* [uiSettings] colocate routes and service

* [testUtils/esTestCluster] use more standard api style

* [testUtils/es] add createCallCluster util

* [testUtils/esTestCluster] add getters for client/callCluster

* [es/healthcheck] ensure that healtcheck stops when server is stopped

* [uiSettings/routes] add param/payload validation

* [uiSettings/routes] add tests that verify error behaviors
2017-08-08 17:55:36 -07:00
Spencer
924548864d [es/healthcheck] ensure that healthcheck stops when server is stopped (#13201) 2017-08-08 15:11:23 -07:00
Stacey Gammon
b5e13ff1d0 Fix dark theme issues with spy toggle and spy pane (#13345)
* Fix dark theme issues with spy toggle and spy pane

* Port dark theme portion of styling kuiIcon into uiFramework library
2017-08-08 15:21:00 -04:00
Matt Bargar
542d553fe2 Make filter pills keyboard accessible (#13331)
Fixes #12639

It's now possible to tab to each filter's actions and interact with them via the keyboard.

In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
2017-08-08 13:06:20 -04:00