Commit graph

3518 commits

Author SHA1 Message Date
patrykkopycinski a58cc5da12
[SIEM] Fix AlertsTable id (#63368) 2020-04-13 19:40:48 +02:00
Ryland Herrick 5559b09dcc
Consistent terminology around cypress test data (#63279)
* Uses "data" or "test data" when referring to the general idea
* Uses "archive" when referring to the specific data/implementation
* Adds a few grammar/spelling tweaks
2020-04-13 12:24:09 -05:00
Nathan Reese c604eb9e63
[Maps] fix regression in loading left join fields (#63325)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-13 08:00:15 -06:00
MadameSheema e74d360adb
fixes test flakiness (#63331) 2020-04-13 15:38:32 +02:00
Thomas Neirynck bbd501ea51
[Maps] Cleanup sources (#63175)
- Introduces additional TS typing for sources
- Organizes sources in sub-directories by type
- migrates XYZTMSSource to TS
2020-04-13 09:24:16 -04:00
Shahzad c7f61f956a
[Uptime] Update Ml functional test (#62562)
* update test

* added test

* updated type

* updated test

* updated test

* update test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-13 13:49:46 +02:00
Shahzad 61271c0652
[Uptime] Simplify monitor param usage (#63121)
* add useMonitorId hook

* update url param hook

* update type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-13 13:44:10 +02:00
Cauê Marcondes 2be6b7fdce
fixing custom link popover size and hiding scroll (#63240) 2020-04-11 11:06:39 +02:00
The SpaceCake Project 39fbc5e103
bc6 rule import april 9 (#63152)
* bc6 rule import april 9

Increased the lookback of the ML rules

* re-import

with LF chars

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-10 17:50:23 -04:00
Ryland Herrick d8a295dcbc
[SIEM] Link ML Rule card CTA to license_management (#63210)
* Link ML Rule card CTA to license_management

Taking the user directly to the license management page within kibana
(where they could immediately start a trial subscription) is much more
actionable than taking them to the subscriptions marketing page.

* Revert translation key change

Neither of these is totally accurate, and there've already been
translations written for the old one.
2020-04-10 14:00:11 -05:00
Tim Sullivan aed5253b53
[Reporting] convert all server unit tests to TypeScript (#62873)
* [Reporting] convert all server unit tests to TypeScript

* fix ts

* revert unrelated change
2020-04-10 09:57:59 -07:00
Wylie Conlon f96f928e69
[Lens] Fix error in query from generated suggestion (#63018)
* [Lens] Fix error in query from generated suggestion

* Update from review comments

* Fix test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-10 12:29:26 -04:00
Steph Milovic 55a3cc4583
[SIEM] [Cases] Unit tests for case UI components (#63005) 2020-04-10 09:55:38 -06:00
Nathan L Smith e8491adbab
Use globe icon for "ext" span type on service map (#63205)
Both "external" and "ext" can be returned and should have the same icon.
2020-04-10 09:04:17 -05:00
Cauê Marcondes 77d22f55d9
[APM] Agent config select box doesn't work on IE (#63236)
* adding value property to select options

* fixing test
2020-04-10 14:54:48 +02:00
MadameSheema 34b1d0a10d
[SIEM] Updates cypress readme with documentation about the test data. (#62747)
* updates test data section

* Update x-pack/legacy/plugins/siem/cypress/README.md

Co-Authored-By: Ryland Herrick <ryalnd@gmail.com>

Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
2020-04-10 11:28:59 +02:00
Cauê Marcondes 83b9417d45
[APM] Custom links submit button is off screen in IE11 (#63122) 2020-04-10 09:28:06 +02:00
CJ Cenizal 982c0da78e
Move ILM out of legacy (#61915)
* Rename IndexMgmtSetup to IndexManagementPluginSetup.
* Remove unused fetch index template route and related tests.
* Remove unnecessary custom styles.
2020-04-09 16:51:22 -07:00
Tim Schnell 783e3c17a9
ignore some things for code coverage (#62701)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-09 14:32:24 -05:00
Christos Nasikas 38f7bfb133
[SIEM][CASE] Test configuration API and hooks (#62803)
* Test API

* Test useConnectors

* Test useConfigure

* Fixes
2020-04-09 21:26:13 +03:00
Joel Griffith 2574d0f805
Adds a new config flag to encode with BOM for our CSVs (#63006)
* Adds a new config flag to encode with BOM for our CSVs

* Push out bom-chars to it's own constant

* Getting those snapshots back into shape 💪

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-09 11:01:25 -07:00
Maryia Lapata dfea62187f
[NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (#61575)
* Move buildHierarchicalData to vislib

* Move shortened version of buildPointSeriesData to Discover

* Move buildPointSeriesData to vis_type_vislib

* Convert unit tests to jest

* Remove ui/agg_response

* Convert point_series files to TS

* Update TS in unit tests

* Convert buildHierarchicalData to TS

* Convert buildPointSeriesData to TS in Discover

* Clean TS in Discover

* Update TS for buildHierarchicalData

* Update buildHierarchicalData unit tests

* Clean up TS in point_series

* Add unit tests fro response_handler.js

* Simplify point_series for Discover

* Return array for data

* Add check for empty row

* Simplify point_series for Discover

* Return all points

* Specify TS

* Refactoring

* Simplifying

* improve types

* Update _get_point.test.ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-04-09 18:56:36 +03:00
Joe Reuter 8d21b6b6f3
Move search source parsing and serializing to data (#59919) 2020-04-09 14:06:01 +02:00
Devin W. Hurley 274cb805e1
[SIEM] [Detection Engine] Fixes bug when notification doesn't… (#63013)
Set refresh on bulk create to 'wait_for' when actions are present, so we do not respond until the newly indexed signals are searchable.

* set refresh on bulk create to 'wait_for' when actions are present, so we do not respond until the newly indexed signals are searchable

* fix types in tests
2020-04-08 19:58:50 -04:00
Frank Hassanabad c643148f36
[SIEM][Detection Engine] Fix rule notification critical bugs
## Summary

Fixes critical bugs found during testing of the rule notification.

* Fixes a bug where when you turn on rules quickly such as ML rules you would see these message below. This message can also be seen when you first create a rule with an action notification. This is a race condition with how we update rules multiple times when we really should only update it once and do it before enabling a rule

```
server    log   [12:18:35.986] [error][alerting][alerting][plugins][plugins] Executing Alert "63b828b5-24b9-4d55-83ee-8a8201fe2d76" has resulted in Error: [security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } 
``` 

* Fixes a bug where we were using `ruleParams.interval` when we should have been using `ruleAlertSavedObject.attributes.schedule.interval`. When changing rule notifications to run daily, weekly, etc.. you would see this exception being thrown:

```
server    log   [21:23:08.028] [error][alerting][alerting][plugins][plugins] Executing Alert "fedcccc0-7c69-4e2f-83f8-d8ee88ab5484" has resulted in Error: "from" or "to" was not provided to signals count query
```

* Fixes misc typing issues found
* Fixes it to where we no longer make multiple DB calls but rather pass down objects we already have.
* Changes the work flow to where we only update, create, or patch the alerting object once which fixes the race condition and improves the backend performance.
* Removes left over unused code
* Applied https://en.wikipedia.org/wiki/Single-entry_single-exit to functions where it made sense and easier to read.


### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-08 17:36:20 -06:00
Brittany Joiner 0c35762f27
Add Error Exception Type Column (#59596)
* start of error exception type

* width and link

* removed extra line

* updated snapshot

* updated snapshots

* updated snapshots

* Update snapshots

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2020-04-08 18:08:13 -05:00
Matthew Kime e0a519424f
Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (#62594)
* implement index pattern management plugin in new platform
2020-04-08 15:10:44 -05:00
Oliver Gupte 184f59447b
[APM] Service map - fixes layout issues for maps with no rum services (#62887)
* Closes #62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
2020-04-08 11:13:39 -07:00
Nathan Reese 3598b8c44c
[Maps] fix attribution overflow with exit full screen button (#62699)
* [Maps] fix attribution overflow with exit full screen button

* use margin-left instead of padding-left

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 11:24:04 -06:00
Shahzad 8cacbdfaa5
[Uptime]Alerting UI text in case filter is selected (#62570)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 19:23:16 +02:00
Yuliia Naumenko 730dcbf638
Implemented actions server API for supporting preconfigured connectors (#62382)
* Implemented actions server API for supporting preconfigured connectors defined in kibana.yaml

* Fixed type check

* Fixed due to comments and extended functional tests

* Fixed tests and renamed connectors

* fixed jest tests

* Fixed type checks

* Fixed failing alert save

* Fixed alert client tests

* fixed type checks

* Fixed language check error

* Fixed jest tests

* Added missing comments and docs

* fixed due to comments

* Fixed json config for preconfigured

* fixed type check, reverted config

* config experiment with json stringify

* revert experiment

* Removed the spaces from connector names in config
2020-04-08 09:54:42 -07:00
Yara Tercero 5d34697ea5
[SIEM][Detection Engine] - Update list values in REST interfaces (#62320)
Summary
- #60022
- Follow up on #60171
- Modifies boolean filters to enum of "included" and "excluded"
- Adds operator types of enum "match", "match_all", "list", and "exists"
- Adds values properties to include those for "list"
- DOES NOT FILTER ON THE VALUES JUST YET (That will be a follow on PR)
2020-04-08 10:46:06 -04:00
Poff Poffenberger d94d7cc719
[Canvas] Fix Canvas-specific storybook after new platform changes (#61876)
* Fix Canvas storybook webpack config

* Temporarily disable workpad export example

* Mock out lib/notify and download_workpad

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 09:20:25 -05:00
Aaron Caldwell 67536e4b3c
Fix issue with license not getting obtained & passed to server… (#62883) 2020-04-08 08:12:37 -06:00
MadameSheema aa54929fb5
skips 'Sorts by activated rules' (#62924) 2020-04-08 15:14:07 +02:00
Frank Hassanabad 5218e30487
[SIEM][Detection Engine] Fixes TypeScript types and adds format to time range query
## Summary

* Fixes the Type Script types so we don't have to use non-null-assertions
* Adds null checks where needed
* Changes the time range query to have a format of epoch to avoid mapping issues

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-07 19:37:47 -06:00
Tiago Costa 7e3c68bb7a
chore(NA): removes server imports from canvas src plugin (#62783)
* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
2020-04-08 00:44:38 +01:00
Cauê Marcondes 20dc67df71
[APM] Agent span_frames_min_duration configuration input cannot handle 0 or -1 (#62777)
* changing duration min value for span_frames_min_duration

* adding min property to number field
2020-04-07 20:18:35 +02:00
Chris Roberson 8ffc08f2f7
[REVERT THE REVERT] [Monitoring] Cluster state watch to Kibana alerting (#62793)
* Revert "Revert "[Monitoring] Cluster state watch to Kibana alerting (#61685)""

This reverts commit f1bd3bdacb.

* Fix i18n error

* Fix test
2020-04-07 13:44:34 -04:00
Cauê Marcondes d70718426f
[APM] Change custom link from EuiListGroupItem to EuiLink (#62742) 2020-04-07 18:39:52 +02:00
Corey Robertson 2c4cc12b98
Removes Pitch Presentation Template from Canvas (#62688)
* Removes Pitch Presentation Template from Canvas

* Fix test

* Keep translation to not fail i18n
2020-04-07 11:55:06 -04:00
Xavier Mouligneau 8eb9fdd6eb
[SIEM] Update beat doc (#61902)
* add new ecs description

* new auditbeat/filebeat description

* update description winlogbeat

* bring back description in pictures

* review I + use ECS doc as last ressource when you do not know the index

* update test

* safety default just in case

* fix functional test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 10:27:11 -04:00
Nathan L Smith cd1e11bce6
Add service map icon for rum-js agent type (#62721)
* Add service map icon for rum-js agent type

We previously were only checking for "js-base" as the RUM `agent.name` but it can report either "js-base" or "rum-js", so make that work.

I saw an "opbeans-react" service on a map generated by apm-integration-testing that Gil had running last week. Not sure if that's a newer or older version because I don't see it on apm.elstc.co.

Also clean up the icons storybook a little.

Fixes #62336.

* use isRumAgentName

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 09:08:38 -05:00
Oliver Gupte 30b6d42c42
[APM] Service map - fixes irrelevant services on data refresh (#62750)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 16:06:55 +02:00
Oliver Gupte d565db0dbd
[APM] Service map - Fix taxi edge arrow orientation (#62741)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 16:06:49 +02:00
Dario Gieselaar 6fdd7b4c9b
[APM] Prevent error rate alert trigger from rendering NaN (#62754)
* [APM] Prevent error rate alert trigger from rendering NaN

Closes #62458.

* Use params instead of alertParams
2020-04-07 16:06:13 +02:00
Tim Roes 3a9e7be8bf
[Lens] Remove all legacy imports (#62596)
* Remove all legacy imports

* Fix import
2020-04-07 11:08:54 +02:00
Shahzad 355cacff7c
[Uptime] Improve Telemetry test (#62428)
* removed unnecessary filter

* update condition

* added a unit test for mix state

* fix types

* fix type

* updated test

* update

* updates test

* updates tests

* updates tests

* updated type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 09:19:36 +02:00
MadameSheema 91a0010668
[SIEM] Adds sort rules Cypress test (#62700)
* adds 'singal detection rules' spec

* adds 'Sorts by activated rules' test

* implements 'Sort by activated rules'

* refactors code

* fixes index
2020-04-07 09:19:08 +02:00
Cauê Marcondes 0458626379
fixing bug (#62577) 2020-04-07 09:08:00 +02:00
Nathan Reese 7882e0c3a8
[Maps] Always show current zoom level (#62684)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 21:26:10 -06:00
The SpaceCake Project b65de27458
bc5 siem rules merge (#62679)
* bc5 rule merge

version changes
field changes to endpoint rules
removed max_signals from 7 rules

* Fixing monitoring i18n (#62715)

* Updates esarchiver test data with the latest rules (#62723)

* Remove CR, only CRLF for rules

* delete two files

for Garrett

* deletes

delete 2 files (for Garrett)

* Revert "deletes"

This reverts commit cc2ac1e05f.

* Revert "Fixing monitoring i18n (#62715)"

This reverts commit 028574037a.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Co-authored-by: Ross Wolf <31489089+rw-access@users.noreply.github.com>
2020-04-06 20:45:39 -06:00
spalger f1bd3bdacb Revert "[Monitoring] Cluster state watch to Kibana alerting (#61685)"
This reverts commit ab0cc8894a.
2020-04-06 17:05:09 -07:00
Ahmad Bamieh e16885c3ad
[Telemetry] update crypto packages (#62469)
* update crypto packages

* as type for return value

* get default export

* add if checks

* wrap errors in i18n

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 00:36:15 +03:00
Aaron Caldwell f80925af97
[Maps] Move layers to np maps (#61877)
* Move layers to new location

* Update layer path refs

* Update np kibana services to cover all required services

* Init np kibana services in legacy plugin. Port init functions to np

* Path updates, supporting file moves, general clean up

* More moves of related files and clean-up of legacy refs

* Path updates. Typescript warning fixes

* Update test paths

* Clean up unused kibana services usage in legacy

* Remove unused http ref

* Test fixes and clean up

* Remove unused snapshots

* Add np service init to embeddables too

* Move validate color picker to NP
2020-04-06 14:01:38 -06:00
Garrett Spong 0bdcda8f20
[SIEM] Fixes UX issues around prebuilt ML Rules (#62396)
## Summary

This PR fixes a number of UX issues around the new prebuilt `machine_learning` rules when the user does not have the necessary permissions to manage the backing ML Job. Along with https://github.com/elastic/kibana/pull/62383, this ensures there is adequate information for the user determine if a rule is not working because the backing job is not running (and helping to prevent this from occurring). This also includes some requested copy changes, including:

* Renames `Anomaly Detection`  dropdown to `ML job settings`
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320279-57c5a880-7526-11ea-8350-647cbba263a4.png" />
</p>

* Updates copy in `ML job settings` dropdown
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320473-cc98e280-7526-11ea-8871-e97661ff5f78.png" />
</p>

* Only shows `ML job settings` UI when on `/detections/` routes 
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320401-922f4580-7526-11ea-9f97-0ec06526b273.png" />
</p>


### All Rules Changes

* Disables the `activate switch` if user does not have permission to enable/disable jobs
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320892-d3742500-7527-11ea-90bb-91fd203480bd.png" />
</p>

* Adds warning toast when attempting to activate via bulk actions (if user does not have permission to enable/disable jobs)
<p align="center">
  <img width="300" src="https://user-images.githubusercontent.com/2946766/78321015-1a621a80-7528-11ea-8ab0-f9fef19240f7.png" />
</p>

### Rule Details Changes
* `Machine Learning job` link now links to ML App with table filtered to the relevant job

* Disables the `activate switch` if user does not have permission to enable/disable jobs
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78321277-c277e380-7528-11ea-99e9-034970a5054e.png" />
</p>

### Create/Edit Rule Changes

* If the job selected _is not running_, a warning will be displayed to remind the user to enable the job before running the rule. cc @benskelker @MikePaquette -- this okay copy here?
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78321498-63ff3500-7529-11ea-9b09-a87186cbe0ce.png" />
</p>

Resolves https://github.com/elastic/siem-team/issues/575
Resolves https://github.com/elastic/siem-team/issues/519

### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials 
  - Scheduled time with @benskelker to update docs
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-06 13:44:46 -06:00
MadameSheema 813d6cb796
[SIEM] View signal in default timeline (#62616)
* adds test data

* adds 'View a signal in timeline' test

* implements test

* fixes implementation

* changes view signal for investigate signal
2020-04-06 21:42:43 +02:00
Chris Roberson ab0cc8894a
[Monitoring] Cluster state watch to Kibana alerting (#61685)
* WIP

* Add new alert with tests

* Fix type issues, and disable new alerting for tests

* Fix up the view all alerts view

* Turn off for merging

* Fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 15:31:01 -04:00
patrykkopycinski 0ebfe76b3f
[SIEM][Detection Engine] Fix signals count in Rule notifications (#62311) 2020-04-06 19:26:40 +02:00
Christos Nasikas d67f2220b3
[SIEM][CASE] Configuration page tests (#61093)
* Test ClosureOptionsRadio component

* Test ClosureOptions component

* Test ConnectorsDropdown component

* Test Connectors

* Test FieldMappingRow

* Test FieldMapping

* Create utils functions and refactor to be able to test

* Test Mapping

* Improve tests

* Test ConfigureCases

* Refactor tests

* Fix flacky tests

* Remove snapshots

* Refactor tests

* Test button

* Test reducer

* Move test

* Better structure

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 20:22:46 +03:00
Corey Robertson 6da7c00b5d
Remove the action_value_click action in canvas (#62215)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:49:34 -04:00
Justin Kambic ba446f3900
[Uptime] Default uptime alert type and disable changing type (#62028)
* Default uptime alert type and disable changing type.

* Update functional test to handle new UI flow.

* Fix type error.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:11:25 -04:00
Alison Goryachev f86dac77da
Fix es_ui_shared imports (#62526) 2020-04-06 09:20:29 -04:00
Nathan Reese 102fa1b560
[Maps] clean up IDynamicStyleProperty (#62466)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 07:13:21 -06:00
Shahzad 6a32b457f0
[Uptime] Replace usage of date_histogram with aut_date_histogr… (#59577)
* remove usage of manual date_histogram

* update

* update

* remove unused

* update fixtures

* update snaps

* remove duplicate test

* type

* update test

* update fixtures

* update interface

* updated type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:32:36 +02:00
Mikhail Shustov bdf628d29a
use union of strings instead of enum (#62493)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:31:36 +02:00
Dario Gieselaar ca1d77cc14
[APM] Prevent "For the last" expression from jumping (#62414)
Closes #61063.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:42:17 +02:00
Daniil Suleiman 104b49015e
[NP] Dashboard (#61895)
* Remove absoluteToParsedUrl reference in dashboard

* Remove KibanaParsedUrl from visualize

* Fix tests

* Add tests

* Fix saved dashboard

* Fix empty line after resolving conflicts

* Move dashboard to np

* Move migrations back to legacy

* Make it works

* Other fixes

* Move into application folder

* FIx translations

* Make share & home plugins otional

* FIx kbn url tracking, jest tests

* Import from dashboard_constants in FT

* Fix translations order

* Use getStartServices for start plugin deps

* Path fixes

* i18n fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:11:48 +03:00
Tim Sullivan f1f93d32a4
[Reporting] Use a shim for server config (#62086)
* config shim

* simplify route register calls

* switch to in-sync worker functions

* fix tests

* comment

* fix set up config with defaults

* reduce loc change

* remove test for removed file

* reportingconfigtype

* revert changing executeJobFactory to synchronous

* imports cleanup

* Clean up some awaits

* undo comment

* clean up async

* clean up imports

* add warning logs for config defaults

* Move around some config shim code

* Register routes params take ReportingCore

* usageCollection is an optional dependency
2020-04-03 21:37:54 -07:00
Tim Sullivan a5c3865594
[Reporting] Fix reporting for non-default spaces (#62226)
* [Reporting] Fix URLs in job params when basePath includes namespace suffix

* canvas fix

* cleanup

* update snapshots in tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 20:18:08 -07:00
Devin W. Hurley 7e11961869
[SIEM] [Detection Engine] Remove has manage api keys requireme… (#62446)
Alerting no longer requires the manage_api_keys privilege, so we are removing it from the detection engine code. Fixes #62387

* removes hasManageApiKeys since alerting is using the internal user api calls, manage_api_keys privilege is no longer necessary

* linting error

* fixes types and removes a test for manage api keys

* removes manage api key reducer and updates leftover tests

* moves userHasNoPermissions repeated code into a function in helpers, adds a few test cases, updated references to new function

* fix test title

* remove userHasNoPermissions function and remove tests, replace with just not canUserCRUD

* Revert "remove userHasNoPermissions function and remove tests, replace with just not canUserCRUD"

This reverts commit 93912e7e22.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 20:25:12 -04:00
Nathan Reese a5526c8730
[Maps] Safely handle empty string and invalid strings from EuiColorPicker (#62507)
* [Maps] Safely handle empty string and invalid strings from EuiColorPicker

* move RGBA_0000 to constants
2020-04-03 17:57:53 -06:00
Joel Griffith 9ed69ce9f2
Reporting/bug more blacklisted headers (#62389)
* Adding more blacklisted headers + a starts-with pattern export

* Fixing starts-with pattern export
2020-04-03 15:19:44 -07:00
Ryland Herrick b9ac2ac223
[SIEM] Prevent undefined behavior in our ML popover (#62498)
* Moves enableDataFeed outside of MLPopover

If we accept our dispatch functions, enableDatafeed can be abstracted as
a pure function. The version bound to popover's dispatch functions is
now named 'handleJobStateChange', as that is the callback it's used for.

* Remove unused component state

We no longer deal with jobs in our local state; that's the
responsibility of the useSiemJobs hook

* Prevent user from initiating multiple job installations

When attempting to run a job from the ML Popover, if the job needs to
first be installed, we set the rest of the jobs to be "loading" while
installation is performed.

Without this change, if users are fast enough they can potentially
trigger multiple rule installations, which is undefined behavior and
leads to failures and bad state in our component.

* Remove unused import
2020-04-03 16:52:12 -05:00
Devin W. Hurley 96ac8def87
[SIEM] [Detection Engine] remove all unknowns from all rules t… (#62327)
* remove all unknowns from all rules table props

* update sorting property type remove optional, also remove unnecessary properties we are not using in sorting, rename paginationMemo prop to pagination, remove null from rulesStatuses type as we are defaulting to empty array now

* fixes type mismatch for sorting and rulesStatuses

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 17:35:06 -04:00
Ryland Herrick 30afc9d597
Mark rule run as failure if there was an error (#62383)
While we still let the rule execute in the case of gap errors and
stopped ML jobs, we now mark that execution as a failure instead of a
success.
2020-04-03 15:22:38 -05:00
Frank Hassanabad 85c665acb0
[SIEM][Detection Engine] Fixes export of single rule and the icons
## Summary

Fixes export of single rule and the icons.
* https://github.com/elastic/kibana/issues/62378
* Single export of rules was using the `rule.id` instead of the `rule.rule_id` where now it flips it and works as expected.
* This adds data-test-subj for testing
* This adds jest unit tests to the menu component

Icons Before:
<img width="396" alt="Screen Shot 2020-04-02 at 5 12 43 PM" src="https://user-images.githubusercontent.com/1151048/78315482-5b533280-751a-11ea-8378-d5e106ebd36f.png">

Icons After:
<img width="407" alt="Screen Shot 2020-04-02 at 7 40 28 PM" src="https://user-images.githubusercontent.com/1151048/78315449-3fe82780-751a-11ea-9d16-2f8c2ea22a78.png">

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-03 13:56:54 -06:00
MadameSheema 4cbf6d252b
fixes flakiness (#62406)
* fixes flakiness

* updates 'number of signals' selector

* changes the way we are asserting the text
2020-04-03 21:33:57 +02:00
Ryland Herrick 4b05ac2dee
Ensure rule message do not span multiple lines (#62391)
Because these messages are used for logging, we should ensure they do
not span multiple lines and confuse log parsers. Since the frontend does
not currently display these newlines, anyway, there is no impact to the
UI.
2020-04-03 11:29:02 -05:00
Angela Chuang f7bbf33667
fix persisting note (#62444) 2020-04-03 16:46:22 +01:00
Larry Gregory 37c826229b
Spaces - Migrate to NP Saved Objects Service (#58716)
* use NP saved objects service for type and wrapper registration

* simplifying

* additional testing

* revert snapshot changes

* removing dependency on legacy saved objects service

* consolidate mocks

* fixing imports

* addrress PR feedback

* remove unused docs

* adjust tests for updated corestart contract

* address test flakiness

* address flakiness, part 2

* address test flakiness

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 09:50:06 -04:00
Angela Chuang aab3dffefd
allow null for filterQuery (#62310) 2020-04-03 10:01:25 +01:00
Stacey Gammon bb747abdaf
Switch to embeddable factory interface with optional override (#61165)
* wip

* typescript map embeddable

* More updates

* Address code review comments and update some usages in SIEM and uptime to the new types

* More clean up - carry over some of the SIEM types to maps for render tool tip

* fixes

* fixes

* Address more review comments

* fixes

* fixes

* fix jest test

* Fix visualize embeddable

* fixes after master merge

* Fixes

* Prefix variable with name "custom" to make it more obvious

* Remove layerList from input state

* fixes

* Update src/plugins/dashboard/public/embeddable/dashboard_container_factory.tsx

Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com>

* review updates

* fixes

* update maps readme

Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
2020-04-02 14:27:51 -04:00
Nathan Reese e202fe7aa3
[Maps] remove MapBounds type (#62332) 2020-04-02 11:04:06 -06:00
Shahzad 9a6c17d3da
[Uptime] Convert anomaly Jobs name to lowercase to comply with… (#62293)
* converted ml job name to lower case

* update type
2020-04-02 19:00:34 +02:00
Nathan Reese c8415b6519
[Maps] fix replaceLayerList to handle case where map is not intialized (#62202) 2020-04-02 09:06:57 -06:00
Court Ewing a729b3baef
Remove support for deprecated xpack.telemetry configurations (#51142)
* Remove support for deprecated xpack.telemetry configurations

In 7.5, we moved telemetry to OSS and dropped the xpack prefix for the
telemetry plugin configuration options. We deprecated the usage of the
xpack prefix so any existing usage would trigger a warning at startup.

In 8.0, we remove support for the deprecated xpack prefix configs for
telemetry.

* Move telemetry settings into its own document

* Use external reference instead of anchor

* Update docs/migration/migrate_8_0.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/migration/migrate_8_0.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/settings/telemetry-settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Remove depecrated xpack.telemetry.* config from xpack_main/index.js

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-04-02 15:27:57 +01:00
Andrew Cholakian 4a20567fb7
[Uptime] Remove static constant for index name completely (#62256)
Fixes #62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 09:06:15 -05:00
Victor Martinez 71ff45ad6a
[APM] E2E: install dependencies for vanilla workspaces (#62178) 2020-04-02 14:51:42 +01:00
Mike Côté 02dad02923
Rename some alert types (#61693)
* Rename some alert types

* Use sentence case for remaining changes + fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 07:48:42 -04:00
Marta Bondyra ee3f5309f8
[Lens] fix error for minInterval>computedInterval for XYChart (#61931) 2020-04-02 09:26:23 +02:00
Shahzad df655c9a97
[Uptime] Optimize get latest monitor API (#61820)
* update monitor status API

* update fixture

* fix types

* fix tets

* fix tests
2020-04-02 08:31:32 +02:00
Nathan Reese 467f27b600
[Maps] Separate layer wizards for Clusters and heatmap (#60870)
* [Maps] source registry and register seperate clusters and heat map sources

* split into to registries

* add EMS file source

* add geojson upload layer

* register rest of sources

* i18n changes

* ts lint errors

* fix jest test

* fix pew-pew source

* review feedback

* import registires in plugin so they exist in embeddable

* remove order parameter and move all layer registies into single file

* fix functionalt est

* pass constructor to sourceREgistry instead of factory

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-01 20:21:18 -06:00
Devin W. Hurley cb914d408e
[SIEM] [Detection Engine] Fixes all rules sorting (#62039)
* fixes sorting to what it was in 7.6.1

* removes sortable=true from non-sortable columns, fixes naming of sortable column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render
2020-04-01 16:45:16 -04:00
Xavier Mouligneau b1a39ce23c
[SIEM] CASES Bugs BC2 (#62170)
* fix persistence between filter

* Fix API filtering bug

* Show username if full name is empty

* fix user in avatar

* do not allow push to service now when connector is none

* fix types

* Show errors from actions

* update connector name in configure

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2020-04-01 16:33:51 -04:00
Oliver Gupte 2cdb9d3113
Closes #60173 by turning off client caching for the main service map API call (#62111) 2020-04-01 11:29:58 -07:00
Andrew Goldstein 2cff8b43e4
[SIEM] Restores the _External alert count_ widget's subtitle (#62094)
## [SIEM] Restores the _External alert count_ widget's subtitle

Fixes an issue where the _External alert count_ widget's subtitle, (e.g. `Showing: 47,642,905 external alerts`), didn't render after data is loaded

### Before

![external-alerts-before](https://user-images.githubusercontent.com/4459398/78086038-f3fe7c80-7379-11ea-8291-2ef807349aea.png)

### After

![external-alerts-after](https://user-images.githubusercontent.com/4459398/78086045-fb258a80-7379-11ea-9bc6-338dc3aba482.png)
2020-04-01 11:47:59 -06:00
CJ Cenizal 82e0fd9b3f
Update ILM node attributes blacklist. (#62093)
- Remove 'testattr' because this doesn't seem to be used in production by ES.
- Add 'transform.node' (added via https://github.com/elastic/elasticsearch/pull/52712/files#diff-225cc2c1291b4c60a8c3412a619094e1R147).
2020-04-01 09:29:32 -07:00
Thomas Neirynck 42fbdc182f
[Maps] Highlight selected layer in TOC (#61510) 2020-04-01 09:29:48 -04:00
Frank Hassanabad 086bea5eb6
[SIEM][Detection Engine] Adds release notes link and updates one UI section
## Summary

Based on feed back from two users within our community slack channel of SIEM we are adding a release notes link to the product for when rules are updated.

Also, because new rules can show up we are changing the words of the "Reload X deleted Elastic prebuilt rule" to "Install X Elastic prebuilt rule" as it is misleading to imply the user has deleted rules when really they have either deleted rules or new rules are available to be installed.

The screen shot with the link of "release notes". Previously the link of "release notes" did not exist:

This new link right now goes to:
https://www.elastic.co/guide/en/siem/guide/master/prebuilt-rules.html

where in the link `master` is replaced with the version of the product that is deployed. I think we want to replace that link with a new one which will have release notes of rules for each new version of the rules.   

<img width="688" alt="Screen Shot 2020-03-20 at 2 29 47 PM" src="https://user-images.githubusercontent.com/1151048/77207801-ef0b1480-6abf-11ea-8ad7-771b0f3334d6.png">

Screen shot of the new text for Install Elastic Rules:
<img width="679" alt="Screen Shot 2020-03-20 at 3 20 44 PM" src="https://user-images.githubusercontent.com/1151048/77207875-1b269580-6ac0-11ea-908d-6ec1694df62f.png">

Screen shot of the existing Reload Elastic Rules the above screen shot is replacing:
<img width="817" alt="Screen Shot 2020-03-20 at 2 36 52 PM" src="https://user-images.githubusercontent.com/1151048/77207833-03e7a800-6ac0-11ea-92f8-7bb065775122.png">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
2020-04-01 06:32:41 -06:00
Dario Gieselaar d4fa5edafd
[APM] Ensure telemetry data matches SO/telemetry mapping (#61957)
* [APM] Ensure telemetry data matches SO/telemetry mapping

Closes #61802.

* Correct mapping for dotnet data
2020-04-01 12:39:24 +02:00
Cauê Marcondes 79757651a9
[APM] Filters are not prefilled when the custom link flyout is opened from a transaction page. (#61650)
* open flyout with filters prefilled

* addressing pr comments

* addressing pr comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-01 08:50:06 +02:00
Nathan L Smith 433d06fd16
Don't fetch service map data if no license (#62071)
Fixes #61994
2020-03-31 19:57:30 -05:00
Shahzad 92eab3e8d1
[Uptime] Added func test for obsv location map (#61518)
* add functional test

* update func test

* refactor more changed

* update test

* update test

* update type and test

* fix the fix of fix, which din't get fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-01 00:51:55 +02:00
Justin Kambic 93ad6d42e4
[Uptime] Fix action variables for monitor status alert (#61844)
* Add action variables for monitor status alert.

* Translate action variable descriptions.

* Add state variables to list. Update defaultActionMessage.

* Remove non-literal characters from test names, and update outdated snapshots.
2020-03-31 18:41:17 -04:00
Justin Kambic aa20442a3d
Close create alert popover after the create alert flyout has been selected. (#62036) 2020-03-31 16:56:34 -04:00
Corey Robertson f9fefdd467
[CANVAS] Gets ride of chrome/ui for advanced settings (#61865)
* Gets ride of chrome/ui for advanced settings

* Mock new platform for test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-31 16:43:07 -04:00
MadameSheema 86a70ba963
slows down timeline creation (#62037) 2020-03-31 21:46:32 +02:00
Joel Griffith 12caa46e35
Always log non-200 responses in reportin (#61897)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-31 12:30:47 -07:00
MadameSheema c8b7b55a93
increases default command timeout (#62022) 2020-03-31 21:15:27 +02:00
Nathan L Smith 49e53dac7b
Hide APM alerting menu if alerting plugin is disabled (#61907)
* Hide APM alerting menu if alerting plugin is disabled

Checks for presence of plugin and does not display the link if the plugin is disabled.

Use `xpack.alerting.enabled: false` in config/kibana.dev.yml to try it.

Fixes #61048.
2020-03-31 13:22:36 -05:00
Mike Côté 7d97ead26e
Adding PagerDuty icon to connectors cards (#60805)
* adding PagerDuty icon to connectors cards

* Fix jest

* remove unnecessary global typings from canvas and sync global typings in xpack with oss

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-31 13:41:00 -04:00
MadameSheema 477ce93d17
Fix drag and drop flakiness (#61993)
* increases the time between dragging and dropping an element

* fixes test
2020-03-31 19:11:41 +02:00
Kerry Gallagher 558dd120a1
Grok debugger migration (#60658)
* Migrates Grok Debugger to new platform
2020-03-31 17:54:34 +01:00
The SpaceCake Project 341c787f9c
[SIEM] version 7.7 rule import (#61903)
* rule import

* Update x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/prepackaged_rules/windows_credential_dumping_msbuild.json

Co-Authored-By: Garrett Spong <spong@users.noreply.github.com>

* Update add_prepackaged_rules_schema.ts

* Update rule.ts

* updates 'prebuilt_rules_loaded' data (#61940)

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: MadameSheema <snootchie.boochies@gmail.com>
2020-03-31 10:24:59 -06:00
Matthias Wilhelm 0082ca7ad8
[Discover] Deangularize and euificate sidebar (#47559)
* Split angular templates into React components

* Add tooltip for field label

* Adapt SCSS

* Cleanup angular directives

* Extract helper functions

* Improve tests + docs

* Move css to _sidebar.scss

* Exclude _id field from displaying the Visualize button to prevent an ES error

* A11y improvements
2020-03-31 17:01:44 +02:00
Justin Kambic e8143918e6
Add an onBlur handler for the kuery bar. Only resubmit when input changes. (#61901) 2020-03-31 10:42:50 -04:00
Aaron Caldwell d73671e2b5
[Maps] Explicitly pass fetch function to ems-client (#61846)
* Add fetchFunction binding appropriate version of fetch for ems client

* Wrap standard window fetch prior to passing to ems-client

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-31 08:03:05 -06:00
Christos Nasikas 810cbd2820
[SIEM][CASE] Fix aria-labels and translations (#61670)
* Fix aria-labels and translations

* Fix conflicts and bugs
2020-03-31 16:20:37 +03:00
Dario Gieselaar 08c94bf58b
APM] Set ignore_above to 1024 for telemetry saved object (#61732)
Closes #61546.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-31 14:25:34 +02:00
patrykkopycinski 65e8f2b603
[SIEM][Detection Engine] Allow to edit actions for prepackaged rules (#61312) 2020-03-31 12:54:58 +02:00
Alexey Antonov 1696dd5607
Delete legacy embeddable_api plugin (#61767)
* Delete legacy `embeddable_api` plugin

Closes: #61545

* fix test:karma
2020-03-31 10:33:04 +03:00
Xavier Mouligneau 4083d6682f
[SIEM] Cases clean up Phase II (#61750)
* allow case to work without security

* disable configure button + add call out if license does not match and if kibana config does not allow if

* add skeleton for crud in case

* fix link to timeline + disable action on case on read only + allow read only access to our saved object in siem + manage no x-pack.security + show msg when read-only + fix reporters bug

* add actions required in plugins

* review I

* review II

* review III

* review IV

* fix types

* review V
2020-03-31 00:20:11 -04:00
Nathan Reese 1687e8ef5a
[Maps] convert redux store to TS phase 1 (#61704)
* [Maps] convert redux store to TS phase 1

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-30 21:56:43 -06:00
Patrick Mueller fcefe7d902
[Alerting] add complete alerting/action privs to apm feature (#61159)
Based on a [review comment of a related PR[1], the apm feature definition
has been changed to supply all the alerting/action privs for both read
and all apm privs.

[1] https://github.com/elastic/kibana/pull/61113#pullrequestreview-380544712
2020-03-30 23:27:44 -04:00
Nathan L Smith 5808f86f60
Use docLinks API for APM doc links (#61880)
* Use docLinks API for APM doc links

Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component.

Fixes #56453
Fixes #60945
2020-03-30 18:34:23 -05:00
Ryland Herrick 8b31ce0a89
[SIEM] Check ML Job status on ML Rule execution (#61715)
* Move isMlRule helper to a more general location

And use it during rule execution as well.

* Add error message back to rule error status

This was unintentionally removed in a previous merge commit.

* Expose mlClient as part of ML's Setup contract

This allows dependent plugins to leverage the exposed services without
having to define their own ml paths, e.g. "ml.jobs"

* Move ML Job predicates to common folder

These are pure functions and used on both the client and server.

* WIP: Check ML Job status on ML Rule execution

This works, but unfortunately it pushes this executor function to a
complexity of 25. We're gonna refactor this next.

* Move isMlRule and RuleType to common

These are used on both the frontend and the backend, and can be shared.

* Refactor Signal Rule executor to use RuleStatusService

RuleStatusService holds the logic for updating the current status as
well as adding an error status. It leverages a simple
RuleStatusSavedObjectClient to handle the communication with
SavedObjects.

This removes the need for our specialized 'writeError', 'writeGap', and
'writeSuccess' functions, which duplicated much of the rule status
logic and code. It also fixes a bug with gap failures, with should have
been treated the same as other failures.

NB that an error does not necessarily prevent the rule from running, as
in the case of a gap or an ML Job not running.

This also adds a buildRuleMessage helper to reduce the noise of
generating logs/messages, and to make them more consistent.

* Remove unneeded 'async' keywords

We're not awaiting here, so we can just return the promise.

* Make buildRuleStatusAttributes synchronous

We weren't doing anything async here, and in fact the returning of a
promise was causing a bug when we tried to spread it into our attributes
object.

* Fix incorrectly-named RuleStatus attributes

This mapping could be done within the ruleStatusService, but it
lives outside it for now.

Also renames the object holding these values to the more general
'result,' as creationSuccess implies it always succeeds.

* Move our rule message helpers to a separate file

Adds some tests, as well.

* Refactor how rule status objects interact

Only ruleStatusSavedObjectsClient receives a savedObjectsClient, the
other functions receive the ruleStatusSavedObjectsClient

* pluralizes savedObjects in ruleStatusSavedObjectsClient
* Backfills tests

* Handle adding multiple errors during a single rule execution

We were storing state in our RuleStatusClient, and consequently could
get into a situation where that state did not reflect reality, and we
would incorrectly try to delete a SavedObject that had already been
deleted.

Rather than try to store the _correct_ state in the service, we remove
state entirely and just fetch our statuses on each action.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-30 16:35:38 -05:00
Ryland Herrick 9ff8be602d
[SIEM] 7.7. NP Cleanup (#61713)
* Remove unused legacy services

These were migrated to NP in a previous PR.

* Remove unused legacy request types

* Type our siem client as optional

If a plugin does not have siem enabled, they won't get our client.

While it seems unlikely to be in a situation where our routes are being
hit but our client is unavailable, we will return a 404 in that case,
similar to the unavailability of actions/alerting.

This also removes some redundant checks on action/alerting clients.

* Remove more redundant dependency checks

In general, we use optional chaining to ignore any intermediate null
values, and defer checks to our actual dependencies, e.g. alertsClient
or siemClient.
2020-03-30 15:12:45 -05:00
Steph Milovic 9831c12e1a
[SIEM] [Case] Design fixing (#61681) 2020-03-30 11:31:35 -06:00
Shahzad d1cf0acf3f
[Uptime] Update ML flyout to add cancel button (#61627)
* update button

* fix type

* update snaps

* update layout
2020-03-30 19:28:49 +02:00
Nathan Reese 0070bdcdd5
[Maps] clean-up unsaved state check (#61705)
* [Maps] clean-up unsaved state check (#61535)

* close layer panel in functional test

* skip vector styling test

* skip saved object management test

* skip all of group 7 tests

* turn back on group 7, skip full screen

* turn on all tests except full screen

* unskip all tests and resolve root problem

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-30 11:25:49 -06:00
Christos Nasikas d054fbc7dd
[SIEM][CASE] Add triggers_actions_ui plugin (#61810) 2020-03-30 19:10:47 +03:00
Cauê Marcondes 567f84056b
[APM] Storybook waterfall (#61617)
* creating storybook to test Waterfall

* creating storybook to test Waterfall

* addressing PR comments
2020-03-30 17:41:52 +02:00
Christos Nasikas c679ceb1ba
[SIEM][CASE] Configuration page design fixes (#61772)
* Add toaster

* Better message

* Design fixes
2020-03-30 18:38:15 +03:00
Angela Chuang c0c9d98538
[SIEM] Import timeline schema update (#61622)
* allow users importing data if they are authorized

* rename props

* rename types

* hide import timeline btn if unauthorized

* unit test for TimelinesPageComponent

* update schemas

* update schema

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-30 15:56:16 +01:00
Angela Chuang f21dea11c3
[SIEM] Fix layout issue for open timeline modal (#61786)
* show icon on open timeline modal

* add unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-30 14:32:20 +01:00
Yara Tercero dd77dea216
[SIEM][Detections Engine] - Add rule markdown to timeline global notes (#61026)
[SIEM][Detections Engine] - Add rule markdown to timeline global notes

* added functionality of new global timeline note created on init timeline creation if signal.rule.note exists

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-30 07:58:01 -04:00
Joe Reuter b6101f042a
Graph: Migrate feature registration (#61419) 2020-03-30 11:11:00 +02:00
Daniil Suleiman 84d1bbd7b6
[NP] Remove absoluteToParsedUrl & KibanaParsedUrl ref in kibana app (#61105)
* Remove absoluteToParsedUrl reference in dashboard

* Remove KibanaParsedUrl from visualize

* Fix tests

* Add tests

* Fix saved dashboard

* Fix empty line after resolving conflicts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-30 11:51:29 +03:00
Christos Nasikas 808dc855c6
[SIEM][CASE] Add missing AbortController to API calls (#61426) 2020-03-28 19:04:52 +02:00
Nathan Reese fdcbb19a3f
[Maps] fix tooltip overflow (#61564)
* [Maps] fix tooltip overflow

* update jest snapshots

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-27 17:20:53 -06:00
spalger 4c18199208 Revert "[Maps] clean-up unsaved state check (#61535)"
This reverts commit 30bdfeda6c.
2020-03-27 13:54:45 -07:00
Nathan L Smith a9a9776b39
Replace APM agent "Active" setting with "Recording" (#61538)
Also change "APM server" to "APM Server"

Fixes #61179.
2020-03-27 12:40:55 -05:00
Steph Milovic bec4e33651
[SIEM] [Cases] Fix comments and user (#61642) 2020-03-27 11:25:48 -06:00
Nathan Reese 30bdfeda6c
[Maps] clean-up unsaved state check (#61535) 2020-03-27 11:03:57 -06:00
Justin Kambic 1da53ed23b
[Uptime] Fix PingList pagination (#61481)
* Add pagination.

* Update test files.
2020-03-27 12:50:49 -04:00
Oliver Gupte 5afb573736
Closes #61291 by debouncing service map hover metric events tracking (#61561) 2020-03-27 09:30:16 -07:00
Mikhail Shustov ab39ceba8f
Serve static assets from NP (#60490)
* add hapi.inert plugin to NP

* update tests

* move serving static assets

* update tests

* add functional tests

* fix type errors. Hapi.Request doesn't support typings for payload

* update docs

* remove comment

* move assets to NP

* update all assets references

* address Spencer's comments

* move ui settings migration to migration examples

* document legacy plugin spec

* move platform assets test to integration_tests

* address Spencer's comment p.2

* try to fix type errors

* fix merge commit

* update tests
2020-03-27 14:24:28 +01:00
Peter Pisljar 7b0c66f7f1
move visualizations plugin to new platform (#60403) 2020-03-27 13:02:06 +01:00
Jean-Louis Leysens 3373bb8613
[Grokdebugger] Fix grokdebugger simulate call in non-default s… (#61423) 2020-03-27 11:35:22 +01:00
Christos Nasikas 5b8de94616
[SIEM][CASE] Improve connector flyout (#61450)
* Disable action types

* Disable autofill

* Warn user on edit flyout about empty secrets

* Change column name

* Disable field mapping
2020-03-27 11:03:59 +02:00
MadameSheema 55ed873f32
[SIEM] Adds 'Delete custom rules' tests (#61495)
* adds test data

* implements 'Deletes one rule' test

* adds new data

* fixes 'Deletes one rule' for the new data

* adds 'Deletes more than one rule' test
2020-03-27 09:34:14 +01:00
Xavier Mouligneau 327f5a099a
[SIEM] [CASES] bug/clean up phase I (#61354)
* clean up comments + add update_by/update_at  case when comment are added/updated + return all comments

* add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page

* fix i18m

* review I

* review II
2020-03-26 20:09:58 -04:00
Nathan Reese 3431697a3a
[Maps] add functional test for category autocomplete (#61386)
* [Maps] add functional test for category autocomplete

* remove duplicated method
2020-03-26 16:26:26 -06:00
Stacey Gammon 65452bddf9
Typescript map embeddable (#61264)
* typescript map embeddable

* Address code review comments and update some usages in SIEM and uptime to the new types

* More clean up - carry over some of the SIEM types to maps for render tool tip

* Address more review comments
2020-03-26 16:14:23 -04:00
Angela Chuang 36a4944f0c
[SIEM] Allow Import timeline for authorised users (#61438)
* allow users importing data if they are authorized

* rename props

* rename types

* hide import timeline btn if unauthorized
2020-03-26 19:54:33 +00:00
Marta Bondyra 25221f7675
[Lens] Fix display single bar in XYChart Bar Vis (#61452) 2020-03-26 19:32:24 +01:00
Pierre Gayvallet 7ab38ff6de
Migrate savedObjectManagementActionRegistry to NP plugin (#60481)
* create empty plugin + move home feature registration to it

* move the so action_registry to new plugin

* adapt existing calls to the registry

* fix i18n namespace

* fix table unit tests

* update codeowners

* rename plugin to match other PRs

* remove registerLegacyAPI from spaces public plugin

* fix typo

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-26 17:25:27 +01:00
Christos Nasikas 933b6ee996
[SIEM][CASE] Track unsaved changes (#60925)
* Hide bottom bar when flyout is open

* Track unchanged saves

* Make function optional

* Show action bar when close flyout

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-26 14:17:55 +02:00
Cauê Marcondes a16d446492
[APM] Link preview breaks when editing a custom link (#61053)
* refactoring custom link server side

* refactoring custom link server side

* fixing pr comments

* fixing unit test

* fixing unit tests

* renaming server directory

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-26 11:49:41 +01:00
MadameSheema 01e3cc307e
[SIEM] Adds 'Deleting prebuilt rules' tests (#61328)
* implements 'Deleting prebuilt rules' tests

* refactors code

* extracts the number of prebuilt riles to a constant that can be used in any test
2020-03-26 11:34:28 +01:00
MadameSheema 4b4c5bca2d
increases timeouts (#61229)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-26 09:19:10 +01:00
Ryland Herrick 9243b6de28
Check auth status via security plugin on our privileges endpoint (#61334)
* Accounts for security being disabled, adds tests
* Updates other auth-aware endpoints (import timeline, graphql) to
account for security being disabled.
2020-03-25 19:08:29 -05:00
Nathan L Smith 43d95da464
Make global service map zoom toward center (#61340)
* Make global service map zoom toward center

Calculate the center of the graph when there's not a primary node.

Also update to latest version of types.

Fixes #61176.

* Fix types
2020-03-25 18:24:15 -05:00
Andrew Cholakian 5c5c98f0e7
[Uptime] Various Settings Fixes (#61007)
Fixes behavior in chrome where using the enter key to submit the settings form would reload the page. Fixes #61006

Fixes test failures in uptime settings tests by waiting until form data is loaded: https://kibana-ci.elastic.co/job/elastic+kibana+master/3882/https:/

Sample failure:

{ Error: expected { heartbeatIndices: '' } to sort of equal { heartbeatIndices: 'heartbeat-8*' }
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js💯11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/functional/apps/uptime/settings.ts:31:25)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  actual: '{\n  "heartbeatIndices": ""\n}',
  expected: '{\n  "heartbeatIndices": "heartbeat-8*"\n}',
  showDiff: true }

Re-enables location tests failure, which should have been fixed by https://github.com/elastic/kibana/pull/60573/files#diff-7198f3de6fe631f903e590f63bc88e21R20
2020-03-25 17:58:07 -05:00
Frank Hassanabad 33511b3879
[SIEM] Add developer optimization scripts for their environments
## Summary

This adds an optimization script very copied and slightly modified from:
* https://github.com/elastic/kibana/pull/49868

Usage:

Run this to do an dev tsconfig optimization:
```ts
node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig
```

Run this to undo the optimization:
```ts
node x-pack/legacy/plugins/siem/scripts/unoptimize_tsconfig
```

Testing and what this does:

Run this:
```ts
node x-pack/legacy/plugins/siem/scripts/optimize_tsconfig
```

Then run your start-test-all or at least your linter, typescript check, and jest tests to make sure they all operate as expected. Restart your IDE and ensure everything works as expected.

Run `git status` and ensure it looks like no new files want to be checked in.

Open up your:
```ts
kibana/x-pack/tsconfig.json
```

And notice it is now changed when optimization has run to use a smaller set of includes.

Open up your:
```ts
kibana/tsconfig.json
```

And notice it is now changed when optimization is run to use a smaller set of includes.
2020-03-25 16:30:53 -06:00
Dario Gieselaar d87cb9489f
[APM] Explicit telemetry mappings (#61266)
Replaces generic object type mappings with explicitly defined properties. These were probably unmapped because the sample data for some agents does not have these fields.
2020-03-25 22:07:45 +01:00
Poff Poffenberger a16968dd3a
[Canvas] Fix map embeddables not showing up on PDF reports (#61149)
* Allow embeddables to track their own render complete for report generation in canvas

* Updating following consult with reporting team

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-25 14:54:32 -05:00
Nathan Reese 4c70ef54a7
descriptors to descriptor_types (#61290)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-25 13:42:50 -06:00
Tim Roes b8e3ccb356
Move lens saved object setup to Kibana platform (#61157) 2020-03-25 17:56:49 +01:00
Tim Schnell 46e495ff8a
Limit rows in debug element (#60804)
* limiting the number of rows displayed in debug element to 100

* updating function and typescripting

* adding debug tests
2020-03-25 11:27:03 -05:00
Joe Reuter d170b37b8f
Shim getFormat function correctly (#60032) 2020-03-25 16:16:11 +01:00
Aaron Caldwell f5da5bc6d6
Fix typo: autocompleteService -> autocomplete (#61186) 2020-03-25 07:23:25 -06:00
MadameSheema 5b706ee372
[SIEM] Adds 'Create ML rule' Cypress test (#61059)
* splits signal detection rules tests in different spec files

* implements 'creates and activates a new ml rule'

* refactors code

* updates 'select_rule_type' data-test-subj selectors

* Refactor JobStatusBadge

I'm adding a data-test-subj and it seems silly to define it in two
branches.

* Update ML Rule cypress tests

* Updates the test now that the Rule Details have changed
* Adds an additional assertion on the new JobStatusBadge

* keeps code consistency

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
2020-03-25 11:11:03 +01:00
Katrin Freihofner 6c3fa6bd43
fix/uptime-alert-icon (#60750)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-25 08:24:46 +01:00
Søren Louv-Jansen 488b9e2648
[APM] Improve e2e runner (#61163) 2020-03-25 07:09:28 +01:00
Devin W. Hurley 411959fc47
fix type check failure on master (#61204) 2020-03-25 01:52:06 -04:00
Steph Milovic 1e3c5b1f87
[SIEM] [Cases] Final case features for 7.7 (#61161) 2020-03-24 23:39:46 -06:00
Devin W. Hurley 96852249e8
[SIEM] [Detection Engine] Rule activity monitoring (#60816)
* backend rule monitoring with gap desc, last look back date, and time duration of search after and bulk create operations

* adds new properties to mocked request_response status saved object

* first pass at UI table

* migrate rule monitoring backend to work with refactor of rule executor, fix some formatting stuff on the frontend, update the mapping for gap to be a string instead of a float

* trying to write a test for rules statuses hook

* fixed hooks tests

* fixes merge conflicts from rebase with master

* add columns for indexing and query time lapse

* i18n

* i18n for tabs

* don't change the mappings in ml es_archives

* remove accidental commit of interval change for shell script detection engine rule

* removes inline object from prop

* fix merge conflicts

* backend changes from pr comments

* updates ui changes from pr feedback

* fix tests and add formatting for dates

* remove null from rulesStatuses initial state and replace with empty array
2020-03-24 23:49:08 -04:00
Nathan Reese 29a3f55985
[Maps] clean up icon category UI (#61116)
* [Maps] clean up icon category UI

* fix jest tests

* add unit test for getFirstUnusedSymbol

* remove duplicate icon stop values

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-24 21:24:37 -06:00
Ryland Herrick 683bf3a72e
[SIEM] ML Rules Details (#61182)
* Add basic help text to ML Job dropdown on Rule form

* Use EUI's preferred layout for form fields

* Add a link to ML in the Job select help text

* Restrict timeline picker to EUI guidelines

Don't display the row as fullwidth, lest the help text wrap across the
entire page. It only looks okay now because it was a short sentence;
adding the ML Job select with its wrapped text caused some visual
weirdness, so this at least makes it consistent.

* Add placeholder option to ML Job dropdown

* Humanize rule type on Rule Description component

This is displayed both on the readonly form view, and the Rule Details
page.

* Add useMlCapabilities hook

This is a base hook that we can combine with our permissions helpers.

* Restrict ML Rule creation to ML Admins

If we're auto-activating jobs on their behalf, they'll need to be an
admin.

* Extract ML Job status helpers to separate file

* WIP: Enrich Rule Description with ML Job Data

This adds the auditMessage as well as a link to ML; actual status is
next

* Display job status as a badge on Rule Details

Also simplifies the layout of these job details.

* Port helper tests to new location

* Fix DescriptionStep tests now that they use useSiemJobs

UseSiemJobs uses uiSettings, so we need to use our kibana mocks here.

* Fix responsiveness of ML Rule Details

The long job names were causing the panel to overflow.
2020-03-24 21:39:07 -05:00
Angela Chuang 2ad68f0e98
[SIEM] Import timeline (#60880)
* add import timelines route

* update timeline

* sync with master

* wip

* wip

* update timeline

* overwrite pinned events

* clean up

* init server side unit test

* add server side unit test

* clean up unit test

* unit test

* add unit tests

* clean up

* clean up

* fix unit test

* fix types and unit tests

* rename constants

* fix validation schemas

* review

* fix schemas

* functional test

* skip a functinal test

* add unit tests

* code review

* review with angela

* fix tests

* update modal label

* rename folder to align component name

* fix types

* fix unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
2020-03-24 20:20:40 -04:00
Oliver Gupte f9ad60d490
Renames apm metric event 'service_map_object_hover' to 'service_map_node_or_edge_hover' for more clarity (#61178) 2020-03-24 16:55:05 -07:00
patrykkopycinski f9d37b392a
[SIEM] Add rule notifications (#59004)
## Summary

Allow defining notifications that will trigger whenever the rule created new signals.

Requires:
- https://github.com/elastic/kibana/pull/58395
- https://github.com/elastic/kibana/pull/58964
- https://github.com/elastic/kibana/pull/60832


![Screenshot 2020-03-02 at 10 19 18](https://user-images.githubusercontent.com/5188868/75662390-4fe8bf00-5c6f-11ea-943f-591367348b91.png)

![Screenshot 2020-03-02 at 10 13 00](https://user-images.githubusercontent.com/5188868/75662421-5e36db00-5c6f-11ea-9317-d158cddf4344.png)


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)
- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-03-24 17:49:10 -06:00
Shahzad 2443827579
[Uptime] Feature/enhance telemetry Phase 1 (#61062)
* add telemetry

* update telemetry

* update telemetry

* update types

* fix issue when no data

* use dynamic settings in telemtry

* fix type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-25 00:05:57 +01:00
Ryland Herrick 64a5734439
[SIEM] Add license checks for ML Rules on the backend (#61023)
* WIP: Check license on simple rule creation

We'll add this to the rest of the routes momentarily.

* Add license checks around all rule-modifying endpoints

This ensures that you cannot create nor update an ML Rule if your
license is not Platinum (or Trial).

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-24 16:49:35 -05:00
Nick Peihl 72afbbbd72
[Maps] Fix cross origin error for icon spritesheets when Kibana secured via OAuth proxy (#53896)
* Set crossOrigin to anonymous only on requests from external hosts

* Update x-pack/legacy/plugins/maps/public/connected_components/map/mb/utils.js

Co-Authored-By: Joe Portner <5295965+jportner@users.noreply.github.com>

* 🙇‍♂️ Lint

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-24 14:30:44 -07:00
Oliver Gupte 36285d62b6
Closes #60754 by removing uiFilters from the API route for service map (#61012)
since it is unused.
2020-03-24 13:56:08 -07:00
Corey Robertson 17db8a66b3
[Canvas] Visualize embeddable (#60859)
* Enables Visualize Embeddable

* Fix i18n

* Fix tests

* Remove unused import
2020-03-24 16:04:43 -04:00
Oliver Gupte 693e74b1ca
[APM] Service map - add page load and interaction telemetry (#61009)
* Closes #60527 by adding called to shared observability usage tracking
function when service map page is loaded, and if the user interacts with
it

* trigger usage tracking on specific cytoscape events: node select, object hover
2020-03-24 12:53:31 -07:00
Wylie Conlon 2f1e689c91
[Lens] Create filters on click with bar, line, area charts (#57261) 2020-03-24 20:51:00 +01:00
Søren Louv-Jansen 0fc0440cdc
[APM] E2E: Zero config for running e2e locally (#59152) 2020-03-24 20:28:11 +01:00
Gidi Meir Morris 18793dbc6c
[Alerting] notifies user when security is enabled but TLS is not (#60270)
This PR:
1. Adds a callout on the Alerting UI when security is enabled but TLS is not
2. Cleans up displayed error message when creation fails due to TLS being switched off
2020-03-24 19:15:27 +00:00
Joel Griffith 427848c3be
Revert "[Reporting/New Platform Migration] Use a new config service on server-side (#55882)" (#61075)
This reverts commit 5755b2ac52.
2020-03-24 09:07:39 -07:00
Nathan Reese e55ee76b26
[Maps] convert layer utils to TS (#60791)
* [Maps] convert layer utils to TS

* clean up

* renovate changes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-24 09:38:00 -06:00
Larry Gregory b82cc6ed4a
Support for sub-feature privileges (#60563)
* initial server-side support for sub-feature privileges (#57507)

* initial server-side support for sub-feature privileges

* start addressing PR feedback

* renaming interfaces

* move privilege id collision check to security plugin

* additional testing

* change featurePrivilegeIterator import location

* fix link assertions following rebase from master

* Initial UI support for sub-feature privileges (#59198)

* Initial UI support for sub-feature privileges

* Address PR feedback

* display deleted spaces correctly in the privilege summary

* additional testing

* update snapshot

* Enables sub-feature privileges for gold+ licenses (#59750)

* enables sub-feature privileges for gold+ licenses

* Address PR feedback

* address platform review feedback
2020-03-24 11:12:49 -04:00
Wylie Conlon 6d2aa8974d
[Lens] Fix bug in metric config panel (#60982)
* [Lens] Fix bug in metric config panel

* Fix test
2020-03-24 10:43:48 -04:00
patrykkopycinski 2106b69219
[SIEM][Detection Engine] Add rule's notification alert type (#60832) 2020-03-24 14:26:24 +01:00
Dario Gieselaar 6bd8755df4
[APM] Re-revert "Collect telemetry about data/API performance" (#61030)
* Revert "Revert "[APM] Collect telemetry about data/API performance (#51612)""

This reverts commit 6de7f2a62b.

* Update transaction mock data to reflect the type
2020-03-24 13:38:15 +01:00
Shahzad d31e5f524f
[Uptime] Ml detection of duration anomalies (#59785)
* add flyout

* add state

* update state

* ad job

* update

* updat

* add ml analyze button

* update api

* use differential colors for duration chart

* remove duration chart gql

* update type

* type fix

* fix tyoe

* update translation

* update test

* update conflicts

* update anomaly record

* chart

* added annotations

* update error handling

* update

* update types

* fixed types

* fix types

* update types

* update

* update

* remove unnecessary change

* remove unnecessary change

* fix type

* update

* save

* update pr

* update tets

* update job deletion

* update

* update tets

* upadte tests

* fix types

* update title text

* update types

* fixed tests

* update tests and types

* updated types

* fix PR feedback

* unit test

* update more types

* update test and manage  job

* resolve conflicts

* types

* remove unnecessary change

* revert ml code

* revert ml code

* fixed formatting issues pointed by pr feedback
2020-03-24 12:34:43 +01:00