Commit graph

30097 commits

Author SHA1 Message Date
Zacqary Adam Xeper 8edb53ddbc
[Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage (#49781)
* [Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage

* Split settings pages in two; add loading screen to settings page

* Restore timestamp field to metrics screen

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-08 13:46:01 -06:00
Corey Robertson 89e4daf5bd
[Canvas] Fixes bugs with autoplay and refresh (#53149)
* Fixes bugs with autoplay and refresh

* Fix typecheck

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-08 14:16:31 -05:00
Melissa Alvarez fc948a0c8e
[ML] DF Analytics Classification: ensure confusion matrix can be fetched (#53629)
* check depVar field type before adding keyword suffix for evaluate endpoint

* update indexPattern type and use FIELD types

* add keyword suffix if field type is keyword

* keyword suffix added if depVar is of type keyword AND text
2020-01-08 13:38:34 -05:00
Tim Roes 7ffe38569e
Fix Vega react eslint errors (#54259) 2020-01-08 18:19:20 +01:00
Tim Roes 53d1c96a4a
Remove non existing codeowners (#54274)
* Remove non existing codeowners

* Add TSVB to Kibana App codeowners
2020-01-08 18:10:26 +01:00
Mikhail Shustov 26a4ec4117
use correct type (#54244) 2020-01-08 19:46:10 +03:00
Maja Grubic bc640bdcba
[Dashboard] Removing 100% as dshDashboardViewport height (#54263) 2020-01-08 16:26:56 +00:00
Anton Dosov 513428af44
add examples/ to no-restricted-path config (#54252) 2020-01-08 19:20:07 +03:00
gchaps 1ffd30eb85
[DOCS][Spaces] Adds example of of using default route setting (#54201)
* Added defaultRoute examples

Added `Examples: /app/monitoring, /app/ml, /app/kibana#/dashboards`

* [DOCS] Adds default route example to Spaces docs

Co-authored-by: ErnestoBezanilla <ErnestoBezanilla@users.noreply.github.com>
2020-01-08 08:08:51 -08:00
patrykkopycinski 8e0e4948d5
[SIEM] Fix columns in timeline do not resize (#51816) 2020-01-08 16:33:51 +01:00
Aleh Zasypkin 63ac99b3aa
Re-enable OIDC API integration test. (#54111) 2020-01-08 15:59:06 +01:00
Justin Kambic a93c23cd56 Reorganize structure of component render to avoid errors. (#54251) 2020-01-08 15:53:49 +01:00
Court Ewing 16b217a11b
[DOCS] consolidate telemetry settings to core (#52634)
* docs: consolidate telemetry settings to core

Telemetry is no longer part of monitoring.

* docs: revise telemetry settings text

* docs: tweak telemetry setting text
2020-01-08 09:32:58 -05:00
Aaron Caldwell 683c138798
Add file upload to telemetry integration tests (#53539)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-08 07:26:54 -07:00
Xavier Mouligneau 6abfbd1382
filters are back (#54218) 2020-01-08 08:58:44 -05:00
Tim Roes fdea7b048d
Add explanation of path.data to contribution guide (#54235)
* Add explanation of path.data to contribution guide

* Change title slightly
2020-01-08 14:53:58 +01:00
Tim Schnell 3b5a90b51c
fix ecommerce percentages in sample data (#54200) 2020-01-08 07:41:52 -06:00
Ahmad Bamieh 392e62a4de
[Telemetry] Fix license page crashing on telemetry.enabled: fa… (#54174) 2020-01-08 13:31:07 +02:00
Alexey Antonov 71ff2de7e1
[ui/public/utils] Copy rarely used items to where they are consumed (#53819)
* [ui/public/utils] Copy rarely used items to where they are consumed

Closes: #52841

* sort_prefix_first 👉x-pack/legacy/plugins/kuery_autocomplete

* numeric 👉src/legacy/core_plugins/kibana/public/management

* diff_object + tests 👉ui/state_management

* function + tests 👉ui/state_management (function.js was removed!)

* key_map 👉ui/directives

* leastCommonMultiple 👉ui/vis

* string_utils 👉ui/saved_objects

* collection

* parse_interval

* it -> test

* fix CI

* fix PR comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-08 13:15:54 +03:00
Mikhail Shustov 007ea5fc46
set AppArch team as an owner of the search endpoints (#54131) 2020-01-08 12:18:55 +03:00
Mikhail Shustov 56041f03ad
Don't expose Elasticsearch client as Observable (#53824)
* expose ES clients without observables

* expose observable-less api to plugins

* update core api and mocks

* update plugins

* NP SO & legacy use updated API

* update SO tests

* update TSDocs

* update types

* update docs

* document createCluster analog in np

* typo
2020-01-08 12:01:47 +03:00
patrykkopycinski 8eb000d629
[SIEM] Cleanup unnecessary use of enzyme-to-json (#53980) 2020-01-08 09:28:38 +01:00
Joe Reuter b7284ca627
fix ui exports doc (#54138) 2020-01-08 09:18:35 +01:00
Ryan Keairns 0d11ec7729
change markdown element title (#54194) 2020-01-07 17:26:36 -06:00
Zacqary Adam Xeper f5448bd9f4
[Logs UI] Refactor log position to hooks (#53540)
* Move URL state to hook

* Fix log filter URL state infinite loop

* Initial refactor of log position to hooks

* Simplify and reimplement controlsShouldDisplayTargetPosition

* Fix live streaming

* Flatten logposition destructuring

* Revert "Move URL state to hook"

This reverts commit 4e04aa061d.

# Conflicts:
#	x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx
#	x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx

* Fix unused imports

* Fix link-to test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 16:38:25 -06:00
Ryland Herrick b7a534b1b1
[SIEM] Implement NP Plugin Setup (#54030)
* Set up our react app in the NP way

* Defines the setup() method for our UI plugin
* Renders the app in the NP way within our setup() method
* Defines a legacy file that invokes the plugin manually

Things seem to be mostly working; the app mounts with no immediate
errors, at least.

* Move files into NP structure

Our plugin function and class are both direct children of siem/public.
The app folder contains both our React app and the function to render
it.

* Register SIEM in the feature catalogue via NP format

Unfortunately, this can't live in the plugin for now because it doesn't
get invoked when we need it. For now, it's going to live in the same
spot, and once we're a real NP plugin we can move it.

* Eliminate usage of timezoneBrowser UI setting

This seems to be redundant with dateFormat:tz except that it always
returns a real timezone, not just a preference. By wrapping that logic
in our own hook, useTimeZone, we can remove this weird usage and stick
to the standard dateFormat and dateFormat:tz.

* Clean up tests for FormattedDate components

Mocks our simpler wrapping hooks rather than the entire UI Settings
module.

* Remove remaining uses of UI Settings mocks

These remaining tests can mock settings directly, or otherwise were
misusing the settings mocks to retrieve assertion values.

* Remove unnecessary intermediate `describe` blocks

They were not adding any information to the tests.

* Remove use of kibana version in client requests

We were previously passing this version all over the place for the sake
of our framework-specific request header. The sole advantage of supplying
such a header is that the client will receive an informative error modal
in the case of a version mismatch between the client and server.

We can successfully perform these requests with the `kbn-xsrf` header
instead. Long-term, we can use core.http.fetch to perform the requests
and auto-populate the version header, but it would be nicer to abstract
those requests to the framework level rather than threading the HTTP
client throughout the application.

* Remove newly added uses of kbnVersion

These happened on master in the meantime.

* Use helper to generate test assertion

Allows us to change the implementation of the empty string without
breaking the test.

* Remove guard from date formatting component

We're always going to get back usable values from these hooks; while the
user can unset the dateFormat in their settings, we'll still get an
empty string which is effectively the same as no formatting (as
evidenced in the tests).

* Remove default from byte formatting component

If the user has deleted this default, they presumably meant to do so and
we shouldn't supersede it.

* Refactor bytes formatting to allow use in our charts

We need a formatting function to use with our charts, so this splits out
a hook from the original react component, allowing our charts to be
formatted as specified in the user's UI settings.

* Refer to our constant for APP_ID

* Explicit return values for some UI Settings hooks

This forces accidental changes to the return value to be explicit.

* Remove use of ui/chrome in request header

This is an unnecessary use: kibana works the same no matter what
contents the `kbn-xsrf` header contains (as long as it's there).

* Mock UI Settings values in our TestProvider

When using our TestProvider components, we were previously relying on
platform's UISettings mocks instead of our own, more comprehensive ones.
This worked for the most part, and when we needed real settings we would
mock the UI Settings client manually.

When we removed some app code that defaulted UI Settings values when the
client did not return a value, tests that used TestProviders but also
relied on those defaults broke. This adds that behavior back,
and obviates the need for manual calls to jest.mock except when we're a)
not using TestProviders but b) overriding the platform mocks.

Also removes some of those unneeded uses.

* Remove unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 13:20:57 -08:00
Lisa Cawley ae1fac4fe5
[DOCS] Updates ML links (#53613) 2020-01-07 13:07:24 -08:00
spalger af52b29394 sort renovate packages in config 2020-01-07 12:53:54 -07:00
Larry Gregory 03ec7af044
Spaces - fix flakey api tests (#54154)
* adding terms query

* run x-pack-ciGroup8 44 times

* Revert "run x-pack-ciGroup8 44 times"

This reverts commit 7d10217c2b.
2020-01-07 14:50:02 -05:00
Justin Kambic 7b33fd318c
Remove dependency that was causing effect to re-execute infinitely. (#54160) 2020-01-07 14:20:02 -05:00
Spencer 9eb0c77318
[dev/run] expose unexpected flags as more than just names (#54080) 2020-01-07 11:56:08 -07:00
gchaps 057632758b
[DOCS] Moves index pattern doc to Discover (#53347)
* [DOCS] Moves index pattern doc to Discover

* [DOCS] Improves intro to index patterns doc

* [DOCS] Edits index patterns doc

* [DOCS] Incorporates comments into index patterns doc

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 10:43:40 -08:00
patrykkopycinski 0308c9d8ca
[SIEM] Cleanup React imports (#53981) 2020-01-07 19:30:37 +01:00
renovate[bot] 49d6a45788 Update eslint related packages (#54107) 2020-01-07 19:08:36 +01:00
Shahzad 334dff37d4
[Uptime] Added date range filter into expanded list query (#52609)
* added filters into expanded list query

* update filters

* update query

* update snap

* update tests

* update filters

* update test

* remove side effect

* ignore typcehck

* update to remove location filter from query

* update filter groups

* remove code

* update test
2020-01-07 18:47:00 +01:00
patrykkopycinski 23a0513469
[SIEM] Add react/display-name eslint rule (#53107) 2020-01-07 18:05:04 +01:00
patrykkopycinski 677670b929
[SIEM] Enable eslint prefer-template rule (#53983)
* [SIEM] Enable eslint prefer-template rule

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 18:02:32 +01:00
Brian Seeders 4b6c2f84e1
Elasticsearch snapshots automation (#53706) 2020-01-07 11:50:08 -05:00
patrykkopycinski 6e1328b9f0
[SIEM] Enable eslint react/no-children-prop (#53985) 2020-01-07 17:46:56 +01:00
gchaps 91173525c3
[DOCS][Reporting] Adds info about using a custom reporting index (#54052)
* [DOCS][Reporting] Adds info about using a custom reporting index

* [DOCS] Incorporates edits into reporting security doc
2020-01-07 08:37:58 -08:00
Maja Grubic cca454f7aa
Changing background color to align with EUI color (#54060)
* Changing background color to align with EUI color

* Removing background-color from theme
2020-01-07 16:36:18 +00:00
Chris Roberson 28b6efa260
Fix linting issues (#54068)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 11:31:15 -05:00
Joe Reuter c02531a494
NP Migration: Move doc views registry and existing doc views into discover plugin (#53465) 2020-01-07 16:53:16 +01:00
Melissa Alvarez 865462a259
[ML] DF Analytics job creation: Add 'excludes' input field to form (#53856)
* Add exclude fields input to df analytics creation form

* rename explain api endpoint to general explainDataFrameAnalytics

* wip: use explain api for exclude fields

* show error message if classification depVar has cardinality of > 2

* update types

* updates after conflict resolution

* prevent creation if more than 2 distinct classes for class job. create form field validation file
2020-01-07 10:46:32 -05:00
nnamdifrankie 6a2fb61ae5
EMT-issue-65: add endpoint list api (#53861)
add endpoint list api
2020-01-07 09:59:11 -05:00
patrykkopycinski f46e8e2f0b
[SIEM] Fix doubled drag handles in Timeline (#52679) 2020-01-07 15:56:13 +01:00
Dmitry Lemeshko a1176b0e4a
Functional tests: refactor visualize_page (#53845)
* add new POs and services

* split visualize_page

* refactor PO and tests

* lost changes

* more fixes

* fix tslint error

* refactor POs

* add vega_chart_page, refactor

* review fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 15:42:20 +01:00
Maja Grubic ab76ee5a58
[Dashboard] Redesign empty screen in readonly mode (#54073)
* [Dashboard] Make empty screen nicer in readonly mode

* Adding contact-the-owner part

* Updating text
2020-01-07 14:41:02 +00:00
Dima Arnautov 8ac233f303
[ML] Support search for partitions on Single Metric Viewer (#53879)
* [ML] agg for partition field values

* [ML] change api

* [ML] load entity values

* [ML] check for partition field names

* [ML] wip

* [ML] refactor api

* [ML] debounce input

* [ML] remove Record, improve types, fix typo

* [ML] jobId as dedicated param, jsdoc comments

* [ML] result_type term based on model plot config

* [ML] remove redundant criteria for job id

* [ML] refactor getPartitionFieldsValues to TS

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 06:14:32 -08:00
Silvia Mitter 825748ea0c
update apm index pattern (#54095)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-07 14:57:43 +01:00